]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathHull.cpp
Assure correct spacing of colored items in mathed
[lyx.git] / src / mathed / InsetMathHull.cpp
index 06368ac4906c9c0976210ec3233ec516d0be0e53..d0e11fe2ab1118b9b4401ac8f1eb91f460c1bce9 100644 (file)
 #include "InsetMathMacro.h"
 #include "InsetMathMacroTemplate.h"
 #include "MetricsInfo.h"
-#include "output_xhtml.h"
+#include "xml.h"
 #include "Paragraph.h"
 #include "ParIterator.h"
-#include "sgml.h"
+#include "xml.h"
 #include "TexRow.h"
 #include "TextClass.h"
 #include "TextPainter.h"
@@ -123,13 +123,10 @@ namespace {
        // writes a preamble for underlined or struck out math display
        void writeMathdisplayPreamble(WriteStream & os)
        {
-               if (os.strikeoutMath()) {
-                       if (os.ulemCmd() == WriteStream::UNDERLINE)
-                               os << "\\raisebox{-\\belowdisplayshortskip}{"
-                                     "\\lyxmathsout{\\parbox[b]{\\linewidth}{";
-                       else
-                               os << "\\lyxmathsout{\\parbox{\\linewidth}{";
-               } else if (os.ulemCmd() == WriteStream::UNDERLINE)
+               if (os.strikeoutMath())
+                       return;
+
+               if (os.ulemCmd() == WriteStream::UNDERLINE)
                        os << "\\raisebox{-\\belowdisplayshortskip}{"
                              "\\parbox[b]{\\linewidth}{";
                else if (os.ulemCmd() == WriteStream::STRIKEOUT)
@@ -140,11 +137,10 @@ namespace {
        // writes a postamble for underlined or struck out math display
        void writeMathdisplayPostamble(WriteStream & os)
        {
-               if (os.strikeoutMath()) {
-                       if (os.ulemCmd() == WriteStream::UNDERLINE)
-                               os << "}";
-                       os << "}}\\\\\n";
-               } else if (os.ulemCmd() == WriteStream::UNDERLINE)
+               if (os.strikeoutMath())
+                       return;
+
+               if (os.ulemCmd() == WriteStream::UNDERLINE)
                        os << "}}\\\\\n";
                else if (os.ulemCmd() == WriteStream::STRIKEOUT)
                        os << "}\\\\\n";
@@ -198,7 +194,7 @@ docstring hullName(HullType type)
 static InsetLabel * dummy_pointer = 0;
 
 InsetMathHull::InsetMathHull(Buffer * buf)
-       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NUMBER),
+       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NONUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
          preview_(new RenderPreview(this))
 {
@@ -213,7 +209,7 @@ InsetMathHull::InsetMathHull(Buffer * buf)
 
 
 InsetMathHull::InsetMathHull(Buffer * buf, HullType type)
-       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NUMBER),
+       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NONUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
          preview_(new RenderPreview(this))
 {
@@ -283,7 +279,7 @@ namespace {
 } // namespace
 
 
-void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
+void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool const deleted)
 {
        if (!buffer_) {
                //FIXME: buffer_ should be set at creation for this inset! Problem is
@@ -316,8 +312,12 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
                                counter_map[eqstr] = cnts.value(eqstr);
                        for (size_t i = 0; i != label_.size(); ++i) {
                                if (numbered(i)) {
-                                       cnts.step(eqstr, utype);
-                                       numbers_[i] = cnts.theCounter(eqstr, lang);
+                                       Paragraph const & par = it.paragraph();
+                                       if (!par.isDeleted(it.pos())) {
+                                               cnts.step(eqstr, utype);
+                                               numbers_[i] = cnts.theCounter(eqstr, lang);
+                                       } else
+                                               numbers_[i] = from_ascii("#");
                                } else
                                        numbers_[i] = empty_docstring();
                        }
@@ -327,10 +327,10 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
        // now the labels
        for (size_t i = 0; i != label_.size(); ++i) {
                if (label_[i])
-                       label_[i]->updateBuffer(it, utype);
+                       label_[i]->updateBuffer(it, utype, deleted);
        }
        // pass down
-       InsetMathGrid::updateBuffer(it, utype);
+       InsetMathGrid::updateBuffer(it, utype, deleted);
 }
 
 
@@ -419,22 +419,6 @@ InsetMath::mode_type InsetMathHull::currentMode() const
 }
 
 
-bool InsetMathHull::idxFirst(Cursor & cur) const
-{
-       cur.idx() = 0;
-       cur.pos() = 0;
-       return true;
-}
-
-
-bool InsetMathHull::idxLast(Cursor & cur) const
-{
-       cur.idx() = nargs() - 1;
-       cur.pos() = cur.lastpos();
-       return true;
-}
-
-
 // FIXME: InsetMathGrid should be changed to let the real column alignment be
 // given by a virtual method like displayColAlign, because the values produced
 // by defaultColAlign can be invalidated by lfuns such as add-column. For the
@@ -525,11 +509,21 @@ bool InsetMathHull::previewState(const BufferView *const bv) const
 
 
 namespace {
-static const int ERROR_FRAME_WIDTH = 2;
+const int ERROR_FRAME_WIDTH = 2;
+
+bool previewTooSmall(Dimension const & dim)
+{
+       return dim.width() <= 10 && dim.height() <= 10;
 }
+}
+
 
 void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
 {
+       // true value in LaTeX is 12pt plus 3pt minus 9pt
+       // FIXME: even better would be to handle the short skip case.
+       int const display_margin = display() ? mi.base.inPixels(Length(12, Length::PT)) : 0;
+
        if (previewState(mi.base.bv)) {
                preview_->metrics(mi, dim);
                if (previewTooSmall(dim)) {
@@ -537,52 +531,58 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
                        dim.wid += 2 * ERROR_FRAME_WIDTH;
                        dim.asc += 2 * ERROR_FRAME_WIDTH;
                } else {
-                       // insert a one pixel gap in front of the formula
-                       dim.wid += 1;
-                       if (display())
-                               dim.des += displayMargin();
+                       // insert a gap in front of the formula
+                       // value was hardcoded to 1 pixel
+                       dim.wid += mi.base.bv->zoomedPixels(1) ;
+                       if (display()) {
+                               dim.asc += display_margin;
+                               dim.des += display_margin;
+                       }
                }
                return;
        }
 
-       Changer dummy1 = mi.base.changeFontSet(standardFont());
-       Changer dummy2 = mi.base.font.changeStyle(display() ? LM_ST_DISPLAY
-                                                           : LM_ST_TEXT);
-
-       // let the cells adjust themselves
-       InsetMathGrid::metrics(mi, dim);
+       {
+               Changer dummy1 = mi.base.changeFontSet(standardFont());
+               Changer dummy2 = mi.base.font.changeStyle(display() ? DISPLAY_STYLE
+                                                                                                 : TEXT_STYLE);
 
-       if (display()) {
-               dim.asc += displayMargin();
-               dim.des += displayMargin();
+               // let the cells adjust themselves
+               InsetMathGrid::metrics(mi, dim);
        }
 
+       // Check whether the numbering interferes with the equations
        if (numberedType()) {
-               Changer dummy = mi.base.changeFontSet("mathrm");
-               int l = 0;
-               for (row_type row = 0; row < nrows(); ++row)
-                       l = max(l, mathed_string_width(mi.base.font, nicelabel(row)));
+               BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
+               int extra_offset = 0;
+               for (row_type row = 0; row < nrows(); ++row) {
+                       rowinfo(row).offset[mi.base.bv] += extra_offset;
+                       if (!numbered(row))
+                               continue;
+                       docstring const nl = nicelabel(row);
+                       Dimension dimnl;
+                       mathed_string_dim(mi.base.font, nl, dimnl);
+                       int const ind = indent(*mi.base.bv);
+                       int const x = ind ? ind : (mi.base.textwidth - dim.wid) / 2;
+                       // for some reason metrics does not trigger at the
+                       // same point as draw, and therefore we use >= instead of >
+                       if ((math_number == BufferParams::LEFT && dimnl.wid >= x)
+                           || (math_number == BufferParams::RIGHT
+                               && dimnl.wid >= mi.base.textwidth - x - dim.wid)) {
+                               extra_offset += dimnl.height();
+                       }
+               }
+               dim.des += extra_offset;
+       }
+
 
-               if (l)
-                       // Value was hardcoded to 30 pixels
-                       dim.wid += Length(0.3, Length::IN).inPixels(mi.base) + l;
+       if (display()) {
+               dim.asc += display_margin;
+               dim.des += display_margin;
        }
 
        // reserve some space for marker.
        dim.wid += 2;
-
-       // make it at least as high as the current font
-       int asc = 0;
-       int des = 0;
-       math_font_max_dim(mi.base.font, asc, des);
-       dim.asc = max(dim.asc, asc);
-       dim.des = max(dim.des, des);
-}
-
-
-bool InsetMathHull::previewTooSmall(Dimension const & dim) const
-{
-       return dim.width() <= 10 && dim.height() <= 10;
 }
 
 
@@ -599,6 +599,25 @@ ColorCode InsetMathHull::backgroundColor(PainterInfo const & pi) const
 }
 
 
+void InsetMathHull::drawMarkers(PainterInfo & pi, int x, int y) const
+{
+       ColorCode pen_color = mouseHovered(pi.base.bv) || editing(pi.base.bv)?
+               Color_mathframe : Color_mathcorners;
+       // If the corners have the same color as the background, do not paint them.
+       if (lcolor.getX11Name(Color_mathbg) == lcolor.getX11Name(pen_color))
+               return;
+
+       Inset::drawMarkers(pi, x, y);
+       Dimension const dim = dimension(*pi.base.bv);
+       int const t = x + dim.width() - 1;
+       int const a = y - dim.ascent();
+       pi.pain.line(x, a + 3, x, a, pen_color);
+       pi.pain.line(t, a + 3, t, a, pen_color);
+       pi.pain.line(x, a, x + 3, a, pen_color);
+       pi.pain.line(t - 3, a, t, a, pen_color);
+}
+
+
 void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
 {
        Dimension const dim = dimension(*pi.base.bv);
@@ -607,6 +626,11 @@ void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
                    dim.wid, dim.asc + dim.des, backgroundColor(pi));
                return;
        }
+       // If there are numbers, the margins around the (displayed)
+       // equation have to be cleared.
+       if (numberedType())
+               pi.pain.fillRectangle(pi.leftx, y - dim.asc,
+                               pi.rightx - pi.leftx, dim.height(), pi.background_color);
        pi.pain.fillRectangle(x + 1, y - dim.asc + 1, dim.wid - 2,
                        dim.asc + dim.des - 1, pi.backgroundColor(this));
 }
@@ -624,61 +648,59 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
        if (previewState(bv)) {
                // Do not draw change tracking cue if taken care of by RowPainter
                // already.
-               Changer dummy = !canPaintChange(*bv) ? make_change(pi.change_, Change())
+               Changer dummy = !canPaintChange(*bv) ? make_change(pi.change, Change())
                        : Changer();
                if (previewTooSmall(dim)) {
                        // we have an extra frame
                        preview_->draw(pi, x + ERROR_FRAME_WIDTH, y);
                } else {
                        // one pixel gap in front
-                       preview_->draw(pi, x + 1, y);
+                       // value was hardcoded to 1 pixel
+                       int const gap = pi.base.bv->zoomedPixels(1) ;
+                       preview_->draw(pi, x + gap, y);
                }
                return;
        }
 
+       // First draw the numbers
        ColorCode color = pi.selected && lyxrc.use_system_colors
                                ? Color_selectiontext : standardColor();
        bool const really_change_color = pi.base.font.color() == Color_none;
        Changer dummy0 = really_change_color ? pi.base.font.changeColor(color)
                : Changer();
-       Changer dummy1 = pi.base.changeFontSet(standardFont());
-       Changer dummy2 = pi.base.font.changeStyle(display() ? LM_ST_DISPLAY
-                                                           : LM_ST_TEXT);
-
-       int xmath = x;
-       BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
-       if (numberedType() && math_number == BufferParams::LEFT) {
-               Changer dummy = pi.base.changeFontSet("mathrm");
-               int l = 0;
-               for (row_type row = 0; row < nrows(); ++row)
-                       l = max(l, mathed_string_width(pi.base.font, nicelabel(row)));
-
-               if (l)
-                       // Value was hardcoded to 30 pixels
-                       xmath += Length(0.3, Length::IN).inPixels(pi.base) + l;
-       }
-
-       InsetMathGrid::draw(pi, xmath + 1, y);
-       drawMarkers2(pi, x, y);
-
        if (numberedType()) {
-               Changer dummy = pi.base.changeFontSet("mathrm");
+               BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
                for (row_type row = 0; row < nrows(); ++row) {
-                       int const yy = y + rowinfo_[row].offset_;
+                       int yy = y + rowinfo(row).offset[bv];
                        docstring const nl = nicelabel(row);
-                       if (math_number == BufferParams::LEFT)
-                               pi.draw(x, yy, nl);
-                       else {
-                               int l = mathed_string_width(pi.base.font, nl);
-                               pi.draw(x + dim.wid - l, yy, nl);
+                       Dimension dimnl;
+                       mathed_string_dim(pi.base.font, nl, dimnl);
+                       if (math_number == BufferParams::LEFT) {
+                               if (dimnl.wid > x - pi.leftx)
+                                       yy += rowinfo(row).descent + dimnl.asc;
+                               pi.draw(pi.leftx, yy, nl);
+                       } else {
+                               if (dimnl.wid > pi.rightx - x - dim.wid)
+                                       yy += rowinfo(row).descent + dimnl.asc;
+                               pi.draw(pi.rightx - dimnl.wid, yy, nl);
                        }
                }
        }
 
+       // Then the equations
+       Changer dummy1 = pi.base.changeFontSet(standardFont());
+       Changer dummy2 = pi.base.font.changeStyle(display() ? DISPLAY_STYLE
+                                                           : TEXT_STYLE);
+       InsetMathGrid::draw(pi, x + 1, y);
+       drawMarkers(pi, x, y);
+
        // drawing change line
-       if (canPaintChange(*bv))
-               pi.change_.paintCue(pi, x + 1, y + 1 - dim.asc,
-                                   x + dim.wid, y + dim.des);
+       if (canPaintChange(*bv)) {
+               // like in metrics()
+               int const display_margin = display() ? pi.base.inPixels(Length(12, Length::PT)) : 0;
+               pi.change.paintCue(pi, x + 1, y + 1 - dim.asc + display_margin,
+                                   x + dim.wid, y + dim.des - display_margin);
+       }
 }
 
 
@@ -993,7 +1015,7 @@ bool InsetMathHull::outerDisplay() const
 }
 
 
-Inset::DisplayType InsetMathHull::display() const
+Inset::RowFlags InsetMathHull::rowFlags() const
 {
        switch (type_) {
        case hullUnknown:
@@ -1011,12 +1033,12 @@ Inset::DisplayType InsetMathHull::display() const
        case hullMultline:
        case hullGather:
                if (buffer().params().is_math_indent)
-                       return AlignLeft;
+                       return Display | AlignLeft;
                else
-                       return AlignCenter;
+                       return Display;
        }
        // avoid warning
-       return AlignCenter;
+       return Display;
 }
 
 
@@ -1024,7 +1046,7 @@ int InsetMathHull::indent(BufferView const & bv) const
 {
        // FIXME: set this in the textclass. This value is what the article class uses.
        static Length default_indent(2.5, Length::EM);
-       if (display() != Inline && buffer().params().is_math_indent) {
+       if (display() && buffer().params().is_math_indent) {
                Length const & len = buffer().params().getMathIndent();
                if (len.empty())
                        return bv.inPixels(default_indent);
@@ -1077,9 +1099,9 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
                                + bgcol + "}{\\ensuremath{\\mathtt{#1}}}}");
                        features.addPreambleSnippet(
                                from_ascii("\\newcommand{\\endregexp}{}"));
-               } else if (outerDisplay() && features.inDeletedInset()
-                          && !features.mustProvide("ct-dvipost")) {
-                               features.require("ct-tikz-math-sout");
+               } else if (outerDisplay() && features.inDeletedInset()) {
+                               features.require("tikz");
+                               features.require("ct-tikz-object-sout");
                }
 
                // Validation is necessary only if not using AMS math.
@@ -1102,6 +1124,37 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
 }
 
 
+OutputParams::CtObject InsetMathHull::CtObject(OutputParams const & runparams) const
+{
+       OutputParams::CtObject res = OutputParams::CT_NORMAL;
+       switch(type_) {
+       case hullNone:
+       case hullSimple:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullRegexp:
+       case hullUnknown:
+               break;
+
+       case hullEquation:
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullGather:
+       case hullMultline: {
+               if (runparams.inulemcmd
+                   && (!runparams.local_font || runparams.local_font->fontInfo().strikeout() != FONT_ON))
+                       res = OutputParams::CT_UDISPLAYOBJECT;
+               else
+                       res = OutputParams::CT_DISPLAYOBJECT;
+               break;
+               }
+       }
+       return res;
+}
+
+
 void InsetMathHull::header_write(WriteStream & os) const
 {
        bool n = numberedType();
@@ -1711,13 +1764,11 @@ void InsetMathHull::check() const
 
 void InsetMathHull::doExtern(Cursor & cur, FuncRequest & func)
 {
-       docstring dlang;
-       docstring extra;
-       idocstringstream iss(func.argument());
-       iss >> dlang >> extra;
+       //FIXME: sort out whether we want std::string or docstring for those
+       string const lang = func.getArg(0);
+       docstring extra = from_utf8(func.getArg(1));
        if (extra.empty())
                extra = from_ascii("noextra");
-       string const lang = to_ascii(dlang);
 
        // replace selection with result of computation
        if (reduceSelectionToOneCell(cur)) {
@@ -2053,15 +2104,15 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                return true;
        }
        case LFUN_MATH_DISPLAY: {
-               status.setEnabled(display() != Inline || allowDisplayMath(cur));
-               status.setOnOff(display() != Inline);
+               status.setEnabled(display() || allowDisplayMath(cur));
+               status.setOnOff(display());
                return true;
        }
 
        case LFUN_MATH_NUMBER_TOGGLE:
                // FIXME: what is the right test, this or the one of
                // LABEL_INSERT?
-               status.setEnabled(display() != Inline);
+               status.setEnabled(display());
                status.setOnOff(numberedType());
                return true;
 
@@ -2070,7 +2121,7 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                // LABEL_INSERT?
                bool const enable = (type_ == hullMultline)
                        ? (nrows() - 1 == cur.row())
-                       : display() != Inline;
+                       : display();
                row_type const r = (type_ == hullMultline) ? nrows() - 1 : cur.row();
                status.setEnabled(enable);
                status.setOnOff(enable && numbered(r));
@@ -2223,17 +2274,14 @@ void InsetMathHull::handleFont2(Cursor & cur, docstring const & arg)
        font.fromString(to_utf8(arg), b);
        if (font.fontInfo().color() != Color_inherit) {
                MathAtom at = MathAtom(new InsetMathColor(buffer_, true, font.fontInfo().color()));
-               cur.handleNest(at, 0);
+               cur.handleNest(at);
        }
 }
 
 
 void InsetMathHull::edit(Cursor & cur, bool front, EntryDirection entry_from)
 {
-       cur.push(*this);
-       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_LEFT ||
-               (entry_from == Inset::ENTRY_DIRECTION_IGNORE && front));
-       enter_front ? idxFirst(cur) : idxLast(cur);
+       InsetMathNest::edit(cur, front, entry_from);
        // The inset formula dimension is not necessarily the same as the
        // one of the instant preview image, so we have to indicate to the
        // BufferView that a metrics update is needed.
@@ -2356,60 +2404,70 @@ int InsetMathHull::plaintext(odocstringstream & os,
 }
 
 
-int InsetMathHull::docbook(odocstream & os, OutputParams const & runparams) const
+void InsetMathHull::docbook(XMLStream & xs, OutputParams const & runparams) const
 {
-       MathStream ms(os);
-       int res = 0;
+       // Choose the tag around the MathML equation.
        docstring name;
        if (getType() == hullSimple)
                name = from_ascii("inlineequation");
        else
                name = from_ascii("informalequation");
 
-       docstring bname = name;
-       if (!label(0).empty())
-               bname += " id='" + sgml::cleanID(buffer(), runparams, label(0)) + "'";
+       // DocBook also has <equation>, but it comes with a title.
 
-       ++ms.tab(); ms.cr(); ms.os() << '<' << bname << '>';
+       docstring attr;
+       for (row_type i = 0; i < nrows(); ++i) {
+               if (!label(i).empty()) {
+                       attr = "xml:id=\"" + xml::cleanID(label(i)) + "\"";
+                       break;
+               }
+       }
 
+       xs << xml::StartTag(name, attr);
+       xs << xml::CR();
+
+       // With DocBook 5, MathML must be within its own namespace; defined in Buffer.cpp::writeDocBookSource as "m".
+       // Output everything in a separate stream so that this does not interfere with the standard flow of DocBook tags.
+       odocstringstream osmath;
+       MathStream ms(osmath, "m", true);
+
+       // Output the MathML subtree.
        odocstringstream ls;
        otexstream ols(ls);
-       if (runparams.flavor == OutputParams::XML) {
-               ms << MTag("alt role='tex' ");
-               // Workaround for db2latex: db2latex always includes equations with
-               // \ensuremath{} or \begin{display}\end{display}
-               // so we strip LyX' math environment
-               WriteStream wi(ols, false, false, WriteStream::wsDefault, runparams.encoding);
-               InsetMathGrid::write(wi);
-               ms << from_utf8(subst(subst(to_utf8(ls.str()), "&", "&amp;"), "<", "&lt;"));
-               ms << ETag("alt");
-               ms << MTag("math");
-               ms << ETag("alt");
+
+       // TeX transcription. Avoid MTag/ETag so that there are no extraneous spaces.
+       ms << "<" << from_ascii("alt") << " role='tex'" << ">";
+       // Workaround for db2latex: db2latex always includes equations with
+       // \ensuremath{} or \begin{display}\end{display}
+       // so we strip LyX' math environment
+       WriteStream wi(ols, false, false, WriteStream::wsDefault, runparams.encoding);
+       InsetMathGrid::write(wi);
+       ms << from_utf8(subst(subst(to_utf8(ls.str()), "&", "&amp;"), "<", "&lt;"));
+       ms << "</" << from_ascii("alt") << ">";
+
+       // Actual transformation of the formula into MathML. This translation may fail (for example, due to custom macros).
+       // The new output stream is required to deal with the errors: first write completely the formula into this
+       // temporary stream; then, if it is possible without error, then copy it back to the "real" stream. Otherwise,
+       // some incomplete tags might be put into the real stream.
+       try {
+               // First, generate the MathML expression.
+               odocstringstream ostmp;
+               MathStream mstmp(ostmp, ms.xmlns(), ms.xmlMode());
+               InsetMathGrid::mathmlize(mstmp);
+
+               // Then, output it (but only if the generation can be done without errors!).
                ms << MTag("math");
-               InsetMathGrid::mathmlize(ms);
+               ms.cr();
+               osmath << ostmp.str(); // osmath is not a XMLStream, so no need for XMLStream::ESCAPE_NONE.
                ms << ETag("math");
-       } else {
-               ms << MTag("alt role='tex'");
-               latex(ols, runparams);
-               res = ols.texrow().rows();
-               ms << from_utf8(subst(subst(to_utf8(ls.str()), "&", "&amp;"), "<", "&lt;"));
-               ms << ETag("alt");
+       } catch (MathExportException const &) {
+               osmath << "MathML export failed. Please report this as a bug.";
        }
 
-       ms << from_ascii("<graphic fileref=\"eqn/");
-       if (!label(0).empty())
-               ms << sgml::cleanID(buffer(), runparams, label(0));
-       else
-               ms << sgml::uniqueID(from_ascii("anon"));
-
-       if (runparams.flavor == OutputParams::XML)
-               ms << from_ascii("\"/>");
-       else
-               ms << from_ascii("\">");
-
-       ms.cr(); --ms.tab(); ms.os() << "</" << name << '>';
-
-       return ms.line() + res;
+       // Output the complete formula to the DocBook stream.
+       xs << XMLStream::ESCAPE_NONE << osmath.str();
+       xs << xml::CR();
+       xs << xml::EndTag(name);
 }
 
 
@@ -2469,13 +2527,13 @@ void InsetMathHull::htmlize(HtmlStream & os) const
 // this duplicates code from InsetMathGrid, but
 // we need access here to number information,
 // and we simply do not have that in InsetMathGrid.
-void InsetMathHull::mathmlize(MathStream & os) const
+void InsetMathHull::mathmlize(MathStream & ms) const
 {
        bool const havenumbers = haveNumbers();
        bool const havetable = havenumbers || nrows() > 1 || ncols() > 1;
 
        if (havetable)
-               os << MTag("mtable");
+               ms << MTag("mtable");
        char const * const celltag = havetable ? "mtd" : "mrow";
        // FIXME There does not seem to be wide support at the moment
        // for mlabeledtr, so we have to use just mtr for now.
@@ -2483,25 +2541,25 @@ void InsetMathHull::mathmlize(MathStream & os) const
        char const * const rowtag = "mtr";
        for (row_type row = 0; row < nrows(); ++row) {
                if (havetable)
-                       os << MTag(rowtag);
+                       ms << MTag(rowtag);
                for (col_type col = 0; col < ncols(); ++col) {
-                       os << MTag(celltag)
+                       ms << MTag(celltag)
                           << cell(index(row, col))
                           << ETag(celltag);
                }
                // fleqn?
                if (havenumbers) {
-                       os << MTag("mtd");
+                       ms << MTag("mtd");
                        docstring const & num = numbers_[row];
                        if (!num.empty())
-                               os << '(' << num << ')';
-                 os << ETag("mtd");
+                               ms << '(' << num << ')';
+                 ms << ETag("mtd");
                }
                if (havetable)
-                       os << ETag(rowtag);
+                       ms << ETag(rowtag);
        }
        if (havetable)
-               os << ETag("mtable");
+               ms << ETag("mtable");
 }
 
 
@@ -2537,7 +2595,7 @@ void InsetMathHull::mathAsLatex(WriteStream & os) const
 }
 
 
-docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
+docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
 {
        BufferParams::MathOutput const mathtype =
                buffer().masterBuffer()->params().html_math_output;
@@ -2563,14 +2621,14 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                } catch (MathExportException const &) {}
                if (success) {
                        if (getType() == hullSimple)
-                               xs << html::StartTag("math",
+                               xs << xml::StartTag("math",
                                                        "xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
                        else
-                               xs << html::StartTag("math",
+                               xs << xml::StartTag("math",
                                      "display=\"block\" xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
-                       xs << XHTMLStream::ESCAPE_NONE
+                       xs << XMLStream::ESCAPE_NONE
                                 << os.str()
-                                << html::EndTag("math");
+                                << xml::EndTag("math");
                }
        } else if (mathtype == BufferParams::HTML) {
                odocstringstream os;
@@ -2581,10 +2639,10 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                } catch (MathExportException const &) {}
                if (success) {
                        string const tag = (getType() == hullSimple) ? "span" : "div";
-                       xs << html::StartTag(tag, "class='formula'", true)
-                          << XHTMLStream::ESCAPE_NONE
+                       xs << xml::StartTag(tag, "class='formula'", true)
+                          << XMLStream::ESCAPE_NONE
                           << os.str()
-                          << html::EndTag(tag);
+                          << xml::EndTag(tag);
                }
        }
 
@@ -2624,11 +2682,11 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                        }
 
                        string const tag = (getType() == hullSimple) ? "span" : "div";
-                       xs << html::CR()
-                          << html::StartTag(tag, "style = \"text-align: center;\"")
-                                << html::CompTag("img", "src=\"" + filename + "\" alt=\"Mathematical Equation\"")
-                                << html::EndTag(tag)
-                                << html::CR();
+                       xs << xml::CR()
+                          << xml::StartTag(tag, "style = \"text-align: center;\"")
+                                << xml::CompTag("img", "src=\"" + filename + "\" alt=\"Mathematical Equation\"")
+                                << xml::EndTag(tag)
+                                << xml::CR();
                        success = true;
                }
        }
@@ -2651,10 +2709,10 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                // FIXME XHTML
                // probably should allow for some kind of customization here
                string const tag = (getType() == hullSimple) ? "span" : "div";
-               xs << html::StartTag(tag, "class='math'")
+               xs << xml::StartTag(tag, "class='math'")
                   << latex
-                  << html::EndTag(tag)
-                  << html::CR();
+                  << xml::EndTag(tag)
+                  << xml::CR();
        }
        return docstring();
 }
@@ -2695,7 +2753,7 @@ void InsetMathHull::recordLocation(DocIterator const & di)
 bool InsetMathHull::canPaintChange(BufferView const &) const
 {
        // We let RowPainter do it seamlessly for inline insets
-       return display() != Inline;
+       return display();
 }