]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathHull.cpp
Revert "Fix the display of column spacing in AMS environments"
[lyx.git] / src / mathed / InsetMathHull.cpp
index 956b6b9bca220271066bf090aff0e89a32191827..cce029f6cedf25f98b3f3293ac45ea8cb8476974 100644 (file)
 
 #include "InsetMathChar.h"
 #include "InsetMathColor.h"
+#include "InsetMathFrac.h"
+#include "InsetMathGrid.h"
+#include "InsetMathNest.h"
+#include "InsetMathScript.h"
 #include "MathExtern.h"
 #include "MathFactory.h"
 #include "MathStream.h"
@@ -32,6 +36,8 @@
 #include "LaTeXFeatures.h"
 #include "LyXRC.h"
 #include "MacroTable.h"
+#include "MathMacro.h"
+#include "MathMacroTemplate.h"
 #include "output_xhtml.h"
 #include "Paragraph.h"
 #include "ParIterator.h"
@@ -44,6 +50,7 @@
 #include "insets/InsetRef.h"
 #include "insets/RenderPreview.h"
 
+#include "graphics/GraphicsImage.h"
 #include "graphics/PreviewImage.h"
 #include "graphics/PreviewLoader.h"
 
@@ -65,6 +72,7 @@ using namespace lyx::support;
 namespace lyx {
 
 using cap::grabAndEraseSelection;
+using cap::reduceSelectionToOneCell;
 
 namespace {
 
@@ -119,7 +127,7 @@ HullType hullType(docstring const & s)
        if (s == "gather")    return hullGather;
        if (s == "flalign")   return hullFlAlign;
        if (s == "regexp")    return hullRegexp;
-       lyxerr << "unknown hull type '" << to_utf8(s) << "'" << endl;
+       lyxerr << "unknown hull type '" << to_utf8(s) << "'" << endl;
        return HullType(-1);
 }
 
@@ -139,7 +147,7 @@ docstring hullName(HullType type)
                case hullGather:     return from_ascii("gather");
                case hullFlAlign:    return from_ascii("flalign");
                case hullRegexp:     return from_ascii("regexp");
-               default:
+               default:
                        lyxerr << "unknown hull type '" << type << "'" << endl;
                        return from_ascii("none");
        }
@@ -148,9 +156,9 @@ docstring hullName(HullType type)
 static InsetLabel * dummy_pointer = 0;
 
 InsetMathHull::InsetMathHull(Buffer * buf)
-       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, true),
-    numbers_(1, empty_docstring()), label_(1, dummy_pointer),
-    preview_(new RenderPreview(this))
+       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NUMBER),
+         numbers_(1, empty_docstring()), label_(1, dummy_pointer),
+         preview_(new RenderPreview(this)), use_preview_(false)
 {
        //lyxerr << "sizeof InsetMath: " << sizeof(InsetMath) << endl;
        //lyxerr << "sizeof MetricsInfo: " << sizeof(MetricsInfo) << endl;
@@ -163,9 +171,9 @@ InsetMathHull::InsetMathHull(Buffer * buf)
 
 
 InsetMathHull::InsetMathHull(Buffer * buf, HullType type)
-       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, true),
-    numbers_(1, empty_docstring()), label_(1, dummy_pointer),
-    preview_(new RenderPreview(this))
+       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NUMBER),
+         numbers_(1, empty_docstring()), label_(1, dummy_pointer),
+         preview_(new RenderPreview(this)), use_preview_(false)
 {
        buffer_ = buf;
        initMath();
@@ -284,7 +292,8 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
 }
 
 
-void InsetMathHull::addToToc(DocIterator const & pit, bool output_active) const
+void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
+                                                        UpdateType utype) const
 {
        if (!buffer_) {
                //FIXME: buffer_ should be set at creation for this inset! Problem is
@@ -293,14 +302,14 @@ void InsetMathHull::addToToc(DocIterator const & pit, bool output_active) const
                return;
        }
 
-       Toc & toc = buffer().tocBackend().toc("equation");
+       shared_ptr<Toc> toc = buffer().tocBackend().toc("equation");
 
        for (row_type row = 0; row != nrows(); ++row) {
-               if (!numbered_[row])
+               if (!numbered(row))
                        continue;
                if (label_[row])
-                       label_[row]->addToToc(pit, output_active);
-               toc.push_back(TocItem(pit, 0, nicelabel(row), output_active));
+                       label_[row]->addToToc(pit, output_active, utype);
+               toc->push_back(TocItem(pit, 0, nicelabel(row), output_active));
        }
 }
 
@@ -340,29 +349,36 @@ bool InsetMathHull::idxLast(Cursor & cur) const
 }
 
 
+//FIXME: This has probably no effect and can be removed.\r
 char InsetMathHull::defaultColAlign(col_type col)
 {
-       if (type_ == hullEqnArray)
-               return "rcl"[col];
-       if (type_ == hullMultline)
-               return 'c';
-       if (type_ == hullGather)
-               return 'c';
-       if (type_ >= hullAlign)
-               return "rl"[col & 1];
-       return 'c';
+       return colAlign(type_, col);\r
 }
 
 
-char InsetMathHull::displayColAlign(col_type col, row_type row) const
+char InsetMathHull::displayColAlign(idx_type idx) const
 {
-       if (type_ == hullMultline) {
-               if (row == 0)
+       switch (type_) {\r
+       case hullMultline: {\r
+               row_type const r = row(idx);
+               if (r == 0)
                        return 'l';
-               if (row == nrows() - 1)
+               if (r == nrows() - 1)
                        return 'r';
+               return 'c';\r
+       }\r
+       case hullEqnArray:\r
+       case hullGather:\r
+       case hullAlign:\r
+       case hullAlignAt:\r
+       case hullXAlignAt:\r
+       case hullXXAlignAt:\r
+       case hullFlAlign:\r
+               return colAlign(type_, col(idx));\r
+       default:\r
+               break;\r
        }
-       return InsetMathGrid::displayColAlign(col, row);
+       return InsetMathGrid::displayColAlign(idx);
 }
 
 
@@ -410,10 +426,10 @@ ColorCode InsetMathHull::standardColor() const
 }
 
 
-bool InsetMathHull::previewState(BufferView * bv) const
+bool InsetMathHull::previewState(const BufferView *const bv) const
 {
-       if (!editing(bv) && RenderPreview::status() == LyXRC::PREVIEW_ON
-               && type_ != hullRegexp)
+       if (!editing(bv) && RenderPreview::previewMath()
+           && type_ != hullRegexp)
        {
                graphics::PreviewImage const * pimage =
                        preview_->getPreviewImage(bv->buffer());
@@ -423,14 +439,24 @@ bool InsetMathHull::previewState(BufferView * bv) const
 }
 
 
+namespace {
+static const int ERROR_FRAME_WIDTH = 2;
+}
+
 void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
 {
        if (previewState(mi.base.bv)) {
                preview_->metrics(mi, dim);
-               // insert a one pixel gap in front of the formula
-               dim.wid += 1;
-               if (display())
-                       dim.des += displayMargin();
+               if (previewTooSmall(dim)) {
+                       // preview image is too small
+                       dim.wid += 2 * ERROR_FRAME_WIDTH;
+                       dim.asc += 2 * ERROR_FRAME_WIDTH;
+               } else {
+                       // insert a one pixel gap in front of the formula
+                       dim.wid += 1;
+                       if (display())
+                               dim.des += displayMargin();
+               }
                // Cache the inset dimension.
                setDimCache(mi, dim);
                return;
@@ -471,10 +497,21 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
 }
 
 
+bool InsetMathHull::previewTooSmall(Dimension const & dim) const
+{
+       return dim.width() <= 10 && dim.height() <= 10;
+}
+
+
 ColorCode InsetMathHull::backgroundColor(PainterInfo const & pi) const
 {
-       if (previewState(pi.base.bv))
+       BufferView const * const bv = pi.base.bv;
+       if (previewState(bv)) {
+               Dimension const dim = dimension(*pi.base.bv);
+               if (previewTooSmall(dim))
+                       return Color_error;
                return graphics::PreviewLoader::backgroundColor();
+       }
        return Color_mathbg;
 }
 
@@ -482,23 +519,36 @@ ColorCode InsetMathHull::backgroundColor(PainterInfo const & pi) const
 void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
 {
        Dimension const dim = dimension(*pi.base.bv);
+       if (previewTooSmall(dim)) {
+               pi.pain.fillRectangle(x, y - 2 * ERROR_FRAME_WIDTH,
+                   dim.wid, dim.asc + dim.des, backgroundColor(pi));
+               return;
+       }
        pi.pain.fillRectangle(x + 1, y - dim.asc + 1, dim.wid - 2,
-               dim.asc + dim.des - 1, pi.backgroundColor(this));
+                       dim.asc + dim.des - 1, pi.backgroundColor(this));
 }
 
 
 void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
 {
-       use_preview_ = previewState(pi.base.bv);
+       BufferView const * const bv = pi.base.bv;
+       use_preview_ = previewState(bv);
 
        if (type_ == hullRegexp) {
-               Dimension const dim = dimension(*pi.base.bv);
+               Dimension const dim = dimension(*bv);
                pi.pain.rectangle(x + 1, y - dim.ascent() + 1,
                        dim.width() - 2, dim.height() - 2, Color_regexpframe);
        }
+
        if (use_preview_) {
-               // one pixel gap in front
-               preview_->draw(pi, x + 1, y);
+               Dimension const dim = dimension(*bv);
+               if (previewTooSmall(dim)) {
+                       // we have an extra frame
+                       preview_->draw(pi, x + ERROR_FRAME_WIDTH, y);
+               } else {
+                       // one pixel gap in front
+                       preview_->draw(pi, x + 1, y);
+               }
                setPosCache(pi, x, y);
                return;
        }
@@ -531,7 +581,9 @@ void InsetMathHull::metricsT(TextMetricsInfo const & mi, Dimension & dim) const
                InsetMathGrid::metricsT(mi, dim);
        } else {
                odocstringstream os;
-               WriteStream wi(os, false, true, WriteStream::wsDefault);
+               TexRow texrow(false);
+               otexrowstream ots(os,texrow);
+               WriteStream wi(ots, false, true, WriteStream::wsDefault);
                write(wi);
                dim.wid = os.str().size();
                dim.asc = 1;
@@ -546,7 +598,9 @@ void InsetMathHull::drawT(TextPainter & pain, int x, int y) const
                InsetMathGrid::drawT(pain, x, y);
        } else {
                odocstringstream os;
-               WriteStream wi(os, false, true, WriteStream::wsDefault);
+               TexRow texrow(false);
+               otexrowstream ots(os,texrow);
+               WriteStream wi(ots, false, true, WriteStream::wsDefault);
                write(wi);
                pain.draw(x, y, os.str().c_str());
        }
@@ -564,7 +618,9 @@ static docstring latexString(InsetMathHull const & inset)
        static Encoding const * encoding = 0;
        if (inset.isBufferValid())
                encoding = &(inset.buffer().params().encoding());
-       WriteStream wi(ls, false, true, WriteStream::wsPreview, encoding);
+       TexRow texrow(false);
+       otexrowstream ots(ls,texrow);
+       WriteStream wi(ots, false, true, WriteStream::wsPreview, encoding);
        inset.write(wi);
        return ls.str();
 }
@@ -580,35 +636,111 @@ void InsetMathHull::initUnicodeMath() const
 void InsetMathHull::addPreview(DocIterator const & inset_pos,
        graphics::PreviewLoader & /*ploader*/) const
 {
-       if (RenderPreview::status() == LyXRC::PREVIEW_ON) {
+       if (RenderPreview::previewMath()) {
                preparePreview(inset_pos);
        }
 }
 
 
+void InsetMathHull::usedMacros(MathData const & md, DocIterator const & pos,
+                               MacroNameSet & macros, MacroNameSet & defs) const
+{
+       MacroNameSet::iterator const end = macros.end();
+
+       for (size_t i = 0; i < md.size(); ++i) {
+               MathMacro const * mi = md[i].nucleus()->asMacro();
+               MathMacroTemplate const * mt = md[i].nucleus()->asMacroTemplate();
+               InsetMathScript const * si = md[i].nucleus()->asScriptInset();
+               InsetMathFracBase const * fi = md[i].nucleus()->asFracBaseInset();
+               InsetMathGrid const * gi = md[i].nucleus()->asGridInset();
+               InsetMathNest const * ni = md[i].nucleus()->asNestInset();
+               if (mi) {
+                       // Look for macros in the arguments of this macro.
+                       for (idx_type idx = 0; idx < mi->nargs(); ++idx)
+                               usedMacros(mi->cell(idx), pos, macros, defs);
+                       // Make sure this is a macro defined in the document
+                       // (as we also spot the macros in the symbols file)
+                       // or that we have not already accounted for it.
+                       docstring const name = mi->name();
+                       if (macros.find(name) == end)
+                               continue;
+                       macros.erase(name);
+                       // Look for macros in the definition of this macro.
+                       MathData ar(pos.buffer());
+                       MacroData const * data =
+                               pos.buffer()->getMacro(name, pos, true);
+                       if (data) {
+                               odocstringstream macro_def;
+                               data->write(macro_def, true);
+                               macro_def << endl;
+                               defs.insert(macro_def.str());
+                               asArray(data->definition(), ar);
+                       }
+                       usedMacros(ar, pos, macros, defs);
+               } else if (mt) {
+                       MathData ar(pos.buffer());
+                       asArray(mt->definition(), ar);
+                       usedMacros(ar, pos, macros, defs);
+               } else if (si) {
+                       if (!si->nuc().empty())
+                               usedMacros(si->nuc(), pos, macros, defs);
+                       if (si->hasDown())
+                               usedMacros(si->down(), pos, macros, defs);
+                       if (si->hasUp())
+                               usedMacros(si->up(), pos, macros, defs);
+               } else if (fi || gi) {
+                       idx_type nidx = fi ? fi->nargs() : gi->nargs();
+                       for (idx_type idx = 0; idx < nidx; ++idx)
+                               usedMacros(fi ? fi->cell(idx) : gi->cell(idx),
+                                          pos, macros, defs);
+               } else if (ni) {
+                       usedMacros(ni->cell(0), pos, macros, defs);
+               }
+       }
+}
+
+
 void InsetMathHull::preparePreview(DocIterator const & pos,
-                                   bool forexport) const  
+                                   bool forexport) const
 {
        // there is no need to do all the macro stuff if we're not
        // actually going to generate the preview.
-       if (RenderPreview::status() != LyXRC::PREVIEW_ON && !forexport)
+       if (!RenderPreview::previewMath() && !forexport)
                return;
-       
+
        Buffer const * buffer = pos.buffer();
 
        // collect macros at this position
        MacroNameSet macros;
        buffer->listMacroNames(macros);
-       MacroNameSet::iterator it = macros.begin();
-       MacroNameSet::iterator end = macros.end();
-       odocstringstream macro_preamble;
-       for (; it != end; ++it) {
-               MacroData const * data = buffer->getMacro(*it, pos, true);
-               if (data) {
-                       data->write(macro_preamble, true);
-                       macro_preamble << endl;
-               }
-       }
+
+       // collect definitions only for the macros used in this inset
+       MacroNameSet defs;
+       for (idx_type idx = 0; idx < nargs(); ++idx)
+               usedMacros(cell(idx), pos, macros, defs);
+
+       MacroNameSet::iterator it = defs.begin();
+       MacroNameSet::iterator end = defs.end();
+       docstring macro_preamble;
+       for (; it != end; ++it)
+               macro_preamble.append(*it);
+
+       // set the font series and size for this snippet
+       DocIterator dit = pos;
+       while (dit.inMathed())
+               dit.pop_back();
+       Paragraph const & par = dit.paragraph();
+       Font font = par.getFontSettings(buffer->params(), dit.pos());
+       font.fontInfo().realize(par.layout().font);
+       string const lsize = font.latexSize();
+       docstring setfont;
+       docstring endfont;
+       if (font.fontInfo().series() == BOLD_SERIES) {
+               setfont += from_ascii("\\textbf{");
+               endfont += '}';
+       }
+       if (lsize != "normalsize" && !prefixIs(lsize, "error"))
+               setfont += from_ascii("\\" + lsize + '\n'); 
 
        docstring setcnt;
        if (forexport && haveNumbers()) {
@@ -631,8 +763,8 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
                                          '{' + convert<docstring>(num) + '}';
                }
        }
-       docstring const snippet = macro_preamble.str() +
-           setcnt + latexString(*this);
+       docstring const snippet = macro_preamble + setfont + setcnt
+                                 + latexString(*this) + endfont;
        LYXERR(Debug::MACROS, "Preview snippet: " << snippet);
        preview_->addPreview(snippet, *buffer, forexport);
 }
@@ -655,7 +787,7 @@ void InsetMathHull::loadPreview(DocIterator const & pos) const
 
 bool InsetMathHull::notifyCursorLeaves(Cursor const & old, Cursor & cur)
 {
-       if (RenderPreview::status() == LyXRC::PREVIEW_ON) {
+       if (RenderPreview::previewMath()) {
                reloadPreview(old);
                cur.screenUpdateFlags(Update::Force);
        }
@@ -695,10 +827,10 @@ void InsetMathHull::label(row_type row, docstring const & label)
 }
 
 
-void InsetMathHull::numbered(row_type row, bool num)
+void InsetMathHull::numbered(row_type row, Numbered num)
 {
        numbered_[row] = num;
-       if (!numbered_[row] && label_[row]) {
+       if (!numbered(row) && label_[row]) {
                delete label_[row];
                label_[row] = 0;
        }
@@ -707,19 +839,32 @@ void InsetMathHull::numbered(row_type row, bool num)
 
 bool InsetMathHull::numbered(row_type row) const
 {
-       return numbered_[row];
+       return numbered_[row] == NUMBER;
 }
 
 
 bool InsetMathHull::ams() const
 {
-       return type_ == hullAlign
-               || type_ == hullFlAlign
-               || type_ == hullMultline
-               || type_ == hullGather
-               || type_ == hullAlignAt
-               || type_ == hullXAlignAt
-               || type_ == hullXXAlignAt;
+       switch (type_) {
+               case hullAlign:
+               case hullFlAlign:
+               case hullMultline:
+               case hullGather:
+               case hullAlignAt:
+               case hullXAlignAt:
+               case hullXXAlignAt:
+                       return true;
+               case hullNone:
+               case hullSimple:
+               case hullEquation:
+               case hullEqnArray:
+               case hullRegexp:
+                       break;
+       }
+       for (size_t row = 0; row < numbered_.size(); ++row)
+               if (numbered_[row] == NOTAG)
+                       return true;
+       return false;
 }
 
 
@@ -741,7 +886,7 @@ bool InsetMathHull::numberedType() const
        if (type_ == hullRegexp)
                return false;
        for (row_type row = 0; row < nrows(); ++row)
-               if (numbered_[row])
+               if (numbered(row))
                        return true;
        return false;
 }
@@ -752,7 +897,7 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
        if (features.runparams().isLaTeX()) {
                if (ams())
                        features.require("amsmath");
-       
+
                if (type_ == hullRegexp) {
                        features.require("color");
                        string frcol = lcolor.getLaTeXName(Color_regexpframe);
@@ -764,12 +909,12 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
                        features.addPreambleSnippet(
                                string("\\newcommand{\\endregexp}{}"));
                }
-       
+
                // Validation is necessary only if not using AMS math.
                // To be safe, we will always run mathedvalidate.
                //if (features.amsstyle)
                //  return;
-       
+
                //features.binom      = true;
        } else if (features.runparams().math_flavor == OutputParams::MathAsHTML) {
                // it would be better to do this elsewhere, but we can't validate in
@@ -795,15 +940,18 @@ void InsetMathHull::header_write(WriteStream & os) const
 
        case hullSimple:
                os << '$';
+               os.startOuterRow();
                if (cell(0).empty())
                        os << ' ';
                break;
 
        case hullEquation:
+               os << "\n";
+               os.startOuterRow();
                if (n)
-                       os << "\n\\begin{equation" << star(n) << "}\n";
+                       os << "\\begin{equation" << star(n) << "}\n";
                else
-                       os << "\n\\[\n";
+                       os << "\\[\n";
                break;
 
        case hullEqnArray:
@@ -811,17 +959,23 @@ void InsetMathHull::header_write(WriteStream & os) const
        case hullFlAlign:
        case hullGather:
        case hullMultline:
-               os << "\n\\begin{" << hullName(type_) << star(n) << "}\n";
+               os << "\n";
+               os.startOuterRow();
+               os << "\\begin{" << hullName(type_) << star(n) << "}\n";
                break;
 
        case hullAlignAt:
        case hullXAlignAt:
-               os << "\n\\begin{" << hullName(type_) << star(n) << '}'
+               os << "\n";
+               os.startOuterRow();
+               os << "\\begin{" << hullName(type_) << star(n) << '}'
                  << '{' << static_cast<unsigned int>((ncols() + 1)/2) << "}\n";
                break;
 
        case hullXXAlignAt:
-               os << "\n\\begin{" << hullName(type_) << '}'
+               os << "\n";
+               os.startOuterRow();
+               os << "\\begin{" << hullName(type_) << '}'
                  << '{' << static_cast<unsigned int>((ncols() + 1)/2) << "}\n";
                break;
 
@@ -830,7 +984,9 @@ void InsetMathHull::header_write(WriteStream & os) const
                break;
 
        default:
-               os << "\n\\begin{unknown" << star(n) << "}\n";
+               os << "\n";
+               os.startOuterRow();
+               os << "\\begin{unknown" << star(n) << "}\n";
                break;
        }
 }
@@ -850,10 +1006,12 @@ void InsetMathHull::footer_write(WriteStream & os) const
                break;
 
        case hullEquation:
+               os << "\n";
+               os.startOuterRow();
                if (n)
-                       os << "\n\\end{equation" << star(n) << "}\n";
+                       os << "\\end{equation" << star(n) << "}\n";
                else
-                       os << "\n\\]\n";
+                       os << "\\]\n";
                break;
 
        case hullEqnArray:
@@ -863,11 +1021,15 @@ void InsetMathHull::footer_write(WriteStream & os) const
        case hullXAlignAt:
        case hullGather:
        case hullMultline:
-               os << "\n\\end{" << hullName(type_) << star(n) << "}\n";
+               os << "\n";
+               os.startOuterRow();
+               os << "\\end{" << hullName(type_) << star(n) << "}\n";
                break;
 
        case hullXXAlignAt:
-               os << "\n\\end{" << hullName(type_) << "}\n";
+               os << "\n";
+               os.startOuterRow();
+               os << "\\end{" << hullName(type_) << "}\n";
                break;
 
        case hullRegexp:
@@ -876,7 +1038,9 @@ void InsetMathHull::footer_write(WriteStream & os) const
                break;
 
        default:
-               os << "\n\\end{unknown" << star(n) << "}\n";
+               os << "\n";
+               os.startOuterRow();
+               os << "\\end{unknown" << star(n) << "}\n";
                break;
        }
 }
@@ -911,14 +1075,14 @@ void InsetMathHull::addRow(row_type row)
        docstring number = empty_docstring();
        if (type_ == hullMultline) {
                if (row + 1 == nrows())  {
-                       numbered_[row] = false;
+                       numbered_[row] = NONUMBER;
                        swap(label, label_[row]);
                        swap(number, numbers_[row]);
                } else
                        numbered = false;
        }
 
-       numbered_.insert(numbered_.begin() + row + 1, numbered);
+       numbered_.insert(numbered_.begin() + row + 1, numbered ? NUMBER : NONUMBER);
        numbers_.insert(numbers_.begin() + row + 1, number);
        label_.insert(label_.begin() + row + 1, label);
        InsetMathGrid::addRow(row);
@@ -931,14 +1095,7 @@ void InsetMathHull::swapRow(row_type row)
                return;
        if (row + 1 == nrows())
                --row;
-       // gcc implements the standard std::vector<bool> which is *not* a container:
-       //   http://www.gotw.ca/publications/N1185.pdf
-       // As a results, it doesn't like this:
-       //      swap(numbered_[row], numbered_[row + 1]);
-       // so we do it manually:
-       bool const b = numbered_[row];
-       numbered_[row] = numbered_[row + 1];
-       numbered_[row + 1] = b;
+       swap(numbered_[row], numbered_[row + 1]);
        swap(numbers_[row], numbers_[row + 1]);
        swap(label_[row], label_[row + 1]);
        InsetMathGrid::swapRow(row);
@@ -950,9 +1107,7 @@ void InsetMathHull::delRow(row_type row)
        if (nrows() <= 1 || !rowChangeOK())
                return;
        if (row + 1 == nrows() && type_ == hullMultline) {
-               bool const b = numbered_[row - 1];
-               numbered_[row - 1] = numbered_[row];
-               numbered_[row] = b;
+               swap(numbered_[row - 1], numbered_[row]);
                swap(numbers_[row - 1], numbers_[row]);
                swap(label_[row - 1], label_[row]);
                InsetMathGrid::delRow(row);
@@ -988,7 +1143,7 @@ void InsetMathHull::delCol(col_type col)
 
 docstring InsetMathHull::nicelabel(row_type row) const
 {
-       if (!numbered_[row])
+       if (!numbered(row))
                return docstring();
        docstring const & val = numbers_[row];
        if (!label_[row])
@@ -1092,6 +1247,27 @@ void InsetMathHull::setType(HullType type)
 }
 
 
+bool InsetMathHull::isMutable(HullType type)\r
+{\r
+       switch (type) {\r
+       case hullNone:\r
+       case hullSimple:\r
+       case hullEquation:\r
+       case hullEqnArray:\r
+       case hullAlign:\r
+       case hullFlAlign:\r
+       case hullAlignAt:\r
+       case hullXAlignAt:\r
+       case hullXXAlignAt:\r
+       case hullMultline:\r
+       case hullGather:\r
+               return true;\r
+       default:\r
+               return false;\r
+       }\r
+}\r
+\r
+\r
 void InsetMathHull::mutate(HullType newtype)
 {
        //lyxerr << "mutating from '" << type_ << "' to '" << newtype << "'" << endl;
@@ -1225,21 +1401,24 @@ docstring InsetMathHull::eolString(row_type row, bool fragile, bool latex,
 {
        docstring res;
        if (numberedType()) {
-               if (label_[row] && numbered_[row]) {
+               if (label_[row] && numbered(row)) {
                        docstring const name =
                                latex ? escape(label_[row]->getParam("name"))
                                      : label_[row]->getParam("name");
                        res += "\\label{" + name + '}';
                }
-               if (!numbered_[row] && (type_ != hullMultline))
-                       res += "\\nonumber ";
+               if (type_ != hullMultline) {
+                       if (numbered_[row]  == NONUMBER)
+                               res += "\\nonumber ";
+                       else if (numbered_[row]  == NOTAG)
+                               res += "\\notag ";
+               }
        }
        // Never add \\ on the last empty line of eqnarray and friends
        last_eoln = false;
        return res + InsetMathGrid::eolString(row, fragile, latex, last_eoln);
 }
 
-
 void InsetMathHull::write(WriteStream & os) const
 {
        ModeSpecifier specifier(os, MATH_MODE);
@@ -1259,7 +1438,7 @@ void InsetMathHull::normalize(NormalStream & os) const
 
 void InsetMathHull::infoize(odocstream & os) const
 {
-       os << "Type: " << hullName(type_);
+       os << bformat(_("Type: %1$s"), hullName(type_));
 }
 
 
@@ -1281,14 +1460,14 @@ void InsetMathHull::doExtern(Cursor & cur, FuncRequest & func)
                extra = from_ascii("noextra");
        string const lang = to_ascii(dlang);
 
-       // FIXME: temporarily disabled
-       //if (cur.selection()) {
-       //      MathData ar;
-       //      selGet(cur.ar);
-       //      lyxerr << "use selection: " << ar << endl;
-       //      insert(pipeThroughExtern(lang, extra, ar));
-       //      return;
-       //}
+       // replace selection with result of computation
+       if (reduceSelectionToOneCell(cur)) {
+               MathData ar;
+               asArray(grabAndEraseSelection(cur), ar);
+               lyxerr << "use selection: " << ar << endl;
+               cur.insert(pipeThroughExtern(lang, extra, ar));
+               return;
+       }
 
        // only inline, display or eqnarray math is allowed
        if (getType() > hullEqnArray) {
@@ -1309,9 +1488,7 @@ void InsetMathHull::doExtern(Cursor & cur, FuncRequest & func)
        if (getType() == hullSimple) {
                size_type pos = cur.cell().find_last(eq);
                MathData ar;
-               if (cur.inMathed() && cur.selection()) {
-                       asArray(grabAndEraseSelection(cur), ar);
-               } else if (!pos == cur.cell().empty()) {
+               if (pos == cur.cell().size()) {
                        ar = cur.cell();
                        lyxerr << "use whole cell: " << ar << endl;
                } else {
@@ -1367,7 +1544,6 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_FINISHED_LEFT:
                //lyxerr << "action: " << cmd.action() << endl;
                InsetMathGrid::doDispatch(cur, cmd);
-               cur.undispatched();
                break;
 
        case LFUN_PARAGRAPH_BREAK:
@@ -1379,7 +1555,7 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                if (type_ == hullSimple || type_ == hullEquation) {
                        cur.recordUndoInset();
                        bool const align =
-                               cur.bv().buffer().params().use_package("amsmath") == BufferParams::package_on;
+                               cur.bv().buffer().params().use_package("amsmath") != BufferParams::package_off;
                        mutate(align ? hullAlign : hullEqnArray);
                        // mutate() may change labels and such.
                        cur.forceBufferUpdate();
@@ -1444,7 +1620,7 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // if there is an argument, find the corresponding label, else
                        // check whether there is at least one label.
                        for (row = 0; row != nrows(); ++row)
-                               if (numbered_[row] && label_[row]
+                               if (numbered(row) && label_[row]
                                          && (cmd.argument().empty() || label(row) == cmd.argument()))
                                        break;
                }
@@ -1541,9 +1717,15 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_MATH_DISPLAY: {
                cur.recordUndoInset();
                mutate(type_ == hullSimple ? hullEquation : hullSimple);
-               cur.idx() = 0;
-               cur.pos() = cur.lastpos();
-               //cur.dispatched(FINISHED);
+               // if the cursor is in a cell that got merged, move it to
+               // start of the hull inset.
+               if (cur.idx() > 0) {
+                       cur.idx() = 0;
+                       cur.pos() = 0;
+               }
+               if (cur.pos() > cur.lastpos())
+                       cur.pos() = cur.lastpos();
+
                break;
        }
 
@@ -1604,6 +1786,7 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                                enable = display() != Inline;
                }
                status.setEnabled(enable);
+               status.setOnOff(display() != Inline);
                return true;
        }
 
@@ -1637,12 +1820,12 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                        // if there is no argument and we're inside math, we retrieve
                        // the row number from the cursor position.
                        row = (type_ == hullMultline) ? nrows() - 1 : cur.row();
-                       enabled = numberedType() && label_[row] && numbered_[row];
+                       enabled = numberedType() && label_[row] && numbered(row);
                } else {
                        // if there is an argument, find the corresponding label, else
                        // check whether there is at least one label.
                        for (row_type row = 0; row != nrows(); ++row) {
-                               if (numbered_[row] && label_[row] && 
+                               if (numbered(row) && label_[row] &&
                                        (cmd.argument().empty() || label(row) == cmd.argument())) {
                                                enabled = true;
                                                break;
@@ -1872,7 +2055,9 @@ bool InsetMathHull::searchForward(BufferView * bv, string const & str,
 void InsetMathHull::write(ostream & os) const
 {
        odocstringstream oss;
-       WriteStream wi(oss, false, false, WriteStream::wsDefault);
+       TexRow texrow(false);
+       otexrowstream ots(oss,texrow);
+       WriteStream wi(ots, false, false, WriteStream::wsDefault);
        oss << "Formula ";
        write(wi);
        os << to_utf8(oss.str());
@@ -1914,8 +2099,10 @@ int InsetMathHull::plaintext(odocstringstream & os,
        }
 
        odocstringstream oss;
+       TexRow texrow(false);
+       otexrowstream ots(oss,texrow);
        Encoding const * const enc = encodings.fromLyXName("utf8");
-       WriteStream wi(oss, false, true, WriteStream::wsDefault, enc);
+       WriteStream wi(ots, false, true, WriteStream::wsDefault, enc);
 
        // Fix Bug #6139
        if (type_ == hullRegexp)
@@ -1928,7 +2115,8 @@ int InsetMathHull::plaintext(odocstringstream & os,
                        // and do not include the newline.
                        if (op.for_toc || op.for_tooltip || oss.str().size() >= max_length)
                                break;
-                       wi << "\n";
+                       if (r < nrows() - 1)
+                               wi << "\n";
                }
        }
        docstring const str = oss.str();
@@ -1954,12 +2142,14 @@ int InsetMathHull::docbook(odocstream & os, OutputParams const & runparams) cons
        ++ms.tab(); ms.cr(); ms.os() << '<' << bname << '>';
 
        odocstringstream ls;
+       TexRow texrow;
+       otexstream ols(ls, texrow);
        if (runparams.flavor == OutputParams::XML) {
                ms << MTag("alt role='tex' ");
                // Workaround for db2latex: db2latex always includes equations with
                // \ensuremath{} or \begin{display}\end{display}
                // so we strip LyX' math environment
-               WriteStream wi(ls, false, false, WriteStream::wsDefault, runparams.encoding);
+               WriteStream wi(ols, false, false, WriteStream::wsDefault, runparams.encoding);
                InsetMathGrid::write(wi);
                ms << from_utf8(subst(subst(to_utf8(ls.str()), "&", "&amp;"), "<", "&lt;"));
                ms << ETag("alt");
@@ -1969,9 +2159,6 @@ int InsetMathHull::docbook(odocstream & os, OutputParams const & runparams) cons
                InsetMathGrid::mathmlize(ms);
                ms << ETag("math");
        } else {
-               TexRow texrow;
-               texrow.reset();
-               otexstream ols(ls, texrow);
                ms << MTag("alt role='tex'");
                latex(ols, runparams);
                res = texrow.rows();
@@ -2003,7 +2190,7 @@ bool InsetMathHull::haveNumbers() const
        if (getType() == hullSimple)
                return havenumbers;
        for (size_t i = 0; i != numbered_.size(); ++i) {
-               if (numbered_[i]) {
+               if (numbered(i)) {
                        havenumbers = true;
                        break;
                }
@@ -2122,7 +2309,7 @@ void InsetMathHull::mathAsLatex(WriteStream & os) const
 
 docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
 {
-       BufferParams::MathOutput const mathtype = 
+       BufferParams::MathOutput const mathtype =
                buffer().masterBuffer()->params().html_math_output;
 
        bool success = false;
@@ -2146,10 +2333,10 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                } catch (MathExportException const &) {}
                if (success) {
                        if (getType() == hullSimple)
-                               xs << html::StartTag("math", 
+                               xs << html::StartTag("math",
                                                        "xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
-                       else 
-                               xs << html::StartTag("math", 
+                       else
+                               xs << html::StartTag("math",
                                      "display=\"block\" xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
                        xs << XHTMLStream::ESCAPE_NONE
                                 << os.str()
@@ -2170,14 +2357,14 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                           << html::EndTag(tag);
                }
        }
-       
+
        // what we actually want is this:
        // if (
-       //     ((mathtype == BufferParams::MathML || mathtype == BufferParams::HTML) 
+       //     ((mathtype == BufferParams::MathML || mathtype == BufferParams::HTML)
        //       && !success)
        //     || mathtype == BufferParams::Images
        //    )
-       // but what follows is equivalent, since we'll enter only if either (a) we 
+       // but what follows is equivalent, since we'll enter only if either (a) we
        // tried and failed with MathML or HTML or (b) didn't try yet at all but
        // aren't doing LaTeX, in which case we are doing Images.
        if (!success && mathtype != BufferParams::LaTeX) {
@@ -2213,7 +2400,7 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                        success = true;
                }
        }
-       
+
        // so we'll pass this test if we've failed everything else, or
        // if mathtype was LaTeX, since we won't have entered any of the
        // earlier branches
@@ -2221,18 +2408,20 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                // Unfortunately, we cannot use latexString() because we do not want
                // $...$ or whatever.
                odocstringstream ls;
-               WriteStream wi(ls, false, true, WriteStream::wsPreview);
+               TexRow texrow(false);
+               otexrowstream ots(ls,texrow);
+               WriteStream wi(ots, false, true, WriteStream::wsPreview);
                ModeSpecifier specifier(wi, MATH_MODE);
                mathAsLatex(wi);
                docstring const latex = ls.str();
-               
+
                // class='math' allows for use of jsMath
                // http://www.math.union.edu/~dpvc/jsMath/
                // FIXME XHTML
                // probably should allow for some kind of customization here
                string const tag = (getType() == hullSimple) ? "span" : "div";
                xs << html::StartTag(tag, "class='math'")
-                  << latex 
+                  << latex
                   << html::EndTag(tag)
                   << html::CR();
        }
@@ -2248,11 +2437,13 @@ void InsetMathHull::toString(odocstream & os) const
 }
 
 
-void InsetMathHull::forToc(docstring & os, size_t) const
+void InsetMathHull::forOutliner(docstring & os, size_t const, bool const) const
 {
        odocstringstream ods;
        OutputParams op(0);
        op.for_toc = true;
+       // FIXME: this results in spilling TeX into the LyXHTML output since the
+       // outliner is used to generate the LyXHTML list of figures/etc.
        plaintext(ods, op);
        os += ods.str();
 }