]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathHull.cpp
g-brief loads babel internally. So don't load it ourselves.
[lyx.git] / src / mathed / InsetMathHull.cpp
index b8808959dee466f49cc03263e7e7f9dc9758a3ff..94d293870d6911365b13c9395d798e864df1306a 100644 (file)
@@ -148,7 +148,7 @@ namespace {
 } // namespace
 
 
-static InsetLabel * dummy_pointer = 0;
+static InsetLabel * dummy_pointer = nullptr;
 
 InsetMathHull::InsetMathHull(Buffer * buf)
        : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NONUMBER),
@@ -228,14 +228,6 @@ void InsetMathHull::setBuffer(Buffer & buffer)
 }
 
 
-// FIXME This should really be controlled by the TOC level, or
-// something of the sort.
-namespace {
-       const char * counters_to_save[] = {"section", "chapter"};
-       unsigned int const numcnts = sizeof(counters_to_save)/sizeof(char *);
-} // namespace
-
-
 void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool const deleted)
 {
        if (!buffer_) {
@@ -253,21 +245,11 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool
                Counters & cnts =
                        buffer_->masterBuffer()->params().documentClass().counters();
 
-               // right now, we only need to do this at export time
-               if (utype == OutputUpdate) {
-                       for (size_t i = 0; i < numcnts; ++i) {
-                               docstring const cnt = from_ascii(counters_to_save[i]);
-                               if (cnts.hasCounter(cnt))
-                                       counter_map[cnt] = cnts.value(cnt);
-                       }
-               }
-
                // this has to be done separately
                docstring const eqstr = from_ascii("equation");
                if (cnts.hasCounter(eqstr)) {
-                       if (utype == OutputUpdate)
-                               counter_map[eqstr] = cnts.value(eqstr);
                        for (size_t i = 0; i != label_.size(); ++i) {
+                               docstring const oldnumber = numbers_[i];
                                if (numbered(i)) {
                                        Paragraph const & par = it.paragraph();
                                        if (!par.isDeleted(it.pos())) {
@@ -277,6 +259,12 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool
                                                numbers_[i] = from_ascii("#");
                                } else
                                        numbers_[i] = empty_docstring();
+                               // If the numbering has changed, trigger a new preview
+                               if (oldnumber != numbers_[i] && RenderPreview::previewMath()) {
+                                       // Do we need to remove it first?
+                                       //preview_->removePreview(*buffer_);
+                                       preparePreview(it);
+                               }
                        }
                }
        }
@@ -286,6 +274,32 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool
                if (label_[i])
                        label_[i]->updateBuffer(it, utype, deleted);
        }
+        // set up equation numbers
+
+       // compute first and last item
+       row_type first = nrows();
+       for (row_type row = 0; row != nrows(); ++row)
+               if (numbered(row)) {
+                       first = row;
+                       break;
+               }
+       if (first != nrows()) {
+               row_type last = nrows() - 1;
+               for (; last != 0; --last)
+                       if (numbered(last))
+                               break;
+
+               for (row_type row = 0; row != nrows(); ++row) {
+                       if (!numbered(row))
+                               continue;
+                       if (label_[row]) {
+                               label_[row]->setCounterValue(numbers_[row]);
+                               label_[row]->setPrettyCounter("(" + numbers_[row] + ")");
+                               label_[row]->setFormattedCounter("(" + numbers_[row] + ")");
+                       }
+               }
+       }
+
        // pass down
        InsetMathGrid::updateBuffer(it, utype, deleted);
 }
@@ -301,7 +315,6 @@ void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
                return;
        }
 
-       TocBuilder & b = backend.builder("equation");
        // compute first and last item
        row_type first = nrows();
        for (row_type row = 0; row != nrows(); ++row)
@@ -315,24 +328,47 @@ void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
        row_type last = nrows() - 1;
        for (; last != 0; --last)
                if (numbered(last))
-                       break;
-       // add equation numbers
-       b.pushItem(pit, docstring(), output_active);
+            break;
+
+       TocBuilder & b = backend.builder("equation");
+        b.pushItem(pit, docstring(), output_active);
        if (first != last)
                b.argumentItem(bformat(from_ascii("(%1$s-%2$s)"),
                                       numbers_[first], numbers_[last]));
+
+       odocstringstream ods;
+       Encoding const * enc = encodings.fromLyXName("utf8");
+       OutputParams ops(enc);
+       ops.for_toc = true;
+       int const max_length = 30;
+
        for (row_type row = 0; row != nrows(); ++row) {
                if (!numbered(row))
                        continue;
-               if (label_[row])
+               if (label_[row]) {
                        label_[row]->addToToc(pit, output_active, utype, backend);
+               }
                docstring label = nicelabel(row);
-               if (first == last)
+               if (first == last) {
                        // this is the only equation
-                       b.argumentItem(label);
-               else {
+                       plaintext(ods, ops, max_length);
+                       b.argumentItem(label + " " + ods.str());
+               } else {
                        // insert as sub-items
-                       b.pushItem(pit, label, output_active);
+                       otexrowstream ots(ods);
+                       TeXMathStream wi(ots, false, false, TeXMathStream::wsDefault, enc);
+                       docstring d;
+                       for (col_type c = 0; c < ncols(); ++c) {
+                               wi << cell(index(row, c));
+                               d = ods.str();
+                               if (d.size() > max_length) {
+                                       d = d.substr(0, max_length - 1);
+                                       break;
+                               }
+                       }
+                       b.pushItem(pit, label+ " " + d, output_active);
+                       // clear the stringstream
+                       odocstringstream().swap(ods);
                        b.pop();
                }
        }
@@ -487,6 +523,9 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
        if (mi.vmode)
                top_display_margin += theFontMetrics(mi.base.font).maxHeight() + 2;
 
+       int const ind = indent(*mi.base.bv);
+       mi.extrawidth = ind;
+
        if (previewState(mi.base.bv)) {
                preview_->metrics(mi, dim);
                if (previewTooSmall(dim)) {
@@ -518,14 +557,14 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
        if (numberedType()) {
                BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
                int extra_offset = 0;
+               int max_nlwid = 0;
                for (row_type row = 0; row < nrows(); ++row) {
                        rowinfo(row).offset[mi.base.bv] += extra_offset;
-                       if (!numbered(row))
-                               continue;
                        docstring const nl = nicelabel(row);
+                       if (nl.empty())
+                               continue;
                        Dimension dimnl;
                        mathed_string_dim(mi.base.font, nl, dimnl);
-                       int const ind = indent(*mi.base.bv);
                        int const x = ind ? ind : (mi.base.textwidth - dim.wid) / 2;
                        // for some reason metrics does not trigger at the
                        // same point as draw, and therefore we use >= instead of >
@@ -533,8 +572,10 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
                            || (math_number == BufferParams::RIGHT
                                && dimnl.wid >= mi.base.textwidth - x - dim.wid)) {
                                extra_offset += dimnl.height();
-                       }
+                       } else if (dimnl.wid > max_nlwid)
+                               max_nlwid = dimnl.wid;
                }
+               mi.extrawidth += max_nlwid;
                dim.des += extra_offset;
        }
 
@@ -589,13 +630,9 @@ void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
                    dim.wid, dim.asc + dim.des, backgroundColor(pi));
                return;
        }
-       // If there are numbers, the margins around the (displayed)
-       // equation have to be cleared.
-       if (numberedType())
-               pi.pain.fillRectangle(pi.leftx, y - dim.asc,
-                               pi.rightx - pi.leftx, dim.height(), pi.background_color);
+
        pi.pain.fillRectangle(x + 1, y - dim.asc + 1, dim.wid - 2,
-                       dim.asc + dim.des - 1, pi.backgroundColor(this));
+                             dim.height() - 1, pi.backgroundColor(this));
 }
 
 
@@ -626,11 +663,6 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
        }
 
        // First draw the numbers
-       ColorCode color = pi.selected && lyxrc.use_system_colors
-                               ? Color_selectiontext : standardColor();
-       bool const really_change_color = pi.base.font.color() == Color_none;
-       Changer dummy0 = really_change_color ? pi.base.font.changeColor(color)
-               : noChange();
        if (numberedType()) {
                BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
                for (row_type row = 0; row < nrows(); ++row) {
@@ -639,18 +671,36 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
                        Dimension dimnl;
                        mathed_string_dim(pi.base.font, nl, dimnl);
                        if (math_number == BufferParams::LEFT) {
+                               ColorCode const col = pi.selected_left
+                                       ? Color_selectiontext
+                                       : pi.base.font.color();
+                               Changer dummy0 = pi.base.font.changeColor(col);
                                if (dimnl.wid > x - pi.leftx)
                                        yy += rowinfo(row).descent + dimnl.asc;
+                               pi.pain.fillRectangle(pi.leftx, yy - dimnl.asc,
+                                       dimnl.width(), dimnl.height(),
+                                       pi.selected_left ? Color_selection : pi.background_color);
                                pi.draw(pi.leftx, yy, nl);
                        } else {
+                               ColorCode const col = pi.selected_right
+                                       ? Color_selectiontext
+                                       : pi.base.font.color();
+                               Changer dummy0 = pi.base.font.changeColor(col);
                                if (dimnl.wid > pi.rightx - x - dim.wid)
                                        yy += rowinfo(row).descent + dimnl.asc;
+                               pi.pain.fillRectangle(pi.rightx - dimnl.wid, yy - dimnl.asc,
+                                       dimnl.width(), dimnl.height(),
+                                       pi.selected_right ? Color_selection : pi.background_color);
                                pi.draw(pi.rightx - dimnl.wid, yy, nl);
                        }
                }
        }
 
        // Then the equations
+       ColorCode color = pi.selected ? Color_selectionmath : standardColor();
+       bool const really_change_color = pi.base.font.color() == Color_none;
+       Changer dummy0 = really_change_color ? pi.base.font.changeColor(color)
+               : noChange();
        Changer dummy1 = pi.base.changeFontSet(standardFont());
        Changer dummy2 = pi.base.font.changeStyle(display() ? DISPLAY_STYLE
                                                            : TEXT_STYLE);
@@ -705,7 +755,7 @@ static docstring latexString(InsetMathHull const & inset)
        // \newcommand{\xxx}{\text{$\phi$}}) gets processed twice. The
        // first time as a whole, and the second time only the inner math.
        // In this last case inset.buffer() would be invalid.
-       static Encoding const * encoding = 0;
+       static Encoding const * encoding = nullptr;
        if (inset.isBufferValid())
                encoding = &(inset.buffer().params().encoding());
        otexrowstream ots(ls);
@@ -827,29 +877,7 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
        if (lsize != "normalsize" && !prefixIs(lsize, "error"))
                setfont += from_ascii("\\" + lsize + '\n');
 
-       docstring setcnt;
-       if (forexport && haveNumbers()) {
-               docstring eqstr = from_ascii("equation");
-               CounterMap::const_iterator it = counter_map.find(eqstr);
-               if (it != counter_map.end()) {
-                       int num = it->second;
-                       if (num >= 0)
-                               setcnt += from_ascii("\\setcounter{") + eqstr + '}' +
-                                         '{' + convert<docstring>(num) + '}' + '\n';
-               }
-               for (size_t i = 0; i != numcnts; ++i) {
-                       docstring cnt = from_ascii(counters_to_save[i]);
-                       it = counter_map.find(cnt);
-                       if (it == counter_map.end())
-                                       continue;
-                       int num = it->second;
-                       if (num > 0)
-                               setcnt += from_ascii("\\setcounter{") + cnt + '}' +
-                                         '{' + convert<docstring>(num) + '}';
-               }
-       }
-       docstring const snippet = macro_preamble + setfont + setcnt
-                                 + latexString(*this) + endfont;
+       docstring const snippet = macro_preamble + setfont + latexString(*this) + endfont;
        LYXERR(Debug::MACROS, "Preview snippet: " << snippet);
        preview_->addPreview(snippet, *buffer, forexport);
 }
@@ -915,10 +943,6 @@ void InsetMathHull::label(row_type row, docstring const & label)
 void InsetMathHull::numbered(row_type row, Numbered num)
 {
        numbered_[row] = num;
-       if (!numbered(row) && label_[row]) {
-               delete label_[row];
-               label_[row] = 0;
-       }
 }
 
 
@@ -978,7 +1002,7 @@ bool InsetMathHull::outerDisplay() const
 }
 
 
-Inset::RowFlags InsetMathHull::rowFlags() const
+int InsetMathHull::rowFlags() const
 {
        switch (type_) {
        case hullUnknown:
@@ -1367,8 +1391,11 @@ void InsetMathHull::delCol(col_type col)
 
 docstring InsetMathHull::nicelabel(row_type row) const
 {
-       if (!numbered(row))
-               return docstring();
+       if (!numbered(row)) {
+               if (!label_[row])
+                       return docstring();
+               return '[' + label_[row]->screenLabel() + ']';
+       }
        docstring const & val = numbers_[row];
        if (!label_[row])
                return '(' + val + ')';
@@ -1381,7 +1408,7 @@ void InsetMathHull::glueall(HullType type)
        MathData ar;
        for (idx_type i = 0; i < nargs(); ++i)
                ar.append(cell(i));
-       InsetLabel * label = 0;
+       InsetLabel * label = nullptr;
        if (type == hullEquation) {
                // preserve first non-empty label
                for (row_type row = 0; row < nrows(); ++row) {
@@ -1671,27 +1698,36 @@ void InsetMathHull::mutate(HullType newtype)
 }
 
 
-docstring InsetMathHull::eolString(row_type row, bool fragile, bool latex,
-               bool last_eoln) const
+void InsetMathHull::eol(TeXMathStream & os, row_type row, bool fragile, bool latex,
+                        bool last_eoln) const
 {
-       docstring res;
        if (numberedType()) {
-               if (label_[row] && numbered(row)) {
-                       docstring const name =
-                               latex ? escape(label_[row]->getParam("name"))
-                                     : label_[row]->getParam("name");
-                       res += "\\label{" + name + '}';
+               bool const for_preview =
+                       (os.output() == TeXMathStream::wsPreview);
+               if (label_[row]) {
+                       // Use utf8 strings for previewed labels when possible
+                       bool use_utf8 = for_preview &&
+                               (buffer().params().useNonTeXFonts ||
+                                buffer().params().encoding().package() == Encoding::japanese);
+                       docstring const name = (latex && !use_utf8)
+                               ? escape(label_[row]->getParam("name"))
+                               : label_[row]->getParam("name");
+                       os << "\\label{" + name + '}';
                }
                if (type_ != hullMultline) {
                        if (numbered_[row]  == NONUMBER)
-                               res += "\\nonumber ";
+                               os << "\\nonumber ";
                        else if (numbered_[row]  == NOTAG)
-                               res += "\\notag ";
+                               os<< "\\notag ";
+               }
+               if (for_preview && !numbers_[row].empty()) {
+                       os << "\\global\\def\\theequation{" << numbers_[row] << "}\n";
                }
+
        }
        // Never add \\ on the last empty line of eqnarray and friends
        last_eoln = false;
-       return res + InsetMathGrid::eolString(row, fragile, latex, last_eoln);
+       InsetMathGrid::eol(os, row, fragile, latex, last_eoln);
 }
 
 void InsetMathHull::write(TeXMathStream & os) const
@@ -1847,11 +1883,22 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                //lyxerr << "toggling all numbers" << endl;
                cur.recordUndoInset();
                bool old = numberedType();
-               if (type_ == hullMultline)
-                       numbered(nrows() - 1, !old);
-               else
-                       for (row_type row = 0; row < nrows(); ++row)
+               if (type_ == hullMultline) {
+                       row_type row = nrows() - 1;
+                       numbered(row, !old);
+                       if (old && label_[row]) {
+                               delete label_[row];
+                               label_[row] = 0;
+                       }
+               } else {
+                       for (row_type row = 0; row < nrows(); ++row) {
                                numbered(row, !old);
+                               if (old && label_[row]) {
+                                       delete label_[row];
+                                       label_[row] = 0;
+                               }
+                       }
+               }
 
                cur.message(old ? _("No number") : _("Number"));
                cur.forceBufferUpdate();
@@ -1864,6 +1911,10 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                bool old = numbered(r);
                cur.message(old ? _("No number") : _("Number"));
                numbered(r, !old);
+               if (old && label_[r]) {
+                       delete label_[r];
+                       label_[r] = 0;
+               }
                cur.forceBufferUpdate();
                break;
        }
@@ -1898,7 +1949,7 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                        // if there is an argument, find the corresponding label, else
                        // check whether there is at least one label.
                        for (row = 0; row != nrows(); ++row)
-                               if (numbered(row) && label_[row]
+                               if (label_[row]
                                          && (cmd.argument().empty() || label(row) == cmd.argument()))
                                        break;
                }
@@ -2101,12 +2152,12 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                        // if there is no argument and we're inside math, we retrieve
                        // the row number from the cursor position.
                        row_type row = (type_ == hullMultline) ? nrows() - 1 : cur.row();
-                       enabled = numberedType() && label_[row] && numbered(row);
+                       enabled = numberedType() && label_[row];
                } else {
                        // if there is an argument, find the corresponding label, else
                        // check whether there is at least one label.
                        for (row_type row = 0; row != nrows(); ++row) {
-                               if (numbered(row) && label_[row] &&
+                               if (label_[row] &&
                                        (cmd.argument().empty() || label(row) == cmd.argument())) {
                                                enabled = true;
                                                break;
@@ -2192,28 +2243,6 @@ int InsetMathHull::border() const
 
 
 
-// simply scrap this function if you want
-void InsetMathHull::mutateToText()
-{
-#if 0
-       // translate to latex
-       ostringstream os;
-       latex(os, false, false);
-       string str = os.str();
-
-       // insert this text
-       Text * lt = view_->cursor().innerText();
-       string::const_iterator cit = str.begin();
-       string::const_iterator end = str.end();
-       for (; cit != end; ++cit)
-               view_->getIntl()->getTransManager().TranslateAndInsert(*cit, lt);
-
-       // remove ourselves
-       //dispatch(LFUN_ESCAPE);
-#endif
-}
-
-
 void InsetMathHull::handleFont(Cursor & cur, docstring const & arg,
        docstring const & font)
 {
@@ -2244,7 +2273,10 @@ void InsetMathHull::handleFont2(Cursor & cur, docstring const & arg)
 
 void InsetMathHull::edit(Cursor & cur, bool front, EntryDirection entry_from)
 {
-       InsetMathNest::edit(cur, front, entry_from);
+       cur.push(*this);
+       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_LEFT ||
+               (entry_from == Inset::ENTRY_DIRECTION_IGNORE && front));
+       enter_front ? idxFirst(cur) : idxLast(cur);
        // The inset formula dimension is not necessarily the same as the
        // one of the instant preview image, so we have to indicate to the
        // BufferView that a metrics update is needed.
@@ -2255,47 +2287,6 @@ void InsetMathHull::edit(Cursor & cur, bool front, EntryDirection entry_from)
 /////////////////////////////////////////////////////////////////////
 
 
-#if 0
-bool InsetMathHull::searchForward(BufferView * bv, string const & str,
-                                    bool, bool)
-{
-       // FIXME: completely broken
-       static InsetMathHull * lastformula = 0;
-       static CursorBase current = DocIterator(ibegin(nucleus()));
-       static MathData ar;
-       static string laststr;
-
-       if (lastformula != this || laststr != str) {
-               //lyxerr << "reset lastformula to " << this << endl;
-               lastformula = this;
-               laststr = str;
-               current = ibegin(nucleus());
-               ar.clear();
-               mathed_parse_cell(ar, str, Parse::NORMAL, &buffer());
-       } else {
-               increment(current);
-       }
-       //lyxerr << "searching '" << str << "' in " << this << ar << endl;
-
-       for (DocIterator it = current; it != iend(nucleus()); increment(it)) {
-               CursorSlice & top = it.back();
-               MathData const & a = top.asInsetMath()->cell(top.idx_);
-               if (a.matchpart(ar, top.pos_)) {
-                       bv->cursor().setSelection(it, ar.size());
-                       current = it;
-                       top.pos_ += ar.size();
-                       bv->update();
-                       return true;
-               }
-       }
-
-       //lyxerr << "not found!" << endl;
-       lastformula = 0;
-       return false;
-}
-#endif
-
-
 void InsetMathHull::write(ostream & os) const
 {
        odocstringstream oss;
@@ -2344,12 +2335,19 @@ int InsetMathHull::plaintext(odocstringstream & os,
        odocstringstream oss;
        otexrowstream ots(oss);
        Encoding const * const enc = encodings.fromLyXName("utf8");
-       TeXMathStream wi(ots, false, true, TeXMathStream::wsDefault, enc);
 
+       TeXMathStream::OutputType ot;
+       if (op.find_effective())
+               ot = TeXMathStream::wsSearchAdv;
+       else
+               ot = TeXMathStream::wsDefault;
        // Fix Bug #6139
-       if (type_ == hullRegexp)
+       if (type_ == hullRegexp) {
+               TeXMathStream wi(ots, false, true, ot, enc);
                write(wi);
+       }
        else {
+               TeXMathStream wi(ots, false, true, ot, enc);
                for (row_type r = 0; r < nrows(); ++r) {
                        for (col_type c = 0; c < ncols(); ++c)
                                wi << (c == 0 ? "" : "\t") << cell(index(r, c));
@@ -2416,7 +2414,7 @@ void InsetMathHull::docbook(XMLStream & xs, OutputParams const & runparams) cons
        }
 
        odocstringstream osmath;
-       MathMLStream ms(osmath, mathmlNamespacePrefix, true);
+       MathMLStream ms(osmath, mathmlNamespacePrefix);
 
        // Output the MathML subtree.
        // TeX transcription. Avoid MTag/ETag so that there are no extraneous spaces.
@@ -2439,7 +2437,7 @@ void InsetMathHull::docbook(XMLStream & xs, OutputParams const & runparams) cons
                // First, generate the MathML expression. If there is an error in the generation, this block is not fully
                // executed, and the formula is not output to the DocBook stream.
                odocstringstream ostmp;
-               MathMLStream mstmp(ostmp, ms.xmlns(), ms.xmlMode());
+               MathMLStream mstmp(ostmp, ms.xmlns());
                mathmlize(mstmp);
 
                // Choose the display style for the formula, to be output as an attribute near the formula root.
@@ -2527,69 +2525,105 @@ void InsetMathHull::htmlize(HtmlStream & os) const
 // and we simply do not have that in InsetMathGrid.
 void InsetMathHull::mathmlize(MathMLStream & ms) const
 {
-       bool const havenumbers = haveNumbers();
-       bool const havetable = havenumbers || nrows() > 1 || ncols() > 1;
+       bool const havetable = haveNumbers() || nrows() > 1 || ncols() > 1;
+
+       // Simplest case: single row, single column, no numbering.
+       if (!havetable) {
+               ms << cell(index(0, 0));
+               return;
+       }
+
+       // More complex case: wrap elements in a table.
+    if (getType() == hullSimple) {
+        ms << MTag("mtable");
+    } else if (getType() >= hullAlign && getType() <= hullXXAlignAt) {
+               // hullAlign, hullAlignAt, hullXAlignAt, hullXXAlignAt
+        string alignment;
+        for (col_type col = 0; col < ncols(); ++col) {
+            alignment += (col % 2) ? "left " : "right ";
+        }
+        ms << MTag("mtable", "displaystyle='true' columnalign='" + alignment + "'");
+    } else {
+        ms << MTag("mtable", "displaystyle='true'");
+    }
 
-       if (havetable)
-               ms << MTag("mtable");
-       char const * const celltag = havetable ? "mtd" : "mrow";
-       // FIXME There does not seem to be wide support at the moment
-       // for mlabeledtr, so we have to use just mtr for now.
-       // char const * const rowtag = havenumbers ? "mlabeledtr" : "mtr";
-       char const * const rowtag = "mtr";
        for (row_type row = 0; row < nrows(); ++row) {
-               if (havetable)
-                       ms << MTag(rowtag);
+               // No Wed browser supports mlabeledtr in 2023, even though it has been introduced in
+               // MathML 2 (2003). Moreover, it is not supported in MathML 4 Core.
+               ms << MTag("mtr");
+
                for (col_type col = 0; col < ncols(); ++col) {
-                       ms << MTag(celltag)
+                       ms << MTag("mtd")
                           << cell(index(row, col))
-                          << ETag(celltag);
+                          << ETag("mtd");
                }
+
                // fleqn?
-               if (havenumbers) {
+               if (haveNumbers()) {
                        ms << MTag("mtd");
                        docstring const & num = numbers_[row];
                        if (!num.empty())
                                ms << MTagInline("mtext") << '(' << num << ')' << ETagInline("mtext");
-                 ms << ETag("mtd");
+                   ms << ETag("mtd");
                }
-               if (havetable)
-                       ms << ETag(rowtag);
+
+               ms << ETag("mtr");
        }
-       if (havetable)
-               ms << ETag("mtable");
+
+       ms << ETag("mtable");
 }
 
 
-void InsetMathHull::mathAsLatex(TeXMathStream & os) const
+docstring InsetMathHull::mathAsLatex() const
 {
-       MathEnsurer ensurer(os, false);
-       bool havenumbers = haveNumbers();
+       bool const havenumbers = haveNumbers();
        bool const havetable = havenumbers || nrows() > 1 || ncols() > 1;
 
        if (!havetable) {
+               odocstringstream ls;
+               otexrowstream ots(ls);
+               TeXMathStream os(ots, false, true, TeXMathStream::wsPreview);
+               ModeSpecifier specifier(os, MATH_MODE);
+               MathEnsurer ensurer(os, false);
+
                os << cell(index(0, 0));
-               return;
+               return ls.str();
        }
 
-       os << "<table class='mathtable'>";
+       odocstringstream ods;
+       XMLStream xs(ods);
+
+       xs << xml::StartTag("table", "class='mathtable'");
        for (row_type row = 0; row < nrows(); ++row) {
-               os << "<tr>";
+               xs << xml::StartTag("tr");
                for (col_type col = 0; col < ncols(); ++col) {
-                       os << "<td class='math'>";
-                       os << cell(index(row, col));
-                       os << "</td>";
+                       xs << xml::StartTag("td", "class='math'");
+
+                       odocstringstream ls;
+                       otexrowstream ots(ls);
+                       TeXMathStream os(ots, false, true, TeXMathStream::wsPreview);
+                       ModeSpecifier specifier(os, MATH_MODE);
+                       MathEnsurer ensurer(os, false);
+
+                       os << cell(index(0, 0));
+                       // ls.str() contains a raw LaTeX string, which might require some encoding before being valid XML.
+                       xs << ls.str();
+
+                       xs << xml::EndTag("td");
                }
                if (havenumbers) {
-                       os << "<td>";
+                       xs << xml::StartTag("td");
                        docstring const & num = numbers_[row];
-                       if (!num.empty())
-                               os << '(' << num << ')';
-                 os << "</td>";
+                       if (!num.empty()) {
+                               xs << '(' << num << ')';
+                       }
+                       xs << xml::EndTag("td");
                }
-               os << "</tr>";
+               xs << xml::EndTag("tr");
        }
-       os << "</table>";
+       xs << xml::EndTag("table");
+
+       return ods.str();
 }
 
 
@@ -2618,16 +2652,23 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
                        success = true;
                } catch (MathExportException const &) {}
                if (success) {
+                       string const name_space_declaration = "xmlns='http://www.w3.org/1998/Math/MathML'";
                        if (getType() == hullSimple)
-                               xs << xml::StartTag("math",
-                                                       "xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
-                       else
-                               xs << xml::StartTag("math",
-                                     "display=\"block\" xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
+                           xs << xml::StartTag("math", name_space_declaration, true);
+                       else {
+                   if (!xs.isLastTagCR())
+                        xs << xml::CR();
+                   xs << xml::StartTag("math", name_space_declaration + " display='block'", true);
+                   }
+
                        xs << XMLStream::ESCAPE_NONE
-                                << os.str()
-                                << xml::EndTag("math");
+                          << os.str();
+
+                       if (!xs.isLastTagCR())
+                               xs << xml::CR();
+                       xs << xml::EndTag("math") << xml::CR();
                }
+               // In case of failure, generate an image.
        } else if (mathtype == BufferParams::HTML) {
                odocstringstream os;
                HtmlStream ms(os);
@@ -2642,6 +2683,7 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
                           << os.str()
                           << xml::EndTag(tag);
                }
+               // In case of failure, generate an image.
        }
 
        // what we actually want is this:
@@ -2656,7 +2698,7 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
        //
        // so this is for Images.
        if (!success && mathtype != BufferParams::LaTeX) {
-               graphics::PreviewImage const * pimage = 0;
+               graphics::PreviewImage const * pimage = nullptr;
                if (!op.dryrun) {
                        loadPreview(docit_);
                        pimage = preview_->getPreviewImage(buffer());
@@ -2682,7 +2724,7 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
                        string const tag = (getType() == hullSimple) ? "span" : "div";
                        xs << xml::CR()
                           << xml::StartTag(tag, "style = \"text-align: center;\"")
-                          << xml::CompTag("img", "src=\"" + filename + "\" alt=\"Mathematical Equation\"")
+                          << xml::CompTag("img", "src=\"" + filename + R"(" alt="Mathematical Equation")")
                           << xml::EndTag(tag)
                           << xml::CR();
                        success = true;
@@ -2695,12 +2737,8 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
        if (!success /* || mathtype != BufferParams::LaTeX */) {
                // Unfortunately, we cannot use latexString() because we do not want
                // $...$ or whatever.
-               odocstringstream ls;
-               otexrowstream ots(ls);
-               TeXMathStream wi(ots, false, true, TeXMathStream::wsPreview);
-               ModeSpecifier specifier(wi, MATH_MODE);
-               mathAsLatex(wi);
-               docstring const latex = ls.str();
+               // The returned value already has the correct escaping for HTML.
+               docstring const latex = mathAsLatex();
 
                // class='math' allows for use of jsMath
                // http://www.math.union.edu/~dpvc/jsMath/
@@ -2708,7 +2746,7 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
                // probably should allow for some kind of customization here
                string const tag = (getType() == hullSimple) ? "span" : "div";
                xs << xml::StartTag(tag, "class='math'")
-                  << latex
+                  << XMLStream::ESCAPE_NONE << latex // Don't escape anything: latex might contain XML.
                   << xml::EndTag(tag)
                   << xml::CR();
        }
@@ -2719,7 +2757,7 @@ docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
 void InsetMathHull::toString(odocstream & os) const
 {
        odocstringstream ods;
-       plaintext(ods, OutputParams(0));
+       plaintext(ods, OutputParams(nullptr));
        os << ods.str();
 }
 
@@ -2727,7 +2765,7 @@ void InsetMathHull::toString(odocstream & os) const
 void InsetMathHull::forOutliner(docstring & os, size_t const, bool const) const
 {
        odocstringstream ods;
-       OutputParams op(0);
+       OutputParams op(nullptr);
        op.for_toc = true;
        // FIXME: this results in spilling TeX into the LyXHTML output since the
        // outliner is used to generate the LyXHTML list of figures/etc.