]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathHull.cpp
This patch does two closely related things.
[lyx.git] / src / mathed / InsetMathHull.cpp
index 5b884b4a6259f558a9f7e33046c486ac5258785e..513a8963345ae7ba0fe0083f02b8e234c4879de6 100644 (file)
@@ -38,6 +38,7 @@
 #include "MacroTable.h"
 #include "MathMacro.h"
 #include "MathMacroTemplate.h"
+#include "MetricsInfo.h"
 #include "output_xhtml.h"
 #include "Paragraph.h"
 #include "ParIterator.h"
@@ -79,17 +80,25 @@ namespace {
        int getCols(HullType type)
        {
                switch (type) {
-                       case hullEqnArray:
-                               return 3;
-                       case hullAlign:
-                       case hullFlAlign:
-                       case hullAlignAt:
-                       case hullXAlignAt:
-                       case hullXXAlignAt:
-                               return 2;
-                       default:
-                               return 1;
+               case hullEqnArray:
+                       return 3;
+               case hullAlign:
+               case hullFlAlign:
+               case hullAlignAt:
+               case hullXAlignAt:
+               case hullXXAlignAt:
+                       return 2;
+               case hullUnknown:
+               case hullNone:
+               case hullSimple:
+               case hullEquation:
+               case hullMultline:
+               case hullGather:
+               case hullRegexp:
+                       return 1;
                }
+               // avoid warning
+               return 0;
        }
 
 
@@ -98,7 +107,7 @@ namespace {
        size_t firstRelOp(MathData const & ar)
        {
                for (MathData::const_iterator it = ar.begin(); it != ar.end(); ++it)
-                       if ((*it)->isRelOp())
+                       if ((*it)->isMathRel())
                                return it - ar.begin();
                return ar.size();
        }
@@ -128,29 +137,30 @@ HullType hullType(docstring const & s)
        if (s == "flalign")   return hullFlAlign;
        if (s == "regexp")    return hullRegexp;
        lyxerr << "unknown hull type '" << to_utf8(s) << "'" << endl;
-       return HullType(-1);
+       return hullUnknown;
 }
 
 
 docstring hullName(HullType type)
 {
        switch (type) {
-               case hullNone:       return from_ascii("none");
-               case hullSimple:     return from_ascii("simple");
-               case hullEquation:   return from_ascii("equation");
-               case hullEqnArray:   return from_ascii("eqnarray");
-               case hullAlign:      return from_ascii("align");
-               case hullAlignAt:    return from_ascii("alignat");
-               case hullXAlignAt:   return from_ascii("xalignat");
-               case hullXXAlignAt:  return from_ascii("xxalignat");
-               case hullMultline:   return from_ascii("multline");
-               case hullGather:     return from_ascii("gather");
-               case hullFlAlign:    return from_ascii("flalign");
-               case hullRegexp:     return from_ascii("regexp");
-               default:
-                       lyxerr << "unknown hull type '" << type << "'" << endl;
-                       return from_ascii("none");
+       case hullNone:       return from_ascii("none");
+       case hullSimple:     return from_ascii("simple");
+       case hullEquation:   return from_ascii("equation");
+       case hullEqnArray:   return from_ascii("eqnarray");
+       case hullAlign:      return from_ascii("align");
+       case hullAlignAt:    return from_ascii("alignat");
+       case hullXAlignAt:   return from_ascii("xalignat");
+       case hullXXAlignAt:  return from_ascii("xxalignat");
+       case hullMultline:   return from_ascii("multline");
+       case hullGather:     return from_ascii("gather");
+       case hullFlAlign:    return from_ascii("flalign");
+       case hullRegexp:     return from_ascii("regexp");
+       case hullUnknown:
+               lyxerr << "unknown hull type" << endl;
+               break;
        }
+       return from_ascii("none");
 }
 
 static InsetLabel * dummy_pointer = 0;
@@ -158,7 +168,7 @@ static InsetLabel * dummy_pointer = 0;
 InsetMathHull::InsetMathHull(Buffer * buf)
        : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
-         preview_(new RenderPreview(this)), use_preview_(false)
+         preview_(new RenderPreview(this))
 {
        //lyxerr << "sizeof InsetMath: " << sizeof(InsetMath) << endl;
        //lyxerr << "sizeof MetricsInfo: " << sizeof(MetricsInfo) << endl;
@@ -173,7 +183,7 @@ InsetMathHull::InsetMathHull(Buffer * buf)
 InsetMathHull::InsetMathHull(Buffer * buf, HullType type)
        : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
-         preview_(new RenderPreview(this)), use_preview_(false)
+         preview_(new RenderPreview(this))
 {
        buffer_ = buf;
        initMath();
@@ -316,7 +326,7 @@ void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
 
 Inset * InsetMathHull::editXY(Cursor & cur, int x, int y)
 {
-       if (use_preview_) {
+       if (previewState(&cur.bv())) {
                edit(cur, true);
                return this;
        }
@@ -326,9 +336,26 @@ Inset * InsetMathHull::editXY(Cursor & cur, int x, int y)
 
 InsetMath::mode_type InsetMathHull::currentMode() const
 {
-       if (type_ == hullNone)
+       switch (type_) {
+       case hullNone:
                return UNDECIDED_MODE;
+
        // definitely math mode ...
+       case hullUnknown:
+       case hullSimple:
+       case hullEquation:
+       case hullMultline:
+       case hullGather:
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullRegexp:
+               return MATH_MODE;
+       }
+       // avoid warning
        return MATH_MODE;
 }
 
@@ -349,74 +376,79 @@ bool InsetMathHull::idxLast(Cursor & cur) const
 }
 
 
+// FIXME: InsetMathGrid should be changed to let the real column alignment be
+// given by a virtual method like displayColAlign, because the values produced
+// by defaultColAlign can be invalidated by lfuns such as add-column. For the
+// moment the values produced by defaultColAlign are not used, notably because
+// alignment is not implemented in the LyXHTML output.
 char InsetMathHull::defaultColAlign(col_type col)
 {
-       if (type_ == hullEqnArray)
-               return "rcl"[col];
-       if (type_ == hullMultline)
-               return 'c';
-       if (type_ == hullGather)
-               return 'c';
-       if (type_ >= hullAlign)
-               return "rl"[col & 1];
-       return 'c';
+       return colAlign(type_, col);
 }
 
 
 char InsetMathHull::displayColAlign(idx_type idx) const
 {
-       if (type_ == hullMultline) {
+       switch (type_) {
+       case hullMultline: {
                row_type const r = row(idx);
                if (r == 0)
                        return 'l';
                if (r == nrows() - 1)
                        return 'r';
+               return 'c';
+       }
+       case hullEqnArray:
+       case hullGather:
+       case hullAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullFlAlign:
+               return colAlign(type_, col(idx));
+       default:
+               break;
        }
        return InsetMathGrid::displayColAlign(idx);
 }
 
 
+int InsetMathHull::displayColSpace(col_type col) const
+{
+       return colSpace(type_, col);
+}
+
+
+// FIXME: same comment as for defaultColAlign applies.
 int InsetMathHull::defaultColSpace(col_type col)
 {
-       if (type_ == hullAlign || type_ == hullAlignAt)
-               return 0;
-       if (type_ == hullXAlignAt)
-               return (col & 1) ? 20 : 0;
-       if (type_ == hullXXAlignAt || type_ == hullFlAlign)
-               return (col & 1) ? 40 : 0;
-       return 0;
+       return colSpace(type_, col);
 }
 
 
-docstring InsetMathHull::standardFont() const
+string InsetMathHull::standardFont() const
 {
-       docstring font_name;
        switch (type_) {
        case hullRegexp:
-               font_name = from_ascii("texttt");
-               break;
+               return "texttt";
        case hullNone:
-               font_name = from_ascii("lyxnochange");
-               break;
+               return "lyxnochange";
        default:
-               font_name = from_ascii("mathnormal");
+               return "mathnormal";
        }
-       return font_name;
 }
 
 
 ColorCode InsetMathHull::standardColor() const
 {
-       ColorCode color;
        switch (type_) {
        case hullRegexp:
        case hullNone:
-               color = Color_foreground;
-               break;
+               return Color_foreground;
+
        default:
-               color = Color_math;
+               return Color_math;
        }
-       return color;
 }
 
 
@@ -456,8 +488,9 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
                return;
        }
 
-       FontSetChanger dummy1(mi.base, standardFont());
-       StyleChanger dummy2(mi.base, display() ? LM_ST_DISPLAY : LM_ST_TEXT);
+       // FIXME: Changing the same object repeatedly is inefficient.
+       Changer dummy1 = mi.base.changeFontSet(standardFont());
+       Changer dummy2 = mi.base.changeStyle(display() ? LM_ST_DISPLAY : LM_ST_TEXT);
 
        // let the cells adjust themselves
        InsetMathGrid::metrics(mi, dim);
@@ -468,7 +501,7 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
        }
 
        if (numberedType()) {
-               FontSetChanger dummy(mi.base, from_ascii("mathbf"));
+               Changer dummy = mi.base.changeFontSet("mathbf");
                int l = 0;
                for (row_type row = 0; row < nrows(); ++row)
                        l = max(l, mathed_string_width(mi.base.font, nicelabel(row)));
@@ -526,7 +559,6 @@ void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
 void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
 {
        BufferView const * const bv = pi.base.bv;
-       use_preview_ = previewState(bv);
 
        if (type_ == hullRegexp) {
                Dimension const dim = dimension(*bv);
@@ -534,7 +566,7 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
                        dim.width() - 2, dim.height() - 2, Color_regexpframe);
        }
 
-       if (use_preview_) {
+       if (previewState(bv)) {
                Dimension const dim = dimension(*bv);
                if (previewTooSmall(dim)) {
                        // we have an extra frame
@@ -550,9 +582,9 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
        ColorCode color = pi.selected && lyxrc.use_system_colors
                                ? Color_selectiontext : standardColor();
        bool const really_change_color = pi.base.font.color() == Color_none;
-       ColorChanger dummy0(pi.base.font, color, really_change_color);
-       FontSetChanger dummy1(pi.base, standardFont());
-       StyleChanger dummy2(pi.base, display() ? LM_ST_DISPLAY : LM_ST_TEXT);
+       Changer dummy0 = pi.base.font.changeColor(color, really_change_color);
+       Changer dummy1 = pi.base.changeFontSet(standardFont());
+       Changer dummy2 = pi.base.changeStyle(display() ? LM_ST_DISPLAY : LM_ST_TEXT);
 
        InsetMathGrid::draw(pi, x + 1, y);
 
@@ -560,7 +592,7 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
                int const xx = x + colinfo_.back().offset_ + colinfo_.back().width_ + 20;
                for (row_type row = 0; row < nrows(); ++row) {
                        int const yy = y + rowinfo_[row].offset_;
-                       FontSetChanger dummy(pi.base, from_ascii("mathrm"));
+                       Changer dummy = pi.base.changeFontSet("mathrm");
                        docstring const nl = nicelabel(row);
                        pi.draw(xx, yy, nl);
                }
@@ -720,9 +752,7 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
                macro_preamble.append(*it);
 
        // set the font series and size for this snippet
-       DocIterator dit = pos;
-       while (dit.inMathed())
-               dit.pop_back();
+       DocIterator dit = pos.getInnerText();
        Paragraph const & par = dit.paragraph();
        Font font = par.getFontSettings(buffer->params(), dit.pos());
        font.fontInfo().realize(par.layout().font);
@@ -840,20 +870,22 @@ bool InsetMathHull::numbered(row_type row) const
 bool InsetMathHull::ams() const
 {
        switch (type_) {
-               case hullAlign:
-               case hullFlAlign:
-               case hullMultline:
-               case hullGather:
-               case hullAlignAt:
-               case hullXAlignAt:
-               case hullXXAlignAt:
-                       return true;
-               case hullNone:
-               case hullSimple:
-               case hullEquation:
-               case hullEqnArray:
-               case hullRegexp:
-                       break;
+       case hullAlign:
+       case hullFlAlign:
+       case hullMultline:
+       case hullGather:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+               return true;
+       case hullUnknown:
+       case hullRegexp:
+               return false;
+       case hullNone:
+       case hullSimple:
+       case hullEquation:
+       case hullEqnArray:
+               break;
        }
        for (size_t row = 0; row < numbered_.size(); ++row)
                if (numbered_[row] == NOTAG)
@@ -864,21 +896,46 @@ bool InsetMathHull::ams() const
 
 Inset::DisplayType InsetMathHull::display() const
 {
-       if (type_ == hullSimple || type_ == hullNone || type_ == hullRegexp)
+       switch (type_) {
+       case hullUnknown:
+       case hullSimple:
+       case hullNone:
+       case hullRegexp:
                return Inline;
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullEquation:
+       case hullMultline:
+       case hullGather:
+               return AlignCenter;
+       }
+       // avoid warning
        return AlignCenter;
 }
 
 bool InsetMathHull::numberedType() const
 {
-       if (type_ == hullNone)
-               return false;
-       if (type_ == hullSimple)
-               return false;
-       if (type_ == hullXXAlignAt)
-               return false;
-       if (type_ == hullRegexp)
+       switch (type_) {
+       case hullUnknown:
+       case hullNone:
+       case hullSimple:
+       case hullXXAlignAt:
+       case hullRegexp:
                return false;
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullEquation:
+       case hullMultline:
+       case hullGather:
+               break;
+       }
        for (row_type row = 0; row < nrows(); ++row)
                if (numbered(row))
                        return true;
@@ -977,7 +1034,7 @@ void InsetMathHull::header_write(WriteStream & os) const
                os << "\\regexp{";
                break;
 
-       default:
+       case hullUnknown:
                os << "\n";
                os.startOuterRow();
                os << "\\begin{unknown" << star(n) << "}\n";
@@ -1031,7 +1088,7 @@ void InsetMathHull::footer_write(WriteStream & os) const
                os << "\\endregexp{}}";
                break;
 
-       default:
+       case hullUnknown:
                os << "\n";
                os.startOuterRow();
                os << "\\end{unknown" << star(n) << "}\n";
@@ -1040,6 +1097,29 @@ void InsetMathHull::footer_write(WriteStream & os) const
 }
 
 
+bool InsetMathHull::allowsTabularFeatures() const
+{
+       switch (type_) {
+       case hullEqnArray:
+       case hullAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullFlAlign:
+       case hullMultline:
+       case hullGather:
+               return true;
+       case hullNone:
+       case hullSimple:
+       case hullEquation:
+       case hullRegexp:
+       case hullUnknown:
+               break;
+       }
+       return false;
+}
+
+
 bool InsetMathHull::rowChangeOK() const
 {
        return
@@ -1241,10 +1321,46 @@ void InsetMathHull::setType(HullType type)
 }
 
 
+bool InsetMathHull::isMutable(HullType type)
+{
+       switch (type) {
+       case hullNone:
+       case hullSimple:
+       case hullEquation:
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullMultline:
+       case hullGather:
+               return true;
+       case hullUnknown:
+       case hullRegexp:
+               return false;
+       }
+       // avoid warning
+       return false;
+}
+
+
 void InsetMathHull::mutate(HullType newtype)
 {
        //lyxerr << "mutating from '" << type_ << "' to '" << newtype << "'" << endl;
 
+       if (newtype == type_)
+               return;
+
+       // This guards the algorithm below it, which is designed with certain types
+       // in mind.
+       if (!isMutable(newtype) || !isMutable(type_)) {
+               lyxerr << "mutation from '" << to_utf8(hullName(type_))
+                      << "' to '" << to_utf8(hullName(newtype))
+                      << "' not implemented" << endl;
+               return;
+       }
+
        // we try to move along the chain
        // none <-> simple <-> equation <-> eqnarray -> *align* -> multline, gather -+
        //                                     ^                                     |
@@ -1253,22 +1369,14 @@ void InsetMathHull::mutate(HullType newtype)
        // directly supported because it handles labels and numbering for
        // "down mutation".
 
-       if (newtype == type_) {
-               // done
-       }
-
-       else if (newtype < hullNone) {
-               // unknown type
-               dump();
-       }
-
-       else if (type_ == hullNone) {
+       switch (type_) {
+       case hullNone:
                setType(hullSimple);
                numbered(0, false);
                mutate(newtype);
-       }
+               break;
 
-       else if (type_ == hullSimple) {
+       case hullSimple:
                if (newtype == hullNone) {
                        setType(hullNone);
                        numbered(0, false);
@@ -1277,95 +1385,138 @@ void InsetMathHull::mutate(HullType newtype)
                        numbered(0, label_[0] ? true : false);
                        mutate(newtype);
                }
-       }
+               break;
 
-       else if (type_ == hullEquation) {
-               if (newtype < type_) {
+       case hullEquation:
+               switch (newtype) {
+               case hullNone:
+               case hullSimple:
                        setType(hullSimple);
                        numbered(0, false);
                        mutate(newtype);
-               } else if (newtype == hullEqnArray) {
+                       break;
+               case hullEqnArray:
                        // split it "nicely" on the first relop
                        splitTo3Cols();
                        setType(hullEqnArray);
-               } else if (newtype == hullMultline || newtype == hullGather) {
+                       break;
+               case hullMultline:
+               case hullGather:
                        setType(newtype);
-               } else {
+                       break;
+               default:
+                       // *align*
                        // split it "nicely"
                        splitTo2Cols();
                        setType(hullAlign);
                        mutate(newtype);
+                       break;
                }
-       }
+               break;
 
-       else if (type_ == hullEqnArray) {
-               if (newtype < type_) {
+       case hullEqnArray:
+               switch (newtype) {
+               case hullNone:
+               case hullSimple:
+               case hullEquation:
                        glueall(newtype);
                        mutate(newtype);
-               } else { // align & Co.
+                       break;
+               default:
+                       // align & Co.
                        changeCols(2);
                        setType(hullAlign);
                        mutate(newtype);
+                       break;
                }
-       }
+               break;
 
-       else if (type_ ==  hullAlign || type_ == hullAlignAt ||
-                type_ == hullXAlignAt || type_ == hullFlAlign) {
-               if (newtype < hullAlign) {
+       case hullAlign:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullFlAlign:
+               switch (newtype) {
+               case hullNone:
+               case hullSimple:
+               case hullEquation:
+               case hullEqnArray:
                        changeCols(3);
                        setType(hullEqnArray);
                        mutate(newtype);
-               } else if (newtype == hullGather || newtype == hullMultline) {
+                       break;
+               case hullGather:
+               case hullMultline:
                        changeCols(1);
                        setType(newtype);
-               } else if (newtype ==   hullXXAlignAt) {
+                       break;
+               case hullXXAlignAt:
                        for (row_type row = 0; row < nrows(); ++row)
                                numbered(row, false);
                        setType(newtype);
-               } else {
+                       break;
+               default:
                        setType(newtype);
+                       break;
                }
-       }
+               break;
 
-       else if (type_ == hullXXAlignAt) {
+       case hullXXAlignAt:
                for (row_type row = 0; row < nrows(); ++row)
                        numbered(row, false);
-               if (newtype < hullAlign) {
+               switch (newtype) {
+               case hullNone:
+               case hullSimple:
+               case hullEquation:
+               case hullEqnArray:
                        changeCols(3);
                        setType(hullEqnArray);
                        mutate(newtype);
-               } else if (newtype == hullGather || newtype == hullMultline) {
+                       break;
+               case hullGather:
+               case hullMultline:
                        changeCols(1);
                        setType(newtype);
-               } else {
+                       break;
+               default:
                        setType(newtype);
+                       break;
                }
-       }
+               break;
 
-       else if (type_ == hullMultline || type_ == hullGather) {
-               if (newtype == hullGather || newtype == hullMultline)
+       case hullMultline:
+       case hullGather:
+               switch (newtype) {
+               case hullGather:
+               case hullMultline:
                        setType(newtype);
-               else if (newtype == hullAlign || newtype == hullFlAlign  ||
-                        newtype == hullAlignAt || newtype == hullXAlignAt) {
+                       break;
+               case hullAlign:
+               case hullFlAlign:
+               case hullAlignAt:
+               case hullXAlignAt:
                        splitTo2Cols();
                        setType(newtype);
-               } else if (newtype ==   hullXXAlignAt) {
+                       break;
+               case hullXXAlignAt:
                        splitTo2Cols();
                        for (row_type row = 0; row < nrows(); ++row)
                                numbered(row, false);
                        setType(newtype);
-               } else {
+                       break;
+               default:
+                       // first we mutate to EqnArray
                        splitTo3Cols();
                        setType(hullEqnArray);
                        mutate(newtype);
+                       break;
                }
-       }
+               break;
 
-       else {
-               lyxerr << "mutation from '" << to_utf8(hullName(type_))
-                      << "' to '" << to_utf8(hullName(newtype))
-                      << "' not implemented" << endl;
-       }
+       default:
+               // we passed the guard so we should not be here
+               LASSERT("Mutation not implemented, but should have been.", return);
+               break;
+       }// switch
 }
 
 
@@ -1443,7 +1594,12 @@ void InsetMathHull::doExtern(Cursor & cur, FuncRequest & func)
        }
 
        // only inline, display or eqnarray math is allowed
-       if (getType() > hullEqnArray) {
+       switch (getType()) {
+       case hullSimple:
+       case hullEquation:
+       case hullEqnArray:
+               break;
+       default:
                frontend::Alert::warning(_("Bad math environment"),
                                _("Computation cannot be performed for AMS "
                                  "math environments.\nChange the math "
@@ -1702,6 +1858,13 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
+       case LFUN_TABULAR_FEATURE:
+               if (!allowsTabularFeatures())
+                       cur.undispatched();
+               else
+                       InsetMathGrid::doDispatch(cur, cmd);
+               break;
+
        default:
                InsetMathGrid::doDispatch(cur, cmd);
                break;
@@ -1709,6 +1872,21 @@ void InsetMathHull::doDispatch(Cursor & cur, FuncRequest & cmd)
 }
 
 
+namespace {
+
+bool allowDisplayMath(Cursor const & cur)
+{
+       LATTEST(cur.depth() > 1);
+       Cursor tmpcur = cur;
+       tmpcur.pop();
+       FuncStatus status;
+       FuncRequest cmd(LFUN_MATH_DISPLAY);
+       return tmpcur.getStatus(cmd, status) && status.enabled();
+}
+
+}
+
+
 bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                FuncStatus & status) const
 {
@@ -1733,32 +1911,14 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_MATH_MUTATE: {
                HullType const ht = hullType(cmd.argument());
                status.setOnOff(type_ == ht);
-               status.setEnabled(true);
+               status.setEnabled(isMutable(ht) && isMutable(type_));
 
-               if (ht != hullSimple) {
-                       Cursor tmpcur = cur;
-                       while (!tmpcur.empty()) {
-                               InsetCode code = tmpcur.inset().lyxCode();
-                               if (code == BOX_CODE) {
-                                       return true;
-                               } else if (code == TABULAR_CODE) {
-                                       FuncRequest tmpcmd(LFUN_MATH_DISPLAY);
-                                       if (tmpcur.getStatus(tmpcmd, status) && !status.enabled())
-                                               return true;
-                               }
-                               tmpcur.pop_back();
-                       }
-               }
+               if (ht != hullSimple && status.enabled())
+                       status.setEnabled(allowDisplayMath(cur));
                return true;
        }
        case LFUN_MATH_DISPLAY: {
-               bool enable = true;
-               if (cur.depth() > 1) {
-                       Inset const & in = cur[cur.depth()-2].inset();
-                       if (in.lyxCode() == SCRIPT_CODE)
-                               enable = display() != Inline;
-               }
-               status.setEnabled(enable);
+               status.setEnabled(display() != Inline || allowDisplayMath(cur));
                status.setOnOff(display() != Inline);
                return true;
        }
@@ -1817,6 +1977,8 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                return InsetMathGrid::getStatus(cur, cmd, status);
 
        case LFUN_TABULAR_FEATURE: {
+               if (!allowsTabularFeatures())
+                       return false;
                string s = cmd.getArg(0);
                if (!rowChangeOK()
                    && (s == "append-row"
@@ -1838,16 +2000,6 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
                        status.setEnabled(false);
                        return true;
                }
-               if ((type_ == hullSimple
-                 || type_ == hullEquation
-                 || type_ == hullNone) &&
-                   (s == "add-hline-above" || s == "add-hline-below")) {
-                       status.message(bformat(
-                               from_utf8(N_("Can't add horizontal grid lines in '%1$s'")),
-                               hullName(type_)));
-                       status.setEnabled(false);
-                       return true;
-               }
                if (s == "add-vline-left" || s == "add-vline-right") {
                        status.message(bformat(
                                from_utf8(N_("Can't add vertical grid lines in '%1$s'")),