]> git.lyx.org Git - lyx.git/blobdiff - src/mathed/InsetMathHull.cpp
MathML stream allows for name spaces.
[lyx.git] / src / mathed / InsetMathHull.cpp
index 9c53f6fbe8f83c74ab0e1dc0f33e30885ec3068e..465ba6466b73b46865f4e37edc2be7b221cab0db 100644 (file)
@@ -15,7 +15,6 @@
 #include "InsetMathChar.h"
 #include "InsetMathColor.h"
 #include "InsetMathFrac.h"
-#include "InsetMathGrid.h"
 #include "InsetMathNest.h"
 #include "InsetMathScript.h"
 #include "MathExtern.h"
 #include "LaTeXFeatures.h"
 #include "LyXRC.h"
 #include "MacroTable.h"
-#include "MathMacro.h"
-#include "MathMacroTemplate.h"
+#include "InsetMathMacro.h"
+#include "InsetMathMacroTemplate.h"
 #include "MetricsInfo.h"
 #include "output_xhtml.h"
 #include "Paragraph.h"
 #include "ParIterator.h"
-#include "sgml.h"
+#include "xml.h"
 #include "TexRow.h"
 #include "TextClass.h"
 #include "TextPainter.h"
@@ -109,7 +108,7 @@ namespace {
        size_t firstRelOp(MathData const & ar)
        {
                for (MathData::const_iterator it = ar.begin(); it != ar.end(); ++it)
-                       if ((*it)->isMathRel())
+                       if ((*it)->mathClass() == MC_REL)
                                return it - ar.begin();
                return ar.size();
        }
@@ -121,7 +120,34 @@ namespace {
        }
 
 
-} // end anon namespace
+       // writes a preamble for underlined or struck out math display
+       void writeMathdisplayPreamble(WriteStream & os)
+       {
+               if (os.strikeoutMath())
+                       return;
+
+               if (os.ulemCmd() == WriteStream::UNDERLINE)
+                       os << "\\raisebox{-\\belowdisplayshortskip}{"
+                             "\\parbox[b]{\\linewidth}{";
+               else if (os.ulemCmd() == WriteStream::STRIKEOUT)
+                       os << "\\parbox{\\linewidth}{";
+       }
+
+
+       // writes a postamble for underlined or struck out math display
+       void writeMathdisplayPostamble(WriteStream & os)
+       {
+               if (os.strikeoutMath())
+                       return;
+
+               if (os.ulemCmd() == WriteStream::UNDERLINE)
+                       os << "}}\\\\\n";
+               else if (os.ulemCmd() == WriteStream::STRIKEOUT)
+                       os << "}\\\\\n";
+       }
+
+
+} // namespace
 
 
 HullType hullType(docstring const & s)
@@ -168,7 +194,7 @@ docstring hullName(HullType type)
 static InsetLabel * dummy_pointer = 0;
 
 InsetMathHull::InsetMathHull(Buffer * buf)
-       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NUMBER),
+       : InsetMathGrid(buf, 1, 1), type_(hullNone), numbered_(1, NONUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
          preview_(new RenderPreview(this))
 {
@@ -183,7 +209,7 @@ InsetMathHull::InsetMathHull(Buffer * buf)
 
 
 InsetMathHull::InsetMathHull(Buffer * buf, HullType type)
-       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NUMBER),
+       : InsetMathGrid(buf, getCols(type), 1), type_(type), numbered_(1, NONUMBER),
          numbers_(1, empty_docstring()), label_(1, dummy_pointer),
          preview_(new RenderPreview(this))
 {
@@ -250,10 +276,10 @@ void InsetMathHull::setBuffer(Buffer & buffer)
 namespace {
        const char * counters_to_save[] = {"section", "chapter"};
        unsigned int const numcnts = sizeof(counters_to_save)/sizeof(char *);
-}
+} // namespace
 
 
-void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
+void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype, bool const deleted)
 {
        if (!buffer_) {
                //FIXME: buffer_ should be set at creation for this inset! Problem is
@@ -286,8 +312,12 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
                                counter_map[eqstr] = cnts.value(eqstr);
                        for (size_t i = 0; i != label_.size(); ++i) {
                                if (numbered(i)) {
-                                       cnts.step(eqstr, utype);
-                                       numbers_[i] = cnts.theCounter(eqstr, lang);
+                                       Paragraph const & par = it.paragraph();
+                                       if (!par.isDeleted(it.pos())) {
+                                               cnts.step(eqstr, utype);
+                                               numbers_[i] = cnts.theCounter(eqstr, lang);
+                                       } else
+                                               numbers_[i] = from_ascii("#");
                                } else
                                        numbers_[i] = empty_docstring();
                        }
@@ -297,15 +327,15 @@ void InsetMathHull::updateBuffer(ParIterator const & it, UpdateType utype)
        // now the labels
        for (size_t i = 0; i != label_.size(); ++i) {
                if (label_[i])
-                       label_[i]->updateBuffer(it, utype);
+                       label_[i]->updateBuffer(it, utype, deleted);
        }
        // pass down
-       InsetMathGrid::updateBuffer(it, utype);
+       InsetMathGrid::updateBuffer(it, utype, deleted);
 }
 
 
 void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
-                                                        UpdateType utype) const
+                                                        UpdateType utype, TocBackend & backend) const
 {
        if (!buffer_) {
                //FIXME: buffer_ should be set at creation for this inset! Problem is
@@ -314,15 +344,42 @@ void InsetMathHull::addToToc(DocIterator const & pit, bool output_active,
                return;
        }
 
-       shared_ptr<Toc> toc = buffer().tocBackend().toc("equation");
-
+       TocBuilder & b = backend.builder("equation");
+       // compute first and last item
+       row_type first = nrows();
+       for (row_type row = 0; row != nrows(); ++row)
+               if (numbered(row)) {
+                       first = row;
+                       break;
+               }
+       if (first == nrows())
+               // no equation
+               return;
+       row_type last = nrows() - 1;
+       for (; last != 0; --last)
+               if (numbered(last))
+                       break;
+       // add equation numbers
+       b.pushItem(pit, docstring(), output_active);
+       if (first != last)
+               b.argumentItem(bformat(from_ascii("(%1$s-%2$s)"),
+                                      numbers_[first], numbers_[last]));
        for (row_type row = 0; row != nrows(); ++row) {
                if (!numbered(row))
                        continue;
                if (label_[row])
-                       label_[row]->addToToc(pit, output_active, utype);
-               toc->push_back(TocItem(pit, 0, nicelabel(row), output_active));
+                       label_[row]->addToToc(pit, output_active, utype, backend);
+               docstring label = nicelabel(row);
+               if (first == last)
+                       // this is the only equation
+                       b.argumentItem(label);
+               else {
+                       // insert as sub-items
+                       b.pushItem(pit, label, output_active);
+                       b.pop();
+               }
        }
+       b.pop();
 }
 
 
@@ -362,22 +419,6 @@ InsetMath::mode_type InsetMathHull::currentMode() const
 }
 
 
-bool InsetMathHull::idxFirst(Cursor & cur) const
-{
-       cur.idx() = 0;
-       cur.pos() = 0;
-       return true;
-}
-
-
-bool InsetMathHull::idxLast(Cursor & cur) const
-{
-       cur.idx() = nargs() - 1;
-       cur.pos() = cur.lastpos();
-       return true;
-}
-
-
 // FIXME: InsetMathGrid should be changed to let the real column alignment be
 // given by a virtual method like displayColAlign, because the values produced
 // by defaultColAlign can be invalidated by lfuns such as add-column. For the
@@ -468,11 +509,21 @@ bool InsetMathHull::previewState(const BufferView *const bv) const
 
 
 namespace {
-static const int ERROR_FRAME_WIDTH = 2;
+const int ERROR_FRAME_WIDTH = 2;
+
+bool previewTooSmall(Dimension const & dim)
+{
+       return dim.width() <= 10 && dim.height() <= 10;
+}
 }
 
+
 void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
 {
+       // true value in LaTeX is 12pt plus 3pt minus 9pt
+       // FIXME: even better would be to handle the short skip case.
+       int const display_margin = display() ? mi.base.inPixels(Length(12, Length::PT)) : 0;
+
        if (previewState(mi.base.bv)) {
                preview_->metrics(mi, dim);
                if (previewTooSmall(dim)) {
@@ -480,55 +531,58 @@ void InsetMathHull::metrics(MetricsInfo & mi, Dimension & dim) const
                        dim.wid += 2 * ERROR_FRAME_WIDTH;
                        dim.asc += 2 * ERROR_FRAME_WIDTH;
                } else {
-                       // insert a one pixel gap in front of the formula
-                       dim.wid += 1;
-                       if (display())
-                               dim.des += displayMargin();
+                       // insert a gap in front of the formula
+                       // value was hardcoded to 1 pixel
+                       dim.wid += mi.base.bv->zoomedPixels(1) ;
+                       if (display()) {
+                               dim.asc += display_margin;
+                               dim.des += display_margin;
+                       }
                }
-               // Cache the inset dimension.
-               setDimCache(mi, dim);
                return;
        }
 
-       // FIXME: Changing the same object repeatedly is inefficient.
-       Changer dummy1 = mi.base.changeFontSet(standardFont());
-       Changer dummy2 = mi.base.changeStyle(display() ? LM_ST_DISPLAY : LM_ST_TEXT);
-
-       // let the cells adjust themselves
-       InsetMathGrid::metrics(mi, dim);
+       {
+               Changer dummy1 = mi.base.changeFontSet(standardFont());
+               Changer dummy2 = mi.base.font.changeStyle(display() ? DISPLAY_STYLE
+                                                                                                 : TEXT_STYLE);
 
-       if (display()) {
-               dim.asc += displayMargin();
-               dim.des += displayMargin();
+               // let the cells adjust themselves
+               InsetMathGrid::metrics(mi, dim);
        }
 
+       // Check whether the numbering interferes with the equations
        if (numberedType()) {
-               Changer dummy = mi.base.changeFontSet("mathbf");
-               int l = 0;
-               for (row_type row = 0; row < nrows(); ++row)
-                       l = max(l, mathed_string_width(mi.base.font, nicelabel(row)));
-
-               if (l)
-                       dim.wid += 30 + l;
+               BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
+               int extra_offset = 0;
+               for (row_type row = 0; row < nrows(); ++row) {
+                       rowinfo(row).offset[mi.base.bv] += extra_offset;
+                       if (!numbered(row))
+                               continue;
+                       docstring const nl = nicelabel(row);
+                       Dimension dimnl;
+                       mathed_string_dim(mi.base.font, nl, dimnl);
+                       int const ind = indent(*mi.base.bv);
+                       int const x = ind ? ind : (mi.base.textwidth - dim.wid) / 2;
+                       // for some reason metrics does not trigger at the
+                       // same point as draw, and therefore we use >= instead of >
+                       if ((math_number == BufferParams::LEFT && dimnl.wid >= x)
+                           || (math_number == BufferParams::RIGHT
+                               && dimnl.wid >= mi.base.textwidth - x - dim.wid)) {
+                               extra_offset += dimnl.height();
+                       }
+               }
+               dim.des += extra_offset;
        }
 
-       if (type_ == hullRegexp)
-               dim.wid += 2;
-       // make it at least as high as the current font
-       int asc = 0;
-       int des = 0;
-       math_font_max_dim(mi.base.font, asc, des);
-       dim.asc = max(dim.asc, asc);
-       dim.des = max(dim.des, des);
-       // Cache the inset dimension.
-       // FIXME: This will overwrite InsetMathGrid dimension, is that OK?
-       setDimCache(mi, dim);
-}
 
+       if (display()) {
+               dim.asc += display_margin;
+               dim.des += display_margin;
+       }
 
-bool InsetMathHull::previewTooSmall(Dimension const & dim) const
-{
-       return dim.width() <= 10 && dim.height() <= 10;
+       // reserve some space for marker.
+       dim.wid += 2;
 }
 
 
@@ -545,6 +599,25 @@ ColorCode InsetMathHull::backgroundColor(PainterInfo const & pi) const
 }
 
 
+void InsetMathHull::drawMarkers(PainterInfo & pi, int x, int y) const
+{
+       ColorCode pen_color = mouseHovered(pi.base.bv) || editing(pi.base.bv)?
+               Color_mathframe : Color_mathcorners;
+       // If the corners have the same color as the background, do not paint them.
+       if (lcolor.getX11Name(Color_mathbg) == lcolor.getX11Name(pen_color))
+               return;
+
+       Inset::drawMarkers(pi, x, y);
+       Dimension const dim = dimension(*pi.base.bv);
+       int const t = x + dim.width() - 1;
+       int const a = y - dim.ascent();
+       pi.pain.line(x, a + 3, x, a, pen_color);
+       pi.pain.line(t, a + 3, t, a, pen_color);
+       pi.pain.line(x, a, x + 3, a, pen_color);
+       pi.pain.line(t - 3, a, t, a, pen_color);
+}
+
+
 void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
 {
        Dimension const dim = dimension(*pi.base.bv);
@@ -553,6 +626,11 @@ void InsetMathHull::drawBackground(PainterInfo & pi, int x, int y) const
                    dim.wid, dim.asc + dim.des, backgroundColor(pi));
                return;
        }
+       // If there are numbers, the margins around the (displayed)
+       // equation have to be cleared.
+       if (numberedType())
+               pi.pain.fillRectangle(pi.leftx, y - dim.asc,
+                               pi.rightx - pi.leftx, dim.height(), pi.background_color);
        pi.pain.fillRectangle(x + 1, y - dim.asc + 1, dim.wid - 2,
                        dim.asc + dim.des - 1, pi.backgroundColor(this));
 }
@@ -570,41 +648,59 @@ void InsetMathHull::draw(PainterInfo & pi, int x, int y) const
        if (previewState(bv)) {
                // Do not draw change tracking cue if taken care of by RowPainter
                // already.
-               Changer dummy = make_change(pi.change_, Change(), !canPaintChange(*bv));
+               Changer dummy = !canPaintChange(*bv) ? make_change(pi.change, Change())
+                       : Changer();
                if (previewTooSmall(dim)) {
                        // we have an extra frame
                        preview_->draw(pi, x + ERROR_FRAME_WIDTH, y);
                } else {
                        // one pixel gap in front
-                       preview_->draw(pi, x + 1, y);
+                       // value was hardcoded to 1 pixel
+                       int const gap = pi.base.bv->zoomedPixels(1) ;
+                       preview_->draw(pi, x + gap, y);
                }
-               setPosCache(pi, x, y);
                return;
        }
 
+       // First draw the numbers
        ColorCode color = pi.selected && lyxrc.use_system_colors
                                ? Color_selectiontext : standardColor();
        bool const really_change_color = pi.base.font.color() == Color_none;
-       Changer dummy0 = pi.base.font.changeColor(color, really_change_color);
-       Changer dummy1 = pi.base.changeFontSet(standardFont());
-       Changer dummy2 = pi.base.changeStyle(display() ? LM_ST_DISPLAY : LM_ST_TEXT);
-
-       InsetMathGrid::draw(pi, x + 1, y);
-
+       Changer dummy0 = really_change_color ? pi.base.font.changeColor(color)
+               : Changer();
        if (numberedType()) {
-               int const xx = x + colinfo_.back().offset_ + colinfo_.back().width_ + 20;
+               BufferParams::MathNumber const math_number = buffer().params().getMathNumber();
                for (row_type row = 0; row < nrows(); ++row) {
-                       int const yy = y + rowinfo_[row].offset_;
-                       Changer dummy = pi.base.changeFontSet("mathrm");
+                       int yy = y + rowinfo(row).offset[bv];
                        docstring const nl = nicelabel(row);
-                       pi.draw(xx, yy, nl);
+                       Dimension dimnl;
+                       mathed_string_dim(pi.base.font, nl, dimnl);
+                       if (math_number == BufferParams::LEFT) {
+                               if (dimnl.wid > x - pi.leftx)
+                                       yy += rowinfo(row).descent + dimnl.asc;
+                               pi.draw(pi.leftx, yy, nl);
+                       } else {
+                               if (dimnl.wid > pi.rightx - x - dim.wid)
+                                       yy += rowinfo(row).descent + dimnl.asc;
+                               pi.draw(pi.rightx - dimnl.wid, yy, nl);
+                       }
                }
        }
+
+       // Then the equations
+       Changer dummy1 = pi.base.changeFontSet(standardFont());
+       Changer dummy2 = pi.base.font.changeStyle(display() ? DISPLAY_STYLE
+                                                           : TEXT_STYLE);
+       InsetMathGrid::draw(pi, x + 1, y);
+       drawMarkers(pi, x, y);
+
        // drawing change line
-       if (canPaintChange(*bv))
-               pi.change_.paintCue(pi, x + 1, y + 1 - dim.asc,
-                                   x + dim.wid, y + dim.des);
-       setPosCache(pi, x, y);
+       if (canPaintChange(*bv)) {
+               // like in metrics()
+               int const display_margin = display() ? pi.base.inPixels(Length(12, Length::PT)) : 0;
+               pi.change.paintCue(pi, x + 1, y + 1 - dim.asc + display_margin,
+                                   x + dim.wid, y + dim.des - display_margin);
+       }
 }
 
 
@@ -678,8 +774,8 @@ void InsetMathHull::usedMacros(MathData const & md, DocIterator const & pos,
        MacroNameSet::iterator const end = macros.end();
 
        for (size_t i = 0; i < md.size(); ++i) {
-               MathMacro const * mi = md[i].nucleus()->asMacro();
-               MathMacroTemplate const * mt = md[i].nucleus()->asMacroTemplate();
+               InsetMathMacro const * mi = md[i].nucleus()->asMacro();
+               InsetMathMacroTemplate const * mt = md[i].nucleus()->asMacroTemplate();
                InsetMathScript const * si = md[i].nucleus()->asScriptInset();
                InsetMathFracBase const * fi = md[i].nucleus()->asFracBaseInset();
                InsetMathGrid const * gi = md[i].nucleus()->asGridInset();
@@ -749,11 +845,9 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
        for (idx_type idx = 0; idx < nargs(); ++idx)
                usedMacros(cell(idx), pos, macros, defs);
 
-       MacroNameSet::iterator it = defs.begin();
-       MacroNameSet::iterator end = defs.end();
        docstring macro_preamble;
-       for (; it != end; ++it)
-               macro_preamble.append(*it);
+       for (auto const & defvar : defs)
+               macro_preamble.append(defvar);
 
        // set the font series and size for this snippet
        DocIterator dit = pos.getInnerText();
@@ -768,7 +862,7 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
                endfont += '}';
        }
        if (lsize != "normalsize" && !prefixIs(lsize, "error"))
-               setfont += from_ascii("\\" + lsize + '\n'); 
+               setfont += from_ascii("\\" + lsize + '\n');
 
        docstring setcnt;
        if (forexport && haveNumbers()) {
@@ -938,12 +1032,31 @@ Inset::DisplayType InsetMathHull::display() const
        case hullEquation:
        case hullMultline:
        case hullGather:
-               return AlignCenter;
+               if (buffer().params().is_math_indent)
+                       return AlignLeft;
+               else
+                       return AlignCenter;
        }
        // avoid warning
        return AlignCenter;
 }
 
+
+int InsetMathHull::indent(BufferView const & bv) const
+{
+       // FIXME: set this in the textclass. This value is what the article class uses.
+       static Length default_indent(2.5, Length::EM);
+       if (display() != Inline && buffer().params().is_math_indent) {
+               Length const & len = buffer().params().getMathIndent();
+               if (len.empty())
+                       return bv.inPixels(default_indent);
+               else
+                       return bv.inPixels(len);
+       } else
+               return Inset::indent(bv);
+}
+
+
 bool InsetMathHull::numberedType() const
 {
        switch (type_) {
@@ -986,9 +1099,9 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
                                + bgcol + "}{\\ensuremath{\\mathtt{#1}}}}");
                        features.addPreambleSnippet(
                                from_ascii("\\newcommand{\\endregexp}{}"));
-               } else if (outerDisplay() && features.inDeletedInset()
-                          && !features.mustProvide("ct-dvipost")) {
-                               features.require("ct-tikz-math-sout");
+               } else if (outerDisplay() && features.inDeletedInset()) {
+                               features.require("tikz");
+                               features.require("ct-tikz-object-sout");
                }
 
                // Validation is necessary only if not using AMS math.
@@ -1011,6 +1124,37 @@ void InsetMathHull::validate(LaTeXFeatures & features) const
 }
 
 
+OutputParams::CtObject InsetMathHull::CtObject(OutputParams const & runparams) const
+{
+       OutputParams::CtObject res = OutputParams::CT_NORMAL;
+       switch(type_) {
+       case hullNone:
+       case hullSimple:
+       case hullAlignAt:
+       case hullXAlignAt:
+       case hullXXAlignAt:
+       case hullRegexp:
+       case hullUnknown:
+               break;
+
+       case hullEquation:
+       case hullEqnArray:
+       case hullAlign:
+       case hullFlAlign:
+       case hullGather:
+       case hullMultline: {
+               if (runparams.inulemcmd
+                   && (!runparams.local_font || runparams.local_font->fontInfo().strikeout() != FONT_ON))
+                       res = OutputParams::CT_UDISPLAYOBJECT;
+               else
+                       res = OutputParams::CT_DISPLAYOBJECT;
+               break;
+               }
+       }
+       return res;
+}
+
+
 void InsetMathHull::header_write(WriteStream & os) const
 {
        bool n = numberedType();
@@ -1020,6 +1164,8 @@ void InsetMathHull::header_write(WriteStream & os) const
                break;
 
        case hullSimple:
+               if (os.ulemCmd())
+                       os << "\\mbox{";
                os << '$';
                os.startOuterRow();
                if (cell(0).empty())
@@ -1027,8 +1173,7 @@ void InsetMathHull::header_write(WriteStream & os) const
                break;
 
        case hullEquation:
-               if (os.strikeoutMath())
-                       os << "\\lyxmathsout{\\parbox{\\columnwidth}{";
+               writeMathdisplayPreamble(os);
                os << "\n";
                os.startOuterRow();
                if (n)
@@ -1042,8 +1187,7 @@ void InsetMathHull::header_write(WriteStream & os) const
        case hullFlAlign:
        case hullGather:
        case hullMultline:
-               if (os.strikeoutMath())
-                       os << "\\lyxmathsout{\\parbox{\\columnwidth}{";
+               writeMathdisplayPreamble(os);
                os << "\n";
                os.startOuterRow();
                os << "\\begin{" << hullName(type_) << star(n) << "}\n";
@@ -1088,6 +1232,8 @@ void InsetMathHull::footer_write(WriteStream & os) const
 
        case hullSimple:
                os << '$';
+               if (os.ulemCmd())
+                       os << "}";
                break;
 
        case hullEquation:
@@ -1097,8 +1243,7 @@ void InsetMathHull::footer_write(WriteStream & os) const
                        os << "\\end{equation" << star(n) << "}\n";
                else
                        os << "\\]\n";
-               if (os.strikeoutMath())
-                       os << "}}\\\\\n";
+               writeMathdisplayPostamble(os);
                break;
 
        case hullEqnArray:
@@ -1109,8 +1254,7 @@ void InsetMathHull::footer_write(WriteStream & os) const
                os << "\n";
                os.startOuterRow();
                os << "\\end{" << hullName(type_) << star(n) << "}\n";
-               if (os.strikeoutMath())
-                       os << "}}\\\\\n";
+               writeMathdisplayPostamble(os);
                break;
 
        case hullAlignAt:
@@ -1557,7 +1701,8 @@ void InsetMathHull::mutate(HullType newtype)
 
        default:
                // we passed the guard so we should not be here
-               LASSERT("Mutation not implemented, but should have been.", return);
+               LYXERR0("Mutation not implemented, but should have been.");
+               LASSERT(false, return);
                break;
        }// switch
 }
@@ -1619,13 +1764,11 @@ void InsetMathHull::check() const
 
 void InsetMathHull::doExtern(Cursor & cur, FuncRequest & func)
 {
-       docstring dlang;
-       docstring extra;
-       idocstringstream iss(func.argument());
-       iss >> dlang >> extra;
+       //FIXME: sort out whether we want std::string or docstring for those
+       string const lang = func.getArg(0);
+       docstring extra = from_utf8(func.getArg(1));
        if (extra.empty())
                extra = from_ascii("noextra");
-       string const lang = to_ascii(dlang);
 
        // replace selection with result of computation
        if (reduceSelectionToOneCell(cur)) {
@@ -1927,7 +2070,7 @@ bool allowDisplayMath(Cursor const & cur)
        return tmpcur.getStatus(cmd, status) && status.enabled();
 }
 
-}
+} // namespace
 
 
 bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
@@ -1991,11 +2134,10 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
 
        case LFUN_LABEL_COPY_AS_REFERENCE: {
                bool enabled = false;
-               row_type row;
                if (cmd.argument().empty() && &cur.inset() == this) {
                        // if there is no argument and we're inside math, we retrieve
                        // the row number from the cursor position.
-                       row = (type_ == hullMultline) ? nrows() - 1 : cur.row();
+                       row_type row = (type_ == hullMultline) ? nrows() - 1 : cur.row();
                        enabled = numberedType() && label_[row] && numbered(row);
                } else {
                        // if there is an argument, find the corresponding label, else
@@ -2062,9 +2204,24 @@ bool InsetMathHull::getStatus(Cursor & cur, FuncRequest const & cmd,
        default:
                return InsetMathGrid::getStatus(cur, cmd, status);
        }
+}
+
+
+int InsetMathHull::leftMargin() const
+{
+       return (getType() == hullSimple) ? 0 : InsetMathGrid::leftMargin();
+}
+
 
-       // This cannot really happen, but inserted to shut-up gcc
-       return InsetMathGrid::getStatus(cur, cmd, status);
+int InsetMathHull::rightMargin() const
+{
+       return (getType() == hullSimple) ? 0 : InsetMathGrid::rightMargin();
+}
+
+
+int InsetMathHull::border() const
+{
+       return (getType() == hullSimple) ? 0 : InsetMathGrid::border();
 }
 
 
@@ -2117,17 +2274,14 @@ void InsetMathHull::handleFont2(Cursor & cur, docstring const & arg)
        font.fromString(to_utf8(arg), b);
        if (font.fontInfo().color() != Color_inherit) {
                MathAtom at = MathAtom(new InsetMathColor(buffer_, true, font.fontInfo().color()));
-               cur.handleNest(at, 0);
+               cur.handleNest(at);
        }
 }
 
 
 void InsetMathHull::edit(Cursor & cur, bool front, EntryDirection entry_from)
 {
-       cur.push(*this);
-       bool enter_front = (entry_from == Inset::ENTRY_DIRECTION_LEFT ||
-               (entry_from == Inset::ENTRY_DIRECTION_IGNORE && front));
-       enter_front ? idxFirst(cur) : idxLast(cur);
+       InsetMathNest::edit(cur, front, entry_from);
        // The inset formula dimension is not necessarily the same as the
        // one of the instant preview image, so we have to indicate to the
        // BufferView that a metrics update is needed.
@@ -2135,42 +2289,6 @@ void InsetMathHull::edit(Cursor & cur, bool front, EntryDirection entry_from)
 }
 
 
-void InsetMathHull::revealCodes(Cursor & cur) const
-{
-       if (!cur.inMathed())
-               return;
-       odocstringstream os;
-       cur.info(os);
-       cur.message(os.str());
-/*
-       // write something to the minibuffer
-       // translate to latex
-       cur.markInsert(bv);
-       ostringstream os;
-       write(os);
-       string str = os.str();
-       cur.markErase(bv);
-       string::size_type pos = 0;
-       string res;
-       for (string::iterator it = str.begin(); it != str.end(); ++it) {
-               if (*it == '\n')
-                       res += ' ';
-               else if (*it == '\0') {
-                       res += "  -X-  ";
-                       pos = it - str.begin();
-               }
-               else
-                       res += *it;
-       }
-       if (pos > 30)
-               res = res.substr(pos - 30);
-       if (res.size() > 60)
-               res = res.substr(0, 60);
-       cur.message(res);
-*/
-}
-
-
 /////////////////////////////////////////////////////////////////////
 
 
@@ -2247,8 +2365,8 @@ bool InsetMathHull::readQuiet(Lexer & lex)
 int InsetMathHull::plaintext(odocstringstream & os,
         OutputParams const & op, size_t max_length) const
 {
-       // disables ASCII-art for export of equations. See #2275.
-       if (0 && display()) {
+       // Try enabling this now that there is a flag as requested at #2275.
+       if (buffer().isExporting() && display()) {
                Dimension dim;
                TextMetricsInfo mi;
                metricsT(mi, dim);
@@ -2298,7 +2416,7 @@ int InsetMathHull::docbook(odocstream & os, OutputParams const & runparams) cons
 
        docstring bname = name;
        if (!label(0).empty())
-               bname += " id='" + sgml::cleanID(buffer(), runparams, label(0)) + "'";
+               bname += " id='" + xml::cleanID(label(0)) + "'";
 
        ++ms.tab(); ms.cr(); ms.os() << '<' << bname << '>';
 
@@ -2328,9 +2446,9 @@ int InsetMathHull::docbook(odocstream & os, OutputParams const & runparams) cons
 
        ms << from_ascii("<graphic fileref=\"eqn/");
        if (!label(0).empty())
-               ms << sgml::cleanID(buffer(), runparams, label(0));
+               ms << xml::cleanID(label(0));
        else
-               ms << sgml::uniqueID(from_ascii("anon"));
+               ms << xml::uniqueID(from_ascii("anon"));
 
        if (runparams.flavor == OutputParams::XML)
                ms << from_ascii("\"/>");
@@ -2399,13 +2517,13 @@ void InsetMathHull::htmlize(HtmlStream & os) const
 // this duplicates code from InsetMathGrid, but
 // we need access here to number information,
 // and we simply do not have that in InsetMathGrid.
-void InsetMathHull::mathmlize(MathStream & os) const
+void InsetMathHull::mathmlize(MathStream & ms) const
 {
        bool const havenumbers = haveNumbers();
        bool const havetable = havenumbers || nrows() > 1 || ncols() > 1;
 
        if (havetable)
-               os << MTag("mtable");
+               ms << MTag("mtable");
        char const * const celltag = havetable ? "mtd" : "mrow";
        // FIXME There does not seem to be wide support at the moment
        // for mlabeledtr, so we have to use just mtr for now.
@@ -2413,25 +2531,25 @@ void InsetMathHull::mathmlize(MathStream & os) const
        char const * const rowtag = "mtr";
        for (row_type row = 0; row < nrows(); ++row) {
                if (havetable)
-                       os << MTag(rowtag);
+                       ms << MTag(rowtag);
                for (col_type col = 0; col < ncols(); ++col) {
-                       os << MTag(celltag)
+                       ms << MTag(celltag)
                           << cell(index(row, col))
                           << ETag(celltag);
                }
                // fleqn?
                if (havenumbers) {
-                       os << MTag("mtd");
+                       ms << MTag("mtd");
                        docstring const & num = numbers_[row];
                        if (!num.empty())
-                               os << '(' << num << ')';
-                 os << ETag("mtd");
+                               ms << '(' << num << ')';
+                 ms << ETag("mtd");
                }
                if (havetable)
-                       os << ETag(rowtag);
+                       ms << ETag(rowtag);
        }
        if (havetable)
-               os << ETag("mtable");
+               ms << ETag("mtable");
 }
 
 
@@ -2467,7 +2585,7 @@ void InsetMathHull::mathAsLatex(WriteStream & os) const
 }
 
 
-docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
+docstring InsetMathHull::xhtml(XMLStream & xs, OutputParams const & op) const
 {
        BufferParams::MathOutput const mathtype =
                buffer().masterBuffer()->params().html_math_output;
@@ -2493,14 +2611,14 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                } catch (MathExportException const &) {}
                if (success) {
                        if (getType() == hullSimple)
-                               xs << html::StartTag("math",
+                               xs << xml::StartTag("math",
                                                        "xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
                        else
-                               xs << html::StartTag("math",
+                               xs << xml::StartTag("math",
                                      "display=\"block\" xmlns=\"http://www.w3.org/1998/Math/MathML\"", true);
-                       xs << XHTMLStream::ESCAPE_NONE
+                       xs << XMLStream::ESCAPE_NONE
                                 << os.str()
-                                << html::EndTag("math");
+                                << xml::EndTag("math");
                }
        } else if (mathtype == BufferParams::HTML) {
                odocstringstream os;
@@ -2511,10 +2629,10 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                } catch (MathExportException const &) {}
                if (success) {
                        string const tag = (getType() == hullSimple) ? "span" : "div";
-                       xs << html::StartTag(tag, "class='formula'", true)
-                          << XHTMLStream::ESCAPE_NONE
+                       xs << xml::StartTag(tag, "class='formula'", true)
+                          << XMLStream::ESCAPE_NONE
                           << os.str()
-                          << html::EndTag(tag);
+                          << xml::EndTag(tag);
                }
        }
 
@@ -2554,11 +2672,11 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                        }
 
                        string const tag = (getType() == hullSimple) ? "span" : "div";
-                       xs << html::CR()
-                          << html::StartTag(tag, "style = \"text-align: center;\"")
-                                << html::CompTag("img", "src=\"" + filename + "\" alt=\"Mathematical Equation\"")
-                                << html::EndTag(tag)
-                                << html::CR();
+                       xs << xml::CR()
+                          << xml::StartTag(tag, "style = \"text-align: center;\"")
+                                << xml::CompTag("img", "src=\"" + filename + "\" alt=\"Mathematical Equation\"")
+                                << xml::EndTag(tag)
+                                << xml::CR();
                        success = true;
                }
        }
@@ -2581,10 +2699,10 @@ docstring InsetMathHull::xhtml(XHTMLStream & xs, OutputParams const & op) const
                // FIXME XHTML
                // probably should allow for some kind of customization here
                string const tag = (getType() == hullSimple) ? "span" : "div";
-               xs << html::StartTag(tag, "class='math'")
+               xs << xml::StartTag(tag, "class='math'")
                   << latex
-                  << html::EndTag(tag)
-                  << html::CR();
+                  << xml::EndTag(tag)
+                  << xml::CR();
        }
        return docstring();
 }