Please Coverity (code should be equivalent)

[lyx.git] / src / mathed / InsetMathDecoration.cpp

diff --git a/src/mathed/InsetMathDecoration.cpp b/src/mathed/InsetMathDecoration.cpp
index d47c1a9c57786d0af753df1cc771b24e2d4f8b5f..37ae239d108479d057a042b9a4bfafb2cbb2fed4 100644 (file)
--- a/src/mathed/InsetMathDecoration.cpp
+++ b/src/mathed/InsetMathDecoration.cpp
@@ -22,17 +22,22 @@
 #include "LaTeXFeatures.h"
 
 #include "support/debug.h"
+#include "support/docstring.h"
+#include "support/gettext.h"
 #include "support/lassert.h"
+#include "support/lstrings.h"
 
 #include <ostream>
 
+using namespace lyx::support;
+
 using namespace std;
 
 namespace lyx {
 
 
 InsetMathDecoration::InsetMathDecoration(Buffer * buf, latexkeys const * key)
-       : InsetMathNest(buf, 1), key_(key)
+       : InsetMathNest(buf, 1), key_(key), dh_(0), dy_(0), dw_(0)
 {
 //     lyxerr << " creating deco " << key->name << endl;
 }
@@ -46,7 +51,7 @@ Inset * InsetMathDecoration::clone() const
 
 bool InsetMathDecoration::upper() const
 {
-       return key_->name.substr(0, 5) != "under";
+       return key_->name.substr(0, 5) != "under" && key_->name != "utilde";
 }
 
 
@@ -54,13 +59,7 @@ bool InsetMathDecoration::isScriptable() const
 {
        return
                        key_->name == "overbrace" ||
-                       key_->name == "underbrace" ||
-                       key_->name == "overleftarrow" ||
-                       key_->name == "overrightarrow" ||
-                       key_->name == "overleftrightarrow" ||
-                       key_->name == "underleftarrow" ||
-                       key_->name == "underrightarrow" ||
-                       key_->name == "underleftrightarrow";
+                       key_->name == "underbrace";
 }
 
 
@@ -92,7 +91,9 @@ bool InsetMathDecoration::wide() const
                        key_->name == "widetilde" ||
                        key_->name == "underleftarrow" ||
                        key_->name == "underrightarrow" ||
-                       key_->name == "underleftrightarrow";
+                       key_->name == "underleftrightarrow" ||
+                       key_->name == "undertilde" ||
+                       key_->name == "utilde";
 }
 
 
@@ -104,8 +105,9 @@ InsetMath::mode_type InsetMathDecoration::currentMode() const
 
 void InsetMathDecoration::metrics(MetricsInfo & mi, Dimension & dim) const
 {
-       FontSetChanger dummy(mi.base, currentMode() == TEXT_MODE ?
-                               "textnormal" : "mathnormal");
+       bool really_change_font = currentMode() == TEXT_MODE
+                               && isMathFont(from_ascii(mi.base.fontname));
+       FontSetChanger dummy(mi.base, "textnormal", really_change_font);
 
        cell(0).metrics(mi, dim);
 
@@ -126,8 +128,9 @@ void InsetMathDecoration::metrics(MetricsInfo & mi, Dimension & dim) const
 
 void InsetMathDecoration::draw(PainterInfo & pi, int x, int y) const
 {
-       FontSetChanger dummy(pi.base, currentMode() == TEXT_MODE ?
-                               "textnormal" : "mathnormal");
+       bool really_change_font = currentMode() == TEXT_MODE
+                               && isMathFont(from_ascii(pi.base.fontname));
+       FontSetChanger dummy(pi.base, "textnormal", really_change_font);
 
        cell(0).draw(pi, x + 1, y);
        Dimension const & dim0 = cell(0).dimension(*pi.base.bv);
@@ -160,7 +163,7 @@ void InsetMathDecoration::normalize(NormalStream & os) const
 
 void InsetMathDecoration::infoize(odocstream & os) const
 {
-       os << "Deco: " << key_->name;
+       os << bformat(_("Decoration: %1$s"), key_->name);
 }
 
 
@@ -201,6 +204,8 @@ namespace {
                // this is the macron, again, but it works
                t["underline"] = Attributes(false, "&macr;");
                t["underrightarrow"] = Attributes(false, "&xrarr;");
+               t["undertilde"] = Attributes(false, "&Tilde;");
+               t["utilde"] = Attributes(false, "&Tilde;");
                t["vec"] = Attributes(true, "&rarr;");
                t["widehat"] = Attributes(true, "&Hat;");
                t["widetilde"] = Attributes(true, "&Tilde;");
@@ -234,7 +239,7 @@ void InsetMathDecoration::htmlize(HtmlStream & os) const
                os << MTag("span", "class='overbar'") << cell(0) << ETag("span");
                return;
        }
-       
+
        if (name == "underbar" || name == "underline") {
                os << MTag("span", "class='underbar'") << cell(0) << ETag("span");
                return;
@@ -243,12 +248,12 @@ void InsetMathDecoration::htmlize(HtmlStream & os) const
        TranslationMap const & t = translationMap();
        TranslationMap::const_iterator cur = t.find(name);
        LASSERT(cur != t.end(), return);
-       
+
        bool symontop = cur->second.over;
        string const symclass = symontop ? "symontop" : "symonbot";
        os << MTag("span", "class='symbolpair " + symclass + "'")
           << '\n';
-       
+
        if (symontop)
                os << MTag("span", "class='symbol'") << from_ascii(cur->second.tag);
        else
@@ -268,25 +273,20 @@ void InsetMathDecoration::validate(LaTeXFeatures & features) const
        if (features.runparams().math_flavor == OutputParams::MathAsHTML) {
                string const name = to_utf8(key_->name);
                if (name == "bar") {
-                       features.addPreambleSnippet("<style type=\"text/css\">\n"
-                               "span.overbar{border-top: thin black solid;}\n"
-                               "</style>");
+                       features.addCSSSnippet("span.overbar{border-top: thin black solid;}");
                } else if (name == "underbar" || name == "underline") {
-                       features.addPreambleSnippet("<style type=\"text/css\">\n"
-                               "span.underbar{border-bottom: thin black solid;}\n"
-                               "</style>");
+                       features.addCSSSnippet("span.underbar{border-bottom: thin black solid;}");
                } else {
-                       features.addPreambleSnippet("<style type=\"text/css\">\n"
+                       features.addCSSSnippet(
                                "span.symbolpair{display: inline-block; text-align:center;}\n"
                                "span.symontop{vertical-align: top;}\n"
                                "span.symonbot{vertical-align: bottom;}\n"
-                               "span.symbolpair span{display: block;}\n"                       
-                               "span.symbol{height: 0.5ex;}\n"
-                               "</style>");
+                               "span.symbolpair span{display: block;}\n"
+                               "span.symbol{height: 0.5ex;}");
                }
        } else {
                if (!key_->requires.empty())
-                       features.require(to_utf8(key_->requires));
+                       features.require(key_->requires);
        }
        InsetMathNest::validate(features);
 }