]> git.lyx.org Git - lyx.git/blobdiff - src/lyxfunc.C
last Friday's text*.C -> text_func shuffle
[lyx.git] / src / lyxfunc.C
index e9e3efe8af372d731603597e7a28c9c664bbf41b..9036b814eef0d7f0879bb5a2b4a4902832c22764 100644 (file)
@@ -15,6 +15,8 @@
 #include "kbmap.h"
 #include "lyxrow.h"
 #include "bufferlist.h"
+#include "buffer.h"
+#include "buffer_funcs.h"
 #include "BufferView.h"
 #include "lyxserver.h"
 #include "intl.h"
@@ -43,6 +45,7 @@
 #include "ParagraphParameters.h"
 
 #include "insets/insetcommand.h"
+#include "insets/insetexternal.h"
 #include "insets/insettabular.h"
 
 #include "mathed/formulamacro.h"
 #include "support/FileInfo.h"
 #include "support/forkedcontr.h"
 #include "support/lstrings.h"
+#include "support/tostr.h"
 #include "support/path.h"
 #include "support/lyxfunctional.h"
 
-#include "support/BoostFormat.h"
-
 #include <ctime>
 #include <clocale>
 #include <cstdlib>
@@ -76,6 +78,8 @@
 #include <utility>
 #include <algorithm>
 
+using namespace lyx::support;
+
 using std::pair;
 using std::make_pair;
 using std::endl;
@@ -125,7 +129,6 @@ void LyXFunc::moveCursorUpdate(bool flag, bool selecting)
                    view()->toggleToggle();
        }
        view()->update(TEXT(flag), BufferView::SELECT);
-       view()->showCursor();
 
        view()->switchKeyMap();
 }
@@ -318,10 +321,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        // encode this in the function itself.
        bool disable = false;
        switch (ev.action) {
-       case LFUN_MENUPRINT:
-               disable = !Exporter::IsExportable(buf, "dvi")
-                       || lyxrc.print_command == "none";
-               break;
        case LFUN_EXPORT:
                disable = ev.argument != "custom"
                        && !Exporter::IsExportable(buf, ev.argument);
@@ -353,10 +352,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                disable = !Exporter::IsExportable(buf, "program");
                break;
 
-       case LFUN_LAYOUT_CHARACTER:
-               disable = tli && tli->lyxCode() == Inset::ERT_CODE;
-               break;
-
        case LFUN_LAYOUT_TABULAR:
                disable = !tli
                        || (tli->lyxCode() != Inset::TABULAR_CODE
@@ -430,13 +425,17 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                        if (tli->lyxCode() == Inset::TABULAR_CODE) {
                                ret = static_cast<InsetTabular *>(tli)
                                        ->getStatus(ev.argument);
+                               flag |= ret;
+                               disable = false;
                        } else if (tli->getFirstLockingInsetOfType(Inset::TABULAR_CODE)) {
                                ret = static_cast<InsetTabular *>
                                        (tli->getFirstLockingInsetOfType(Inset::TABULAR_CODE))
                                        ->getStatus(ev.argument);
+                               flag |= ret;
+                               disable = false;
+                       } else {
+                               disable = true;
                        }
-                       flag |= ret;
-                       disable = false;
                } else {
                        static InsetTabular inset(*owner->buffer(), 1, 1);
                        FuncStatus ret;
@@ -459,7 +458,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                break;
        case LFUN_VC_REVERT:
        case LFUN_VC_UNDO:
-       case LFUN_VC_HISTORY:
                disable = !buf->lyxvc.inUse();
                break;
        case LFUN_MENURELOAD:
@@ -484,9 +482,44 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                                && lt->inset_owner->owner()->isOpen()));
                break;
        }
-       case LFUN_LATEX_LOG:
-               disable = !IsFileReadable(buf->getLogName().second);
+
+       case LFUN_INSET_SETTINGS: {
+               disable = true;
+               UpdatableInset * inset = view()->theLockingInset();
+
+               if (!inset)
+                       break;
+
+               // get the innermost inset
+               inset = inset->getLockingInset();
+
+               // jump back to owner if an InsetText, so
+               // we get back to the InsetTabular or whatever
+               if (inset->lyxCode() == Inset::TEXT_CODE)
+                       inset = inset->owner();
+
+               Inset::Code code = inset->lyxCode();
+               switch (code) {
+                       case Inset::TABULAR_CODE:
+                               disable = ev.argument != "tabular";
+                               break;
+                       case Inset::ERT_CODE:
+                               disable = ev.argument != "ert";
+                               break;
+                       case Inset::FLOAT_CODE:
+                               disable = ev.argument != "float";
+                               break;
+                       case Inset::MINIPAGE_CODE:
+                               disable = ev.argument != "minipage";
+                               break;
+                       case Inset::WRAP_CODE:
+                               disable = ev.argument != "wrap";
+                               break;
+                       default:
+                               break;
+               }
                break;
+       }
 
        case LFUN_MATH_MUTATE:
                if (mathcursor)
@@ -506,6 +539,31 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                disable = !mathcursor;
                break;
 
+       case LFUN_DIALOG_SHOW: {
+               string const name = ev.getArg(0);
+               if (!buf) {
+                       disable = !(name == "aboutlyx" ||
+                                   name == "file" ||
+                                   name == "forks" ||
+                                   name == "preferences" ||
+                                   name == "texinfo");
+                       break;
+               }
+
+               if (name == "print") {
+                       disable = !Exporter::IsExportable(buf, "dvi") ||
+                               lyxrc.print_command == "none";
+               } else if (name == "character") {
+                       UpdatableInset * tli = view()->theLockingInset();
+                       disable = tli && tli->lyxCode() == Inset::ERT_CODE;
+               } else if (name == "vclog") {
+                       disable = !buf->lyxvc.inUse();
+               } else if (name == "latexlog") {
+                       disable = !IsFileReadable(buf->getLogName().second);
+               }
+               break;
+       }
+
        default:
                break;
        }
@@ -603,9 +661,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        case LFUN_TOC_INSERT:
                code = Inset::TOC_CODE;
                break;
-       case LFUN_PARENTINSERT:
-               code = Inset::PARENT_CODE;
-               break;
        case LFUN_HTMLURL:
        case LFUN_URL:
                code = Inset::URL_CODE;
@@ -622,10 +677,10 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        case LFUN_END_OF_SENTENCE:
                code = Inset::SPECIALCHAR_CODE;
                break;
-       case LFUN_PROTECTEDSPACE:
+       case LFUN_SPACE_INSERT:
                // slight hack: we know this is allowed in math mode
                if (!mathcursor)
-                       code = Inset::SPECIALCHAR_CODE;
+                       code = Inset::SPACE_CODE;
                break;
        default:
                break;
@@ -731,15 +786,7 @@ void LyXFunc::dispatch(string const & s, bool verbose)
        int const action = lyxaction.LookupFunc(s);
 
        if (action == LFUN_UNKNOWN_ACTION) {
-#if USE_BOOST_FORMAT
-boost::format fmt(_("Unknown function (%1$s)"));
-fmt % s;
-owner->message(fmt.str());
-#else
-               string const msg = string(_("Unknown function ("))
-                       + s + ')';
-               owner->message(msg);
-#endif
+               owner->message(bformat(_("Unknown function (%1$s)"), s));
                return;
        }
 
@@ -772,9 +819,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
        selection_possible = false;
 
-       if (view()->available())
-               view()->hideCursor();
-
        string argument = ev.argument;
        kb_action action = ev.action;
 
@@ -788,6 +832,9 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                goto exit_with_message;
        }
 
+       if (view()->available())
+               view()->hideCursor();
+
        if (view()->available() && view()->theLockingInset()) {
                Inset::RESULT result;
                if ((action > 1) || ((action == LFUN_UNKNOWN_ACTION) &&
@@ -803,6 +850,19 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                            && argument.empty()) {
                                argument = encoded_last_key;
                        }
+
+                       // the insets can't try to handle this,
+                       // a table cell in the dummy position will
+                       // lock its insettext, the insettext will
+                       // pass it the bufferview, and succeed,
+                       // so it will stay not locked. Not good
+                       // if we've just done LFUN_ESCAPE (which
+                       // injects an LFUN_PARAGRAPH_UPDATE)
+                       if (action == LFUN_PARAGRAPH_UPDATE) {
+                               view()->dispatch(ev);
+                               goto exit_with_message;
+                       }
+
                        // Undo/Redo is a bit tricky for insets.
                        if (action == LFUN_UNDO) {
                                view()->undo();
@@ -890,7 +950,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                                        }
                                        goto exit_with_message;
                                case LFUN_DOWN:
-                                       if (boost::next(TEXT()->cursor.row()) != TEXT()->rows().end())
+                                       if (boost::next(TEXT()->cursorRow()) != TEXT()->rows().end())
                                                TEXT()->cursorDown(view());
                                        else
                                                TEXT()->cursorRight(view());
@@ -948,7 +1008,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                if (!searched_string.empty()) {
                        lyxfind::LyXFind(view(), searched_string, fw);
                }
-//             view()->showCursor();
        }
        break;
 
@@ -1010,39 +1069,25 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
        case LFUN_MENUWRITE:
                if (!owner->buffer()->isUnnamed()) {
-                       ostringstream s1;
-#if USE_BOOST_FORMAT
-                       s1 << boost::format(_("Saving document %1$s..."))
-                          % MakeDisplayPath(owner->buffer()->fileName());
-#else
-                       s1 << _("Saving document ")
-                          << MakeDisplayPath(owner->buffer()->fileName())
-                          << _("...");
-#endif
-                       owner->message(STRCONV(s1.str()));
-                       MenuWrite(view(), owner->buffer());
-                       s1 << _(" done.");
-                       owner->message(STRCONV(s1.str()));
+                       string const str = bformat(_("Saving document %1$s..."),
+                          MakeDisplayPath(owner->buffer()->fileName()));
+                       owner->message(str);
+                       MenuWrite(owner->buffer());
+                       owner->message(str + _(" done."));
                } else
-                       WriteAs(view(), owner->buffer());
+                       WriteAs(owner->buffer());
                break;
 
        case LFUN_WRITEAS:
-               WriteAs(view(), owner->buffer(), argument);
+               WriteAs(owner->buffer(), argument);
                break;
 
        case LFUN_MENURELOAD: {
                string const file = MakeDisplayPath(view()->buffer()->fileName(), 20);
-#if USE_BOOST_FORMAT
-               boost::format fmt(_("Any changes will be lost. Are you sure you want to revert to the saved version of the document %1$s?"));
-               fmt % file;
-               string text = fmt.str();
-#else
-               string text = _("Any changes will be lost. Are you sure you want to revert to the saved version of the document");
-               text += file + _("?");
-#endif
+               string text = bformat(_("Any changes will be lost. Are you sure "
+                       "you want to revert to the saved version of the document %1$s?"), file);
                int const ret = Alert::prompt(_("Revert to saved document?"),
-                       text, 1, _("&Revert"), _("&Cancel"));
+                       text, 0, 1, _("&Revert"), _("&Cancel"));
 
                if (ret == 0)
                        view()->reload();
@@ -1051,29 +1096,31 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
        case LFUN_UPDATE:
                Exporter::Export(owner->buffer(), argument, true);
+               view()->showErrorList(BufferFormat(*owner->buffer()));
                break;
 
        case LFUN_PREVIEW:
                Exporter::Preview(owner->buffer(), argument);
+               view()->showErrorList(BufferFormat(*owner->buffer()));
                break;
 
        case LFUN_BUILDPROG:
                Exporter::Export(owner->buffer(), "program", true);
+               view()->showErrorList(_("Build"));
                break;
 
        case LFUN_RUNCHKTEX:
                owner->buffer()->runChktex();
-               break;
-
-       case LFUN_MENUPRINT:
-               owner->getDialogs().showPrint();
+               view()->showErrorList(_("ChkTeX"));
                break;
 
        case LFUN_EXPORT:
                if (argument == "custom")
                        owner->getDialogs().showSendto();
-               else
+               else {
                        Exporter::Export(owner->buffer(), argument, false);
+                       view()->showErrorList(BufferFormat(*owner->buffer()));
+               }
                break;
 
        case LFUN_IMPORT:
@@ -1104,18 +1151,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                view()->redo();
                break;
 
-       case LFUN_MENUSEARCH:
-               owner->getDialogs().showSearch();
-               break;
-
-       case LFUN_REMOVEERRORS:
-               if (view()->removeAutoInsets()) {
-#warning repaint() or update() or nothing ?
-                       view()->repaint();
-                       view()->fitCursor();
-               }
-               break;
-
        case LFUN_DEPTH_MIN:
                changeDepth(view(), TEXT(false), DEC_DEPTH, false);
                owner->view_state_changed();
@@ -1154,14 +1189,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 //#warning Find another implementation here (or another lyxfunc)!
 #endif
 #endif
-       case LFUN_HELP_ABOUTLYX:
-               owner->getDialogs().show("about");
-               break;
-
-       case LFUN_HELP_TEXINFO:
-               owner->getDialogs().showTexinfo();
-               break;
-
        case LFUN_HELP_OPEN:
        {
                string const arg = argument;
@@ -1175,16 +1202,9 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                               << arg << "'. Bad installation?" << endl;
                        break;
                }
-               ostringstream str;
-#if USE_BOOST_FORMAT
-               str << boost::format(_("Opening help file %1$s..."))
-                   % MakeDisplayPath(fname);
-#else
-               str << _("Opening help file ")
-                   << MakeDisplayPath(fname) << _("...");
-#endif
-               owner->message(STRCONV(str.str()));
-               view()->buffer(bufferlist.loadLyXFile(fname, false));
+               owner->message(bformat(_("Opening help file %1$s..."),
+                       MakeDisplayPath(fname)));
+               view()->loadLyXFile(fname, false);
                break;
        }
 
@@ -1224,12 +1244,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        }
        break;
 
-       case LFUN_VC_HISTORY:
-       {
-               owner->getDialogs().show("vclog");
-               break;
-       }
-
        // --- buffers ----------------------------------------
 
        case LFUN_SWITCHBUFFER:
@@ -1249,21 +1263,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                open(argument);
                break;
 
-       case LFUN_LATEX_LOG:
-               owner->getDialogs().show("log");
-               break;
-
-       case LFUN_LAYOUT_DOCUMENT:
-               owner->getDialogs().showDocument();
-               break;
-
-       case LFUN_LAYOUT_CHARACTER: {
-               string data = freefont2string();
-               if (!data.empty())
-                       owner->getDialogs().show("character", data);
-               break;
-       }
-
        case LFUN_LAYOUT_TABULAR:
            if (view()->theLockingInset()) {
                if (view()->theLockingInset()->lyxCode()==Inset::TABULAR_CODE) {
@@ -1279,10 +1278,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
            }
            break;
 
-       case LFUN_LAYOUT_PREAMBLE:
-               owner->getDialogs().showPreamble();
-               break;
-
        case LFUN_DROP_LAYOUTS_CHOICE:
                owner->getToolbar().openLayoutList();
                break;
@@ -1291,10 +1286,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                owner->getMenubar().openByName(argument);
                break; // RVDK_PATCH_5
 
-       case LFUN_SPELLCHECK:
-               owner->getDialogs().showSpellchecker();
-               break;
-
        // --- lyxserver commands ----------------------------
 
 
@@ -1325,7 +1316,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                if (bufferlist.exists(s)) {
                        view()->buffer(bufferlist.getBuffer(s));
                } else {
-                       view()->buffer(bufferlist.loadLyXFile(s));
+                       view()->loadLyXFile(s);
                }
 
                view()->setCursorFromRow(row);
@@ -1342,8 +1333,8 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
                int id;
                istr >> id;
-               Paragraph * par = owner->buffer()->getParFromID(id);
-               if (par == 0) {
+               ParIterator par = owner->buffer()->getParFromID(id);
+               if (par == owner->buffer()->par_iterator_end()) {
                        lyxerr[Debug::INFO] << "No matching paragraph found! ["
                                            << id << ']' << endl;
                        break;
@@ -1355,10 +1346,11 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                if (view()->theLockingInset())
                        view()->unlockInset(view()->theLockingInset());
                if (par->inInset()) {
-                       par->inInset()->edit(view());
+                       FuncRequest cmd(view(), LFUN_INSET_EDIT, "left");
+                       par->inInset()->localDispatch(cmd);
                }
                // Set the cursor
-               view()->getLyXText()->setCursor(par, 0);
+               view()->getLyXText()->setCursor(par.pit(), 0);
                view()->switchKeyMap();
                owner->view_state_changed();
 
@@ -1368,14 +1360,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        }
        break;
 
-       case LFUN_APROPOS:
-       case LFUN_GETTIP:
-       {
-               int const qa = lyxaction.LookupFunc(argument);
-               setMessage(lyxaction.helpText(static_cast<kb_action>(qa)));
-       }
-       break;
-
        // --- insert characters ----------------------------------------
 
        // ---  Mathed stuff. If we are here, there is no locked inset yet.
@@ -1396,9 +1380,32 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                dispatch(FuncRequest(view(), LFUN_SELFINSERT, "^"));
                break;
 
-       case LFUN_MATH_PANEL:
-               owner->getDialogs().showMathPanel();
+       case LFUN_DIALOG_SHOW: {
+               string const name = ev.getArg(0);
+               string data = trim(ev.argument.substr(name.size()));
+
+               if (name == "character") {
+                       data = freefont2string();
+                       if (!data.empty())
+                               owner->getDialogs().show("character", data);
+               } else if (name == "document")
+                       owner->getDialogs().showDocument();
+               else if (name == "findreplace")
+                       owner->getDialogs().showSearch();
+               else if (name == "forks")
+                       owner->getDialogs().showForks();
+               else if (name == "preamble")
+                       owner->getDialogs().showPreamble();
+               else if (name == "preferences")
+                       owner->getDialogs().showPreferences();
+               else if (name == "print")
+                       owner->getDialogs().showPrint();
+               else if (name == "spellchecker")
+                       owner->getDialogs().showSpellchecker();
+               else
+                       owner->getDialogs().show(name, data);
                break;
+       }
 
        case LFUN_DIALOG_SHOW_NEW_INSET: {
                string const & name = argument;
@@ -1457,7 +1464,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                if (bufferlist.exists(filename))
                        view()->buffer(bufferlist.getBuffer(filename));
                else
-                       view()->buffer(bufferlist.loadLyXFile(filename));
+                       view()->loadLyXFile(filename);
        }
        break;
 
@@ -1492,10 +1499,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        }
        break;
 
-       case LFUN_DIALOG_PREFERENCES:
-               owner->getDialogs().showPreferences();
-               break;
-
        case LFUN_SAVEPREFERENCES:
        {
                Path p(user_lyxdir);
@@ -1535,20 +1538,10 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                         x11_name != lcolor.getX11Name(LColor::graphicsbg));
 
                if (!lcolor.setColor(lyx_name, x11_name)) {
-#if USE_BOOST_FORMAT
                        setErrorMessage(
-                               boost::io::str(
-                                       boost::format(
-                                               _("Set-color \"%1$s\" failed "
+                               bformat(_("Set-color \"%1$s\" failed "
                                                  "- color is undefined or "
-                                                 "may not be redefined"))
-                                       % lyx_name));
-#else
-                       setErrorMessage(_("Set-color ") + lyx_name
-                                       + _(" failed - color is undefined"
-                                           " or may not be redefined"));
-#endif
-
+                                                 "may not be redefined"), lyx_name));
                        break;
                }
 
@@ -1572,10 +1565,6 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                owner->message(argument);
                break;
 
-       case LFUN_FORKS_SHOW:
-               owner->getDialogs().showForks();
-               break;
-
        case LFUN_FORKS_KILL:
        {
                if (!isStrInt(argument))
@@ -1591,6 +1580,12 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                owner->getDialogs().toggleTooltips();
                break;
 
+       case LFUN_EXTERNAL_EDIT: {
+               InsetExternal()
+                       .localDispatch(FuncRequest(view(), action, argument));
+               break;
+       }
+
        default:
                // Then if it was none of the above
                // Trying the BufferView::pimpl dispatch:
@@ -1728,7 +1723,7 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
                templname = fname;
        }
 
-       view()->buffer(bufferlist.newFile(filename, templname, !name.empty()));
+       view()->buffer(newFile(filename, templname, !name.empty()));
 }
 
 
@@ -1783,38 +1778,20 @@ void LyXFunc::open(string const & fname)
        FileInfo const f(filename, true);
        if (!f.exist()) {
                // the user specifically chose this name. Believe them.
-               Buffer * buffer =  bufferlist.newFile(filename, "", true);
+               Buffer * buffer =  newFile(filename, "", true);
                view()->buffer(buffer);
                return;
        }
 
-       ostringstream str;
-#if USE_BOOST_FORMAT
-       str << boost::format(_("Opening document %1$s...")) % disp_fn;
-#else
-       str << _("Opening document ") << disp_fn << _("...");
-#endif
-
-       owner->message(STRCONV(str.str()));
+       owner->message(bformat(_("Opening document %1$s..."), disp_fn));
 
-       Buffer * openbuf = bufferlist.loadLyXFile(filename);
-       ostringstream str2;
-       if (openbuf) {
-               view()->buffer(openbuf);
-#if USE_BOOST_FORMAT
-               str2 << boost::format(_("Document %1$s opened.")) % disp_fn;
-#else
-               str2 << _("Document ") << disp_fn << _(" opened.");
-#endif
+       string str2;
+       if (view()->loadLyXFile(filename)) {
+               str2 = bformat(_("Document %1$s opened."), disp_fn);
        } else {
-#if USE_BOOST_FORMAT
-               str2 << boost::format(_("Could not open document %1$s"))
-                       % disp_fn;
-#else
-               str2 << _("Could not open document ") << disp_fn;
-#endif
+               str2 = bformat(_("Could not open document %1$s"), disp_fn);
        }
-       owner->message(STRCONV(str2.str()));
+       owner->message(str2);
 }
 
 
@@ -1837,14 +1814,8 @@ void LyXFunc::doImport(string const & argument)
                                initpath = trypath;
                }
 
-#if USE_BOOST_FORMAT
-               boost::format fmt(_("Select %1$s file to import"));
-               fmt % formats.prettyName(format);
-               string const text = fmt.str();
-#else
-               string const text = _("Select ") + formats.prettyName(format)
-                       + _(" file to import");;
-#endif
+               string const text = bformat(_("Select %1$s file to import"),
+                       formats.prettyName(format));
 
                FileDialog fileDlg(text,
                        LFUN_IMPORT,
@@ -1880,22 +1851,7 @@ void LyXFunc::doImport(string const & argument)
 
        // Check if the document already is open
        if (lyx_gui::use_gui && bufferlist.exists(lyxfile)) {
-               string const file = MakeDisplayPath(lyxfile, 30);
-
-               // FIXME: sucky UI !
-
-#if USE_BOOST_FORMAT
-               boost::format fmt(_("The document %1$s is already open.\n\nDo you want to close that document?"));
-               fmt % file;
-               string text = fmt.str();
-#else
-               string text = _("The document ");
-               text += file + _(" is already open.\n\nDo you want to close that document?");
-#endif
-               int const ret = Alert::prompt(_("Close open document?"),
-                       text, 1, _("&Close"), _("&Cancel"));
-
-               if (ret == 0 || !bufferlist.close(bufferlist.getBuffer(lyxfile), true)) {
+               if (!bufferlist.close(bufferlist.getBuffer(lyxfile), true)) {
                        owner->message(_("Canceled."));
                        return;
                }
@@ -1906,16 +1862,10 @@ void LyXFunc::doImport(string const & argument)
        if (FileInfo(lyxfile, true).exist() && filename != lyxfile) {
                string const file = MakeDisplayPath(lyxfile, 30);
 
-#if USE_BOOST_FORMAT
-               boost::format fmt(_("The document %1$s already exists.\n\nDo you want to over-write that document?"));
-               fmt % file;
-               string text = fmt.str();
-#else
-               string text = _("The document ");
-               text += file + _(" already exists.\n\nDo you want to over-write that document?");
-#endif
+               string text = bformat(_("The document %1$s already exists.\n\n"
+                       "Do you want to over-write that document?"), file);
                int const ret = Alert::prompt(_("Over-write document?"),
-                       text, 1, _("&Over-write"), _("&Cancel"));
+                       text, 0, 1, _("&Over-write"), _("&Cancel"));
 
                if (ret == 1) {
                        owner->message(_("Canceled."));
@@ -1989,6 +1939,6 @@ string const LyXFunc::view_status_message()
 
 BufferView * LyXFunc::view() const
 {
-       lyx::Assert(owner);
+       Assert(owner);
        return owner->view().get();
 }