]> git.lyx.org Git - lyx.git/blobdiff - src/lyxfunc.C
hopefully fix tex2lyx linking.
[lyx.git] / src / lyxfunc.C
index ae6109d09402c573dc3bc841e661679fe0bfd23e..7de71684d5d8267f2de39d929e5b4b88325e2ce3 100644 (file)
@@ -78,6 +78,7 @@
 #include "frontends/Dialogs.h"
 #include "frontends/FileDialog.h"
 #include "frontends/FontLoader.h"
+#include "frontends/Gui.h"
 #include "frontends/LyXKeySym.h"
 #include "frontends/LyXView.h"
 #include "frontends/Menubar.h"
@@ -223,14 +224,13 @@ void LyXFunc::setLyXView(LyXView * lv)
 
 void LyXFunc::handleKeyFunc(kb_action action)
 {
-       char c = encoded_last_key;
+       char_type c = encoded_last_key;
 
-       if (keyseq->length()) {
+       if (keyseq->length())
                c = 0;
-       }
 
-       lyx_view_->view()->getIntl().getTransManager()
-               .deadkey(c, get_accent(action).accent, view()->getLyXText());
+       lyx_view_->view()->getIntl().getTransManager().deadkey(
+               c, get_accent(action).accent, view()->getLyXText(), view()->cursor());
        // Need to clear, in case the minibuffer calls these
        // actions
        keyseq->clear();
@@ -347,6 +347,25 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
 {
        //lyxerr << "LyXFunc::getStatus: cmd: " << cmd << endl;
        FuncStatus flag;
+
+       if (cmd.action == LFUN_LYX_QUIT) {
+               flag.message(from_utf8(N_("Exiting")));
+               flag.enabled(true);
+               return flag;
+       } else if (cmd.action == LFUN_BOOKMARK_GOTO) {
+               // bookmarks can be valid even if there is no opened buffer
+               flag.enabled(LyX::ref().session().bookmarks().isValid(convert<unsigned int>(to_utf8(cmd.argument()))));
+               return flag;
+       } else if (cmd.action == LFUN_BOOKMARK_CLEAR) {
+               flag.enabled(LyX::ref().session().bookmarks().size() > 0);
+               return flag;
+       } else if (cmd.action == LFUN_TOOLBAR_TOGGLE_STATE) {
+               ToolbarBackend::Flags flags = lyx_view_->getToolbarState(to_utf8(cmd.argument()));
+               if (!(flags & ToolbarBackend::AUTO))
+                       flag.setOnOff(flags & ToolbarBackend::ON);
+               return flag;
+       }
+
        LCursor & cur = view()->cursor();
 
        /* In LyX/Mac, when a dialog is open, the menus of the
@@ -358,7 +377,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
           http://bugzilla.lyx.org/show_bug.cgi?id=1941#c4
        */
        Buffer * buf;
-       if (cmd.origin == FuncRequest::UI && !lyx_view_->hasFocus())
+       if (cmd.origin == FuncRequest::MENU && !lyx_view_->hasFocus())
                buf = 0;
        else
                buf = lyx_view_->buffer();
@@ -558,6 +577,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                break;
        }
 
+
        // this one is difficult to get right. As a half-baked
        // solution, we consider only the first action of the sequence
        case LFUN_COMMAND_SEQUENCE: {
@@ -581,7 +601,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_BUFFER_UPDATE:
        case LFUN_BUFFER_VIEW:
        case LFUN_BUFFER_IMPORT:
-       case LFUN_LYX_QUIT:
        case LFUN_TOC_VIEW:
        case LFUN_BUFFER_AUTO_SAVE:
        case LFUN_RECONFIGURE:
@@ -620,6 +639,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_BUFFER_NEXT:
        case LFUN_BUFFER_PREVIOUS:
        case LFUN_WINDOW_NEW:
+       case LFUN_WINDOW_CLOSE:
                // these are handled in our dispatch()
                break;
 
@@ -717,7 +737,6 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new);
 
 void LyXFunc::dispatch(FuncRequest const & cmd)
 {
-       BOOST_ASSERT(view());
        string const argument = to_utf8(cmd.argument());
        kb_action const action = cmd.action;
 
@@ -730,9 +749,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
        // redraw the screen at the end (first of the two drawing steps).
        //This is done unless explicitely requested otherwise
-       bool update = true;
-       // also do the second redrawing step. Only done if requested.
-       bool updateforce = false;
+       Update::flags updateFlags = Update::FitCursor;
 
        FuncStatus const flag = getStatus(cmd);
        if (!flag.enabled()) {
@@ -747,6 +764,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                case LFUN_WORD_FIND_FORWARD:
                case LFUN_WORD_FIND_BACKWARD: {
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->view());
                        static string last_search;
                        string searched_string;
 
@@ -768,15 +786,18 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_COMMAND_PREFIX:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->message(from_utf8(keyseq->printOptions()));
                        break;
 
                case LFUN_COMMAND_EXECUTE:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->getToolbars().display("minibuffer", true);
                        lyx_view_->focus_command_buffer();
                        break;
 
                case LFUN_CANCEL:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->view());
                        keyseq->reset();
                        meta_fake_bit = key_modifier::none;
                        if (view()->buffer())
@@ -791,6 +812,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_BUFFER_TOGGLE_READ_ONLY:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->view() && lyx_view_->buffer());
                        if (lyx_view_->buffer()->lyxvc().inUse())
                                lyx_view_->buffer()->lyxvc().toggleReadOnly();
                        else
@@ -809,9 +831,11 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                case LFUN_BUFFER_CLOSE:
                        closeBuffer();
+                       view()->update();
                        break;
 
                case LFUN_BUFFER_WRITE:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (!lyx_view_->buffer()->isUnnamed()) {
                                docstring const str = bformat(_("Saving document %1$s..."),
                                         makeDisplayPath(lyx_view_->buffer()->fileName()));
@@ -820,15 +844,17 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                lyx_view_->message(str + _(" done."));
                        } else
                                writeAs(lyx_view_->buffer());
-                       update = false;
+                       updateFlags = Update::None;
                        break;
 
                case LFUN_BUFFER_WRITE_AS:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        writeAs(lyx_view_->buffer(), argument);
-                       update = false;
+                       updateFlags = Update::None;
                        break;
 
                case LFUN_BUFFER_RELOAD: {
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        docstring const file = makeDisplayPath(view()->buffer()->fileName(), 20);
                        docstring text = bformat(_("Any changes will be lost. Are you sure "
                                                             "you want to revert to the saved version of the document %1$s?"), file);
@@ -841,22 +867,27 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_BUFFER_UPDATE:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        Exporter::Export(lyx_view_->buffer(), argument, true);
                        break;
 
                case LFUN_BUFFER_VIEW:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        Exporter::preview(lyx_view_->buffer(), argument);
                        break;
 
                case LFUN_BUILD_PROGRAM:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        Exporter::Export(lyx_view_->buffer(), "program", true);
                        break;
 
                case LFUN_BUFFER_CHKTEX:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        lyx_view_->buffer()->runChktex();
                        break;
 
                case LFUN_BUFFER_EXPORT:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (argument == "custom")
                                lyx_view_->getDialogs().show("sendto");
                        else {
@@ -865,6 +896,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_BUFFER_EXPORT_CUSTOM: {
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        string format_name;
                        string command = split(argument, format_name, ' ');
                        Format const * format = formats.getFormat(format_name);
@@ -907,6 +939,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_BUFFER_PRINT: {
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        string target;
                        string target_name;
                        string command = split(split(argument, target, ' '),
@@ -1002,17 +1035,26 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_LYX_QUIT:
-                       if (view()->buffer()) {
+                       if (argument != "force") {
+                               if (!theApp->gui().closeAll())
+                                       break;
+                               lyx_view_ = 0;
+                       }
+
+                       // FIXME: this code needs to be transfered somewhere else
+                       // as lyx_view_ will most certainly be null and a same buffer
+                       // might be visible in more than one LyXView.
+                       if (lyx_view_ && lyx_view_->view()->buffer()) {
                                // save cursor Position for opened files to .lyx/session
-                               LyX::ref().session().saveFilePosition(lyx_view_->buffer()->fileName(),
+                               LyX::ref().session().lastFilePos().save(lyx_view_->buffer()->fileName(),
                                        boost::tie(view()->cursor().pit(), view()->cursor().pos()) );
-                               // save bookmarks to .lyx/session
-                               view()->saveSavedPositions();
-                       }                       
-                       LyX::ref().quit(argument == "force");
+                       }
+
+                       LyX::ref().quit();
                        break;
 
                case LFUN_TOC_VIEW: {
+                       BOOST_ASSERT(lyx_view_);
                        InsetCommandParams p("tableofcontents");
                        string const data = InsetCommandMailer::params2string("toc", p);
                        lyx_view_->getDialogs().show("toc", data, 0);
@@ -1024,10 +1066,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_RECONFIGURE:
-                       reconfigure(view());
+                       BOOST_ASSERT(lyx_view_);
+                       reconfigure(*lyx_view_);
                        break;
 
                case LFUN_HELP_OPEN: {
+                       BOOST_ASSERT(lyx_view_);
                        string const arg = argument;
                        if (arg.empty()) {
                                setErrorMessage(_("Missing argument"));
@@ -1047,6 +1091,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                // --- version control -------------------------------
                case LFUN_VC_REGISTER:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (!ensureBufferClean(view()))
                                break;
                        if (!lyx_view_->buffer()->lyxvc().inUse()) {
@@ -1056,6 +1101,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_VC_CHECK_IN:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (!ensureBufferClean(view()))
                                break;
                        if (lyx_view_->buffer()->lyxvc().inUse()
@@ -1066,6 +1112,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_VC_CHECK_OUT:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (!ensureBufferClean(view()))
                                break;
                        if (lyx_view_->buffer()->lyxvc().inUse()
@@ -1076,46 +1123,56 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_VC_REVERT:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        lyx_view_->buffer()->lyxvc().revert();
                        view()->reload();
                        break;
 
                case LFUN_VC_UNDO_LAST:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        lyx_view_->buffer()->lyxvc().undoLast();
                        view()->reload();
                        break;
 
                // --- buffers ----------------------------------------
                case LFUN_BUFFER_SWITCH:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->setBuffer(theBufferList().getBuffer(argument));
                        break;
 
                case LFUN_BUFFER_NEXT:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->setBuffer(theBufferList().next(view()->buffer()));
                        break;
 
                case LFUN_BUFFER_PREVIOUS:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->setBuffer(theBufferList().previous(view()->buffer()));
                        break;
 
                case LFUN_FILE_NEW:
+                       BOOST_ASSERT(lyx_view_);
                        newFile(view(), argument);
                        break;
 
                case LFUN_FILE_OPEN:
+                       BOOST_ASSERT(lyx_view_);
                        open(argument);
                        break;
 
                case LFUN_DROP_LAYOUTS_CHOICE:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->getToolbars().openLayoutList();
                        break;
 
                case LFUN_MENU_OPEN:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->getMenubar().openByName(from_utf8(argument));
                        break;
 
                // --- lyxserver commands ----------------------------
                case LFUN_SERVER_GET_NAME:
+                       BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        setMessage(from_utf8(lyx_view_->buffer()->fileName()));
                        lyxerr[Debug::INFO] << "FNAME["
                                                         << lyx_view_->buffer()->fileName()
@@ -1128,6 +1185,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_SERVER_GOTO_FILE_ROW: {
+                       BOOST_ASSERT(lyx_view_);
                        string file_name;
                        int row;
                        istringstream is(argument);
@@ -1156,6 +1214,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_DIALOG_SHOW: {
+                       BOOST_ASSERT(lyx_view_);
                        string const name = cmd.getArg(0);
                        string data = trim(to_utf8(cmd.argument()).substr(name.size()));
 
@@ -1186,12 +1245,14 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_DIALOG_SHOW_NEW_INSET: {
+                       BOOST_ASSERT(lyx_view_);
                        string const name = cmd.getArg(0);
                        string data = trim(to_utf8(cmd.argument()).substr(name.size()));
                        if (name == "bibitem" ||
                            name == "bibtex" ||
                            name == "index" ||
                            name == "label" ||
+                           name == "nomenclature" ||
                            name == "ref" ||
                            name == "toc" ||
                            name == "url") {
@@ -1238,6 +1299,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_DIALOG_UPDATE: {
+                       BOOST_ASSERT(lyx_view_);
                        string const & name = argument;
                        // Can only update a dialog connected to an existing inset
                        InsetBase * inset = lyx_view_->getDialogs().getOpenInset(name);
@@ -1257,11 +1319,13 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_DIALOG_DISCONNECT_INSET:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->getDialogs().disconnect(argument);
                        break;
 
 
                case LFUN_CITATION_INSERT: {
+                       BOOST_ASSERT(lyx_view_);
                        if (!argument.empty()) {
                                // we can have one optional argument, delimited by '|'
                                // citation-insert <key>|<text_before>
@@ -1285,12 +1349,13 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_BUFFER_CHILD_OPEN: {
+                       BOOST_ASSERT(lyx_view_);
                        string const filename =
                                makeAbsPath(argument, lyx_view_->buffer()->filePath());
                        // FIXME Should use bformat
                        setMessage(_("Opening child document ") +
                                         makeDisplayPath(filename) + "...");
-                       view()->savePosition(0);
+                       view()->saveBookmark(false);
                        string const parentfilename = lyx_view_->buffer()->fileName();
                        if (theBufferList().exists(filename))
                                lyx_view_->setBuffer(theBufferList().getBuffer(filename));
@@ -1304,22 +1369,27 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_TOGGLE_CURSOR_FOLLOWS_SCROLLBAR:
+                       BOOST_ASSERT(lyx_view_);
                        lyxrc.cursor_follows_scrollbar = !lyxrc.cursor_follows_scrollbar;
                        break;
 
                case LFUN_KEYMAP_OFF:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->view()->getIntl().keyMapOn(false);
                        break;
 
                case LFUN_KEYMAP_PRIMARY:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->view()->getIntl().keyMapPrim();
                        break;
 
                case LFUN_KEYMAP_SECONDARY:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->view()->getIntl().keyMapSec();
                        break;
 
                case LFUN_KEYMAP_TOGGLE:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->view()->getIntl().toggleKeyMap();
                        break;
 
@@ -1356,6 +1426,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_SCREEN_FONT_UPDATE:
+                       BOOST_ASSERT(lyx_view_);
                        // handle the screen font changes.
                        lyxrc.set_font_norm_type();
                        theFontLoader().update();
@@ -1399,10 +1470,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_MESSAGE:
+                       BOOST_ASSERT(lyx_view_);
                        lyx_view_->message(from_utf8(argument));
                        break;
 
                case LFUN_EXTERNAL_EDIT: {
+                       BOOST_ASSERT(lyx_view_);
                        FuncRequest fr(action, argument);
                        InsetExternal().dispatch(view()->cursor(), fr);
                        break;
@@ -1415,6 +1488,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_INSET_APPLY: {
+                       BOOST_ASSERT(lyx_view_);
                        string const name = cmd.getArg(0);
                        InsetBase * inset = lyx_view_->getDialogs().getOpenInset(name);
                        if (inset) {
@@ -1426,11 +1500,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        }
                        // ideally, the update flag should be set by the insets,
                        // but this is not possible currently
-                       updateforce = true;
+                       updateFlags = Update::Force | Update::FitCursor;
                        break;
                }
 
                case LFUN_ALL_INSETS_TOGGLE: {
+                       BOOST_ASSERT(lyx_view_);
                        string action;
                        string const name = split(argument, action, ' ');
                        InsetBase::Code const inset_code =
@@ -1450,11 +1525,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                        it->dispatch(tmpcur, fr);
                                }
                        }
-                       updateforce = true;
+                       updateFlags = Update::Force | Update::FitCursor;
                        break;
                }
 
                case LFUN_BUFFER_LANGUAGE: {
+                       BOOST_ASSERT(lyx_view_);
                        Buffer & buffer = *lyx_view_->buffer();
                        Language const * oldL = buffer.params().language;
                        Language const * newL = languages.getLanguage(argument);
@@ -1497,6 +1573,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_BUFFER_PARAMS_APPLY: {
+                       BOOST_ASSERT(lyx_view_);
                        biblio::CiteEngine const engine =
                                lyx_view_->buffer()->params().cite_engine;
 
@@ -1528,6 +1605,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_TEXTCLASS_APPLY: {
+                       BOOST_ASSERT(lyx_view_);
                        Buffer * buffer = lyx_view_->buffer();
 
                        textclass_type const old_class =
@@ -1559,7 +1637,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                        buffer->errors("Class Switch");
                        updateLabels(*buffer);
-                       updateforce = true;
+                       updateFlags = Update::Force | Update::FitCursor;
                        break;
                }
 
@@ -1585,29 +1663,64 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_WINDOW_NEW:
-                       BOOST_ASSERT(theApp);
                        LyX::ref().newLyXView();
+                       break;
+
+               case LFUN_WINDOW_CLOSE:
+                       BOOST_ASSERT(lyx_view_);
+                       BOOST_ASSERT(theApp);
+                       lyx_view_->close();
+                       // We return here because lyx_view does not exists anymore.
+                       return;
+
+               case LFUN_BOOKMARK_GOTO: {
+                       BOOST_ASSERT(lyx_view_);
+                       unsigned int idx = convert<unsigned int>(to_utf8(cmd.argument()));
+                       BookmarksSection::Bookmark const bm = LyX::ref().session().bookmarks().bookmark(idx);
+                       BOOST_ASSERT(!bm.filename.empty());
+                       // if the file is not opened, open it.
+                       if (!theBufferList().exists(bm.filename))
+                               dispatch(FuncRequest(LFUN_FILE_OPEN, bm.filename));
+                       // open may fail, so we need to test it again
+                       if (theBufferList().exists(bm.filename)) {
+                               // if the current buffer is not that one, switch to it.
+                               if (lyx_view_->buffer()->fileName() != bm.filename)
+                                       dispatch(FuncRequest(LFUN_BUFFER_SWITCH, bm.filename));
+                               // BOOST_ASSERT(lyx_view_->buffer()->fileName() != bm.filename);
+                               view()->moveToPosition(bm.par_id, bm.par_pos);
+                       } 
+                       break;
+               }
+
+               case LFUN_BOOKMARK_CLEAR:
+                       LyX::ref().session().bookmarks().clear();
+                       break;
+
+               case LFUN_TOOLBAR_TOGGLE_STATE:
+                       lyx_view_->toggleToolbarState(argument);
+                       break;
 
                default: {
+                       BOOST_ASSERT(lyx_view_);
                        view()->cursor().dispatch(cmd);
-                       update = false;
-                       updateforce |= view()->cursor().result().update();
+                       updateFlags = view()->cursor().result().update();
                        if (!view()->cursor().result().dispatched())
-                               updateforce |= view()->dispatch(cmd);
+                               if (view()->dispatch(cmd)) 
+                                       updateFlags = Update::Force | Update::FitCursor;
                        break;
                }
                }
 
-               if (view()->buffer()) {
+               if (lyx_view_ && view()->buffer()) {
                        // Redraw screen unless explicitly told otherwise.
                        // This also initializes the position cache for all insets
                        // in (at least partially) visible top-level paragraphs.
-                       if (updateforce)
-                               view()->update(Update::FitCursor | Update::Force);
-                       else if (update)
-                               view()->update(Update::FitCursor);
+                       std::pair<bool, bool> needSecondUpdate = view()->update(updateFlags);
 
-                       lyx_view_->redrawWorkArea();
+                       if (needSecondUpdate.first)
+                               view()->buffer()->changed(needSecondUpdate.second);
+
+                       lyx_view_->updateStatusBar();
 
                        // if we executed a mutating lfun, mark the buffer as dirty
                        if (flag.enabled()
@@ -1620,26 +1733,18 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        }
                }
        }
-       if (!quitting)
-               // FIXME UNICODE: _() does not support anything but ascii.
-               // Do we need a to_ascii() method?
+       if (!quitting) {
+               lyx_view_->updateMenubar();
+               lyx_view_->updateToolbars();
                sendDispatchMessage(getMessage(), cmd);
+       }
 }
 
 
 void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd)
 {
-       /* When an action did not originate from the UI/kbd, it makes
-        * sense to avoid updating the GUI. It turns out that this
-        * fixes bug 1941, for reasons that are described here:
-        * http://bugzilla.lyx.org/show_bug.cgi?id=1941#c4
-        */
-       if (cmd.origin != FuncRequest::INTERNAL) {
-               lyx_view_->updateMenubar();
-               lyx_view_->updateToolbars();
-       }
-
-       const bool verbose = (cmd.origin == FuncRequest::UI
+       const bool verbose = (cmd.origin == FuncRequest::MENU
+                             || cmd.origin == FuncRequest::TOOLBAR
                              || cmd.origin == FuncRequest::COMMANDBUFFER);
 
        if (cmd.action == LFUN_SELF_INSERT || !verbose) {
@@ -1891,7 +1996,7 @@ void LyXFunc::doImport(string const & argument)
 void LyXFunc::closeBuffer()
 {
        // save current cursor position
-       LyX::ref().session().saveFilePosition(lyx_view_->buffer()->fileName(),
+       LyX::ref().session().lastFilePos().save(lyx_view_->buffer()->fileName(),
                boost::tie(view()->cursor().pit(), view()->cursor().pos()) );
        if (theBufferList().close(lyx_view_->buffer(), true) && !quitting) {
                if (theBufferList().empty()) {
@@ -1983,6 +2088,7 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_LOADSESSION:
        case LyXRC::RC_CHKTEX_COMMAND:
        case LyXRC::RC_CONVERTER:
+       case LyXRC::RC_CONVERTER_CACHE_MAXAGE:
        case LyXRC::RC_COPIER:
        case LyXRC::RC_CURSOR_FOLLOWS_SCROLLBAR:
        case LyXRC::RC_CUSTOM_EXPORT_COMMAND:
@@ -2079,6 +2185,7 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_USER_NAME:
        case LyXRC::RC_USETEMPDIR:
        case LyXRC::RC_USE_ALT_LANG:
+       case LyXRC::RC_USE_CONVERTER_CACHE:
        case LyXRC::RC_USE_ESC_CHARS:
        case LyXRC::RC_USE_INP_ENC:
        case LyXRC::RC_USE_PERS_DICT: