]> git.lyx.org Git - lyx.git/blobdiff - src/lyxfunc.C
Fix bug 2195: Slowness in rendering inside insets, especially on the Mac
[lyx.git] / src / lyxfunc.C
index 8f99aa2aa8f99f22a4bca42d97e354fd32957b34..7a7882d85f4688cfea484db224cccb1dfbddb5fe 100644 (file)
 #include "bufferparams.h"
 #include "BufferView.h"
 #include "cursor.h"
+#include "CutAndPaste.h"
 #include "debug.h"
 #include "dispatchresult.h"
 #include "encoding.h"
+#include "errorlist.h"
 #include "exporter.h"
 #include "format.h"
 #include "funcrequest.h"
 #include "gettext.h"
 #include "importer.h"
+#include "insetiterator.h"
 #include "intl.h"
-#include "iterators.h"
 #include "kbmap.h"
+#include "language.h"
 #include "LColor.h"
 #include "lyx_cb.h"
 #include "LyXAction.h"
 #include "lyxfind.h"
+#include "lyxlex.h"
 #include "lyxrc.h"
 #include "lyxrow.h"
 #include "lyxserver.h"
+#include "lyxtextclasslist.h"
 #include "lyxvc.h"
 #include "paragraph.h"
+#include "pariterator.h"
 #include "ParagraphParameters.h"
 #include "undo.h"
 
@@ -58,6 +64,7 @@
 #include "insets/insetexternal.h"
 #include "insets/insetfloat.h"
 #include "insets/insetgraphics.h"
+#include "insets/insetinclude.h"
 #include "insets/insetnote.h"
 #include "insets/insettabular.h"
 #include "insets/insetvspace.h"
 #include "frontends/LyXKeySym.h"
 #include "frontends/LyXView.h"
 #include "frontends/Menubar.h"
-#include "frontends/Toolbar.h"
+#include "frontends/Toolbars.h"
 
-#include "support/FileInfo.h"
+#include "support/environment.h"
+#include "support/filefilterlist.h"
 #include "support/filetools.h"
 #include "support/forkedcontr.h"
-#include "support/globbing.h"
+#include "support/fs_extras.h"
+#include "support/lstrings.h"
 #include "support/path.h"
-#include "support/path_defines.h"
-#include "support/tostr.h"
-#include "support/std_sstream.h"
+#include "support/package.h"
+#include "support/systemcall.h"
+#include "support/convert.h"
 #include "support/os.h"
 
+#include <boost/current_function.hpp>
+#include <boost/filesystem/operations.hpp>
+
+#include <sstream>
+
 using bv_funcs::freefont2string;
 
+using lyx::support::AbsolutePath;
 using lyx::support::AddName;
 using lyx::support::AddPath;
 using lyx::support::bformat;
 using lyx::support::ChangeExtension;
+using lyx::support::contains;
 using lyx::support::FileFilterList;
-using lyx::support::FileInfo;
 using lyx::support::FileSearch;
 using lyx::support::ForkedcallsController;
 using lyx::support::i18nLibFileSearch;
@@ -98,17 +113,16 @@ using lyx::support::IsFileReadable;
 using lyx::support::isStrInt;
 using lyx::support::MakeAbsPath;
 using lyx::support::MakeDisplayPath;
+using lyx::support::package;
 using lyx::support::Path;
+using lyx::support::QuoteName;
 using lyx::support::rtrim;
 using lyx::support::split;
-using lyx::support::strToInt;
-using lyx::support::strToUnsignedInt;
-using lyx::support::system_lyxdir;
+using lyx::support::subst;
+using lyx::support::Systemcall;
 using lyx::support::token;
 using lyx::support::trim;
-using lyx::support::user_lyxdir;
 using lyx::support::prefixIs;
-using lyx::support::os::getTmpDir;
 
 using std::endl;
 using std::make_pair;
@@ -116,10 +130,12 @@ using std::pair;
 using std::string;
 using std::istringstream;
 
+namespace biblio = lyx::biblio;
+namespace fs = boost::filesystem;
+
 
 extern BufferList bufferlist;
 extern LyXServer * lyxserver;
-extern bool selection_possible;
 
 extern boost::scoped_ptr<kb_keymap> toplevel_keymap;
 
@@ -127,6 +143,61 @@ extern boost::scoped_ptr<kb_keymap> toplevel_keymap;
 extern tex_accent_struct get_accent(kb_action action);
 
 
+namespace {
+
+bool getStatus(LCursor cursor,
+              FuncRequest const & cmd, FuncStatus & status)
+{
+       // Try to fix cursor in case it is broken.
+       cursor.fixIfBroken();
+
+       // This is, of course, a mess. Better create a new doc iterator and use
+       // this in Inset::getStatus. This might require an additional
+       // BufferView * arg, though (which should be avoided)
+       //LCursor safe = *this;
+       bool res = false;
+       for ( ; cursor.depth(); cursor.pop()) {
+               //lyxerr << "\nLCursor::getStatus: cmd: " << cmd << endl << *this << endl;
+               BOOST_ASSERT(cursor.idx() <= cursor.lastidx());
+               BOOST_ASSERT(cursor.pit() <= cursor.lastpit());
+               BOOST_ASSERT(cursor.pos() <= cursor.lastpos());
+
+               // The inset's getStatus() will return 'true' if it made
+               // a definitive decision on whether it want to handle the
+               // request or not. The result of this decision is put into
+               // the 'status' parameter.
+               if (cursor.inset().getStatus(cursor, cmd, status)) {
+                       res = true;
+                       break;
+               }
+       }
+       return res;
+}
+
+
+/** Return the change status at cursor position, taking in account the
+ * status at each level of the document iterator (a table in a deleted
+ * footnote is deleted).
+ * When \param outer is true, the top slice is not looked at.
+ */
+Change::Type lookupChange(DocIterator const & dit, bool outer = false)
+{
+       size_t const depth = dit.depth() - (outer ? 1 : 0);
+
+       for (size_t i = 0 ; i < depth ; ++i) {
+               CursorSlice const & slice = dit[i];
+               if (!slice.inset().inMathed() 
+                   && slice.pos() < slice.paragraph().size()) {
+                       Change::Type const ch = slice.paragraph().lookupChange(slice.pos());
+                       if (ch != Change::UNCHANGED)
+                               return ch;
+               }
+       }
+       return Change::UNCHANGED;
+}
+
+}
+
 LyXFunc::LyXFunc(LyXView * lv)
        : owner(lv),
        encoded_last_key(0),
@@ -181,7 +252,9 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
        cancel_meta_seq.reset();
 
        FuncRequest func = cancel_meta_seq.addkey(keysym, state);
-       lyxerr[Debug::KEY] << "action first set to [" << func.action << ']' << endl;
+       lyxerr[Debug::KEY] << BOOST_CURRENT_FUNCTION
+                          << " action first set to [" << func.action << ']'
+                          << endl;
 
        // When not cancel or meta-fake, do the normal lookup.
        // Note how the meta_fake Mod1 bit is OR-ed in and reset afterwards.
@@ -189,20 +262,22 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
        if ((func.action != LFUN_CANCEL) && (func.action != LFUN_META_FAKE)) {
                // remove Caps Lock and Mod2 as a modifiers
                func = keyseq.addkey(keysym, (state | meta_fake_bit));
-               lyxerr[Debug::KEY] << "action now set to ["
-                       << func.action << ']' << endl;
+               lyxerr[Debug::KEY] << BOOST_CURRENT_FUNCTION
+                                  << "action now set to ["
+                                  << func.action << ']' << endl;
        }
 
        // Dont remove this unless you know what you are doing.
        meta_fake_bit = key_modifier::none;
 
-       // can this happen now ?
+       // Can this happen now ?
        if (func.action == LFUN_NOACTION) {
                func = FuncRequest(LFUN_PREFIX);
        }
 
        if (lyxerr.debugging(Debug::KEY)) {
-               lyxerr << "Key [action="
+               lyxerr << BOOST_CURRENT_FUNCTION
+                      << " Key [action="
                       << func.action << "]["
                       << keyseq.print() << ']'
                       << endl;
@@ -232,7 +307,8 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
                // by a binding
                if (keysym->isText() && keyseq.length() == 1) {
                        lyxerr[Debug::KEY] << "isText() is true, inserting." << endl;
-                       func = FuncRequest(LFUN_SELFINSERT);
+                       func = FuncRequest(LFUN_SELFINSERT, 
+                                          FuncRequest::KEYBOARD);
                } else {
                        lyxerr[Debug::KEY] << "Unknown, !isText() - giving up" << endl;
                        owner->message(_("Unknown function."));
@@ -242,8 +318,9 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
 
        if (func.action == LFUN_SELFINSERT) {
                if (encoded_last_key != 0) {
-                       string arg(1, encoded_last_key);
-                       dispatch(FuncRequest(LFUN_SELFINSERT, arg));
+                       string const arg(1, encoded_last_key);
+                       dispatch(FuncRequest(LFUN_SELFINSERT, arg, 
+                                            FuncRequest::KEYBOARD));
                        lyxerr[Debug::KEY]
                                << "SelfInsert arg[`" << arg << "']" << endl;
                }
@@ -257,11 +334,24 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
 {
        //lyxerr << "LyXFunc::getStatus: cmd: " << cmd << endl;
        FuncStatus flag;
-       Buffer * buf = owner->buffer();
        LCursor & cur = view()->cursor();
 
+       /* In LyX/Mac, when a dialog is open, the menus of the
+          application can still be accessed without giving focus to
+          the main window. In this case, we want to disable the menu
+          entries that are buffer-related.
+
+          Note that this code is not perfect, as bug 1941 attests:
+          http://bugzilla.lyx.org/show_bug.cgi?id=1941#c4
+       */
+       Buffer * buf;
+       if (cmd.origin == FuncRequest::UI && !owner->hasFocus())
+               buf = 0;
+       else
+               buf = owner->buffer();
+
        if (cmd.action == LFUN_NOACTION) {
-               setStatusMessage(N_("Nothing to do"));
+               flag.message(N_("Nothing to do"));
                flag.enabled(false);
                return flag;
        }
@@ -279,33 +369,23 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        }
 
        if (flag.unknown()) {
-               setStatusMessage(N_("Unknown action"));
+               flag.message(N_("Unknown action"));
                return flag;
        }
 
-       // the default error message if we disable the command
-       setStatusMessage(N_("Command disabled"));
+       if (!flag.enabled()) {
+               if (flag.message().empty())
+                       flag.message(N_("Command disabled"));
+               return flag;
+       }
 
        // Check whether we need a buffer
-       if (!lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)) {
-               // Yes we need a buffer, do we have one?
-               if (buf) {
-                       // yes
-                       // Can we use a readonly buffer?
-                       if (buf->isReadonly() &&
-                           !lyxaction.funcHasFlag(cmd.action,
-                                                  LyXAction::ReadOnly)) {
-                               // no
-                               setStatusMessage(N_("Document is read-only"));
-                               flag.enabled(false);
-                       }
-               } else {
-                       // no
-                       setStatusMessage(N_("Command not allowed with"
-                                           "out any document open"));
-                       flag.enabled(false);
-                       return flag;
-               }
+       if (!lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer) && !buf) {
+               // no, exit directly
+               flag.message(N_("Command not allowed with"
+                                   "out any document open"));
+               flag.enabled(false);
+               return flag;
        }
 
        // I would really like to avoid having this switch and rather try to
@@ -329,24 +409,10 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                        flag.setOnOff(true);
                break;
 
-       case LFUN_TRACK_CHANGES:
-               flag.setOnOff(buf->params().tracking_changes);
-               break;
-
        case LFUN_EXPORT:
                enable = cmd.argument == "custom"
                        || Exporter::IsExportable(*buf, cmd.argument);
                break;
-       case LFUN_UNDO:
-               enable = !buf->undostack().empty();
-               break;
-       case LFUN_REDO:
-               enable = !buf->redostack().empty();
-               break;
-       case LFUN_CUT:
-       case LFUN_COPY:
-               enable = cur.selection();
-               break;
 
        case LFUN_RUNCHKTEX:
                enable = buf->isLatex() && lyxrc.chktex_command != "none";
@@ -362,7 +428,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
 
        case LFUN_LAYOUT:
        case LFUN_LAYOUT_PARAGRAPH:
-               enable = !cur.inset().forceDefaultParagraphs(&cur.inset());
+               enable = !cur.inset().forceDefaultParagraphs(cur.idx());
                break;
 
        case LFUN_VC_REGISTER:
@@ -381,56 +447,32 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_MENURELOAD:
                enable = !buf->isUnnamed() && !buf->isClean();
                break;
-       case LFUN_BOOKMARK_GOTO:
-               enable = view()->isSavedPosition(strToUnsignedInt(cmd.argument));
-               break;
-
-       case LFUN_MERGE_CHANGES:
-       case LFUN_ACCEPT_CHANGE:
-       case LFUN_REJECT_CHANGE:
-       case LFUN_ACCEPT_ALL_CHANGES:
-       case LFUN_REJECT_ALL_CHANGES:
-               enable = buf && buf->params().tracking_changes;
-               break;
 
        case LFUN_INSET_SETTINGS: {
                enable = false;
-               if (!cur.size())
-                       break;
-               UpdatableInset * inset = cur.inset().asUpdatableInset();
-               lyxerr << "inset: " << inset << endl;
-               if (!inset)
+               if (!cur)
                        break;
-
-               // jump back to owner if an InsetText, so
-               // we get back to the InsetTabular or whatever
-               if (inset->lyxCode() == InsetOld::TEXT_CODE)
-                       inset = inset->owner();
-               lyxerr << "inset 2: " << inset << endl;
-               if (!inset)
-                       break;
-
-               InsetOld::Code code = inset->lyxCode();
+               InsetBase::Code code = cur.inset().lyxCode();
                switch (code) {
-                       case InsetOld::TABULAR_CODE:
+                       case InsetBase::TABULAR_CODE:
                                enable = cmd.argument == "tabular";
                                break;
-                       case InsetOld::ERT_CODE:
+                       case InsetBase::ERT_CODE:
                                enable = cmd.argument == "ert";
                                break;
-                       case InsetOld::FLOAT_CODE:
+                       case InsetBase::FLOAT_CODE:
                                enable = cmd.argument == "float";
                                break;
-                       case InsetOld::WRAP_CODE:
+                       case InsetBase::WRAP_CODE:
                                enable = cmd.argument == "wrap";
                                break;
-                       case InsetOld::NOTE_CODE:
+                       case InsetBase::NOTE_CODE:
                                enable = cmd.argument == "note";
                                break;
-                       case InsetOld::BRANCH_CODE:
+                       case InsetBase::BRANCH_CODE:
                                enable = cmd.argument == "branch";
                                break;
-                       case InsetOld::BOX_CODE:
+                       case InsetBase::BOX_CODE:
                                enable = cmd.argument == "box";
                                break;
                        default:
@@ -439,25 +481,75 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                break;
        }
 
+       case LFUN_INSET_APPLY: {
+               string const name = cmd.getArg(0);
+               InsetBase * inset = owner->getDialogs().getOpenInset(name);
+               if (inset) {
+                       FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument);
+                       FuncStatus fs;
+                       bool const success = inset->getStatus(cur, fr, fs);
+                       // Every inset is supposed to handle this
+                       BOOST_ASSERT(success);
+                       flag |= fs;
+               } else {
+                       FuncRequest fr(LFUN_INSET_INSERT, cmd.argument);
+                       flag |= getStatus(fr);
+               }
+               enable = flag.enabled();
+               break;
+       }
+
        case LFUN_DIALOG_SHOW: {
                string const name = cmd.getArg(0);
                if (!buf)
                        enable = name == "aboutlyx"
                                || name == "file"
-                               || name == "preferences"
+                               || name == "forks"
+                               || name == "prefs"
                                || name == "texinfo";
                else if (name == "print")
                        enable = Exporter::IsExportable(*buf, "dvi")
                                && lyxrc.print_command != "none";
-               else if (name == "character")
-                       enable = cur.inset().lyxCode() != InsetOld::ERT_CODE;
-               else if (name == "vclog")
-                       enable = buf->lyxvc().inUse();
+               else if (name == "character" || name == "mathpanel")
+                       enable = cur.inset().lyxCode() != InsetBase::ERT_CODE;
                else if (name == "latexlog")
                        enable = IsFileReadable(buf->getLogName().second);
+#if !defined (USE_ASPELL) && !defined (USE_ISPELL) && !defined (USE_PSPELL)
+               else if (name == "spellchecker")
+                       enable = false;
+#endif
+               else if (name == "vclog")
+                       enable = buf->lyxvc().inUse();
+               break;
+       }
+
+       case LFUN_DIALOG_SHOW_NEW_INSET:
+               enable = cur.inset().lyxCode() != InsetBase::ERT_CODE;
+               break;
+
+       case LFUN_DIALOG_UPDATE: {
+               string const name = cmd.getArg(0);
+               if (!buf)
+                       enable = name == "prefs";
                break;
        }
 
+       case LFUN_INSERT_CITATION: {
+               FuncRequest fr(LFUN_INSET_INSERT, "citation");
+               enable = getStatus(fr).enabled();
+               break;
+       }
+
+       // this one is difficult to get right. As a half-baked
+       // solution, we consider only the first action of the sequence
+       case LFUN_SEQUENCE: {
+               // argument contains ';'-terminated commands
+               string const firstcmd = token(cmd.argument, ';', 0);
+               FuncRequest func(lyxaction.lookupFunc(firstcmd));
+               func.origin = cmd.origin;
+               flag = getStatus(func);
+       }
+
        case LFUN_MENUNEW:
        case LFUN_MENUNEWTMPLT:
        case LFUN_WORDFINDFORWARD:
@@ -484,10 +576,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_GETNAME:
        case LFUN_NOTIFY:
        case LFUN_GOTOFILEROW:
-       case LFUN_GOTO_PARAGRAPH:
-       case LFUN_DIALOG_SHOW_NEW_INSET:
        case LFUN_DIALOG_SHOW_NEXT_INSET:
-       case LFUN_DIALOG_UPDATE:
        case LFUN_DIALOG_HIDE:
        case LFUN_DIALOG_DISCONNECT_INSET:
        case LFUN_CHILDOPEN:
@@ -497,21 +586,56 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_KMAP_SEC:
        case LFUN_KMAP_TOGGLE:
        case LFUN_REPEAT:
-       case LFUN_SEQUENCE:
+       case LFUN_EXPORT_CUSTOM:
+       case LFUN_PRINT:
        case LFUN_SAVEPREFERENCES:
        case LFUN_SCREEN_FONT_UPDATE:
        case LFUN_SET_COLOR:
        case LFUN_MESSAGE:
        case LFUN_EXTERNAL_EDIT:
+       case LFUN_GRAPHICS_EDIT:
+       case LFUN_ALL_INSETS_TOGGLE:
+       case LFUN_LANGUAGE_BUFFER:
+       case LFUN_TEXTCLASS_APPLY:
+       case LFUN_TEXTCLASS_LOAD:
+       case LFUN_SAVE_AS_DEFAULT:
+       case LFUN_BUFFERPARAMS_APPLY:
+       case LFUN_LYXRC_APPLY:
+       case LFUN_NEXTBUFFER:
+       case LFUN_PREVIOUSBUFFER:
                // these are handled in our dispatch()
                break;
 
        default:
-               cur.getStatus(cmd, flag);
-               return flag;
+
+               if (!::getStatus(cur, cmd, flag))
+                       flag = view()->getStatus(cmd);
+       }
+
+       if (!enable)
+               flag.enabled(false);
+
+       // Can we use a readonly buffer?
+       if (buf && buf->isReadonly()
+           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly)
+           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)) {
+               flag.message(N_("Document is read-only"));
+               flag.enabled(false);
+       }
+
+       // Are we in a DELETED change-tracking region?
+       if (buf && buf->params().tracking_changes
+           && lookupChange(cur, true) == Change::DELETED
+           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly)
+           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)) {
+               flag.message(N_("This portion of the document is deleted."));
+               flag.enabled(false);
        }
 
-       flag.enabled(enable);
+       // the default error message if we disable the command
+       if (!flag.enabled() && flag.message().empty())
+               flag.message(N_("Command disabled"));
+
        return flag;
 }
 
@@ -538,11 +662,47 @@ bool ensureBufferClean(BufferView * bv)
        return buf.isClean();
 }
 
+
+void showPrintError(string const & name)
+{
+       string str = bformat(_("Could not print the document %1$s.\n"
+                              "Check that your printer is set up correctly."),
+                            MakeDisplayPath(name, 50));
+       Alert::error(_("Print document failed"), str);
+}
+
+
+void loadTextclass(string const & name)
+{
+       std::pair<bool, lyx::textclass_type> const tc_pair =
+               textclasslist.NumberOfClass(name);
+
+       if (!tc_pair.first) {
+               lyxerr << "Document class \"" << name
+                      << "\" does not exist."
+                      << std::endl;
+               return;
+       }
+
+       lyx::textclass_type const tc = tc_pair.second;
+
+       if (!textclasslist[tc].load()) {
+               string s = bformat(_("The document could not be converted\n"
+                                    "into the document class %1$s."),
+                                  textclasslist[tc].name());
+               Alert::error(_("Could not change class"), s);
+       }
+}
+
+
+void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new);
+
 } //namespace anon
 
 
-void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
+void LyXFunc::dispatch(FuncRequest const & cmd)
 {
+       BOOST_ASSERT(view());
        string const argument = cmd.argument;
        kb_action const action = cmd.action;
 
@@ -552,16 +712,17 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
        // we have not done anything wrong yet.
        errorstat = false;
        dispatch_buffer.erase();
-       selection_possible = false;
 
-       // We cannot use this function here
-       if (!getStatus(cmd).enabled()) {
+       bool update = false;
+
+       FuncStatus const flag = getStatus(cmd);
+       if (!flag.enabled()) {
+               // We cannot use this function here
                lyxerr[Debug::ACTION] << "LyXFunc::dispatch: "
                       << lyxaction.getActionName(action)
                       << " [" << action << "] is disabled at this location"
                       << endl;
-               setErrorMessage(getStatusMessage());
-
+               setErrorMessage(flag.message());
        } else {
 
                if (view()->available())
@@ -587,7 +748,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        bool const fw = action == LFUN_WORDFINDFORWARD;
                        string const data =
                                lyx::find::find2string(searched_string, true, false, fw);
-                       view()->dispatch(FuncRequest(LFUN_WORD_FIND, data));
+                       lyx::find::find(view(), FuncRequest(LFUN_WORD_FIND, data));
                        break;
                }
 
@@ -596,6 +757,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        break;
 
                case LFUN_EXEC_COMMAND:
+                       owner->getToolbars().display("minibuffer", true);
                        owner->focus_command_buffer();
                        break;
 
@@ -683,27 +845,153 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
 
                case LFUN_EXPORT:
                        if (argument == "custom")
-                               owner->getDialogs().showSendto();
+                               owner->getDialogs().show("sendto");
                        else {
                                Exporter::Export(owner->buffer(), argument, false);
                                view()->showErrorList(BufferFormat(*owner->buffer()));
                        }
                        break;
 
+               case LFUN_EXPORT_CUSTOM: {
+                       string format_name;
+                       string command = split(argument, format_name, ' ');
+                       Format const * format = formats.getFormat(format_name);
+                       if (!format) {
+                               lyxerr << "Format \"" << format_name
+                                      << "\" not recognized!"
+                                      << std::endl;
+                               break;
+                       }
+
+                       Buffer * buffer = owner->buffer();
+
+                       // The name of the file created by the conversion process
+                       string filename;
+
+                       // Output to filename
+                       if (format->name() == "lyx") {
+                               string const latexname =
+                                       buffer->getLatexName(false);
+                               filename = ChangeExtension(latexname,
+                                                          format->extension());
+                               filename = AddName(buffer->temppath(), filename);
+
+                               if (!buffer->writeFile(filename))
+                                       break;
+
+                       } else {
+                               Exporter::Export(buffer, format_name, true,
+                                                filename);
+                       }
+
+                       // Substitute $$FName for filename
+                       if (!contains(command, "$$FName"))
+                               command = "( " + command + " ) < $$FName";
+                       command = subst(command, "$$FName", filename);
+
+                       // Execute the command in the background
+                       Systemcall call;
+                       call.startscript(Systemcall::DontWait, command);
+                       break;
+               }
+
+               case LFUN_PRINT: {
+                       string target;
+                       string target_name;
+                       string command = split(split(argument, target, ' '),
+                                              target_name, ' ');
+
+                       if (target.empty()
+                           || target_name.empty()
+                           || command.empty()) {
+                               lyxerr << "Unable to parse \""
+                                      << argument << '"' << std::endl;
+                               break;
+                       }
+                       if (target != "printer" && target != "file") {
+                               lyxerr << "Unrecognized target \""
+                                      << target << '"' << std::endl;
+                               break;
+                       }
+
+                       Buffer * buffer = owner->buffer();
+
+                       if (!Exporter::Export(buffer, "dvi", true)) {
+                               showPrintError(buffer->fileName());
+                               break;
+                       }
+
+                       // Push directory path.
+                       string const path = buffer->temppath();
+                       Path p(path);
+
+                       // there are three cases here:
+                       // 1. we print to a file
+                       // 2. we print directly to a printer
+                       // 3. we print using a spool command (print to file first)
+                       Systemcall one;
+                       int res = 0;
+                       string const dviname =
+                               ChangeExtension(buffer->getLatexName(true),
+                                               "dvi");
+
+                       if (target == "printer") {
+                               if (!lyxrc.print_spool_command.empty()) {
+                                       // case 3: print using a spool
+                                       string const psname =
+                                               ChangeExtension(dviname,".ps");
+                                       command += lyxrc.print_to_file
+                                               + QuoteName(psname)
+                                               + ' '
+                                               + QuoteName(dviname);
+
+                                       string command2 =
+                                               lyxrc.print_spool_command +' ';
+                                       if (target_name != "default") {
+                                               command2 += lyxrc.print_spool_printerprefix
+                                                       + target_name
+                                                       + ' ';
+                                       }
+                                       command2 += QuoteName(psname);
+                                       // First run dvips.
+                                       // If successful, then spool command
+                                       res = one.startscript(
+                                               Systemcall::Wait,
+                                               command);
+
+                                       if (res == 0)
+                                               res = one.startscript(
+                                                       Systemcall::DontWait,
+                                                       command2);
+                               } else {
+                                       // case 2: print directly to a printer
+                                       res = one.startscript(
+                                               Systemcall::DontWait,
+                                               command + QuoteName(dviname));
+                               }
+
+                       } else {
+                               // case 1: print to a file
+                               command += lyxrc.print_to_file
+                                       + QuoteName(MakeAbsPath(target_name,
+                                                               path))
+                                       + ' '
+                                       + QuoteName(dviname);
+                               res = one.startscript(Systemcall::DontWait,
+                                                     command);
+                       }
+
+                       if (res != 0)
+                               showPrintError(buffer->fileName());
+                       break;
+               }
+
                case LFUN_IMPORT:
                        doImport(argument);
                        break;
 
                case LFUN_QUIT:
-#if 0
-                       // test speed of DocumentIterator
-                       lyxerr << "start" << endl;
-                       for (DocumentIterator it(owner->buffer()->inset()), end;
-                               it != end; it.forwardPos())
-                               ;
-                       lyxerr << "end" << endl;
-#endif
-                       QuitLyX();
+                       QuitLyX(argument == "force");
                        break;
 
                case LFUN_TOCVIEW: {
@@ -784,6 +1072,14 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        view()->setBuffer(bufferlist.getBuffer(argument));
                        break;
 
+               case LFUN_NEXTBUFFER:
+                       view()->setBuffer(bufferlist.next(view()->buffer()));
+                       break;
+
+               case LFUN_PREVIOUSBUFFER:
+                       view()->setBuffer(bufferlist.previous(view()->buffer()));
+                       break;
+
                case LFUN_FILE_NEW:
                        NewFile(view(), argument);
                        break;
@@ -793,7 +1089,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        break;
 
                case LFUN_DROP_LAYOUTS_CHOICE:
-                       owner->getToolbar().openLayoutList();
+                       owner->getToolbars().openLayoutList();
                        break;
 
                case LFUN_MENU_OPEN_BY_NAME:
@@ -818,7 +1114,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        int row;
                        istringstream is(argument);
                        is >> file_name >> row;
-                       if (prefixIs(file_name, getTmpDir())) {
+                       if (prefixIs(file_name, package().temp_dir())) {
                                // Needed by inverse dvi search. If it is a file
                                // in tmpdir, call the apropriated function
                                view()->setBuffer(bufferlist.getBufferFromTmp(file_name));
@@ -842,32 +1138,6 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        break;
                }
 
-               case LFUN_GOTO_PARAGRAPH: {
-                       istringstream is(argument);
-                       int id;
-                       is >> id;
-                       ParIterator par = owner->buffer()->getParFromID(id);
-                       if (par == owner->buffer()->par_iterator_end()) {
-                               lyxerr[Debug::INFO] << "No matching paragraph found! ["
-                                                               << id << ']' << endl;
-                               break;
-                       } else {
-                               lyxerr[Debug::INFO] << "Paragraph " << par->id()
-                                                               << " found." << endl;
-                       }
-
-                       // Set the cursor
-                       view()->setCursor(par, 0);
-
-                       view()->switchKeyMap();
-                       owner->view_state_changed();
-
-                       view()->center();
-                       // see BufferView_pimpl::center()
-                       view()->updateScrollbar();
-                       break;
-               }
-
                case LFUN_DIALOG_SHOW: {
                        string const name = cmd.getArg(0);
                        string data = trim(cmd.argument.substr(name.size()));
@@ -877,16 +1147,6 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                                if (!data.empty())
                                        owner->getDialogs().show("character", data);
                        }
-                       else if (name == "document")
-                               owner->getDialogs().showDocument();
-                       else if (name == "preamble")
-                               owner->getDialogs().showPreamble();
-                       else if (name == "preferences")
-                               owner->getDialogs().showPreferences();
-                       else if (name == "print")
-                               owner->getDialogs().showPrint();
-                       else if (name == "spellchecker")
-                               owner->getDialogs().showSpellchecker();
 
                        else if (name == "latexlog") {
                                pair<Buffer::LogType, string> const logfile =
@@ -917,7 +1177,6 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        string data = trim(cmd.argument.substr(name.size()));
                        if (name == "bibitem" ||
                            name == "bibtex" ||
-                           name == "include" ||
                            name == "index" ||
                            name == "label" ||
                            name == "ref" ||
@@ -925,6 +1184,9 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                            name == "url") {
                                InsetCommandParams p(name);
                                data = InsetCommandMailer::params2string(name, p);
+                       } else if (name == "include") {
+                               InsetCommandParams p(data);
+                               data = InsetIncludeMailer::params2string(p);
                        } else if (name == "box") {
                                // \c data == "Boxed" || "Frameless" etc
                                InsetBoxParams p(data);
@@ -974,6 +1236,8 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                                inset->dispatch(view()->cursor(), fr);
                        } else if (name == "paragraph") {
                                dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
+                       } else if (name == "prefs") {
+                               owner->getDialogs().update(name, string());
                        }
                        break;
                }
@@ -986,6 +1250,30 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        owner->getDialogs().disconnect(argument);
                        break;
 
+               
+               case LFUN_INSERT_CITATION: {
+                       if (!argument.empty()) {
+                               // we can have one optional argument, delimited by '|'
+                               // citation-insert <key>|<text_before>
+                               // this should be enhanced to also support text_after 
+                               // and citation style
+                               string arg = argument;
+                               string opt1;
+                               if (contains(argument, "|")) {
+                                       arg = token(argument, '|', 0);
+                                       opt1 = '[' + token(argument, '|', 1) + ']';
+                               }
+                               std::ostringstream os;
+                               os << "citation LatexCommand\n"
+                                  << "\\cite" << opt1 << "{" << arg << "}\n"
+                                  << "\\end_inset";
+                               FuncRequest fr(LFUN_INSET_INSERT, os.str());
+                               dispatch(fr);
+                       } else
+                               dispatch(FuncRequest(LFUN_DIALOG_SHOW, "citation"));
+                       break;
+               }
+
                case LFUN_CHILDOPEN: {
                        string const filename =
                                MakeAbsPath(argument, owner->buffer()->filePath());
@@ -1037,18 +1325,22 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        break;
                }
 
-               case LFUN_SEQUENCE:
+               case LFUN_SEQUENCE: {
                        // argument contains ';'-terminated commands
-                       while (!argument.empty()) {
+                       string arg = argument;
+                       while (!arg.empty()) {
                                string first;
-                               string rest = split(argument, first, ';');
-                               dispatch(lyxaction.lookupFunc(rest));
+                               arg = split(arg, first, ';');
+                               FuncRequest func(lyxaction.lookupFunc(first));
+                               func.origin = cmd.origin;
+                               dispatch(func);
                        }
                        break;
+               }
 
                case LFUN_SAVEPREFERENCES: {
-                       Path p(user_lyxdir());
-                       lyxrc.write("preferences");
+                       Path p(package().user_support());
+                       lyxrc.write("preferences", false);
                        break;
                }
 
@@ -1073,8 +1365,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                                (lyx_name == lcolor.getLyXName(LColor::graphicsbg) &&
                                 x11_name != lcolor.getX11Name(LColor::graphicsbg));
 
-                       LColor::color col = lcolor.getFromLyXName(lyx_name);
-                       if (!lcolor.setColor(col, x11_name)) {
+                       if (!lcolor.setColor(lyx_name, x11_name)) {
                                setErrorMessage(
                                        bformat(_("Set-color \"%1$s\" failed "
                                                                "- color is undefined or "
@@ -1109,38 +1400,228 @@ void LyXFunc::dispatch(FuncRequest const & cmd, bool verbose)
                        break;
                }
 
+               case LFUN_GRAPHICS_EDIT: {
+                       FuncRequest fr(action, argument);
+                       InsetGraphics().dispatch(view()->cursor(), fr);
+                       break;
+               }
+
+               case LFUN_INSET_APPLY: {
+                       string const name = cmd.getArg(0);
+                       InsetBase * inset = owner->getDialogs().getOpenInset(name);
+                       if (inset) {
+                               FuncRequest fr(LFUN_INSET_MODIFY, argument);
+                               inset->dispatch(view()->cursor(), fr);
+                       } else {
+                               FuncRequest fr(LFUN_INSET_INSERT, argument);
+                               dispatch(fr);
+                       }
+                       // ideally, the update flag should be set by the insets,
+                       // but this is not possible currently
+                       update = true;
+                       break;
+               }
+
+               case LFUN_ALL_INSETS_TOGGLE: {
+                       string action;
+                       string const name = split(argument, action, ' ');
+                       InsetBase::Code const inset_code =
+                               InsetBase::translate(name);
+
+                       LCursor & cur = view()->cursor();
+                       FuncRequest fr(LFUN_INSET_TOGGLE, action);
+
+                       InsetBase & inset = owner->buffer()->inset();
+                       InsetIterator it  = inset_iterator_begin(inset);
+                       InsetIterator const end = inset_iterator_end(inset);
+                       for (; it != end; ++it) {
+                               if (inset_code == InsetBase::NO_CODE
+                                   || inset_code == it->lyxCode()) {
+                                       LCursor tmpcur = cur;
+                                       tmpcur.pushLeft(*it);
+                                       it->dispatch(tmpcur, fr);
+                               }
+                       }
+                       update = true;
+                       break;
+               }
+
+               case LFUN_LANGUAGE_BUFFER: {
+                       Buffer & buffer = *owner->buffer();
+                       Language const * oldL = buffer.params().language;
+                       Language const * newL = languages.getLanguage(argument);
+                       if (!newL || oldL == newL)
+                               break;
+
+                       if (oldL->RightToLeft() == newL->RightToLeft()
+                           && !buffer.isMultiLingual())
+                               buffer.changeLanguage(oldL, newL);
+                       else
+                               buffer.updateDocLang(newL);
+                       break;
+               }
+
+               case LFUN_SAVE_AS_DEFAULT: {
+                       string const fname =
+                               AddName(AddPath(package().user_support(), "templates/"),
+                                       "defaults.lyx");
+                       Buffer defaults(fname);
+
+                       istringstream ss(argument);
+                       LyXLex lex(0,0);
+                       lex.setStream(ss);
+                       int const unknown_tokens = defaults.readHeader(lex);
+
+                       if (unknown_tokens != 0) {
+                               lyxerr << "Warning in LFUN_SAVE_AS_DEFAULT!\n"
+                                      << unknown_tokens << " unknown token"
+                                      << (unknown_tokens == 1 ? "" : "s")
+                                      << endl;
+                       }
+
+                       if (defaults.writeFile(defaults.fileName()))
+                               setMessage(_("Document defaults saved in ")
+                                          + MakeDisplayPath(fname));
+                       else
+                               setErrorMessage(_("Unable to save document defaults"));
+                       break;
+               }
+
+               case LFUN_BUFFERPARAMS_APPLY: {
+                       biblio::CiteEngine const engine =
+                               owner->buffer()->params().cite_engine;
+
+                       istringstream ss(argument);
+                       LyXLex lex(0,0);
+                       lex.setStream(ss);
+                       int const unknown_tokens =
+                               owner->buffer()->readHeader(lex);
+
+                       if (unknown_tokens != 0) {
+                               lyxerr << "Warning in LFUN_BUFFERPARAMS_APPLY!\n"
+                                      << unknown_tokens << " unknown token"
+                                      << (unknown_tokens == 1 ? "" : "s")
+                                      << endl;
+                       }
+                       if (engine == owner->buffer()->params().cite_engine)
+                               break;
+
+                       LCursor & cur = view()->cursor();
+                       FuncRequest fr(LFUN_INSET_REFRESH);
+
+                       InsetBase & inset = owner->buffer()->inset();
+                       InsetIterator it  = inset_iterator_begin(inset);
+                       InsetIterator const end = inset_iterator_end(inset);
+                       for (; it != end; ++it)
+                               if (it->lyxCode() == InsetBase::CITE_CODE)
+                                       it->dispatch(cur, fr);
+                       break;
+               }
+
+               case LFUN_TEXTCLASS_APPLY: {
+                       Buffer * buffer = owner->buffer();
+
+                       lyx::textclass_type const old_class =
+                               buffer->params().textclass;
+
+                       loadTextclass(argument);
+
+                       std::pair<bool, lyx::textclass_type> const tc_pair =
+                               textclasslist.NumberOfClass(argument);
+
+                       if (!tc_pair.first)
+                               break;
+
+                       lyx::textclass_type const new_class = tc_pair.second;
+                       if (old_class == new_class)
+                               // nothing to do
+                               break;
+
+                       owner->message(_("Converting document to new document class..."));
+                       recordUndoFullDocument(view());
+                       buffer->params().textclass = new_class;
+                       StableDocIterator backcur(view()->cursor());
+                       ErrorList el;
+                       lyx::cap::SwitchBetweenClasses(
+                               old_class, new_class,
+                               buffer->paragraphs(), el);
+
+                       view()->setCursor(backcur.asDocIterator(&(buffer->inset())));
+                       bufferErrors(*buffer, el);
+                       view()->showErrorList(_("Class switch"));
+                       updateCounters(*buffer);
+                       update = true;
+                       break;
+               }
+
+               case LFUN_TEXTCLASS_LOAD:
+                       loadTextclass(argument);
+                       break;
+
+               case LFUN_LYXRC_APPLY: {
+                       LyXRC const lyxrc_orig = lyxrc;
+
+                       istringstream ss(argument);
+                       bool const success = lyxrc.read(ss) == 0;
+
+                       if (!success) {
+                               lyxerr << "Warning in LFUN_LYXRC_APPLY!\n"
+                                      << "Unable to read lyxrc data"
+                                      << endl;
+                               break;
+                       }
+
+                       actOnUpdatedPrefs(lyxrc_orig, lyxrc);
+                       break;
+               }
+
                default: {
-                       DispatchResult res = view()->cursor().dispatch(cmd);
-                       if (!res.dispatched());
-                               view()->dispatch(cmd);
+                       view()->cursor().dispatch(cmd);
+                       update |= view()->cursor().result().update();
+                       if (!view()->cursor().result().dispatched())
+                               update |= view()->dispatch(cmd);
                        break;
                }
                }
-       }
 
-       if (view()->available()) {
-               view()->fitCursor();
-               view()->update();
-               view()->cursor().updatePos();
-               // if we executed a mutating lfun, mark the buffer as dirty
-               if (getStatus(cmd).enabled()
-                   && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)
-                   && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly))
-                       view()->buffer()->markDirty();
-       }
+               if (view()->available()) {
+                       // Redraw screen unless explicitly told otherwise.
+                       // This also initializes the position cache for all insets
+                       // in (at least partially) visible top-level paragraphs.
+                       if (update)
+                               view()->update(Update::FitCursor | Update::Force);
+                       else
+                               view()->update(Update::FitCursor);
 
-       if (view()->cursor().inTexted()) {
-               view()->owner()->updateLayoutChoice();
-               sendDispatchMessage(getMessage(), cmd, verbose);
+                       // if we executed a mutating lfun, mark the buffer as dirty
+                       if (flag.enabled()
+                           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)
+                           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly))
+                               view()->buffer()->markDirty();
+               }
+
+               if (view()->cursor().inTexted()) {
+                       view()->owner()->updateLayoutChoice();
+               }
        }
+       sendDispatchMessage(_(getMessage()), cmd);
 }
 
 
-void LyXFunc::sendDispatchMessage(string const & msg,
-                                 FuncRequest const & cmd, bool verbose)
+void LyXFunc::sendDispatchMessage(string const & msg, FuncRequest const & cmd)
 {
-       owner->updateMenubar();
-       owner->updateToolbar();
+       /* When an action did not originate from the UI/kbd, it makes
+        * sense to avoid updating the GUI. It turns out that this
+        * fixes bug 1941, for reasons that are described here:
+        * http://bugzilla.lyx.org/show_bug.cgi?id=1941#c4 
+        */
+       if (cmd.origin != FuncRequest::INTERNAL) {
+               owner->updateMenubar();
+               owner->updateToolbars();
+       }
+
+       const bool verbose = (cmd.origin == FuncRequest::UI
+                             || cmd.origin == FuncRequest::COMMANDBUFFER);
 
        if (cmd.action == LFUN_SELFINSERT || !verbose) {
                lyxerr[Debug::ACTION] << "dispatch msg is " << msg << endl;
@@ -1164,17 +1645,16 @@ void LyXFunc::sendDispatchMessage(string const & msg,
                }
        }
 
-       string const shortcuts = toplevel_keymap->findbinding(cmd);
+       string const shortcuts = toplevel_keymap->printbindings(cmd);
 
-       if (!shortcuts.empty()) {
+       if (!shortcuts.empty())
                comname += ": " + shortcuts;
-       } else if (!argsadded && !cmd.argument.empty()) {
+       else if (!argsadded && !cmd.argument.empty())
                comname += ' ' + cmd.argument;
-       }
 
        if (!comname.empty()) {
                comname = rtrim(comname);
-               dispatch_msg += '(' + comname + ')';
+               dispatch_msg += '(' + rtrim(comname) + ')';
        }
 
        lyxerr[Debug::ACTION] << "verbose dispatch msg " << dispatch_msg << endl;
@@ -1208,14 +1688,12 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
 
        if (filename.empty()) {
                filename = AddName(lyxrc.document_path,
-                           "newfile" + tostr(++newfile_number) + ".lyx");
-               FileInfo fi(filename);
-               while (bufferlist.exists(filename) || fi.readable()) {
+                           "newfile" + convert<string>(++newfile_number) + ".lyx");
+               while (bufferlist.exists(filename) || fs::is_readable(filename)) {
                        ++newfile_number;
                        filename = AddName(lyxrc.document_path,
-                                   "newfile" + tostr(newfile_number) +
+                                          "newfile" +  convert<string>(newfile_number) +
                                    ".lyx");
-                       fi.newFile(filename);
                }
        }
 
@@ -1264,7 +1742,7 @@ void LyXFunc::open(string const & fname)
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
                        make_pair(string(_("Examples|#E#e")),
-                                 string(AddPath(system_lyxdir(), "examples"))));
+                                 string(AddPath(package().system_support(), "examples"))));
 
                FileDialog::Result result =
                        fileDlg.open(initpath,
@@ -1294,8 +1772,7 @@ void LyXFunc::open(string const & fname)
        string const disp_fn(MakeDisplayPath(filename));
 
        // if the file doesn't exist, let the user create one
-       FileInfo const f(filename, true);
-       if (!f.exist()) {
+       if (!fs::exists(filename)) {
                // the user specifically chose this name. Believe them.
                view()->newFile(filename, "", true);
                return;
@@ -1340,7 +1817,7 @@ void LyXFunc::doImport(string const & argument)
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
                        make_pair(string(_("Examples|#E#e")),
-                                 string(AddPath(system_lyxdir(), "examples"))));
+                                 string(AddPath(package().system_support(), "examples"))));
 
                string const filter = formats.prettyName(format)
                        + " (*." + formats.extension(format) + ')';
@@ -1378,7 +1855,7 @@ void LyXFunc::doImport(string const & argument)
 
        // if the file exists already, and we didn't do
        // -i lyx thefile.lyx, warn
-       if (FileInfo(lyxfile, true).exist() && filename != lyxfile) {
+       if (fs::exists(lyxfile) && filename != lyxfile) {
                string const file = MakeDisplayPath(lyxfile, 30);
 
                string text = bformat(_("The document %1$s already exists.\n\n"
@@ -1430,12 +1907,6 @@ void LyXFunc::setMessage(string const & m) const
 }
 
 
-void LyXFunc::setStatusMessage(string const & m) const
-{
-       status_buffer = m;
-}
-
-
 string const LyXFunc::viewStatusMessage()
 {
        // When meta-fake key is pressed, show the key sequence so far + "M-".
@@ -1465,3 +1936,140 @@ bool LyXFunc::wasMetaKey() const
 {
        return (meta_fake_bit != key_modifier::none);
 }
+
+
+namespace {
+
+void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
+{
+       // Why the switch you might ask. It is a trick to ensure that all
+       // the elements in the LyXRCTags enum is handled. As you can see
+       // there are no breaks at all. So it is just a huge fall-through.
+       // The nice thing is that we will get a warning from the compiler
+       // if we forget an element.
+       LyXRC::LyXRCTags tag = LyXRC::RC_LAST;
+       switch (tag) {
+       case LyXRC::RC_ACCEPT_COMPOUND:
+       case LyXRC::RC_ALT_LANG:
+       case LyXRC::RC_ASCIIROFF_COMMAND:
+       case LyXRC::RC_ASCII_LINELEN:
+       case LyXRC::RC_AUTOREGIONDELETE:
+       case LyXRC::RC_AUTORESET_OPTIONS:
+       case LyXRC::RC_AUTOSAVE:
+       case LyXRC::RC_AUTO_NUMBER:
+       case LyXRC::RC_BACKUPDIR_PATH:
+       case LyXRC::RC_BIBTEX_COMMAND:
+       case LyXRC::RC_BINDFILE:
+       case LyXRC::RC_CHECKLASTFILES:
+       case LyXRC::RC_CHKTEX_COMMAND:
+       case LyXRC::RC_CONVERTER:
+       case LyXRC::RC_COPIER:
+       case LyXRC::RC_CURSOR_FOLLOWS_SCROLLBAR:
+       case LyXRC::RC_CUSTOM_EXPORT_COMMAND:
+       case LyXRC::RC_CUSTOM_EXPORT_FORMAT:
+       case LyXRC::RC_CYGWIN_PATH_FIX:
+               if (lyxrc_orig.cygwin_path_fix != lyxrc_new.cygwin_path_fix) {
+                       namespace os = lyx::support::os;
+                       os::cygwin_path_fix(lyxrc_new.cygwin_path_fix);
+               }
+       case LyXRC::RC_DATE_INSERT_FORMAT:
+       case LyXRC::RC_DEFAULT_LANGUAGE:
+       case LyXRC::RC_DEFAULT_PAPERSIZE:
+       case LyXRC::RC_DIALOGS_ICONIFY_WITH_MAIN:
+       case LyXRC::RC_DISPLAY_GRAPHICS:
+       case LyXRC::RC_DOCUMENTPATH:
+               if (lyxrc_orig.document_path != lyxrc_new.document_path) {
+                       if (fs::exists(lyxrc_new.document_path) &&
+                           fs::is_directory(lyxrc_new.document_path)) {
+                               using lyx::support::package;
+                               package().document_dir() = lyxrc.document_path;
+                       }
+               }
+       case LyXRC::RC_ESC_CHARS:
+       case LyXRC::RC_FONT_ENCODING:
+       case LyXRC::RC_FORMAT:
+       case LyXRC::RC_INDEX_COMMAND:
+       case LyXRC::RC_INPUT:
+       case LyXRC::RC_KBMAP:
+       case LyXRC::RC_KBMAP_PRIMARY:
+       case LyXRC::RC_KBMAP_SECONDARY:
+       case LyXRC::RC_LABEL_INIT_LENGTH:
+       case LyXRC::RC_LANGUAGE_AUTO_BEGIN:
+       case LyXRC::RC_LANGUAGE_AUTO_END:
+       case LyXRC::RC_LANGUAGE_COMMAND_BEGIN:
+       case LyXRC::RC_LANGUAGE_COMMAND_END:
+       case LyXRC::RC_LANGUAGE_COMMAND_LOCAL:
+       case LyXRC::RC_LANGUAGE_GLOBAL_OPTIONS:
+       case LyXRC::RC_LANGUAGE_PACKAGE:
+       case LyXRC::RC_LANGUAGE_USE_BABEL:
+       case LyXRC::RC_LASTFILES:
+       case LyXRC::RC_MAKE_BACKUP:
+       case LyXRC::RC_MARK_FOREIGN_LANGUAGE:
+       case LyXRC::RC_NUMLASTFILES:
+       case LyXRC::RC_PATH_PREFIX:
+               if (lyxrc_orig.path_prefix != lyxrc_new.path_prefix) {
+                       using lyx::support::prependEnvPath;
+                       prependEnvPath("PATH", lyxrc.path_prefix);
+               }
+       case LyXRC::RC_PERS_DICT:
+       case LyXRC::RC_POPUP_BOLD_FONT:
+       case LyXRC::RC_POPUP_FONT_ENCODING:
+       case LyXRC::RC_POPUP_NORMAL_FONT:
+       case LyXRC::RC_PREVIEW:
+       case LyXRC::RC_PREVIEW_HASHED_LABELS:
+       case LyXRC::RC_PREVIEW_SCALE_FACTOR:
+       case LyXRC::RC_PRINTCOLLCOPIESFLAG:
+       case LyXRC::RC_PRINTCOPIESFLAG:
+       case LyXRC::RC_PRINTER:
+       case LyXRC::RC_PRINTEVENPAGEFLAG:
+       case LyXRC::RC_PRINTEXSTRAOPTIONS:
+       case LyXRC::RC_PRINTFILEEXTENSION:
+       case LyXRC::RC_PRINTLANDSCAPEFLAG:
+       case LyXRC::RC_PRINTODDPAGEFLAG:
+       case LyXRC::RC_PRINTPAGERANGEFLAG:
+       case LyXRC::RC_PRINTPAPERDIMENSIONFLAG:
+       case LyXRC::RC_PRINTPAPERFLAG:
+       case LyXRC::RC_PRINTREVERSEFLAG:
+       case LyXRC::RC_PRINTSPOOL_COMMAND:
+       case LyXRC::RC_PRINTSPOOL_PRINTERPREFIX:
+       case LyXRC::RC_PRINTTOFILE:
+       case LyXRC::RC_PRINTTOPRINTER:
+       case LyXRC::RC_PRINT_ADAPTOUTPUT:
+       case LyXRC::RC_PRINT_COMMAND:
+       case LyXRC::RC_RTL_SUPPORT:
+       case LyXRC::RC_SCREEN_DPI:
+       case LyXRC::RC_SCREEN_FONT_ENCODING:
+       case LyXRC::RC_SCREEN_FONT_ROMAN:
+       case LyXRC::RC_SCREEN_FONT_ROMAN_FOUNDRY:
+       case LyXRC::RC_SCREEN_FONT_SANS:
+       case LyXRC::RC_SCREEN_FONT_SANS_FOUNDRY:
+       case LyXRC::RC_SCREEN_FONT_SCALABLE:
+       case LyXRC::RC_SCREEN_FONT_SIZES:
+       case LyXRC::RC_SCREEN_FONT_TYPEWRITER:
+       case LyXRC::RC_SCREEN_FONT_TYPEWRITER_FOUNDRY:
+       case LyXRC::RC_SCREEN_ZOOM:
+       case LyXRC::RC_SERVERPIPE:
+       case LyXRC::RC_SET_COLOR:
+       case LyXRC::RC_SHOW_BANNER:
+       case LyXRC::RC_SPELL_COMMAND:
+       case LyXRC::RC_TEMPDIRPATH:
+       case LyXRC::RC_TEMPLATEPATH:
+       case LyXRC::RC_TEX_ALLOWS_SPACES:
+       case LyXRC::RC_UIFILE:
+       case LyXRC::RC_USER_EMAIL:
+       case LyXRC::RC_USER_NAME:
+       case LyXRC::RC_USETEMPDIR:
+       case LyXRC::RC_USE_ALT_LANG:
+       case LyXRC::RC_USE_ESC_CHARS:
+       case LyXRC::RC_USE_INP_ENC:
+       case LyXRC::RC_USE_PERS_DICT:
+       case LyXRC::RC_USE_SPELL_LIB:
+       case LyXRC::RC_VIEWDVI_PAPEROPTION:
+       case LyXRC::RC_VIEWER:
+       case LyXRC::RC_WHEEL_JUMP:
+       case LyXRC::RC_LAST:
+               break;
+       }
+}
+
+} // namespace anon