]> git.lyx.org Git - lyx.git/blobdiff - src/lyxfunc.C
fix some C++ parsing bugs
[lyx.git] / src / lyxfunc.C
index 85eaa63d5c6eaa9288889b2631005040622202e2..34e54fc295dc63b376f16064f76878b8a90aad97 100644 (file)
 
 #include <config.h>
 
-#ifdef __GNUG__
-#pragma implementation
-#endif
-
 #include "lyxfunc.h"
 #include "version.h"
 #include "kbmap.h"
 #include "gettext.h"
 #include "Lsstream.h"
 #include "trans_mgr.h"
+#include "encoding.h"
 #include "layout.h"
 #include "bufferview_funcs.h"
 #include "frontends/LyXView.h"
 #include "frontends/lyx_gui.h"
 #include "vspace.h"
 #include "FloatList.h"
-#include "converter.h"
+#include "format.h"
 #include "exporter.h"
 #include "importer.h"
 #include "TextCache.h"
@@ -46,6 +43,8 @@
 #include "ParagraphParameters.h"
 
 #include "insets/insetcommand.h"
+#include "insets/inseterror.h"
+#include "insets/insetert.h"
 #include "insets/insettabular.h"
 
 #include "mathed/formulamacro.h"
@@ -69,6 +68,8 @@
 #include "support/path.h"
 #include "support/lyxfunctional.h"
 
+#include "BoostFormat.h"
+
 #include <ctime>
 #include <clocale>
 #include <cstdlib>
@@ -99,6 +100,7 @@ extern void ShowLatexLog();
 
 LyXFunc::LyXFunc(LyXView * o)
        : owner(o),
+       encoded_last_key(0),
        keyseq(toplevel_keymap.get(), toplevel_keymap.get()),
        cancel_meta_seq(toplevel_keymap.get(), toplevel_keymap.get()),
        meta_fake_bit(key_modifier::none)
@@ -119,11 +121,11 @@ inline
 void LyXFunc::moveCursorUpdate(bool flag, bool selecting)
 {
        if (selecting || TEXT(flag)->selection.mark()) {
-               TEXT(flag)->setSelection(view());
-               if (TEXT(flag)->bv_owner)
+               TEXT(flag)->setSelection();
+               if (!TEXT(flag)->isInInset())
                    view()->toggleToggle();
        }
-       view()->update(TEXT(flag), BufferView::SELECT|BufferView::FITCUR);
+       view()->update(TEXT(flag), BufferView::SELECT);
        view()->showCursor();
 
        view()->switchKeyMap();
@@ -132,9 +134,9 @@ void LyXFunc::moveCursorUpdate(bool flag, bool selecting)
 
 void LyXFunc::handleKeyFunc(kb_action action)
 {
-       char c = keyseq.getLastKeyEncoded();
+       char c = encoded_last_key;
 
-       if (keyseq.length() > 1) {
+       if (keyseq.length()) {
                c = 0;
        }
 
@@ -144,8 +146,7 @@ void LyXFunc::handleKeyFunc(kb_action action)
        // actions
        keyseq.clear();
        // copied verbatim from do_accent_char
-       view()->update(TEXT(false),
-              BufferView::SELECT|BufferView::FITCUR|BufferView::CHANGE);
+       view()->update(TEXT(false), BufferView::SELECT);
        TEXT(false)->selection.cursor = TEXT(false)->cursor;
 }
 
@@ -160,7 +161,7 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym,
                       << keysym->getSymbolName()
                       << endl;
        }
+
        // Do nothing if we have nothing (JMarc)
        if (!keysym->isOK()) {
                lyxerr[Debug::KEY] << "Empty kbd action (probably composing)"
@@ -169,15 +170,20 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym,
        }
 
        if (keysym->isModifier()) {
+               lyxerr[Debug::KEY] << "isModifier true" << endl;
                return;
        }
 
+       Encoding const * encoding = view()->getEncoding();
+
+       encoded_last_key = keysym->getISOEncoded(encoding ? encoding->Name() : "");
+
        // Do a one-deep top-level lookup for
        // cancel and meta-fake keys. RVDK_PATCH_5
        cancel_meta_seq.reset();
 
        int action = cancel_meta_seq.addkey(keysym, state);
-       lyxerr[Debug::KEY] << "action first set to [" << action << "]" << endl;
+       lyxerr[Debug::KEY] << "action first set to [" << action << ']' << endl;
 
        // When not cancel or meta-fake, do the normal lookup.
        // Note how the meta_fake Mod1 bit is OR-ed in and reset afterwards.
@@ -186,7 +192,7 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym,
                // remove Caps Lock and Mod2 as a modifiers
                action = keyseq.addkey(keysym, (state | meta_fake_bit));
                lyxerr[Debug::KEY] << "action now set to ["
-                       << action << "]" << endl;
+                       << action << ']' << endl;
        }
 
        // Dont remove this unless you know what you are doing.
@@ -200,7 +206,7 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym,
        if (lyxerr.debugging(Debug::KEY)) {
                lyxerr << "Key [action="
                       << action << "]["
-                      << keyseq.print() << "]"
+                      << keyseq.print() << ']'
                       << endl;
        }
 
@@ -212,31 +218,39 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym,
                owner->message(keyseq.print());
        }
 
-       if (action == LFUN_UNKNOWN_ACTION) {
-               // It is unknown, but what if we remove all
-               // the modifiers? (Lgb)
-               action = keyseq.addkey(keysym, key_modifier::none);
 
-               lyxerr[Debug::KEY] << "Removing modifiers...\n"
-                       << "Action now set to ["
-                       << action << "]" << endl;
+       // Maybe user can only reach the key via holding down shift.
+       // Let's see. But only if shift is the only modifier
+       if (action == LFUN_UNKNOWN_ACTION && state == key_modifier::shift) {
+               lyxerr[Debug::KEY] << "Trying without shift" << endl;
+               action = keyseq.addkey(keysym, key_modifier::none);
+               lyxerr[Debug::KEY] << "Action now " << action << endl;
+       }
 
-               if (action == LFUN_UNKNOWN_ACTION) {
+       if (action == LFUN_UNKNOWN_ACTION) {
+               // Hmm, we didn't match any of the keysequences. See
+               // if it's normal insertable text not already covered
+               // by a binding
+               if (keysym->isText() && keyseq.length() == 1) {
+                       lyxerr[Debug::KEY] << "isText() is true, inserting." << endl;
+                       action = LFUN_SELFINSERT;
+               } else {
+                       lyxerr[Debug::KEY] << "Unknown, !isText() - giving up" << endl;
                        owner->message(_("Unknown function."));
                        return;
                }
        }
 
        if (action == LFUN_SELFINSERT) {
-               char c = keysym->getISOEncoded();
-               string argument;
+               if (encoded_last_key != 0) {
+                       string arg;
+                       arg += encoded_last_key;
 
-               if (c != 0)
-                       argument = c;
+                       dispatch(FuncRequest(view(), LFUN_SELFINSERT, arg));
 
-               dispatch(FuncRequest(view(), LFUN_SELFINSERT, argument));
-               lyxerr[Debug::KEY] << "SelfInsert arg[`"
+                       lyxerr[Debug::KEY] << "SelfInsert arg[`"
                                   << argument << "']" << endl;
+               }
        } else {
                dispatch(action);
        }
@@ -259,9 +273,20 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                return flag.disabled(true);
        }
 
-       if (ev.action == LFUN_UNKNOWN_ACTION) {
+       switch (ev.action) {
+       case LFUN_UNKNOWN_ACTION:
+#ifndef HAVE_LIBAIKSAURUS
+       case LFUN_THESAURUS_ENTRY:
+#endif
+               flag.unknown(true);
+               break;
+       default:
+               flag |= lyx_gui::getStatus(ev);
+       }
+
+       if (flag.unknown()) {
                setStatusMessage(N_("Unknown action"));
-               return flag.unknown(true);
+               return flag;
        }
 
        // the default error message if we disable the command
@@ -299,8 +324,8 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                        || lyxrc.print_command == "none";
                break;
        case LFUN_EXPORT:
-               disable = ev.argument == "fax" &&
-                       !Exporter::IsExportable(buf, ev.argument);
+               disable = ev.argument != "custom"
+                       && !Exporter::IsExportable(buf, ev.argument);
                break;
        case LFUN_UNDO:
                disable = buf->undostack.empty();
@@ -310,20 +335,18 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                break;
        case LFUN_CUT:
        case LFUN_COPY:
-               if (tli && tli->lyxCode() == Inset::TABULAR_CODE) {
-                       InsetTabular * t(static_cast<InsetTabular*>(tli));
-                       if (t->hasSelection()) {
+               if (tli) {
+                       UpdatableInset * in = tli;
+                       if (in->lyxCode() != Inset::TABULAR_CODE) {
+                               in = tli->getFirstLockingInsetOfType(Inset::TABULAR_CODE);
+                       }
+                       if (in && static_cast<InsetTabular*>(in)->hasSelection()) {
                                disable = false;
                                break;
                        }
                }
                disable = !mathcursor && !view()->getLyXText()->selection.set();
                break;
-#ifndef HAVE_LIBAIKSAURUS
-       case LFUN_THESAURUS_ENTRY:
-               disable = true;
-               break;
-#endif
        case LFUN_RUNCHKTEX:
                disable = lyxrc.chktex_command == "none";
                break;
@@ -432,10 +455,20 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        case LFUN_VC_HISTORY:
                disable = !buf->lyxvc.inUse();
                break;
+       case LFUN_MENURELOAD:
+               disable = buf->isUnnamed() || buf->isClean();
+               break;
        case LFUN_BOOKMARK_GOTO:
                disable =  !view()->
                        isSavedPosition(strToUnsignedInt(ev.argument));
                break;
+       case LFUN_MERGE_CHANGES:
+       case LFUN_ACCEPT_CHANGE:
+       case LFUN_REJECT_CHANGE:
+       case LFUN_ACCEPT_ALL_CHANGES:
+       case LFUN_REJECT_ALL_CHANGES:
+               disable = !buf->params.tracking_changes;
+               break;
        case LFUN_INSET_TOGGLE: {
                LyXText * lt = view()->getLyXText();
                disable = !(isEditableInset(lt->getInset())
@@ -473,21 +506,48 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        // the functions which insert insets
        Inset::Code code = Inset::NO_CODE;
        switch (ev.action) {
+       case LFUN_DIALOG_SHOW_NEW_INSET:
+               if (ev.argument == "bibitem")
+                       code = Inset::BIBITEM_CODE;
+               else if (ev.argument == "bibtex")
+                       code = Inset::BIBTEX_CODE;
+               else if (ev.argument == "citation")
+                       code = Inset::CITE_CODE;
+               else if (ev.argument == "ert")
+                       code = Inset::ERT_CODE;
+               else if (ev.argument == "external")
+                       code = Inset::EXTERNAL_CODE;
+               else if (ev.argument == "float")
+                       code = Inset::FLOAT_CODE;
+               else if (ev.argument == "graphics")
+                       code = Inset::GRAPHICS_CODE;
+               else if (ev.argument == "include")
+                       code = Inset::INCLUDE_CODE;
+               else if (ev.argument == "index")
+                       code = Inset::INDEX_CODE;
+               else if (ev.argument == "label")
+                       code = Inset::LABEL_CODE;
+               else if (ev.argument == "minipage")
+                       code = Inset::MINIPAGE_CODE;
+               else if (ev.argument == "ref")
+                       code = Inset::REF_CODE;
+               else if (ev.argument == "toc")
+                       code = Inset::TOC_CODE;
+               else if (ev.argument == "url")
+                       code = Inset::URL_CODE;
+               else if (ev.argument == "wrap")
+                       code = Inset::WRAP_CODE;
+               break;
+
        case LFUN_INSET_ERT:
                code = Inset::ERT_CODE;
                break;
-       case LFUN_INSET_GRAPHICS:
-               code = Inset::GRAPHICS_CODE;
-               break;
        case LFUN_INSET_FOOTNOTE:
                code = Inset::FOOT_CODE;
                break;
        case LFUN_TABULAR_INSERT:
                code = Inset::TABULAR_CODE;
                break;
-       case LFUN_INSET_EXTERNAL:
-               code = Inset::EXTERNAL_CODE;
-               break;
        case LFUN_INSET_MARGINAL:
                code = Inset::MARGIN_CODE;
                break;
@@ -524,15 +584,8 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        case LFUN_INSET_OPTARG:
                code = Inset::OPTARG_CODE;
                break;
-       case LFUN_REF_INSERT:
-               code = Inset::REF_CODE;
-               break;
-       case LFUN_CITATION_CREATE:
-       case LFUN_CITATION_INSERT:
-               code = Inset::CITE_CODE;
-               break;
-       case LFUN_INSERT_BIBTEX:
-               code = Inset::BIBTEX_CODE;
+       case LFUN_ENVIRONMENT_INSERT:
+               code = Inset::MINIPAGE_CODE;
                break;
        case LFUN_INDEX_INSERT:
                code = Inset::INDEX_CODE;
@@ -540,9 +593,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
        case LFUN_INDEX_PRINT:
                code = Inset::INDEX_PRINT_CODE;
                break;
-       case LFUN_CHILD_INSERT:
-               code = Inset::INCLUDE_CODE;
-               break;
        case LFUN_TOC_INSERT:
                code = Inset::TOC_CODE;
                break;
@@ -551,7 +601,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                break;
        case LFUN_HTMLURL:
        case LFUN_URL:
-       case LFUN_INSERT_URL:
                code = Inset::URL_CODE;
                break;
        case LFUN_QUOTE:
@@ -598,6 +647,9 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & ev) const
                if (ev.argument == buf->fileName())
                        flag.setOnOff(true);
                break;
+       case LFUN_TRACK_CHANGES:
+               flag.setOnOff(buf->params.tracking_changes);
+               break;
        default:
                break;
        }
@@ -672,9 +724,15 @@ void LyXFunc::dispatch(string const & s, bool verbose)
        int const action = lyxaction.LookupFunc(s);
 
        if (action == LFUN_UNKNOWN_ACTION) {
+#if USE_BOOST_FORMAT
+boost::format fmt(_("Unknown function (%1$s)"));
+fmt % s;
+owner->message(fmt.str());
+#else
                string const msg = string(_("Unknown function ("))
-                       + s + ")";
+                       + s + ')';
                owner->message(msg);
+#endif
                return;
        }
 
@@ -692,7 +750,7 @@ void LyXFunc::dispatch(int ac, bool verbose)
 void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 {
        lyxerr[Debug::ACTION] << "LyXFunc::dispatch: action[" << ev.action
-                             <<"] arg[" << ev.argument << "]" << endl;
+                             <<"] arg[" << ev.argument << ']' << endl;
 
        // we have not done anything wrong yet.
        errorstat = false;
@@ -736,7 +794,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 #endif
                        if ((action == LFUN_UNKNOWN_ACTION)
                            && argument.empty()) {
-                               argument = keyseq.getLastKeyEncoded();
+                               argument = encoded_last_key;
                        }
                        // Undo/Redo is a bit tricky for insets.
                        if (action == LFUN_UNDO) {
@@ -748,25 +806,25 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                        } else if (((result=inset->
                                     // Hand-over to inset's own dispatch:
                                     localDispatch(FuncRequest(view(), action, argument))) ==
-                                   UpdatableInset::DISPATCHED) ||
-                                  (result == UpdatableInset::DISPATCHED_NOUPDATE))
+                                   DISPATCHED) ||
+                                  (result == DISPATCHED_NOUPDATE))
                                goto exit_with_message;
                                        // If UNDISPATCHED, just soldier on
-                       else if (result == UpdatableInset::FINISHED) {
+                       else if (result == FINISHED) {
                                goto exit_with_message;
                                // We do not need special RTL handling here:
                                // FINISHED means that the cursor should be
                                // one position after the inset.
-                       } else if (result == UpdatableInset::FINISHED_RIGHT) {
+                       } else if (result == FINISHED_RIGHT) {
                                TEXT()->cursorRight(view());
                                moveCursorUpdate(true, false);
                                owner->view_state_changed();
                                goto exit_with_message;
-                       } else if (result == UpdatableInset::FINISHED_UP) {
+                       } else if (result == FINISHED_UP) {
                                if (TEXT()->cursor.irow()->previous()) {
 #if 1
                                        TEXT()->setCursorFromCoordinates(
-                                               view(), TEXT()->cursor.ix() + inset_x,
+                                               TEXT()->cursor.ix() + inset_x,
                                                TEXT()->cursor.iy() -
                                                TEXT()->cursor.irow()->baseline() - 1);
                                        TEXT()->cursor.x_fix(TEXT()->cursor.x());
@@ -776,14 +834,14 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                                        moveCursorUpdate(true, false);
                                        owner->view_state_changed();
                                } else {
-                                       view()->update(TEXT(), BufferView::SELECT|BufferView::FITCUR);
+                                       view()->update(TEXT(), BufferView::SELECT);
                                }
                                goto exit_with_message;
-                       } else if (result == UpdatableInset::FINISHED_DOWN) {
+                       } else if (result == FINISHED_DOWN) {
                                if (TEXT()->cursor.irow()->next()) {
 #if 1
                                        TEXT()->setCursorFromCoordinates(
-                                               view(), TEXT()->cursor.ix() + inset_x,
+                                               TEXT()->cursor.ix() + inset_x,
                                                TEXT()->cursor.iy() -
                                                TEXT()->cursor.irow()->baseline() +
                                                TEXT()->cursor.irow()->height() + 1);
@@ -861,7 +919,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                        }
                        finishUndo();
                        // Tell the paragraph dialog that we changed paragraph
-                       owner->getDialogs().updateParagraph();
+                       dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
                }
        }
        break;
@@ -878,7 +936,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                } else {
                        searched_string = last_search;
                }
-               bool fw = (action == LFUN_WORDFINDBACKWARD);
+               bool fw = (action == LFUN_WORDFINDFORWARD);
                if (!searched_string.empty()) {
                        lyxfind::LyXFind(view(), searched_string, fw);
                }
@@ -889,8 +947,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        case LFUN_PREFIX:
        {
                if (view()->available() && !view()->theLockingInset()) {
-                       view()->update(TEXT(),
-                                             BufferView::SELECT|BufferView::FITCUR);
+                       view()->update(TEXT(), BufferView::SELECT);
                }
                owner->message(keyseq.printOptions());
        }
@@ -946,12 +1003,18 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        case LFUN_MENUWRITE:
                if (!owner->buffer()->isUnnamed()) {
                        ostringstream s1;
-                       s1 << _("Saving document") << ' '
-                          << MakeDisplayPath(owner->buffer()->fileName() + "...");
-                       owner->message(s1.str().c_str());
+#if USE_BOOST_FORMAT
+                       s1 << boost::format(_("Saving document %1$s..."))
+                          % MakeDisplayPath(owner->buffer()->fileName());
+#else
+                       s1 << _("Saving document ")
+                          << MakeDisplayPath(owner->buffer()->fileName())
+                          << _("...");
+#endif
+                       owner->message(STRCONV(s1.str()));
                        MenuWrite(view(), owner->buffer());
                        s1 << _(" done.");
-                       owner->message(s1.str().c_str());
+                       owner->message(STRCONV(s1.str()));
                } else
                        WriteAs(view(), owner->buffer());
                break;
@@ -961,7 +1024,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                break;
 
        case LFUN_MENURELOAD:
-               reloadBuffer();
+               view()->reload();
                break;
 
        case LFUN_UPDATE:
@@ -1000,27 +1063,10 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                break;
 
        case LFUN_TOCVIEW:
-#if 0
-       case LFUN_LOFVIEW:
-       case LFUN_LOTVIEW:
-       case LFUN_LOAVIEW:
-#endif
        {
-               InsetCommandParams p;
-
-#if 0
-               if (action == LFUN_TOCVIEW)
-#endif
-                       p.setCmdName("tableofcontents");
-#if 0
-               else if (action == LFUN_LOAVIEW)
-                       p.setCmdName("listof{algorithm}{List of Algorithms}");
-               else if (action == LFUN_LOFVIEW)
-                       p.setCmdName("listoffigures");
-               else
-                       p.setCmdName("listoftables");
-#endif
-               owner->getDialogs().createTOC(p.getAsString());
+               InsetCommandParams p("tableofcontents");
+               string const data = InsetCommandMailer::params2string("toc", p);
+               owner->getDialogs().show("toc", data, 0);
                break;
        }
 
@@ -1056,8 +1102,12 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                changeDepth(view(), TEXT(false), 1);
                break;
 
-       case LFUN_FREE:
-               owner->getDialogs().setUserFreeFont();
+       case LFUN_FREEFONT_APPLY:
+               apply_freefont(view());
+               break;
+
+       case LFUN_FREEFONT_UPDATE:
+               update_and_apply_freefont(view(), argument);
                break;
 
        case LFUN_RECONFIGURE:
@@ -1081,7 +1131,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 #endif
 #endif
        case LFUN_HELP_ABOUTLYX:
-               owner->getDialogs().showAboutlyx();
+               owner->getDialogs().show("about");
                break;
 
        case LFUN_HELP_TEXINFO:
@@ -1095,20 +1145,22 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                        setErrorMessage(N_("Missing argument"));
                        break;
                }
-               owner->prohibitInput();
                string const fname = i18nLibFileSearch("doc", arg, "lyx");
                if (fname.empty()) {
                        lyxerr << "LyX: unable to find documentation file `"
                               << arg << "'. Bad installation?" << endl;
-                       owner->allowInput();
                        break;
                }
                ostringstream str;
-               str << _("Opening help file") << ' '
-                   << MakeDisplayPath(fname) << "...";
-               owner->message(str.str().c_str());
+#if USE_BOOST_FORMAT
+               str << boost::format(_("Opening help file %1$s..."))
+                   % MakeDisplayPath(fname);
+#else
+               str << _("Opening help file ")
+                   << MakeDisplayPath(fname) << _("...");
+#endif
+               owner->message(STRCONV(str.str()));
                view()->buffer(bufferlist.loadLyXFile(fname, false));
-               owner->allowInput();
                break;
        }
 
@@ -1150,7 +1202,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
 
        case LFUN_VC_HISTORY:
        {
-               owner->getDialogs().showVCLogFile();
+               owner->getDialogs().show("vclog");
                break;
        }
 
@@ -1174,20 +1226,19 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                break;
 
        case LFUN_LATEX_LOG:
-               owner->getDialogs().showLogFile();
+               owner->getDialogs().show("log");
                break;
 
        case LFUN_LAYOUT_DOCUMENT:
                owner->getDialogs().showDocument();
                break;
 
-       case LFUN_LAYOUT_PARAGRAPH:
-               owner->getDialogs().showParagraph();
-               break;
-
-       case LFUN_LAYOUT_CHARACTER:
-               owner->getDialogs().showCharacter();
+       case LFUN_LAYOUT_CHARACTER: {
+               string data = freefont2string();
+               if (!data.empty())
+                       owner->getDialogs().show("character", data);
                break;
+       }
 
        case LFUN_LAYOUT_TABULAR:
            if (view()->theLockingInset()) {
@@ -1270,7 +1321,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                Paragraph * par = owner->buffer()->getParFromID(id);
                if (par == 0) {
                        lyxerr[Debug::INFO] << "No matching paragraph found! ["
-                                           << id << "]" << endl;
+                                           << id << ']' << endl;
                        break;
                } else {
                        lyxerr[Debug::INFO] << "Paragraph " << par->id()
@@ -1283,7 +1334,7 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                        par->inInset()->edit(view());
                }
                // Set the cursor
-               view()->getLyXText()->setCursor(view(), par, 0);
+               view()->getLyXText()->setCursor(par, 0);
                view()->switchKeyMap();
                owner->view_state_changed();
 
@@ -1325,27 +1376,52 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                owner->getDialogs().showMathPanel();
                break;
 
-       case LFUN_CITATION_CREATE:
-       {
-               InsetCommandParams p("cite");
+       case LFUN_DIALOG_SHOW_NEW_INSET: {
+               string const & name = argument;
+               string data;
+               if (name == "bibitem" ||
+                   name == "bibtex" ||
+                   name == "include" ||
+                   name == "index" ||
+                   name == "ref" ||
+                   name == "toc" ||
+                   name == "url") {
+                       InsetCommandParams p(name);
+                       data = InsetCommandMailer::params2string(name, p);
+               } else if (name == "citation") {
+                       InsetCommandParams p("cite");
+                       data = InsetCommandMailer::params2string(name, p);
+               }
+               owner->getDialogs().show(name, data, 0);
+       }
+       break;
 
-               if (!argument.empty()) {
-                       // This should be set at source, ie when typing
-                       // "citation-insert foo" in the minibuffer.
-                       // Question: would pybibliographer also need to be
-                       // changed. Suspect so. Leave as-is therefore.
-                       if (contains(argument, "|")) {
-                               p.setContents(token(argument, '|', 0));
-                               p.setOptions(token(argument, '|', 1));
-                       } else {
-                               p.setContents(argument);
-                       }
-                       dispatch(FuncRequest(view(), LFUN_CITATION_INSERT, p.getAsString()));
-               } else
-                       owner->getDialogs().createCitation(p.getAsString());
+       case LFUN_DIALOG_SHOW_NEXT_INSET: {
        }
        break;
 
+       case LFUN_DIALOG_UPDATE: {
+               string const & name = argument;
+               // Can only update a dialog connected to an existing inset
+               InsetBase * inset = owner->getDialogs().getOpenInset(name);
+               if (inset) {
+                       FuncRequest fr(view(), LFUN_INSET_DIALOG_UPDATE,
+                                      ev.argument);
+                       inset->localDispatch(fr);
+               } else if (name == "paragraph") {
+                       dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
+               }
+       }
+       break;
+
+       case LFUN_DIALOG_HIDE:
+               Dialogs::hide(argument, 0);
+               break;
+
+       case LFUN_DIALOG_DISCONNECT_INSET:
+               owner->getDialogs().disconnect(argument);
+               break;
+
        case LFUN_CHILDOPEN:
        {
                string const filename =
@@ -1435,11 +1511,20 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
                         x11_name != lcolor.getX11Name(LColor::graphicsbg));
 
                if (!lcolor.setColor(lyx_name, x11_name)) {
-                       static string const err1 (N_("Set-color \""));
-                       static string const err2 (
-                               N_("\" failed - color is undefined "
-                                  "or may not be redefined"));
-                       setErrorMessage(_(err1) + lyx_name + _(err2));
+#if USE_BOOST_FORMAT
+                       setErrorMessage(
+                               boost::io::str(
+                                       boost::format(
+                                               _("Set-color \"%1$s\" failed "
+                                                 "- color is undefined or "
+                                                 "may not be redefined"))
+                                       % lyx_name));
+#else
+                       setErrorMessage(_("Set-color ") + lyx_name
+                                       + _(" failed - color is undefined"
+                                           " or may not be redefined"));
+#endif
+
                        break;
                }
 
@@ -1493,6 +1578,18 @@ void LyXFunc::dispatch(FuncRequest const & ev, bool verbose)
        } // end of switch
 
 exit_with_message:
+
+       view()->owner()->updateLayoutChoice();
+
+       if (view()->available()) {
+               view()->fitCursor();
+
+               // If we executed a mutating lfun, mark the buffer as dirty
+               if (!lyxaction.funcHasFlag(ev.action, LyXAction::NoBuffer)
+                   && !lyxaction.funcHasFlag(ev.action, LyXAction::ReadOnly))
+                       view()->buffer()->markDirty();
+       }
+
        sendDispatchMessage(getMessage(), ev, verbose);
 }
 
@@ -1511,7 +1608,7 @@ void LyXFunc::sendDispatchMessage(string const & msg, FuncRequest const & ev, bo
 
        string dispatch_msg = msg;
        if (!dispatch_msg.empty())
-               dispatch_msg += " ";
+               dispatch_msg += ' ';
 
        string comname = lyxaction.getActionName(ev.action);
 
@@ -1525,7 +1622,7 @@ void LyXFunc::sendDispatchMessage(string const & msg, FuncRequest const & ev, bo
                if (pseudoaction == LFUN_UNKNOWN_ACTION) {
                        pseudoaction = ev.action;
                } else {
-                       comname += " " + ev.argument;
+                       comname += ' ' + ev.argument;
                        argsadded = true;
                }
        }
@@ -1535,12 +1632,12 @@ void LyXFunc::sendDispatchMessage(string const & msg, FuncRequest const & ev, bo
        if (!shortcuts.empty()) {
                comname += ": " + shortcuts;
        } else if (!argsadded && !ev.argument.empty()) {
-               comname += " " + ev.argument;
+               comname += ' ' + ev.argument;
        }
 
        if (!comname.empty()) {
                comname = rtrim(comname);
-               dispatch_msg += "(" + comname + ')';
+               dispatch_msg += '(' + comname + ')';
        }
 
        lyxerr[Debug::ACTION] << "verbose dispatch msg " << dispatch_msg << endl;
@@ -1586,7 +1683,7 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
        // The template stuff
        string templname;
        if (fromTemplate) {
-               FileDialog fileDlg(owner, _("Select template file"),
+               FileDialog fileDlg(_("Select template file"),
                        LFUN_SELECT_FILE_SYNC,
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
@@ -1594,8 +1691,8 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
                                  string(lyxrc.template_path)));
 
                FileDialog::Result result =
-                       fileDlg.Select(lyxrc.template_path,
-                                      _("*.lyx|LyX Documents (*.lyx)"));
+                       fileDlg.open(lyxrc.template_path,
+                                      _("*.lyx| LyX Documents (*.lyx)"));
 
                if (result.first == FileDialog::Later)
                        return;
@@ -1625,7 +1722,7 @@ void LyXFunc::open(string const & fname)
        string filename;
 
        if (fname.empty()) {
-               FileDialog fileDlg(owner, _("Select document to open"),
+               FileDialog fileDlg(_("Select document to open"),
                        LFUN_FILE_OPEN,
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
@@ -1633,8 +1730,8 @@ void LyXFunc::open(string const & fname)
                                  string(AddPath(system_lyxdir, "examples"))));
 
                FileDialog::Result result =
-                       fileDlg.Select(initpath,
-                                      "*.lyx|LyX Documents (*.lyx)");
+                       fileDlg.open(initpath,
+                                      _("*.lyx| LyX Documents (*.lyx)"));
 
                if (result.first == FileDialog::Later)
                        return;
@@ -1663,7 +1760,7 @@ void LyXFunc::open(string const & fname)
        if (!f.exist()) {
                if (!Alert::askQuestion(_("No such file"), disp_fn,
                        _("Start a new document with this filename ?"))) {
-                       owner->message(_("Canceled"));
+                       owner->message(_("Canceled."));
                        return;
                }
                // the user specifically chose this name. Believe them.
@@ -1673,21 +1770,32 @@ void LyXFunc::open(string const & fname)
        }
 
        ostringstream str;
-       str << _("Opening document") << ' ' << disp_fn << "...";
+#if USE_BOOST_FORMAT
+       str << boost::format(_("Opening document %1$s...")) % disp_fn;
+#else
+       str << _("Opening document ") << disp_fn << _("...");
+#endif
 
-       owner->message(str.str().c_str());
+       owner->message(STRCONV(str.str()));
 
        Buffer * openbuf = bufferlist.loadLyXFile(filename);
+       ostringstream str2;
        if (openbuf) {
                view()->buffer(openbuf);
-               ostringstream str;
-               str << _("Document") << ' ' << disp_fn << ' ' << _("opened.");
-               owner->message(str.str().c_str());
+#if USE_BOOST_FORMAT
+               str2 << boost::format(_("Document %1$s opened.")) % disp_fn;
+#else
+               str2 << _("Document ") << disp_fn << _(" opened.");
+#endif
        } else {
-               ostringstream str;
-               str << _("Could not open document") << ' ' << disp_fn;
-               owner->message(str.str().c_str());
+#if USE_BOOST_FORMAT
+               str2 << boost::format(_("Could not open document %1$s"))
+                       % disp_fn;
+#else
+               str2 << _("Could not open document ") << disp_fn;
+#endif
        }
+       owner->message(STRCONV(str2.str()));
 }
 
 
@@ -1710,10 +1818,16 @@ void LyXFunc::doImport(string const & argument)
                                initpath = trypath;
                }
 
+#if USE_BOOST_FORMAT
+               boost::format fmt(_("Select %1$s file to import"));
+               fmt % formats.prettyName(format);
+               string const text = fmt.str();
+#else
                string const text = _("Select ") + formats.prettyName(format)
-                       + _(" file to import");
+                       + _(" file to import");;
+#endif
 
-               FileDialog fileDlg(owner, text,
+               FileDialog fileDlg(text,
                        LFUN_IMPORT,
                        make_pair(string(_("Documents|#o#O")),
                                  string(lyxrc.document_path)),
@@ -1722,9 +1836,9 @@ void LyXFunc::doImport(string const & argument)
 
                string const extension = "*." + formats.extension(format)
                        + "| " + formats.prettyName(format)
-                       + " (*." + formats.extension(format) + ")";
+                       + " (*." + formats.extension(format) + ')';
 
-               FileDialog::Result result = fileDlg.Select(initpath,
+               FileDialog::Result result = fileDlg.open(initpath,
                                                           extension);
 
                if (result.first == FileDialog::Later)
@@ -1771,7 +1885,7 @@ void LyXFunc::doImport(string const & argument)
        if (FileInfo(lyxfile, true).exist() && filename != lyxfile) {
                if (!Alert::askQuestion(_("A document by the name"),
                        MakeDisplayPath(lyxfile), _("already exists. Overwrite?"))) {
-                       owner->message(_("Canceled"));
+                       owner->message(_("Canceled."));
                        return;
                }
        }
@@ -1780,14 +1894,6 @@ void LyXFunc::doImport(string const & argument)
 }
 
 
-void LyXFunc::reloadBuffer()
-{
-       string const fn = owner->buffer()->fileName();
-       if (bufferlist.close(owner->buffer()))
-               view()->buffer(bufferlist.loadLyXFile(fn));
-}
-
-
 void LyXFunc::closeBuffer()
 {
        if (bufferlist.close(owner->buffer()) && !quitting) {