]> git.lyx.org Git - lyx.git/blobdiff - src/lyxfunc.C
remove redundant lyxerr.debugging checks; macro LYXERR already checks whether the...
[lyx.git] / src / lyxfunc.C
index 5a5e955dd9e375e5fda1b31d8cfccf0aee3611be..33d3ef2cb45d228a258ea510c5424be469629b0b 100644 (file)
@@ -27,6 +27,7 @@
 #include "bufferlist.h"
 #include "bufferparams.h"
 #include "BufferView.h"
+#include "bufferview_funcs.h"
 #include "cursor.h"
 #include "CutAndPaste.h"
 #include "debug.h"
@@ -143,10 +144,6 @@ namespace Alert = frontend::Alert;
 namespace fs = boost::filesystem;
 
 
-// (alkis)
-extern tex_accent_struct get_accent(kb_action action);
-
-
 namespace {
 
 bool getLocalStatus(LCursor cursor,
@@ -231,7 +228,7 @@ void LyXFunc::handleKeyFunc(kb_action action)
                c = 0;
 
        lyx_view_->view()->getIntl().getTransManager().deadkey(
-               c, get_accent(action).accent, view()->getLyXText(), view()->cursor());
+               c, get_accent(action).accent, view()->cursor().innerText(), view()->cursor());
        // Need to clear, in case the minibuffer calls these
        // actions
        keyseq->clear();
@@ -241,32 +238,70 @@ void LyXFunc::handleKeyFunc(kb_action action)
 }
 
 
+void LyXFunc::gotoBookmark(unsigned int idx, bool openFile, bool switchToBuffer)
+{
+       BOOST_ASSERT(lyx_view_);
+       if (!LyX::ref().session().bookmarks().isValid(idx))
+               return;
+       BookmarksSection::Bookmark const & bm = LyX::ref().session().bookmarks().bookmark(idx);
+       BOOST_ASSERT(!bm.filename.empty());
+       string const file = bm.filename.absFilename();
+       // if the file is not opened, open it.
+       if (!theBufferList().exists(file)) {
+               if (openFile)
+                       dispatch(FuncRequest(LFUN_FILE_OPEN, file));
+               else
+                       return;
+       }
+       // open may fail, so we need to test it again
+       if (theBufferList().exists(file)) {
+               // if the current buffer is not that one, switch to it.
+               if (lyx_view_->buffer()->fileName() != file) {
+                       if (switchToBuffer)
+                               dispatch(FuncRequest(LFUN_BUFFER_SWITCH, file));
+                       else
+                               return;
+               }
+               // moveToPosition use par_id, and par_pit and return new par_id.
+               pit_type new_pit;
+               int new_id;
+               boost::tie(new_pit, new_id) = view()->moveToPosition(bm.par_pit, bm.par_id, bm.par_pos);
+               // if par_id or pit has been changed, reset par_pit and par_id
+               // see http://bugzilla.lyx.org/show_bug.cgi?id=3092
+               if (bm.par_pit != new_pit || bm.par_id != new_id)
+                       const_cast<BookmarksSection::Bookmark &>(bm).setPos(new_pit, new_id);
+       } 
+}
+
+
 void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
 {
-       lyxerr[Debug::KEY] << "KeySym is " << keysym->getSymbolName() << endl;
+       LYXERR(Debug::KEY) << "KeySym is " << keysym->getSymbolName() << endl;
 
        // Do nothing if we have nothing (JMarc)
        if (!keysym->isOK()) {
-               lyxerr[Debug::KEY] << "Empty kbd action (probably composing)"
+               LYXERR(Debug::KEY) << "Empty kbd action (probably composing)"
                                   << endl;
                return;
        }
 
        if (keysym->isModifier()) {
-               lyxerr[Debug::KEY] << "isModifier true" << endl;
+               LYXERR(Debug::KEY) << "isModifier true" << endl;
                return;
        }
 
        //Encoding const * encoding = view()->cursor().getEncoding();
        //encoded_last_key = keysym->getISOEncoded(encoding ? encoding->name() : "");
-       size_t encoded_last_key = keysym->getUCSEncoded();
+       // FIXME: encoded_last_key shadows the member variable of the same
+       // name. Is that intended?
+       char_type encoded_last_key = keysym->getUCSEncoded();
 
        // Do a one-deep top-level lookup for
        // cancel and meta-fake keys. RVDK_PATCH_5
        cancel_meta_seq->reset();
 
        FuncRequest func = cancel_meta_seq->addkey(keysym, state);
-       lyxerr[Debug::KEY] << BOOST_CURRENT_FUNCTION
+       LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
                           << " action first set to [" << func.action << ']'
                           << endl;
 
@@ -276,7 +311,7 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
        if ((func.action != LFUN_CANCEL) && (func.action != LFUN_META_PREFIX)) {
                // remove Caps Lock and Mod2 as a modifiers
                func = keyseq->addkey(keysym, (state | meta_fake_bit));
-               lyxerr[Debug::KEY] << BOOST_CURRENT_FUNCTION
+               LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
                                   << "action now set to ["
                                   << func.action << ']' << endl;
        }
@@ -289,20 +324,18 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
                func = FuncRequest(LFUN_COMMAND_PREFIX);
        }
 
-       if (lyxerr.debugging(Debug::KEY)) {
-               lyxerr << BOOST_CURRENT_FUNCTION
-                      << " Key [action="
-                      << func.action << "]["
-                      << keyseq->print() << ']'
-                      << endl;
-       }
+       LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
+              << " Key [action="
+              << func.action << "]["
+              << to_utf8(keyseq->print(false)) << ']'
+              << endl;
 
        // already here we know if it any point in going further
        // why not return already here if action == -1 and
        // num_bytes == 0? (Lgb)
 
        if (keyseq->length() > 1) {
-               lyx_view_->message(from_utf8(keyseq->print()));
+               lyx_view_->message(keyseq->print(true));
        }
 
 
@@ -310,9 +343,9 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
        // Let's see. But only if shift is the only modifier
        if (func.action == LFUN_UNKNOWN_ACTION &&
            state == key_modifier::shift) {
-               lyxerr[Debug::KEY] << "Trying without shift" << endl;
+               LYXERR(Debug::KEY) << "Trying without shift" << endl;
                func = keyseq->addkey(keysym, key_modifier::none);
-               lyxerr[Debug::KEY] << "Action now " << func.action << endl;
+               LYXERR(Debug::KEY) << "Action now " << func.action << endl;
        }
 
        if (func.action == LFUN_UNKNOWN_ACTION) {
@@ -320,11 +353,11 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
                // if it's normal insertable text not already covered
                // by a binding
                if (keysym->isText() && keyseq->length() == 1) {
-                       lyxerr[Debug::KEY] << "isText() is true, inserting." << endl;
+                       LYXERR(Debug::KEY) << "isText() is true, inserting." << endl;
                        func = FuncRequest(LFUN_SELF_INSERT,
                                           FuncRequest::KEYBOARD);
                } else {
-                       lyxerr[Debug::KEY] << "Unknown, !isText() - giving up" << endl;
+                       LYXERR(Debug::KEY) << "Unknown, !isText() - giving up" << endl;
                        lyx_view_->message(_("Unknown function."));
                        return;
                }
@@ -335,7 +368,7 @@ void LyXFunc::processKeySym(LyXKeySymPtr keysym, key_modifier::state state)
                        docstring const arg(1, encoded_last_key);
                        dispatch(FuncRequest(LFUN_SELF_INSERT, arg,
                                             FuncRequest::KEYBOARD));
-                       lyxerr[Debug::KEY]
+                       LYXERR(Debug::KEY)
                                << "SelfInsert arg[`" << to_utf8(arg) << "']" << endl;
                }
        } else {
@@ -349,24 +382,6 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        //lyxerr << "LyXFunc::getStatus: cmd: " << cmd << endl;
        FuncStatus flag;
 
-       if (cmd.action == LFUN_LYX_QUIT) {
-               flag.message(from_utf8(N_("Exiting")));
-               flag.enabled(true);
-               return flag;
-       } else if (cmd.action == LFUN_BOOKMARK_GOTO) {
-               // bookmarks can be valid even if there is no opened buffer
-               flag.enabled(LyX::ref().session().bookmarks().isValid(convert<unsigned int>(to_utf8(cmd.argument()))));
-               return flag;
-       } else if (cmd.action == LFUN_BOOKMARK_CLEAR) {
-               flag.enabled(LyX::ref().session().bookmarks().size() > 0);
-               return flag;
-       } else if (cmd.action == LFUN_TOOLBAR_TOGGLE_STATE) {
-               ToolbarBackend::Flags flags = lyx_view_->getToolbarState(to_utf8(cmd.argument()));
-               if (!(flags & ToolbarBackend::AUTO))
-                       flag.setOnOff(flags & ToolbarBackend::ON);
-               return flag;
-       }
-
        LCursor & cur = view()->cursor();
 
        /* In LyX/Mac, when a dialog is open, the menus of the
@@ -515,9 +530,10 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                if (inset) {
                        FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument());
                        FuncStatus fs;
-                       bool const success = inset->getStatus(cur, fr, fs);
-                       // Every inset is supposed to handle this
-                       BOOST_ASSERT(success);
+                       if (!inset->getStatus(cur, fr, fs)) {
+                               // Every inset is supposed to handle this
+                               BOOST_ASSERT(false);
+                       }
                        flag |= fs;
                } else {
                        FuncRequest fr(LFUN_INSET_INSERT, cmd.argument());
@@ -555,6 +571,11 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
 
        case LFUN_DIALOG_SHOW_NEW_INSET:
                enable = cur.inset().lyxCode() != InsetBase::ERT_CODE;
+               if (cur.inset().lyxCode() == InsetBase::CAPTION_CODE) {
+                       FuncStatus flag;
+                       if (cur.inset().getStatus(cur, cmd, flag))
+                               return flag;
+               }
                break;
 
        case LFUN_DIALOG_UPDATE: {
@@ -576,6 +597,22 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                break;
        }
 
+       case LFUN_BOOKMARK_GOTO: {
+               const unsigned int num = convert<unsigned int>(to_utf8(cmd.argument()));
+               enable = LyX::ref().session().bookmarks().isValid(num);
+               break;
+       }
+
+       case LFUN_BOOKMARK_CLEAR:
+               enable = LyX::ref().session().bookmarks().size() > 0;
+               break;
+
+       case LFUN_TOOLBAR_TOGGLE_STATE: {
+               ToolbarBackend::Flags flags = lyx_view_->getToolbarState(to_utf8(cmd.argument()));
+               if (!(flags & ToolbarBackend::AUTO))
+                       flag.setOnOff(flags & ToolbarBackend::ON);
+               break;
+       }
 
        // this one is difficult to get right. As a half-baked
        // solution, we consider only the first action of the sequence
@@ -639,6 +676,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        case LFUN_BUFFER_PREVIOUS:
        case LFUN_WINDOW_NEW:
        case LFUN_WINDOW_CLOSE:
+       case LFUN_LYX_QUIT:
                // these are handled in our dispatch()
                break;
 
@@ -739,7 +777,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
        string const argument = to_utf8(cmd.argument());
        kb_action const action = cmd.action;
 
-       lyxerr[Debug::ACTION] << endl << "LyXFunc::dispatch: cmd: " << cmd << endl;
+       LYXERR(Debug::ACTION) << endl << "LyXFunc::dispatch: cmd: " << cmd << endl;
        //lyxerr << "LyXFunc::dispatch: cmd: " << cmd << endl;
 
        // we have not done anything wrong yet.
@@ -753,7 +791,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
        FuncStatus const flag = getStatus(cmd);
        if (!flag.enabled()) {
                // We cannot use this function here
-               lyxerr[Debug::ACTION] << "LyXFunc::dispatch: "
+               LYXERR(Debug::ACTION) << "LyXFunc::dispatch: "
                       << lyxaction.getActionName(action)
                       << " [" << action << "] is disabled at this location"
                       << endl;
@@ -764,12 +802,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_WORD_FIND_FORWARD:
                case LFUN_WORD_FIND_BACKWARD: {
                        BOOST_ASSERT(lyx_view_ && lyx_view_->view());
-                       static string last_search;
-                       string searched_string;
+                       static docstring last_search;
+                       docstring searched_string;
 
-                       if (!argument.empty()) {
-                               last_search = argument;
-                               searched_string = argument;
+                       if (!cmd.argument().empty()) {
+                               last_search = cmd.argument();
+                               searched_string = cmd.argument();
                        } else {
                                searched_string = last_search;
                        }
@@ -778,7 +816,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                break;
 
                        bool const fw = action == LFUN_WORD_FIND_FORWARD;
-                       string const data =
+                       docstring const data =
                                find2string(searched_string, true, false, fw);
                        find(view(), FuncRequest(LFUN_WORD_FIND, data));
                        break;
@@ -786,7 +824,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                case LFUN_COMMAND_PREFIX:
                        BOOST_ASSERT(lyx_view_);
-                       lyx_view_->message(from_utf8(keyseq->printOptions()));
+                       lyx_view_->message(keyseq->printOptions(true));
                        break;
 
                case LFUN_COMMAND_EXECUTE:
@@ -802,12 +840,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        if (view()->buffer())
                                // cancel any selection
                                dispatch(FuncRequest(LFUN_MARK_OFF));
-                       setMessage(_("Cancel"));
+                       setMessage(from_ascii(N_("Cancel")));
                        break;
 
                case LFUN_META_PREFIX:
                        meta_fake_bit = key_modifier::alt;
-                       setMessage(from_utf8(keyseq->print()));
+                       setMessage(keyseq->print(true));
                        break;
 
                case LFUN_BUFFER_TOGGLE_READ_ONLY:
@@ -841,8 +879,9 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                lyx_view_->message(str);
                                menuWrite(lyx_view_->buffer());
                                lyx_view_->message(str + _(" done."));
-                       } else
-                               writeAs(lyx_view_->buffer());
+                       } else {
+                               writeAs(lyx_view_->buffer());
+                       }
                        updateFlags = Update::None;
                        break;
 
@@ -861,7 +900,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                text, 0, 1, _("&Revert"), _("&Cancel"));
 
                        if (ret == 0)
-                               view()->reload();
+                               reloadBuffer();
                        break;
                }
 
@@ -1015,9 +1054,18 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                        } else {
                                // case 1: print to a file
+                               FileName const filename(makeAbsPath(target_name, path));
+                               if (fs::exists(filename.toFilesystemEncoding())) {
+                                       docstring text = bformat(
+                                               _("The file %1$s already exists.\n\n"
+                                                 "Do you want to over-write that file?"),
+                                               makeDisplayPath(filename.absFilename()));
+                                       if (Alert::prompt(_("Over-write file?"),
+                                           text, 0, 1, _("&Over-write"), _("&Cancel")) != 0)
+                                               break;
+                               }
                                command += lyxrc.print_to_file
-                                       + quoteName(makeAbsPath(target_name,
-                                                               path))
+                                       + quoteName(filename.toFilesystemEncoding())
                                        + ' '
                                        + quoteName(dviname);
                                res = one.startscript(Systemcall::DontWait,
@@ -1034,19 +1082,11 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_LYX_QUIT:
-                       // FIXME: this code needs to be transfered somewhere else
-                       // as lyx_view_ will most certainly be null and a same buffer
-                       // might be visible in more than one LyXView.
-                       if (lyx_view_ && lyx_view_->view()->buffer()) {
-                               // save cursor Position for opened files to .lyx/session
-                               LyX::ref().session().lastFilePos().save(FileName(lyx_view_->buffer()->fileName()),
-                                       boost::tie(view()->cursor().pit(), view()->cursor().pos()) );
-                       }
-                       
-                       // save the geometry of the current view 
-                       lyx_view_->saveGeometry();
-                       // quitting is trigged by the gui code (leaving the event loop)
-                       theApp()->gui().closeAllViews();
+                       // quitting is triggered by the gui code
+                       // (leaving the event loop).
+                       lyx_view_->message(from_utf8(N_("Exiting.")));
+                       if (theBufferList().quitWriteAll())
+                               theApp()->gui().closeAllViews();
                        break;
 
                case LFUN_TOC_VIEW: {
@@ -1070,7 +1110,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        BOOST_ASSERT(lyx_view_);
                        string const arg = argument;
                        if (arg.empty()) {
-                               setErrorMessage(_("Missing argument"));
+                               setErrorMessage(from_ascii(N_("Missing argument")));
                                break;
                        }
                        FileName const fname = i18nLibFileSearch("doc", arg, "lyx");
@@ -1092,8 +1132,9 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                break;
                        if (!lyx_view_->buffer()->lyxvc().inUse()) {
                                lyx_view_->buffer()->lyxvc().registrer();
-                               view()->reload();
+                               reloadBuffer();
                        }
+                       updateFlags = Update::Force;
                        break;
 
                case LFUN_VC_CHECK_IN:
@@ -1103,7 +1144,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        if (lyx_view_->buffer()->lyxvc().inUse()
                                        && !lyx_view_->buffer()->isReadonly()) {
                                lyx_view_->buffer()->lyxvc().checkIn();
-                               view()->reload();
+                               reloadBuffer();
                        }
                        break;
 
@@ -1114,20 +1155,20 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        if (lyx_view_->buffer()->lyxvc().inUse()
                                        && lyx_view_->buffer()->isReadonly()) {
                                lyx_view_->buffer()->lyxvc().checkOut();
-                               view()->reload();
+                               reloadBuffer();
                        }
                        break;
 
                case LFUN_VC_REVERT:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        lyx_view_->buffer()->lyxvc().revert();
-                       view()->reload();
+                       reloadBuffer();
                        break;
 
                case LFUN_VC_UNDO_LAST:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        lyx_view_->buffer()->lyxvc().undoLast();
-                       view()->reload();
+                       reloadBuffer();
                        break;
 
                // --- buffers ----------------------------------------
@@ -1170,13 +1211,13 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_SERVER_GET_NAME:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        setMessage(from_utf8(lyx_view_->buffer()->fileName()));
-                       lyxerr[Debug::INFO] << "FNAME["
+                       LYXERR(Debug::INFO) << "FNAME["
                                                         << lyx_view_->buffer()->fileName()
                                                         << "] " << endl;
                        break;
 
                case LFUN_SERVER_NOTIFY:
-                       dispatch_buffer = from_utf8(keyseq->print());
+                       dispatch_buffer = keyseq->print(false);
                        theLyXServer().notifyClient(to_utf8(dispatch_buffer));
                        break;
 
@@ -1204,8 +1245,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                        view()->setCursorFromRow(row);
 
-                       view()->center();
-                       // see BufferView::center()
+                       updateFlags = Update::FitCursor;
                        break;
                }
 
@@ -1255,6 +1295,11 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                InsetCommandParams p(name);
                                data = InsetCommandMailer::params2string(name, p);
                        } else if (name == "include") {
+                               // data is the include type: one of "include",
+                               // "input", "verbatiminput" or "verbatiminput*"
+                               if (data.empty())
+                                       // default type is requested
+                                       data = "include";
                                InsetCommandParams p(data);
                                data = InsetIncludeMailer::params2string(p);
                        } else if (name == "box") {
@@ -1346,17 +1391,16 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                case LFUN_BUFFER_CHILD_OPEN: {
                        BOOST_ASSERT(lyx_view_);
-                       string const filename =
+                       FileName const filename =
                                makeAbsPath(argument, lyx_view_->buffer()->filePath());
-                       // FIXME Should use bformat
-                       setMessage(_("Opening child document ") +
-                                        makeDisplayPath(filename) + "...");
+                       setMessage(bformat(_("Opening child document %1$s..."),
+                                          makeDisplayPath(filename.absFilename())));
                        view()->saveBookmark(false);
                        string const parentfilename = lyx_view_->buffer()->fileName();
-                       if (theBufferList().exists(filename))
-                               lyx_view_->setBuffer(theBufferList().getBuffer(filename));
+                       if (theBufferList().exists(filename.absFilename()))
+                               lyx_view_->setBuffer(theBufferList().getBuffer(filename.absFilename()));
                        else
-                               lyx_view_->loadLyXFile(FileName(filename));
+                               lyx_view_->loadLyXFile(filename);
                        // Set the parent name of the child document.
                        // This makes insertion of citations and references in the child work,
                        // when the target is in the parent or another child document.
@@ -1416,8 +1460,8 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                }
 
                case LFUN_PREFERENCES_SAVE: {
-                       lyxrc.write(FileName(makeAbsPath("preferences",
-                                                        package().user_support())),
+                       lyxrc.write(makeAbsPath("preferences",
+                                               package().user_support()),
                                    false);
                        break;
                }
@@ -1425,18 +1469,19 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_SCREEN_FONT_UPDATE:
                        BOOST_ASSERT(lyx_view_);
                        // handle the screen font changes.
-                       lyxrc.set_font_norm_type();
                        theFontLoader().update();
-                       // All visible buffers will need resize
-                       view()->resize();
+                       /// FIXME: only the current view will be updated. the Gui
+                       /// class is able to furnish the list of views.
+                       updateFlags = Update::Force;
                        break;
 
                case LFUN_SET_COLOR: {
                        string lyx_name;
                        string const x11_name = split(argument, lyx_name, ' ');
                        if (lyx_name.empty() || x11_name.empty()) {
-                               setErrorMessage(_("Syntax: set-color <lyx_name>"
-                                                       " <x11_name>"));
+                               setErrorMessage(from_ascii(N_(
+                                               "Syntax: set-color <lyx_name>"
+                                               " <x11_name>")));
                                break;
                        }
 
@@ -1561,18 +1606,17 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        }
 
                        if (defaults.writeFile(FileName(defaults.fileName())))
-                               // FIXME Should use bformat
-                               setMessage(_("Document defaults saved in ")
-                                          + makeDisplayPath(fname));
+                               setMessage(bformat(_("Document defaults saved in %1$s"),
+                                                  makeDisplayPath(fname)));
                        else
-                               setErrorMessage(_("Unable to save document defaults"));
+                               setErrorMessage(from_ascii(N_("Unable to save document defaults")));
                        break;
                }
 
                case LFUN_BUFFER_PARAMS_APPLY: {
                        BOOST_ASSERT(lyx_view_);
                        biblio::CiteEngine const engine =
-                               lyx_view_->buffer()->params().cite_engine;
+                               lyx_view_->buffer()->params().getEngine();
 
                        istringstream ss(argument);
                        LyXLex lex(0,0);
@@ -1586,7 +1630,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                       << (unknown_tokens == 1 ? "" : "s")
                                       << endl;
                        }
-                       if (engine == lyx_view_->buffer()->params().cite_engine)
+                       if (engine == lyx_view_->buffer()->params().getEngine())
                                break;
 
                        LCursor & cur = view()->cursor();
@@ -1656,6 +1700,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        }
 
                        actOnUpdatedPrefs(lyxrc_orig, lyxrc);
+
+                       /// We force the redraw in any case because there might be
+                       /// some screen font changes.
+                       /// FIXME: only the current view will be updated. the Gui
+                       /// class is able to furnish the list of views.
+                       updateFlags = Update::Force;
                        break;
                }
 
@@ -1666,29 +1716,19 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_WINDOW_CLOSE:
                        BOOST_ASSERT(lyx_view_);
                        BOOST_ASSERT(theApp());
+                       // update bookmark pit of the current buffer before window close
+                       for (size_t i = 0; i < LyX::ref().session().bookmarks().size(); ++i)
+                               gotoBookmark(i+1, false, false);
+                       // ask the user for saving changes or cancel quit
+                       if (!theBufferList().quitWriteAll())
+                               break;
                        lyx_view_->close();
-                       lyx_view_->closed(lyx_view_->id());
                        return;
 
-               case LFUN_BOOKMARK_GOTO: {
-                       BOOST_ASSERT(lyx_view_);
-                       unsigned int idx = convert<unsigned int>(to_utf8(cmd.argument()));
-                       BookmarksSection::Bookmark const bm = LyX::ref().session().bookmarks().bookmark(idx);
-                       BOOST_ASSERT(!bm.filename.empty());
-                       string const file = bm.filename.absFilename();
-                       // if the file is not opened, open it.
-                       if (!theBufferList().exists(file))
-                               dispatch(FuncRequest(LFUN_FILE_OPEN, file));
-                       // open may fail, so we need to test it again
-                       if (theBufferList().exists(file)) {
-                               // if the current buffer is not that one, switch to it.
-                               if (lyx_view_->buffer()->fileName() != file)
-                                       dispatch(FuncRequest(LFUN_BUFFER_SWITCH, file));
-                               // BOOST_ASSERT(lyx_view_->buffer()->fileName() != file);
-                               view()->moveToPosition(bm.par_id, bm.par_pos);
-                       } 
+               case LFUN_BOOKMARK_GOTO:
+                       // go to bookmark, open unopened file and switch to buffer if necessary
+                       gotoBookmark(convert<unsigned int>(to_utf8(cmd.argument())), true, true);
                        break;
-               }
 
                case LFUN_BOOKMARK_CLEAR:
                        LyX::ref().session().bookmarks().clear();
@@ -1703,8 +1743,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        view()->cursor().dispatch(cmd);
                        updateFlags = view()->cursor().result().update();
                        if (!view()->cursor().result().dispatched())
-                               if (view()->dispatch(cmd)) 
-                                       updateFlags = Update::Force | Update::FitCursor;
+                               updateFlags = view()->dispatch(cmd);
                        break;
                }
                }
@@ -1713,22 +1752,20 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        // BufferView::update() updates the ViewMetricsInfo and
                        // also initializes the position cache for all insets in
                        // (at least partially) visible top-level paragraphs.
-                       std::pair<bool, bool> needSecondUpdate 
-                               = view()->update(updateFlags);
-
-                       // Redraw screen unless explicitly told otherwise.
-                       if (needSecondUpdate.first)
+                       // We will redraw the screen only if needed.
+                       if (view()->update(updateFlags)) {
                                // Buffer::changed() signals that a repaint is needed.
                                // The frontend (WorkArea) knows which area to repaint
                                // thanks to the ViewMetricsInfo updated above.
                                view()->buffer()->changed();
+                       }
 
                        lyx_view_->updateStatusBar();
 
                        // if we executed a mutating lfun, mark the buffer as dirty
                        if (flag.enabled()
-                           && !lyxaction.funcHasFlag(cmd.action, LyXAction::NoBuffer)
-                           && !lyxaction.funcHasFlag(cmd.action, LyXAction::ReadOnly))
+                           && !lyxaction.funcHasFlag(action, LyXAction::NoBuffer)
+                           && !lyxaction.funcHasFlag(action, LyXAction::ReadOnly))
                                view()->buffer()->markDirty();
 
                        if (view()->cursor().inTexted()) {
@@ -1739,7 +1776,8 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
        if (!quitting) {
                lyx_view_->updateMenubar();
                lyx_view_->updateToolbars();
-               sendDispatchMessage(getMessage(), cmd);
+               // Some messages may already be translated, so we cannot use _()
+               sendDispatchMessage(translateIfPossible(getMessage()), cmd);
        }
 }
 
@@ -1751,7 +1789,7 @@ void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd
                              || cmd.origin == FuncRequest::COMMANDBUFFER);
 
        if (cmd.action == LFUN_SELF_INSERT || !verbose) {
-               lyxerr[Debug::ACTION] << "dispatch msg is " << to_utf8(msg) << endl;
+               LYXERR(Debug::ACTION) << "dispatch msg is " << to_utf8(msg) << endl;
                if (!msg.empty())
                        lyx_view_->message(msg);
                return;
@@ -1761,30 +1799,30 @@ void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd
        if (!dispatch_msg.empty())
                dispatch_msg += ' ';
 
-       string comname = lyxaction.getActionName(cmd.action);
+       docstring comname = from_utf8(lyxaction.getActionName(cmd.action));
 
        bool argsadded = false;
 
        if (!cmd.argument().empty()) {
                if (cmd.action != LFUN_UNKNOWN_ACTION) {
-                       comname += ' ' + to_utf8(cmd.argument());
+                       comname += ' ' + cmd.argument();
                        argsadded = true;
                }
        }
 
-       string const shortcuts = theTopLevelKeymap().printbindings(cmd);
+       docstring const shortcuts = theTopLevelKeymap().printbindings(cmd);
 
        if (!shortcuts.empty())
                comname += ": " + shortcuts;
        else if (!argsadded && !cmd.argument().empty())
-               comname += ' ' + to_utf8(cmd.argument());
+               comname += ' ' + cmd.argument();
 
        if (!comname.empty()) {
                comname = rtrim(comname);
-               dispatch_msg += from_utf8('(' + rtrim(comname) + ')');
+               dispatch_msg += '(' + rtrim(comname) + ')';
        }
 
-       lyxerr[Debug::ACTION] << "verbose dispatch msg "
+       LYXERR(Debug::ACTION) << "verbose dispatch msg "
                << to_utf8(dispatch_msg) << endl;
        if (!dispatch_msg.empty())
                lyx_view_->message(dispatch_msg);
@@ -1800,7 +1838,7 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
        if (view()->buffer()) {
                string const trypath = lyx_view_->buffer()->filePath();
                // If directory is writeable, use this as default.
-               if (isDirWriteable(trypath))
+               if (isDirWriteable(FileName(trypath)))
                        initpath = trypath;
        }
 
@@ -1809,7 +1847,8 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
        if (filename.empty()) {
                filename = addName(lyxrc.document_path,
                            "newfile" + convert<string>(++newfile_number) + ".lyx");
-               while (theBufferList().exists(filename) || fs::is_readable(filename)) {
+               while (theBufferList().exists(filename) ||
+                      fs::is_readable(FileName(filename).toFilesystemEncoding())) {
                        ++newfile_number;
                        filename = addName(lyxrc.document_path,
                                           "newfile" +  convert<string>(newfile_number) +
@@ -1838,8 +1877,10 @@ void LyXFunc::menuNew(string const & name, bool fromTemplate)
        }
 
        Buffer * const b = newFile(filename, templname, !name.empty());
-       if (b)
+       if (b) {
+               updateLabels(*b);
                lyx_view_->setBuffer(b);
+       }
 }
 
 
@@ -1850,7 +1891,7 @@ void LyXFunc::open(string const & fname)
        if (view()->buffer()) {
                string const trypath = lyx_view_->buffer()->filePath();
                // If directory is writeable, use this as default.
-               if (isDirWriteable(trypath))
+               if (isDirWriteable(FileName(trypath)))
                        initpath = trypath;
        }
 
@@ -1913,7 +1954,7 @@ void LyXFunc::doImport(string const & argument)
        string format;
        string filename = split(argument, format, ' ');
 
-       lyxerr[Debug::INFO] << "LyXFunc::doImport: " << format
+       LYXERR(Debug::INFO) << "LyXFunc::doImport: " << format
                            << " file: " << filename << endl;
 
        // need user interaction
@@ -1923,7 +1964,7 @@ void LyXFunc::doImport(string const & argument)
                if (view()->buffer()) {
                        string const trypath = lyx_view_->buffer()->filePath();
                        // If directory is writeable, use this as default.
-                       if (isDirWriteable(trypath))
+                       if (isDirWriteable(FileName(trypath)))
                                initpath = trypath;
                }
 
@@ -2000,6 +2041,9 @@ void LyXFunc::closeBuffer()
        // save current cursor position
        LyX::ref().session().lastFilePos().save(FileName(lyx_view_->buffer()->fileName()),
                boost::tie(view()->cursor().pit(), view()->cursor().pos()) );
+       // goto bookmark to update bookmark pit.
+       for (size_t i = 0; i < LyX::ref().session().bookmarks().size(); ++i)
+               gotoBookmark(i+1, false, false);
        if (theBufferList().close(lyx_view_->buffer(), true) && !quitting) {
                if (theBufferList().empty()) {
                        // need this otherwise SEGV may occur while
@@ -2013,6 +2057,13 @@ void LyXFunc::closeBuffer()
 }
 
 
+void LyXFunc::reloadBuffer()
+{
+       FileName filename(lyx_view_->buffer()->fileName());
+       closeBuffer();
+       lyx_view_->loadLyXFile(filename);
+}
+
 // Each "lyx_view_" should have it's own message method. lyxview and
 // the minibuffer would use the minibuffer, but lyxserver would
 // send an ERROR signal to its client.  Alejandro 970603
@@ -2032,19 +2083,19 @@ void LyXFunc::setMessage(docstring const & m) const
 }
 
 
-string const LyXFunc::viewStatusMessage()
+docstring const LyXFunc::viewStatusMessage()
 {
        // When meta-fake key is pressed, show the key sequence so far + "M-".
        if (wasMetaKey())
-               return keyseq->print() + "M-";
+               return keyseq->print(true) + "M-";
 
        // Else, when a non-complete key sequence is pressed,
        // show the available options.
        if (keyseq->length() > 0 && !keyseq->deleted())
-               return keyseq->printOptions();
+               return keyseq->printOptions(true);
 
        if (!view()->buffer())
-               return to_utf8(_("Welcome to LyX!"));
+               return _("Welcome to LyX!");
 
        return view()->cursor().currentState();
 }
@@ -2076,8 +2127,8 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        switch (tag) {
        case LyXRC::RC_ACCEPT_COMPOUND:
        case LyXRC::RC_ALT_LANG:
-       case LyXRC::RC_ASCIIROFF_COMMAND:
-       case LyXRC::RC_ASCII_LINELEN:
+       case LyXRC::RC_PLAINTEXT_ROFF_COMMAND:
+       case LyXRC::RC_PLAINTEXT_LINELEN:
        case LyXRC::RC_AUTOREGIONDELETE:
        case LyXRC::RC_AUTORESET_OPTIONS:
        case LyXRC::RC_AUTOSAVE:
@@ -2102,10 +2153,10 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_DISPLAY_GRAPHICS:
        case LyXRC::RC_DOCUMENTPATH:
                if (lyxrc_orig.document_path != lyxrc_new.document_path) {
-                       if (fs::exists(lyxrc_new.document_path) &&
-                           fs::is_directory(lyxrc_new.document_path)) {
+                       string const encoded = FileName(
+                               lyxrc_new.document_path).toFilesystemEncoding();
+                       if (fs::exists(encoded) && fs::is_directory(encoded))
                                support::package().document_dir() = lyxrc.document_path;
-                       }
                }
        case LyXRC::RC_ESC_CHARS:
        case LyXRC::RC_FONT_ENCODING:
@@ -2132,9 +2183,6 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
                        support::prependEnvPath("PATH", lyxrc.path_prefix);
                }
        case LyXRC::RC_PERS_DICT:
-       case LyXRC::RC_POPUP_BOLD_FONT:
-       case LyXRC::RC_POPUP_FONT_ENCODING:
-       case LyXRC::RC_POPUP_NORMAL_FONT:
        case LyXRC::RC_PREVIEW:
        case LyXRC::RC_PREVIEW_HASHED_LABELS:
        case LyXRC::RC_PREVIEW_SCALE_FACTOR:
@@ -2158,7 +2206,6 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_PRINT_COMMAND:
        case LyXRC::RC_RTL_SUPPORT:
        case LyXRC::RC_SCREEN_DPI:
-       case LyXRC::RC_SCREEN_FONT_ENCODING:
        case LyXRC::RC_SCREEN_FONT_ROMAN:
        case LyXRC::RC_SCREEN_FONT_ROMAN_FOUNDRY:
        case LyXRC::RC_SCREEN_FONT_SANS: