]> git.lyx.org Git - lyx.git/blobdiff - src/insets/insettabular.C
the update/updateInset merge
[lyx.git] / src / insets / insettabular.C
index 7872bd04ea4e084cdcd7f769f38801e888243c38..d293e1d61108071f9ef53a4ce40d09301db950fb 100644 (file)
 #include "buffer.h"
 #include "bufferparams.h"
 #include "BufferView.h"
+#include "cursor.h"
 #include "debug.h"
+#include "dispatchresult.h"
 #include "funcrequest.h"
 #include "FuncStatus.h"
 #include "gettext.h"
 #include "language.h"
+#include "LColor.h"
 #include "lyx_cb.h"
 #include "lyxlex.h"
 #include "metricsinfo.h"
+#include "outputparams.h"
 #include "paragraph.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
-#include "undo_funcs.h"
-#include "WordLangTuple.h"
+#include "undo.h"
 
 #include "frontends/Alert.h"
 #include "frontends/font_metrics.h"
 #include "frontends/Painter.h"
 
 #include "support/std_sstream.h"
+#include <iostream>
 
 using lyx::graphics::PreviewLoader;
 
 using lyx::support::ltrim;
 using lyx::support::strToInt;
+using lyx::support::strToDbl;
 
 using std::endl;
 using std::max;
 using std::swap;
-
+using std::string;
 using std::auto_ptr;
 using std::istringstream;
 using std::ostream;
@@ -57,7 +62,7 @@ int const ADD_TO_HEIGHT = 2;
 int const ADD_TO_TABULAR_WIDTH = 2;
 
 ///
-LyXTabular * paste_tabular = 0;
+boost::scoped_ptr<LyXTabular> paste_tabular;
 
 
 struct TabularFeature {
@@ -140,42 +145,33 @@ string const featureAsString(LyXTabular::Feature feature)
 
 bool InsetTabular::hasPasteBuffer() const
 {
-       return (paste_tabular != 0);
+       return (paste_tabular.get() != 0);
 }
 
 
 InsetTabular::InsetTabular(Buffer const & buf, int rows, int columns)
-       : tabular(buf.params(), this, max(rows, 1), max(columns, 1)),
+       : tabular(buf.params(), max(rows, 1), max(columns, 1)),
          buffer_(&buf), cursorx_(0), cursory_(0)
 {
-       // for now make it always display as display() inset
-       // just for test!!!
+       tabular.setOwner(this);
        the_locking_inset = 0;
-       old_locking_inset = 0;
-       locked = false;
-       oldcell = -1;
-       actrow = actcell = 0;
+       actrow = 0;
+       actcell = 0;
        clearSelection();
        in_reset_pos = 0;
-       inset_x = 0;
-       inset_y = 0;
 }
 
 
 InsetTabular::InsetTabular(InsetTabular const & tab)
-       : UpdatableInset(tab),
-               tabular(tab.buffer_->params(), this, tab.tabular),
+       : UpdatableInset(tab), tabular(tab.tabular),
                buffer_(tab.buffer_), cursorx_(0), cursory_(0)
 {
+       tabular.setOwner(this);
        the_locking_inset = 0;
-       old_locking_inset = 0;
-       locked = false;
-       oldcell = -1;
-       actrow = actcell = 0;
+       actrow = 0;
+       actcell = 0;
        clearSelection();
        in_reset_pos = 0;
-       inset_x = 0;
-       inset_y = 0;
 }
 
 
@@ -197,13 +193,6 @@ Buffer const & InsetTabular::buffer() const
 }
 
 
-BufferView * InsetTabular::view() const
-{
-       BOOST_ASSERT(false);
-       return 0;
-}
-
-
 void InsetTabular::buffer(Buffer * b)
 {
        buffer_ = b;
@@ -263,12 +252,8 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
 
        BufferView * bv = pi.base.bv;
 
-#if 0
-       UpdatableInset::draw(pi, x, y);
-#else
        if (!owner())
                x += scroll();
-#endif
 
        top_x = x;
        top_baseline = y;
@@ -327,7 +312,7 @@ void InsetTabular::drawCellLines(Painter & pain, int x, int y,
                                 int row, int cell) const
 {
        int x2 = x + tabular.getWidthOfColumn(cell);
-       bool on_off;
+       bool on_off = false;
 
        if (!tabular.topAlreadyDrawn(cell)) {
                on_off = !tabular.topLine(cell);
@@ -391,136 +376,24 @@ string const InsetTabular::editMessage() const
 }
 
 
-void InsetTabular::insetUnlock(BufferView * bv)
-{
-       if (the_locking_inset) {
-               the_locking_inset->insetUnlock(bv);
-               updateLocal(bv);
-               the_locking_inset = 0;
-       }
-       actcell = 0;
-       oldcell = -1;
-       locked = false;
-       if (scroll(false) || hasSelection()) {
-               clearSelection();
-               if (scroll(false))
-                       scroll(bv, 0.0F);
-               updateLocal(bv);
-       }
-}
-
-
 void InsetTabular::updateLocal(BufferView * bv) const
 {
-       bv->updateInset(this);
-       if (locked)
-               resetPos(bv);
-}
-
-
-bool InsetTabular::lockInsetInInset(BufferView * bv, UpdatableInset * inset)
-{
-       lyxerr[Debug::INSETTEXT] << "InsetTabular::LockInsetInInset("
-                             << inset << "): ";
-       if (!inset)
-               return false;
-       oldcell = -1;
-       if (inset == &tabular.getCellInset(actcell)) {
-               lyxerr[Debug::INSETTEXT] << "OK" << endl;
-               the_locking_inset = &tabular.getCellInset(actcell);
-               resetPos(bv);
-               return true;
-       } else if (!the_locking_inset) {
-               int const n = tabular.getNumberOfCells();
-               int const id = inset->id();
-               for (int i = 0; i < n; ++i) {
-                       InsetText * in = &tabular.getCellInset(i);
-                       if (inset == in) {
-                               actcell = i;
-                               the_locking_inset = in;
-                               locked = true;
-                               resetPos(bv);
-                               return true;
-                       }
-                       if (in->getInsetFromID(id)) {
-                               actcell = i;
-                               in->localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
-                               return the_locking_inset->lockInsetInInset(bv, inset);
-                       }
-               }
-       } else if (the_locking_inset && (the_locking_inset == inset)) {
-               lyxerr[Debug::INSETTEXT] << "OK" << endl;
-               resetPos(bv);
-       } else if (the_locking_inset) {
-               lyxerr[Debug::INSETTEXT] << "MAYBE" << endl;
-               return the_locking_inset->lockInsetInInset(bv, inset);
-       }
-       lyxerr[Debug::INSETTEXT] << "NOT OK" << endl;
-       return false;
-}
-
-
-bool InsetTabular::unlockInsetInInset(BufferView * bv, UpdatableInset * inset,
-                                     bool lr)
-{
-       if (!the_locking_inset)
-               return false;
-       if (the_locking_inset == inset) {
-               the_locking_inset->insetUnlock(bv);
-#ifdef WITH_WARNINGS
-#warning fix scrolling when cellinset has requested a scroll (Jug)!!!
-#endif
-#if 0
-               if (scroll(false))
-                       scroll(bv, 0.0F);
-#endif
-               updateLocal(bv);
-               // this has to be here otherwise we don't redraw the cell!
-               the_locking_inset = 0;
-               return true;
-       }
-       if (the_locking_inset->unlockInsetInInset(bv, inset, lr)) {
-               if (inset->lyxCode() == TABULAR_CODE &&
-                   !the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE)) {
-                       InsetTabularMailer(*this).updateDialog(bv);
-                       oldcell = actcell;
-               }
-               return true;
-       }
-       return false;
+       bv->update();
+       resetPos(bv);
 }
 
 
 int InsetTabular::insetInInsetY() const
 {
-       if (!the_locking_inset)
-               return 0;
-       return inset_y + the_locking_inset->insetInInsetY();
-}
-
-
-UpdatableInset * InsetTabular::getLockingInset() const
-{
-       return the_locking_inset ? the_locking_inset->getLockingInset() :
-               const_cast<InsetTabular *>(this);
-}
-
-
-UpdatableInset * InsetTabular::getFirstLockingInsetOfType(InsetOld::Code c)
-{
-       if (c == lyxCode())
-               return this;
        if (the_locking_inset)
-               return the_locking_inset->getFirstLockingInsetOfType(c);
+               return cursory_ + the_locking_inset->insetInInsetY();
        return 0;
 }
 
 
 bool InsetTabular::insertInset(BufferView * bv, InsetOld * inset)
 {
-       if (the_locking_inset)
-               return the_locking_inset->insertInset(bv, inset);
-       return false;
+       return the_locking_inset && the_locking_inset->insertInset(bv, inset);
 }
 
 
@@ -529,226 +402,130 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
        if (hasSelection() && cmd.button() == mouse_button::button3)
                return;
 
-       if (hasSelection()) {
+       if (hasSelection())
                clearSelection();
-               updateLocal(cmd.view());
-       }
 
-       int const ocell = actcell;
        BufferView * bv = cmd.view();
 
-       if (!locked) {
-               locked = true;
-               the_locking_inset = 0;
-               inset_x = 0;
-               inset_y = 0;
-       }
+       the_locking_inset = 0;
        setPos(bv, cmd.x, cmd.y);
        clearSelection();
+       the_locking_inset = 0;
 
-       bool const inset_hit = insetHit(bv, cmd.x, cmd.y);
-
-       if ((ocell == actcell) && the_locking_inset && inset_hit) {
-               resetPos(bv);
-               FuncRequest cmd1 = cmd;
-               cmd1.x -= inset_x;
-               cmd1.y -= inset_y;
-               the_locking_inset->localDispatch(cmd1);
-               return;
-       }
-
-       if (the_locking_inset) {
-               the_locking_inset->insetUnlock(bv);
-               updateLocal(bv);
-               the_locking_inset = 0;
-       }
-
-       if (cmd.button() == mouse_button::button2) {
-               localDispatch(FuncRequest(bv, LFUN_PASTESELECTION, "paragraph"));
-               return;
-       }
-
-       if (inset_hit && bv->theLockingInset()) {
-               if (!bv->lockInset(&tabular.getCellInset(actcell))) {
-                       lyxerr[Debug::INSETS] << "Cannot lock inset" << endl;
-                       return;
-               }
-               FuncRequest cmd1 = cmd;
-               cmd1.x -= inset_x;
-               cmd1.y -= inset_y;
-               the_locking_inset->localDispatch(cmd1);
-       }
+       if (cmd.button() == mouse_button::button2)
+               dispatch(FuncRequest(bv, LFUN_PASTESELECTION, "paragraph"));
 }
 
 
-bool InsetTabular::lfunMouseRelease(FuncRequest const & cmd)
+void InsetTabular::lfunMouseRelease(FuncRequest const & cmd)
 {
-       bool ret = false;
-       if (the_locking_inset) {
-               FuncRequest cmd1 = cmd;
-               cmd1.x -= inset_x;
-               cmd1.y -= inset_y;
-               ret = the_locking_inset->localDispatch(cmd1);
-       }
-       if (cmd.button() == mouse_button::button3 && !ret) {
+       if (cmd.button() == mouse_button::button3)
                InsetTabularMailer(*this).showDialog(cmd.view());
-               return true;
-       }
-       return ret;
 }
 
 
 void InsetTabular::lfunMouseMotion(FuncRequest const & cmd)
 {
-       if (the_locking_inset) {
-               FuncRequest cmd1 = cmd;
-               cmd1.x -= inset_x;
-               cmd1.y -= inset_y;
-               the_locking_inset->localDispatch(cmd1);
-               return;
-       }
-
        BufferView * bv = cmd.view();
        int const old_cell = actcell;
 
        setPos(bv, cmd.x, cmd.y);
-       if (!hasSelection()) {
+       if (!hasSelection())
                setSelection(actcell, actcell);
-               updateLocal(bv);
-       } else if (old_cell != actcell) {
+       else if (old_cell != actcell)
                setSelection(sel_cell_start, actcell);
-               updateLocal(bv);
+}
+
+
+void InsetTabular::edit(BufferView * bv, bool left)
+{
+       lyxerr << "InsetTabular::edit: " << this
+               << " first text: " << tabular.cell_info[0][0].inset.getText(0) 
+               << " first cell: " << &tabular.cell_info[0][0].inset << endl;
+
+       finishUndo();
+       the_locking_inset = 0;
+
+       if (left) {
+               if (isRightToLeft(bv))
+                       actcell = tabular.getLastCellInRow(0);
+               else
+                       actcell = 0;
+       } else {
+               if (isRightToLeft(bv))
+                       actcell = tabular.getFirstCellInRow(tabular.rows()-1);
+               else
+                       actcell = tabular.getNumberOfCells() - 1;
        }
+       clearSelection();
+       resetPos(bv);
+       bv->fitCursor();
+       bv->cursor().push(this);
+}
+
+
+void InsetTabular::edit(BufferView * bv, int x, int y)
+{
+       lyxerr << "InsetTabular::edit: " << this << " first cell "
+               << &tabular.cell_info[0][0].inset << endl;
+
+       finishUndo();
+       the_locking_inset = 0;
+       setPos(bv, x, y);
+       clearSelection();
+       finishUndo();
+       int xx = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
+       bv->cursor().push(this);
+       if (x > xx)
+               activateCellInset(bv, x - xx, y - cursory_);
 }
 
 
-InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
+DispatchResult
+InsetTabular::priv_dispatch(FuncRequest const & cmd, idx_type &, pos_type &)
 {
+       lyxerr << "InsetTabular::dispatch: " << cmd << endl;
        // We need to save the value of the_locking_inset as the call to
        // the_locking_inset->localDispatch might unlock it.
-       old_locking_inset = the_locking_inset;
-       RESULT result = UpdatableInset::localDispatch(cmd);
-       BufferView * bv = cmd.view();
+       DispatchResult result(true, true);
+       BufferView * bv  = cmd.view();
+       bool hs = hasSelection();
 
-       if (cmd.action == LFUN_INSET_EDIT) {
+       switch (cmd.action) {
 
-               if (!bv->lockInset(this)) {
-                       lyxerr[Debug::INSETTEXT] << "InsetTabular::Cannot lock inset" << endl;
-                       return DISPATCHED;
-               }
+       case LFUN_MOUSE_PRESS:
+               lfunMousePress(cmd);
+               return DispatchResult(true, true);
 
-               finishUndo();
-               locked = true;
-               the_locking_inset = 0;
-               inset_x = 0;
-               inset_y = 0;
-
-               if (cmd.argument.size()) {
-                       if (cmd.argument == "left") {
-                               if (isRightToLeft(bv))
-                                       actcell = tabular.getLastCellInRow(0);
-                               else
-                                       actcell = 0;
-                       } else {
-                               if (isRightToLeft(bv))
-                                       actcell = tabular.getFirstCellInRow(tabular.rows()-1);
-                               else
-                                       actcell = tabular.getNumberOfCells() - 1;
-                       }
-                       clearSelection();
-                       resetPos(bv);
-                       bv->fitCursor();
-               }
+       case LFUN_MOUSE_MOTION:
+               lfunMouseMotion(cmd);
+               return DispatchResult(true, true);
 
-               else {
-                       setPos(bv, cmd.x, cmd.y);
-                       clearSelection();
-                       finishUndo();
-                       if (insetHit(bv, cmd.x, cmd.y) && cmd.button() != mouse_button::button3) {
-                               activateCellInsetAbs(bv, cmd.x, cmd.y, cmd.button());
-                       }
-               }
-               return DISPATCHED;
-       }
+       case LFUN_MOUSE_RELEASE:
+               lfunMouseRelease(cmd);
+               return DispatchResult(true, true);
 
-       if (result == DISPATCHED || result == DISPATCHED_NOUPDATE) {
-               resetPos(bv);
+       case LFUN_CELL_BACKWARD:
+       case LFUN_CELL_FORWARD:
+               if (cmd.action == LFUN_CELL_FORWARD)
+                       moveNextCell(bv, the_locking_inset != 0);
+               else
+                       movePrevCell(bv, the_locking_inset != 0);
+               clearSelection();
+               if (!the_locking_inset)
+                       return DispatchResult(true);
                return result;
-       }
-
-       if (cmd.action < 0 && cmd.argument.empty())
-               return FINISHED;
 
-       bool hs = hasSelection();
-
-       result = DISPATCHED;
-       // this one have priority over the locked InsetText, if we're not already
-       // inside another tabular then that one get's priority!
-       if (getFirstLockingInsetOfType(InsetOld::TABULAR_CODE) == this) {
-               switch (cmd.action) {
-               case LFUN_MOUSE_PRESS:
-                       lfunMousePress(cmd);
-                       return DISPATCHED;
-
-               case LFUN_MOUSE_MOTION:
-                       lfunMouseMotion(cmd);
-                       return DISPATCHED;
-
-               case LFUN_MOUSE_RELEASE:
-                       return lfunMouseRelease(cmd) ? DISPATCHED : UNDISPATCHED;
-
-               case LFUN_CELL_BACKWARD:
-               case LFUN_CELL_FORWARD:
-                       unlockInsetInInset(bv, the_locking_inset);
-                       if (cmd.action == LFUN_CELL_FORWARD)
-                               moveNextCell(bv, old_locking_inset != 0);
+       case LFUN_SCROLL_INSET:
+               if (!cmd.argument.empty()) {
+                       if (cmd.argument.find('.') != cmd.argument.npos)
+                               scroll(cmd.view(), static_cast<float>(strToDbl(cmd.argument)));
                        else
-                               movePrevCell(bv, old_locking_inset != 0);
-                       clearSelection();
-                       if (hs)
-                               updateLocal(bv);
-                       if (!the_locking_inset)
-                               return DISPATCHED_NOUPDATE;
-                       return result;
-               // this to avoid compiler warnings.
-               default:
-                       break;
-               }
-       }
-
-       kb_action action = cmd.action;
-       string    arg    = cmd.argument;
-       if (the_locking_inset) {
-               result = the_locking_inset->localDispatch(cmd);
-               if (result == DISPATCHED_NOUPDATE) {
-                       int sc = scroll();
-                       resetPos(bv);
-                       if (sc != scroll()) { // inset has been scrolled
-                               updateLocal(bv);
-                       }
-                       return result;
-               } else if (result == DISPATCHED) {
-                       updateLocal(bv);
-                       return result;
-               } else if (result == FINISHED_UP) {
-                       action = LFUN_UP;
-                       // Make sure to reset status message after
-                       // exiting, e.g. math inset
-                       bv->owner()->clearMessage();
-               } else if (result == FINISHED_DOWN) {
-                       action = LFUN_DOWN;
-                       bv->owner()->clearMessage();
-               } else if (result == FINISHED_RIGHT) {
-                       action = LFUN_RIGHT;
-                       bv->owner()->clearMessage();
-               } else if (result == FINISHED) {
-                       bv->owner()->clearMessage();
+                               scroll(cmd.view(), strToInt(cmd.argument));
+                       cmd.view()->update();
+                       return DispatchResult(true, true);
                }
-       }
 
-       result = DISPATCHED;
-       switch (action) {
-               // --- Cursor Movements ----------------------------------
        case LFUN_RIGHTSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
                if (tabular.isLastCellInRow(actcell)) {
@@ -764,15 +541,14 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        end = actcell;
                }
                setSelection(start, end);
-               updateLocal(bv);
                break;
        }
+
        case LFUN_RIGHT:
-               result = moveRight(bv);
+               result = moveRight(bv, true);
                clearSelection();
-               if (hs)
-                       updateLocal(bv);
                break;
+
        case LFUN_LEFTSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
                if (tabular.isFirstCellInRow(actcell)) {
@@ -788,15 +564,14 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        end = actcell;
                }
                setSelection(start, end);
-               updateLocal(bv);
                break;
        }
+
        case LFUN_LEFT:
-               result = moveLeft(bv);
+               result = moveLeft(bv, true);
                clearSelection();
-               if (hs)
-                       updateLocal(bv);
                break;
+
        case LFUN_DOWNSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
                int const ocell = actcell;
@@ -812,15 +587,14 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                } else {
                        setSelection(start, start);
                }
-               updateLocal(bv);
+               break;
        }
-       break;
+
        case LFUN_DOWN:
-               result = moveDown(bv, old_locking_inset != 0);
+               result = moveDown(bv, the_locking_inset != 0);
                clearSelection();
-               if (hs)
-                       updateLocal(bv);
                break;
+
        case LFUN_UPSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
                int const ocell = actcell;
@@ -828,45 +602,42 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                // the current cell at the beginning
                if (hasSelection()) {
                        moveUp(bv, false);
-                       if ((ocell == sel_cell_end) ||
-                           (tabular.column_of_cell(ocell)>tabular.column_of_cell(actcell)))
+                       if (ocell == sel_cell_end ||
+                           tabular.column_of_cell(ocell) > tabular.column_of_cell(actcell))
                                setSelection(start, tabular.getCellAbove(sel_cell_end));
                        else
                                setSelection(start, tabular.getLastCellAbove(sel_cell_end));
                } else {
                        setSelection(start, start);
                }
-               updateLocal(bv);
+               break;
        }
-       break;
+
        case LFUN_UP:
-               result = moveUp(bv, old_locking_inset != 0);
+               result = moveUp(bv, the_locking_inset != 0);
                clearSelection();
-               if (hs)
-                       updateLocal(bv);
                break;
+
        case LFUN_NEXT: {
                if (hs)
                        clearSelection();
                int column = actcol;
-               unlockInsetInInset(bv, the_locking_inset);
-               if (bv->top_y() + bv->painter().paperHeight() <
-                   top_baseline + tabular.getHeightOfTabular())
-                       {
-                               bv->scrollDocView(bv->top_y() + bv->painter().paperHeight());
-                               actcell = tabular.getCellBelow(first_visible_cell) + column;
-                       } else {
-                               actcell = tabular.getFirstCellInRow(tabular.rows() - 1) + column;
-                       }
+               if (bv->top_y() + bv->painter().paperHeight()
+                   < top_baseline + tabular.getHeightOfTabular())
+               {
+                       bv->scrollDocView(bv->top_y() + bv->painter().paperHeight());
+                       actcell = tabular.getCellBelow(first_visible_cell) + column;
+               } else {
+                       actcell = tabular.getFirstCellInRow(tabular.rows() - 1) + column;
+               }
                resetPos(bv);
-               updateLocal(bv);
                break;
        }
+
        case LFUN_PRIOR: {
                if (hs)
                        clearSelection();
                int column = actcol;
-               unlockInsetInInset(bv, the_locking_inset);
                if (top_baseline < 0) {
                        bv->scrollDocView(bv->top_y() - bv->painter().paperHeight());
                        if (top_baseline > 0)
@@ -877,9 +648,9 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        actcell = column;
                }
                resetPos(bv);
-               updateLocal(bv);
                break;
        }
+
        // none of these make sense for insettabular,
        // but we must catch them to prevent any
        // selection from being confused
@@ -904,51 +675,86 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
        case LFUN_ENDBUF:
        case LFUN_ENDBUFSEL:
                break;
-       case LFUN_LAYOUT_TABULAR: {
+
+       case LFUN_LAYOUT_TABULAR:
                InsetTabularMailer(*this).showDialog(bv);
                break;
-       }
-       case LFUN_INSET_DIALOG_UPDATE: {
+
+       case LFUN_INSET_DIALOG_UPDATE:
                InsetTabularMailer(*this).updateDialog(bv);
                break;
-       }
+
        case LFUN_TABULAR_FEATURE:
-               if (!tabularFeatures(bv, arg))
-                       result = UNDISPATCHED;
+               if (!tabularFeatures(bv, cmd.argument))
+                       result = DispatchResult(false);
                break;
-               // insert file functions
+
+       // insert file functions
        case LFUN_FILE_INSERT_ASCII_PARA:
-       case LFUN_FILE_INSERT_ASCII:
-       {
-               string tmpstr = getContentsOfAsciiFile(bv, arg, false);
-               if (tmpstr.empty())
-                       break;
-               if (insertAsciiString(bv, tmpstr, false))
-                       updateLocal(bv);
-               else
-                       result = UNDISPATCHED;
+       case LFUN_FILE_INSERT_ASCII: {
+               string tmpstr = getContentsOfAsciiFile(bv, cmd.argument, false);
+               if (!tmpstr.empty() && !insertAsciiString(bv, tmpstr, false))
+                       result = DispatchResult(false);
                break;
        }
-       // cut and paste functions
+
+       case LFUN_LANGUAGE:
+       case LFUN_EMPH:
+       case LFUN_BOLD:
+       case LFUN_NOUN:
+       case LFUN_CODE:
+       case LFUN_SANS:
+       case LFUN_ROMAN:
+       case LFUN_DEFAULT:
+       case LFUN_UNDERLINE:
+       case LFUN_FONT_SIZE:
+               lyxerr << "font changes not re-implemented for tables after LOCK" << endl;
+               break;
+
+       case LFUN_FINISHED_LEFT:
+               lyxerr << "swallow LFUN_FINISHED_LEFT, act: " << actcell << endl;
+               if (!movePrevCell(bv, false))
+                       result = DispatchResult(FINISHED);
+               break;
+
+       case LFUN_FINISHED_RIGHT:
+               lyxerr << "swallow LFUN_FINISHED_RIGHT, act: " << actcell << endl;
+               if (!moveNextCell(bv, false))
+                       result = DispatchResult(FINISHED_RIGHT);
+               break;
+
+       case LFUN_FINISHED_UP:
+               lyxerr << "swallow LFUN_FINISHED_UP, act: " << actcell << endl;
+               result = moveUp(bv, true);
+               break;
+
+       case LFUN_FINISHED_DOWN:
+               lyxerr << "swallow LFUN_FINISHED_DOWN, act: " << actcell << endl;
+               result = moveDown(bv, true);
+               break;
+
        case LFUN_CUT:
-               if (!copySelection(bv))
-                       break;
-               // no break here!
+               if (copySelection(bv)) {
+                       recordUndo(bv, Undo::DELETE);
+                       cutSelection(bv->buffer()->params());
+               }
+               break;
+
        case LFUN_DELETE:
                recordUndo(bv, Undo::DELETE);
                cutSelection(bv->buffer()->params());
-               updateLocal(bv);
                break;
+
        case LFUN_COPY:
                if (!hasSelection())
                        break;
                finishUndo();
                copySelection(bv);
                break;
-       case LFUN_PASTESELECTION:
-       {
-               string const clip(bv->getClipboard());
-                       if (clip.empty())
+
+       case LFUN_PASTESELECTION: {
+               string const clip = bv->getClipboard();
+               if (clip.empty())
                        break;
 #if 0
                if (clip.find('\t') != string::npos) {
@@ -974,9 +780,12 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                                ++p;
                        }
                        maxCols = max(cols, maxCols);
-                       delete paste_tabular;
-                       paste_tabular = new LyXTabular(bv->buffer()->params(),
-                                                      this, rows, maxCols);
+
+                       paste_tabular.reset(
+                               new LyXTabular(bv->buffer()->params(),
+                                              this, rows, maxCols)
+                               );
+
                        string::size_type op = 0;
                        int cell = 0;
                        int cells = paste_tabular->getNumberOfCells();
@@ -1012,92 +821,70 @@ InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        // so that the clipboard is used and it goes on
                        // to default
                        // and executes LFUN_PASTESELECTION in insettext!
-                       delete paste_tabular;
-                       paste_tabular = 0;
+                       paste_tabular.reset();
                }
+               // fall through
        }
+
        case LFUN_PASTE:
                if (hasPasteBuffer()) {
                        recordUndo(bv, Undo::INSERT);
                        pasteSelection(bv);
-                       updateLocal(bv);
                        break;
                }
-               // ATTENTION: the function above has to be PASTE and PASTESELECTION!!!
+               // fall through
+
+       // ATTENTION: the function above has to be PASTE and PASTESELECTION!!!
+
        default:
                // handle font changing stuff on selection before we lock the inset
                // in the default part!
-               result = UNDISPATCHED;
-               if (hs) {
-                       switch(action) {
-                       case LFUN_LANGUAGE:
-                       case LFUN_EMPH:
-                       case LFUN_BOLD:
-                       case LFUN_NOUN:
-                       case LFUN_CODE:
-                       case LFUN_SANS:
-                       case LFUN_ROMAN:
-                       case LFUN_DEFAULT:
-                       case LFUN_UNDERLINE:
-                       case LFUN_FONT_SIZE:
-                               if (bv->dispatch(FuncRequest(bv, action, arg)))
-                                       result = DISPATCHED;
-                               break;
-                       default:
-                               break;
-                       }
-               }
+               result = DispatchResult(false);
                // we try to activate the actual inset and put this event down to
                // the insets dispatch function.
-               if (result == DISPATCHED || the_locking_inset)
-                       break;
-               if (activateCellInset(bv)) {
-                       result = the_locking_inset->localDispatch(FuncRequest(bv, action, arg));
-                       if (result == UNDISPATCHED || result >= FINISHED) {
-                               unlockInsetInInset(bv, the_locking_inset);
+               if (!the_locking_inset && activateCellInset(bv)) {
+                       result = the_locking_inset->dispatch(cmd);
+                       if (!result.dispatched()) {
                                // we need to update if this was requested before
-                               updateLocal(bv);
-                               return UNDISPATCHED;
+                               result = DispatchResult(false);
+                               break;
                        }
                        if (hs)
                                clearSelection();
-                       updateLocal(bv);
-                       return result;
                }
                break;
        }
-       if (result < FINISHED) {
-               if (!the_locking_inset && bv->fitCursor())
-                       updateLocal(bv);
-       } else
-               bv->unlockInset(this);
+
+       updateLocal(bv);
+       InsetTabularMailer(*this).updateDialog(bv);
        return result;
 }
 
 
 int InsetTabular::latex(Buffer const & buf, ostream & os,
-                       LatexRunParams const & runparams) const
+                       OutputParams const & runparams) const
 {
        return tabular.latex(buf, os, runparams);
 }
 
 
-int InsetTabular::ascii(Buffer const & buf, ostream & os, int ll) const
+int InsetTabular::plaintext(Buffer const & buf, ostream & os,
+                       OutputParams const & runparams) const
 {
-       if (ll > 0)
-               return tabular.ascii(buf, os, ownerPar(buf, this).params().depth(),
-                                     false, 0);
-       return tabular.ascii(buf, os, 0, false, 0);
+       int dp = runparams.linelen ? ownerPar(buf, this).params().depth() : 0;
+       return tabular.plaintext(buf, os, runparams, dp, false, 0);
 }
 
 
-int InsetTabular::linuxdoc(Buffer const & buf, ostream & os) const
+int InsetTabular::linuxdoc(Buffer const & buf, ostream & os,
+                          OutputParams const & runparams) const
 {
-       return tabular.linuxdoc(buf,os);
+       return tabular.linuxdoc(buf,os, runparams);
 }
 
 
-int InsetTabular::docbook(Buffer const & buf, ostream & os, bool mixcont) const
+int InsetTabular::docbook(Buffer const & buf, ostream & os,
+                         OutputParams const & runparams) const
 {
        int ret = 0;
        InsetOld * master;
@@ -1110,14 +897,14 @@ int InsetTabular::docbook(Buffer const & buf, ostream & os, bool mixcont) const
 
        if (!master) {
                os << "<informaltable>";
-               if (mixcont)
+               if (runparams.mixed_content)
                        os << endl;
                ++ret;
        }
-       ret += tabular.docbook(buf, os, mixcont);
+       ret += tabular.docbook(buf, os, runparams);
        if (!master) {
                os << "</informaltable>";
-               if (mixcont)
+               if (runparams.mixed_content)
                        os << endl;
                ++ret;
        }
@@ -1179,34 +966,10 @@ void InsetTabular::calculate_dimensions_of_cells(MetricsInfo & mi) const
 }
 
 
-void InsetTabular::getCursor(BufferView & bv, int & x, int & y) const
-{
-       if (the_locking_inset) {
-               the_locking_inset->getCursor(bv, x, y);
-               return;
-       }
-
-       x = cursorx_;
-       y = cursory_ + InsetTabular::y();
-
-       // Fun stuff
-       int desc = tabular.getDescentOfRow(actrow);
-       y += desc;
-       int ascdesc = tabular.getAscentOfRow(actrow) + desc;
-       y -= ascdesc / 2;
-       y += ADD_TO_HEIGHT * 2;
-       y += TEXT_TO_INSET_OFFSET;
-}
-
-
-void InsetTabular::getCursorPos(BufferView * bv, int & x, int & y) const
+void InsetTabular::getCursorPos(BufferView *, int & x, int & y) const
 {
-       if (the_locking_inset) {
-               the_locking_inset->getCursorPos(bv, x, y);
-               return;
-       }
-       x = cursorx_ - top_x;
-       y = cursory_;
+       x = TEXT_TO_INSET_OFFSET + cursorx_ - top_x;
+       y = TEXT_TO_INSET_OFFSET + cursory_;
 }
 
 
@@ -1229,7 +992,9 @@ void InsetTabular::fitInsetCursor(BufferView * bv) const
 void InsetTabular::setPos(BufferView * bv, int x, int y) const
 {
        cursory_ = 0;
-       actcell = actrow = actcol = 0;
+       actcell = 0;
+       actrow = 0;
+       actcol = 0;
        int ly = tabular.getDescentOfRow(actrow);
 
        // first search the right row
@@ -1265,7 +1030,7 @@ int InsetTabular::getCellXPos(int cell) const
        for (; c < cell; ++c)
                lx += tabular.getWidthOfColumn(c);
 
-       return (lx - tabular.getWidthOfColumn(cell) + top_x);
+       return lx - tabular.getWidthOfColumn(cell) + top_x;
 }
 
 
@@ -1290,17 +1055,12 @@ void InsetTabular::resetPos(BufferView * bv) const
                        ++actrow;
                }
        }
-       if (!locked) {
-               if (the_locking_inset)
-                       inset_y = cursory_;
-               return;
-       }
+
        // we need this only from here on!!!
        ++in_reset_pos;
-       static int const offset = ADD_TO_TABULAR_WIDTH + 2;
-       int new_x = getCellXPos(actcell);
+       int const offset = ADD_TO_TABULAR_WIDTH + 2;
+       int new_x = getCellXPos(actcell) + offset;
        int old_x = cursorx_;
-       new_x += offset;
        cursorx_ = new_x;
 //    cursor.x(getCellXPos(actcell) + offset);
        if (actcol < tabular.columns() - 1 && scroll(false) &&
@@ -1311,9 +1071,9 @@ void InsetTabular::resetPos(BufferView * bv) const
        } else if (the_locking_inset &&
                 tabular.getWidthOfColumn(actcell) > bv->workWidth() - 20)
        {
-               int xx = cursorx_ - offset + bv->text->getRealCursorX();
+               int xx = cursorx_ - offset;
                if (xx > bv->workWidth()-20) {
-                       scroll(bv, -(xx - bv->workWidth() + 60));
+                       scroll(bv, - xx + bv->workWidth() - 60);
                        updateLocal(bv);
                } else if (xx < 20) {
                        if (xx < 0)
@@ -1326,101 +1086,77 @@ void InsetTabular::resetPos(BufferView * bv) const
        } else if (cursorx_ - offset > 20 &&
                   cursorx_ - offset + tabular.getWidthOfColumn(actcell)
                   > bv->workWidth() - 20) {
-               scroll(bv, -tabular.getWidthOfColumn(actcell) - 20);
+               scroll(bv, - tabular.getWidthOfColumn(actcell) - 20);
                updateLocal(bv);
        } else if (cursorx_ - offset < 20) {
                scroll(bv, 20 - cursorx_ + offset);
                updateLocal(bv);
        } else if (scroll() && top_x > 20 &&
-                  (top_x + tabular.getWidthOfTabular()) > bv->workWidth() - 20) {
+                  top_x + tabular.getWidthOfTabular() > bv->workWidth() - 20) {
                scroll(bv, old_x - cursorx_);
                updateLocal(bv);
        }
-       if (the_locking_inset) {
-               inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
-               inset_y = cursory_;
-       }
-       if ((!the_locking_inset ||
-            !the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE)) &&
-           actcell != oldcell) {
-               InsetTabularMailer(*this).updateDialog(bv);
-               oldcell = actcell;
-       }
+       InsetTabularMailer(*this).updateDialog(bv);
        in_reset_pos = 0;
 }
 
 
-InsetOld::RESULT InsetTabular::moveRight(BufferView * bv, bool lock)
+DispatchResult InsetTabular::moveRight(BufferView * bv, bool lock)
 {
-       if (lock && !old_locking_inset) {
+       if (lock) {
                if (activateCellInset(bv))
-                       return DISPATCHED;
+                       return DispatchResult(true, true);
        } else {
                bool moved = isRightToLeft(bv)
                        ? movePrevCell(bv) : moveNextCell(bv);
                if (!moved)
-                       return FINISHED_RIGHT;
+                       return DispatchResult(false, FINISHED_RIGHT);
                if (lock && activateCellInset(bv))
-                       return DISPATCHED;
+                       return DispatchResult(true, true);
        }
        resetPos(bv);
-       return DISPATCHED_NOUPDATE;
+       return DispatchResult(true);
 }
 
 
-InsetOld::RESULT InsetTabular::moveLeft(BufferView * bv, bool lock)
+DispatchResult InsetTabular::moveLeft(BufferView * bv, bool lock)
 {
        bool moved = isRightToLeft(bv) ? moveNextCell(bv) : movePrevCell(bv);
        if (!moved)
-               return FINISHED;
-       if (lock) {       // behind the inset
-               if (activateCellInset(bv, 0, 0, mouse_button::none, true))
-                       return DISPATCHED;
-       }
+               return DispatchResult(false, FINISHED);
+       // behind the inset
+       if (lock && activateCellInset(bv, 0, 0, true))
+               return DispatchResult(true, true);
        resetPos(bv);
-       return DISPATCHED_NOUPDATE;
+       return DispatchResult(true);
 }
 
 
-InsetOld::RESULT InsetTabular::moveUp(BufferView * bv, bool lock)
+DispatchResult InsetTabular::moveUp(BufferView * bv, bool lock)
 {
        int const ocell = actcell;
        actcell = tabular.getCellAbove(actcell);
-       if (actcell == ocell) // we moved out of the inset
-               return FINISHED_UP;
-       resetPos(bv);
-       if (lock) {
-               int x = 0;
-               int y = 0;
-               if (old_locking_inset) {
-                       old_locking_inset->getCursorPos(bv, x, y);
-                       x -= cursorx_ + tabular.getBeginningOfTextInCell(actcell);
-               }
-               if (activateCellInset(bv, x, 0))
-                       return DISPATCHED;
+       if (actcell == ocell) { // we moved out of the inset
+               return DispatchResult(false, FINISHED_UP);
        }
-       return DISPATCHED_NOUPDATE;
+       resetPos(bv);
+       if (lock)
+               activateCellInset(bv, bv->x_target(), 0);
+       return DispatchResult(true, true);
 }
 
 
-InsetOld::RESULT InsetTabular::moveDown(BufferView * bv, bool lock)
+DispatchResult InsetTabular::moveDown(BufferView * bv, bool lock)
 {
        int const ocell = actcell;
        actcell = tabular.getCellBelow(actcell);
-       if (actcell == ocell) // we moved out of the inset
-               return FINISHED_DOWN;
-       resetPos(bv);
-       if (lock) {
-               int x = 0;
-               int y = 0;
-               if (old_locking_inset) {
-                       old_locking_inset->getCursorPos(bv, x, y);
-                       x -= cursorx_ + tabular.getBeginningOfTextInCell(actcell);
-               }
-               if (activateCellInset(bv, x, 0))
-                       return DISPATCHED;
+       if (actcell == ocell) { // we moved out of the inset
+               return DispatchResult(false, FINISHED_DOWN);
        }
-       return DISPATCHED_NOUPDATE;
+       resetPos(bv);
+       if (lock)
+               activateCellInset(bv, bv->x_target(), 0);
+       return DispatchResult(true, true);
 }
 
 
@@ -1446,7 +1182,7 @@ bool InsetTabular::moveNextCell(BufferView * bv, bool lock)
        if (lock) {
                bool rtl = tabular.getCellInset(actcell).paragraphs.begin()->
                        isRightToLeftPar(bv->buffer()->params());
-               activateCellInset(bv, 0, 0, mouse_button::none, !rtl);
+               activateCellInset(bv, 0, 0, !rtl);
        }
        resetPos(bv);
        return true;
@@ -1455,7 +1191,9 @@ bool InsetTabular::moveNextCell(BufferView * bv, bool lock)
 
 bool InsetTabular::movePrevCell(BufferView * bv, bool lock)
 {
+       lyxerr << "move prevcell 1" << endl;
        if (isRightToLeft(bv)) {
+               lyxerr << "move prevcell a" << endl;
                if (tabular.isLastCellInRow(actcell)) {
                        int row = tabular.row_of_cell(actcell);
                        if (row == 0)
@@ -1468,16 +1206,20 @@ bool InsetTabular::movePrevCell(BufferView * bv, bool lock)
                        ++actcell;
                }
        } else {
-               if (!actcell) // first cell
+               lyxerr << "move prevcell b" << endl;
+               if (actcell == 0) // first cell
                        return false;
                --actcell;
        }
+       lyxerr << "move prevcell 2" << endl;
        if (lock) {
                bool rtl = tabular.getCellInset(actcell).paragraphs.begin()->
                        isRightToLeftPar(bv->buffer()->params());
-               activateCellInset(bv, 0, 0, mouse_button::none, !rtl);
+               activateCellInset(bv, 0, 0, !rtl);
        }
+       lyxerr << "move prevcell 3" << endl;
        resetPos(bv);
+       lyxerr << "move prevcell 4" << endl;
        return true;
 }
 
@@ -1499,8 +1241,8 @@ void InsetTabular::setFont(BufferView * bv, LyXFont const & font, bool tall,
                int sel_col_start;
                int sel_col_end;
                getSelection(sel_row_start, sel_row_end, sel_col_start, sel_col_end);
-               for(int i = sel_row_start; i <= sel_row_end; ++i)
-                       for(int j = sel_col_start; j <= sel_col_end; ++j)
+               for (int i = sel_row_start; i <= sel_row_end; ++i)
+                       for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.getCellInset(i, j).setFont(bv, font, tall, true);
 
                if (!frozen)
@@ -1558,12 +1300,11 @@ void checkLongtableSpecial(LyXTabular::ltType & ltt,
        }
 }
 
-}
+} // anon namespace
 
 
 void InsetTabular::tabularFeatures(BufferView * bv,
-                                  LyXTabular::Feature feature,
-                                  string const & value)
+       LyXTabular::Feature feature, string const & value)
 {
        int sel_col_start;
        int sel_col_end;
@@ -1628,104 +1369,73 @@ void InsetTabular::tabularFeatures(BufferView * bv,
 
        switch (feature) {
 
-       case LyXTabular::SET_PWIDTH:
-       {
-               LyXLength const vallen(value);
-               LyXLength const & tmplen = tabular.getColumnPWidth(actcell);
-
-               bool const update = (tmplen != vallen);
-               tabular.setColumnPWidth(actcell, vallen);
-               if (update) {
-                       // We need this otherwise we won't resize
-                       // the insettext of the active cell (if any)
-                       // until later (see InsetText::do_resize)
-                       unlockInsetInInset(bv, the_locking_inset);
-                       bv->update();
-               }
-
-               if (vallen.zero()
+       case LyXTabular::SET_PWIDTH: {
+               LyXLength const len(value);
+               tabular.setColumnPWidth(actcell, len);
+               if (len.zero()
                    && tabular.getAlignment(actcell, true) == LYX_ALIGN_BLOCK)
                        tabularFeatures(bv, LyXTabular::ALIGN_CENTER, string());
-               else if (!vallen.zero()
+               else if (!len.zero()
                         && tabular.getAlignment(actcell, true) != LYX_ALIGN_BLOCK)
                        tabularFeatures(bv, LyXTabular::ALIGN_BLOCK, string());
                break;
        }
 
        case LyXTabular::SET_MPWIDTH:
-       {
-               LyXLength const vallen(value);
-               LyXLength const & tmplen = tabular.getPWidth(actcell);
-
-               bool const update = (tmplen != vallen);
-               tabular.setMColumnPWidth(actcell, vallen);
-               if (update) {
-                       // We need this otherwise we won't resize
-                       // the insettext of the active cell (if any)
-                       // until later (see InsetText::do_resize)
-                       unlockInsetInInset(bv, the_locking_inset);
-                       updateLocal(bv);
-               }
-       }
-       break;
+               tabular.setMColumnPWidth(actcell, LyXLength(value));
+               break;
+
        case LyXTabular::SET_SPECIAL_COLUMN:
        case LyXTabular::SET_SPECIAL_MULTI:
                tabular.setAlignSpecial(actcell,value,feature);
-               updateLocal(bv);
                break;
+
        case LyXTabular::APPEND_ROW:
                // append the row into the tabular
-               unlockInsetInInset(bv, the_locking_inset);
                tabular.appendRow(bv->buffer()->params(), actcell);
-               updateLocal(bv);
+               tabular.setOwner(this);
                break;
+
        case LyXTabular::APPEND_COLUMN:
                // append the column into the tabular
-               unlockInsetInInset(bv, the_locking_inset);
                tabular.appendColumn(bv->buffer()->params(), actcell);
+               tabular.setOwner(this);
                actcell = tabular.getCellNumber(row, column);
-               updateLocal(bv);
                break;
+
        case LyXTabular::DELETE_ROW:
-               unlockInsetInInset(bv, the_locking_inset);
-               for(int i = sel_row_start; i <= sel_row_end; ++i) {
+               for (int i = sel_row_start; i <= sel_row_end; ++i)
                        tabular.deleteRow(sel_row_start);
-               }
                if (sel_row_start >= tabular.rows())
                        --sel_row_start;
                actcell = tabular.getCellNumber(sel_row_start, column);
                clearSelection();
-               updateLocal(bv);
                break;
+
        case LyXTabular::DELETE_COLUMN:
-               unlockInsetInInset(bv, the_locking_inset);
-               for(int i = sel_col_start; i <= sel_col_end; ++i) {
+               for (int i = sel_col_start; i <= sel_col_end; ++i)
                        tabular.deleteColumn(sel_col_start);
-               }
                if (sel_col_start >= tabular.columns())
                        --sel_col_start;
                actcell = tabular.getCellNumber(row, sel_col_start);
                clearSelection();
-               updateLocal(bv);
                break;
+
        case LyXTabular::M_TOGGLE_LINE_TOP:
                flag = false;
-       case LyXTabular::TOGGLE_LINE_TOP:
-       {
+       case LyXTabular::TOGGLE_LINE_TOP: {
                bool lineSet = !tabular.topLine(actcell, flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setTopLine(
                                        tabular.getCellNumber(i, j),
                                        lineSet, flag);
-               updateLocal(bv);
                break;
        }
 
        case LyXTabular::M_TOGGLE_LINE_BOTTOM:
                flag = false;
-       case LyXTabular::TOGGLE_LINE_BOTTOM:
-       {
+       case LyXTabular::TOGGLE_LINE_BOTTOM: {
                bool lineSet = !tabular.bottomLine(actcell, flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
@@ -1733,14 +1443,12 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i, j),
                                        lineSet,
                                        flag);
-               updateLocal(bv);
                break;
        }
 
        case LyXTabular::M_TOGGLE_LINE_LEFT:
                flag = false;
-       case LyXTabular::TOGGLE_LINE_LEFT:
-       {
+       case LyXTabular::TOGGLE_LINE_LEFT: {
                bool lineSet = !tabular.leftLine(actcell, flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
@@ -1748,14 +1456,12 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i,j),
                                        lineSet,
                                        flag);
-               updateLocal(bv);
                break;
        }
 
        case LyXTabular::M_TOGGLE_LINE_RIGHT:
                flag = false;
-       case LyXTabular::TOGGLE_LINE_RIGHT:
-       {
+       case LyXTabular::TOGGLE_LINE_RIGHT: {
                bool lineSet = !tabular.rightLine(actcell, flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
@@ -1763,7 +1469,6 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i,j),
                                        lineSet,
                                        flag);
-               updateLocal(bv);
                break;
        }
 
@@ -1781,7 +1486,6 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i, j),
                                        setAlign,
                                        flag);
-               updateLocal(bv);
                break;
 
        case LyXTabular::M_VALIGN_TOP:
@@ -1796,7 +1500,6 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                tabular.setVAlignment(
                                        tabular.getCellNumber(i, j),
                                        setVAlign, flag);
-               updateLocal(bv);
                break;
 
        case LyXTabular::MULTICOLUMN: {
@@ -1815,7 +1518,6 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                tabular.unsetMultiColumn(actcell);
                        else
                                tabular.setMultiColumn(bv->buffer(), actcell, 1);
-                       updateLocal(bv);
                        break;
                }
                // we have a selection so this means we just add all this
@@ -1833,7 +1535,6 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                tabular.setMultiColumn(bv->buffer(), s_start, s_end - s_start + 1);
                actcell = s_start;
                clearSelection();
-               updateLocal(bv);
                break;
        }
 
@@ -1844,17 +1545,14 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setAllLines(
                                        tabular.getCellNumber(i,j), setLines);
-               updateLocal(bv);
                break;
 
        case LyXTabular::SET_LONGTABULAR:
                tabular.setLongTabular(true);
-               updateLocal(bv); // because this toggles displayed
                break;
 
        case LyXTabular::UNSET_LONGTABULAR:
                tabular.setLongTabular(false);
-               updateLocal(bv); // because this toggles displayed
                break;
 
        case LyXTabular::SET_ROTATE_TABULAR:
@@ -1867,7 +1565,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
 
        case LyXTabular::SET_ROTATE_CELL:
                for (int i = sel_row_start; i <= sel_row_end; ++i)
-                       for (int j = sel_col_start; j<=sel_col_end; ++j)
+                       for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setRotateCell(
                                        tabular.getCellNumber(i, j), true);
                break;
@@ -1921,23 +1619,21 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                tabular.setLTFoot(row, flag, ltt, true);
                break;
 
-       case LyXTabular::SET_LTNEWPAGE: {
-               bool what = !tabular.getLTNewPage(row);
-               tabular.setLTNewPage(row, what);
+       case LyXTabular::SET_LTNEWPAGE:
+               tabular.setLTNewPage(row, !tabular.getLTNewPage(row));
                break;
-       }
 
        // dummy stuff just to avoid warnings
        case LyXTabular::LAST_ACTION:
                break;
        }
 
+       updateLocal(bv);
        InsetTabularMailer(*this).updateDialog(bv);
 }
 
 
-bool InsetTabular::activateCellInset(BufferView * bv, int x, int y,
-       mouse_button::state button, bool behind)
+bool InsetTabular::activateCellInset(BufferView * bv, int x, int y, bool behind)
 {
        UpdatableInset & inset = tabular.getCellInset(actcell);
        if (behind) {
@@ -1945,9 +1641,8 @@ bool InsetTabular::activateCellInset(BufferView * bv, int x, int y,
                x = inset.x() + inset.width();
                y = inset.descent();
        }
-       //inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
-       //inset_y = cursory_;
-       inset.localDispatch(FuncRequest(bv, LFUN_INSET_EDIT, x,  y, button));
+       inset.edit(bv, x, y);
+       bv->cursor().push(&inset);
        if (!the_locking_inset)
                return false;
        updateLocal(bv);
@@ -1955,36 +1650,12 @@ bool InsetTabular::activateCellInset(BufferView * bv, int x, int y,
 }
 
 
-bool InsetTabular::activateCellInsetAbs(BufferView * bv, int x, int y,
-                                       mouse_button::state button)
-{
-       inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
-       inset_y = cursory_;
-       return activateCellInset(bv, x - inset_x, y - inset_y, button);
-}
-
-
-bool InsetTabular::insetHit(BufferView *, int x, int) const
-{
-       return x + top_x > cursorx_ + tabular.getBeginningOfTextInCell(actcell);
-}
-
-
 void InsetTabular::deleteLyXText(BufferView * /*bv*/, bool /*recursive*/) const
 {
        //resizeLyXText(bv, recursive);
 }
 
 
-LyXText * InsetTabular::getLyXText(BufferView const * bv,
-                                  bool const recursive) const
-{
-       if (the_locking_inset)
-               return the_locking_inset->getLyXText(bv, recursive);
-       return InsetOld::getLyXText(bv, recursive);
-}
-
-
 bool InsetTabular::showInsetDialog(BufferView * bv) const
 {
        if (!the_locking_inset || !the_locking_inset->showInsetDialog(bv))
@@ -1995,6 +1666,8 @@ bool InsetTabular::showInsetDialog(BufferView * bv) const
 
 void InsetTabular::openLayoutDialog(BufferView * bv) const
 {
+#warning Look here
+/*
        if (the_locking_inset) {
                InsetTabular * inset = static_cast<InsetTabular *>
                        (the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE));
@@ -2003,6 +1676,7 @@ void InsetTabular::openLayoutDialog(BufferView * bv) const
                        return;
                }
        }
+*/
        InsetTabularMailer(*this).showDialog(bv);
 }
 
@@ -2028,7 +1702,8 @@ FuncStatus InsetTabular::getStatus(string const & what) const
        }
        if (action == LyXTabular::LAST_ACTION) {
                status.clear();
-               return status.unknown(true);
+               status.unknown(true);
+               return status;
        }
 
        string const argument
@@ -2056,7 +1731,8 @@ FuncStatus InsetTabular::getStatus(string const & what) const
        case LyXTabular::DELETE_COLUMN:
        case LyXTabular::SET_ALL_LINES:
        case LyXTabular::UNSET_ALL_LINES:
-               return status.clear();
+               status.clear();
+               return status;
 
        case LyXTabular::MULTICOLUMN:
                status.setOnOff(tabular.isMultiColumn(actcell));
@@ -2184,9 +1860,10 @@ FuncStatus InsetTabular::getStatus(string const & what) const
 }
 
 
-void InsetTabular::getLabelList(std::vector<string> & list) const
+void InsetTabular::getLabelList(Buffer const & buffer,
+                               std::vector<string> & list) const
 {
-       tabular.getLabelList(list);
+       tabular.getLabelList(buffer, list);
 }
 
 
@@ -2209,8 +1886,8 @@ bool InsetTabular::copySelection(BufferView * bv)
        if (sel_row_start > sel_row_end)
                swap(sel_row_start, sel_row_end);
 
-       delete paste_tabular;
-       paste_tabular = new LyXTabular(bv->buffer()->params(), this, tabular);
+       paste_tabular.reset(new LyXTabular(tabular));
+       paste_tabular->setOwner(this);
 
        for (int i = 0; i < sel_row_start; ++i)
                paste_tabular->deleteRow(0);
@@ -2235,8 +1912,9 @@ bool InsetTabular::copySelection(BufferView * bv)
                                    true, true);
 
        ostringstream os;
-       paste_tabular->ascii(*bv->buffer(), os,
-                            ownerPar(*bv->buffer(), this).params().depth(), true, '\t');
+       OutputParams const runparams;   
+       paste_tabular->plaintext(*bv->buffer(), os, runparams,
+                                ownerPar(*bv->buffer(), this).params().depth(), true, '\t');
        bv->stuffClipboard(os.str());
        return true;
 }
@@ -2300,7 +1978,8 @@ bool InsetTabular::cutSelection(BufferParams const & bp)
 
        for (int i = sel_row_start; i <= sel_row_end; ++i)
                for (int j = sel_col_start; j <= sel_col_end; ++j)
-                       tabular.getCellInset(tabular.getCellNumber(i, j)).clear(bp.tracking_changes);
+                       tabular.getCellInset(tabular.getCellNumber(i, j))
+                               .clear(bp.tracking_changes);
        return true;
 }
 
@@ -2344,85 +2023,23 @@ void InsetTabular::getSelection(int & srow, int & erow,
 
 ParagraphList * InsetTabular::getParagraphs(int i) const
 {
-       return (i < tabular.getNumberOfCells())
+       return i < tabular.getNumberOfCells()
                ? tabular.getCellInset(i).getParagraphs(0)
                : 0;
 }
 
 
-LyXCursor const & InsetTabular::cursor(BufferView * bv) const
-{
-       if (the_locking_inset)
-               return the_locking_inset->cursor(bv);
-       return InsetOld::cursor(bv);
-}
-
-
-InsetOld * InsetTabular::getInsetFromID(int id_arg) const
-{
-       if (id_arg == id())
-               return const_cast<InsetTabular *>(this);
-
-       for (int i = 0; i < tabular.rows(); ++i) {
-               for (int j = 0; j < tabular.columns(); ++j) {
-                       InsetOld * inset = tabular.getCellInset(i, j).getInsetFromID(id_arg);
-                       if (inset)
-                               return inset;
-               }
-       }
-       return 0;
-}
-
-
-WordLangTuple const
-InsetTabular::selectNextWordToSpellcheck(BufferView * bv, float & value) const
+int InsetTabular::numParagraphs() const
 {
-       if (the_locking_inset) {
-               WordLangTuple word(the_locking_inset->selectNextWordToSpellcheck(bv, value));
-               if (!word.word().empty())
-                       return word;
-               if (tabular.isLastCell(actcell)) {
-                       bv->unlockInset(const_cast<InsetTabular *>(this));
-                       return WordLangTuple();
-               }
-               ++actcell;
-       }
-       // otherwise we have to lock the next inset and ask for it's selecttion
-       tabular.getCellInset(actcell)
-               .localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
-       WordLangTuple word(selectNextWordInt(bv, value));
-       if (!word.word().empty())
-               resetPos(bv);
-       return word;
-}
-
-
-WordLangTuple InsetTabular::selectNextWordInt(BufferView * bv, float & value) const
-{
-       // when entering this function the inset should be ALWAYS locked!
-       BOOST_ASSERT(the_locking_inset);
-
-       WordLangTuple word(the_locking_inset->selectNextWordToSpellcheck(bv, value));
-       if (!word.word().empty())
-               return word;
-
-       if (tabular.isLastCell(actcell)) {
-               bv->unlockInset(const_cast<InsetTabular *>(this));
-               return WordLangTuple();
-       }
-
-       // otherwise we have to lock the next inset and ask for it's selecttion
-       ++actcell;
-       tabular.getCellInset(actcell)
-               .localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
-       return selectNextWordInt(bv, value);
+       return tabular.getNumberOfCells();
 }
 
 
-void InsetTabular::selectSelectedWord(BufferView * bv)
+LyXText * InsetTabular::getText(int i) const
 {
-       if (the_locking_inset)
-               the_locking_inset->selectSelectedWord(bv);
+       return i < tabular.getNumberOfCells()
+               ? tabular.getCellInset(i).getText(0)
+               : 0;
 }
 
 
@@ -2433,113 +2050,27 @@ void InsetTabular::markErased()
 }
 
 
-bool InsetTabular::nextChange(BufferView * bv, lyx::pos_type & length)
+bool InsetTabular::insetAllowed(InsetOld::Code) const
 {
-       if (the_locking_inset) {
-               if (the_locking_inset->nextChange(bv, length)) {
-                       updateLocal(bv);
-                       return true;
-               }
-               if (tabular.isLastCell(actcell))
-                       return false;
-               ++actcell;
-       }
-       InsetText & inset = tabular.getCellInset(actcell);
-       if (inset.nextChange(bv, length)) {
-               updateLocal(bv);
-               return true;
-       }
-       while (!tabular.isLastCell(actcell)) {
-               ++actcell;
-               InsetText & inset = tabular.getCellInset(actcell);
-               if (inset.nextChange(bv, length)) {
-                       updateLocal(bv);
-                       return true;
-               }
-       }
-       return false;
-}
-
-
-bool InsetTabular::searchForward(BufferView * bv, string const & str,
-                                bool cs, bool mw)
-{
-       int cell = 0;
-       if (the_locking_inset) {
-               if (the_locking_inset->searchForward(bv, str, cs, mw)) {
-                       updateLocal(bv);
-                       return true;
-               }
-               if (tabular.isLastCell(actcell))
-                       return false;
-               cell = actcell + 1;
-       }
-       InsetText & inset = tabular.getCellInset(cell);
-       if (inset.searchForward(bv, str, cs, mw)) {
-               updateLocal(bv);
-               return true;
-       }
-       while (!tabular.isLastCell(cell)) {
-               ++cell;
-               InsetText & inset = tabular.getCellInset(cell);
-               if (inset.searchForward(bv, str, cs, mw)) {
-                       updateLocal(bv);
-                       return true;
-               }
-       }
        return false;
 }
 
 
-bool InsetTabular::searchBackward(BufferView * bv, string const & str,
-                              bool cs, bool mw)
-{
-       int cell = tabular.getNumberOfCells();
-       if (the_locking_inset) {
-               if (the_locking_inset->searchBackward(bv, str, cs, mw)) {
-                       updateLocal(bv);
-                       return true;
-               }
-               cell = actcell;
-       }
-
-       while (cell) {
-               --cell;
-               InsetText & inset = tabular.getCellInset(cell);
-               if (inset.searchBackward(bv, str, cs, mw)) {
-                       updateLocal(bv);
-                       return true;
-               }
-       }
-       return false;
-}
-
-
-bool InsetTabular::insetAllowed(InsetOld::Code code) const
-{
-       if (the_locking_inset)
-               return the_locking_inset->insetAllowed(code);
-       // we return true here because if the inset is not locked someone
-       // wants to insert something in one of our insettexts and we generally
-       // allow to do so.
-       return true;
-}
-
-
 bool InsetTabular::forceDefaultParagraphs(InsetOld const * in) const
 {
-       const int cell = tabular.getCellFromInset(in, actcell);
+       const int cell = tabular.getCellFromInset(in);
 
        if (cell != -1)
                return tabular.getPWidth(cell).zero();
 
-       // well we didn't obviously find it so maybe our owner knows more
-       if (owner())
-               return owner()->forceDefaultParagraphs(in);
+       // this is a workaround for a crash (New, Insert->Tabular,
+       // Insert->FootNote)
+       if (!owner())
+               return false;
 
-       lyxerr << "If we're here there is really something strange going on!"
-              << endl;
-       return false;
+       // well we didn't obviously find it so maybe our owner knows more
+       BOOST_ASSERT(owner());
+       return owner()->forceDefaultParagraphs(in);
 }
 
 
@@ -2561,7 +2092,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                        ++cols;
                        break;
                case '\n':
-                       if ((p+1) < len)
+                       if (p + 1 < len)
                                ++rows;
                        maxCols = max(cols, maxCols);
                        cols = 1;
@@ -2575,10 +2106,12 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
        int ocol = 0;
        int row = 0;
        if (usePaste) {
-               delete paste_tabular;
-               paste_tabular = new LyXTabular(bv->buffer()->params(),
-                                              this, rows, maxCols);
-               loctab = paste_tabular;
+               paste_tabular.reset(
+                       new LyXTabular(bv->buffer()->params(), rows, maxCols)
+                       );
+
+               paste_tabular->setOwner(this);
+               loctab = paste_tabular.get();
                cols = 0;
        } else {
                loctab = &tabular;
@@ -2604,7 +2137,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                        // we can only set this if we are not too far right
                        if (cols < columns) {
                                InsetText & inset = loctab->getCellInset(cell);
-                               LyXFont const font = inset.getLyXText(bv)->
+                               LyXFont const font = inset.text_.
                                        getFont(inset.paragraphs.begin(), 0);
                                inset.setText(buf.substr(op, p - op), font);
                                ++cols;
@@ -2615,7 +2148,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                        // we can only set this if we are not too far right
                        if (cols < columns) {
                                InsetText & inset = tabular.getCellInset(cell);
-                               LyXFont const font = inset.getLyXText(bv)->
+                               LyXFont const font = inset.text_.
                                        getFont(inset.paragraphs.begin(), 0);
                                inset.setText(buf.substr(op, p - op), font);
                        }
@@ -2631,8 +2164,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
        // check for the last cell if there is no trailing '\n'
        if (cell < cells && op < len) {
                InsetText & inset = loctab->getCellInset(cell);
-               LyXFont const font = inset.getLyXText(bv)->
-                       getFont(inset.paragraphs.begin(), 0);
+               LyXFont const font = inset.text_.getFont(inset.paragraphs.begin(), 0);
                inset.setText(buf.substr(op, len - op), font);
        }
 
@@ -2644,9 +2176,10 @@ void InsetTabular::addPreview(PreviewLoader & loader) const
 {
        int const rows = tabular.rows();
        int const columns = tabular.columns();
-       for (int i = 0; i < rows; ++i)
+       for (int i = 0; i < rows; ++i) {
                for (int j = 0; j < columns; ++j)
                        tabular.getCellInset(i, j).addPreview(loader);
+       }
 }
 
 
@@ -2713,11 +2246,9 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
 
 string const InsetTabularMailer::params2string(InsetTabular const & inset)
 {
-       Buffer const & buffer = inset.buffer();
-
        ostringstream data;
        data << name_ << " \\active_cell " << inset.getActCell() << '\n';
-       inset.write(buffer, data);
+       inset.write(inset.buffer(), data);
        data << "\\end_inset\n";
        return data.str();
 }