]> git.lyx.org Git - lyx.git/blobdiff - src/insets/insettabular.C
Make buffer's member variables private; use accessor functions.
[lyx.git] / src / insets / insettabular.C
index 6067326101b7fdbe05db273ba537c1b674b13ecd..bbc4f28e2b3f849429b02fb1bc33ca30e900df3d 100644 (file)
@@ -5,61 +5,50 @@
  *
  * \author Jürgen Vigna
  *
- * Full author contact details are available in file CREDITS
+ * Full author contact details are available in file CREDITS.
  */
 
 #include <config.h>
 
 #include "insettabular.h"
-#include "insettext.h"
 
 #include "buffer.h"
 #include "BufferView.h"
-#include "lfuns.h"
 #include "debug.h"
-#include "dimension.h"
 #include "funcrequest.h"
+#include "FuncStatus.h"
 #include "gettext.h"
 #include "language.h"
-#include "LaTeXFeatures.h"
-#include "Lsstream.h"
 #include "lyx_cb.h"
-#include "lyxfunc.h"
-#include "lyxlength.h"
 #include "lyxlex.h"
-#include "lyxtext.h"
+#include "metricsinfo.h"
+#include "paragraph.h"
+#include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
 #include "undo_funcs.h"
 #include "WordLangTuple.h"
-#include "metricsinfo.h"
 
 #include "frontends/Alert.h"
-#include "frontends/Dialogs.h"
 #include "frontends/font_metrics.h"
 #include "frontends/LyXView.h"
 #include "frontends/Painter.h"
 
 #include "support/LAssert.h"
-#include "support/lstrings.h"
-
-#include <fstream>
-#include <algorithm>
-#include <cstdlib>
-#include <map>
-//#include <signal.h>
 
+#include "support/std_sstream.h"
 
 using namespace lyx::support;
+using namespace lyx::graphics;
 
-using std::vector;
-using std::ostream;
-using std::ifstream;
-using std::max;
 using std::endl;
-using std::swap;
 using std::max;
+using std::swap;
+
+using std::auto_ptr;
+using std::istringstream;
+using std::ostream;
+using std::ostringstream;
 
-namespace grfx = lyx::graphics;
 
 namespace {
 
@@ -92,7 +81,7 @@ TabularFeature tabularFeature[] =
        { LyXTabular::ALIGN_BLOCK, "align-block" },
        { LyXTabular::VALIGN_TOP, "valign-top" },
        { LyXTabular::VALIGN_BOTTOM, "valign-bottom" },
-       { LyXTabular::VALIGN_CENTER, "valign-center" },
+       { LyXTabular::VALIGN_MIDDLE, "valign-middle" },
        { LyXTabular::M_TOGGLE_LINE_TOP, "m-toggle-line-top" },
        { LyXTabular::M_TOGGLE_LINE_BOTTOM, "m-toggle-line-bottom" },
        { LyXTabular::M_TOGGLE_LINE_LEFT, "m-toggle-line-left" },
@@ -102,7 +91,7 @@ TabularFeature tabularFeature[] =
        { LyXTabular::M_ALIGN_CENTER, "m-align-center" },
        { LyXTabular::M_VALIGN_TOP, "m-valign-top" },
        { LyXTabular::M_VALIGN_BOTTOM, "m-valign-bottom" },
-       { LyXTabular::M_VALIGN_CENTER, "m-valign-center" },
+       { LyXTabular::M_VALIGN_MIDDLE, "m-valign-middle" },
        { LyXTabular::MULTICOLUMN, "multicolumn" },
        { LyXTabular::SET_ALL_LINES, "set-all-lines" },
        { LyXTabular::UNSET_ALL_LINES, "unset-all-lines" },
@@ -155,8 +144,8 @@ bool InsetTabular::hasPasteBuffer() const
 
 
 InsetTabular::InsetTabular(Buffer const & buf, int rows, int columns)
-       : tabular(buf.params, this, max(rows, 1), max(columns, 1)),
-         buffer_(&buf)
+       : tabular(buf.params(), this, max(rows, 1), max(columns, 1)),
+         buffer_(&buf), cursorx_(0), cursory_(0)
 {
        // for now make it always display as display() inset
        // just for test!!!
@@ -166,7 +155,6 @@ InsetTabular::InsetTabular(Buffer const & buf, int rows, int columns)
        oldcell = -1;
        actrow = actcell = 0;
        clearSelection();
-       need_update = INIT;
        in_reset_pos = 0;
        inset_x = 0;
        inset_y = 0;
@@ -175,8 +163,8 @@ InsetTabular::InsetTabular(Buffer const & buf, int rows, int columns)
 
 InsetTabular::InsetTabular(InsetTabular const & tab)
        : UpdatableInset(tab),
-               tabular(tab.buffer_->params, this, tab.tabular),
-               buffer_(tab.buffer_)
+               tabular(tab.buffer_->params(), this, tab.tabular),
+               buffer_(tab.buffer_), cursorx_(0), cursory_(0)
 {
        the_locking_inset = 0;
        old_locking_inset = 0;
@@ -184,7 +172,6 @@ InsetTabular::InsetTabular(InsetTabular const & tab)
        oldcell = -1;
        actrow = actcell = 0;
        clearSelection();
-       need_update = INIT;
        in_reset_pos = 0;
        inset_x = 0;
        inset_y = 0;
@@ -193,20 +180,19 @@ InsetTabular::InsetTabular(InsetTabular const & tab)
 
 InsetTabular::~InsetTabular()
 {
-       InsetTabularMailer mailer(*this);
-       mailer.hideDialog();
+       InsetTabularMailer(*this).hideDialog();
 }
 
 
-InsetBase * InsetTabular::clone() const
+auto_ptr<InsetBase> InsetTabular::clone() const
 {
-       return new InsetTabular(*this);
+       return auto_ptr<InsetBase>(new InsetTabular(*this));
 }
 
 
-Buffer const * InsetTabular::buffer() const
+Buffer const & InsetTabular::buffer() const
 {
-       return buffer_;
+       return *buffer_;
 }
 
 
@@ -223,21 +209,19 @@ void InsetTabular::buffer(Buffer * b)
 }
 
 
-void InsetTabular::write(Buffer const * buf, ostream & os) const
+void InsetTabular::write(Buffer const & buf, ostream & os) const
 {
-       os << " Tabular" << endl;
+       os << "Tabular" << endl;
        tabular.write(buf, os);
 }
 
 
-void InsetTabular::read(Buffer const * buf, LyXLex & lex)
+void InsetTabular::read(Buffer const & buf, LyXLex & lex)
 {
        bool const old_format = (lex.getString() == "\\LyXTable");
 
        tabular.read(buf, lex);
 
-       need_update = INIT;
-
        if (old_format)
                return;
 
@@ -256,32 +240,27 @@ void InsetTabular::read(Buffer const * buf, LyXLex & lex)
 
 void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
 {
-       if (mi.base.bv) {
-               calculate_dimensions_of_cells(mi.base.bv, true);
-               //lyxerr << "InsetTabular::metrics, bv: " << mi.base.bv << endl;
-               for (int i = 0; i < tabular.getNumberOfCells(); ++i) {
-                       tabular.cellinfo_of_cell(i)->inset.text_.bv_owner = mi.base.bv;
-                       tabular.cellinfo_of_cell(i)->inset.reinitLyXText();
-               }
+       //lyxerr << "InsetTabular::metrics: " << mi.base.bv << " width: " <<
+       //      mi.base.textwidth << "\n";
+       if (!mi.base.bv) {
+               lyxerr << "InsetTabular::metrics: need bv" << endl;
+               Assert(0);
        }
-                       
+
+       calculate_dimensions_of_cells(mi);
+
        dim.asc = tabular.getAscentOfRow(0);
        dim.des = tabular.getHeightOfTabular() - tabular.getAscentOfRow(0) + 1;
        dim.wid = tabular.getWidthOfTabular() + 2 * ADD_TO_TABULAR_WIDTH;
+       dim_ = dim;
 }
 
 
 void InsetTabular::draw(PainterInfo & pi, int x, int y) const
 {
-       if (nodraw()) {
-               need_update = FULL;
-               return;
-       }
+       //lyxerr << "InsetTabular::draw: " << x << " " << y << endl;
 
        BufferView * bv = pi.base.bv;
-       int i;
-       int j;
-       int nx;
 
 #if 0
        UpdatableInset::draw(pi, x, y);
@@ -295,32 +274,31 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
        x += ADD_TO_TABULAR_WIDTH;
 
        int cell = 0;
-       int cx;
        first_visible_cell = -1;
-       for (i = 0; i < tabular.rows(); ++i) {
-               nx = x;
+       for (int i = 0; i < tabular.rows(); ++i) {
+               int nx = x;
                cell = tabular.getCellNumber(i, 0);
-               if (!((y + tabular.getDescentOfRow(i)) > 0) &&
-                       (y - tabular.getAscentOfRow(i)) < pi.pain.paperHeight())
+               if (y + tabular.getDescentOfRow(i) <= 0 &&
+                         y - tabular.getAscentOfRow(i) < pi.pain.paperHeight())
                {
-               y += tabular.getDescentOfRow(i) +
-                               tabular.getAscentOfRow(i + 1) +
-                               tabular.getAdditionalHeight(i + 1);
+                       y += tabular.getDescentOfRow(i) +
+                                       tabular.getAscentOfRow(i + 1) +
+                                       tabular.getAdditionalHeight(i + 1);
                        continue;
                }
-               for (j = 0; j < tabular.columns(); ++j) {
+               for (int j = 0; j < tabular.columns(); ++j) {
                        if (nx > bv->workWidth())
                                break;
                        if (tabular.isPartOfMultiColumn(i, j))
                                continue;
-                       cx = nx + tabular.getBeginningOfTextInCell(cell);
+                       int cx = nx + tabular.getBeginningOfTextInCell(cell);
                        if (first_visible_cell < 0)
                                first_visible_cell = cell;
                        if (hasSelection()) {
                                drawCellSelection(pi.pain, nx, y, i, j, cell);
                        }
 
-                       tabular.getCellInset(cell)->draw(pi, cx, y);
+                       tabular.getCellInset(cell).draw(pi, cx, y);
                        drawCellLines(pi.pain, nx, y, i, cell);
                        nx += tabular.getWidthOfColumn(cell);
                        ++cell;
@@ -341,8 +319,6 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
                        tabular.getAscentOfRow(i + 1) +
                        tabular.getAdditionalHeight(i + 1);
        }
-
-       need_update = NONE;
 }
 
 
@@ -418,7 +394,7 @@ void InsetTabular::insetUnlock(BufferView * bv)
 {
        if (the_locking_inset) {
                the_locking_inset->insetUnlock(bv);
-               updateLocal(bv, CELL);
+               updateLocal(bv);
                the_locking_inset = 0;
        }
        actcell = 0;
@@ -426,29 +402,18 @@ void InsetTabular::insetUnlock(BufferView * bv)
        locked = false;
        if (scroll(false) || hasSelection()) {
                clearSelection();
-               if (scroll(false)) {
+               if (scroll(false))
                        scroll(bv, 0.0F);
-               }
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        }
 }
 
 
-void InsetTabular::updateLocal(BufferView * bv, UpdateCodes what) const
+void InsetTabular::updateLocal(BufferView * bv) const
 {
-       if (what == INIT) {
-               calculate_dimensions_of_cells(bv, true);
-       }
-       if (!locked && what == CELL)
-               what = FULL;
-       if (need_update < what) // only set this if it has greater update
-               need_update = what;
-       // Dirty Cast! (Lgb)
-       if (need_update != NONE) {
-               bv->updateInset(const_cast<InsetTabular *>(this));
-               if (locked)
-                       resetPos(bv);
-       }
+       bv->updateInset(this);
+       if (locked)
+               resetPos(bv);
 }
 
 
@@ -459,16 +424,16 @@ bool InsetTabular::lockInsetInInset(BufferView * bv, UpdatableInset * inset)
        if (!inset)
                return false;
        oldcell = -1;
-       if (inset == tabular.getCellInset(actcell)) {
+       if (inset == &tabular.getCellInset(actcell)) {
                lyxerr[Debug::INSETTEXT] << "OK" << endl;
-               the_locking_inset = tabular.getCellInset(actcell);
+               the_locking_inset = &tabular.getCellInset(actcell);
                resetPos(bv);
                return true;
        } else if (!the_locking_inset) {
                int const n = tabular.getNumberOfCells();
                int const id = inset->id();
                for (int i = 0; i < n; ++i) {
-                       InsetText * in = tabular.getCellInset(i);
+                       InsetText * in = &tabular.getCellInset(i);
                        if (inset == in) {
                                actcell = i;
                                the_locking_inset = in;
@@ -508,7 +473,7 @@ bool InsetTabular::unlockInsetInInset(BufferView * bv, UpdatableInset * inset,
                if (scroll(false))
                        scroll(bv, 0.0F);
 #endif
-               updateLocal(bv, CELL);
+               updateLocal(bv);
                // this has to be here otherwise we don't redraw the cell!
                the_locking_inset = 0;
                return true;
@@ -516,8 +481,7 @@ bool InsetTabular::unlockInsetInInset(BufferView * bv, UpdatableInset * inset,
        if (the_locking_inset->unlockInsetInInset(bv, inset, lr)) {
                if (inset->lyxCode() == TABULAR_CODE &&
                    !the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE)) {
-                       InsetTabularMailer mailer(*this);
-                       mailer.updateDialog(bv);
+                       InsetTabularMailer(*this).updateDialog(bv);
                        oldcell = actcell;
                }
                return true;
@@ -526,25 +490,6 @@ bool InsetTabular::unlockInsetInInset(BufferView * bv, UpdatableInset * inset,
 }
 
 
-bool InsetTabular::updateInsetInInset(BufferView * bv, Inset * inset)
-{
-       Inset * tl_inset = inset;
-       // look if this inset is really inside myself!
-       while(tl_inset->owner() && tl_inset->owner() != this)
-               tl_inset = tl_inset->owner();
-       // if we enter here it's not ower inset
-       if (!tl_inset->owner())
-               return false;
-       // we only have to do this if this is a subinset of our cells
-       if (tl_inset != inset) {
-               if (!static_cast<InsetText *>(tl_inset)->updateInsetInInset(bv, inset))
-                       return false;
-       }
-       updateLocal(bv, CELL);
-       return true;
-}
-
-
 int InsetTabular::insetInInsetY() const
 {
        if (!the_locking_inset)
@@ -560,7 +505,7 @@ UpdatableInset * InsetTabular::getLockingInset() const
 }
 
 
-UpdatableInset * InsetTabular::getFirstLockingInsetOfType(Inset::Code c)
+UpdatableInset * InsetTabular::getFirstLockingInsetOfType(InsetOld::Code c)
 {
        if (c == lyxCode())
                return this;
@@ -570,7 +515,7 @@ UpdatableInset * InsetTabular::getFirstLockingInsetOfType(Inset::Code c)
 }
 
 
-bool InsetTabular::insertInset(BufferView * bv, Inset * inset)
+bool InsetTabular::insertInset(BufferView * bv, InsetOld * inset)
 {
        if (the_locking_inset)
                return the_locking_inset->insertInset(bv, inset);
@@ -585,11 +530,10 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
 
        if (hasSelection()) {
                clearSelection();
-               updateLocal(cmd.view(), FULL);
+               updateLocal(cmd.view());
        }
 
        int const ocell = actcell;
-       int const orow = actrow;
        BufferView * bv = cmd.view();
 
        if (!locked) {
@@ -599,19 +543,7 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
                inset_y = 0;
        }
        setPos(bv, cmd.x, cmd.y);
-       if (actrow != orow)
-               updateLocal(bv, NONE);
        clearSelection();
-#if 0
-       if (cmd.button() == mouse_button::button3) {
-               if ((ocell != actcell) && the_locking_inset) {
-                       the_locking_inset->insetUnlock(bv);
-                       updateLocal(bv, CELL);
-                       the_locking_inset = 0;
-               }
-               return;
-       }
-#endif
 
        bool const inset_hit = insetHit(bv, cmd.x, cmd.y);
 
@@ -626,7 +558,7 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
 
        if (the_locking_inset) {
                the_locking_inset->insetUnlock(bv);
-               updateLocal(bv, CELL);
+               updateLocal(bv);
                the_locking_inset = 0;
        }
 
@@ -636,9 +568,7 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
        }
 
        if (inset_hit && bv->theLockingInset()) {
-               if (!bv->lockInset(static_cast<UpdatableInset*>
-                               (tabular.getCellInset(actcell))))
-               {
+               if (!bv->lockInset(&tabular.getCellInset(actcell))) {
                        lyxerr[Debug::INSETS] << "Cannot lock inset" << endl;
                        return;
                }
@@ -646,7 +576,6 @@ void InsetTabular::lfunMousePress(FuncRequest const & cmd)
                cmd1.x -= inset_x;
                cmd1.y -= inset_y;
                the_locking_inset->localDispatch(cmd1);
-               return;
        }
 }
 
@@ -684,15 +613,15 @@ void InsetTabular::lfunMouseMotion(FuncRequest const & cmd)
        setPos(bv, cmd.x, cmd.y);
        if (!hasSelection()) {
                setSelection(actcell, actcell);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        } else if (old_cell != actcell) {
                setSelection(sel_cell_start, actcell);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        }
 }
 
 
-Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
+InsetOld::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
 {
        // We need to save the value of the_locking_inset as the call to
        // the_locking_inset->localDispatch might unlock it.
@@ -754,7 +683,7 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
        result = DISPATCHED;
        // this one have priority over the locked InsetText, if we're not already
        // inside another tabular then that one get's priority!
-       if (getFirstLockingInsetOfType(Inset::TABULAR_CODE) == this) {
+       if (getFirstLockingInsetOfType(InsetOld::TABULAR_CODE) == this) {
                switch (cmd.action) {
                case LFUN_MOUSE_PRESS:
                        lfunMousePress(cmd);
@@ -776,10 +705,9 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                                movePrevCell(bv, old_locking_inset != 0);
                        clearSelection();
                        if (hs)
-                               updateLocal(bv, FULL);
-                       if (!the_locking_inset) {
+                               updateLocal(bv);
+                       if (!the_locking_inset)
                                return DISPATCHED_NOUPDATE;
-                       }
                        return result;
                // this to avoid compiler warnings.
                default:
@@ -795,11 +723,11 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        int sc = scroll();
                        resetPos(bv);
                        if (sc != scroll()) { // inset has been scrolled
-                               updateLocal(bv, FULL);
+                               updateLocal(bv);
                        }
                        return result;
                } else if (result == DISPATCHED) {
-                       updateLocal(bv, CELL);
+                       updateLocal(bv);
                        return result;
                } else if (result == FINISHED_UP) {
                        action = LFUN_UP;
@@ -835,14 +763,14 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        end = actcell;
                }
                setSelection(start, end);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
                break;
        }
        case LFUN_RIGHT:
                result = moveRight(bv);
                clearSelection();
                if (hs)
-                       updateLocal(bv, FULL);
+                       updateLocal(bv);
                break;
        case LFUN_LEFTSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
@@ -859,14 +787,14 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        end = actcell;
                }
                setSelection(start, end);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
                break;
        }
        case LFUN_LEFT:
                result = moveLeft(bv);
                clearSelection();
                if (hs)
-                       updateLocal(bv, FULL);
+                       updateLocal(bv);
                break;
        case LFUN_DOWNSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
@@ -875,23 +803,22 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                // the current cell at the beginning
                if (hasSelection()) {
                        moveDown(bv, false);
-                       if ((ocell == sel_cell_end) ||
-                           (tabular.column_of_cell(ocell)>tabular.column_of_cell(actcell)))
+                       if (ocell == sel_cell_end ||
+                           tabular.column_of_cell(ocell) > tabular.column_of_cell(actcell))
                                setSelection(start, tabular.getCellBelow(sel_cell_end));
                        else
                                setSelection(start, tabular.getLastCellBelow(sel_cell_end));
                } else {
                        setSelection(start, start);
                }
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        }
        break;
        case LFUN_DOWN:
                result = moveDown(bv, old_locking_inset != 0);
                clearSelection();
-               if (hs) {
-                       updateLocal(bv, FULL);
-               }
+               if (hs)
+                       updateLocal(bv);
                break;
        case LFUN_UPSEL: {
                int const start = hasSelection() ? sel_cell_start : actcell;
@@ -908,47 +835,39 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                } else {
                        setSelection(start, start);
                }
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        }
        break;
        case LFUN_UP:
                result = moveUp(bv, old_locking_inset != 0);
                clearSelection();
                if (hs)
-                       updateLocal(bv, FULL);
+                       updateLocal(bv);
                break;
        case LFUN_NEXT: {
-               UpdateCodes code = CURSOR;
-               if (hs) {
+               if (hs)
                        clearSelection();
-                       code = FULL;
-               }
                int column = actcol;
                unlockInsetInInset(bv, the_locking_inset);
-               if (bv->text->top_y() + bv->painter().paperHeight() <
-                   (top_baseline + tabular.getHeightOfTabular()))
+               if (bv->top_y() + bv->painter().paperHeight() <
+                   top_baseline + tabular.getHeightOfTabular())
                        {
-                               bv->scrollDocView(bv->text->top_y() + bv->painter().paperHeight());
-                               code = FULL;
+                               bv->scrollDocView(bv->top_y() + bv->painter().paperHeight());
                                actcell = tabular.getCellBelow(first_visible_cell) + column;
                        } else {
                                actcell = tabular.getFirstCellInRow(tabular.rows() - 1) + column;
                        }
                resetPos(bv);
-               updateLocal(bv, code);
+               updateLocal(bv);
                break;
        }
        case LFUN_PRIOR: {
-               UpdateCodes code = CURSOR;
-               if (hs) {
+               if (hs)
                        clearSelection();
-                       code = FULL;
-               }
                int column = actcol;
                unlockInsetInInset(bv, the_locking_inset);
                if (top_baseline < 0) {
-                       bv->scrollDocView(bv->text->top_y() - bv->painter().paperHeight());
-                       code = FULL;
+                       bv->scrollDocView(bv->top_y() - bv->painter().paperHeight());
                        if (top_baseline > 0)
                                actcell = column;
                        else
@@ -957,7 +876,7 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        actcell = column;
                }
                resetPos(bv);
-               updateLocal(bv, code);
+               updateLocal(bv);
                break;
        }
        // none of these make sense for insettabular,
@@ -985,13 +904,11 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
        case LFUN_ENDBUFSEL:
                break;
        case LFUN_LAYOUT_TABULAR: {
-               InsetTabularMailer mailer(*this);
-               mailer.showDialog(bv);
+               InsetTabularMailer(*this).showDialog(bv);
                break;
        }
        case LFUN_INSET_DIALOG_UPDATE: {
-               InsetTabularMailer mailer(*this);
-               mailer.updateDialog(bv);
+               InsetTabularMailer(*this).updateDialog(bv);
                break;
        }
        case LFUN_TABULAR_FEATURE:
@@ -1006,7 +923,7 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                if (tmpstr.empty())
                        break;
                if (insertAsciiString(bv, tmpstr, false))
-                       updateLocal(bv, INIT);
+                       updateLocal(bv);
                else
                        result = UNDISPATCHED;
                break;
@@ -1017,9 +934,9 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        break;
                // no break here!
        case LFUN_DELETE:
-               setUndo(bv, Undo::DELETE);
-               cutSelection(bv->buffer()->params);
-               updateLocal(bv, INIT);
+               recordUndo(bv, Undo::DELETE);
+               cutSelection(bv->buffer()->params());
+               updateLocal(bv);
                break;
        case LFUN_COPY:
                if (!hasSelection())
@@ -1057,7 +974,7 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                        }
                        maxCols = max(cols, maxCols);
                        delete paste_tabular;
-                       paste_tabular = new LyXTabular(bv->buffer()->params,
+                       paste_tabular = new LyXTabular(bv->buffer()->params(),
                                                       this, rows, maxCols);
                        string::size_type op = 0;
                        int cell = 0;
@@ -1100,9 +1017,9 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
        }
        case LFUN_PASTE:
                if (hasPasteBuffer()) {
-                       setUndo(bv, Undo::INSERT);
+                       recordUndo(bv, Undo::INSERT);
                        pasteSelection(bv);
-                       updateLocal(bv, INIT);
+                       updateLocal(bv);
                        break;
                }
                // ATTENTION: the function above has to be PASTE and PASTESELECTION!!!
@@ -1131,92 +1048,77 @@ Inset::RESULT InsetTabular::localDispatch(FuncRequest const & cmd)
                }
                // we try to activate the actual inset and put this event down to
                // the insets dispatch function.
-               if ((result == DISPATCHED) || the_locking_inset)
+               if (result == DISPATCHED || the_locking_inset)
                        break;
-               nodraw(true);
                if (activateCellInset(bv)) {
-                       // reset need_update setted in above function!
-                       need_update = NONE;
                        result = the_locking_inset->localDispatch(FuncRequest(bv, action, arg));
-                       if ((result == UNDISPATCHED) || (result >= FINISHED)) {
+                       if (result == UNDISPATCHED || result >= FINISHED) {
                                unlockInsetInInset(bv, the_locking_inset);
-                               nodraw(false);
                                // we need to update if this was requested before
-                               updateLocal(bv, NONE);
+                               updateLocal(bv);
                                return UNDISPATCHED;
-                       } else if (hs) {
-                               clearSelection();
-                               // so the below CELL is not set because this is higher
-                               // priority and we get a full redraw
-                               need_update = FULL;
                        }
-                       nodraw(false);
-                       updateLocal(bv, CELL);
+                       if (hs)
+                               clearSelection();
+                       updateLocal(bv);
                        return result;
                }
                break;
        }
        if (result < FINISHED) {
-               if (!the_locking_inset) {
-                       if (bv->fitCursor())
-                               updateLocal(bv, FULL);
-               }
+               if (!the_locking_inset && bv->fitCursor())
+                       updateLocal(bv);
        } else
                bv->unlockInset(this);
        return result;
 }
 
 
-int InsetTabular::latex(Buffer const * buf, ostream & os,
+int InsetTabular::latex(Buffer const & buf, ostream & os,
                        LatexRunParams const & runparams) const
 {
        return tabular.latex(buf, os, runparams);
 }
 
 
-int InsetTabular::ascii(Buffer const * buf, ostream & os, int ll) const
+int InsetTabular::ascii(Buffer const & buf, ostream & os, int ll) const
 {
        if (ll > 0)
-               return tabular.ascii(buf, os, (int)parOwner()->params().depth(),
-                                     false,0);
-       return tabular.ascii(buf, os, 0, false,0);
+               return tabular.ascii(buf, os, ownerPar(buf, this).params().depth(),
+                                     false, 0);
+       return tabular.ascii(buf, os, 0, false, 0);
 }
 
 
-int InsetTabular::linuxdoc(Buffer const * buf, ostream & os) const
+int InsetTabular::linuxdoc(Buffer const & buf, ostream & os) const
 {
-       os << "<![CDATA[";
-       int const ret = tabular.ascii(buf,os,
-                                      (int)parOwner()->params().depth(),
-                                      false, 0);
-       os << "]]>";
-       return ret;
+       return tabular.linuxdoc(buf,os);
 }
 
 
-int InsetTabular::docbook(Buffer const * buf, ostream & os, bool mixcont) const
+int InsetTabular::docbook(Buffer const & buf, ostream & os, bool mixcont) const
 {
        int ret = 0;
-       Inset * master;
+       InsetOld * master;
 
        // if the table is inside a float it doesn't need the informaltable
        // wrapper. Search for it.
-       for(master = owner();
-           master && master->lyxCode() != Inset::FLOAT_CODE;
-           master = master->owner());
+       for (master = owner();
+            master && master->lyxCode() != InsetOld::FLOAT_CODE;
+            master = master->owner());
 
        if (!master) {
                os << "<informaltable>";
                if (mixcont)
                        os << endl;
-               ret++;
+               ++ret;
        }
-       ret+= tabular.docbook(buf, os, mixcont);
+       ret += tabular.docbook(buf, os, mixcont);
        if (!master) {
                os << "</informaltable>";
                if (mixcont)
                        os << endl;
-               ret++;
+               ++ret;
        }
        return ret;
 }
@@ -1228,54 +1130,51 @@ void InsetTabular::validate(LaTeXFeatures & features) const
 }
 
 
-bool InsetTabular::calculate_dimensions_of_cells(BufferView * bv, bool reinit) const
+void InsetTabular::calculate_dimensions_of_cells(MetricsInfo & mi) const
 {
-       int cell = -1;
-       int maxAsc = 0;
-       int maxDesc = 0;
-       InsetText * inset;
-       bool changed = false;
-
-       // FIXME: since InsetText ignores this anyway, it doesn't
-       // matter what we pass it. Ugly
-       LyXFont font;
-
+#if 1
        // if we have a locking_inset we should have to check only this cell for
-       // change so I'll try this to have a boost, but who knows ;)
-       if ((need_update != INIT) &&
-           (the_locking_inset == tabular.getCellInset(actcell))) {
-               for(int i = 0; i < tabular.columns(); ++i) {
+       // change so I'll try this to have a boost, but who knows ;) (Jug?)
+       // This is _really_ important (André)
+       if (the_locking_inset == &tabular.getCellInset(actcell)) {
+               int maxAsc = 0;
+               int maxDesc = 0;
+               for (int j = 0; j < tabular.columns(); ++j) {
                        Dimension dim;
-                       MetricsInfo mi(bv, font);
-                       tabular.getCellInset(actrow, i)->metrics(mi, dim);
-                       maxAsc = max(dim.asc, maxAsc);
+                       MetricsInfo m = mi;
+                       m.base.textwidth =
+                               tabular.column_info[j].p_width.inPixels(mi.base.textwidth);
+                       tabular.getCellInset(actrow, j).metrics(m, dim);
+                       maxAsc  = max(dim.asc, maxAsc);
                        maxDesc = max(dim.des, maxDesc);
                }
-               changed = tabular.setWidthOfCell(actcell, the_locking_inset->width(bv, font));
-               changed = tabular.setAscentOfRow(actrow, maxAsc + ADD_TO_HEIGHT) || changed;
-               changed = tabular.setDescentOfRow(actrow, maxDesc + ADD_TO_HEIGHT) || changed;
-               return changed;
+               tabular.setWidthOfCell(actcell, the_locking_inset->width());
+               tabular.setAscentOfRow(actrow, maxAsc + ADD_TO_HEIGHT);
+               tabular.setDescentOfRow(actrow, maxDesc + ADD_TO_HEIGHT);
+               return;
        }
+#endif
+
+       int cell = -1;
        for (int i = 0; i < tabular.rows(); ++i) {
-               maxAsc = 0;
-               maxDesc = 0;
+               int maxAsc = 0;
+               int maxDesc = 0;
                for (int j = 0; j < tabular.columns(); ++j) {
-                       if (tabular.isPartOfMultiColumn(i,j))
+                       if (tabular.isPartOfMultiColumn(i, j))
                                continue;
                        ++cell;
                        Dimension dim;
-                       MetricsInfo mi(bv, font);
-                       tabular.getCellInset(cell)->metrics(mi, dim);
-                       maxAsc = max(maxAsc, dim.asc);
+                       MetricsInfo m = mi;
+                       m.base.textwidth =
+                               tabular.column_info[j].p_width.inPixels(mi.base.textwidth);
+                       tabular.getCellInset(cell).metrics(m, dim);
+                       maxAsc  = max(maxAsc, dim.asc);
                        maxDesc = max(maxDesc, dim.des);
-                       changed = tabular.setWidthOfCell(cell, dim.wid) || changed;
+                       tabular.setWidthOfCell(cell, dim.wid);
                }
-               changed = tabular.setAscentOfRow(i, maxAsc + ADD_TO_HEIGHT) || changed;
-               changed = tabular.setDescentOfRow(i, maxDesc + ADD_TO_HEIGHT) || changed;
+               tabular.setAscentOfRow(i, maxAsc + ADD_TO_HEIGHT);
+               tabular.setDescentOfRow(i, maxDesc + ADD_TO_HEIGHT);
        }
-       if (changed)
-               tabular.reinit();
-       return changed;
 }
 
 
@@ -1286,8 +1185,8 @@ void InsetTabular::getCursor(BufferView & bv, int & x, int & y) const
                return;
        }
 
-       x = cursor_.x();
-       y = cursor_.y() + InsetTabular::y();
+       x = cursorx_;
+       y = cursory_ + InsetTabular::y();
 
        // Fun stuff
        int desc = tabular.getDescentOfRow(actrow);
@@ -1305,56 +1204,52 @@ void InsetTabular::getCursorPos(BufferView * bv, int & x, int & y) const
                the_locking_inset->getCursorPos(bv, x, y);
                return;
        }
-       x = cursor_.x() - top_x;
-       y = cursor_.y();
+       x = cursorx_ - top_x;
+       y = cursory_;
 }
 
 
 void InsetTabular::fitInsetCursor(BufferView * bv) const
 {
        if (the_locking_inset) {
-               int old_top_y = bv->text->top_y();
                the_locking_inset->fitInsetCursor(bv);
-               if (old_top_y != bv->text->top_y())
-                       need_update = FULL;
                return;
        }
-       LyXFont font;
 
+       LyXFont font;
        int const asc = font_metrics::maxAscent(font);
        int const desc = font_metrics::maxDescent(font);
        resetPos(bv);
 
-       if (bv->fitLockedInsetCursor(cursor_.x(), cursor_.y(), asc, desc))
-               need_update = FULL;
+       bv->fitLockedInsetCursor(cursorx_, cursory_, asc, desc);
 }
 
 
 void InsetTabular::setPos(BufferView * bv, int x, int y) const
 {
-       cursor_.y(0);
-
+       cursory_ = 0;
        actcell = actrow = actcol = 0;
        int ly = tabular.getDescentOfRow(actrow);
 
        // first search the right row
-       while ((ly < y) && ((actrow+1) < tabular.rows())) {
-               cursor_.y(cursor_.y() + tabular.getDescentOfRow(actrow) +
+       while (ly < y && actrow + 1 < tabular.rows()) {
+               cursory_ += tabular.getDescentOfRow(actrow) +
                                 tabular.getAscentOfRow(actrow + 1) +
-                                tabular.getAdditionalHeight(actrow + 1));
+                                tabular.getAdditionalHeight(actrow + 1);
                ++actrow;
-               ly = cursor_.y() + tabular.getDescentOfRow(actrow);
+               ly = cursory_ + tabular.getDescentOfRow(actrow);
        }
        actcell = tabular.getCellNumber(actrow, actcol);
 
        // now search the right column
        int lx = tabular.getWidthOfColumn(actcell) -
                tabular.getAdditionalWidth(actcell);
-       for (; !tabular.isLastCellInRow(actcell) && lx < x; ++actcell) {
+
+       for (; !tabular.isLastCellInRow(actcell) && lx < x; ++actcell)
                lx += tabular.getWidthOfColumn(actcell + 1)
                        + tabular.getAdditionalWidth(actcell);
-       }
-       cursor_.x(lx - tabular.getWidthOfColumn(actcell) + top_x + 2);
+
+       cursorx_ = lx - tabular.getWidthOfColumn(actcell) + top_x + 2;
        resetPos(bv);
 }
 
@@ -1366,9 +1261,9 @@ int InsetTabular::getCellXPos(int cell) const
        for (; !tabular.isFirstCellInRow(c); --c)
                ;
        int lx = tabular.getWidthOfColumn(cell);
-       for (; c < cell; ++c) {
+       for (; c < cell; ++c)
                lx += tabular.getWidthOfColumn(c);
-       }
+
        return (lx - tabular.getWidthOfColumn(cell) + top_x);
 }
 
@@ -1385,78 +1280,76 @@ void InsetTabular::resetPos(BufferView * bv) const
        int cell = 0;
        actcol = tabular.column_of_cell(actcell);
        actrow = 0;
-       cursor_.y(0);
-       for (; (cell < actcell) && !tabular.isLastRow(cell); ++cell) {
+       cursory_ = 0;
+       for (; cell < actcell && !tabular.isLastRow(cell); ++cell) {
                if (tabular.isLastCellInRow(cell)) {
-                       cursor_.y(cursor_.y() + tabular.getDescentOfRow(actrow) +
+                       cursory_ += tabular.getDescentOfRow(actrow) +
                                         tabular.getAscentOfRow(actrow + 1) +
-                                        tabular.getAdditionalHeight(actrow + 1));
+                                        tabular.getAdditionalHeight(actrow + 1);
                        ++actrow;
                }
        }
-       if (!locked || nodraw()) {
+       if (!locked) {
                if (the_locking_inset)
-                       inset_y = cursor_.y();
+                       inset_y = cursory_;
                return;
        }
        // we need this only from here on!!!
        ++in_reset_pos;
        static int const offset = ADD_TO_TABULAR_WIDTH + 2;
        int new_x = getCellXPos(actcell);
-       int old_x = cursor_.x();
+       int old_x = cursorx_;
        new_x += offset;
-       cursor_.x(new_x);
+       cursorx_ = new_x;
 //    cursor.x(getCellXPos(actcell) + offset);
-       if ((actcol < tabular.columns() - 1) && scroll(false) &&
-               (tabular.getWidthOfTabular() < bv->workWidth()-20))
+       if (actcol < tabular.columns() - 1 && scroll(false) &&
+               tabular.getWidthOfTabular() < bv->workWidth()-20)
        {
                scroll(bv, 0.0F);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
        } else if (the_locking_inset &&
-                (tabular.getWidthOfColumn(actcell) > bv->workWidth()-20))
+                tabular.getWidthOfColumn(actcell) > bv->workWidth() - 20)
        {
-               int xx = cursor_.x() - offset + bv->text->getRealCursorX();
-               if (xx > (bv->workWidth()-20)) {
+               int xx = cursorx_ - offset + bv->text->getRealCursorX();
+               if (xx > bv->workWidth()-20) {
                        scroll(bv, -(xx - bv->workWidth() + 60));
-                       updateLocal(bv, FULL);
+                       updateLocal(bv);
                } else if (xx < 20) {
                        if (xx < 0)
                                xx = -xx + 60;
                        else
                                xx = 60;
                        scroll(bv, xx);
-                       updateLocal(bv, FULL);
+                       updateLocal(bv);
                }
-       } else if ((cursor_.x() - offset) > 20 &&
-                  (cursor_.x() - offset + tabular.getWidthOfColumn(actcell))
-                  > (bv->workWidth() - 20)) {
+       } else if (cursorx_ - offset > 20 &&
+                  cursorx_ - offset + tabular.getWidthOfColumn(actcell)
+                  > bv->workWidth() - 20) {
                scroll(bv, -tabular.getWidthOfColumn(actcell) - 20);
-               updateLocal(bv, FULL);
-       } else if ((cursor_.x() - offset) < 20) {
-               scroll(bv, 20 - cursor_.x() + offset);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
+       } else if (cursorx_ - offset < 20) {
+               scroll(bv, 20 - cursorx_ + offset);
+               updateLocal(bv);
        } else if (scroll() && top_x > 20 &&
-                  (top_x + tabular.getWidthOfTabular()) > (bv->workWidth() - 20)) {
-               scroll(bv, old_x - cursor_.x());
-               updateLocal(bv, FULL);
+                  (top_x + tabular.getWidthOfTabular()) > bv->workWidth() - 20) {
+               scroll(bv, old_x - cursorx_);
+               updateLocal(bv);
        }
        if (the_locking_inset) {
-               inset_x = cursor_.x() - top_x + tabular.getBeginningOfTextInCell(actcell);
-               inset_y = cursor_.y();
+               inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
+               inset_y = cursory_;
        }
        if ((!the_locking_inset ||
             !the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE)) &&
            actcell != oldcell) {
-               InsetTabular * inset = const_cast<InsetTabular *>(this);
-               InsetTabularMailer mailer(*inset);
-               mailer.updateDialog(bv);
+               InsetTabularMailer(*this).updateDialog(bv);
                oldcell = actcell;
        }
        in_reset_pos = 0;
 }
 
 
-Inset::RESULT InsetTabular::moveRight(BufferView * bv, bool lock)
+InsetOld::RESULT InsetTabular::moveRight(BufferView * bv, bool lock)
 {
        if (lock && !old_locking_inset) {
                if (activateCellInset(bv))
@@ -1474,7 +1367,7 @@ Inset::RESULT InsetTabular::moveRight(BufferView * bv, bool lock)
 }
 
 
-Inset::RESULT InsetTabular::moveLeft(BufferView * bv, bool lock)
+InsetOld::RESULT InsetTabular::moveLeft(BufferView * bv, bool lock)
 {
        bool moved = isRightToLeft(bv) ? moveNextCell(bv) : movePrevCell(bv);
        if (!moved)
@@ -1488,7 +1381,7 @@ Inset::RESULT InsetTabular::moveLeft(BufferView * bv, bool lock)
 }
 
 
-Inset::RESULT InsetTabular::moveUp(BufferView * bv, bool lock)
+InsetOld::RESULT InsetTabular::moveUp(BufferView * bv, bool lock)
 {
        int const ocell = actcell;
        actcell = tabular.getCellAbove(actcell);
@@ -1500,7 +1393,7 @@ Inset::RESULT InsetTabular::moveUp(BufferView * bv, bool lock)
                int y = 0;
                if (old_locking_inset) {
                        old_locking_inset->getCursorPos(bv, x, y);
-                       x -= cursor_.x() + tabular.getBeginningOfTextInCell(actcell);
+                       x -= cursorx_ + tabular.getBeginningOfTextInCell(actcell);
                }
                if (activateCellInset(bv, x, 0))
                        return DISPATCHED;
@@ -1509,7 +1402,7 @@ Inset::RESULT InsetTabular::moveUp(BufferView * bv, bool lock)
 }
 
 
-Inset::RESULT InsetTabular::moveDown(BufferView * bv, bool lock)
+InsetOld::RESULT InsetTabular::moveDown(BufferView * bv, bool lock)
 {
        int const ocell = actcell;
        actcell = tabular.getCellBelow(actcell);
@@ -1521,7 +1414,7 @@ Inset::RESULT InsetTabular::moveDown(BufferView * bv, bool lock)
                int y = 0;
                if (old_locking_inset) {
                        old_locking_inset->getCursorPos(bv, x, y);
-                       x -= cursor_.x() + tabular.getBeginningOfTextInCell(actcell);
+                       x -= cursorx_ + tabular.getBeginningOfTextInCell(actcell);
                }
                if (activateCellInset(bv, x, 0))
                        return DISPATCHED;
@@ -1550,8 +1443,8 @@ bool InsetTabular::moveNextCell(BufferView * bv, bool lock)
                ++actcell;
        }
        if (lock) {
-               bool rtl = tabular.getCellInset(actcell)->paragraphs.begin()->
-                       isRightToLeftPar(bv->buffer()->params);
+               bool rtl = tabular.getCellInset(actcell).paragraphs.begin()->
+                       isRightToLeftPar(bv->buffer()->params());
                activateCellInset(bv, 0, 0, mouse_button::none, !rtl);
        }
        resetPos(bv);
@@ -1579,8 +1472,8 @@ bool InsetTabular::movePrevCell(BufferView * bv, bool lock)
                --actcell;
        }
        if (lock) {
-               bool rtl = tabular.getCellInset(actcell)->paragraphs.begin()->
-                       isRightToLeftPar(bv->buffer()->params);
+               bool rtl = tabular.getCellInset(actcell).paragraphs.begin()->
+                       isRightToLeftPar(bv->buffer()->params());
                activateCellInset(bv, 0, 0, mouse_button::none, !rtl);
        }
        resetPos(bv);
@@ -1595,7 +1488,7 @@ void InsetTabular::setFont(BufferView * bv, LyXFont const & font, bool tall,
                setSelection(0, tabular.getNumberOfCells() - 1);
        }
        if (hasSelection()) {
-               setUndo(bv, Undo::EDIT);
+               recordUndo(bv, Undo::ATOMIC);
                bool const frozen = undo_frozen;
                if (!frozen)
                        freezeUndo();
@@ -1605,16 +1498,15 @@ void InsetTabular::setFont(BufferView * bv, LyXFont const & font, bool tall,
                int sel_col_start;
                int sel_col_end;
                getSelection(sel_row_start, sel_row_end, sel_col_start, sel_col_end);
-               for(int i = sel_row_start; i <= sel_row_end; ++i) {
-                       for(int j = sel_col_start; j <= sel_col_end; ++j) {
-                               tabular.getCellInset(i, j)->setFont(bv, font, tall, true);
-                       }
-               }
+               for(int i = sel_row_start; i <= sel_row_end; ++i)
+                       for(int j = sel_col_start; j <= sel_col_end; ++j)
+                               tabular.getCellInset(i, j).setFont(bv, font, tall, true);
+
                if (!frozen)
                        unFreezeUndo();
                if (selectall)
                        clearSelection();
-               updateLocal(bv, INIT);
+               updateLocal(bv);
        }
        if (the_locking_inset)
                the_locking_inset->setFont(bv, font, tall);
@@ -1681,43 +1573,52 @@ void InsetTabular::tabularFeatures(BufferView * bv,
        LyXTabular::VAlignment setVAlign = LyXTabular::LYX_VALIGN_TOP;
 
        switch (feature) {
+
        case LyXTabular::M_ALIGN_LEFT:
        case LyXTabular::ALIGN_LEFT:
                setAlign = LYX_ALIGN_LEFT;
                break;
+
        case LyXTabular::M_ALIGN_RIGHT:
        case LyXTabular::ALIGN_RIGHT:
                setAlign = LYX_ALIGN_RIGHT;
                break;
+
        case LyXTabular::M_ALIGN_CENTER:
        case LyXTabular::ALIGN_CENTER:
                setAlign = LYX_ALIGN_CENTER;
                break;
+
        case LyXTabular::ALIGN_BLOCK:
                setAlign = LYX_ALIGN_BLOCK;
                break;
+
        case LyXTabular::M_VALIGN_TOP:
        case LyXTabular::VALIGN_TOP:
                setVAlign = LyXTabular::LYX_VALIGN_TOP;
                break;
+
        case LyXTabular::M_VALIGN_BOTTOM:
        case LyXTabular::VALIGN_BOTTOM:
                setVAlign = LyXTabular::LYX_VALIGN_BOTTOM;
                break;
-       case LyXTabular::M_VALIGN_CENTER:
-       case LyXTabular::VALIGN_CENTER:
-               setVAlign = LyXTabular::LYX_VALIGN_CENTER;
+
+       case LyXTabular::M_VALIGN_MIDDLE:
+       case LyXTabular::VALIGN_MIDDLE:
+               setVAlign = LyXTabular::LYX_VALIGN_MIDDLE;
                break;
+
        default:
                break;
        }
+
        if (hasSelection()) {
                getSelection(sel_row_start, sel_row_end, sel_col_start, sel_col_end);
        } else {
                sel_col_start = sel_col_end = tabular.column_of_cell(actcell);
                sel_row_start = sel_row_end = tabular.row_of_cell(actcell);
        }
-       setUndo(bv, Undo::FINISH);
+       recordUndo(bv, Undo::ATOMIC);
 
        int row =  tabular.row_of_cell(actcell);
        int column = tabular.column_of_cell(actcell);
@@ -1725,6 +1626,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
        LyXTabular::ltType ltt;
 
        switch (feature) {
+
        case LyXTabular::SET_PWIDTH:
        {
                LyXLength const vallen(value);
@@ -1737,13 +1639,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        // the insettext of the active cell (if any)
                        // until later (see InsetText::do_resize)
                        unlockInsetInInset(bv, the_locking_inset);
-
-                       int cell;
-                       for (int i = 0; i < tabular.rows(); ++i) {
-                               cell = tabular.getCellNumber(i,column);
-                               tabular.getCellInset(cell)->resizeLyXText(bv);
-                       }
-                       updateLocal(bv, INIT);
+                       bv->update();
                }
 
                if (vallen.zero()
@@ -1752,8 +1648,9 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                else if (!vallen.zero()
                         && tabular.getAlignment(actcell, true) != LYX_ALIGN_BLOCK)
                        tabularFeatures(bv, LyXTabular::ALIGN_BLOCK, string());
+               break;
        }
-       break;
+
        case LyXTabular::SET_MPWIDTH:
        {
                LyXLength const vallen(value);
@@ -1766,32 +1663,27 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        // the insettext of the active cell (if any)
                        // until later (see InsetText::do_resize)
                        unlockInsetInInset(bv, the_locking_inset);
-
-                       for (int i = 0; i < tabular.rows(); ++i) {
-                               tabular.getCellInset(tabular.getCellNumber(i, column))->
-                                       resizeLyXText(bv);
-                       }
-                       updateLocal(bv, INIT);
+                       updateLocal(bv);
                }
        }
        break;
        case LyXTabular::SET_SPECIAL_COLUMN:
        case LyXTabular::SET_SPECIAL_MULTI:
                tabular.setAlignSpecial(actcell,value,feature);
-               updateLocal(bv, FULL);
+               updateLocal(bv);
                break;
        case LyXTabular::APPEND_ROW:
                // append the row into the tabular
                unlockInsetInInset(bv, the_locking_inset);
-               tabular.appendRow(bv->buffer()->params, actcell);
-               updateLocal(bv, INIT);
+               tabular.appendRow(bv->buffer()->params(), actcell);
+               updateLocal(bv);
                break;
        case LyXTabular::APPEND_COLUMN:
                // append the column into the tabular
                unlockInsetInInset(bv, the_locking_inset);
-               tabular.appendColumn(bv->buffer()->params, actcell);
+               tabular.appendColumn(bv->buffer()->params(), actcell);
                actcell = tabular.getCellNumber(row, column);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        case LyXTabular::DELETE_ROW:
                unlockInsetInInset(bv, the_locking_inset);
@@ -1802,7 +1694,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        --sel_row_start;
                actcell = tabular.getCellNumber(sel_row_start, column);
                clearSelection();
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        case LyXTabular::DELETE_COLUMN:
                unlockInsetInInset(bv, the_locking_inset);
@@ -1813,7 +1705,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        --sel_col_start;
                actcell = tabular.getCellNumber(row, sel_col_start);
                clearSelection();
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        case LyXTabular::M_TOGGLE_LINE_TOP:
                flag = false;
@@ -1825,7 +1717,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                tabular.setTopLine(
                                        tabular.getCellNumber(i, j),
                                        lineSet, flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        }
 
@@ -1840,7 +1732,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i, j),
                                        lineSet,
                                        flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        }
 
@@ -1855,7 +1747,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i,j),
                                        lineSet,
                                        flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        }
 
@@ -1870,7 +1762,7 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i,j),
                                        lineSet,
                                        flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        }
 
@@ -1888,24 +1780,25 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                                        tabular.getCellNumber(i, j),
                                        setAlign,
                                        flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
+
        case LyXTabular::M_VALIGN_TOP:
        case LyXTabular::M_VALIGN_BOTTOM:
-       case LyXTabular::M_VALIGN_CENTER:
+       case LyXTabular::M_VALIGN_MIDDLE:
                flag = false;
        case LyXTabular::VALIGN_TOP:
        case LyXTabular::VALIGN_BOTTOM:
-       case LyXTabular::VALIGN_CENTER:
+       case LyXTabular::VALIGN_MIDDLE:
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setVAlignment(
                                        tabular.getCellNumber(i, j),
                                        setVAlign, flag);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
-       case LyXTabular::MULTICOLUMN:
-       {
+
+       case LyXTabular::MULTICOLUMN: {
                if (sel_row_start != sel_row_end) {
 #ifdef WITH_WARNINGS
 #warning Need I say it ? This is horrible.
@@ -1917,13 +1810,11 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                // just multicol for one Single Cell
                if (!hasSelection()) {
                        // check wether we are completly in a multicol
-                       if (tabular.isMultiColumn(actcell)) {
+                       if (tabular.isMultiColumn(actcell))
                                tabular.unsetMultiColumn(actcell);
-                               updateLocal(bv, INIT);
-                       } else {
+                       else
                                tabular.setMultiColumn(bv->buffer(), actcell, 1);
-                               updateLocal(bv, CELL);
-                       }
+                       updateLocal(bv);
                        break;
                }
                // we have a selection so this means we just add all this
@@ -1941,9 +1832,10 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                tabular.setMultiColumn(bv->buffer(), s_start, s_end - s_start + 1);
                actcell = s_start;
                clearSelection();
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
        }
+
        case LyXTabular::SET_ALL_LINES:
                setLines = true;
        case LyXTabular::UNSET_ALL_LINES:
@@ -1951,176 +1843,135 @@ void InsetTabular::tabularFeatures(BufferView * bv,
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setAllLines(
                                        tabular.getCellNumber(i,j), setLines);
-               updateLocal(bv, INIT);
+               updateLocal(bv);
                break;
+
        case LyXTabular::SET_LONGTABULAR:
                tabular.setLongTabular(true);
-               updateLocal(bv, INIT); // because this toggles displayed
+               updateLocal(bv); // because this toggles displayed
                break;
+
        case LyXTabular::UNSET_LONGTABULAR:
                tabular.setLongTabular(false);
-               updateLocal(bv, INIT); // because this toggles displayed
+               updateLocal(bv); // because this toggles displayed
                break;
+
        case LyXTabular::SET_ROTATE_TABULAR:
                tabular.setRotateTabular(true);
                break;
+
        case LyXTabular::UNSET_ROTATE_TABULAR:
                tabular.setRotateTabular(false);
                break;
+
        case LyXTabular::SET_ROTATE_CELL:
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j<=sel_col_end; ++j)
                                tabular.setRotateCell(
-                                       tabular.getCellNumber(i, j),
-                                       true);
+                                       tabular.getCellNumber(i, j), true);
                break;
+
        case LyXTabular::UNSET_ROTATE_CELL:
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setRotateCell(
                                        tabular.getCellNumber(i, j), false);
                break;
-       case LyXTabular::SET_USEBOX:
-       {
+
+       case LyXTabular::SET_USEBOX: {
                LyXTabular::BoxType val = LyXTabular::BoxType(strToInt(value));
                if (val == tabular.getUsebox(actcell))
                        val = LyXTabular::BOX_NONE;
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
-                               tabular.setUsebox(
-                                       tabular.getCellNumber(i, j), val);
+                               tabular.setUsebox(tabular.getCellNumber(i, j), val);
                break;
        }
+
        case LyXTabular::UNSET_LTFIRSTHEAD:
                flag = false;
        case LyXTabular::SET_LTFIRSTHEAD:
-               (void)tabular.getRowOfLTFirstHead(row, ltt);
+               tabular.getRowOfLTFirstHead(row, ltt);
                checkLongtableSpecial(ltt, value, flag);
                tabular.setLTHead(row, flag, ltt, true);
                break;
+
        case LyXTabular::UNSET_LTHEAD:
                flag = false;
        case LyXTabular::SET_LTHEAD:
-               (void)tabular.getRowOfLTHead(row, ltt);
+               tabular.getRowOfLTHead(row, ltt);
                checkLongtableSpecial(ltt, value, flag);
                tabular.setLTHead(row, flag, ltt, false);
                break;
+
        case LyXTabular::UNSET_LTFOOT:
                flag = false;
        case LyXTabular::SET_LTFOOT:
-               (void)tabular.getRowOfLTFoot(row, ltt);
+               tabular.getRowOfLTFoot(row, ltt);
                checkLongtableSpecial(ltt, value, flag);
                tabular.setLTFoot(row, flag, ltt, false);
                break;
+
        case LyXTabular::UNSET_LTLASTFOOT:
                flag = false;
        case LyXTabular::SET_LTLASTFOOT:
-               (void)tabular.getRowOfLTLastFoot(row, ltt);
+               tabular.getRowOfLTLastFoot(row, ltt);
                checkLongtableSpecial(ltt, value, flag);
                tabular.setLTFoot(row, flag, ltt, true);
                break;
-       case LyXTabular::SET_LTNEWPAGE:
-       {
+
+       case LyXTabular::SET_LTNEWPAGE: {
                bool what = !tabular.getLTNewPage(row);
                tabular.setLTNewPage(row, what);
                break;
        }
+
        // dummy stuff just to avoid warnings
        case LyXTabular::LAST_ACTION:
                break;
        }
 
-       InsetTabularMailer mailer(*this);
-       mailer.updateDialog(bv);
+       InsetTabularMailer(*this).updateDialog(bv);
 }
 
 
-bool InsetTabular::activateCellInset(BufferView * bv, int x, int y, mouse_button::state button,
-                                    bool behind)
+bool InsetTabular::activateCellInset(BufferView * bv, int x, int y,
+       mouse_button::state button, bool behind)
 {
-       UpdatableInset * inset =
-               static_cast<UpdatableInset*>(tabular.getCellInset(actcell));
-       LyXFont font(LyXFont::ALL_SANE);
+       UpdatableInset & inset = tabular.getCellInset(actcell);
        if (behind) {
-               x = inset->x() + inset->width(bv, font);
-               y = inset->descent(bv, font);
+#warning metrics?
+               x = inset.x() + inset.width();
+               y = inset.descent();
        }
-       //inset_x = cursor.x() - top_x + tabular.getBeginningOfTextInCell(actcell);
-       //inset_y = cursor.y();
-       inset->localDispatch(FuncRequest(bv, LFUN_INSET_EDIT, x,  y, button));
+       //inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
+       //inset_y = cursory_;
+       inset.localDispatch(FuncRequest(bv, LFUN_INSET_EDIT, x,  y, button));
        if (!the_locking_inset)
                return false;
-       updateLocal(bv, CELL);
-       return (the_locking_inset != 0);
+       updateLocal(bv);
+       return the_locking_inset;
 }
 
 
 bool InsetTabular::activateCellInsetAbs(BufferView * bv, int x, int y,
                                        mouse_button::state button)
 {
-       inset_x = cursor_.x()
-               - top_x + tabular.getBeginningOfTextInCell(actcell);
-       inset_y = cursor_.y();
+       inset_x = cursorx_ - top_x + tabular.getBeginningOfTextInCell(actcell);
+       inset_y = cursory_;
        return activateCellInset(bv, x - inset_x, y - inset_y, button);
 }
 
 
 bool InsetTabular::insetHit(BufferView *, int x, int) const
 {
-       return (x + top_x)
-               > (cursor_.x() + tabular.getBeginningOfTextInCell(actcell));
+       return x + top_x > cursorx_ + tabular.getBeginningOfTextInCell(actcell);
 }
 
 
-// This returns paperWidth() if the cell-width is unlimited or the width
-// in pixels if we have a pwidth for this cell.
-int InsetTabular::getMaxWidthOfCell(BufferView * bv, int cell) const
+void InsetTabular::deleteLyXText(BufferView * /*bv*/, bool /*recursive*/) const
 {
-       LyXLength const len = tabular.getPWidth(cell);
-
-       if (len.zero())
-               return -1;
-       return len.inPixels(latexTextWidth(bv));
-}
-
-
-int InsetTabular::getMaxWidth(BufferView * bv,
-                             UpdatableInset const * inset) const
-{
-       int cell = tabular.getCellFromInset(inset, actcell);
-
-       if (cell == -1) {
-               lyxerr << "Own inset not found, shouldn't really happen!"
-                      << endl;
-               return -1;
-       }
-
-       int w = getMaxWidthOfCell(bv, cell);
-       if (w > 0) {
-               // because the inset then subtracts it's top_x and owner->x()
-               w += (inset->x() - top_x);
-       }
-
-       return w;
-}
-
-
-void InsetTabular::deleteLyXText(BufferView * bv, bool recursive) const
-{
-       resizeLyXText(bv, recursive);
-}
-
-
-void InsetTabular::resizeLyXText(BufferView * bv, bool force) const
-{
-       if (force) {
-               for(int i = 0; i < tabular.rows(); ++i) {
-                       for(int j = 0; j < tabular.columns(); ++j) {
-                               tabular.getCellInset(i, j)->resizeLyXText(bv, true);
-                       }
-               }
-       }
-       need_update = FULL;
+       //resizeLyXText(bv, recursive);
 }
 
 
@@ -2129,26 +1980,14 @@ LyXText * InsetTabular::getLyXText(BufferView const * bv,
 {
        if (the_locking_inset)
                return the_locking_inset->getLyXText(bv, recursive);
-#if 0
-       // if we're locked lock the actual insettext and return it's LyXText!!!
-       if (locked) {
-               UpdatableInset * inset =
-                       static_cast<UpdatableInset*>(tabular.getCellInset(actcell));
-               inset->edit(const_cast<BufferView *>(bv), 0,  0, 0);
-               return the_locking_inset->getLyXText(bv, recursive);
-       }
-#endif
-       return Inset::getLyXText(bv, recursive);
+       return InsetOld::getLyXText(bv, recursive);
 }
 
 
 bool InsetTabular::showInsetDialog(BufferView * bv) const
 {
-       if (!the_locking_inset || !the_locking_inset->showInsetDialog(bv)) {
-               InsetTabular * tmp = const_cast<InsetTabular *>(this);
-               InsetTabularMailer mailer(*tmp);
-               mailer.showDialog(bv);
-       }
+       if (!the_locking_inset || !the_locking_inset->showInsetDialog(bv))
+               InsetTabularMailer(*this).showDialog(bv);
        return true;
 }
 
@@ -2156,16 +1995,14 @@ bool InsetTabular::showInsetDialog(BufferView * bv) const
 void InsetTabular::openLayoutDialog(BufferView * bv) const
 {
        if (the_locking_inset) {
-               InsetTabular * i = static_cast<InsetTabular *>
+               InsetTabular * inset = static_cast<InsetTabular *>
                        (the_locking_inset->getFirstLockingInsetOfType(TABULAR_CODE));
-               if (i) {
-                       i->openLayoutDialog(bv);
+               if (inset) {
+                       inset->openLayoutDialog(bv);
                        return;
                }
        }
-       InsetTabular * tmp = const_cast<InsetTabular *>(this);
-       InsetTabularMailer mailer(*tmp);
-       mailer.showDialog(bv);
+       InsetTabularMailer(*this).showDialog(bv);
 }
 
 
@@ -2193,7 +2030,8 @@ FuncStatus InsetTabular::getStatus(string const & what) const
                return status.unknown(true);
        }
 
-       string const argument = ltrim(what.substr(tabularFeature[i].feature.length()));
+       string const argument
+               = ltrim(what.substr(tabularFeature[i].feature.length()));
 
        int sel_row_start;
        int sel_row_end;
@@ -2201,11 +2039,10 @@ FuncStatus InsetTabular::getStatus(string const & what) const
        LyXTabular::ltType dummyltt;
        bool flag = true;
 
-       if (hasSelection()) {
+       if (hasSelection())
                getSelection(sel_row_start, sel_row_end, dummy, dummy);
-       } else {
+       else
                sel_row_start = sel_row_end = tabular.row_of_cell(actcell);
-       }
 
        switch (action) {
        case LyXTabular::SET_PWIDTH:
@@ -2223,96 +2060,120 @@ FuncStatus InsetTabular::getStatus(string const & what) const
        case LyXTabular::MULTICOLUMN:
                status.setOnOff(tabular.isMultiColumn(actcell));
                break;
+
        case LyXTabular::M_TOGGLE_LINE_TOP:
                flag = false;
        case LyXTabular::TOGGLE_LINE_TOP:
                status.setOnOff(tabular.topLine(actcell, flag));
                break;
+
        case LyXTabular::M_TOGGLE_LINE_BOTTOM:
                flag = false;
        case LyXTabular::TOGGLE_LINE_BOTTOM:
                status.setOnOff(tabular.bottomLine(actcell, flag));
                break;
+
        case LyXTabular::M_TOGGLE_LINE_LEFT:
                flag = false;
        case LyXTabular::TOGGLE_LINE_LEFT:
                status.setOnOff(tabular.leftLine(actcell, flag));
                break;
+
        case LyXTabular::M_TOGGLE_LINE_RIGHT:
                flag = false;
        case LyXTabular::TOGGLE_LINE_RIGHT:
                status.setOnOff(tabular.rightLine(actcell, flag));
                break;
+
        case LyXTabular::M_ALIGN_LEFT:
                flag = false;
        case LyXTabular::ALIGN_LEFT:
                status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_LEFT);
                break;
+
        case LyXTabular::M_ALIGN_RIGHT:
                flag = false;
        case LyXTabular::ALIGN_RIGHT:
                status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_RIGHT);
                break;
+
        case LyXTabular::M_ALIGN_CENTER:
                flag = false;
        case LyXTabular::ALIGN_CENTER:
                status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_CENTER);
                break;
+
        case LyXTabular::ALIGN_BLOCK:
                status.disabled(tabular.getPWidth(actcell).zero());
                status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_BLOCK);
                break;
+
        case LyXTabular::M_VALIGN_TOP:
                flag = false;
        case LyXTabular::VALIGN_TOP:
                status.setOnOff(tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_TOP);
                break;
+
        case LyXTabular::M_VALIGN_BOTTOM:
                flag = false;
        case LyXTabular::VALIGN_BOTTOM:
                status.setOnOff(tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_BOTTOM);
                break;
-       case LyXTabular::M_VALIGN_CENTER:
+
+       case LyXTabular::M_VALIGN_MIDDLE:
                flag = false;
-       case LyXTabular::VALIGN_CENTER:
-               status.setOnOff(tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_CENTER);
+       case LyXTabular::VALIGN_MIDDLE:
+               status.setOnOff(tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_MIDDLE);
                break;
+
        case LyXTabular::SET_LONGTABULAR:
                status.setOnOff(tabular.isLongTabular());
                break;
+
        case LyXTabular::UNSET_LONGTABULAR:
                status.setOnOff(!tabular.isLongTabular());
                break;
+
        case LyXTabular::SET_ROTATE_TABULAR:
                status.setOnOff(tabular.getRotateTabular());
                break;
+
        case LyXTabular::UNSET_ROTATE_TABULAR:
                status.setOnOff(!tabular.getRotateTabular());
                break;
+
        case LyXTabular::SET_ROTATE_CELL:
                status.setOnOff(tabular.getRotateCell(actcell));
                break;
+
        case LyXTabular::UNSET_ROTATE_CELL:
                status.setOnOff(!tabular.getRotateCell(actcell));
                break;
+
        case LyXTabular::SET_USEBOX:
                status.setOnOff(strToInt(argument) == tabular.getUsebox(actcell));
                break;
+
        case LyXTabular::SET_LTFIRSTHEAD:
                status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
                break;
+
        case LyXTabular::SET_LTHEAD:
                status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
                break;
+
        case LyXTabular::SET_LTFOOT:
                status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
                break;
+
        case LyXTabular::SET_LTLASTFOOT:
                status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
                break;
+
        case LyXTabular::SET_LTNEWPAGE:
                status.setOnOff(tabular.getLTNewPage(sel_row_start));
                break;
+
        default:
                status.clear();
                status.disabled(true);
@@ -2341,37 +2202,41 @@ bool InsetTabular::copySelection(BufferView * bv)
        } else {
                sel_col_end = tabular.right_column_of_cell(sel_cell_end);
        }
-       int const columns = sel_col_end - sel_col_start + 1;
 
        int sel_row_start = tabular.row_of_cell(sel_cell_start);
        int sel_row_end = tabular.row_of_cell(sel_cell_end);
-       if (sel_row_start > sel_row_end) {
+       if (sel_row_start > sel_row_end)
                swap(sel_row_start, sel_row_end);
-       }
-       int const rows = sel_row_end - sel_row_start + 1;
 
        delete paste_tabular;
-       paste_tabular = new LyXTabular(bv->buffer()->params,
-                                      this, tabular); // rows, columns);
+       paste_tabular = new LyXTabular(bv->buffer()->params(), this, tabular);
+
        for (int i = 0; i < sel_row_start; ++i)
                paste_tabular->deleteRow(0);
+
+       int const rows = sel_row_end - sel_row_start + 1;
        while (paste_tabular->rows() > rows)
                paste_tabular->deleteRow(rows);
+
        paste_tabular->setTopLine(0, true, true);
        paste_tabular->setBottomLine(paste_tabular->getFirstCellInRow(rows - 1),
                                     true, true);
+
        for (int i = 0; i < sel_col_start; ++i)
                paste_tabular->deleteColumn(0);
+
+       int const columns = sel_col_end - sel_col_start + 1;
        while (paste_tabular->columns() > columns)
                paste_tabular->deleteColumn(columns);
+
        paste_tabular->setLeftLine(0, true, true);
        paste_tabular->setRightLine(paste_tabular->getLastCellInRow(0),
                                    true, true);
 
-       ostringstream sstr;
-       paste_tabular->ascii(bv->buffer(), sstr,
-                            (int)parOwner()->params().depth(), true, '\t');
-       bv->stuffClipboard(STRCONV(sstr.str()));
+       ostringstream os;
+       paste_tabular->ascii(*bv->buffer(), os,
+                            ownerPar(*bv->buffer(), this).params().depth(), true, '\t');
+       bv->stuffClipboard(STRCONV(os.str()));
        return true;
 }
 
@@ -2382,28 +2247,27 @@ bool InsetTabular::pasteSelection(BufferView * bv)
                return false;
 
        for (int r1 = 0, r2 = actrow;
-            (r1 < paste_tabular->rows()) && (r2 < tabular.rows());
+            r1 < paste_tabular->rows() && r2 < tabular.rows();
             ++r1, ++r2) {
-               for(int c1 = 0, c2 = actcol;
-                   (c1 < paste_tabular->columns()) && (c2 < tabular.columns());
+               for (int c1 = 0, c2 = actcol;
+                   c1 < paste_tabular->columns() && c2 < tabular.columns();
                    ++c1, ++c2) {
-                       if (paste_tabular->isPartOfMultiColumn(r1,c1) &&
-                           tabular.isPartOfMultiColumn(r2,c2))
+                       if (paste_tabular->isPartOfMultiColumn(r1, c1) &&
+                           tabular.isPartOfMultiColumn(r2, c2))
                                continue;
-                       if (paste_tabular->isPartOfMultiColumn(r1,c1)) {
+                       if (paste_tabular->isPartOfMultiColumn(r1, c1)) {
                                --c2;
                                continue;
                        }
-                       if (tabular.isPartOfMultiColumn(r2,c2)) {
+                       if (tabular.isPartOfMultiColumn(r2, c2)) {
                                --c1;
                                continue;
                        }
-                       int const n1 = paste_tabular->getCellNumber(r1, c1);
-                       int const n2 = tabular.getCellNumber(r2, c2);
-                       *(tabular.getCellInset(n2)) = *(paste_tabular->getCellInset(n1));
-                       tabular.getCellInset(n2)->setOwner(this);
-                       tabular.getCellInset(n2)->deleteLyXText(bv);
-                       tabular.getCellInset(n2)->markNew();
+                       InsetText & inset = tabular.getCellInset(r2, c2);
+                       inset = paste_tabular->getCellInset(r1, c1);
+                       inset.setOwner(this);
+                       inset.deleteLyXText(bv);
+                       inset.markNew();
                }
        }
        return true;
@@ -2423,19 +2287,19 @@ bool InsetTabular::cutSelection(BufferParams const & bp)
        } else {
                sel_col_end = tabular.right_column_of_cell(sel_cell_end);
        }
+
        int sel_row_start = tabular.row_of_cell(sel_cell_start);
        int sel_row_end = tabular.row_of_cell(sel_cell_end);
-       if (sel_row_start > sel_row_end) {
+
+       if (sel_row_start > sel_row_end)
                swap(sel_row_start, sel_row_end);
-       }
-       if (sel_cell_start > sel_cell_end) {
+
+       if (sel_cell_start > sel_cell_end)
                swap(sel_cell_start, sel_cell_end);
-       }
-       for (int i = sel_row_start; i <= sel_row_end; ++i) {
-               for (int j = sel_col_start; j <= sel_col_end; ++j) {
-                       tabular.getCellInset(tabular.getCellNumber(i, j))->clear(bp.tracking_changes);
-               }
-       }
+
+       for (int i = sel_row_start; i <= sel_row_end; ++i)
+               for (int j = sel_col_start; j <= sel_col_end; ++j)
+                       tabular.getCellInset(tabular.getCellNumber(i, j)).clear(bp.tracking_changes);
        return true;
 }
 
@@ -2446,14 +2310,6 @@ bool InsetTabular::isRightToLeft(BufferView * bv)
 }
 
 
-bool InsetTabular::nodraw() const
-{
-       if (!UpdatableInset::nodraw() && the_locking_inset)
-               return the_locking_inset->nodraw();
-       return UpdatableInset::nodraw();
-}
-
-
 int InsetTabular::scroll(bool recursive) const
 {
        int sx = UpdatableInset::scroll(false);
@@ -2473,24 +2329,22 @@ void InsetTabular::getSelection(int & srow, int & erow,
 
        srow = tabular.row_of_cell(start);
        erow = tabular.row_of_cell(end);
-       if (srow > erow) {
+       if (srow > erow)
                swap(srow, erow);
-       }
 
        scol = tabular.column_of_cell(start);
        ecol = tabular.column_of_cell(end);
-       if (scol > ecol) {
+       if (scol > ecol)
                swap(scol, ecol);
-       } else {
+       else
                ecol = tabular.right_column_of_cell(end);
-       }
 }
 
 
 ParagraphList * InsetTabular::getParagraphs(int i) const
 {
        return (i < tabular.getNumberOfCells())
-               ? tabular.getCellInset(i)->getParagraphs(0)
+               ? tabular.getCellInset(i).getParagraphs(0)
                : 0;
 }
 
@@ -2499,20 +2353,20 @@ LyXCursor const & InsetTabular::cursor(BufferView * bv) const
 {
        if (the_locking_inset)
                return the_locking_inset->cursor(bv);
-       return Inset::cursor(bv);
+       return InsetOld::cursor(bv);
 }
 
 
-Inset * InsetTabular::getInsetFromID(int id_arg) const
+InsetOld * InsetTabular::getInsetFromID(int id_arg) const
 {
        if (id_arg == id())
                return const_cast<InsetTabular *>(this);
 
-       Inset * result;
-       for(int i = 0; i < tabular.rows(); ++i) {
-               for(int j = 0; j < tabular.columns(); ++j) {
-                       if ((result = tabular.getCellInset(i, j)->getInsetFromID(id_arg)))
-                               return result;
+       for (int i = 0; i < tabular.rows(); ++i) {
+               for (int j = 0; j < tabular.columns(); ++j) {
+                       InsetOld * inset = tabular.getCellInset(i, j).getInsetFromID(id_arg);
+                       if (inset)
+                               return inset;
                }
        }
        return 0;
@@ -2522,26 +2376,20 @@ Inset * InsetTabular::getInsetFromID(int id_arg) const
 WordLangTuple const
 InsetTabular::selectNextWordToSpellcheck(BufferView * bv, float & value) const
 {
-       nodraw(true);
        if (the_locking_inset) {
                WordLangTuple word(the_locking_inset->selectNextWordToSpellcheck(bv, value));
-               if (!word.word().empty()) {
-                       nodraw(false);
+               if (!word.word().empty())
                        return word;
-               }
                if (tabular.isLastCell(actcell)) {
                        bv->unlockInset(const_cast<InsetTabular *>(this));
-                       nodraw(false);
                        return WordLangTuple();
                }
                ++actcell;
        }
        // otherwise we have to lock the next inset and ask for it's selecttion
-       UpdatableInset * inset =
-               static_cast<UpdatableInset*>(tabular.getCellInset(actcell));
-       inset->localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
+       tabular.getCellInset(actcell)
+               .localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
        WordLangTuple word(selectNextWordInt(bv, value));
-       nodraw(false);
        if (!word.word().empty())
                resetPos(bv);
        return word;
@@ -2563,40 +2411,24 @@ WordLangTuple InsetTabular::selectNextWordInt(BufferView * bv, float & value) co
        }
 
        // otherwise we have to lock the next inset and ask for it's selecttion
-       UpdatableInset * inset =
-               static_cast<UpdatableInset*>(tabular.getCellInset(++actcell));
-       inset->localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
+       ++actcell;
+       tabular.getCellInset(actcell)
+               .localDispatch(FuncRequest(bv, LFUN_INSET_EDIT));
        return selectNextWordInt(bv, value);
 }
 
 
 void InsetTabular::selectSelectedWord(BufferView * bv)
 {
-       if (the_locking_inset) {
+       if (the_locking_inset)
                the_locking_inset->selectSelectedWord(bv);
-               return;
-       }
-       return;
-}
-
-
-void InsetTabular::toggleSelection(BufferView * bv, bool kill_selection)
-{
-       if (the_locking_inset) {
-               the_locking_inset->toggleSelection(bv, kill_selection);
-       }
 }
 
 
 void InsetTabular::markErased()
 {
-       int cell = 0;
-
-       while (cell < tabular.getNumberOfCells()) {
-               InsetText * inset = tabular.getCellInset(cell);
-               inset->markErased();
-               ++cell;
-       }
+       for (int cell = 0; cell < tabular.getNumberOfCells(); ++cell)
+               tabular.getCellInset(cell).markErased();
 }
 
 
@@ -2604,23 +2436,23 @@ bool InsetTabular::nextChange(BufferView * bv, lyx::pos_type & length)
 {
        if (the_locking_inset) {
                if (the_locking_inset->nextChange(bv, length)) {
-                       updateLocal(bv, CELL);
+                       updateLocal(bv);
                        return true;
                }
                if (tabular.isLastCell(actcell))
                        return false;
                ++actcell;
        }
-       InsetText * inset = tabular.getCellInset(actcell);
-       if (inset->nextChange(bv, length)) {
-               updateLocal(bv, FULL);
+       InsetText & inset = tabular.getCellInset(actcell);
+       if (inset.nextChange(bv, length)) {
+               updateLocal(bv);
                return true;
        }
        while (!tabular.isLastCell(actcell)) {
                ++actcell;
-               inset = tabular.getCellInset(actcell);
-               if (inset->nextChange(bv, length)) {
-                       updateLocal(bv, FULL);
+               InsetText & inset = tabular.getCellInset(actcell);
+               if (inset.nextChange(bv, length)) {
+                       updateLocal(bv);
                        return true;
                }
        }
@@ -2634,23 +2466,23 @@ bool InsetTabular::searchForward(BufferView * bv, string const & str,
        int cell = 0;
        if (the_locking_inset) {
                if (the_locking_inset->searchForward(bv, str, cs, mw)) {
-                       updateLocal(bv, CELL);
+                       updateLocal(bv);
                        return true;
                }
                if (tabular.isLastCell(actcell))
                        return false;
                cell = actcell + 1;
        }
-       InsetText * inset = tabular.getCellInset(cell);
-       if (inset->searchForward(bv, str, cs, mw)) {
-               updateLocal(bv, FULL);
+       InsetText & inset = tabular.getCellInset(cell);
+       if (inset.searchForward(bv, str, cs, mw)) {
+               updateLocal(bv);
                return true;
        }
        while (!tabular.isLastCell(cell)) {
                ++cell;
-               inset = tabular.getCellInset(cell);
-               if (inset->searchForward(bv, str, cs, mw)) {
-                       updateLocal(bv, FULL);
+               InsetText & inset = tabular.getCellInset(cell);
+               if (inset.searchForward(bv, str, cs, mw)) {
+                       updateLocal(bv);
                        return true;
                }
        }
@@ -2664,7 +2496,7 @@ bool InsetTabular::searchBackward(BufferView * bv, string const & str,
        int cell = tabular.getNumberOfCells();
        if (the_locking_inset) {
                if (the_locking_inset->searchBackward(bv, str, cs, mw)) {
-                       updateLocal(bv, CELL);
+                       updateLocal(bv);
                        return true;
                }
                cell = actcell;
@@ -2672,9 +2504,9 @@ bool InsetTabular::searchBackward(BufferView * bv, string const & str,
 
        while (cell) {
                --cell;
-               InsetText * inset = tabular.getCellInset(cell);
-               if (inset->searchBackward(bv, str, cs, mw)) {
-                       updateLocal(bv, CELL);
+               InsetText & inset = tabular.getCellInset(cell);
+               if (inset.searchBackward(bv, str, cs, mw)) {
+                       updateLocal(bv);
                        return true;
                }
        }
@@ -2682,7 +2514,7 @@ bool InsetTabular::searchBackward(BufferView * bv, string const & str,
 }
 
 
-bool InsetTabular::insetAllowed(Inset::Code code) const
+bool InsetTabular::insetAllowed(InsetOld::Code code) const
 {
        if (the_locking_inset)
                return the_locking_inset->insetAllowed(code);
@@ -2693,7 +2525,7 @@ bool InsetTabular::insetAllowed(Inset::Code code) const
 }
 
 
-bool InsetTabular::forceDefaultParagraphs(Inset const * in) const
+bool InsetTabular::forceDefaultParagraphs(InsetOld const * in) const
 {
        const int cell = tabular.getCellFromInset(in, actcell);
 
@@ -2703,10 +2535,13 @@ bool InsetTabular::forceDefaultParagraphs(Inset const * in) const
        // well we didn't obviously find it so maybe our owner knows more
        if (owner())
                return owner()->forceDefaultParagraphs(in);
-       // if we're here there is really something strange going on!!!
+
+       lyxerr << "If we're here there is really something strange going on!"
+              << endl;
        return false;
 }
 
+
 bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                                     bool usePaste)
 {
@@ -2719,9 +2554,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
        string::size_type len = buf.length();
        string::size_type p = 0;
 
-       while (p < len &&
-              ((p = buf.find_first_of("\t\n", p)) != string::npos))
-       {
+       while (p < len && (p = buf.find_first_of("\t\n", p)) != string::npos) {
                switch (buf[p]) {
                case '\t':
                        ++cols;
@@ -2742,7 +2575,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
        int row = 0;
        if (usePaste) {
                delete paste_tabular;
-               paste_tabular = new LyXTabular(bv->buffer()->params,
+               paste_tabular = new LyXTabular(bv->buffer()->params(),
                                               this, rows, maxCols);
                loctab = paste_tabular;
                cols = 0;
@@ -2760,7 +2593,7 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
        rows = loctab->rows();
        int const columns = loctab->columns();
 
-       while ((cell < cells) && (p < len) && (row < rows) &&
+       while (cell < cells && p < len && row < rows &&
               (p = buf.find_first_of("\t\n", p)) != string::npos)
        {
                if (p >= len)
@@ -2769,10 +2602,10 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                case '\t':
                        // we can only set this if we are not too far right
                        if (cols < columns) {
-                               InsetText * ti = loctab->getCellInset(cell);
-                               LyXFont const font = ti->getLyXText(bv)->
-                                       getFont(bv->buffer(), ti->paragraphs.begin(), 0);
-                               ti->setText(buf.substr(op, p - op), font);
+                               InsetText & inset = loctab->getCellInset(cell);
+                               LyXFont const font = inset.getLyXText(bv)->
+                                       getFont(inset.paragraphs.begin(), 0);
+                               inset.setText(buf.substr(op, p - op), font);
                                ++cols;
                                ++cell;
                        }
@@ -2780,10 +2613,10 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                case '\n':
                        // we can only set this if we are not too far right
                        if (cols < columns) {
-                               InsetText * ti = loctab->getCellInset(cell);
-                               LyXFont const font = ti->getLyXText(bv)->
-                                       getFont(bv->buffer(), ti->paragraphs.begin(), 0);
-                               ti->setText(buf.substr(op, p - op), font);
+                               InsetText & inset = tabular.getCellInset(cell);
+                               LyXFont const font = inset.getLyXText(bv)->
+                                       getFont(inset.paragraphs.begin(), 0);
+                               inset.setText(buf.substr(op, p - op), font);
                        }
                        cols = ocol;
                        ++row;
@@ -2795,37 +2628,35 @@ bool InsetTabular::insertAsciiString(BufferView * bv, string const & buf,
                op = p;
        }
        // check for the last cell if there is no trailing '\n'
-       if ((cell < cells) && (op < len)) {
-               InsetText * ti = loctab->getCellInset(cell);
-               LyXFont const font = ti->getLyXText(bv)->
-                       getFont(bv->buffer(), ti->paragraphs.begin(), 0);
-               ti->setText(buf.substr(op, len - op), font);
+       if (cell < cells && op < len) {
+               InsetText & inset = loctab->getCellInset(cell);
+               LyXFont const font = inset.getLyXText(bv)->
+                       getFont(inset.paragraphs.begin(), 0);
+               inset.setText(buf.substr(op, len - op), font);
        }
 
        return true;
 }
 
 
-void InsetTabular::addPreview(grfx::PreviewLoader & loader) const
+void InsetTabular::addPreview(PreviewLoader & loader) const
 {
        int const rows = tabular.rows();
        int const columns = tabular.columns();
-       for (int i = 0; i < rows; ++i) {
-               for (int j = 0; j < columns; ++j) {
-                       tabular.getCellInset(i,j)->addPreview(loader);
-               }
-       }
+       for (int i = 0; i < rows; ++i)
+               for (int j = 0; j < columns; ++j)
+                       tabular.getCellInset(i, j).addPreview(loader);
 }
 
 
-string const InsetTabularMailer:: name_("tabular");
+string const InsetTabularMailer::name_("tabular");
 
-InsetTabularMailer::InsetTabularMailer(InsetTabular & inset)
-       : inset_(inset)
+InsetTabularMailer::InsetTabularMailer(InsetTabular const & inset)
+       : inset_(const_cast<InsetTabular &>(inset))
 {}
 
 
-string const InsetTabularMailer::inset2string() const
+string const InsetTabularMailer::inset2string(Buffer const &) const
 {
        return params2string(inset_);
 }
@@ -2870,9 +2701,8 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
        if (!lex.isOK())
                return -1;
 
-       Buffer const * const buffer = inset.buffer();
-       if (buffer)
-               inset.read(buffer, lex);
+       Buffer const & buffer = inset.buffer();
+       inset.read(buffer, lex);
 
        // We can't set the active cell, but we can tell the frontend
        // what it is.
@@ -2882,9 +2712,7 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
 
 string const InsetTabularMailer::params2string(InsetTabular const & inset)
 {
-       Buffer const * const buffer = inset.buffer();
-       if (!buffer)
-               return string();
+       Buffer const & buffer = inset.buffer();
 
        ostringstream data;
        data << name_ << " \\active_cell " << inset.getActCell() << '\n';