]> git.lyx.org Git - lyx.git/blobdiff - src/insets/insettabular.C
insetcharstyle drawing cosmetics
[lyx.git] / src / insets / insettabular.C
index fee887c086e181dc93242184ae55eb9fac77325a..ae7764db6b526ce9c607c7ef42bdbffae187aea0 100644 (file)
@@ -37,8 +37,7 @@
 #include "frontends/LyXView.h"
 #include "frontends/Painter.h"
 
-#include "support/std_sstream.h"
-
+#include <sstream>
 #include <iostream>
 
 using lyx::graphics::PreviewLoader;
@@ -183,7 +182,7 @@ Buffer const & InsetTabular::buffer() const
 }
 
 
-void InsetTabular::buffer(Buffer * b)
+void InsetTabular::buffer(Buffer const * b)
 {
        buffer_ = b;
 }
@@ -205,10 +204,10 @@ void InsetTabular::read(Buffer const & buf, LyXLex & lex)
        if (old_format)
                return;
 
-       lex.nextToken();
+       lex.next();
        string token = lex.getString();
        while (lex.isOK() && (token != "\\end_inset")) {
-               lex.nextToken();
+               lex.next();
                token = lex.getString();
        }
        if (token != "\\end_inset") {
@@ -236,8 +235,10 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
                        ++cell;
                        Dimension dim;
                        MetricsInfo m = mi;
-                       m.base.textwidth =
-                               tabular.column_info[j].p_width.inPixels(mi.base.textwidth);
+                       LyXLength p_width = tabular.column_info[j].p_width;
+                       if (!p_width.zero()) {
+                               m.base.textwidth = p_width.inPixels(mi.base.textwidth);
+                       }
                        tabular.getCellInset(cell).metrics(m, dim);
                        maxAsc  = max(maxAsc, dim.asc);
                        maxDesc = max(maxDesc, dim.des);
@@ -269,12 +270,11 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
        for (int i = 0; i < tabular.rows(); ++i) {
                int nx = x;
                idx = tabular.getCellNumber(i, 0);
-               if (y + tabular.getDescentOfRow(i) <= 0 &&
-                         y - tabular.getAscentOfRow(i) < pi.pain.paperHeight())
-               {
-                       y += tabular.getDescentOfRow(i) +
-                                       tabular.getAscentOfRow(i + 1) +
-                                       tabular.getAdditionalHeight(i + 1);
+               if (y + tabular.getDescentOfRow(i) <= 0
+                   && y - tabular.getAscentOfRow(i) < pi.pain.paperHeight()) {
+                       y += tabular.getDescentOfRow(i)
+                               + tabular.getAscentOfRow(i + 1)
+                               + tabular.getAdditionalHeight(i + 1);
                        continue;
                }
                for (int j = 0; j < tabular.columns(); ++j) {
@@ -375,33 +375,36 @@ void InsetTabular::edit(LCursor & cur, bool left)
 {
        lyxerr << "InsetTabular::edit: " << this << endl;
        finishUndo();
-       int cell;
+       cur.selection() = false;
+       cur.push(*this);
        if (left) {
                if (isRightToLeft(cur))
-                       cell = tabular.getLastCellInRow(0);
+                       cur.idx() = tabular.getLastCellInRow(0);
                else
-                       cell = 0;
+                       cur.idx() = 0;
+               cur.par() = 0;
+               cur.pos() = 0;
        } else {
                if (isRightToLeft(cur))
-                       cell = tabular.getFirstCellInRow(tabular.rows()-1);
+                       cur.idx() = tabular.getFirstCellInRow(tabular.rows() - 1);
                else
-                       cell = tabular.getNumberOfCells() - 1;
+                       cur.idx() = tabular.getNumberOfCells() - 1;
+               cur.par() = 0;
+               cur.pos() = cur.lastpos(); // FIXME crude guess
        }
-       cur.selection() = false;
-       resetPos(cur);
-       cur.bv().fitCursor();
-       cur.push(*this);
-       cur.idx() = cell;
+       // this accesses the position cache before it is initialized
+       //resetPos(cur);
+       //cur.bv().fitCursor();
 }
 
 
-InsetBase * InsetTabular::editXY(LCursor & cur, int x, int y)
+InsetBase * InsetTabular::editXY(LCursor & cur, int x, int y) const
 {
        //lyxerr << "InsetTabular::editXY: " << this << endl;
        cur.selection() = false;
-       cur.push(*this);
+       cur.push(const_cast<InsetTabular&>(*this));
        return setPos(cur, x, y);
-       //int xx = cursorx_ - xo_ + tabular.getBeginningOfTextInCell(actcell);
+       //int xx = cursorx_ - xo() + tabular.getBeginningOfTextInCell(cur.idx());
 }
 
 
@@ -410,32 +413,43 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        lyxerr << "# InsetTabular::dispatch: cmd: " << cmd << endl;
        //lyxerr << "  cur:\n" << cur << endl;
        CursorSlice sl = cur.top();
+       LCursor & bvcur = cur.bv().cursor();
 
        switch (cmd.action) {
 
        case LFUN_MOUSE_PRESS:
-               // we'll pop up the table dialog on release
-               if (cmd.button() == mouse_button::button3)
+               lyxerr << "# InsetTabular::MousePress\n" << cur.bv().cursor() << endl;
+
+               if (cmd.button() == mouse_button::button1) {
+                       cur.selection() = false;
+                       setPos(cur, cmd.x, cmd.y);
+                       cur.resetAnchor();
+                       bvcur = cur;
                        break;
-               cur.selection() = false;
-               setPos(cur, cmd.x, cmd.y);
-               cur.resetAnchor();
-               cur.bv().cursor().setCursor(cur, false);
+               }
+
                //if (cmd.button() == mouse_button::button2)
                //      dispatch(cur, FuncRequest(LFUN_PASTESELECTION, "paragraph"));
-               //lyxerr << "# InsetTabular::MousePress\n" << cur.bv().cursor() << endl;
+
+               // we'll pop up the table dialog on release
+               if (cmd.button() == mouse_button::button3)
+                       break;
                break;
 
        case LFUN_MOUSE_MOTION:
-               if (cmd.button() != mouse_button::button1)
-                       break;
-               setPos(cur, cmd.x, cmd.y);
-               cur.bv().cursor().setCursor(cur, true);
-               //lyxerr << "# InsetTabular::MouseMotion\n" << cur.bv().cursor() << endl;
+               lyxerr << "# InsetTabular::MouseMotion\n" << bvcur << endl;
+               if (cmd.button() == mouse_button::button1) {
+                       // only accept motions to places not deeper nested than the real anchor
+                       if (bvcur.anchor_.hasPart(cur)) {
+                               setPos(cur, cmd.x, cmd.y);
+                               bvcur.setCursor(cur);
+                               bvcur.selection() = true;
+                       }
+               }
                break;
 
        case LFUN_MOUSE_RELEASE:
-               //lyxerr << "# InsetTabular::MouseRelease\n" << cur.bv().cursor() << endl;
+               lyxerr << "# InsetTabular::MouseRelease\n" << bvcur << endl;
                if (cmd.button() == mouse_button::button3)
                        InsetTabularMailer(*this).showDialog(&cur.bv());
                break;
@@ -462,6 +476,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_RIGHTSEL:
        case LFUN_RIGHT:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        isRightToLeft(cur) ? movePrevCell(cur) : moveNextCell(cur);
                if (sl == cur.top()) {
@@ -470,9 +485,10 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_LEFTSEL: 
+       case LFUN_LEFTSEL:
        case LFUN_LEFT:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        isRightToLeft(cur) ? moveNextCell(cur) : movePrevCell(cur);
                if (sl == cur.top()) {
@@ -484,6 +500,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_DOWNSEL:
        case LFUN_DOWN:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        if (tabular.row_of_cell(cur.idx()) != tabular.rows() - 1) {
                                cur.idx() = tabular.getCellBelow(cur.idx());
@@ -500,6 +517,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_UPSEL:
        case LFUN_UP:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        if (tabular.row_of_cell(cur.idx()) != 0) {
                                cur.idx() = tabular.getCellAbove(cur.idx());
@@ -516,18 +534,16 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_NEXT: {
                //if (hasSelection())
                //      cur.selection() = false;
-               int actcell = cur.idx();
-               int actcol = tabular.column_of_cell(actcell);
-               int column = actcol;
-               if (cur.bv().top_y() + cur.bv().painter().paperHeight()
-                               < yo_ + tabular.getHeightOfTabular())
-               {
-                       cur.bv().scrollDocView(
-                               cur.bv().top_y() + cur.bv().painter().paperHeight());
-                       cur.idx() = tabular.getCellBelow(first_visible_cell) + column;
+               int const col = tabular.column_of_cell(cur.idx());
+               int const t =   cur.bv().top_y() + cur.bv().painter().paperHeight();
+               if (t < yo() + tabular.getHeightOfTabular()) {
+                       cur.bv().scrollDocView(t);
+                       cur.idx() = tabular.getCellBelow(first_visible_cell) + col;
                } else {
-                       cur.idx() = tabular.getFirstCellInRow(tabular.rows() - 1) + column;
+                       cur.idx() = tabular.getFirstCellInRow(tabular.rows() - 1) + col;
                }
+               cur.par() = 0;
+               cur.pos() = 0;
                resetPos(cur);
                break;
        }
@@ -535,17 +551,19 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_PRIOR: {
                //if (hasSelection())
                //      cur.selection() = false;
-               int column = tabular.column_of_cell(cur.idx());
-               if (yo_ < 0) {
-                       cur.bv().scrollDocView(
-                               cur.bv().top_y() - cur.bv().painter().paperHeight());
-                       if (yo_ > 0)
-                               cur.idx() = column;
+               int const col = tabular.column_of_cell(cur.idx());
+               int const t =   cur.bv().top_y() + cur.bv().painter().paperHeight();
+               if (yo() < 0) {
+                       cur.bv().scrollDocView(t);
+                       if (yo() > 0)
+                               cur.idx() = col;
                        else
-                               cur.idx() = tabular.getCellBelow(first_visible_cell) + column;
+                               cur.idx() = tabular.getCellBelow(first_visible_cell) + col;
                } else {
-                       cur.idx() = column;
+                       cur.idx() = col;
                }
+               cur.par() = cur.lastpar();
+               cur.pos() = cur.lastpos();
                resetPos(cur);
                break;
        }
@@ -572,19 +590,6 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                break;
        }
 
-       case LFUN_LANGUAGE:
-       case LFUN_EMPH:
-       case LFUN_BOLD:
-       case LFUN_NOUN:
-       case LFUN_CODE:
-       case LFUN_SANS:
-       case LFUN_ROMAN:
-       case LFUN_DEFAULT:
-       case LFUN_UNDERLINE:
-       case LFUN_FONT_SIZE:
-               lyxerr << "font changes not re-implemented for tables after LOCK" << endl;
-               break;
-
        case LFUN_CUT:
                if (copySelection(cur)) {
                        recordUndo(cur, Undo::DELETE);
@@ -636,7 +641,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                        maxCols = max(cols, maxCols);
 
                        paste_tabular.reset(
-                               new LyXTabular(cur.bv().buffer()->params(), rows, maxCols));
+                               new LyXTabular(cur.buffer().params(), rows, maxCols));
 
                        string::size_type op = 0;
                        int cell = 0;
@@ -696,75 +701,184 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
 }
 
 
+// function sets an object as defined in func_status.h:
+// states OK, Unknown, Disabled, On, Off.
 bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
-       FuncStatus & flag) const
+       FuncStatus & status) const
 {
        switch (cmd.action) {
-       case LFUN_TABULAR_FEATURE:
-#if 0
-               if (cur.inMathed()) {
-                       // FIXME: check temporarily disabled
-                       // valign code
-                       char align = mathcursor::valign();
-                       if (align == '\0') {
-                               enable = false;
-                               break;
-                       }
-                       if (cmd.argument.empty()) {
-                               flag.clear();
-                               break;
-                       }
-                       if (!contains("tcb", cmd.argument[0])) {
-                               enable = false;
+       case LFUN_TABULAR_FEATURE: {
+               int action = LyXTabular::LAST_ACTION;
+               int i = 0;
+               for (; tabularFeature[i].action != LyXTabular::LAST_ACTION; ++i) {
+                       string const tmp = tabularFeature[i].feature;
+                       if (tmp == cmd.argument.substr(0, tmp.length())) {
+                               action = tabularFeature[i].action;
                                break;
                        }
-                       flag.setOnOff(cmd.argument[0] == align);
-               } else {
-                       enable = false;
+               }
+               if (action == LyXTabular::LAST_ACTION) {
+                       status.clear();
+                       status.unknown(true);
+                       return true;
+               }
 
-                       char const align = mathcursor::halign();
-                       if (align == '\0') {
-                               enable = false;
-                               break;
-                       }
-                       if (cmd.argument.empty()) {
-                               flag.clear();
-                               break;
-                       }
-                       if (!contains("lcr", cmd.argument[0])) {
-                               enable = false;
-                               break;
-                       }
-                       flag.setOnOff(cmd.argument[0] == align);
+               string const argument
+                       = ltrim(cmd.argument.substr(tabularFeature[i].feature.length()));
+
+               int sel_row_start = 0;
+               int sel_row_end = 0;
+               int dummy;
+               LyXTabular::ltType dummyltt;
+               bool flag = true;
+
+               getSelection(cur, sel_row_start, sel_row_end, dummy, dummy);
+
+               switch (action) {
+               case LyXTabular::SET_PWIDTH:
+               case LyXTabular::SET_MPWIDTH:
+               case LyXTabular::SET_SPECIAL_COLUMN:
+               case LyXTabular::SET_SPECIAL_MULTI:
+               case LyXTabular::APPEND_ROW:
+               case LyXTabular::APPEND_COLUMN:
+               case LyXTabular::DELETE_ROW:
+               case LyXTabular::DELETE_COLUMN:
+               case LyXTabular::SET_ALL_LINES:
+               case LyXTabular::UNSET_ALL_LINES:
+                       status.clear();
+                       return true;
+
+               case LyXTabular::MULTICOLUMN:
+                       status.setOnOff(tabular.isMultiColumn(cur.idx()));
+                       break;
 
-                       disable = !mathcursor::halign();
+               case LyXTabular::M_TOGGLE_LINE_TOP:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_TOP:
+                       status.setOnOff(tabular.topLine(cur.idx(), flag));
                        break;
-               }
 
-                       FuncStatus ret;
-                       //ret.disabled(true);
-                       InsetTabular * tab = static_cast<InsetTabular *>
-                               (cur.innerInsetOfType(InsetBase::TABULAR_CODE));
-                       if (tab) {
-                               ret = tab->getStatus(cmd.argument);
-                               flag |= ret;
-                               enable = true;
-                       } else {
-                               enable = false;
-                       }
-               } else {
-                       static InsetTabular inset(*buf, 1, 1);
-                       enable = false;
-                       FuncStatus ret = inset.getStatus(cmd.argument);
-                       if (ret.onoff(true) || ret.onoff(false))
-                               flag.setOnOff(false);
+               case LyXTabular::M_TOGGLE_LINE_BOTTOM:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_BOTTOM:
+                       status.setOnOff(tabular.bottomLine(cur.idx(), flag));
+                       break;
+
+               case LyXTabular::M_TOGGLE_LINE_LEFT:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_LEFT:
+                       status.setOnOff(tabular.leftLine(cur.idx(), flag));
+                       break;
+
+               case LyXTabular::M_TOGGLE_LINE_RIGHT:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_RIGHT:
+                       status.setOnOff(tabular.rightLine(cur.idx(), flag));
+                       break;
+
+               case LyXTabular::M_ALIGN_LEFT:
+                       flag = false;
+               case LyXTabular::ALIGN_LEFT:
+                       status.setOnOff(tabular.getAlignment(cur.idx(), flag) == LYX_ALIGN_LEFT);
+                       break;
+
+               case LyXTabular::M_ALIGN_RIGHT:
+                       flag = false;
+               case LyXTabular::ALIGN_RIGHT:
+                       status.setOnOff(tabular.getAlignment(cur.idx(), flag) == LYX_ALIGN_RIGHT);
+                       break;
+
+               case LyXTabular::M_ALIGN_CENTER:
+                       flag = false;
+               case LyXTabular::ALIGN_CENTER:
+                       status.setOnOff(tabular.getAlignment(cur.idx(), flag) == LYX_ALIGN_CENTER);
+                       break;
+
+               case LyXTabular::ALIGN_BLOCK:
+                       status.enabled(!tabular.getPWidth(cur.idx()).zero());
+                       status.setOnOff(tabular.getAlignment(cur.idx(), flag) == LYX_ALIGN_BLOCK);
+                       break;
+
+               case LyXTabular::M_VALIGN_TOP:
+                       flag = false;
+               case LyXTabular::VALIGN_TOP:
+                       status.setOnOff(
+                               tabular.getVAlignment(cur.idx(), flag) == LyXTabular::LYX_VALIGN_TOP);
+                       break;
+
+               case LyXTabular::M_VALIGN_BOTTOM:
+                       flag = false;
+               case LyXTabular::VALIGN_BOTTOM:
+                       status.setOnOff(
+                               tabular.getVAlignment(cur.idx(), flag) == LyXTabular::LYX_VALIGN_BOTTOM);
+                       break;
+
+               case LyXTabular::M_VALIGN_MIDDLE:
+                       flag = false;
+               case LyXTabular::VALIGN_MIDDLE:
+                       status.setOnOff(
+                               tabular.getVAlignment(cur.idx(), flag) == LyXTabular::LYX_VALIGN_MIDDLE);
+                       break;
+
+               case LyXTabular::SET_LONGTABULAR:
+                       status.setOnOff(tabular.isLongTabular());
+                       break;
+
+               case LyXTabular::UNSET_LONGTABULAR:
+                       status.setOnOff(!tabular.isLongTabular());
+                       break;
+
+               case LyXTabular::SET_ROTATE_TABULAR:
+                       status.setOnOff(tabular.getRotateTabular());
+                       break;
+
+               case LyXTabular::UNSET_ROTATE_TABULAR:
+                       status.setOnOff(!tabular.getRotateTabular());
+                       break;
+
+               case LyXTabular::SET_ROTATE_CELL:
+                       status.setOnOff(tabular.getRotateCell(cur.idx()));
+                       break;
+
+               case LyXTabular::UNSET_ROTATE_CELL:
+                       status.setOnOff(!tabular.getRotateCell(cur.idx()));
+                       break;
+
+               case LyXTabular::SET_USEBOX:
+                       status.setOnOff(strToInt(argument) == tabular.getUsebox(cur.idx()));
+                       break;
+
+               case LyXTabular::SET_LTFIRSTHEAD:
+                       status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTHEAD:
+                       status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTFOOT:
+                       status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTLASTFOOT:
+                       status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTNEWPAGE:
+                       status.setOnOff(tabular.getLTNewPage(sel_row_start));
+                       break;
+
+               default:
+                       status.clear();
+                       status.enabled(false);
+                       break;
                }
-#endif
                return true;
+       }
 
        default:
                // we try to handle this event in the insets dispatch function.
-               return cell(cur.idx()).getStatus(cur, cmd, flag);
+               return cell(cur.idx()).getStatus(cur, cmd, status);
        }
 }
 
@@ -779,7 +893,7 @@ int InsetTabular::latex(Buffer const & buf, ostream & os,
 int InsetTabular::plaintext(Buffer const & buf, ostream & os,
                        OutputParams const & runparams) const
 {
-       int dp = runparams.linelen ? ownerPar(buf, this).params().depth() : 0;
+       int dp = runparams.linelen ? runparams.depth : 0;
        return tabular.plaintext(buf, os, runparams, dp, false, 0);
 }
 
@@ -797,7 +911,9 @@ int InsetTabular::docbook(Buffer const & buf, ostream & os,
        int ret = 0;
        InsetOld * master = 0;
 
+#ifdef WITH_WARNINGS
 #warning Why not pass a proper DocIterator here?
+#endif
 #if 0
        // if the table is inside a float it doesn't need the informaltable
        // wrapper. Search for it.
@@ -841,7 +957,7 @@ InsetText & InsetTabular::cell(int idx)
 }
 
 
-void InsetTabular::getCursorPos(CursorSlice const & cur, int & x, int & y) const
+void InsetTabular::getCursorPos(LCursor const & cur, int & x, int & y) const
 {
        cell(cur.idx()).getCursorPos(cur, x, y);
 }
@@ -849,6 +965,7 @@ void InsetTabular::getCursorPos(CursorSlice const & cur, int & x, int & y) const
 
 InsetBase * InsetTabular::setPos(LCursor & cur, int x, int y) const
 {
+       lyxerr << "# InsetTabular::setPos()  x=" << x << " y=" << y << endl;
        int idx_min = 0;
        int dist_min = 1000000;
        for (idx_type i = 0; i < nargs(); ++i) {
@@ -875,33 +992,31 @@ int InsetTabular::getCellXPos(int cell) const
        for (; c < cell; ++c)
                lx += tabular.getWidthOfColumn(c);
 
-       return lx - tabular.getWidthOfColumn(cell) + xo_;
+       return lx - tabular.getWidthOfColumn(cell) + xo();
 }
 
 
 void InsetTabular::resetPos(LCursor & cur) const
 {
        BufferView & bv = cur.bv();
-       int actcell = cur.idx();
-       int actcol = tabular.column_of_cell(actcell);
-
+       int const actcol = tabular.column_of_cell(cur.idx());
        int const offset = ADD_TO_TABULAR_WIDTH + 2;
-       int new_x = getCellXPos(actcell) + offset;
-       int old_x = cursorx_;
+       int const new_x = getCellXPos(cur.idx()) + offset;
+       int const old_x = cursorx_;
+       int const col_width = tabular.getWidthOfColumn(cur.idx());
        cursorx_ = new_x;
-//    cursor.x(getCellXPos(actcell) + offset);
+//    cursor.x(getCellXPos(cur.idx()) + offset);
        if (actcol < tabular.columns() - 1 && scroll(false) &&
                tabular.getWidthOfTabular() < bv.workWidth()-20)
        {
                scroll(bv, 0.0F);
        } else if (cursorx_ - offset > 20 &&
-                  cursorx_ - offset + tabular.getWidthOfColumn(actcell)
-                  > bv.workWidth() - 20) {
-               scroll(bv, - tabular.getWidthOfColumn(actcell) - 20);
+                  cursorx_ - offset + col_width > bv.workWidth() - 20) {
+               scroll(bv, - col_width - 20);
        } else if (cursorx_ - offset < 20) {
                scroll(bv, 20 - cursorx_ + offset);
-       } else if (scroll() && xo_ > 20 &&
-                  xo_ + tabular.getWidthOfTabular() > bv.workWidth() - 20) {
+       } else if (scroll() && xo() > 20 &&
+                  xo() + tabular.getWidthOfTabular() > bv.workWidth() - 20) {
                scroll(bv, old_x - cursorx_);
        }
 
@@ -911,27 +1026,28 @@ void InsetTabular::resetPos(LCursor & cur) const
 
 void InsetTabular::moveNextCell(LCursor & cur)
 {
-       lyxerr << "InsetTabular::moveNextCell 1 cur: " << cur << endl;
+       lyxerr << "InsetTabular::moveNextCell 1 cur: " << cur.top() << endl;
        if (isRightToLeft(cur)) {
+               lyxerr << "InsetTabular::moveNextCell A cur: " << endl;
                if (tabular.isFirstCellInRow(cur.idx())) {
                        int row = tabular.row_of_cell(cur.idx());
                        if (row == tabular.rows() - 1)
                                return;
-                       cur.idx() = tabular.getLastCellInRow(row);
-                       cur.idx() = tabular.getCellBelow(cur.idx());
+                       cur.idx() = tabular.getCellBelow(tabular.getLastCellInRow(row));
                } else {
                        if (cur.idx() == 0)
                                return;
                        --cur.idx();
                }
        } else {
+               lyxerr << "InsetTabular::moveNextCell B cur: " << endl;
                if (tabular.isLastCell(cur.idx()))
                        return;
                ++cur.idx();
        }
        cur.par() = 0;
        cur.pos() = 0;
-       lyxerr << "InsetTabular::moveNextCell 2 cur: " << cur << endl;
+       lyxerr << "InsetTabular::moveNextCell 2 cur: " << cur.top() << endl;
        resetPos(cur);
 }
 
@@ -1013,7 +1129,6 @@ void InsetTabular::tabularFeatures(LCursor & cur,
        LyXTabular::Feature feature, string const & value)
 {
        BufferView & bv = cur.bv();
-       int actcell = cur.idx();
        int sel_col_start;
        int sel_col_end;
        int sel_row_start;
@@ -1065,8 +1180,8 @@ void InsetTabular::tabularFeatures(LCursor & cur,
        recordUndo(cur, Undo::ATOMIC);
 
        getSelection(cur, sel_row_start, sel_row_end, sel_col_start, sel_col_end);
-       int row =  tabular.row_of_cell(actcell);
-       int column = tabular.column_of_cell(actcell);
+       int row = tabular.row_of_cell(cur.idx());
+       int column = tabular.column_of_cell(cur.idx());
        bool flag = true;
        LyXTabular::ltType ltt;
 
@@ -1074,34 +1189,33 @@ void InsetTabular::tabularFeatures(LCursor & cur,
 
        case LyXTabular::SET_PWIDTH: {
                LyXLength const len(value);
-               tabular.setColumnPWidth(actcell, len);
+               tabular.setColumnPWidth(cur.idx(), len);
                if (len.zero()
-                   && tabular.getAlignment(actcell, true) == LYX_ALIGN_BLOCK)
+                   && tabular.getAlignment(cur.idx(), true) == LYX_ALIGN_BLOCK)
                        tabularFeatures(cur, LyXTabular::ALIGN_CENTER, string());
                else if (!len.zero()
-                        && tabular.getAlignment(actcell, true) != LYX_ALIGN_BLOCK)
+                        && tabular.getAlignment(cur.idx(), true) != LYX_ALIGN_BLOCK)
                        tabularFeatures(cur, LyXTabular::ALIGN_BLOCK, string());
                break;
        }
 
        case LyXTabular::SET_MPWIDTH:
-               tabular.setMColumnPWidth(actcell, LyXLength(value));
+               tabular.setMColumnPWidth(cur.idx(), LyXLength(value));
                break;
 
        case LyXTabular::SET_SPECIAL_COLUMN:
        case LyXTabular::SET_SPECIAL_MULTI:
-               tabular.setAlignSpecial(actcell,value,feature);
+               tabular.setAlignSpecial(cur.idx(),value,feature);
                break;
 
        case LyXTabular::APPEND_ROW:
                // append the row into the tabular
-               tabular.appendRow(bv.buffer()->params(), actcell);
+               tabular.appendRow(bv.buffer()->params(), cur.idx());
                break;
 
        case LyXTabular::APPEND_COLUMN:
                // append the column into the tabular
-               tabular.appendColumn(bv.buffer()->params(), actcell);
-               actcell = tabular.getCellNumber(row, column);
+               tabular.appendColumn(bv.buffer()->params(), cur.idx());
                break;
 
        case LyXTabular::DELETE_ROW:
@@ -1109,7 +1223,9 @@ void InsetTabular::tabularFeatures(LCursor & cur,
                        tabular.deleteRow(sel_row_start);
                if (sel_row_start >= tabular.rows())
                        --sel_row_start;
-               actcell = tabular.getCellNumber(sel_row_start, column);
+               cur.idx() = tabular.getCellNumber(sel_row_start, column);
+               cur.par() = 0;
+               cur.pos() = 0;
                cur.selection() = false;
                break;
 
@@ -1118,14 +1234,16 @@ void InsetTabular::tabularFeatures(LCursor & cur,
                        tabular.deleteColumn(sel_col_start);
                if (sel_col_start >= tabular.columns())
                        --sel_col_start;
-               actcell = tabular.getCellNumber(row, sel_col_start);
+               cur.idx() = tabular.getCellNumber(row, sel_col_start);
+               cur.par() = 0;
+               cur.pos() = 0;
                cur.selection() = false;
                break;
 
        case LyXTabular::M_TOGGLE_LINE_TOP:
                flag = false;
        case LyXTabular::TOGGLE_LINE_TOP: {
-               bool lineSet = !tabular.topLine(actcell, flag);
+               bool lineSet = !tabular.topLine(cur.idx(), flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setTopLine(
@@ -1137,7 +1255,7 @@ void InsetTabular::tabularFeatures(LCursor & cur,
        case LyXTabular::M_TOGGLE_LINE_BOTTOM:
                flag = false;
        case LyXTabular::TOGGLE_LINE_BOTTOM: {
-               bool lineSet = !tabular.bottomLine(actcell, flag);
+               bool lineSet = !tabular.bottomLine(cur.idx(), flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setBottomLine(
@@ -1150,7 +1268,7 @@ void InsetTabular::tabularFeatures(LCursor & cur,
        case LyXTabular::M_TOGGLE_LINE_LEFT:
                flag = false;
        case LyXTabular::TOGGLE_LINE_LEFT: {
-               bool lineSet = !tabular.leftLine(actcell, flag);
+               bool lineSet = !tabular.leftLine(cur.idx(), flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setLeftLine(
@@ -1163,7 +1281,7 @@ void InsetTabular::tabularFeatures(LCursor & cur,
        case LyXTabular::M_TOGGLE_LINE_RIGHT:
                flag = false;
        case LyXTabular::TOGGLE_LINE_RIGHT: {
-               bool lineSet = !tabular.rightLine(actcell, flag);
+               bool lineSet = !tabular.rightLine(cur.idx(), flag);
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
                                tabular.setRightLine(
@@ -1215,11 +1333,11 @@ void InsetTabular::tabularFeatures(LCursor & cur,
 #if 0
                // just multicol for one Single Cell
                if (!hasSelection()) {
-                       // check wether we are completly in a multicol
-                       if (tabular.isMultiColumn(actcell))
-                               tabular.unsetMultiColumn(actcell);
+                       // check whether we are completly in a multicol
+                       if (tabular.isMultiColumn(cur.idx()))
+                               tabular.unsetMultiColumn(cur.idx());
                        else
-                               tabular.setMultiColumn(bv.buffer(), actcell, 1);
+                               tabular.setMultiColumn(bv.buffer(), cur.idx(), 1);
                        break;
                }
                // we have a selection so this means we just add all this
@@ -1235,7 +1353,9 @@ void InsetTabular::tabularFeatures(LCursor & cur,
                        s_end = sel_cell_end;
                }
                tabular.setMultiColumn(bv.buffer(), s_start, s_end - s_start + 1);
-               actcell = s_start;
+               cur.idx() = s_start;
+               cur.par() = 0;
+               cur.pos() = 0;
 #endif
                cur.selection() = false;
                break;
@@ -1284,7 +1404,7 @@ void InsetTabular::tabularFeatures(LCursor & cur,
 
        case LyXTabular::SET_USEBOX: {
                LyXTabular::BoxType val = LyXTabular::BoxType(strToInt(value));
-               if (val == tabular.getUsebox(actcell))
+               if (val == tabular.getUsebox(cur.idx()))
                        val = LyXTabular::BOX_NONE;
                for (int i = sel_row_start; i <= sel_row_end; ++i)
                        for (int j = sel_col_start; j <= sel_col_end; ++j)
@@ -1350,187 +1470,6 @@ void InsetTabular::openLayoutDialog(BufferView * bv) const
 }
 
 
-//
-// function returns an object as defined in func_status.h:
-// states OK, Unknown, Disabled, On, Off.
-//
-FuncStatus InsetTabular::getStatus(BufferView & bv,
-       string const & what, int actcell) const
-{
-       FuncStatus status;
-       int action = LyXTabular::LAST_ACTION;   
-       LCursor & cur = bv.cursor();
-
-       int i = 0;
-       for (; tabularFeature[i].action != LyXTabular::LAST_ACTION; ++i) {
-               string const tmp = tabularFeature[i].feature;
-               if (tmp == what.substr(0, tmp.length())) {
-                       //if (!compare(tabularFeatures[i].feature.c_str(), what.c_str(),
-                       //   tabularFeatures[i].feature.length()))
-                       action = tabularFeature[i].action;
-                       break;
-               }
-       }
-       if (action == LyXTabular::LAST_ACTION) {
-               status.clear();
-               status.unknown(true);
-               return status;
-       }
-
-       string const argument
-               = ltrim(what.substr(tabularFeature[i].feature.length()));
-
-       int sel_row_start = 0;
-       int sel_row_end = 0;
-       int dummy;
-       LyXTabular::ltType dummyltt;
-       bool flag = true;
-
-       getSelection(cur, sel_row_start, sel_row_end, dummy, dummy);
-
-       switch (action) {
-       case LyXTabular::SET_PWIDTH:
-       case LyXTabular::SET_MPWIDTH:
-       case LyXTabular::SET_SPECIAL_COLUMN:
-       case LyXTabular::SET_SPECIAL_MULTI:
-       case LyXTabular::APPEND_ROW:
-       case LyXTabular::APPEND_COLUMN:
-       case LyXTabular::DELETE_ROW:
-       case LyXTabular::DELETE_COLUMN:
-       case LyXTabular::SET_ALL_LINES:
-       case LyXTabular::UNSET_ALL_LINES:
-               status.clear();
-               return status;
-
-       case LyXTabular::MULTICOLUMN:
-               status.setOnOff(tabular.isMultiColumn(actcell));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_TOP:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_TOP:
-               status.setOnOff(tabular.topLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_BOTTOM:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_BOTTOM:
-               status.setOnOff(tabular.bottomLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_LEFT:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_LEFT:
-               status.setOnOff(tabular.leftLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_RIGHT:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_RIGHT:
-               status.setOnOff(tabular.rightLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_ALIGN_LEFT:
-               flag = false;
-       case LyXTabular::ALIGN_LEFT:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_LEFT);
-               break;
-
-       case LyXTabular::M_ALIGN_RIGHT:
-               flag = false;
-       case LyXTabular::ALIGN_RIGHT:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_RIGHT);
-               break;
-
-       case LyXTabular::M_ALIGN_CENTER:
-               flag = false;
-       case LyXTabular::ALIGN_CENTER:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_CENTER);
-               break;
-
-       case LyXTabular::ALIGN_BLOCK:
-               status.enabled(!tabular.getPWidth(actcell).zero());
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_BLOCK);
-               break;
-
-       case LyXTabular::M_VALIGN_TOP:
-               flag = false;
-       case LyXTabular::VALIGN_TOP:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_TOP);
-               break;
-
-       case LyXTabular::M_VALIGN_BOTTOM:
-               flag = false;
-       case LyXTabular::VALIGN_BOTTOM:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_BOTTOM);
-               break;
-
-       case LyXTabular::M_VALIGN_MIDDLE:
-               flag = false;
-       case LyXTabular::VALIGN_MIDDLE:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_MIDDLE);
-               break;
-
-       case LyXTabular::SET_LONGTABULAR:
-               status.setOnOff(tabular.isLongTabular());
-               break;
-
-       case LyXTabular::UNSET_LONGTABULAR:
-               status.setOnOff(!tabular.isLongTabular());
-               break;
-
-       case LyXTabular::SET_ROTATE_TABULAR:
-               status.setOnOff(tabular.getRotateTabular());
-               break;
-
-       case LyXTabular::UNSET_ROTATE_TABULAR:
-               status.setOnOff(!tabular.getRotateTabular());
-               break;
-
-       case LyXTabular::SET_ROTATE_CELL:
-               status.setOnOff(tabular.getRotateCell(actcell));
-               break;
-
-       case LyXTabular::UNSET_ROTATE_CELL:
-               status.setOnOff(!tabular.getRotateCell(actcell));
-               break;
-
-       case LyXTabular::SET_USEBOX:
-               status.setOnOff(strToInt(argument) == tabular.getUsebox(actcell));
-               break;
-
-       case LyXTabular::SET_LTFIRSTHEAD:
-               status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTHEAD:
-               status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTFOOT:
-               status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTLASTFOOT:
-               status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTNEWPAGE:
-               status.setOnOff(tabular.getLTNewPage(sel_row_start));
-               break;
-
-       default:
-               status.clear();
-               status.enabled(false);
-               break;
-       }
-       return status;
-}
-
-
 void InsetTabular::getLabelList(Buffer const & buffer,
                                vector<string> & list) const
 {
@@ -1572,7 +1511,7 @@ bool InsetTabular::copySelection(LCursor & cur)
 
        ostringstream os;
        OutputParams const runparams;
-       paste_tabular->plaintext(*cur.bv().buffer(), os, runparams, 0, true, '\t');
+       paste_tabular->plaintext(cur.buffer(), os, runparams, 0, true, '\t');
        cur.bv().stuffClipboard(os.str());
        return true;
 }
@@ -1582,9 +1521,8 @@ bool InsetTabular::pasteSelection(LCursor & cur)
 {
        if (!paste_tabular)
                return false;
-       int actcell = cur.idx();
-       int actcol = tabular.column_of_cell(actcell);
-       int actrow = tabular.row_of_cell(actcell);
+       int actcol = tabular.column_of_cell(cur.idx());
+       int actrow = tabular.row_of_cell(cur.idx());
        for (int r1 = 0, r2 = actrow;
             r1 < paste_tabular->rows() && r2 < tabular.rows();
             ++r1, ++r2) {
@@ -1616,18 +1554,26 @@ void InsetTabular::cutSelection(LCursor & cur)
        if (!cur.selection())
                return;
 
-       bool const track = cur.bv().buffer()->params().tracking_changes;
+       bool const track = cur.buffer().params().tracking_changes;
        int rs, re, cs, ce;
-       getSelection(cur, rs, re, cs, ce); 
+       getSelection(cur, rs, re, cs, ce);
        for (int i = rs; i <= re; ++i)
                for (int j = cs; j <= ce; ++j)
                        cell(tabular.getCellNumber(i, j)).clear(track);
+
+       // cursor position might be invalid now
+       cur.pos() = cur.lastpos();
+       cur.clearSelection();
 }
 
 
-bool InsetTabular::isRightToLeft(LCursor & cur)
+bool InsetTabular::isRightToLeft(LCursor & cur) const
 {
-       return cur.bv().getParentLanguage(this)->RightToLeft();
+       BOOST_ASSERT(cur.size() > 1);
+       Paragraph const & parentpar = cur[cur.size() - 2].paragraph();
+       LCursor::pos_type const parentpos = cur[cur.size() - 2].pos();
+       return parentpar.getFontSettings(cur.bv().buffer()->params(),
+                                        parentpos).language()->RightToLeft();
 }
 
 
@@ -1704,10 +1650,6 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
        string::size_type len = buf.length();
        string::size_type p = 0;
 
-       int actcell = bv.cursor().idx();
-       int actcol = tabular.column_of_cell(actcell);
-       int actrow = tabular.row_of_cell(actcell);
-
        while (p < len && (p = buf.find_first_of("\t\n", p)) != string::npos) {
                switch (buf[p]) {
                case '\t':
@@ -1734,9 +1676,9 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
                cols = 0;
        } else {
                loctab = &tabular;
-               cell = actcell;
-               ocol = actcol;
-               row = actrow;
+               cell = bv.cursor().idx();
+               ocol = tabular.column_of_cell(cell);
+               row = tabular.row_of_cell(cell);
        }
 
        string::size_type op = 0;
@@ -1756,7 +1698,8 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
                        // we can only set this if we are not too far right
                        if (cols < columns) {
                                InsetText & inset = loctab->getCellInset(cell);
-                               LyXFont const font = inset.text_.getFont(0, 0);
+                               Paragraph & par = inset.text_.getPar(0);
+                               LyXFont const font = inset.text_.getFont(par, 0);
                                inset.setText(buf.substr(op, p - op), font);
                                ++cols;
                                ++cell;
@@ -1766,7 +1709,8 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
                        // we can only set this if we are not too far right
                        if (cols < columns) {
                                InsetText & inset = tabular.getCellInset(cell);
-                               LyXFont const font = inset.text_.getFont(0, 0);
+                               Paragraph & par = inset.text_.getPar(0);
+                               LyXFont const font = inset.text_.getFont(par, 0);
                                inset.setText(buf.substr(op, p - op), font);
                        }
                        cols = ocol;
@@ -1781,7 +1725,8 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
        // check for the last cell if there is no trailing '\n'
        if (cell < cells && op < len) {
                InsetText & inset = loctab->getCellInset(cell);
-               LyXFont const font = inset.text_.getFont(0, 0);
+               Paragraph & par = inset.text_.getPar(0);
+               LyXFont const font = inset.text_.getFont(par, 0);
                inset.setText(buf.substr(op, len - op), font);
        }
        return true;
@@ -1801,7 +1746,7 @@ void InsetTabular::addPreview(PreviewLoader & loader) const
 
 bool InsetTabular::tablemode(LCursor & cur) const
 {
-       return cur.selBegin().idx() != cur.selEnd().idx();
+       return cur.selection() && cur.selBegin().idx() != cur.selEnd().idx();
 }
 
 
@@ -1827,7 +1772,9 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
        LyXLex lex(0,0);
        lex.setStream(data);
 
+#ifdef WITH_WARNINGS
 #warning CHECK verify that this is a sane value to return.
+#endif
        if (in.empty())
                return -1;
 
@@ -1872,11 +1819,12 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
 string const InsetTabularMailer::params2string(InsetTabular const & inset)
 {
        ostringstream data;
+#ifdef WITH_WARNINGS
 #warning wrong!
+#endif
        //data << name_ << " \\active_cell " << inset.getActCell() << '\n';
        data << name_ << " \\active_cell " << 0 << '\n';
        inset.write(inset.buffer(), data);
        data << "\\end_inset\n";
        return data.str();
 }
-