]> git.lyx.org Git - lyx.git/blobdiff - src/insets/insettabular.C
Just some changes to be able to change TabularFeatures with the Table menu
[lyx.git] / src / insets / insettabular.C
index faa3f38552e7e59263073a0b0a72530c1983cde6..633ba663b2d776ebf73a58ec1af9c8cdbb3a63ac 100644 (file)
@@ -26,6 +26,8 @@
 #include "LaTeXFeatures.h"
 #include "Painter.h"
 #include "font.h"
+#include "lyxtext.h"
+#include "lyx_gui_misc.h"
 #include "insets/insettext.h"
 
 const int ADD_TO_HEIGHT = 2;
@@ -51,7 +53,7 @@ InsetTabular::InsetTabular(Buffer * buf, int rows, int columns)
     buffer = buf;
     cursor_visible = false;
     cursor.x_fix = -1;
-    sel_pos_start = sel_pos_end = 0;
+    actcell = cursor.pos = sel_pos_start = sel_pos_end = 0;
     no_selection = false;
     init = true;
 }
@@ -64,7 +66,7 @@ InsetTabular::InsetTabular(InsetTabular const & tab, Buffer * buf)
     buffer = buf;
     cursor_visible = false;
     cursor.x_fix = -1;
-    sel_pos_start = sel_pos_end = 0;
+    actcell = cursor.pos = sel_pos_start = sel_pos_end = 0;
     no_selection = false;
     init = true;
 }
@@ -72,11 +74,11 @@ InsetTabular::InsetTabular(InsetTabular const & tab, Buffer * buf)
 
 InsetTabular::~InsetTabular()
 {
-        delete tabular;
+    delete tabular;
 }
 
 
-InsetTabular * InsetTabular::Clone() const
+Inset * InsetTabular::Clone() const
 {
     InsetTabular * t = new InsetTabular(*this, buffer);
     return t;
@@ -85,18 +87,31 @@ InsetTabular * InsetTabular::Clone() const
 
 void InsetTabular::Write(ostream & os) const
 {
-    os << "\\begin_inset Tabular\n";
-    tabular->Write(os,false);
-    os << "\\end_inset\n";
+    os << " Tabular" << endl;
+    tabular->Write(os);
 }
 
 
 void InsetTabular::Read(LyXLex & lex)
 {
-       delete tabular;
+//    bool old_format = (lex.GetString() == "\\LyXTable");
+    string token;
 
-//    bool old_format = (lex.GetString() == "\\LyXTabular");
+    if (tabular)
+       delete tabular;
     tabular = new LyXTabular(lex, buffer);
+
+    lex.nextToken();
+    token = lex.GetString();
+    while (lex.IsOK() && (token != "\\end_inset")) {
+       lex.nextToken();
+       token = lex.GetString();
+    }
+    if (token != "\\end_inset") {
+        lex.printError("Missing \\end_inset at this point. "
+                       "Read: `$$Token'");
+    }
+    tabular->SetLongTabular(true);
     init = true;
 }
 
@@ -107,7 +122,7 @@ int InsetTabular::ascent(Painter & pain, LyXFont const & font) const
        calculate_width_of_cells(pain, font);
        init = false;
     }
-    return tabular->AscentOfRow(0);
+    return tabular->GetAscentOfRow(0);
 }
 
 
@@ -117,7 +132,7 @@ int InsetTabular::descent(Painter & pain, LyXFont const & font) const
        calculate_width_of_cells(pain, font);
        init = false;
     }
-    return tabular->HeightOfTabular() - tabular->AscentOfRow(0);
+    return tabular->GetHeightOfTabular() - tabular->GetAscentOfRow(0);
 }
 
 
@@ -127,7 +142,7 @@ int InsetTabular::width(Painter & pain, LyXFont const & font) const
        calculate_width_of_cells(pain, font);
        init = false;
     }
-    return tabular->WidthOfTabular() + (2 * ADD_TO_TABULAR_WIDTH);
+    return tabular->GetWidthOfTabular() + (2 * ADD_TO_TABULAR_WIDTH);
 }
 
 
@@ -136,28 +151,64 @@ void InsetTabular::draw(Painter & pain, const LyXFont & font, int baseline,
 {
     int i, j, cell=0;
     int nx;
+    float cx;
 
     UpdatableInset::draw(pain,font,baseline,x);
-    if (top_x != int(x)) {
-       int ox = top_x;
+    if ((top_x != int(x)) || (top_baseline != baseline)) {
        top_x = int(x);
-       setPos(pain, cursor.x - ox - 2, cursor.y);
+       top_baseline = baseline;
+       resetPos(pain);
     }
-    top_baseline = baseline;
-    calculate_width_of_cells(pain, font);
     for(i=0;i<tabular->rows();++i) {
        nx = int(x);
         for(j=0;j<tabular->columns();++j) {
+           cx = nx + tabular->GetBeginningOfTextInCell(cell);
+           tabular->GetCellInset(cell)->draw(pain, font, baseline, cx);
            DrawCellLines(pain, nx, baseline, i, cell);
-           nx += tabular->WidthOfColumn(cell);
+           nx += tabular->GetWidthOfColumn(cell);
            ++cell;
        }
-        baseline += tabular->DescentOfRow(i) + tabular->AscentOfRow(i+1)
-            + tabular->AdditionalHeight(cell+1);
+        baseline += tabular->GetDescentOfRow(i) + tabular->GetAscentOfRow(i+1)
+            + tabular->GetAdditionalHeight(cell+1);
     }
 }
 
 
+void InsetTabular::DrawCellLines(Painter & pain, int x, int baseline,
+                                 int row, int cell) const
+{
+    int  x2 = x + tabular->GetWidthOfColumn(cell);
+    bool on_off;
+
+    if (!tabular->TopAlreadyDrawed(cell)) {
+       on_off = !tabular->TopLine(cell);
+       pain.line(x, baseline - tabular->GetAscentOfRow(row),
+                 x2, baseline -  tabular->GetAscentOfRow(row),
+                 on_off ? LColor::tabularonoffline:LColor::tabularline,
+                 on_off ? Painter::line_onoffdash:Painter::line_solid);
+    }
+    on_off = !tabular->BottomLine(cell);
+    pain.line(x,baseline +  tabular->GetDescentOfRow(row),
+             x2, baseline +  tabular->GetDescentOfRow(row),
+             on_off ? LColor::tabularonoffline:LColor::tabularline,
+             on_off ? Painter::line_onoffdash:Painter::line_solid);
+    if (!tabular->LeftAlreadyDrawed(cell)) {
+       on_off = !tabular->LeftLine(cell);
+       pain.line(x, baseline -  tabular->GetAscentOfRow(row),
+                 x, baseline +  tabular->GetDescentOfRow(row),
+                 on_off ? LColor::tabularonoffline:LColor::tabularline,
+                 on_off ? Painter::line_onoffdash:Painter::line_solid);
+    }
+    on_off = !tabular->RightLine(cell);
+    pain.line(x2 - tabular->GetAdditionalWidth(cell),
+              baseline -  tabular->GetAscentOfRow(row),
+              x2 - tabular->GetAdditionalWidth(cell),
+              baseline +  tabular->GetDescentOfRow(row),
+             on_off ? LColor::tabularonoffline:LColor::tabularline,
+              on_off ? Painter::line_onoffdash:Painter::line_solid);
+}
+
+
 char const * InsetTabular::EditMessage() const
 {
     return _("Opened Tabular Inset");
@@ -176,7 +227,10 @@ void InsetTabular::Edit(BufferView * bv, int x, int y, unsigned int button)
     sel_pos_start = sel_pos_end = inset_pos = inset_x = inset_y = 0;
     setPos(bv->painter(), x, y);
     sel_pos_start = sel_pos_end = cursor.pos;
-//    bv->text->FinishUndo();
+    bv->text->FinishUndo();
+    if (InsetHit(bv, x, y)) {
+       ActivateCellInset(bv, x, y, button);
+    }
     UpdateLocal(bv, true);
 //    bv->getOwner()->getPopups().updateFormTabular();
 }
@@ -184,10 +238,11 @@ void InsetTabular::Edit(BufferView * bv, int x, int y, unsigned int button)
 
 void InsetTabular::InsetUnlock(BufferView * bv)
 {
-    if (the_locking_inset)
+    if (the_locking_inset) {
        the_locking_inset->InsetUnlock(bv);
+       the_locking_inset = 0;
+    }
     HideInsetCursor(bv);
-    the_locking_inset = 0;
     if (hasCharSelection()) {
        sel_pos_start = sel_pos_end = cursor.pos;
        UpdateLocal(bv, false);
@@ -196,36 +251,60 @@ void InsetTabular::InsetUnlock(BufferView * bv)
     no_selection = false;
 }
 
-
-bool InsetTabular::LockInsetInInset(UpdatableInset *)
+void InsetTabular::UpdateLocal(BufferView * bv, bool flag)
 {
-    return true;
+    if (flag) {
+       calculate_width_of_cells(bv->painter(), LyXFont(LyXFont::ALL_SANE));
+       resetPos(bv->painter());
+    }
+    bv->updateInset(this, flag);
 }
 
-
-bool InsetTabular::UnlockInsetInInset(BufferView * bv, UpdatableInset * inset,
-                                     bool lr)
+bool InsetTabular::LockInsetInInset(BufferView * bv, UpdatableInset * inset)
 {
-    if (!the_locking_inset)
+    lyxerr[Debug::INSETS] << "InsetTabular::LockInsetInInset(" <<inset<< "): ";
+    if (!inset)
        return false;
-    if (the_locking_inset == inset) {
-       the_locking_inset->InsetUnlock(bv);
-       the_locking_inset = 0;
-       if (lr)
-           moveRight(bv);
+    if (inset == tabular->GetCellInset(actcell)) {
+       lyxerr[Debug::INSETS] << "OK" << endl;
+       the_locking_inset = tabular->GetCellInset(actcell);
+       resetPos(bv->painter());
+       inset_x = cursor.x - top_x + tabular->GetBeginningOfTextInCell(actcell);
+       inset_y = cursor.y;
+       inset_pos = cursor.pos;
        return true;
+    } else if (the_locking_inset && (the_locking_inset == inset)) {
+       if (cursor.pos == inset_pos) {
+           lyxerr[Debug::INSETS] << "OK" << endl;
+           resetPos(bv->painter());
+           inset_x = cursor.x - top_x + tabular->GetBeginningOfTextInCell(actcell);
+           inset_y = cursor.y;
+       } else {
+           lyxerr[Debug::INSETS] << "cursor.pos != inset_pos" << endl;
+       }
+    } else if (the_locking_inset) {
+       lyxerr[Debug::INSETS] << "MAYBE" << endl;
+       return the_locking_inset->LockInsetInInset(bv, inset);
     }
-    return the_locking_inset->UnlockInsetInInset(bv, inset, lr);
+    lyxerr[Debug::INSETS] << "NOT OK" << endl;
+    return false;
 }
 
-
-void InsetTabular::UpdateLocal(BufferView * bv, bool flag)
+bool InsetTabular::UnlockInsetInInset(BufferView * bv, UpdatableInset * inset,
+                                  bool lr)
 {
-//    resetPos();
-    bv->updateInset(this, flag);
+    if (!the_locking_inset)
+        return false;
+    if (the_locking_inset == inset) {
+        the_locking_inset->InsetUnlock(bv);
+        the_locking_inset = 0;
+        if (lr)
+            moveRight(bv, false);
+        return true;
+    }
+    return the_locking_inset->UnlockInsetInInset(bv, inset, lr);
 }
 
-
 bool InsetTabular::UpdateInsetInInset(BufferView * bv, Inset * inset)
 {
     if (!the_locking_inset)
@@ -237,35 +316,53 @@ bool InsetTabular::UpdateInsetInInset(BufferView * bv, Inset * inset)
 }
 
 
+int InsetTabular::InsetInInsetY()
+{
+    if (!the_locking_inset)
+       return 0;
+
+    return (inset_y + the_locking_inset->InsetInInsetY());
+}
+
 void InsetTabular::InsetButtonRelease(BufferView * bv,
                                      int x, int y, int button)
 {
     if (the_locking_inset) {
-        the_locking_inset->InsetButtonRelease(bv, x-inset_x,y-inset_y,button);
+        the_locking_inset->InsetButtonRelease(bv, x-inset_x, y-inset_y,button);
         return;
     }
     no_selection = false;
 }
 
 
-void InsetTabular::InsetButtonPress(BufferView * bv, int x, int y, int)
+void InsetTabular::InsetButtonPress(BufferView * bv, int x, int y, int button)
 {
     if (hasCharSelection()) {
        sel_pos_start = sel_pos_end = 0;
        UpdateLocal(bv, false);
     }
     no_selection = false;
-    if (the_locking_inset) {
-       // otherwise only unlock the_locking_inset
+
+    int oldcell = actcell;
+
+    setPos(bv->painter(), x, y);
+
+    bool inset_hit = InsetHit(bv, x, y);
+
+    if ((oldcell == actcell) && the_locking_inset && inset_hit) {
+        the_locking_inset->InsetButtonPress(bv, x-inset_x, y-inset_y, button);
+        return;
+    } else if (the_locking_inset) {
        the_locking_inset->InsetUnlock(bv);
     }
-#if 0
-    int oldcell = actcell;
-#endif
-    setPos(bv->painter(),x,y);
     the_locking_inset = 0;
     sel_pos_start = sel_pos_end = cursor.pos;
     sel_cell_start = sel_cell_end = actcell;
+    if (inset_hit && bv->the_locking_inset) {
+       ActivateCellInset(bv, x, y, button);
+       the_locking_inset->InsetButtonPress(bv, x-inset_x, y-inset_y, button);
+    }
+    
 #if 0
     if (button == 3)
         bview->getOwner()->getPopups().showFormTabular();
@@ -319,7 +416,7 @@ UpdatableInset::RESULT InsetTabular::LocalDispatch(BufferView * bv, int action,
     if (((result=UpdatableInset::LocalDispatch(bv, action, arg)) == DISPATCHED)
        || (result == DISPATCHED_NOUPDATE)) {
 
-       resetPos(bv);
+       resetPos(bv->painter());
        return result;
     }
     result=DISPATCHED;
@@ -335,15 +432,15 @@ UpdatableInset::RESULT InsetTabular::LocalDispatch(BufferView * bv, int action,
        if (result == DISPATCHED_NOUPDATE)
            return result;
        else if (result == DISPATCHED) {
-            setWidthOfCell(cursor.pos,actcell,actrow);
+            bool upd = SetCellDimensions(bv->painter(), actcell, actrow);
            the_locking_inset->ToggleInsetCursor(bv);
-           UpdateLocal(bv, false);
+           UpdateLocal(bv, upd);
            the_locking_inset->ToggleInsetCursor(bv);
             return result;
         } else if (result == FINISHED) {
            if ((action == LFUN_RIGHT) || (action == -1)) {
                cursor.pos = inset_pos + 1;
-               resetPos(bv);
+               resetPos(bv->painter());
            }
            the_locking_inset=0;
            result = DISPATCHED;
@@ -358,7 +455,7 @@ UpdatableInset::RESULT InsetTabular::LocalDispatch(BufferView * bv, int action,
          break;
       // --- Cursor Movements ---------------------------------------------
       case LFUN_RIGHTSEL:
-          moveRight(bv);
+          moveRight(bv, false);
          sel_pos_end = cursor.pos;
          UpdateLocal(bv, false);
          break;
@@ -371,12 +468,12 @@ UpdatableInset::RESULT InsetTabular::LocalDispatch(BufferView * bv, int action,
              sel_pos_start = sel_pos_end = cursor.pos;
           break;
       case LFUN_LEFTSEL:
-          moveLeft();
+          moveLeft(bv, false);
          sel_pos_end = cursor.pos;
          UpdateLocal(bv, false);
          break;
       case LFUN_LEFT:
-          result= moveLeft();
+          result = moveLeft(bv);
          if (hasCharSelection()) {
              sel_pos_start = sel_pos_end = cursor.pos;
              UpdateLocal(bv, false);
@@ -476,63 +573,28 @@ void InsetTabular::Validate(LaTeXFeatures & features) const
 void InsetTabular::calculate_width_of_cells(Painter & pain,
                                            LyXFont const & font) const
 {
-       int cell = -1;
-        int maxAsc, maxDesc;
-       InsetText * inset;
+    int cell = -1;
+    int maxAsc, maxDesc;
+    InsetText * inset;
     
-       for(int i = 0; i < tabular->rows(); ++i) {
-               maxAsc = maxDesc = 0;
-               for(int j= 0; j < tabular->columns(); ++j) {
-                       if (tabular->IsPartOfMultiColumn(i,j))
-                               continue;
-                       ++cell;
-                       inset = tabular->GetCellInset(cell);
-                       maxAsc = max(maxAsc, inset->ascent(pain, font));
-                       maxDesc = max(maxDesc, inset->descent(pain, font));
-                       tabular->SetWidthOfCell(cell,
-                                               inset->width(pain, font));
-               }
-               tabular->SetAscentOfRow(i, maxAsc + ADD_TO_HEIGHT);
-               tabular->SetDescentOfRow(i, maxDesc + ADD_TO_HEIGHT);
+    for(int i = 0; i < tabular->rows(); ++i) {
+       maxAsc = maxDesc = 0;
+       for(int j= 0; j < tabular->columns(); ++j) {
+           if (tabular->IsPartOfMultiColumn(i,j))
+               continue;
+           ++cell;
+           inset = tabular->GetCellInset(cell);
+           maxAsc = max(maxAsc, inset->ascent(pain, font));
+           maxDesc = max(maxDesc, inset->descent(pain, font));
+           tabular->SetWidthOfCell(cell, inset->width(pain, font));
        }
+       tabular->SetAscentOfRow(i, maxAsc + ADD_TO_HEIGHT);
+       tabular->SetDescentOfRow(i, maxDesc + ADD_TO_HEIGHT);
+    }
 }
 
 
-void InsetTabular::DrawCellLines(Painter & pain, int x, int baseline,
-                                 int row, int cell) const
-{
-    // Juergen, have you thought about drawing the on-off lines in a
-    // different color (gray of some kind), especially since those
-    // lines will not be there on the hardcopy anyway. (Lgb)
-    int  x2 = x + tabular->WidthOfColumn(cell);
-    bool on_off = !tabular->TopLine(cell);
-
-    if (!tabular->TopAlreadyDrawed(cell))
-       pain.line(x, baseline - tabular->AscentOfRow(row),
-                 x2, baseline -  tabular->AscentOfRow(row),
-                 on_off ? LColor::tabularonoffline:LColor::tabularline,
-                 on_off ? Painter::line_onoffdash:Painter::line_solid);
-    on_off = !tabular->BottomLine(cell);
-    pain.line(x,baseline +  tabular->DescentOfRow(row),
-             x2, baseline +  tabular->DescentOfRow(row),
-             on_off ? LColor::tabularonoffline:LColor::tabularline,
-             on_off ? Painter::line_onoffdash:Painter::line_solid);
-    on_off = !tabular->LeftLine(cell);
-    pain.line(x, baseline -  tabular->AscentOfRow(row),
-              x, baseline +  tabular->DescentOfRow(row),
-             on_off ? LColor::tabularonoffline:LColor::tabularline,
-              on_off ? Painter::line_onoffdash:Painter::line_solid);
-    on_off = !tabular->RightLine(cell);
-    pain.line(x2 - tabular->AdditionalWidth(cell),
-              baseline -  tabular->AscentOfRow(row),
-              x2 - tabular->AdditionalWidth(cell),
-              baseline +  tabular->DescentOfRow(row),
-             on_off ? LColor::tabularonoffline:LColor::tabularline,
-              on_off ? Painter::line_onoffdash:Painter::line_solid);
-}
-
-
-void InsetTabular::GetCursorPos(int & x, int & y)
+void InsetTabular::GetCursorPos(int & x, int & y) const
 {
     x = cursor.x-top_x;
     y = cursor.y;
@@ -580,80 +642,120 @@ void InsetTabular::HideInsetCursor(BufferView * bv)
 }
 
 
-void InsetTabular::setPos(Painter &, int x, int y) const
+void InsetTabular::setPos(Painter & pain, int x, int y) const
 {
     cursor.y = cursor.pos = actcell = actrow = actcol = 0;
-    int ly = tabular->DescentOfRow(actrow);
+    int ly = tabular->GetDescentOfRow(actrow);
 
     // first search the right row
     while((ly < y) && (actrow < tabular->rows())) {
-        cursor.y += tabular->DescentOfRow(actrow) +
-               tabular->AscentOfRow(actrow+1) +
-            tabular->AdditionalHeight(tabular->GetCellNumber(actcol,actrow+1));
+        cursor.y += tabular->GetDescentOfRow(actrow) +
+               tabular->GetAscentOfRow(actrow+1) +
+            tabular->GetAdditionalHeight(tabular->GetCellNumber(actcol,actrow+1));
         ++actrow;
-        ly = cursor.y + tabular->DescentOfRow(actrow);
+        ly = cursor.y + tabular->GetDescentOfRow(actrow);
     }
     actcell = tabular->GetCellNumber(actcol, actrow);
 
     // now search the right column
-    int lx = tabular->GetWidthOfCell(actcell);
-    for(;
-       !tabular->IsLastCellInRow(actcell) && (lx < x);
-       ++actcell,lx += tabular->GetWidthOfCell(actcell)) {}
-    cursor.x = lx - tabular->GetWidthOfCell(actcell) + top_x + 2;
+    int lx = tabular->GetWidthOfColumn(actcell) -
+       tabular->GetAdditionalWidth(actcell);
+    for(; !tabular->IsLastCellInRow(actcell) && (lx < x);
+       ++actcell,lx += tabular->GetWidthOfColumn(actcell) +
+           tabular->GetAdditionalWidth(actcell-1));
+    cursor.pos = ((actcell+1) * 2) - 1;
+    resetPos(pain);
+    if ((lx - (tabular->GetWidthOfColumn(actcell)/2)) < x) {
+       cursor.x = lx + top_x - 2;
+    } else {
+       --cursor.pos;
+       cursor.x = lx - tabular->GetWidthOfColumn(actcell) + top_x + 2;
+    }
+    resetPos(pain);
 }
 
 
-void InsetTabular::resetPos(BufferView * bv)
+void InsetTabular::resetPos(Painter & pain) const
 {
     actrow = cursor.y = actcol = 0;
 
     int cell = 0;
     for(; (cell<actcell) && !tabular->IsLastRow(cell); ++cell) {
        if (tabular->IsLastCellInRow(cell)) {
-           cursor.y += tabular->DescentOfRow(actrow) +
-               tabular->AscentOfRow(actrow+1) +
-               tabular->AdditionalHeight(cell+1);
+           cursor.y += tabular->GetDescentOfRow(actrow) +
+               tabular->GetAscentOfRow(actrow+1) +
+               tabular->GetAdditionalHeight(cell+1);
            ++actrow;
        }
     }
     for(cell=actcell;!tabular->IsFirstCellInRow(cell);--cell)
        ;
-    int lx = tabular->GetWidthOfCell(actcell);
+    int lx = tabular->GetWidthOfColumn(actcell);
     for(; (cell < actcell); ++cell) {
-       lx += tabular->GetWidthOfCell(actcell);
+       lx += tabular->GetWidthOfColumn(cell);
        ++actcol;
     }
-    cursor.x = lx - tabular->GetWidthOfCell(actcell) + top_x + 2;
+    cursor.x = lx - tabular->GetWidthOfColumn(actcell) + top_x + 2;
     if (cursor.pos % 2) {
        LyXFont font(LyXFont::ALL_SANE);
-       cursor.x += tabular->GetCellInset(actcell)->width(bv->painter(),font);
+       cursor.x += tabular->GetCellInset(actcell)->width(pain,font) +
+               tabular->GetBeginningOfTextInCell(actcell);
     }
 }
 
 
-void InsetTabular::setWidthOfCell(int, int, int)
+bool InsetTabular::SetCellDimensions(Painter & pain, int cell, int row)
 {
+    InsetText * inset = tabular->GetCellInset(cell);
+    LyXFont font(LyXFont::ALL_SANE);
+    int asc = inset->ascent(pain, font) + ADD_TO_HEIGHT;
+    int desc = inset->descent(pain, font) + ADD_TO_HEIGHT;
+    int maxAsc = tabular->GetAscentOfRow(row);
+    int maxDesc = tabular->GetDescentOfRow(row);
+    bool ret = tabular->SetWidthOfCell(cell, inset->width(pain, font));
+
+    if (maxAsc < asc) {
+       ret = true;
+       tabular->SetAscentOfRow(row, asc);
+    }
+    if (maxDesc < desc) {
+       ret = true;
+       tabular->SetDescentOfRow(row, desc);
+    }
+    return ret;
 }
 
 
-UpdatableInset::RESULT InsetTabular::moveRight(BufferView * bv)
+UpdatableInset::RESULT InsetTabular::moveRight(BufferView * bv, bool lock)
 {
     if (cursor.pos % 2) { // behind the inset
        ++actcell;
        if (actcell >= tabular->GetNumberOfCells())
            return FINISHED;
        ++cursor.pos;
+    } else if (lock) {
+       if (ActivateCellInset(bv))
+           return DISPATCHED;
     } else {              // before the inset
        ++cursor.pos;
     }
-    resetPos(bv);
+    resetPos(bv->painter());
     return DISPATCHED_NOUPDATE;
 }
 
 
-UpdatableInset::RESULT InsetTabular::moveLeft()
+UpdatableInset::RESULT InsetTabular::moveLeft(BufferView * bv, bool lock)
 {
+    if (!cursor.pos)
+       return FINISHED;
+    --cursor.pos;
+    if (cursor.pos % 2) { // behind the inset
+       --actcell;
+    } else if (lock) {       // behind the inset
+       if (ActivateCellInset(bv, -1, -1))
+           return DISPATCHED;
+    }
+    resetPos(bv->painter());
     return DISPATCHED_NOUPDATE;
 }
 
@@ -688,14 +790,13 @@ bool InsetTabular::Delete()
 }
 
 
-void  InsetTabular::SetFont(LyXFont const &)
+void InsetTabular::SetFont(BufferView *, LyXFont const &, bool)
 {
 }
 
 
-void InsetTabular::TabularFeatures(int, string)
+void InsetTabular::TabularFeatures(BufferView * bv, int feature, string val)
 {
-#if 0
     int
        i,
        sel_pos_start,
@@ -739,183 +840,62 @@ void InsetTabular::TabularFeatures(int, string)
           break;
       case LyXTabular::APPEND_ROW:
       {
-         int
-              pos = cursor.pos,
-              cell_org = actcell,
-              cell = actcell;
-
-          // if there is a ContRow following this row I have to add
-          // the row after the ContRow's
-          if ((pos < par->last()) && tabular->RowHasContRow(cell_org)) {
-              while((pos < par->last()) && !tabular->IsContRow(cell)) {
-                  while (pos < par->last() && !par->IsNewline(pos))
-                      ++pos;
-                  if (pos < par->last())
-                      ++pos;
-                  ++cell;
-              }
-              while((pos < par->last()) && tabular->IsContRow(cell)) {
-                  while (pos < par->last() && !par->IsNewline(pos))
-                      ++pos;
-                  if (pos < par->last())
-                      ++pos;
-                  ++cell;
-              }
-              cell_org = --cell;
-              if (pos < par->last())
-                  --pos;
-          }
-          while ((pos < par->last()) && 
-                 ((cell == cell_org) || !tabular->IsFirstCell(cell))) {
-              while ((pos < par->last()) && !par->IsNewline(pos))
-                  ++pos;
-              if (pos < par->last())
-                  ++pos;
-              ++cell;
-          }
-          // insert the new cells
-          int number = tabular->NumberOfCellsInRow(cell_org);
-          for (i=0; i<number; ++i)
-              par->InsertChar(pos, LYX_META_NEWLINE);
-               
           // append the row into the tabular
-          tabular->AppendRow(cell_org);
-          calculate_width_of_cells();
-          UpdateLocal();
-          return;
-      }
-      case LyXTabular::APPEND_CONT_ROW:
-      {
-         int
-              pos = cursor.pos,
-              cell_org = actcell,
-              cell = actcell;
-
-          // if there is already a controw but not for this cell
-          // the AppendContRow sets only the right values but does
-          // not actually add a row
-          if (tabular->RowHasContRow(cell_org) &&
-              (tabular->CellHasContRow(cell_org) < 0)) {
-              tabular->AppendContRow(cell_org);
-              calculate_width_of_cells();
-              UpdateLocal();
-              return;
-          }
-          while ((pos < par->last()) &&
-                 ((cell == cell_org) || !tabular->IsFirstCell(cell))) {
-              while (pos < par->last() && !par->IsNewline(pos))
-                  ++pos;
-              if (pos < par->last())
-                  ++pos;
-              ++cell;
-          }
-          // insert the new cells
-          int number = tabular->NumberOfCellsInRow(cell_org);
-          for (i=0; i<number; ++i)
-              par->InsertChar(pos, LYX_META_NEWLINE);
-          // append the row into the tabular
-          tabular->AppendContRow(cell_org);
-          calculate_width_of_cells();
-          UpdateLocal();
+          tabular->AppendRow(actcell);
+          UpdateLocal(bv, true);
           return;
       }
       case LyXTabular::APPEND_COLUMN:
       { 
-         int
-              pos = 0,
-              cell_org = actcell,
-              cell = 0;
-          do {
-              if (pos && (par->IsNewline(pos-1))) {
-                  if (tabular->AppendCellAfterCell(cell_org, cell)) {
-                      par->InsertChar(pos, LYX_META_NEWLINE);
-                      if (pos <= cursor.pos)
-                          ++cursor.pos;
-                      ++pos;
-                  }
-                  ++cell;
-              }
-              ++pos;
-          } while (pos <= par->last());
-          // remember that the very last cell doesn't end with a newline.
-          // This saves one byte memory per tabular ;-)
-          if (tabular->AppendCellAfterCell(cell_org, cell))
-              par->InsertChar(par->last(), LYX_META_NEWLINE);
           // append the column into the tabular
-          tabular->AppendColumn(cell_org);
-          calculate_width_of_cells();
-          UpdateLocal();
+          tabular->AppendColumn(actcell);
+          UpdateLocal(bv, true);
           return;
       }
       case LyXTabular::DELETE_ROW:
           RemoveTabularRow();
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
       case LyXTabular::DELETE_COLUMN:
       {
-          int pos = 0;
-          int cell = 0;
-          do {
-              if (!pos || (par->IsNewline(pos-1))){
-                  if (tabular->DeleteCellIfColumnIsDeleted(cell, actcell)) {
-                      // delete one cell
-                      while (pos < par->last() && !par->IsNewline(pos))
-                          par->Erase(pos);
-                      if (pos < par->last())
-                          par->Erase(pos);
-                      else 
-                          par->Erase(pos - 1); // the missing newline
-                                               // at the end of a tabular
-                      --pos; // because of ++pos below
-                  }
-                  ++cell;
-              }
-              ++pos;
-          } while (pos <= par->last());
           /* delete the column from the tabular */ 
           tabular->DeleteColumn(actcell);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
       }
       case LyXTabular::TOGGLE_LINE_TOP:
           lineSet = !tabular->TopLine(actcell);
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetTopLine(i,lineSet);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
     
       case LyXTabular::TOGGLE_LINE_BOTTOM:
           lineSet = !tabular->BottomLine(actcell); 
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetBottomLine(i,lineSet);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
                
       case LyXTabular::TOGGLE_LINE_LEFT:
           lineSet = !tabular->LeftLine(actcell);
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetLeftLine(i,lineSet);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
 
       case LyXTabular::TOGGLE_LINE_RIGHT:
           lineSet = !tabular->RightLine(actcell);
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetRightLine(i,lineSet);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
       case LyXTabular::ALIGN_LEFT:
       case LyXTabular::ALIGN_RIGHT:
       case LyXTabular::ALIGN_CENTER:
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetAlignment(i,setAlign);
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
       case LyXTabular::MULTICOLUMN:
       {
@@ -930,26 +910,17 @@ void InsetTabular::TabularFeatures(int, string)
          if (!hasCellSelection()) {
              // check wether we are completly in a multicol
              if (tabular->IsMultiColumn(actcell)) {
-                 int
-                     newlines,
-                     pos = cursor.pos;
-                 if ((newlines=tabular->UnsetMultiColumn(actcell))) {
-                     while ((pos < par->last()) && !par->IsNewline(pos))
-                         ++pos;
-                     for (;newlines;--newlines)
-                         par->InsertChar(pos, LYX_META_NEWLINE);
-                 }
-                 calculate_width_of_cells();
+                 tabular->UnsetMultiColumn(actcell);
+                 UpdateLocal(bv, true);
              } else {
                  tabular->SetMultiColumn(actcell, 1);
+                 UpdateLocal(bv, false);
              }
-             UpdateLocal();
              return;
          }
          // we have a selection so this means we just add all this
          // cells to form a multicolumn cell
          int
-             number = 1,
              s_start, s_end;
 
          if (sel_pos_start > sel_pos_end) {
@@ -959,23 +930,10 @@ void InsetTabular::TabularFeatures(int, string)
              s_start = sel_pos_start;
              s_end = sel_pos_end;
          }
-         for(i=s_start; i < s_end; ++i) {
-             if (par->IsNewline(i)) {
-                 par->Erase(i);
-                 // check for double-blanks
-                 if ((i && !par->IsLineSeparator(i-1)) &&
-                     (i < par->last()) && !par->IsLineSeparator(i))
-                     par->InsertChar(i, ' ');
-                 else
-                     --i;
-                 ++number;
-             }
-         }
-         tabular->SetMultiColumn(sel_pos_start,number);
+         tabular->SetMultiColumn(s_start, s_end);
          cursor.pos = s_start;
          sel_cell_end = sel_cell_start;
-         calculate_width_of_cells();
-         UpdateLocal();
+         UpdateLocal(bv, true);
           return;
       }
       case LyXTabular::SET_ALL_LINES:
@@ -983,16 +941,15 @@ void InsetTabular::TabularFeatures(int, string)
       case LyXTabular::UNSET_ALL_LINES:
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetAllLines(i, setLines);
-          calculate_width_of_cells();
-          UpdateLocal();
+          UpdateLocal(bv, true);
           return;
       case LyXTabular::SET_LONGTABULAR:
           tabular->SetLongTabular(true);
-         UpdateLocal(); // because this toggles displayed
+         UpdateLocal(bv, true); // because this toggles displayed
           return;
       case LyXTabular::UNSET_LONGTABULAR:
           tabular->SetLongTabular(false);
-         UpdateLocal(); // because this toggles displayed
+         UpdateLocal(bv, true); // because this toggles displayed
           return;
       case LyXTabular::SET_ROTATE_TABULAR:
           tabular->SetRotateTabular(true);
@@ -1009,7 +966,7 @@ void InsetTabular::TabularFeatures(int, string)
              tabular->SetRotateCell(i,false);
           return;
       case LyXTabular::SET_LINEBREAKS:
-          what = !tabular->Linebreaks(tabular->FirstVirtualCell(actcell));
+          what = !tabular->GetLinebreaks(actcell);
          for(i=sel_pos_start; i<=sel_pos_end; ++i)
              tabular->SetLinebreaks(i,what);
           return;
@@ -1026,13 +983,53 @@ void InsetTabular::TabularFeatures(int, string)
           tabular->SetLTFoot(actcell,true);
           return;
       case LyXTabular::SET_LTNEWPAGE:
-          what = !tabular->LTNewPage(actcell);
+          what = !tabular->GetLTNewPage(actcell);
           tabular->SetLTNewPage(actcell,what);
           return;
     }
-#endif
 }
 
 void InsetTabular::RemoveTabularRow()
 {
 }
+
+bool InsetTabular::ActivateCellInset(BufferView * bv, int x, int y, int button)
+{
+    // the cursor.pos has to be before the inset so if it isn't now just
+    // reset the curor pos first!
+    if (cursor.pos % 2) { // behind the inset
+       --cursor.pos;
+       resetPos(bv->painter());
+    }
+    UpdatableInset * inset =
+       static_cast<UpdatableInset*>(tabular->GetCellInset(actcell));
+    LyXFont font(LyXFont::ALL_SANE);
+    if (x < 0)
+       x = inset->width(bv->painter(), font) + top_x;
+    if (y < 0)
+       y = inset->descent(bv->painter(), font);
+    inset_x = cursor.x - top_x + tabular->GetBeginningOfTextInCell(actcell);
+    inset_y = cursor.y;
+    inset->Edit(bv, x-inset_x, y-inset_y, button);
+    if (!the_locking_inset)
+       return false;
+    UpdateLocal(bv, true);
+    return true;
+}
+
+bool InsetTabular::InsetHit(BufferView * bv, int x, int ) const
+{
+    InsetText * inset = tabular->GetCellInset(actcell);
+    int x1 = x + top_x;
+
+    if (cursor.pos % 2) { // behind the inset
+       return (((x+top_x) < cursor.x) &&
+               ((x+top_x) > (cursor.x - inset->width(bv->painter(),
+                                                     LyXFont(LyXFont::ALL_SANE)))));
+    } else {
+       int x2 = cursor.x + tabular->GetBeginningOfTextInCell(actcell);
+       return ((x1 > x2) &&
+               (x1 < (x2 + inset->width(bv->painter(),
+                                        LyXFont(LyXFont::ALL_SANE)))));
+    }
+}