]> git.lyx.org Git - features.git/blobdiff - src/insets/insettabular.C
change "support/std_sstream.h" to <sstream>
[features.git] / src / insets / insettabular.C
index fee887c086e181dc93242184ae55eb9fac77325a..515f95cf227b5399f3e7718181774e6f1dbdb5b2 100644 (file)
@@ -37,8 +37,7 @@
 #include "frontends/LyXView.h"
 #include "frontends/Painter.h"
 
-#include "support/std_sstream.h"
-
+#include <sstream>
 #include <iostream>
 
 using lyx::graphics::PreviewLoader;
@@ -183,7 +182,7 @@ Buffer const & InsetTabular::buffer() const
 }
 
 
-void InsetTabular::buffer(Buffer * b)
+void InsetTabular::buffer(Buffer const * b)
 {
        buffer_ = b;
 }
@@ -410,6 +409,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        lyxerr << "# InsetTabular::dispatch: cmd: " << cmd << endl;
        //lyxerr << "  cur:\n" << cur << endl;
        CursorSlice sl = cur.top();
+       LCursor & bvcur = cur.bv().cursor();
 
        switch (cmd.action) {
 
@@ -420,7 +420,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                cur.selection() = false;
                setPos(cur, cmd.x, cmd.y);
                cur.resetAnchor();
-               cur.bv().cursor().setCursor(cur, false);
+               bvcur = cur;
                //if (cmd.button() == mouse_button::button2)
                //      dispatch(cur, FuncRequest(LFUN_PASTESELECTION, "paragraph"));
                //lyxerr << "# InsetTabular::MousePress\n" << cur.bv().cursor() << endl;
@@ -429,13 +429,16 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_MOUSE_MOTION:
                if (cmd.button() != mouse_button::button1)
                        break;
+               // ignore motions deeper nested than the real anchor
+               if (bvcur.selection() && bvcur.anchor_.size() < cur.size())
+                       break;
                setPos(cur, cmd.x, cmd.y);
-               cur.bv().cursor().setCursor(cur, true);
-               //lyxerr << "# InsetTabular::MouseMotion\n" << cur.bv().cursor() << endl;
+               bvcur.setCursor(cur, true);
+               //lyxerr << "# InsetTabular::MouseMotion\n" << bvcur << endl;
                break;
 
        case LFUN_MOUSE_RELEASE:
-               //lyxerr << "# InsetTabular::MouseRelease\n" << cur.bv().cursor() << endl;
+               //lyxerr << "# InsetTabular::MouseRelease\n" << bvcur << endl;
                if (cmd.button() == mouse_button::button3)
                        InsetTabularMailer(*this).showDialog(&cur.bv());
                break;
@@ -462,6 +465,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_RIGHTSEL:
        case LFUN_RIGHT:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        isRightToLeft(cur) ? movePrevCell(cur) : moveNextCell(cur);
                if (sl == cur.top()) {
@@ -470,9 +474,10 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_LEFTSEL: 
+       case LFUN_LEFTSEL:
        case LFUN_LEFT:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        isRightToLeft(cur) ? moveNextCell(cur) : movePrevCell(cur);
                if (sl == cur.top()) {
@@ -484,6 +489,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_DOWNSEL:
        case LFUN_DOWN:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        if (tabular.row_of_cell(cur.idx()) != tabular.rows() - 1) {
                                cur.idx() = tabular.getCellBelow(cur.idx());
@@ -500,6 +506,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_UPSEL:
        case LFUN_UP:
                cell(cur.idx()).dispatch(cur, cmd);
+               cur.dispatched(); // override the cell's decision
                if (sl == cur.top())
                        if (tabular.row_of_cell(cur.idx()) != 0) {
                                cur.idx() = tabular.getCellAbove(cur.idx());
@@ -572,19 +579,6 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                break;
        }
 
-       case LFUN_LANGUAGE:
-       case LFUN_EMPH:
-       case LFUN_BOLD:
-       case LFUN_NOUN:
-       case LFUN_CODE:
-       case LFUN_SANS:
-       case LFUN_ROMAN:
-       case LFUN_DEFAULT:
-       case LFUN_UNDERLINE:
-       case LFUN_FONT_SIZE:
-               lyxerr << "font changes not re-implemented for tables after LOCK" << endl;
-               break;
-
        case LFUN_CUT:
                if (copySelection(cur)) {
                        recordUndo(cur, Undo::DELETE);
@@ -636,7 +630,7 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                        maxCols = max(cols, maxCols);
 
                        paste_tabular.reset(
-                               new LyXTabular(cur.bv().buffer()->params(), rows, maxCols));
+                               new LyXTabular(cur.buffer().params(), rows, maxCols));
 
                        string::size_type op = 0;
                        int cell = 0;
@@ -696,75 +690,185 @@ void InsetTabular::priv_dispatch(LCursor & cur, FuncRequest & cmd)
 }
 
 
+// function sets an object as defined in func_status.h:
+// states OK, Unknown, Disabled, On, Off.
 bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
-       FuncStatus & flag) const
+       FuncStatus & status) const
 {
        switch (cmd.action) {
-       case LFUN_TABULAR_FEATURE:
-#if 0
-               if (cur.inMathed()) {
-                       // FIXME: check temporarily disabled
-                       // valign code
-                       char align = mathcursor::valign();
-                       if (align == '\0') {
-                               enable = false;
-                               break;
-                       }
-                       if (cmd.argument.empty()) {
-                               flag.clear();
-                               break;
-                       }
-                       if (!contains("tcb", cmd.argument[0])) {
-                               enable = false;
+       case LFUN_TABULAR_FEATURE: {
+               int actcell = cur.idx();
+               int action = LyXTabular::LAST_ACTION;
+               int i = 0;
+               for (; tabularFeature[i].action != LyXTabular::LAST_ACTION; ++i) {
+                       string const tmp = tabularFeature[i].feature;
+                       if (tmp == cmd.argument.substr(0, tmp.length())) {
+                               action = tabularFeature[i].action;
                                break;
                        }
-                       flag.setOnOff(cmd.argument[0] == align);
-               } else {
-                       enable = false;
+               }
+               if (action == LyXTabular::LAST_ACTION) {
+                       status.clear();
+                       status.unknown(true);
+                       return true;
+               }
 
-                       char const align = mathcursor::halign();
-                       if (align == '\0') {
-                               enable = false;
-                               break;
-                       }
-                       if (cmd.argument.empty()) {
-                               flag.clear();
-                               break;
-                       }
-                       if (!contains("lcr", cmd.argument[0])) {
-                               enable = false;
-                               break;
-                       }
-                       flag.setOnOff(cmd.argument[0] == align);
+               string const argument
+                       = ltrim(cmd.argument.substr(tabularFeature[i].feature.length()));
+
+               int sel_row_start = 0;
+               int sel_row_end = 0;
+               int dummy;
+               LyXTabular::ltType dummyltt;
+               bool flag = true;
+
+               getSelection(cur, sel_row_start, sel_row_end, dummy, dummy);
+
+               switch (action) {
+               case LyXTabular::SET_PWIDTH:
+               case LyXTabular::SET_MPWIDTH:
+               case LyXTabular::SET_SPECIAL_COLUMN:
+               case LyXTabular::SET_SPECIAL_MULTI:
+               case LyXTabular::APPEND_ROW:
+               case LyXTabular::APPEND_COLUMN:
+               case LyXTabular::DELETE_ROW:
+               case LyXTabular::DELETE_COLUMN:
+               case LyXTabular::SET_ALL_LINES:
+               case LyXTabular::UNSET_ALL_LINES:
+                       status.clear();
+                       return true;
+
+               case LyXTabular::MULTICOLUMN:
+                       status.setOnOff(tabular.isMultiColumn(actcell));
+                       break;
 
-                       disable = !mathcursor::halign();
+               case LyXTabular::M_TOGGLE_LINE_TOP:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_TOP:
+                       status.setOnOff(tabular.topLine(actcell, flag));
                        break;
-               }
 
-                       FuncStatus ret;
-                       //ret.disabled(true);
-                       InsetTabular * tab = static_cast<InsetTabular *>
-                               (cur.innerInsetOfType(InsetBase::TABULAR_CODE));
-                       if (tab) {
-                               ret = tab->getStatus(cmd.argument);
-                               flag |= ret;
-                               enable = true;
-                       } else {
-                               enable = false;
-                       }
-               } else {
-                       static InsetTabular inset(*buf, 1, 1);
-                       enable = false;
-                       FuncStatus ret = inset.getStatus(cmd.argument);
-                       if (ret.onoff(true) || ret.onoff(false))
-                               flag.setOnOff(false);
+               case LyXTabular::M_TOGGLE_LINE_BOTTOM:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_BOTTOM:
+                       status.setOnOff(tabular.bottomLine(actcell, flag));
+                       break;
+
+               case LyXTabular::M_TOGGLE_LINE_LEFT:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_LEFT:
+                       status.setOnOff(tabular.leftLine(actcell, flag));
+                       break;
+
+               case LyXTabular::M_TOGGLE_LINE_RIGHT:
+                       flag = false;
+               case LyXTabular::TOGGLE_LINE_RIGHT:
+                       status.setOnOff(tabular.rightLine(actcell, flag));
+                       break;
+
+               case LyXTabular::M_ALIGN_LEFT:
+                       flag = false;
+               case LyXTabular::ALIGN_LEFT:
+                       status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_LEFT);
+                       break;
+
+               case LyXTabular::M_ALIGN_RIGHT:
+                       flag = false;
+               case LyXTabular::ALIGN_RIGHT:
+                       status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_RIGHT);
+                       break;
+
+               case LyXTabular::M_ALIGN_CENTER:
+                       flag = false;
+               case LyXTabular::ALIGN_CENTER:
+                       status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_CENTER);
+                       break;
+
+               case LyXTabular::ALIGN_BLOCK:
+                       status.enabled(!tabular.getPWidth(actcell).zero());
+                       status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_BLOCK);
+                       break;
+
+               case LyXTabular::M_VALIGN_TOP:
+                       flag = false;
+               case LyXTabular::VALIGN_TOP:
+                       status.setOnOff(
+                               tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_TOP);
+                       break;
+
+               case LyXTabular::M_VALIGN_BOTTOM:
+                       flag = false;
+               case LyXTabular::VALIGN_BOTTOM:
+                       status.setOnOff(
+                               tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_BOTTOM);
+                       break;
+
+               case LyXTabular::M_VALIGN_MIDDLE:
+                       flag = false;
+               case LyXTabular::VALIGN_MIDDLE:
+                       status.setOnOff(
+                               tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_MIDDLE);
+                       break;
+
+               case LyXTabular::SET_LONGTABULAR:
+                       status.setOnOff(tabular.isLongTabular());
+                       break;
+
+               case LyXTabular::UNSET_LONGTABULAR:
+                       status.setOnOff(!tabular.isLongTabular());
+                       break;
+
+               case LyXTabular::SET_ROTATE_TABULAR:
+                       status.setOnOff(tabular.getRotateTabular());
+                       break;
+
+               case LyXTabular::UNSET_ROTATE_TABULAR:
+                       status.setOnOff(!tabular.getRotateTabular());
+                       break;
+
+               case LyXTabular::SET_ROTATE_CELL:
+                       status.setOnOff(tabular.getRotateCell(actcell));
+                       break;
+
+               case LyXTabular::UNSET_ROTATE_CELL:
+                       status.setOnOff(!tabular.getRotateCell(actcell));
+                       break;
+
+               case LyXTabular::SET_USEBOX:
+                       status.setOnOff(strToInt(argument) == tabular.getUsebox(actcell));
+                       break;
+
+               case LyXTabular::SET_LTFIRSTHEAD:
+                       status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTHEAD:
+                       status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTFOOT:
+                       status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTLASTFOOT:
+                       status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
+                       break;
+
+               case LyXTabular::SET_LTNEWPAGE:
+                       status.setOnOff(tabular.getLTNewPage(sel_row_start));
+                       break;
+
+               default:
+                       status.clear();
+                       status.enabled(false);
+                       break;
                }
-#endif
                return true;
+       }
 
        default:
                // we try to handle this event in the insets dispatch function.
-               return cell(cur.idx()).getStatus(cur, cmd, flag);
+               return cell(cur.idx()).getStatus(cur, cmd, status);
        }
 }
 
@@ -797,7 +901,9 @@ int InsetTabular::docbook(Buffer const & buf, ostream & os,
        int ret = 0;
        InsetOld * master = 0;
 
+#ifdef WITH_WARNINGS
 #warning Why not pass a proper DocIterator here?
+#endif
 #if 0
        // if the table is inside a float it doesn't need the informaltable
        // wrapper. Search for it.
@@ -841,7 +947,7 @@ InsetText & InsetTabular::cell(int idx)
 }
 
 
-void InsetTabular::getCursorPos(CursorSlice const & cur, int & x, int & y) const
+void InsetTabular::getCursorPos(LCursor const & cur, int & x, int & y) const
 {
        cell(cur.idx()).getCursorPos(cur, x, y);
 }
@@ -911,8 +1017,9 @@ void InsetTabular::resetPos(LCursor & cur) const
 
 void InsetTabular::moveNextCell(LCursor & cur)
 {
-       lyxerr << "InsetTabular::moveNextCell 1 cur: " << cur << endl;
+       lyxerr << "InsetTabular::moveNextCell 1 cur: " << cur.top() << endl;
        if (isRightToLeft(cur)) {
+               lyxerr << "InsetTabular::moveNextCell A cur: " << endl;
                if (tabular.isFirstCellInRow(cur.idx())) {
                        int row = tabular.row_of_cell(cur.idx());
                        if (row == tabular.rows() - 1)
@@ -925,13 +1032,14 @@ void InsetTabular::moveNextCell(LCursor & cur)
                        --cur.idx();
                }
        } else {
+               lyxerr << "InsetTabular::moveNextCell B cur: " << endl;
                if (tabular.isLastCell(cur.idx()))
                        return;
                ++cur.idx();
        }
        cur.par() = 0;
        cur.pos() = 0;
-       lyxerr << "InsetTabular::moveNextCell 2 cur: " << cur << endl;
+       lyxerr << "InsetTabular::moveNextCell 2 cur: " << cur.top() << endl;
        resetPos(cur);
 }
 
@@ -1215,7 +1323,7 @@ void InsetTabular::tabularFeatures(LCursor & cur,
 #if 0
                // just multicol for one Single Cell
                if (!hasSelection()) {
-                       // check wether we are completly in a multicol
+                       // check whether we are completly in a multicol
                        if (tabular.isMultiColumn(actcell))
                                tabular.unsetMultiColumn(actcell);
                        else
@@ -1350,187 +1458,6 @@ void InsetTabular::openLayoutDialog(BufferView * bv) const
 }
 
 
-//
-// function returns an object as defined in func_status.h:
-// states OK, Unknown, Disabled, On, Off.
-//
-FuncStatus InsetTabular::getStatus(BufferView & bv,
-       string const & what, int actcell) const
-{
-       FuncStatus status;
-       int action = LyXTabular::LAST_ACTION;   
-       LCursor & cur = bv.cursor();
-
-       int i = 0;
-       for (; tabularFeature[i].action != LyXTabular::LAST_ACTION; ++i) {
-               string const tmp = tabularFeature[i].feature;
-               if (tmp == what.substr(0, tmp.length())) {
-                       //if (!compare(tabularFeatures[i].feature.c_str(), what.c_str(),
-                       //   tabularFeatures[i].feature.length()))
-                       action = tabularFeature[i].action;
-                       break;
-               }
-       }
-       if (action == LyXTabular::LAST_ACTION) {
-               status.clear();
-               status.unknown(true);
-               return status;
-       }
-
-       string const argument
-               = ltrim(what.substr(tabularFeature[i].feature.length()));
-
-       int sel_row_start = 0;
-       int sel_row_end = 0;
-       int dummy;
-       LyXTabular::ltType dummyltt;
-       bool flag = true;
-
-       getSelection(cur, sel_row_start, sel_row_end, dummy, dummy);
-
-       switch (action) {
-       case LyXTabular::SET_PWIDTH:
-       case LyXTabular::SET_MPWIDTH:
-       case LyXTabular::SET_SPECIAL_COLUMN:
-       case LyXTabular::SET_SPECIAL_MULTI:
-       case LyXTabular::APPEND_ROW:
-       case LyXTabular::APPEND_COLUMN:
-       case LyXTabular::DELETE_ROW:
-       case LyXTabular::DELETE_COLUMN:
-       case LyXTabular::SET_ALL_LINES:
-       case LyXTabular::UNSET_ALL_LINES:
-               status.clear();
-               return status;
-
-       case LyXTabular::MULTICOLUMN:
-               status.setOnOff(tabular.isMultiColumn(actcell));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_TOP:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_TOP:
-               status.setOnOff(tabular.topLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_BOTTOM:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_BOTTOM:
-               status.setOnOff(tabular.bottomLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_LEFT:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_LEFT:
-               status.setOnOff(tabular.leftLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_TOGGLE_LINE_RIGHT:
-               flag = false;
-       case LyXTabular::TOGGLE_LINE_RIGHT:
-               status.setOnOff(tabular.rightLine(actcell, flag));
-               break;
-
-       case LyXTabular::M_ALIGN_LEFT:
-               flag = false;
-       case LyXTabular::ALIGN_LEFT:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_LEFT);
-               break;
-
-       case LyXTabular::M_ALIGN_RIGHT:
-               flag = false;
-       case LyXTabular::ALIGN_RIGHT:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_RIGHT);
-               break;
-
-       case LyXTabular::M_ALIGN_CENTER:
-               flag = false;
-       case LyXTabular::ALIGN_CENTER:
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_CENTER);
-               break;
-
-       case LyXTabular::ALIGN_BLOCK:
-               status.enabled(!tabular.getPWidth(actcell).zero());
-               status.setOnOff(tabular.getAlignment(actcell, flag) == LYX_ALIGN_BLOCK);
-               break;
-
-       case LyXTabular::M_VALIGN_TOP:
-               flag = false;
-       case LyXTabular::VALIGN_TOP:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_TOP);
-               break;
-
-       case LyXTabular::M_VALIGN_BOTTOM:
-               flag = false;
-       case LyXTabular::VALIGN_BOTTOM:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_BOTTOM);
-               break;
-
-       case LyXTabular::M_VALIGN_MIDDLE:
-               flag = false;
-       case LyXTabular::VALIGN_MIDDLE:
-               status.setOnOff(
-                       tabular.getVAlignment(actcell, flag) == LyXTabular::LYX_VALIGN_MIDDLE);
-               break;
-
-       case LyXTabular::SET_LONGTABULAR:
-               status.setOnOff(tabular.isLongTabular());
-               break;
-
-       case LyXTabular::UNSET_LONGTABULAR:
-               status.setOnOff(!tabular.isLongTabular());
-               break;
-
-       case LyXTabular::SET_ROTATE_TABULAR:
-               status.setOnOff(tabular.getRotateTabular());
-               break;
-
-       case LyXTabular::UNSET_ROTATE_TABULAR:
-               status.setOnOff(!tabular.getRotateTabular());
-               break;
-
-       case LyXTabular::SET_ROTATE_CELL:
-               status.setOnOff(tabular.getRotateCell(actcell));
-               break;
-
-       case LyXTabular::UNSET_ROTATE_CELL:
-               status.setOnOff(!tabular.getRotateCell(actcell));
-               break;
-
-       case LyXTabular::SET_USEBOX:
-               status.setOnOff(strToInt(argument) == tabular.getUsebox(actcell));
-               break;
-
-       case LyXTabular::SET_LTFIRSTHEAD:
-               status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTHEAD:
-               status.setOnOff(tabular.getRowOfLTHead(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTFOOT:
-               status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTLASTFOOT:
-               status.setOnOff(tabular.getRowOfLTFoot(sel_row_start, dummyltt));
-               break;
-
-       case LyXTabular::SET_LTNEWPAGE:
-               status.setOnOff(tabular.getLTNewPage(sel_row_start));
-               break;
-
-       default:
-               status.clear();
-               status.enabled(false);
-               break;
-       }
-       return status;
-}
-
-
 void InsetTabular::getLabelList(Buffer const & buffer,
                                vector<string> & list) const
 {
@@ -1572,7 +1499,7 @@ bool InsetTabular::copySelection(LCursor & cur)
 
        ostringstream os;
        OutputParams const runparams;
-       paste_tabular->plaintext(*cur.bv().buffer(), os, runparams, 0, true, '\t');
+       paste_tabular->plaintext(cur.buffer(), os, runparams, 0, true, '\t');
        cur.bv().stuffClipboard(os.str());
        return true;
 }
@@ -1616,9 +1543,9 @@ void InsetTabular::cutSelection(LCursor & cur)
        if (!cur.selection())
                return;
 
-       bool const track = cur.bv().buffer()->params().tracking_changes;
+       bool const track = cur.buffer().params().tracking_changes;
        int rs, re, cs, ce;
-       getSelection(cur, rs, re, cs, ce); 
+       getSelection(cur, rs, re, cs, ce);
        for (int i = rs; i <= re; ++i)
                for (int j = cs; j <= ce; ++j)
                        cell(tabular.getCellNumber(i, j)).clear(track);
@@ -1801,7 +1728,7 @@ void InsetTabular::addPreview(PreviewLoader & loader) const
 
 bool InsetTabular::tablemode(LCursor & cur) const
 {
-       return cur.selBegin().idx() != cur.selEnd().idx();
+       return cur.selection() && cur.selBegin().idx() != cur.selEnd().idx();
 }
 
 
@@ -1827,7 +1754,9 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
        LyXLex lex(0,0);
        lex.setStream(data);
 
+#ifdef WITH_WARNINGS
 #warning CHECK verify that this is a sane value to return.
+#endif
        if (in.empty())
                return -1;
 
@@ -1872,11 +1801,12 @@ int InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
 string const InsetTabularMailer::params2string(InsetTabular const & inset)
 {
        ostringstream data;
+#ifdef WITH_WARNINGS
 #warning wrong!
+#endif
        //data << name_ << " \\active_cell " << inset.getActCell() << '\n';
        data << name_ << " \\active_cell " << 0 << '\n';
        inset.write(inset.buffer(), data);
        data << "\\end_inset\n";
        return data.str();
 }
-