]> git.lyx.org Git - lyx.git/blobdiff - src/insets/insettabular.C
Implement copying of rows and columns in tables
[lyx.git] / src / insets / insettabular.C
index ed94b67f96d520dda27b138b3d144be4c3d31e11..0774f66c3fd38245f1c2ff6437992557ffc5e80d 100644 (file)
 #include "support/convert.h"
 
 #include "frontends/Alert.h"
+#include "frontends/Application.h"
 #include "frontends/font_metrics.h"
-#include "frontends/LyXView.h"
+#include "frontends/Clipboard.h"
 #include "frontends/Painter.h"
+#include "frontends/Selection.h"
 #include "frontends/nullpainter.h"
 
 #include <sstream>
 #include <iostream>
 #include <limits>
 
+using lyx::docstring;
+
 using lyx::cap::dirtyTabularStack;
 using lyx::cap::tabularStackDirty;
 
@@ -53,6 +57,9 @@ using lyx::graphics::PreviewLoader;
 
 using lyx::support::ltrim;
 
+using lyx::frontend::Painter;
+using lyx::frontend::Clipboard;
+
 using boost::shared_ptr;
 
 using std::auto_ptr;
@@ -70,6 +77,7 @@ namespace {
 
 int const ADD_TO_HEIGHT = 2;
 int const ADD_TO_TABULAR_WIDTH = 2;
+int const default_line_space = 10;
 
 ///
 boost::scoped_ptr<LyXTabular> paste_tabular;
@@ -87,6 +95,8 @@ TabularFeature tabularFeature[] =
        { LyXTabular::APPEND_COLUMN, "append-column" },
        { LyXTabular::DELETE_ROW, "delete-row" },
        { LyXTabular::DELETE_COLUMN, "delete-column" },
+       { LyXTabular::COPY_ROW, "copy-row" },
+       { LyXTabular::COPY_COLUMN, "copy-column" },
        { LyXTabular::TOGGLE_LINE_TOP, "toggle-line-top" },
        { LyXTabular::TOGGLE_LINE_BOTTOM, "toggle-line-bottom" },
        { LyXTabular::TOGGLE_LINE_LEFT, "toggle-line-left" },
@@ -131,6 +141,11 @@ TabularFeature tabularFeature[] =
        { LyXTabular::SET_LTNEWPAGE, "set-ltnewpage" },
        { LyXTabular::SET_SPECIAL_COLUMN, "set-special-column" },
        { LyXTabular::SET_SPECIAL_MULTI, "set-special-multi" },
+       { LyXTabular::SET_BOOKTABS, "set-booktabs" },
+       { LyXTabular::UNSET_BOOKTABS, "unset-booktabs" },
+       { LyXTabular::SET_TOP_SPACE, "set-top-space" },
+       { LyXTabular::SET_BOTTOM_SPACE, "set-bottom-space" },
+       { LyXTabular::SET_INTERLINE_SPACE, "set-interline-space" },
        { LyXTabular::LAST_ACTION, "" }
 };
 
@@ -166,7 +181,7 @@ bool InsetTabular::hasPasteBuffer() const
 
 
 InsetTabular::InsetTabular(Buffer const & buf, row_type rows,
-                           col_type columns)
+                          col_type columns)
        : tabular(buf.params(), max(rows, row_type(1)),
          max(columns, col_type(1))), buffer_(&buf), scx_(0)
 {}
@@ -251,7 +266,7 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
                        Dimension dim;
                        MetricsInfo m = mi;
                        LyXLength p_width;
-                       if (tabular.cell_info[i][j].multicolumn == 
+                       if (tabular.cell_info[i][j].multicolumn ==
                            LyXTabular::CELL_BEGIN_OF_MULTICOLUMN)
                                p_width = tabular.cellinfo_of_cell(cell).p_width;
                        else
@@ -261,13 +276,25 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
                        tabular.getCellInset(cell)->metrics(m, dim);
                        if (!p_width.zero())
                                dim.wid = m.base.textwidth;
+                       tabular.setWidthOfCell(cell, dim.wid);
+                       if (p_width.zero()) {
+                               m.base.textwidth = dim.wid + 2 * ADD_TO_TABULAR_WIDTH;
+                               // FIXME there must be a way to get rid of
+                               // the second metrics call
+                               tabular.getCellInset(cell)->metrics(m, dim);
+                       }
                        maxAsc  = max(maxAsc, dim.asc);
                        maxDesc = max(maxDesc, dim.des);
-                       tabular.setWidthOfCell(cell, dim.wid);
                        ++cell;
                }
-               tabular.setAscentOfRow(i, maxAsc + ADD_TO_HEIGHT);
-               tabular.setDescentOfRow(i, maxDesc + ADD_TO_HEIGHT);
+               int const top_space = tabular.row_info[i].top_space_default ?
+                       default_line_space :
+                       tabular.row_info[i].top_space.inPixels(mi.base.textwidth);
+               tabular.setAscentOfRow(i, maxAsc + ADD_TO_HEIGHT + top_space);
+               int const bottom_space = tabular.row_info[i].bottom_space_default ?
+                       default_line_space :
+                       tabular.row_info[i].bottom_space.inPixels(mi.base.textwidth);
+               tabular.setDescentOfRow(i, maxDesc + ADD_TO_HEIGHT + bottom_space);
        }
 
        dim.asc = tabular.getAscentOfRow(0);
@@ -284,7 +311,7 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
        //lyxerr << "InsetTabular::draw: " << x << " " << y << endl;
        BufferView * bv = pi.base.bv;
 
-       static NullPainter nop;
+       static lyx::frontend::NullPainter nop;
        static PainterInfo nullpi(bv, nop);
 
        //resetPos(bv->cursor());
@@ -332,6 +359,15 @@ void InsetTabular::drawSelection(PainterInfo & pi, int x, int y) const
        setPosCache(pi, x, y);
 
        LCursor & cur = pi.base.bv->cursor();
+
+       x += scx_ + ADD_TO_TABULAR_WIDTH;
+
+       // Paint background of current tabular
+       int const w = tabular.getWidthOfTabular();
+       int const h = tabular.getHeightOfTabular();
+       int yy = y - tabular.getAscentOfRow(0);
+       pi.pain.fillRectangle(x, yy, w, h, backgroundColor());
+
        if (!cur.selection())
                return;
        if (!ptr_cmp(&cur.inset(), this))
@@ -339,7 +375,6 @@ void InsetTabular::drawSelection(PainterInfo & pi, int x, int y) const
 
        //resetPos(cur);
 
-       x += scx_ + ADD_TO_TABULAR_WIDTH;
 
        if (tablemode(cur)) {
                row_type rs, re;
@@ -414,7 +449,7 @@ void InsetTabular::drawCellLines(Painter & pain, int x, int y,
 }
 
 
-string const InsetTabular::editMessage() const
+docstring const InsetTabular::editMessage() const
 {
        return _("Opened table");
 }
@@ -449,7 +484,7 @@ void InsetTabular::edit(LCursor & cur, bool left)
 
 void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
 {
-       lyxerr[Debug::DEBUG] << "# InsetTabular::doDispatch: cmd: " << cmd 
+       lyxerr[Debug::DEBUG] << "# InsetTabular::doDispatch: cmd: " << cmd
                             << "\n  cur:" << cur << endl;
        CursorSlice sl = cur.top();
        LCursor & bvcur = cur.bv().cursor();
@@ -459,7 +494,8 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
        case LFUN_MOUSE_PRESS:
                //lyxerr << "# InsetTabular::MousePress\n" << cur.bv().cursor() << endl;
 
-               if (cmd.button() == mouse_button::button1) {
+               if (cmd.button() == mouse_button::button1
+                   || cmd.button() == mouse_button::button3) {
                        cur.selection() = false;
                        setCursorFromCoordinates(cur, cmd.x, cmd.y);
                        cur.resetAnchor();
@@ -468,14 +504,9 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                }
 
                if (cmd.button() == mouse_button::button2) {
-                       cmd = FuncRequest(LFUN_PASTESELECTION, "paragraph");
+                       cmd = FuncRequest(LFUN_PRIMARY_SELECTION_PASTE, "paragraph");
                        doDispatch(cur, cmd);
-                       break;
                }
-
-               // we'll pop up the table dialog on release
-               if (cmd.button() == mouse_button::button3)
-                       break;
                break;
 
        case LFUN_MOUSE_MOTION:
@@ -507,31 +538,31 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                cur.selection() = false;
                break;
 
-       case LFUN_RIGHTSEL:
-       case LFUN_RIGHT:
+       case LFUN_CHAR_FORWARD_SELECT:
+       case LFUN_CHAR_FORWARD:
                cell(cur.idx())->dispatch(cur, cmd);
                if (!cur.result().dispatched()) {
                        isRightToLeft(cur) ? movePrevCell(cur) : moveNextCell(cur);
-                       if (sl == cur.top()) 
+                       if (sl == cur.top())
                                cmd = FuncRequest(LFUN_FINISHED_RIGHT);
                        else
                                cur.dispatched();
                }
                break;
 
-       case LFUN_LEFTSEL:
-       case LFUN_LEFT:
+       case LFUN_CHAR_BACKWARD_SELECT:
+       case LFUN_CHAR_BACKWARD:
                cell(cur.idx())->dispatch(cur, cmd);
                if (!cur.result().dispatched()) {
                        isRightToLeft(cur) ? moveNextCell(cur) : movePrevCell(cur);
-                       if (sl == cur.top()) 
+                       if (sl == cur.top())
                                cmd = FuncRequest(LFUN_FINISHED_LEFT);
                        else
                                cur.dispatched();
                }
                break;
 
-       case LFUN_DOWNSEL:
+       case LFUN_DOWN_SELECT:
        case LFUN_DOWN:
                cell(cur.idx())->dispatch(cur, cmd);
                cur.dispatched(); // override the cell's decision
@@ -553,7 +584,7 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_UPSEL:
+       case LFUN_UP_SELECT:
        case LFUN_UP:
                cell(cur.idx())->dispatch(cur, cmd);
                cur.dispatched(); // override the cell's decision
@@ -576,11 +607,11 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                }
                break;
 
-//     case LFUN_NEXT: {
+//     case LFUN_SCREEN_DOWN: {
 //             //if (hasSelection())
 //             //      cur.selection() = false;
 //             col_type const col = tabular.column_of_cell(cur.idx());
-//             int const t =   cur.bv().top_y() + cur.bv().painter().paperHeight();
+//             int const t =   cur.bv().top_y() + cur.bv().height();
 //             if (t < yo() + tabular.getHeightOfTabular()) {
 //                     cur.bv().scrollDocView(t);
 //                     cur.idx() = tabular.getCellBelow(first_visible_cell) + col;
@@ -592,11 +623,11 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
 //             break;
 //     }
 //
-//     case LFUN_PRIOR: {
+//     case LFUN_SCREEN_UP: {
 //             //if (hasSelection())
 //             //      cur.selection() = false;
 //             col_type const col = tabular.column_of_cell(cur.idx());
-//             int const t =   cur.bv().top_y() + cur.bv().painter().paperHeight();
+//             int const t =   cur.bv().top_y() + cur.bv().height();
 //             if (yo() < 0) {
 //                     cur.bv().scrollDocView(t);
 //                     if (yo() > 0)
@@ -620,15 +651,17 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                break;
 
        case LFUN_TABULAR_FEATURE:
-               if (!tabularFeatures(cur, cmd.argument))
+               if (!tabularFeatures(cur, lyx::to_utf8(cmd.argument())))
                        cur.undispatched();
                break;
 
        // insert file functions
        case LFUN_FILE_INSERT_ASCII_PARA:
        case LFUN_FILE_INSERT_ASCII: {
-               string const tmpstr = getContentsOfAsciiFile(&cur.bv(), cmd.argument, false);
-               if (!tmpstr.empty() && !insertAsciiString(cur.bv(), tmpstr, false))
+               // FIXME: We don't know the encoding of filenames
+               string const tmpstr = getContentsOfAsciiFile(&cur.bv(), lyx::to_utf8(cmd.argument()), false);
+               // FIXME: We don't know the encoding of the file
+               if (!tmpstr.empty() && !insertAsciiString(cur.bv(), lyx::from_utf8(tmpstr), false))
                        cur.undispatched();
                break;
        }
@@ -644,8 +677,8 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                        cell(cur.idx())->dispatch(cur, cmd);
                break;
 
-       case LFUN_BACKSPACE:
-       case LFUN_DELETE:
+       case LFUN_CHAR_DELETE_BACKWARD:
+       case LFUN_CHAR_DELETE_FORWARD:
                if (tablemode(cur)) {
                        recordUndoInset(cur, Undo::DELETE);
                        cutSelection(cur);
@@ -664,74 +697,27 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                        cell(cur.idx())->dispatch(cur, cmd);
                break;
 
-       case LFUN_PASTESELECTION: {
-               string const clip = cur.bv().getClipboard();
+       case LFUN_CLIPBOARD_PASTE:
+       case LFUN_PRIMARY_SELECTION_PASTE: {
+               docstring const clip = (cmd.action == LFUN_CLIPBOARD_PASTE) ?
+                       theApp->clipboard().get() :
+                       theApp->selection().get();
                if (clip.empty())
                        break;
-               if (clip.find('\t') != string::npos) {
-                       col_type cols = 1;
-                       row_type rows = 1;
-                       col_type maxCols = 1;
-                       size_t len = clip.length();
-                       for (size_t p = 0; p < len; ++p) {
-                               p = clip.find_first_of("\t\n", p);
-                               if (p == string::npos)
-                                       break;
-                               switch (clip[p]) {
-                               case '\t':
-                                       ++cols;
-                                       break;
-                               case '\n':
-                                       if (p + 1 < len)
-                                               ++rows;
-                                       maxCols = max(cols, maxCols);
-                                       cols = 1;
-                                       break;
-                               }
-                       }
-                       maxCols = max(cols, maxCols);
-
-                       paste_tabular.reset(
-                               new LyXTabular(cur.buffer().params(), rows, maxCols));
-
-                       string::size_type op = 0;
-                       idx_type cell = 0;
-                       idx_type const cells =
-                               paste_tabular->getNumberOfCells();
-                       cols = 0;
-                       LyXFont font;
-                       for (size_t p = 0; cell < cells && p < len; ++p) {
-                               p = clip.find_first_of("\t\n", p);
-                               if (p == string::npos || p >= len)
-                                       break;
-                               switch (clip[p]) {
-                               case '\t':
-                                       paste_tabular->getCellInset(cell)->
-                                               setText(clip.substr(op, p - op), font);
-                                       ++cols;
-                                       ++cell;
-                                       break;
-                               case '\n':
-                                       paste_tabular->getCellInset(cell)->
-                                               setText(clip.substr(op, p - op), font);
-                                       while (cols++ < maxCols)
-                                               ++cell;
-                                       cols = 0;
-                                       break;
-                               }
-                               op = p + 1;
+               // pass to InsertAsciiString, but
+               // only if we have multi-cell content
+               if (clip.find_first_of(lyx::from_ascii("\t\n")) != docstring::npos) {
+                       if (insertAsciiString(cur.bv(), clip, false)) {
+                               // content has been replaced,
+                               // so cursor might be invalid
+                               cur.pos() = cur.lastpos();
+                               bvcur.setCursor(cur);
+                               break;
                        }
-                       // check for the last cell if there is no trailing '\n'
-                       if (cell < cells && op < len)
-                               paste_tabular->getCellInset(cell)->
-                                       setText(clip.substr(op, len - op), font);
-                       dirtyTabularStack(true);
-               } else if (insertAsciiString(cur.bv(), clip, false))
-                       break;
-               else {
+               } else {
                        // so that the clipboard is used and it goes on
                        // to default
-                       // and executes LFUN_PASTESELECTION in insettext!
+                       // and executes LFUN_PRIMARY_SELECTION_PASTE in insettext!
                        paste_tabular.reset();
                        dirtyTabularStack(false);
                }
@@ -747,48 +733,43 @@ void InsetTabular::doDispatch(LCursor & cur, FuncRequest & cmd)
                cell(cur.idx())->dispatch(cur, cmd);
                break;
 
-       case LFUN_EMPH:
-       case LFUN_BOLD:
-       case LFUN_ROMAN:
-       case LFUN_NOUN:
-       case LFUN_ITAL:
-       case LFUN_FRAK:
-       case LFUN_CODE:
-       case LFUN_SANS:
-       case LFUN_FREEFONT_APPLY:
-       case LFUN_FREEFONT_UPDATE:
+       case LFUN_FONT_EMPH:
+       case LFUN_FONT_BOLD:
+       case LFUN_FONT_ROMAN:
+       case LFUN_FONT_NOUN:
+       case LFUN_FONT_ITAL:
+       case LFUN_FONT_FRAK:
+       case LFUN_FONT_CODE:
+       case LFUN_FONT_SANS:
+       case LFUN_FONT_FREE_APPLY:
+       case LFUN_FONT_FREE_UPDATE:
        case LFUN_FONT_SIZE:
-       case LFUN_UNDERLINE:
+       case LFUN_FONT_UNDERLINE:
        case LFUN_LANGUAGE:
-       case LFUN_CAPITALIZE_WORD:
-       case LFUN_UPCASE_WORD:
-       case LFUN_LOWCASE_WORD:
-       case LFUN_TRANSPOSE_CHARS:
+       case LFUN_WORD_CAPITALIZE:
+       case LFUN_WORD_UPCASE:
+       case LFUN_WORD_LOWCASE:
+       case LFUN_CHARS_TRANSPOSE:
                if (tablemode(cur)) {
                        row_type rs, re;
                        col_type cs, ce;
                        getSelection(cur, rs, re, cs, ce);
+                       LCursor tmpcur = cur;
                        for (row_type i = rs; i <= re; ++i) {
                                for (col_type j = cs; j <= ce; ++j) {
                                        // cursor follows cell:
-                                       cur.idx() = tabular.getCellNumber(i, j);
+                                       tmpcur.idx() = tabular.getCellNumber(i, j);
                                        // select this cell only:
-                                       cur.pos() = 0;
-                                       cur.resetAnchor();
-                                       cur.pos() = cur.top().lastpos();
-                                       cur.setCursor(cur);
-                                       cur.setSelection();
-                                       cell(cur.idx())->dispatch(cur, cmd);
+                                       tmpcur.pit() = 0;
+                                       tmpcur.pos() = 0;
+                                       tmpcur.resetAnchor();
+                                       tmpcur.pit() = tmpcur.lastpit();
+                                       tmpcur.pos() = tmpcur.top().lastpos();
+                                       tmpcur.setCursor(tmpcur);
+                                       tmpcur.setSelection();
+                                       cell(tmpcur.idx())->dispatch(tmpcur, cmd);
                                }
                        }
-                       // Restore original selection
-                       cur.idx() = tabular.getCellNumber(rs, cs);
-                       cur.pos() = 0;
-                       cur.resetAnchor();
-                       cur.idx() = tabular.getCellNumber(re, ce);
-                       cur.pos() = cur.top().lastpos();
-                       cur.setCursor(cur);
-                       cur.setSelection();
                        break;
                } else {
                        cell(cur.idx())->dispatch(cur, cmd);
@@ -816,7 +797,7 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
                int i = 0;
                for (; tabularFeature[i].action != LyXTabular::LAST_ACTION; ++i) {
                        string const tmp = tabularFeature[i].feature;
-                       if (tmp == cmd.argument.substr(0, tmp.length())) {
+                       if (tmp == lyx::to_utf8(cmd.argument()).substr(0, tmp.length())) {
                                action = tabularFeature[i].action;
                                break;
                        }
@@ -828,7 +809,7 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
                }
 
                string const argument
-                       = ltrim(cmd.argument.substr(tabularFeature[i].feature.length()));
+                       = ltrim(lyx::to_utf8(cmd.argument()).substr(tabularFeature[i].feature.length()));
 
                row_type sel_row_start = 0;
                row_type sel_row_end = 0;
@@ -847,8 +828,13 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
                case LyXTabular::APPEND_COLUMN:
                case LyXTabular::DELETE_ROW:
                case LyXTabular::DELETE_COLUMN:
+               case LyXTabular::COPY_ROW:
+               case LyXTabular::COPY_COLUMN:
                case LyXTabular::SET_ALL_LINES:
                case LyXTabular::UNSET_ALL_LINES:
+               case LyXTabular::SET_TOP_SPACE:
+               case LyXTabular::SET_BOTTOM_SPACE:
+               case LyXTabular::SET_INTERLINE_SPACE:
                        status.clear();
                        return true;
 
@@ -988,6 +974,14 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
                        status.setOnOff(tabular.getLTNewPage(sel_row_start));
                        break;
 
+               case LyXTabular::SET_BOOKTABS:
+                       status.setOnOff(tabular.useBookTabs());
+                       break;
+
+               case LyXTabular::UNSET_BOOKTABS:
+                       status.setOnOff(!tabular.useBookTabs());
+                       break;
+
                default:
                        status.clear();
                        status.enabled(false);
@@ -1005,21 +999,21 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
        // disable these with multiple cells selected
        case LFUN_INSET_INSERT:
        case LFUN_TABULAR_INSERT:
-       case LFUN_INSERT_CHARSTYLE:
-       case LFUN_INSET_FLOAT:
-       case LFUN_INSET_WIDE_FLOAT:
-       case LFUN_INSET_FOOTNOTE:
-       case LFUN_INSET_MARGINAL:
-       case LFUN_INSERT_MATH:
+       case LFUN_CHARSTYLE_INSERT:
+       case LFUN_FLOAT_INSERT:
+       case LFUN_FLOAT_WIDE_INSERT:
+       case LFUN_FOOTNOTE_INSERT:
+       case LFUN_MARGINALNOTE_INSERT:
+       case LFUN_MATH_INSERT:
        case LFUN_MATH_MODE:
        case LFUN_MATH_MUTATE:
        case LFUN_MATH_DISPLAY:
-       case LFUN_INSERT_NOTE:
-       case LFUN_INSET_OPTARG:
-       case LFUN_INSERT_BOX:
-       case LFUN_INSERT_BRANCH:
-       case LFUN_INSET_WRAP:
-       case LFUN_INSET_ERT: {
+       case LFUN_NOTE_INSERT:
+       case LFUN_OPTIONAL_INSERT:
+       case LFUN_BOX_INSERT:
+       case LFUN_BRANCH_INSERT:
+       case LFUN_WRAP_INSERT:
+       case LFUN_ERT_INSERT: {
                if (tablemode(cur)) {
                        status.enabled(false);
                        return true;
@@ -1028,10 +1022,10 @@ bool InsetTabular::getStatus(LCursor & cur, FuncRequest const & cmd,
        }
 
        // disable in non-fixed-width cells
-       case LFUN_BREAKLINE:
-       case LFUN_BREAKPARAGRAPH:
-       case LFUN_BREAKPARAGRAPHKEEPLAYOUT:
-       case LFUN_BREAKPARAGRAPH_SKIP: {
+       case LFUN_BREAK_LINE:
+       case LFUN_BREAK_PARAGRAPH:
+       case LFUN_BREAK_PARAGRAPH_KEEP_LAYOUT:
+       case LFUN_BREAK_PARAGRAPH_SKIP: {
                if (tabular.getPWidth(cur.idx()).zero()) {
                        status.enabled(false);
                        return true;
@@ -1074,13 +1068,6 @@ int InsetTabular::plaintext(Buffer const & buf, ostream & os,
 }
 
 
-int InsetTabular::linuxdoc(Buffer const & buf, ostream & os,
-                          OutputParams const & runparams) const
-{
-       return tabular.linuxdoc(buf,os, runparams);
-}
-
-
 int InsetTabular::docbook(Buffer const & buf, ostream & os,
                          OutputParams const & runparams) const
 {
@@ -1168,20 +1155,19 @@ int InsetTabular::dist(idx_type const cell, int x, int y) const
        Point o = theCoords.getInsets().xy(&inset);
        int const xbeg = o.x_ - tabular.getBeginningOfTextInCell(cell);
        int const xend = xbeg + tabular.getWidthOfColumn(cell);
-       int const ybeg = o.y_ - inset.ascent();
        row_type const row = tabular.row_of_cell(cell);
-       int const rowheight = tabular.getAscentOfRow(row)
-                       + tabular.getDescentOfRow(row);
-       int const yend = ybeg + rowheight;
+       int const ybeg = o.y_ - tabular.getAscentOfRow(row) -
+                        tabular.getAdditionalHeight(row);
+       int const yend = o.y_ + tabular.getDescentOfRow(row);
 
        if (x < xbeg)
                xx = xbeg - x;
        else if (x > xend)
                xx = x - xend;
 
-       if (y < ybeg) 
+       if (y < ybeg)
                yy = ybeg - y;
-       else if (y > yend) 
+       else if (y > yend)
                yy = y - yend;
 
        //lyxerr << " xbeg=" << xbeg << "  xend=" << xend
@@ -1479,6 +1465,15 @@ void InsetTabular::tabularFeatures(LCursor & cur,
                cur.selection() = false;
                break;
 
+       case LyXTabular::COPY_ROW:
+               tabular.copyRow(bv.buffer()->params(), row);
+               break;
+
+       case LyXTabular::COPY_COLUMN:
+               tabular.copyColumn(bv.buffer()->params(), column);
+               cur.idx() = tabular.getCellNumber(row, column);
+               break;
+
        case LyXTabular::M_TOGGLE_LINE_TOP:
                flag = false;
        case LyXTabular::TOGGLE_LINE_TOP: {
@@ -1565,8 +1560,9 @@ void InsetTabular::tabularFeatures(LCursor & cur,
 #ifdef WITH_WARNINGS
 #warning Need I say it ? This is horrible.
 #endif
+                       // FIXME UNICODE
                        Alert::error(_("Error setting multicolumn"),
-                                  _("You cannot set multicolumn vertically."));
+                                    _("You cannot set multicolumn vertically."));
                        return;
                }
                if (!cur.selection()) {
@@ -1675,6 +1671,68 @@ void InsetTabular::tabularFeatures(LCursor & cur,
                tabular.setLTNewPage(row, !tabular.getLTNewPage(row));
                break;
 
+       case LyXTabular::SET_BOOKTABS:
+               tabular.setBookTabs(true);
+               break;
+
+       case LyXTabular::UNSET_BOOKTABS:
+               tabular.setBookTabs(false);
+               break;
+
+       case LyXTabular::SET_TOP_SPACE: {
+               LyXLength len;
+               if (value == "default")
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i)
+                               tabular.row_info[i].top_space_default = true;
+               else if (isValidLength(value, &len))
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].top_space_default = false;
+                               tabular.row_info[i].top_space = len;
+                       }
+               else
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].top_space_default = false;
+                               tabular.row_info[i].top_space = len;
+                       }
+               break;
+       }
+
+       case LyXTabular::SET_BOTTOM_SPACE: {
+               LyXLength len;
+               if (value == "default")
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i)
+                               tabular.row_info[i].bottom_space_default = true;
+               else if (isValidLength(value, &len))
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].bottom_space_default = false;
+                               tabular.row_info[i].bottom_space = len;
+                       }
+               else
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].bottom_space_default = false;
+                               tabular.row_info[i].bottom_space = len;
+                       }
+               break;
+       }
+
+       case LyXTabular::SET_INTERLINE_SPACE: {
+               LyXLength len;
+               if (value == "default")
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i)
+                               tabular.row_info[i].interline_space_default = true;
+               else if (isValidLength(value, &len))
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].interline_space_default = false;
+                               tabular.row_info[i].interline_space = len;
+                       }
+               else
+                       for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                               tabular.row_info[i].interline_space_default = false;
+                               tabular.row_info[i].interline_space = len;
+                       }
+               break;
+       }
+
        // dummy stuff just to avoid warnings
        case LyXTabular::LAST_ACTION:
                break;
@@ -1733,9 +1791,9 @@ bool InsetTabular::copySelection(LCursor & cur)
        ostringstream os;
        OutputParams const runparams;
        paste_tabular->plaintext(cur.buffer(), os, runparams, 0, true, '\t');
-       cur.bv().stuffClipboard(os.str());
+       theApp->clipboard().put(lyx::from_utf8(os.str()));
        // mark tabular stack dirty
-       // FIXME: this is a workaround for bug 1919. Should be removed for 1.5, 
+       // FIXME: this is a workaround for bug 1919. Should be removed for 1.5,
        // when we (hopefully) have a one-for-all paste mechanism.
        lyx::cap::dirtyTabularStack(true);
 
@@ -1797,7 +1855,10 @@ void InsetTabular::cutSelection(LCursor & cur)
        }
 
        // cursor position might be invalid now
-       cur.pos() = cur.lastpos();
+       if (cur.pit() > cur.lastpit())
+               cur.pit() = cur.lastpit();
+       if (cur.pos() > cur.lastpos())
+               cur.pos() = cur.lastpos();
        cur.clearSelection();
 }
 
@@ -1808,7 +1869,7 @@ bool InsetTabular::isRightToLeft(LCursor & cur) const
        Paragraph const & parentpar = cur[cur.depth() - 2].paragraph();
        LCursor::pos_type const parentpos = cur[cur.depth() - 2].pos();
        return parentpar.getFontSettings(cur.bv().buffer()->params(),
-                                        parentpos).language()->RightToLeft();
+                                        parentpos).language()->rightToLeft();
 }
 
 
@@ -1852,7 +1913,7 @@ bool InsetTabular::forceDefaultParagraphs(idx_type cell) const
 }
 
 
-bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
+bool InsetTabular::insertAsciiString(BufferView & bv, docstring const & buf,
                                     bool usePaste)
 {
        if (buf.length() <= 0)
@@ -1861,10 +1922,11 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
        col_type cols = 1;
        row_type rows = 1;
        col_type maxCols = 1;
-       string::size_type const len = buf.length();
-       string::size_type p = 0;
+       docstring::size_type const len = buf.length();
+       docstring::size_type p = 0;
 
-       while (p < len && (p = buf.find_first_of("\t\n", p)) != string::npos) {
+       while (p < len &&
+              (p = buf.find_first_of(lyx::from_ascii("\t\n"), p)) != docstring::npos) {
                switch (buf[p]) {
                case '\t':
                        ++cols;
@@ -1896,7 +1958,7 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
                row = tabular.row_of_cell(cell);
        }
 
-       string::size_type op = 0;
+       docstring::size_type op = 0;
        idx_type const cells = loctab->getNumberOfCells();
        p = 0;
        cols = ocol;
@@ -1904,7 +1966,7 @@ bool InsetTabular::insertAsciiString(BufferView & bv, string const & buf,
        col_type const columns = loctab->columns();
 
        while (cell < cells && p < len && row < rows &&
-              (p = buf.find_first_of("\t\n", p)) != string::npos)
+              (p = buf.find_first_of(lyx::from_ascii("\t\n"), p)) != docstring::npos)
        {
                if (p >= len)
                        break;
@@ -1997,14 +2059,14 @@ void InsetTabularMailer::string2params(string const & in, InsetTabular & inset)
        lex >> token;
        if (!lex || token != name_)
                return print_mailer_error("InsetTabularMailer", in, 1,
-                                         name_);
+                                         name_);
 
        // This is part of the inset proper that is usually swallowed
        // by Buffer::readInset
        lex >> token;
        if (!lex || token != "Tabular")
                return print_mailer_error("InsetTabularMailer", in, 2,
-                                         "Tabular");
+                                         "Tabular");
 
        Buffer const & buffer = inset.buffer();
        inset.read(buffer, lex);