]> git.lyx.org Git - features.git/blobdiff - src/insets/insetgraphics.C
change "support/std_sstream.h" to <sstream>
[features.git] / src / insets / insetgraphics.C
index c111e404af998616b7ae447c72a3704da0b6ba1d..fe29faf3ba076b397f9aabd04e8d0a38aaa2262e 100644 (file)
@@ -4,9 +4,9 @@
  * Licence details can be found in the file COPYING.
  *
  * \author Baruch Even
- * \author Herbert Voss
+ * \author Herbert Voß
  *
- * Full author contact details are available in file CREDITS
+ * Full author contact details are available in file CREDITS.
  */
 
 /*
@@ -29,9 +29,6 @@ TODO
 
 /* NOTES:
  * Fileformat:
- * Current version is 1 (inset file format version), when changing it
- * it should be changed in the Write() function when writing in one place
- * and when reading one should change the version check and the error message.
  * The filename is kept in  the lyx file in a relative way, so as to allow
  * moving the document file and its images with no problem.
  *
@@ -53,64 +50,71 @@ TODO
 #include <config.h>
 
 #include "insets/insetgraphics.h"
-#include "insets/insetgraphicsParams.h"
+#include "insets/render_graphic.h"
 
-#include "graphics/GraphicsLoader.h"
-#include "graphics/GraphicsImage.h"
-#include "graphics/GraphicsParams.h"
-
-#include "lyxtext.h"
-#include "dimension.h"
 #include "buffer.h"
 #include "BufferView.h"
 #include "converter.h"
+#include "cursor.h"
 #include "debug.h"
+#include "dispatchresult.h"
+#include "exporter.h"
 #include "format.h"
 #include "funcrequest.h"
 #include "gettext.h"
 #include "LaTeXFeatures.h"
-#include "latexrunparams.h"
-#include "Lsstream.h"
+#include "lyx_main.h"
 #include "lyxlex.h"
-#include "lyxrc.h"
-#include "Lsstream.h"
+#include "metricsinfo.h"
+#include "outputparams.h"
 
-#include "frontends/lyx_gui.h"
 #include "frontends/Alert.h"
-#include "frontends/Dialogs.h"
-#include "frontends/font_metrics.h"
 #include "frontends/LyXView.h"
-#include "frontends/Painter.h"
 
-#include "support/LAssert.h"
 #include "support/filetools.h"
 #include "support/lyxalgo.h" // lyx::count
 #include "support/lyxlib.h" // float_equal
-#include "support/path.h"
-#include "support/tostr.h"
-#include "support/systemcall.h"
 #include "support/os.h"
-#include "support/lstrings.h"
+#include "support/systemcall.h"
+#include "support/tostr.h"
 
-#include <boost/weak_ptr.hpp>
 #include <boost/bind.hpp>
-#include <boost/signals/trackable.hpp>
+#include <boost/tuple/tuple.hpp>
+
+#include <sstream>
+
+namespace support = lyx::support;
+
+using lyx::support::AbsolutePath;
+using lyx::support::bformat;
+using lyx::support::ChangeExtension;
+using lyx::support::compare_timestamps;
+using lyx::support::contains;
+using lyx::support::FileName;
+using lyx::support::float_equal;
+using lyx::support::GetExtension;
+using lyx::support::getExtFromContents;
+using lyx::support::IsFileReadable;
+using lyx::support::LibFileSearch;
+using lyx::support::OnlyFilename;
+using lyx::support::rtrim;
+using lyx::support::subst;
+using lyx::support::Systemcall;
+using lyx::support::unzipFile;
+using lyx::support::unzippedFileName;
+
+namespace os = lyx::support::os;
 
-#include <algorithm> // For the std::max
-
-extern string system_tempdir;
-// set by Exporters
-
-using std::ostream;
 using std::endl;
+using std::string;
+using std::auto_ptr;
+using std::istringstream;
+using std::ostream;
+using std::ostringstream;
 
 
 namespace {
 
-///////////////////////////////////////////////////////////////////////////
-int const VersionNumber = 1;
-///////////////////////////////////////////////////////////////////////////
-
 // This function is a utility function
 // ... that should be with ChangeExtension ...
 inline
@@ -127,11 +131,11 @@ string const uniqueID()
 }
 
 
-string findTargetFormat(string const & suffix, LatexRunParams const & runparams)
+string findTargetFormat(string const & suffix, OutputParams const & runparams)
 {
        // Are we using latex or pdflatex).
-       if (runparams.flavor == LatexRunParams::PDFLATEX) {
-               lyxerr[Debug::GRAPHICS] << "findTargetFormat: PDF mode\n";
+       if (runparams.flavor == OutputParams::PDFLATEX) {
+               lyxerr[Debug::GRAPHICS] << "findTargetFormat: PDF mode" << endl;
                if (contains(suffix, "ps") || suffix == "pdf")
                        return "pdf";
                if (suffix == "jpg")    // pdflatex can use jpeg
@@ -139,7 +143,7 @@ string findTargetFormat(string const & suffix, LatexRunParams const & runparams)
                return "png";         // and also png
        }
        // If it's postscript, we always do eps.
-       lyxerr[Debug::GRAPHICS] << "findTargetFormat: PostScript mode\n";
+       lyxerr[Debug::GRAPHICS] << "findTargetFormat: PostScript mode" << endl;
        if (suffix != "ps")     // any other than ps
                return "eps";         // is changed to eps
        return suffix;          // let ps untouched
@@ -148,288 +152,118 @@ string findTargetFormat(string const & suffix, LatexRunParams const & runparams)
 } // namespace anon
 
 
-struct InsetGraphics::Cache : boost::signals::trackable
-{
-       ///
-       Cache(InsetGraphics &);
-       ///
-       void update(string const & file_with_path);
-
-       ///
-       int old_ascent;
-       ///
-       grfx::Loader loader;
-       ///
-       unsigned long checksum;
-       ///
-       boost::weak_ptr<BufferView> view;
-
-private:
-       ///
-       InsetGraphics & parent_;
-};
-
-
-InsetGraphics::Cache::Cache(InsetGraphics & p)
-       : old_ascent(0), checksum(0), parent_(p)
-{
-       loader.connect(boost::bind(&InsetGraphics::statusChanged, &parent_));
-}
-
-
-void InsetGraphics::Cache::update(string const & file_with_path)
-{
-       lyx::Assert(!file_with_path.empty());
-
-       string const path = OnlyPath(file_with_path);
-       loader.reset(file_with_path, parent_.params().as_grfxParams(path));
-}
-
-
 InsetGraphics::InsetGraphics()
        : graphic_label(uniqueID()),
-         cache_(new Cache(*this))
+         graphic_(new RenderGraphic(this))
 {}
 
 
-InsetGraphics::InsetGraphics(InsetGraphics const & ig,
-                            string const & filepath,
-                            bool same_id)
-       : Inset(ig, same_id),
+InsetGraphics::InsetGraphics(InsetGraphics const & ig)
+       : InsetOld(ig),
+         boost::signals::trackable(),
          graphic_label(uniqueID()),
-         cache_(new Cache(*this))
+         graphic_(new RenderGraphic(*ig.graphic_, this))
 {
-       setParams(ig.params(), filepath);
+       setParams(ig.params());
 }
 
 
-Inset * InsetGraphics::clone(Buffer const & buffer, bool same_id) const
+auto_ptr<InsetBase> InsetGraphics::clone() const
 {
-       return new InsetGraphics(*this, buffer.filePath(), same_id);
+       return auto_ptr<InsetBase>(new InsetGraphics(*this));
 }
 
 
 InsetGraphics::~InsetGraphics()
 {
-       InsetGraphicsMailer mailer(*this);
-       mailer.hideDialog();
+       InsetGraphicsMailer(*this).hideDialog();
 }
 
 
-dispatch_result InsetGraphics::localDispatch(FuncRequest const & cmd)
+void InsetGraphics::priv_dispatch(LCursor & cur, FuncRequest & cmd)
 {
        switch (cmd.action) {
+        case LFUN_GRAPHICS_EDIT: {
+               Buffer const & buffer = *cur.bv().buffer();
+               InsetGraphicsParams p;
+               InsetGraphicsMailer::string2params(cmd.argument, buffer, p);
+               editGraphics(p, buffer);
+               break;
+       }
+
        case LFUN_INSET_MODIFY: {
+               Buffer const & buffer = cur.buffer();
                InsetGraphicsParams p;
-               InsetGraphicsMailer::string2params(cmd.argument, p);
+               InsetGraphicsMailer::string2params(cmd.argument, buffer, p);
                if (!p.filename.empty()) {
-                       string const filepath = cmd.view()->buffer()->filePath();
-                       setParams(p, filepath);
-                       cmd.view()->updateInset(this);
+                       setParams(p);
+                       cur.bv().update();
                }
-               return DISPATCHED;
+               break;
        }
 
-       case LFUN_INSET_DIALOG_UPDATE: 
-               InsetGraphicsMailer(*this).updateDialog(cmd.view());
-               return DISPATCHED;
+       case LFUN_INSET_DIALOG_UPDATE:
+               InsetGraphicsMailer(*this).updateDialog(&cur.bv());
+               break;
 
-       case LFUN_INSET_EDIT:
        case LFUN_MOUSE_RELEASE:
-               InsetGraphicsMailer(*this).showDialog(cmd.view());
-               return DISPATCHED;
+               InsetGraphicsMailer(*this).showDialog(&cur.bv());
+               break;
 
        default:
-               return Inset::localDispatch(cmd);
+               InsetOld::priv_dispatch(cur, cmd);
+               break;
        }
 }
 
 
-string const InsetGraphics::statusMessage() const
+void InsetGraphics::edit(LCursor & cur, bool)
 {
-       using namespace grfx;
-
-       switch (cache_->loader.status()) {
-               case WaitingToLoad:
-                       return _("Not shown.");
-               case Loading:
-                       return _("Loading...");
-               case Converting:
-                       return _("Converting to loadable format...");
-               case Loaded:
-                       return _("Loaded into memory. Must now generate pixmap.");
-               case ScalingEtc:
-                       return _("Scaling etc...");
-               case Ready:
-                       return _("Ready to display");
-               case ErrorNoFile:
-                       return _("No file found!");
-               case ErrorConverting:
-                       return _("Error converting to loadable format");
-               case ErrorLoading:
-                       return _("Error loading file into memory");
-               case ErrorGeneratingPixmap:
-                       return _("Error generating the pixmap");
-               case ErrorUnknown:
-                       return _("No image");
-       }
-       return string();
+       InsetGraphicsMailer(*this).showDialog(&cur.bv());
 }
 
 
-bool InsetGraphics::imageIsDrawable() const
+void InsetGraphics::metrics(MetricsInfo & mi, Dimension & dim) const
 {
-       if (!cache_->loader.image() || cache_->loader.status() != grfx::Ready)
-               return false;
-
-       return cache_->loader.image()->isDrawable();
+       graphic_->metrics(mi, dim);
+       dim_ = dim;
 }
 
 
-void InsetGraphics::dimension(BufferView *, LyXFont const & font,
-       Dimension & dim) const
+void InsetGraphics::draw(PainterInfo & pi, int x, int y) const
 {
-       cache_->old_ascent = 50;
-       if (imageIsDrawable())
-               cache_->old_ascent = cache_->loader.image()->getHeight();
-       dim.a = cache_->old_ascent;
-       dim.d = 0;
-       if (imageIsDrawable())
-               dim.w = cache_->loader.image()->getWidth() + 2 * TEXT_TO_INSET_OFFSET;
-       else {
-               int font_width = 0;
-
-               LyXFont msgFont(font);
-               msgFont.setFamily(LyXFont::SANS_FAMILY);
-
-               string const justname = OnlyFilename(params().filename);
-               if (!justname.empty()) {
-                       msgFont.setSize(LyXFont::SIZE_FOOTNOTE);
-                       font_width = font_metrics::width(justname, msgFont);
-               }
-
-               string const msg = statusMessage();
-               if (!msg.empty()) {
-                       msgFont.setSize(LyXFont::SIZE_TINY);
-                       font_width = std::max(font_width, font_metrics::width(msg, msgFont));
-               }
-
-               dim.w = std::max(50, font_width + 15);
-       }
+       setPosCache(pi, x, y);
+       graphic_->draw(pi, x, y);
 }
 
 
-BufferView * InsetGraphics::view() const
-{
-       return cache_->view.lock().get();
-}
-
-
-void InsetGraphics::draw(BufferView * bv, LyXFont const & font,
-                        int baseline, float & x) const
-{
-       // MakeAbsPath returns params().filename unchanged if it absolute
-       // already.
-       string const file_with_path =
-               MakeAbsPath(params().filename, bv->buffer()->filePath());
-
-       // A 'paste' operation creates a new inset with the correct filepath,
-       // but then the 'old' inset stored in the 'copy' operation is actually
-       // added to the buffer.
-       // Thus, we should ensure that the filepath is correct.
-       if (file_with_path != cache_->loader.filename())
-               cache_->update(file_with_path);
-
-       cache_->view = bv->owner()->view();
-       int oasc = cache_->old_ascent;
-
-       int ldescent = descent(bv, font);
-       int lascent  = ascent(bv, font);
-       int lwidth   = width(bv, font);
-
-       // we may have changed while someone other was drawing us so better
-       // to not draw anything as we surely call to redraw ourself soon.
-       // This is not a nice thing to do and should be fixed properly somehow.
-       // But I still don't know the best way to go. So let's do this like this
-       // for now (Jug 20020311)
-       if (lascent != oasc)
-               return;
-
-       // Make sure now that x is updated upon exit from this routine
-       int old_x = int(x);
-       x += lwidth;
-
-       grfx::Params const & gparams = params().as_grfxParams();
-
-       if (gparams.display != grfx::NoDisplay &&
-                       cache_->loader.status() == grfx::WaitingToLoad)
-               cache_->loader.startLoading();
-
-       if (!cache_->loader.monitoring())
-               cache_->loader.startMonitoring();
-
-       // This will draw the graphics. If the graphics has not been loaded yet,
-       // we draw just a rectangle.
-       Painter & paint = bv->painter();
-
-       if (imageIsDrawable()) {
-               paint.image(old_x + TEXT_TO_INSET_OFFSET, baseline - lascent,
-                           lwidth - 2 * TEXT_TO_INSET_OFFSET, lascent + ldescent,
-                           *cache_->loader.image());
-
-       } else {
-
-               paint.rectangle(old_x + TEXT_TO_INSET_OFFSET, baseline - lascent,
-                               lwidth - 2 * TEXT_TO_INSET_OFFSET, lascent + ldescent);
-
-               // Print the file name.
-               LyXFont msgFont(font);
-               msgFont.setFamily(LyXFont::SANS_FAMILY);
-               string const justname = OnlyFilename (params().filename);
-               if (!justname.empty()) {
-                       msgFont.setSize(LyXFont::SIZE_FOOTNOTE);
-                       paint.text(old_x + TEXT_TO_INSET_OFFSET + 6,
-                                  baseline - font_metrics::maxAscent(msgFont) - 4,
-                                  justname, msgFont);
-               }
-
-               // Print the message.
-               string const msg = statusMessage();
-               if (!msg.empty()) {
-                       msgFont.setSize(LyXFont::SIZE_TINY);
-                       paint.text(old_x + TEXT_TO_INSET_OFFSET + 6, baseline - 4, msg, msgFont);
-               }
-       }
-}
-
-
-Inset::EDITABLE InsetGraphics::editable() const
+InsetOld::EDITABLE InsetGraphics::editable() const
 {
        return IS_EDITABLE;
 }
 
 
-void InsetGraphics::write(Buffer const *, ostream & os) const
+void InsetGraphics::write(Buffer const & buf, ostream & os) const
 {
        os << "Graphics\n";
-       params().Write(os);
+       params().Write(os, buf.filePath());
 }
 
 
-void InsetGraphics::read(Buffer const * buf, LyXLex & lex)
+void InsetGraphics::read(Buffer const & buf, LyXLex & lex)
 {
        string const token = lex.getString();
 
        if (token == "Graphics")
-               readInsetGraphics(lex);
+               readInsetGraphics(lex, buf.filePath());
        else
-               lyxerr[Debug::GRAPHICS] << "Not a Graphics inset!\n";
+               lyxerr[Debug::GRAPHICS] << "Not a Graphics inset!" << endl;
 
-       cache_->update(MakeAbsPath(params().filename, buf->filePath()));
+       graphic_->update(params().as_grfxParams());
 }
 
 
-void InsetGraphics::readInsetGraphics(LyXLex & lex)
+void InsetGraphics::readInsetGraphics(LyXLex & lex, string const & bufpath)
 {
        bool finished = false;
 
@@ -438,25 +272,14 @@ void InsetGraphics::readInsetGraphics(LyXLex & lex)
 
                string const token = lex.getString();
                lyxerr[Debug::GRAPHICS] << "Token: '" << token << '\''
-                                   << std::endl;
+                                   << endl;
 
                if (token.empty()) {
                        continue;
                } else if (token == "\\end_inset") {
                        finished = true;
-               } else if (token == "FormatVersion") {
-                       lex.next();
-                       int version = lex.getInteger();
-                       if (version > VersionNumber)
-                               lyxerr
-                               << "This document was created with a newer Graphics widget"
-                               ", You should use a newer version of LyX to read this"
-                               " file."
-                               << std::endl;
-                       // TODO: Possibly open up a dialog?
-               }
-               else {
-                       if (! params_.Read(lex, token))
+               } else {
+                       if (!params_.Read(lex, token, bufpath))
                                lyxerr << "Unknown token, " << token << ", skipping."
                                        << std::endl;
                }
@@ -476,8 +299,8 @@ string const InsetGraphics::createLatexOptions() const
            options << "  draft,\n";
        if (params().clip)
            options << "  clip,\n";
-       if (!lyx::float_equal(params().scale, 0.0, 0.05)) {
-               if (!lyx::float_equal(params().scale, 100.0, 0.05))
+       if (!float_equal(params().scale, 0.0, 0.05)) {
+               if (!float_equal(params().scale, 100.0, 0.05))
                        options << "  scale=" << params().scale / 100.0
                                << ",\n";
        } else {
@@ -491,7 +314,7 @@ string const InsetGraphics::createLatexOptions() const
 
        // Make sure rotation angle is not very close to zero;
        // a float can be effectively zero but not exactly zero.
-       if (!lyx::float_equal(params().rotateAngle, 0, 0.001)) {
+       if (!float_equal(params().rotateAngle, 0, 0.001)) {
            options << "  angle=" << params().rotateAngle << ",\n";
            if (!params().rotateOrigin.empty()) {
                options << "  origin=" << params().rotateOrigin[0];
@@ -508,192 +331,289 @@ string const InsetGraphics::createLatexOptions() const
        if (!params().special.empty())
            options << params().special << ",\n";
 
-       string opts = STRCONV(options.str());
+       string opts = options.str();
        // delete last ",\n"
        return opts.substr(0, opts.size() - 2);
 }
 
 
-string const InsetGraphics::prepareFile(Buffer const * buf,
-                                       LatexRunParams const & runparams) const
+namespace {
+
+enum CopyStatus {
+       SUCCESS,
+       FAILURE,
+       IDENTICAL_PATHS,
+       IDENTICAL_CONTENTS
+};
+
+
+std::pair<CopyStatus, string> const
+copyFileIfNeeded(string const & file_in, string const & file_out)
 {
-       // LaTeX can cope if the graphics file doesn't exist, so just return the
-       // filename.
-       string const orig_file = params().filename;
-       string orig_file_with_path =
-               MakeAbsPath(orig_file, buf->filePath());
-       lyxerr[Debug::GRAPHICS] << "[InsetGraphics::prepareFile] orig_file = "
-                   << orig_file << "\n\twith path: "
-                   << orig_file_with_path << endl;
-
-       if (!IsFileReadable(orig_file_with_path))
-               return orig_file;
+       BOOST_ASSERT(AbsolutePath(file_in));
+       BOOST_ASSERT(AbsolutePath(file_out));
 
-       bool const zipped = zippedFile(orig_file_with_path);
+       unsigned long const checksum_in  = support::sum(file_in);
+       unsigned long const checksum_out = support::sum(file_out);
 
-       // If the file is compressed and we have specified that it
-       // should not be uncompressed, then just return its name and
-       // let LaTeX do the rest!
-       if (zipped && params().noUnzip) {
+       if (checksum_in == checksum_out)
+               // Nothing to do...
+               return std::make_pair(IDENTICAL_CONTENTS, file_out);
+
+       bool const success = support::copy(file_in, file_out);
+       if (!success) {
                lyxerr[Debug::GRAPHICS]
-                       << "\tpass zipped file to LaTeX but with full path.\n";
-               // LaTeX needs an absolue path, otherwise the
-               // coresponding *.eps.bb file isn't found
-               return orig_file_with_path;
+                       << support::bformat(_("Could not copy the file\n%1$s\n"
+                                             "into the temporary directory."),
+                                           file_in)
+                       << std::endl;
        }
 
-       // Ascertain whether the file has changed.
-       unsigned long const new_checksum = cache_->loader.checksum();
-       bool const file_has_changed = cache_->checksum != new_checksum;
-       if (file_has_changed)
-               cache_->checksum = new_checksum;
+       CopyStatus status = success ? SUCCESS : FAILURE;
+       return std::make_pair(status, file_out);
+}
+
+
+std::pair<CopyStatus, string> const
+copyToDirIfNeeded(string const & file_in, string const & dir, bool zipped)
+{
+       using support::rtrim;
+
+       BOOST_ASSERT(AbsolutePath(file_in));
+
+       string const only_path = support::OnlyPath(file_in);
+       if (rtrim(support::OnlyPath(file_in) , "/") == rtrim(dir, "/"))
+               return std::make_pair(IDENTICAL_PATHS, file_in);
+
+       string mangled = FileName(file_in).mangledFilename();
+       if (zipped) {
+               // We need to change _eps.gz to .eps.gz. The mangled name is
+               // still unique because of the counter in mangledFilename().
+               // We can't just call mangledFilename() with the zip
+               // extension removed, because base.eps and base.eps.gz may
+               // have different content but would get the same mangled
+               // name in this case.
+               string const base = RemoveExtension(unzippedFileName(file_in));
+               string::size_type const ext_len = file_in.length() - base.length();
+               mangled[mangled.length() - ext_len] = '.';
+       }
+       string const file_out = support::MakeAbsPath(mangled, dir);
+
+       return copyFileIfNeeded(file_in, file_out);
+}
+
+
+string const stripExtension(string const & file)
+{
+       // Remove the extension so the LaTeX will use whatever
+       // is appropriate (when there are several versions in
+       // different formats)
+       // This works only if the filename contains no dots besides
+       // the just removed one. We can fool here by replacing all
+       // dots with a macro whose definition is just a dot ;-)
+       return subst(RemoveExtension(file), ".", "\\lyxdot ");
+}
+
+
+string const stripExtensionIfPossible(string const & file, string const & to)
+{
+       // No conversion is needed. LaTeX can handle the graphic file as is.
+       // This is true even if the orig_file is compressed.
+       string const to_format = formats.getFormat(to)->extension();
+       string const file_format = GetExtension(file);
+       // for latex .ps == .eps
+       if (to_format == file_format ||
+           (to_format == "eps" && file_format ==  "ps") ||
+           (to_format ==  "ps" && file_format == "eps"))
+               return stripExtension(file);
+       return file;
+}
+
+} // namespace anon
+
+
+string const InsetGraphics::prepareFile(Buffer const & buf,
+                                       OutputParams const & runparams) const
+{
+       // We assume that the file exists (the caller checks this)
+       string const orig_file = params().filename.absFilename();
+       string const rel_file = params().filename.relFilename(buf.filePath());
+
+       // If the file is compressed and we have specified that it
+       // should not be uncompressed, then just return its name and
+       // let LaTeX do the rest!
+       bool const zipped = params().filename.isZipped();
 
        // temp_file will contain the file for LaTeX to act on if, for example,
        // we move it to a temp dir or uncompress it.
        string temp_file = orig_file;
 
+       // The master buffer. This is useful when there are multiple levels
+       // of include files
+       Buffer const * m_buffer = buf.getMasterBuffer();
+
+       // We place all temporary files in the master buffer's temp dir.
+       // This is possible because we use mangled file names.
+       // This is necessary for DVI export.
+       string const temp_path = m_buffer->temppath();
+
+       CopyStatus status;
+       boost::tie(status, temp_file) =
+                       copyToDirIfNeeded(orig_file, temp_path, zipped);
+
+       if (status == FAILURE)
+               return orig_file;
+
+       // a relative filename should be relative to the master
+       // buffer.
+       // "nice" means that the buffer is exported to LaTeX format but not
+       //        run through the LaTeX compiler.
+       string const output_file = os::external_path(runparams.nice ?
+               params().filename.outputFilename(m_buffer->filePath()) :
+               OnlyFilename(temp_file));
+       string const source_file = runparams.nice ? orig_file : temp_file;
+
        if (zipped) {
-               // Uncompress the file if necessary.
-               // If it has been uncompressed in a previous call to
-               // prepareFile, do nothing.
-               temp_file = MakeAbsPath(OnlyFilename(temp_file), buf->tmppath);
-               lyxerr[Debug::GRAPHICS]
-                       << "\ttemp_file: " << temp_file << endl;
-               if (file_has_changed || !IsFileReadable(temp_file)) {
-                       bool const success = lyx::copy(orig_file_with_path,
-                                                      temp_file);
+               if (params().noUnzip) {
+                       // We don't know whether latex can actually handle
+                       // this file, but we can't check, because that would
+                       // mean to unzip the file and thereby making the
+                       // noUnzip parameter meaningless.
+                       lyxerr[Debug::GRAPHICS]
+                               << "\tpass zipped file to LaTeX.\n";
+
+                       string const bb_orig_file = ChangeExtension(orig_file, "bb");
+                       if (runparams.nice) {
+                               runparams.exportdata->addExternalFile("latex",
+                                               bb_orig_file,
+                                               ChangeExtension(output_file, "bb"));
+                       } else {
+                               // LaTeX needs the bounding box file in the
+                               // tmp dir
+                               string bb_file = ChangeExtension(temp_file, "bb");
+                               boost::tie(status, bb_file) =
+                                       copyFileIfNeeded(bb_orig_file, bb_file);
+                               if (status == FAILURE)
+                                       return orig_file;
+                               runparams.exportdata->addExternalFile("latex",
+                                               bb_file);
+                       }
+                       runparams.exportdata->addExternalFile("latex",
+                                       source_file, output_file);
+                       runparams.exportdata->addExternalFile("dvi",
+                                       source_file, output_file);
+                       // We can't strip the extension, because we don't know
+                       // the unzipped file format
+                       return output_file;
+               }
+
+               string const unzipped_temp_file = unzippedFileName(temp_file);
+               if (compare_timestamps(unzipped_temp_file, temp_file) > 0) {
+                       // temp_file has been unzipped already and
+                       // orig_file has not changed in the meantime.
+                       temp_file = unzipped_temp_file;
                        lyxerr[Debug::GRAPHICS]
-                               << "\tCopying zipped file from "
-                               << orig_file_with_path << " to " << temp_file
-                               << (success ? " succeeded\n" : " failed\n");
-               } else
+                               << "\twas already unzipped to " << temp_file
+                               << endl;
+               } else {
+                       // unzipped_temp_file does not exist or is too old
+                       temp_file = unzipFile(temp_file);
                        lyxerr[Debug::GRAPHICS]
-                               << "\tzipped file " << temp_file
-                               << " exists! Maybe no tempdir ...\n";
-               orig_file_with_path = unzipFile(temp_file);
-               lyxerr[Debug::GRAPHICS]
-                       << "\tunzipped to " << orig_file_with_path << endl;
+                               << "\tunzipped to " << temp_file << endl;
+               }
        }
 
-       string const from = getExtFromContents(orig_file_with_path);
+       string const from = getExtFromContents(temp_file);
        string const to   = findTargetFormat(from, runparams);
        lyxerr[Debug::GRAPHICS]
                << "\t we have: from " << from << " to " << to << '\n';
 
-       if (from == to && !lyxrc.use_tempdir) {
-               // No conversion is needed. LaTeX can handle the
-               // graphic file as is.
-               // This is true even if the orig_file is compressed.
-               if (formats.getFormat(to)->extension() == GetExtension(orig_file))
-                       return RemoveExtension(orig_file_with_path);
-               return orig_file_with_path;
-       }
-
        // We're going to be running the exported buffer through the LaTeX
        // compiler, so must ensure that LaTeX can cope with the graphics
        // file format.
 
-       // Perform all these manipulations on a temporary file if possible.
-       // If we are not using a temp dir, then temp_file contains the
-       // original file.
-       // to allow files with the same name in different dirs
-       // we manipulate the original file "any.dir/file.ext"
-       // to "any_dir_file.ext"! changing the dots in the
-       // dirname is important for the use of ChangeExtension
        lyxerr[Debug::GRAPHICS]
-               << "\tthe orig file is: " << orig_file_with_path << endl;
-
-       if (lyxrc.use_tempdir) {
-               string const ext_tmp = GetExtension(orig_file_with_path);
-               // without ext and /
-               temp_file = subst(
-                       ChangeExtension(orig_file_with_path, string()), "/", "_");
-               // without dots and again with ext
-               temp_file = ChangeExtension(
-                       subst(temp_file, ".", "_"), ext_tmp);
-               // now we have any_dir_file.ext
-               temp_file = MakeAbsPath(temp_file, buf->tmppath);
-               lyxerr[Debug::GRAPHICS]
-                       << "\tchanged to: " << temp_file << endl;
+               << "\tthe orig file is: " << orig_file << endl;
+
+       if (from == to) {
+               // The extension of temp_file might be != to!
+               runparams.exportdata->addExternalFile("latex", source_file,
+                                                     output_file);
+               runparams.exportdata->addExternalFile("dvi", source_file,
+                                                     output_file);
+               return stripExtensionIfPossible(output_file, to);
+       }
 
-               // if the file doen't exists, copy it into the tempdir
-               if (file_has_changed || !IsFileReadable(temp_file)) {
-                       bool const success = lyx::copy(orig_file_with_path, temp_file);
-                       lyxerr[Debug::GRAPHICS]
-                               << "\tcopying from " << orig_file_with_path << " to "
-                               << temp_file
-                               << (success ? " succeeded\n" : " failed\n");
-                       if (!success) {
-                               string str = bformat(_("Could not copy the file\n%1$s\n"
-                                       "into the temporary directory."), orig_file_with_path);
-                               Alert::error(_("Graphics display failed"), str);
-                               return orig_file;
-                       }
-               }
+       string const to_file = ChangeExtension(temp_file, to);
+       string const output_to_file = ChangeExtension(output_file, to);
 
-               if (from == to) {
-                       // No conversion is needed. LaTeX can handle the
-                       // graphic file as is.
-                       if (formats.getFormat(to)->extension() == GetExtension(orig_file))
-                               return RemoveExtension(temp_file);
-                       return temp_file;
-               }
+       // Do we need to perform the conversion?
+       // Yes if to_file does not exist or if temp_file is newer than to_file
+       if (compare_timestamps(temp_file, to_file) < 0) {
+               lyxerr[Debug::GRAPHICS]
+                       << bformat(_("No conversion of %1$s is needed after all"),
+                                  rel_file)
+                       << std::endl;
+               runparams.exportdata->addExternalFile("latex", to_file,
+                                                     output_to_file);
+               runparams.exportdata->addExternalFile("dvi", to_file,
+                                                     output_to_file);
+               return stripExtension(output_file);
        }
 
-       string const outfile_base = RemoveExtension(temp_file);
        lyxerr[Debug::GRAPHICS]
                << "\tThe original file is " << orig_file << "\n"
                << "\tA copy has been made and convert is to be called with:\n"
                << "\tfile to convert = " << temp_file << '\n'
-               << "\toutfile_base = " << outfile_base << '\n'
                << "\t from " << from << " to " << to << '\n';
 
-       // if no special converter defined, than we take the default one
+       // if no special converter defined, then we take the default one
        // from ImageMagic: convert from:inname.from to:outname.to
-       if (!converters.convert(buf, temp_file, outfile_base, from, to)) {
+       if (!converters.convert(&buf, temp_file, temp_file, from, to)) {
                string const command =
-                       LibFileSearch("scripts", "convertDefault.sh") +
+                       "sh " + LibFileSearch("scripts", "convertDefault.sh") +
                                ' ' + from + ':' + temp_file + ' ' +
-                               to + ':' + outfile_base + '.' + to;
+                               to + ':' + to_file;
                lyxerr[Debug::GRAPHICS]
                        << "No converter defined! I use convertDefault.sh:\n\t"
                        << command << endl;
                Systemcall one;
                one.startscript(Systemcall::Wait, command);
-               if (!IsFileReadable(ChangeExtension(outfile_base, to))) {
+               if (IsFileReadable(to_file)) {
+                       runparams.exportdata->addExternalFile("latex",
+                                       to_file, output_to_file);
+                       runparams.exportdata->addExternalFile("dvi",
+                                       to_file, output_to_file);
+               } else {
                        string str = bformat(_("No information for converting %1$s "
-                               "format files to %1$s.\n"
+                               "format files to %2$s.\n"
                                "Try defining a convertor in the preferences."), from, to);
                        Alert::error(_("Could not convert image"), str);
                }
        }
 
-       return RemoveExtension(temp_file);
+       return stripExtension(output_file);
 }
 
 
-int InsetGraphics::latex(Buffer const * buf, ostream & os,
-                        LatexRunParams const & runparams,
-                        bool/*fs*/) const
+int InsetGraphics::latex(Buffer const & buf, ostream & os,
+                        OutputParams const & runparams) const
 {
        // If there is no file specified or not existing,
        // just output a message about it in the latex output.
        lyxerr[Debug::GRAPHICS]
                << "insetgraphics::latex: Filename = "
-               << params().filename << endl;
-
-       // A missing (e)ps-extension is no problem for LaTeX, so
-       // we have to test three different cases
-       string const file_ = MakeAbsPath(params().filename, buf->filePath());
-       bool const file_exists =
-               !file_.empty() &&
-               (IsFileReadable(file_) ||               // original
-                IsFileReadable(file_ + ".eps") ||      // original.eps
-                IsFileReadable(file_ + ".ps"));        // original.ps
+               << params().filename.absFilename() << endl;
+
+       string const relative_file =
+               params().filename.relFilename(buf.filePath());
+
+       string const file_ = params().filename.absFilename();
+       bool const file_exists = !file_.empty() && IsFileReadable(file_);
        string const message = file_exists ?
                string() : string("bb = 0 0 200 100, draft, type=eps");
-       // if !message.empty() than there was no existing file
-       // "filename(.(e)ps)" found. In this case LaTeX
+       // if !message.empty() then there was no existing file
+       // "filename" found. In this case LaTeX
        // draws only a rectangle with the above bb and the
        // not found filename in it.
        lyxerr[Debug::GRAPHICS]
@@ -725,54 +645,68 @@ int InsetGraphics::latex(Buffer const * buf, ostream & os,
                << "\n\tafter = " << after << endl;
 
 
-       // "nice" means that the buffer is exported to LaTeX format but not
-       //        run through the LaTeX compiler.
-       if (runparams.nice) {
-               os << before <<'{' << params().filename << '}' << after;
-               return 1;
-       }
+       string latex_str = before + '{';
+       if (file_exists)
+               // Convert the file if necessary.
+               // Remove the extension so the LaTeX will use whatever
+               // is appropriate (when there are several versions in
+               // different formats)
+               latex_str += prepareFile(buf, runparams);
+       else
+               latex_str += relative_file + " not found!";
 
-       // Make the filename relative to the lyx file
-       // and remove the extension so the LaTeX will use whatever is
-       // appropriate (when there are several versions in different formats)
-       string const latex_str = message.empty() ?
-               (before + '{' + os::external_path(prepareFile(buf, runparams)) + '}' + after) :
-               (before + '{' + params().filename + " not found!}" + after);
+       latex_str += '}' + after;
        os << latex_str;
 
+       lyxerr[Debug::GRAPHICS] << "InsetGraphics::latex outputting:\n"
+                               << latex_str << endl;
        // Return how many newlines we issued.
        return int(lyx::count(latex_str.begin(), latex_str.end(),'\n') + 1);
 }
 
 
-int InsetGraphics::ascii(Buffer const *, ostream & os, int) const
+int InsetGraphics::plaintext(Buffer const &, ostream & os,
+                        OutputParams const &) const
 {
        // No graphics in ascii output. Possible to use gifscii to convert
        // images to ascii approximation.
        // 1. Convert file to ascii using gifscii
        // 2. Read ascii output file and add it to the output stream.
        // at least we send the filename
-       os << '<' << bformat(_("Graphics file: %1$s"), params().filename) << ">\n";
+       os << '<' << bformat(_("Graphics file: %1$s"),
+                            params().filename.absFilename()) << ">\n";
        return 0;
 }
 
 
-int InsetGraphics::linuxdoc(Buffer const *, ostream &) const
+int InsetGraphics::linuxdoc(Buffer const & buf, ostream & os,
+                           OutputParams const & runparams) const
 {
-       // No graphics in LinuxDoc output. Should check how/what to add.
+       string const file_name = runparams.nice ?
+                               params().filename.relFilename(buf.filePath()):
+                               params().filename.absFilename();
+
+       runparams.exportdata->addExternalFile("linuxdoc",
+                                             params().filename.absFilename());
+       os << "<eps file=\"" << file_name << "\">\n";
+       os << "<img src=\"" << file_name << "\">";
        return 0;
 }
 
 
 // For explanation on inserting graphics into DocBook checkout:
-// http://linuxdoc.org/LDP/LDP-Author-Guide/inserting-pictures.html
+// http://en.tldp.org/LDP/LDP-Author-Guide/html/inserting-pictures.html
 // See also the docbook guide at http://www.docbook.org/
-int InsetGraphics::docbook(Buffer const *, ostream & os,
-                          bool /*mixcont*/) const
+int InsetGraphics::docbook(Buffer const &, ostream & os,
+                          OutputParams const & runparams) const
 {
        // In DocBook v5.0, the graphic tag will be eliminated from DocBook, will
        // need to switch to MediaObject. However, for now this is sufficient and
        // easier to use.
+       runparams.exportdata->addExternalFile("docbook",
+                                             params().filename.absFilename());
+       runparams.exportdata->addExternalFile("docbook-xml",
+                                             params().filename.absFilename());
        os << "<graphic fileref=\"&" << graphic_label << ";\">";
        return 0;
 }
@@ -784,24 +718,28 @@ void InsetGraphics::validate(LaTeXFeatures & features) const
        if (params().filename.empty())
                return;
 
-       features.includeFile(graphic_label, RemoveExtension(params().filename));
+       features.includeFile(graphic_label,
+                            RemoveExtension(params().filename.absFilename()));
 
        features.require("graphicx");
 
+       if (features.nice()) {
+               Buffer const * m_buffer = features.buffer().getMasterBuffer();
+               string basename =
+                       params().filename.outputFilename(m_buffer->filePath());
+               basename = RemoveExtension(basename);
+               if(params().filename.isZipped())
+                       basename = RemoveExtension(basename);
+               if (contains(basename, "."))
+                       features.require("lyxdot");
+       }
+
        if (params().subcaption)
                features.require("subfigure");
 }
 
 
-void InsetGraphics::statusChanged()
-{
-       if (!cache_->view.expired())
-               cache_->view.lock()->updateInset(this);
-}
-
-
-bool InsetGraphics::setParams(InsetGraphicsParams const & p,
-                             string const & filepath)
+bool InsetGraphics::setParams(InsetGraphicsParams const & p)
 {
        // If nothing is changed, just return and say so.
        if (params() == p && !p.filename.empty())
@@ -810,8 +748,8 @@ bool InsetGraphics::setParams(InsetGraphicsParams const & p,
        // Copy the new parameters.
        params_ = p;
 
-       // Update the inset with the new parameters.
-       cache_->update(MakeAbsPath(params().filename, filepath));
+       // Update the display using the new parameters.
+       graphic_->update(params().as_grfxParams());
 
        // We have changed data, report it.
        return true;
@@ -824,6 +762,13 @@ InsetGraphicsParams const & InsetGraphics::params() const
 }
 
 
+void InsetGraphics::editGraphics(InsetGraphicsParams const & p, Buffer const & buffer) const
+{
+       string const file_with_path = p.filename.absFilename();
+       formats.edit(buffer, file_with_path, getExtFromContents(file_with_path));
+}
+
+
 string const InsetGraphicsMailer::name_("graphics");
 
 InsetGraphicsMailer::InsetGraphicsMailer(InsetGraphics & inset)
@@ -831,45 +776,42 @@ InsetGraphicsMailer::InsetGraphicsMailer(InsetGraphics & inset)
 {}
 
 
-string const InsetGraphicsMailer::inset2string() const
+string const InsetGraphicsMailer::inset2string(Buffer const & buffer) const
 {
-       return params2string(inset_.params());
+       return params2string(inset_.params(), buffer);
 }
 
 
 void InsetGraphicsMailer::string2params(string const & in,
+                                       Buffer const & buffer,
                                        InsetGraphicsParams & params)
 {
        params = InsetGraphicsParams();
-
        if (in.empty())
                return;
 
-       istringstream data(STRCONV(in));
+       istringstream data(in);
        LyXLex lex(0,0);
        lex.setStream(data);
 
-       if (lex.isOK()) {
-               lex.next();
-               string const token = lex.getString();
-               if (token != name_)
-                       return;
-       }
+       string name;
+       lex >> name;
+       if (!lex || name != name_)
+               return print_mailer_error("InsetGraphicsMailer", in, 1, name_);
 
-       if (lex.isOK()) {
-               InsetGraphics inset;
-               inset.readInsetGraphics(lex);
-               params = inset.params();
-       }
+       InsetGraphics inset;
+       inset.readInsetGraphics(lex, buffer.filePath());
+       params = inset.params();
 }
 
 
 string const
-InsetGraphicsMailer::params2string(InsetGraphicsParams const & params)
+InsetGraphicsMailer::params2string(InsetGraphicsParams const & params,
+                                  Buffer const & buffer)
 {
        ostringstream data;
        data << name_ << ' ';
-       params.Write(data);
+       params.Write(data, buffer.filePath());
        data << "\\end_inset\n";
-       return STRCONV(data.str());
+       return data.str();
 }