The speed patch: redraw only rows that have changed

[lyx.git] / src / insets / insetexternal.C

diff --git a/src/insets/insetexternal.C b/src/insets/insetexternal.C
index b4548c62501c2d17680b1ce274221969e4645035..4af98bba7798aaabc06d8a9fd1291caf1e7f6f18 100644 (file)
--- a/src/insets/insetexternal.C
+++ b/src/insets/insetexternal.C
@@ -37,11 +37,10 @@
 
 #include "graphics/PreviewLoader.h"
 
-#include "support/FileInfo.h"
 #include "support/filetools.h"
 #include "support/lstrings.h"
 #include "support/lyxlib.h"
-#include "support/tostr.h"
+#include "support/convert.h"
 #include "support/translator.h"
 
 #include <boost/bind.hpp>
@@ -201,7 +200,7 @@ void InsetExternalParams::write(Buffer const & buffer, ostream & os) const
                   << '\n';
 
        if (lyxscale != defaultLyxScale)
-               os << "\tlyxscale " << tostr(lyxscale) << '\n';
+               os << "\tlyxscale " << convert<string>(lyxscale) << '\n';
 
        if (draft)
                os << "\tdraft\n";
@@ -220,7 +219,7 @@ void InsetExternalParams::write(Buffer const & buffer, ostream & os) const
        }
 
        if (!rotationdata.no_rotation()) {
-               os << "\trotateAngle " << rotationdata.angle() << '\n';
+               os << "\trotateAngle " << rotationdata.adjAngle() << '\n';
                if (rotationdata.origin() != external::RotationData::DEFAULT)
                        os << "\trotateOrigin "
                           << rotationdata.originString() << '\n';
@@ -228,9 +227,9 @@ void InsetExternalParams::write(Buffer const & buffer, ostream & os) const
 
        if (!resizedata.no_resize()) {
                using support::float_equal;
-
-               if (!float_equal(resizedata.scale, 0.0, 0.05)) {
-                       if (!float_equal(resizedata.scale, 100.0, 0.05))
+               double const scl = convert<double>(resizedata.scale);
+               if (!float_equal(scl, 0.0, 0.05)) {
+                       if (!float_equal(scl, 100.0, 0.05))
                                os << "\tscale "
                                   << resizedata.scale << '\n';
                } else {
@@ -354,7 +353,7 @@ bool InsetExternalParams::read(Buffer const & buffer, LyXLex & lex)
 
                case EX_ROTATEANGLE:
                        lex.next();
-                       rotationdata.angle(lex.getFloat());
+                       rotationdata.angle = lex.getString();
                        break;
 
                case EX_ROTATEORIGIN:
@@ -364,7 +363,7 @@ bool InsetExternalParams::read(Buffer const & buffer, LyXLex & lex)
 
                case EX_SCALE:
                        lex.next();
-                       resizedata.scale = lex.getFloat();
+                       resizedata.scale = lex.getString();
                        break;
 
                case EX_WIDTH:
@@ -415,7 +414,7 @@ InsetExternal::InsetExternal(InsetExternal const & other)
 {}
 
 
-auto_ptr<InsetBase> InsetExternal::clone() const
+auto_ptr<InsetBase> InsetExternal::doClone() const
 {
        return auto_ptr<InsetBase>(new InsetExternal(*this));
 }
@@ -433,7 +432,7 @@ void InsetExternal::statusChanged() const
 }
 
 
-void InsetExternal::priv_dispatch(LCursor & cur, FuncRequest & cmd)
+void InsetExternal::doDispatch(LCursor & cur, FuncRequest & cmd)
 {
        switch (cmd.action) {
 
@@ -462,7 +461,24 @@ void InsetExternal::priv_dispatch(LCursor & cur, FuncRequest & cmd)
                break;
 
        default:
-               InsetOld::priv_dispatch(cur, cmd);
+               InsetBase::doDispatch(cur, cmd);
+       }
+}
+
+
+bool InsetExternal::getStatus(LCursor & cur, FuncRequest const & cmd,
+               FuncStatus & flag) const
+{
+       switch (cmd.action) {
+
+       case LFUN_EXTERNAL_EDIT:
+       case LFUN_INSET_MODIFY:
+       case LFUN_INSET_DIALOG_UPDATE:
+               flag.enabled(true);
+               return true;
+
+       default:
+               return InsetBase::getStatus(cur, cmd, flag);
        }
 }
 
@@ -524,7 +540,7 @@ graphics::Params get_grfx_params(InsetExternalParams const & eparams)
        gparams.scale = eparams.lyxscale;
        if (eparams.clipdata.clip)
                gparams.bb = eparams.clipdata.bbox;
-       gparams.angle = eparams.rotationdata.angle();
+       gparams.angle = convert<double>(eparams.rotationdata.adjAngle());
 
        switch (eparams.display) {
        case external::DefaultDisplay:
@@ -563,7 +579,7 @@ string const getScreenLabel(InsetExternalParams const & params,
        if (!ptr)
                return support::bformat(_("External template %1$s is not installed"),
                                        params.templatename());
-       return external::doSubstitution(params, buffer, ptr->guiName);
+       return external::doSubstitution(params, buffer, ptr->guiName, false);
 }
 
 void add_preview_and_start_loading(RenderMonitoredPreview &,
@@ -733,18 +749,24 @@ void InsetExternal::validate(LaTeXFeatures & features) const
                return;
        external::Template const & et = *et_ptr;
 
+       // FIXME: This is wrong if we export to PDFLaTeX
        external::Template::Formats::const_iterator cit =
                et.formats.find("LaTeX");
        if (cit == et.formats.end())
                return;
 
-       if (!cit->second.requirement.empty())
-               features.require(cit->second.requirement);
+       // FIXME: We don't need that always
+       features.require("lyxdot");
+
+       vector<string>::const_iterator it  = cit->second.requirements.begin();
+       vector<string>::const_iterator end = cit->second.requirements.end();
+       for (; it != end; ++it)
+               features.require(*it);
 
        external::TemplateManager & etm = external::TemplateManager::get();
 
-       vector<string>::const_iterator it  = cit->second.preambleNames.begin();
-       vector<string>::const_iterator end = cit->second.preambleNames.end();
+       it  = cit->second.preambleNames.begin();
+       end = cit->second.preambleNames.end();
        for (; it != end; ++it) {
                string const preamble = etm.getPreambleDefByName(*it);
                if (!preamble.empty())