prevent crash when inserting minipage in table cell,

[lyx.git] / src / insets / insetcollapsable.C

diff --git a/src/insets/insetcollapsable.C b/src/insets/insetcollapsable.C
index 3adf4c17ef957962372391dc1ab29e86d4a21329..4a5002bf199fc9e1f96f1c568393b1ae618b161a 100644 (file)
--- a/src/insets/insetcollapsable.C
+++ b/src/insets/insetcollapsable.C
@@ -35,18 +35,17 @@
 #include "support/LOstream.h"
 
 using namespace lyx::support;
+using namespace lyx::graphics;
 
 using std::vector;
 using std::ostream;
 using std::endl;
 using std::max;
 
-namespace grfx = lyx::graphics;
 
 InsetCollapsable::InsetCollapsable(BufferParams const & bp, bool collapsed)
        : UpdatableInset(), collapsed_(collapsed), inset(bp),
-         button_length(0), button_top_y(0), button_bottom_y(0),
-         label("Label"),
+         button_dim(0, 0, 0, 0), label("Label"),
 #if 0
        autocollapse(false),
 #endif
@@ -63,8 +62,7 @@ InsetCollapsable::InsetCollapsable(BufferParams const & bp, bool collapsed)
 InsetCollapsable::InsetCollapsable(InsetCollapsable const & in)
        : UpdatableInset(in), collapsed_(in.collapsed_),
          framecolor(in.framecolor), labelfont(in.labelfont), inset(in.inset),
-         button_length(0), button_top_y(0), button_bottom_y(0),
-         label(in.label),
+         button_dim(0, 0, 0, 0), label(in.label),
 #if 0
          autocollapse(in.autocollapse),
 #endif
@@ -75,7 +73,7 @@ InsetCollapsable::InsetCollapsable(InsetCollapsable const & in)
 }
 
 
-bool InsetCollapsable::insertInset(BufferView * bv, Inset * in)
+bool InsetCollapsable::insertInset(BufferView * bv, InsetOld * in)
 {
        if (!insetAllowed(in->lyxCode())) {
                lyxerr << "InsetCollapsable::InsertInset: "
@@ -115,7 +113,6 @@ void InsetCollapsable::read(Buffer const * buf, LyXLex & lex)
 void InsetCollapsable::dimension_collapsed(Dimension & dim) const
 {
        font_metrics::buttonText(label, labelfont, dim.wid, dim.asc, dim.des);
-       dim.wid += 2 * TEXT_TO_INSET_OFFSET;
 }
 
 
@@ -143,7 +140,7 @@ void InsetCollapsable::metrics(MetricsInfo & mi, Dimension & dim) const
 
 void InsetCollapsable::draw_collapsed(PainterInfo & pi, int x, int y) const
 {
-       pi.pain.buttonText(x + TEXT_TO_INSET_OFFSET, y, label, labelfont);
+       pi.pain.buttonText(x, y, label, labelfont);
 }
 
 
@@ -158,10 +155,11 @@ void InsetCollapsable::draw(PainterInfo & pi, int x, int y, bool inlined) const
        Dimension dim_collapsed;
        dimension_collapsed(dim_collapsed);
 
-       int const aa    = ascent();
-       button_length   = dim_collapsed.width();
-       button_top_y    = -aa;
-       button_bottom_y = -aa + dim_collapsed.height();
+       int const aa  = ascent();
+       button_dim.x1 = 0;
+       button_dim.x2 = dim_collapsed.width();
+       button_dim.y1 = -aa;
+       button_dim.y2 = -aa + dim_collapsed.height();
 
        if (!isOpen()) {
                draw_collapsed(pi, x, y);
@@ -182,8 +180,7 @@ void InsetCollapsable::draw(PainterInfo & pi, int x, int y, bool inlined) const
                inset.draw(pi, x, y);
        } else {
                draw_collapsed(pi, old_x, bl);
-               int const yy = bl + dim_collapsed.descent() + inset.ascent();
-               inset.draw(pi, x, yy);
+               inset.draw(pi, x, bl + dim_collapsed.descent() + inset.ascent());
        }
 }
 
@@ -195,7 +192,7 @@ void InsetCollapsable::draw(PainterInfo & pi, int x, int y) const
 }
 
 
-Inset::EDITABLE InsetCollapsable::editable() const
+InsetOld::EDITABLE InsetCollapsable::editable() const
 {
        return collapsed_ ? IS_EDITABLE : HIGHLY_EDITABLE;
 }
@@ -241,8 +238,7 @@ void InsetCollapsable::lfunMouseRelease(FuncRequest const & cmd)
                return;
        }
 
-       if ((cmd.button() != mouse_button::button3) && (cmd.x < button_length) &&
-           (cmd.y >= button_top_y) && (cmd.y <= button_bottom_y))
+       if (cmd.button() != mouse_button::button3 && hitButton(cmd))
        {
                if (collapsed_) {
                        collapsed_ = false;
@@ -255,7 +251,7 @@ void InsetCollapsable::lfunMouseRelease(FuncRequest const & cmd)
                        bv->updateInset(this);
                        bv->buffer()->markDirty();
                }
-       } else if (!collapsed_ && (cmd.y > button_bottom_y)) {
+       } else if (!collapsed_ && (cmd.y > button_dim.y2)) {
                ret = (inset.localDispatch(adjustCommand(cmd)) == DISPATCHED);
        }
        if (cmd.button() == mouse_button::button3 && !ret)
@@ -288,7 +284,13 @@ int InsetCollapsable::docbook(Buffer const * buf, ostream & os, bool mixcont) co
 }
 
 
-Inset::RESULT InsetCollapsable::localDispatch(FuncRequest const & cmd)
+bool InsetCollapsable::hitButton(FuncRequest const & cmd) const
+{
+       return button_dim.contained(cmd.x, cmd.y);
+}
+
+
+InsetOld::RESULT InsetCollapsable::localDispatch(FuncRequest const & cmd)
 {
        lyxerr << "InsetCollapsable::localDispatch: "
                << cmd.action << " '" << cmd.argument << "'\n";
@@ -337,7 +339,7 @@ Inset::RESULT InsetCollapsable::localDispatch(FuncRequest const & cmd)
                                FuncRequest cmd1 = cmd;
                                if (!bv->lockInset(this))
                                        return DISPATCHED;
-                               if (cmd.y <= button_bottom_y) {
+                               if (cmd.y <= button_dim.y2) {
                                        cmd1.y = 0;
                                } else {
                                        cmd1.y = ascent() + cmd.y - (height_collapsed() + inset.ascent());
@@ -348,12 +350,12 @@ Inset::RESULT InsetCollapsable::localDispatch(FuncRequest const & cmd)
                }
 
                case LFUN_MOUSE_PRESS:
-                       if (!collapsed_ && cmd.y > button_bottom_y)
+                       if (!collapsed_ && cmd.y > button_dim.y2)
                                inset.localDispatch(adjustCommand(cmd));
                        return DISPATCHED;
 
                case LFUN_MOUSE_MOTION:
-                       if (!collapsed_ && cmd.y > button_bottom_y)
+                       if (!collapsed_ && cmd.y > button_dim.y2)
                                inset.localDispatch(adjustCommand(cmd));
                        return DISPATCHED;
 
@@ -390,7 +392,7 @@ bool InsetCollapsable::unlockInsetInInset(BufferView * bv, UpdatableInset * in,
 }
 
 
-bool InsetCollapsable::updateInsetInInset(BufferView * bv, Inset *in)
+bool InsetCollapsable::updateInsetInInset(BufferView * bv, InsetOld *in)
 {
        if (in == this)
                return true;
@@ -425,13 +427,13 @@ void InsetCollapsable::getCursorPos(BufferView * bv, int & x, int & y) const
 UpdatableInset * InsetCollapsable::getLockingInset() const
 {
        UpdatableInset * in = inset.getLockingInset();
-       if (const_cast<InsetText *>(&inset) == in)
+       if (&inset == in)
                return const_cast<InsetCollapsable *>(this);
        return in;
 }
 
 
-UpdatableInset * InsetCollapsable::getFirstLockingInsetOfType(Inset::Code c)
+UpdatableInset * InsetCollapsable::getFirstLockingInsetOfType(InsetOld::Code c)
 {
        if (c == lyxCode())
                return this;
@@ -501,7 +503,7 @@ LyXCursor const & InsetCollapsable::cursor(BufferView * bv) const
 }
 
 
-Inset * InsetCollapsable::getInsetFromID(int id_arg) const
+InsetOld * InsetCollapsable::getInsetFromID(int id_arg) const
 {
        if (id_arg == id())
                return const_cast<InsetCollapsable *>(this);
@@ -587,7 +589,7 @@ InsetCollapsable::selectNextWordToSpellcheck(BufferView * bv, float & value) con
 }
 
 
-void InsetCollapsable::addPreview(grfx::PreviewLoader & loader) const
+void InsetCollapsable::addPreview(PreviewLoader & loader) const
 {
        inset.addPreview(loader);
 }