* src/LyXAction.C: mark goto-clear-bookmark as working without buffer

[lyx.git] / src / insets / insetcaption.C

diff --git a/src/insets/insetcaption.C b/src/insets/insetcaption.C
index da1e7ae70add3f25b806bb5a19a87c3c69269a9b..55566f8dae364097cbb91b827ec5701f86666c74 100644 (file)
--- a/src/insets/insetcaption.C
+++ b/src/insets/insetcaption.C
@@ -96,37 +96,35 @@ void InsetCaption::setLabel(LCursor & cur) const
        if (cur.top().text() == &text_) {
                string s;
                size_t i = cur.depth();
-                       while (i > 0) {
-                               --i;
-                               InsetBase * const in = &cur[i].inset();
-                               if (in->lyxCode() == InsetBase::FLOAT_CODE
-                                   || in->lyxCode() == InsetBase::WRAP_CODE) {
-                                       s = in->getInsetName();
-                                       break;
-                               }
+               while (i > 0) {
+                       --i;
+                       InsetBase * const in = &cur[i].inset();
+                       if (in->lyxCode() == InsetBase::FLOAT_CODE ||
+                           in->lyxCode() == InsetBase::WRAP_CODE) {
+                               s = to_utf8(in->getInsetName());
+                               break;
                        }
+               }
                Floating const & fl = textclass_.floats().getType(s);
                s = fl.name();
-               string num;
+               docstring num;
                if (s.empty())
                        s = "Senseless";
                else
-                       num = convert<string>(counter_);
+                       num = convert<docstring>(counter_);
 
                // Generate the label
-               label = to_utf8(
-                       bformat(from_ascii("%1$s %2$s:"), _(s), from_ascii(num)));
+               label = bformat(from_ascii("%1$s %2$s:"), _(s), num);
        }
 }
 
 
-void InsetCaption::metrics(MetricsInfo & mi, Dimension & dim) const
+bool InsetCaption::metrics(MetricsInfo & mi, Dimension & dim) const
 {
        mi.base.textwidth -= 2 * TEXT_TO_INSET_OFFSET;
        LCursor cur = mi.base.bv->cursor();
        setLabel(cur);
-       docstring dlab(label.begin(), label.end());
-       labelwidth_ = theFontMetrics(mi.base.font).width(dlab);
+       labelwidth_ = theFontMetrics(mi.base.font).width(label);
        dim.wid = labelwidth_;
        Dimension textdim;
        InsetText::metrics(mi, textdim);
@@ -137,7 +135,9 @@ void InsetCaption::metrics(MetricsInfo & mi, Dimension & dim) const
        dim.des += TEXT_TO_INSET_OFFSET;
        dim.wid += 2 * TEXT_TO_INSET_OFFSET;
        mi.base.textwidth += 2 * TEXT_TO_INSET_OFFSET;
+       bool const changed = dim_ != dim;
        dim_ = dim;
+       return changed;
 }
 
 
@@ -153,11 +153,7 @@ void InsetCaption::draw(PainterInfo & pi, int x, int y) const
        // belongs to.
        LCursor cur = pi.base.bv->cursor();
        setLabel(cur);
-       docstring dlab(label.begin(), label.end());
-       // FXIME: instead of using the fontLoader metrics, we should make
-       // painter::text() returns the drawn text witdh.
-       labelwidth_ = theFontMetrics(pi.base.font).width(dlab);
-       pi.pain.text(x, y, dlab, pi.base.font);
+       labelwidth_ = pi.pain.text(x, y, label, pi.base.font);
        InsetText::draw(pi, x + labelwidth_, y);
        setPosCache(pi, x, y);
 }