]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetTabular.cpp
Remove unneeded swap() (thanks Jean-Marc)
[lyx.git] / src / insets / InsetTabular.cpp
index acf8acece197c34cff957a2fe75c98c3b3bba800..f7f0d2419b8ff20070f7f3bfcf2940ab0b17f144 100644 (file)
@@ -262,7 +262,7 @@ string const tostr(Tabular::BoxType const & num)
 
 
 // I would have liked a fromstr template a lot better. (Lgb)
-bool string2type(string const str, LyXAlignment & num)
+bool string2type(string const str, LyXAlignment & num)
 {
        if (str == "none")
                num = LYX_ALIGN_NONE;
@@ -282,7 +282,7 @@ bool string2type(string const str, LyXAlignment & num)
 }
 
 
-bool string2type(string const str, Tabular::HAlignment & num)
+bool string2type(string const str, Tabular::HAlignment & num)
 {
        if (str == "left")
                num = Tabular::LYX_LONGTABULAR_ALIGN_LEFT;
@@ -296,7 +296,7 @@ bool string2type(string const str, Tabular::HAlignment & num)
 }
 
 
-bool string2type(string const str, Tabular::VAlignment & num)
+bool string2type(string const str, Tabular::VAlignment & num)
 {
        if (str == "top")
                num = Tabular::LYX_VALIGN_TOP;
@@ -310,7 +310,7 @@ bool string2type(string const str, Tabular::VAlignment & num)
 }
 
 
-bool string2type(string const str, Tabular::BoxType & num)
+bool string2type(string const str, Tabular::BoxType & num)
 {
        if (str == "none")
                num = Tabular::BOX_NONE;
@@ -324,7 +324,7 @@ bool string2type(string const str, Tabular::BoxType & num)
 }
 
 
-bool string2type(string const str, bool & num)
+bool string2type(string const str, bool & num)
 {
        if (str == "true")
                num = true;
@@ -534,7 +534,7 @@ DocIterator separatorPos(InsetTableCell * cell, docstring const & align_d)
 }
 
 
-InsetTableCell splitCell(InsetTableCell & head, docstring const align_d, bool & hassep)
+InsetTableCell splitCell(InsetTableCell & head, docstring const align_d, bool & hassep)
 {
        InsetTableCell tail = InsetTableCell(head);
        DocIterator const dit = separatorPos(&head, align_d);
@@ -602,36 +602,32 @@ Tabular::CellData::CellData(CellData const & cs)
 {
 }
 
-Tabular::CellData & Tabular::CellData::operator=(CellData cs)
-{
-       swap(cs);
+Tabular::CellData & Tabular::CellData::operator=(CellData const & cs)
+{
+       if (&cs == this)
+               return *this;
+       cellno = cs.cellno;
+       width = cs.width;
+       multicolumn = cs.multicolumn;
+       multirow = cs.multirow;
+       mroffset = cs.mroffset;
+       alignment = cs.alignment;
+       valignment = cs.valignment;
+       decimal_hoffset = cs.decimal_hoffset;
+       decimal_width = cs.decimal_width;
+       voffset = cs.voffset;
+       top_line = cs.top_line;
+       bottom_line = cs.bottom_line;
+       left_line = cs.left_line;
+       right_line = cs.right_line;
+       usebox = cs.usebox;
+       rotate = cs.rotate;
+       align_special = cs.align_special;
+       p_width = cs.p_width;
+       inset.reset(static_cast<InsetTableCell *>(cs.inset->clone()));
        return *this;
 }
 
-void Tabular::CellData::swap(CellData & rhs)
-{
-       std::swap(cellno, rhs.cellno);
-       std::swap(width, rhs.width);
-       std::swap(multicolumn, rhs.multicolumn);
-       std::swap(multirow, rhs.multirow);
-       std::swap(mroffset, rhs.mroffset);
-       std::swap(alignment, rhs.alignment);
-       std::swap(valignment, rhs.valignment);
-       std::swap(decimal_hoffset, rhs.decimal_hoffset);
-       std::swap(decimal_width, rhs.decimal_width);
-       std::swap(voffset, rhs.voffset);
-       std::swap(top_line, rhs.top_line);
-       std::swap(bottom_line, rhs.bottom_line);
-       std::swap(left_line, rhs.left_line);
-       std::swap(right_line, rhs.right_line);
-       std::swap(usebox, rhs.usebox);
-       std::swap(rotate, rhs.rotate);
-       std::swap(align_special, rhs.align_special);
-       p_width.swap(rhs.p_width);
-       inset.swap(rhs.inset);
-}
-
-
 Tabular::RowData::RowData()
        : ascent(0),
          descent(0),
@@ -876,7 +872,7 @@ void Tabular::insertColumn(col_type const col, bool copy)
                setBottomLine(i, bottomLine(j));
                setTopLine(i, topLine(j));
                setLeftLine(i, leftLine(j));
-               if (rightLine(j) && rightLine(j)) {
+               if (rightLine(i) && rightLine(j)) {
                        setRightLine(i, true);
                        setRightLine(j, false);
                }
@@ -1154,7 +1150,7 @@ void Tabular::setColumnPWidth(Cursor & cur, idx_type cell,
        col_type const c = cellColumn(cell);
 
        column_info[c].p_width = width;
-       // reset the vertical alignment to top if the fixed with
+       // reset the vertical alignment to top if the fixed width
        // is removed or zero because only fixed width columns can
        // have a vertical alignment
        if (column_info[c].p_width.zero())
@@ -1164,6 +1160,8 @@ void Tabular::setColumnPWidth(Cursor & cur, idx_type cell,
                // because of multicolumns
                toggleFixedWidth(cur, cellInset(cell).get(),
                                 !getPWidth(cell).zero());
+               if (isMultiRow(cell))
+                       setAlignment(cell, LYX_ALIGN_LEFT, false);
        }
        // cur paragraph can become invalid after paragraphs were merged
        if (cur.pit() > cur.lastpit())
@@ -1443,7 +1441,7 @@ void Tabular::write(ostream & os) const
           << ">\n";
        // global longtable options
        os << "<features"
-          << write_attribute("rotate", convert<string>(rotate))
+          << write_attribute("rotate", rotate)
           << write_attribute("booktabs", use_booktabs)
           << write_attribute("islongtable", is_long_tabular)
           << write_attribute("firstHeadTopDL", endfirsthead.topDL)
@@ -1458,12 +1456,11 @@ void Tabular::write(ostream & os) const
           << write_attribute("lastFootEmpty", endlastfoot.empty);
        // longtables cannot be aligned vertically
        if (!is_long_tabular) {
-          os << write_attribute("tabularvalignment", tabular_valignment);
-          os << write_attribute("tabularwidth", tabular_width);
+               os << write_attribute("tabularvalignment", tabular_valignment);
+               os << write_attribute("tabularwidth", tabular_width);
        }
        if (is_long_tabular)
-          os << write_attribute("longtabularalignment",
-                                longtabular_alignment);
+               os << write_attribute("longtabularalignment", longtabular_alignment);
        os << ">\n";
        for (col_type c = 0; c < ncols(); ++c) {
                os << "<column"
@@ -1517,6 +1514,9 @@ void Tabular::write(ostream & os) const
                        cell_info[r][c].inset->write(os);
                        os << "\n\\end_inset\n"
                           << "</cell>\n";
+                       // FIXME This can be removed again once the mystery
+                       // crash has been resolved.
+                       os << flush;
                }
                os << "</row>\n";
        }
@@ -1715,7 +1715,8 @@ bool Tabular::hasMultiRow(row_type r) const
 }
 
 Tabular::idx_type Tabular::setMultiRow(idx_type cell, idx_type number,
-                                      bool const bottom_border)
+                                      bool const bottom_border,
+                                      LyXAlignment const halign)
 {
        idx_type const col = cellColumn(cell);
        idx_type const row = cellRow(cell);
@@ -1731,10 +1732,10 @@ Tabular::idx_type Tabular::setMultiRow(idx_type cell, idx_type number,
        // be changed for the whole table row,
        // support changing this only for the multirow cell can be done via
        // \multirowsetup
-       // this feature would be a fileformat change
-       // until LyX supports this, use the deault alignment of multirow
-       // cells: left
-       cs.alignment = LYX_ALIGN_LEFT;
+       if (getPWidth(cell).zero())
+               cs.alignment = halign;
+       else
+               cs.alignment = LYX_ALIGN_LEFT;
 
        // set the bottom line of the last selected cell
        setBottomLine(cell, bottom_border);
@@ -2139,7 +2140,7 @@ bool Tabular::isPartOfMultiRow(row_type row, col_type column) const
 }
 
 
-void Tabular::TeXTopHLine(otexstream & os, row_type row, string const lang) const
+void Tabular::TeXTopHLine(otexstream & os, row_type row, string const lang) const
 {
        // we only output complete row lines and the 1st row here, the rest
        // is done in Tabular::TeXBottomHLine(...)
@@ -2201,7 +2202,7 @@ void Tabular::TeXTopHLine(otexstream & os, row_type row, string const lang) cons
 }
 
 
-void Tabular::TeXBottomHLine(otexstream & os, row_type row, string const lang) const
+void Tabular::TeXBottomHLine(otexstream & os, row_type row, string const lang) const
 {
        // we output bottomlines of row r and the toplines of row r+1
        // if the latter do not span the whole tabular
@@ -5704,7 +5705,8 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                        // check whether we are completely in a multirow
                        if (!tabular.isMultiRow(cur.idx()))
                                tabular.setMultiRow(cur.idx(), 1,
-                                                   tabular.bottomLine(cur.idx()));
+                                                   tabular.bottomLine(cur.idx()),
+                                                   tabular.getAlignment(cur.idx()));
                        break;
                }
                // we have a selection so this means we just add all this
@@ -5713,7 +5715,8 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                row_type const row_start = tabular.cellRow(s_start);
                row_type const row_end = tabular.cellRow(cur.selEnd().idx());
                cur.idx() = tabular.setMultiRow(s_start, row_end - row_start + 1,
-                                               tabular.bottomLine(cur.selEnd().idx()));
+                                               tabular.bottomLine(cur.selEnd().idx()),
+                                               tabular.getAlignment(cur.selEnd().idx()));
                cur.pit() = 0;
                cur.pos() = 0;
                cur.setSelection(false);