]> git.lyx.org Git - features.git/blobdiff - src/insets/InsetTabular.cpp
move more stuff from buffer_func to Buffer
[features.git] / src / insets / InsetTabular.cpp
index 61a9a68a737ec5806297185a4bdc3864e7dc484b..e9e2c31033efaa5c81c21966cc7ce4fef80edb2a 100644 (file)
@@ -3,14 +3,14 @@
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
- * \author Lars Gullik Bjønnes
+ * \author Lars Gullik Bjønnes
  * \author Matthias Ettrich
- * \author José Matos
+ * \author José Matos
  * \author Jean-Marc Lasgouttes
  * \author Angus Leeming
  * \author John Levon
- * \author André Pönitz
- * \author Jürgen Vigna
+ * \author André Pönitz
+ * \author Jürgen Vigna
  *
  * Full author contact details are available in file CREDITS.
  */
@@ -691,10 +691,14 @@ void Tabular::appendColumn(idx_type const cell)
        for (row_type r = 0; r < nrows; ++r) {
                cell_info[r].insert(cell_info[r].begin() + c + 1, 
                        CellData(buffer()));
+#if 0
+// FIXME: This code does not work. It deletes the cell's content and
+// it triggers an assertion if the cursor is at pos > 0.
                if (cell_info[r][c].multicolumn == CELL_BEGIN_OF_MULTICOLUMN)
                        cell_info[r][c + 1].multicolumn = CELL_PART_OF_MULTICOLUMN;
                else
                        cell_info[r][c + 1].multicolumn = cell_info[r][c].multicolumn;
+#endif
        }
        updateIndexes();
        for (row_type r = 0; r < nrows; ++r) {
@@ -775,6 +779,7 @@ void Tabular::updateIndexes()
                        rowofcell[i] = row;
                        columnofcell[i] = column;
                        setFixedWidth(row, column);
+                       updateContentAlignment(row, column);
                        ++i;
                }
 }
@@ -945,6 +950,7 @@ void Tabular::setAlignment(idx_type cell, LyXAlignment align,
                column_info[cellColumn(cell)].alignment = align;
        if (!onlycolumn)
                cellInfo(cell).alignment = align;
+       cellInset(cell).get()->setContentAlignment(align);
 }
 
 
@@ -1011,9 +1017,9 @@ void Tabular::setColumnPWidth(Cursor & cur, idx_type cell,
 
 bool Tabular::setFixedWidth(row_type r, col_type c)
 {
-       if (!column_info[c].p_width.zero() ||
-                               (cell_info[r][c].multicolumn != CELL_NORMAL && 
-                               !cell_info[r][c].p_width.zero())) {
+       bool const multicol = cell_info[r][c].multicolumn != CELL_NORMAL;
+       if ((!column_info[c].p_width.zero() && !multicol)
+           || (multicol && !cell_info[r][c].p_width.zero())) {
                cell_info[r][c].inset->toggleFixedWidth(true);
                return true;
        }
@@ -1021,6 +1027,13 @@ bool Tabular::setFixedWidth(row_type r, col_type c)
 }
 
 
+void Tabular::updateContentAlignment(row_type r, col_type c)
+{
+       cell_info[r][c].inset->setContentAlignment(
+               getAlignment(cellIndex(r, c)));
+}
+
+
 bool Tabular::setMColumnPWidth(Cursor & cur, idx_type cell,
                Length const & width)
 {
@@ -1797,74 +1810,106 @@ bool Tabular::isPartOfMultiColumn(row_type row, col_type column) const
 }
 
 
-int Tabular::TeXTopHLine(odocstream & os, row_type row) const
+int Tabular::TeXTopHLine(odocstream & os, row_type row, string const lang) const
 {
-       // FIXME: assert or return 0 as in TeXBottomHLine()?
-       LASSERT(row != npos, /**/);
-       LASSERT(row < row_info.size(), /**/);
+       // we only output complete row lines and the 1st row here, the rest
+       // is done in Tabular::TeXBottomHLine(...)
 
-       idx_type const fcell = getFirstCellInRow(row);
-       idx_type const n = numberOfCellsInRow(fcell) + fcell;
-       idx_type tmp = 0;
-
-       for (idx_type i = fcell; i < n; ++i) {
-               if (topLine(i))
-                       ++tmp;
+       // get for each column the topline (if any)
+       col_type const ncols = column_info.size();
+       vector<bool> topline;
+       col_type nset = 0;
+       for (col_type c = 0; c < ncols; ++c) {
+               topline.push_back(topLine(cellIndex(row, c)));
+               if (topline[c])
+                       ++nset;
        }
-       if (use_booktabs && row == 0) {
-               if (topLine(fcell))
-                       os << "\\toprule ";
-       } else if (tmp == n - fcell) {
-               os << (use_booktabs ? "\\midrule " : "\\hline ");
-       } else if (tmp) {
-               for (idx_type i = fcell; i < n; ++i) {
-                       if (topLine(i)) {
-                               os << (use_booktabs ? "\\cmidrule{" : "\\cline{")
-                                  << cellColumn(i) + 1
-                                  << '-'
-                                  << cellRightColumn(i) + 1
-                                  << "} ";
+
+       // do nothing if empty first row, or incomplete row line after
+       if ((row == 0 && nset == 0) || (row > 0 && nset != ncols))
+               return 0;
+
+       // only output complete row lines and the 1st row's clines
+       if (nset == ncols) {
+               if (use_booktabs) {
+                       os << (row == 0 ? "\\toprule " : "\\midrule ");
+               } else {
+                       os << "\\hline ";
+               }
+       } else if (row == 0) {
+               for (col_type c = 0; c < ncols; ++c) {
+                       if (topline[c]) {
+                               //babel makes the "-" character an active one, so we have to suppress this here
+                               //see http://groups.google.com/group/comp.text.tex/browse_thread/thread/af769424a4a0f289#
+                               if (lang == "slovak" || lang == "czech")
+                                       os << (use_booktabs ? "\\expandafter\\cmidrule\\expandafter{\\expandafter" :
+                                                             "\\expandafter\\cline\\expandafter{\\expandafter")
+                                                                                 << c + 1 << "\\string-";
+                               else
+                                       os << (use_booktabs ? "\\cmidrule{" : "\\cline{") << c + 1 << '-';
+                               // get to last column of line span
+                               while (c < ncols && topline[c])
+                                       ++c;
+                               os << c << "} ";
                        }
                }
-       } else {
-               return 0;
        }
        os << "\n";
        return 1;
 }
 
 
-int Tabular::TeXBottomHLine(odocstream & os, row_type row) const
+int Tabular::TeXBottomHLine(odocstream & os, row_type row, string const lang) const
 {
-       // FIXME: return 0 or assert as in TeXTopHLine()?
-       if (row == npos || row >= row_info.size())
-               return 0;
+       // we output bottomlines of row r and the toplines of row r+1
+       // if the latter do not span the whole tabular
 
-       idx_type const fcell = getFirstCellInRow(row);
-       idx_type const n = numberOfCellsInRow(fcell) + fcell;
-       idx_type tmp = 0;
+       // get the bottomlines of row r, and toplines in next row
+       bool lastrow = row == row_info.size() - 1;
+       col_type const ncols = column_info.size();
+       vector<bool> bottomline, topline;
+       bool nextrowset = true;
+       for (col_type c = 0; c < ncols; ++c) {
+               bottomline.push_back(bottomLine(cellIndex(row, c)));
+               topline.push_back(!lastrow && topLine(cellIndex(row + 1, c)));
+               nextrowset &= topline[c];
+       }
 
-       for (idx_type i = fcell; i < n; ++i) {
-               if (bottomLine(i))
-                       ++tmp;
+       // combine this row's bottom lines and next row's toplines if necessary
+       col_type nset = 0;
+       for (col_type c = 0; c < ncols; ++c) {
+               if (!nextrowset)
+                       bottomline[c] = bottomline[c] || topline[c];
+               if (bottomline[c])
+                       ++nset;
        }
-       if (use_booktabs && row == row_info.size() - 1) {
-               if (bottomLine(fcell))
-                       os << "\\bottomrule";
-       } else if (tmp == n - fcell) {
-               os << (use_booktabs ? "\\midrule" : "\\hline");
-       } else if (tmp) {
-               for (idx_type i = fcell; i < n; ++i) {
-                       if (bottomLine(i)) {
-                               os << (use_booktabs ? "\\cmidrule{" : "\\cline{")
-                                  << cellColumn(i) + 1
-                                  << '-'
-                                  << cellRightColumn(i) + 1
-                                  << "} ";
+
+       // do nothing if empty, OR incomplete row line with a topline in next row
+       if (nset == 0 || (nextrowset && nset != ncols))
+               return 0;
+
+       if (nset == ncols) {
+               if (use_booktabs)
+                       os << (lastrow ? "\\bottomrule" : "\\midrule");
+               else
+                       os << "\\hline";
+       } else {
+               for (col_type c = 0; c < ncols; ++c) {
+                       if (bottomline[c]) {
+                               //babel makes the "-" character an active one, so we have to suppress this here
+                               //see http://groups.google.com/group/comp.text.tex/browse_thread/thread/af769424a4a0f289#
+                               if (lang == "slovak" || lang == "czech")
+                                       os << (use_booktabs ? "\\expandafter\\cmidrule\\expandafter{\\expandafter" :
+                                                             "\\expandafter\\cline\\expandafter{\\expandafter")
+                                                                                 << c + 1 << "\\string-";
+                               else
+                                       os << (use_booktabs ? "\\cmidrule{" : "\\cline{") << c + 1 << '-';
+                               // get to last column of line span
+                               while (c < ncols && bottomline[c])
+                                       ++c;
+                               os << c << "} ";
                        }
                }
-       } else {
-               return 0;
        }
        os << "\n";
        return 1;
@@ -1904,6 +1949,19 @@ int Tabular::TeXCellPreamble(odocstream & os, idx_type cell, bool & ismulticol)
                        os << cellInfo(cell).align_special;
                } else {
                        if (!getPWidth(cell).zero()) {
+                               switch (align) {
+                               case LYX_ALIGN_LEFT:
+                                       os << ">{\\raggedright}";
+                                       break;
+                               case LYX_ALIGN_RIGHT:
+                                       os << ">{\\raggedleft}";
+                                       break;
+                               case LYX_ALIGN_CENTER:
+                                       os << ">{\\centering}";
+                                       break;
+                               default:
+                                       break;
+                               }
                                switch (valign) {
                                case LYX_VALIGN_TOP:
                                        os << 'p';
@@ -2108,7 +2166,13 @@ int Tabular::TeXRow(odocstream & os, row_type i,
                       OutputParams const & runparams) const
 {
        idx_type cell = cellIndex(i, 0);
-       int ret = TeXTopHLine(os, i);
+       shared_ptr<InsetTableCell> inset = cellInset(cell);
+       Paragraph const & par = inset->paragraphs().front();
+       string const lang = par.getParLanguage(buffer().params())->lang();
+
+       //output the top line
+       int ret = TeXTopHLine(os, i, lang);
+
        if (row_info[i].top_space_default) {
                if (use_booktabs)
                        os << "\\addlinespace\n";
@@ -2140,16 +2204,26 @@ int Tabular::TeXRow(odocstream & os, row_type i,
                        && getPWidth(cell).zero();
 
                if (rtl) {
-                       if (par.getParLanguage(buffer().params())->lang() ==
-                       "farsi")
+                       string const lang =
+                               par.getParLanguage(buffer().params())->lang();
+                       if (lang == "farsi")
                                os << "\\textFR{";
-                       else if (par.getParLanguage(buffer().params())->lang() == "arabic_arabi")
+                       else if (lang == "arabic_arabi")
                                os << "\\textAR{";
-                       // currently, remaning RTL languages are arabic_arabtex and hebrew
+                       // currently, remaning RTL languages are
+                       // arabic_arabtex and hebrew
                        else
                                os << "\\R{";
                }
-               ret += inset->latex(os, runparams);
+               // pass to the OutputParams that we are in a cell and
+               // which alignment we have set.
+               // InsetNewline needs this context information.
+               OutputParams newrp(runparams);
+               newrp.inTableCell = (getAlignment(cell) == LYX_ALIGN_BLOCK)
+                                   ? OutputParams::PLAIN
+                                   : OutputParams::ALIGNED;
+               ret += inset->latex(os, newrp);
+               runparams.encoding = newrp.encoding;
                if (rtl)
                        os << '}';
 
@@ -2174,7 +2248,10 @@ int Tabular::TeXRow(odocstream & os, row_type i,
        }
        os << '\n';
        ++ret;
-       ret += TeXBottomHLine(os, i);
+
+       //output the bottom line
+       ret += TeXBottomHLine(os, i, lang);
+
        if (row_info[i].interline_space_default) {
                if (use_booktabs)
                        os << "\\addlinespace\n";
@@ -2680,8 +2757,8 @@ void Tabular::validate(LaTeXFeatures & features) const
        if (needRotating())
                features.require("rotating");
        for (idx_type cell = 0; cell < numberofcells; ++cell) {
-               if (getVAlignment(cell) != LYX_VALIGN_TOP ||
-                    (!getPWidth(cell).zero() && !isMultiColumn(cell)))
+               if (getVAlignment(cell) != LYX_VALIGN_TOP
+                   || !getPWidth(cell).zero())
                        features.require("array");
                cellInset(cell)->validate(features);
        }
@@ -2710,7 +2787,8 @@ Tabular::BoxType Tabular::useParbox(idx_type cell) const
 /////////////////////////////////////////////////////////////////////
 
 InsetTableCell::InsetTableCell(Buffer & buf)
-       : InsetText(buf), isFixedWidth(false)
+       : InsetText(buf), isFixedWidth(false),
+         contentAlign(LYX_ALIGN_CENTER)
 {}
 
 
@@ -2719,11 +2797,13 @@ bool InsetTableCell::forcePlainLayout(idx_type) const
        return !isFixedWidth;
 }
 
+
 bool InsetTableCell::allowParagraphCustomization(idx_type) const
 {
        return isFixedWidth;
 }
 
+
 bool InsetTableCell::getStatus(Cursor & cur, FuncRequest const & cmd,
        FuncStatus & status) const
 {
@@ -2916,11 +2996,37 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
        dim.wid = tabular.width() + 2 * ADD_TO_TABULAR_WIDTH;
 }
 
+bool InsetTabular::isCellSelected(Cursor & cur, row_type row, col_type col) 
+       const
+{
+       if (&cur.inset() == this && cur.selection()) {
+               if (cur.selIsMultiCell()) {
+                       row_type rs, re;
+                       col_type cs, ce;
+                       getSelection(cur, rs, re, cs, ce);
+                       
+                       if (col >= cs && col <= ce && row >= rs && row <= re)
+                               return true;
+               } else 
+                       if (col == tabular.cellColumn(cur.idx()) 
+                               && row == tabular.cellRow(cur.idx())) {
+                       CursorSlice const & beg = cur.selBegin();
+                       CursorSlice const & end = cur.selEnd();
+
+                       if (end.lastpos() > 0 && end.pos() == end.lastpos() 
+                                 && beg.pos() == 0)
+                               return true;
+               }
+       }
+       return false;
+}
+
 
 void InsetTabular::draw(PainterInfo & pi, int x, int y) const
 {
        //lyxerr << "InsetTabular::draw: " << x << " " << y << endl;
        BufferView * bv = pi.base.bv;
+       Cursor & cur = pi.base.bv->cursor();
 
        // FIXME: As the full backrgound is painted in drawSelection(),
        // we have no choice but to do a full repaint for the Text cells.
@@ -2932,6 +3038,7 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
        x += ADD_TO_TABULAR_WIDTH;
 
        bool const original_drawing_state = pi.pain.isDrawingEnabled();
+       bool const original_selection_state = pi.selected;
 
        idx_type idx = 0;
        first_visible_cell = Tabular::npos;
@@ -2946,6 +3053,7 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
                        if (first_visible_cell == Tabular::npos)
                                first_visible_cell = idx;
 
+                       pi.selected |= isCellSelected(cur, i, j);
                        int const cx = nx + tabular.getBeginningOfTextInCell(idx);
                        // Cache the Inset position.
                        bv->coordCache().insets().add(cell(idx).get(), cx, y);
@@ -2963,6 +3071,7 @@ void InsetTabular::draw(PainterInfo & pi, int x, int y) const
                        }
                        nx += tabular.columnWidth(idx);
                        ++idx;
+                       pi.selected = original_selection_state;
                }
 
                if (i + 1 < tabular.row_info.size())
@@ -2985,7 +3094,7 @@ void InsetTabular::drawSelection(PainterInfo & pi, int x, int y) const
        int const w = tabular.width();
        int const h = tabular.height();
        int yy = y - tabular.rowAscent(0);
-       pi.pain.fillRectangle(x, yy, w, h, backgroundColor());
+       pi.pain.fillRectangle(x, yy, w, h, pi.backgroundColor(this));
 
        if (!cur.selection())
                return;
@@ -2996,9 +3105,6 @@ void InsetTabular::drawSelection(PainterInfo & pi, int x, int y) const
 
 
        if (cur.selIsMultiCell()) {
-               row_type rs, re;
-               col_type cs, ce;
-               getSelection(cur, rs, re, cs, ce);
                y -= tabular.rowAscent(0);
                for (row_type j = 0; j < tabular.row_info.size(); ++j) {
                        int const a = tabular.rowAscent(j);
@@ -3011,7 +3117,7 @@ void InsetTabular::drawSelection(PainterInfo & pi, int x, int y) const
                                idx_type const cell =
                                        tabular.cellIndex(j, i);
                                int const w = tabular.columnWidth(cell);
-                               if (i >= cs && i <= ce && j >= rs && j <= re)
+                               if (isCellSelected(cur, j, i))
                                        pi.pain.fillRectangle(xx, y, w, h,
                                                              Color_selection);
                                xx += w;
@@ -3079,7 +3185,7 @@ void InsetTabular::edit(Cursor & cur, bool front, EntryDirection)
 {
        //lyxerr << "InsetTabular::edit: " << this << endl;
        cur.finishUndo();
-       cur.selection() = false;
+       cur.setSelection(false);
        cur.push(*this);
        if (front) {
                if (isRightToLeft(cur))
@@ -3105,7 +3211,7 @@ void InsetTabular::edit(Cursor & cur, bool front, EntryDirection)
 void InsetTabular::updateLabels(ParIterator const & it)
 {
        // In a longtable, tell captions what the current float is
-       Counters & cnts = buffer().params().documentClass().counters();
+       Counters & cnts = buffer().masterBuffer()->params().documentClass().counters();
        string const saveflt = cnts.current_float();
        if (tabular.is_long_tabular)
                cnts.current_float("table");
@@ -3114,7 +3220,7 @@ void InsetTabular::updateLabels(ParIterator const & it)
        it2.forwardPos();
        size_t const end = it2.nargs();
        for ( ; it2.idx() < end; it2.top().forwardIdx())
-               lyx::updateLabels(buffer(), it2);
+               buffer().updateLabels(it2);
 
        //reset afterwards
        if (tabular.is_long_tabular)
@@ -3142,7 +3248,7 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cur.resetAnchor();
                        cur.idx() = tabular.getLastCellInRow(r);
                        cur.pos() = cur.lastpos();
-                       cur.selection() = true;
+                       cur.setSelection(true);
                        bvcur = cur; 
                        rowselect_ = true;
                        break;
@@ -3157,7 +3263,7 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cur.resetAnchor();
                        cur.idx() = tabular.cellIndex(tabular.row_info.size() - 1, c);
                        cur.pos() = cur.lastpos();
-                       cur.selection() = true;
+                       cur.setSelection(true);
                        bvcur = cur; 
                        colselect_ = true;
                        break;
@@ -3190,7 +3296,7 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                                cur.pit() = 0;
                                cur.pos() = 0;
                                bvcur.setCursor(cur);
-                               bvcur.selection() = true;
+                               bvcur.setSelection(true);
                                break;
                        }
                        // select (additional) column
@@ -3202,7 +3308,7 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                                cur.pit() = 0;
                                cur.pos() = 0;
                                bvcur.setCursor(cur);
-                               bvcur.selection() = true;
+                               bvcur.setSelection(true);
                                break;
                        }
                        // only update if selection changes
@@ -3211,12 +3317,12 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                                cur.noUpdate();
                        setCursorFromCoordinates(cur, cmd.x, cmd.y);
                        bvcur.setCursor(cur);
-                       bvcur.selection() = true;
+                       bvcur.setSelection(true);
                        // if this is a multicell selection, we just set the cursor to
                        // the beginning of the cell's text.
                        if (bvcur.selIsMultiCell()) {
-                               bvcur.pit() = 0;
-                               bvcur.pos() = 0;
+                               bvcur.pit() = bvcur.lastpit();
+                               bvcur.pos() = bvcur.lastpos();
                        }
                }
                break;
@@ -3228,12 +3334,12 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_CELL_BACKWARD:
                movePrevCell(cur);
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
 
        case LFUN_CELL_FORWARD:
                moveNextCell(cur);
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
 
        case LFUN_CHAR_FORWARD_SELECT:
@@ -3329,6 +3435,11 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cmd = FuncRequest(LFUN_FINISHED_FORWARD);
                        cur.undispatched();
                }
+               if (cur.selIsMultiCell()) {
+                       cur.pit() = cur.lastpit();
+                       cur.pos() = cur.lastpos();
+                       return;
+               }
                break;
 
        case LFUN_UP_SELECT:
@@ -3352,6 +3463,11 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cmd = FuncRequest(LFUN_UP);
                        cur.undispatched();
                }
+               if (cur.selIsMultiCell()) {
+                       cur.pit() = cur.lastpit();
+                       cur.pos() = cur.lastpos();
+                       return;
+               }
                break;
 
 //     case LFUN_SCREEN_DOWN: {
@@ -3433,6 +3549,14 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                        cell(cur.idx())->dispatch(cur, cmd);
                break;
 
+       case LFUN_SELF_INSERT:
+               if (cur.selIsMultiCell()) {
+                       cur.recordUndoInset(DELETE_UNDO);
+                       cutSelection(cur);
+               }
+               cell(cur.idx())->dispatch(cur, cmd);
+               break;
+
        case LFUN_CHAR_DELETE_BACKWARD:
        case LFUN_CHAR_DELETE_FORWARD:
                if (cur.selIsMultiCell()) {
@@ -3492,6 +3616,7 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_FONT_EMPH:
        case LFUN_FONT_BOLD:
+       case LFUN_FONT_BOLDSYMBOL:
        case LFUN_FONT_ROMAN:
        case LFUN_FONT_NOUN:
        case LFUN_FONT_ITAL:
@@ -3951,7 +4076,7 @@ int InsetTabular::dist(BufferView & bv, idx_type const cell, int x, int y) const
 Inset * InsetTabular::editXY(Cursor & cur, int x, int y)
 {
        //lyxerr << "InsetTabular::editXY: " << this << endl;
-       cur.selection() = false;
+       cur.setSelection(false);
        cur.push(*this);
        cur.idx() = getNearestCell(cur.bv(), x, y);
        resetPos(cur);
@@ -4002,14 +4127,16 @@ void InsetTabular::resetPos(Cursor & cur) const
        BufferView & bv = cur.bv();
        int const maxwidth = bv.workWidth();
 
-       if (&cur.inset() != this) {
+       int const scx_old = scx_;
+       int const i = cur.find(this);
+       if (i == -1) {
                scx_ = 0;
        } else {
                int const X1 = 0;
                int const X2 = maxwidth;
                int const offset = ADD_TO_TABULAR_WIDTH + 2;
-               int const x1 = xo(cur.bv()) + cellXPos(cur.idx()) + offset;
-               int const x2 = x1 + tabular.columnWidth(cur.idx());
+               int const x1 = xo(cur.bv()) + cellXPos(cur[i].idx()) + offset;
+               int const x2 = x1 + tabular.columnWidth(cur[i].idx());
 
                if (x1 < X1)
                        scx_ = X1 + 20 - x1;
@@ -4019,7 +4146,9 @@ void InsetTabular::resetPos(Cursor & cur) const
                        scx_ = 0;
        }
 
-       cur.updateFlags(Update::Force | Update::FitCursor);
+       // only update if offset changed
+       if (scx_ != scx_old)
+               cur.updateFlags(Update::Force | Update::FitCursor);
 }
 
 
@@ -4041,9 +4170,18 @@ void InsetTabular::moveNextCell(Cursor & cur, EntryDirection entry_from)
                        return;
                ++cur.idx();
        }
+
+       cur.boundary(false);
+
+       if (cur.selIsMultiCell()) {
+               cur.pit() = cur.lastpit();
+               cur.pos() = cur.lastpos();
+               resetPos(cur);
+               return;
+       }
+
        cur.pit() = 0;
        cur.pos() = 0;
-       cur.boundary(false);
 
        // in visual mode, place cursor at extreme left or right
        
@@ -4084,6 +4222,14 @@ void InsetTabular::movePrevCell(Cursor & cur, EntryDirection entry_from)
                        return;
                --cur.idx();
        }
+
+       if (cur.selIsMultiCell()) {
+               cur.pit() = cur.lastpit();
+               cur.pos() = cur.lastpos();
+               resetPos(cur);
+               return;
+       }
+
        cur.pit() = cur.lastpit();
        cur.pos() = cur.lastpos();
 
@@ -4103,8 +4249,7 @@ void InsetTabular::movePrevCell(Cursor & cur, EntryDirection entry_from)
 
        }
 
-       // FIXME: this accesses the position cache before it is initialized
-       //resetPos(cur);
+       resetPos(cur);
 }
 
 
@@ -4264,7 +4409,7 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                cur.idx() = tabular.cellIndex(sel_row_start, column);
                cur.pit() = 0;
                cur.pos() = 0;
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
 
        case Tabular::DELETE_COLUMN:
@@ -4275,7 +4420,7 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                cur.idx() = tabular.cellIndex(row, sel_col_start);
                cur.pit() = 0;
                cur.pos() = 0;
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
 
        case Tabular::COPY_ROW:
@@ -4362,7 +4507,7 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                cur.idx() = s_start;
                cur.pit() = 0;
                cur.pos() = 0;
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
        }
 
@@ -4481,7 +4626,7 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                cur.idx() = tabular.setLTCaption(row, !tabular.ltCaption(row));
                cur.pit() = 0;
                cur.pos() = 0;
-               cur.selection() = false;
+               cur.setSelection(false);
                break;
 
        case Tabular::SET_BOOKTABS: