]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetTabular.cpp
Fix GRAPHICS_EDIT of InsetGraphics
[lyx.git] / src / insets / InsetTabular.cpp
index 0af0aa6cfa92269c7c02f3b04b59857621756618..aeb3e7eb4c371be8785c5dec033969c791114e07 100644 (file)
@@ -3,7 +3,6 @@
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
- * \author Jürgen Vigna
  * \author Lars Gullik Bjønnes
  * \author Matthias Ettrich
  * \author José Matos
@@ -35,6 +34,7 @@
 #include "LaTeXFeatures.h"
 #include "Lexer.h"
 #include "LyXFunc.h"
+#include "LyXRC.h"
 #include "MetricsInfo.h"
 #include "OutputParams.h"
 #include "paragraph_funcs.h"
@@ -85,10 +85,10 @@ namespace Alert = frontend::Alert;
 
 namespace {
 
-int const ADD_TO_HEIGHT = 2;
-int const ADD_TO_TABULAR_WIDTH = 2;
-int const default_line_space = 10;
-int const WIDTH_OF_LINE = 5;
+int const ADD_TO_HEIGHT = 2; // in cell
+int const ADD_TO_TABULAR_WIDTH = 6; // horiz space before and after the table
+int const default_line_space = 10; // ?
+int const WIDTH_OF_LINE = 5; // space between double lines
 
 
 ///
@@ -120,10 +120,6 @@ TabularFeature tabularFeature[] =
        { Tabular::VALIGN_TOP, "valign-top" },
        { Tabular::VALIGN_BOTTOM, "valign-bottom" },
        { Tabular::VALIGN_MIDDLE, "valign-middle" },
-       { Tabular::M_TOGGLE_LINE_TOP, "m-toggle-line-top" },
-       { Tabular::M_TOGGLE_LINE_BOTTOM, "m-toggle-line-bottom" },
-       { Tabular::M_TOGGLE_LINE_LEFT, "m-toggle-line-left" },
-       { Tabular::M_TOGGLE_LINE_RIGHT, "m-toggle-line-right" },
        { Tabular::M_ALIGN_LEFT, "m-align-left" },
        { Tabular::M_ALIGN_RIGHT, "m-align-right" },
        { Tabular::M_ALIGN_CENTER, "m-align-center" },
@@ -160,6 +156,7 @@ TabularFeature tabularFeature[] =
        { Tabular::SET_TOP_SPACE, "set-top-space" },
        { Tabular::SET_BOTTOM_SPACE, "set-bottom-space" },
        { Tabular::SET_INTERLINE_SPACE, "set-interline-space" },
+       { Tabular::SET_BORDER_LINES, "set-border-lines" },
        { Tabular::LAST_ACTION, "" }
 };
 
@@ -345,7 +342,7 @@ bool getTokenValue(string const & str, char const * token, string & ret)
 {
        ret.erase();
        size_t token_length = strlen(token);
-       string::size_type pos = str.find(token);
+       size_t pos = str.find(token);
 
        if (pos == string::npos || pos + token_length + 1 >= str.length()
                || str[pos + token_length] != '=')
@@ -472,22 +469,22 @@ string const featureAsString(Tabular::Feature feature)
 /////////////////////////////////////////////////////////////////////
 
 
-Tabular::CellData::CellData(Buffer const & buffer)
+Tabular::CellData::CellData(Buffer const & buf, Tabular const & table)
        : cellno(0),
          width(0),
          multicolumn(Tabular::CELL_NORMAL),
          alignment(LYX_ALIGN_CENTER),
          valignment(LYX_VALIGN_TOP),
-         top_line(true),
+         top_line(false),
          bottom_line(false),
-         left_line(true),
+         left_line(false),
          right_line(false),
          usebox(BOX_NONE),
          rotate(false),
-         inset(new InsetText(buffer.params()))
+         inset(new InsetTableCell(buf, this, &table))
 {
-       inset->setBuffer(const_cast<Buffer &>(buffer));
-       inset->paragraphs().back().setLayout(buffer.params().textClass().emptyLayout());
+       inset->setBuffer(const_cast<Buffer &>(buf));
+       inset->paragraphs().back().setLayout(buf.params().documentClass().emptyLayout());
 }
 
 
@@ -505,8 +502,10 @@ Tabular::CellData::CellData(CellData const & cs)
          rotate(cs.rotate),
          align_special(cs.align_special),
          p_width(cs.p_width),
-         inset(dynamic_cast<InsetText*>(cs.inset->clone()))
-{}
+         inset(dynamic_cast<InsetTableCell *>(cs.inset->clone()))
+{
+       inset->setCellData(this);
+}
 
 
 Tabular::CellData & Tabular::CellData::operator=(CellData cs)
@@ -538,8 +537,6 @@ void Tabular::CellData::swap(CellData & rhs)
 Tabular::RowData::RowData()
        : ascent(0),
          descent(0),
-         top_line(true),
-         bottom_line(false),
          top_space_default(false),
          bottom_space_default(false),
          interline_space_default(false),
@@ -554,8 +551,6 @@ Tabular::RowData::RowData()
 Tabular::ColumnData::ColumnData()
        : alignment(LYX_ALIGN_CENTER),
          valignment(LYX_VALIGN_TOP),
-         left_line(true),
-         right_line(false),
          width(0)
 {
 }
@@ -587,34 +582,31 @@ void Tabular::init(Buffer const & buf, row_type rows_arg,
        buffer_ = &buf;
        row_info = row_vector(rows_arg);
        column_info = column_vector(columns_arg);
-       cell_info = cell_vvector(rows_arg, cell_vector(columns_arg, CellData(buf)));
+       cell_info = cell_vvector(rows_arg, cell_vector(columns_arg, CellData(buf, *this)));
        row_info.reserve(10);
        column_info.reserve(10);
        cell_info.reserve(100);
        fixCellNums();
-       for (row_type i = 0; i < rows_arg; ++i)
-               cell_info[i].back().right_line = true;
-       row_info.back().bottom_line = true;
-       row_info.front().bottom_line = true;
-       column_info.back().right_line = true;
        is_long_tabular = false;
        rotate = false;
        use_booktabs = false;
+       // set silly default lines
+       for (row_type i = 0; i < rowCount(); ++i)
+               for (col_type j = 0; j < columnCount(); ++j) {
+                       cell_info[i][j].top_line = true;
+                       cell_info[i][j].left_line = true;
+                       cell_info[i][j].bottom_line = i == 0 || i == rowCount() - 1;
+                       cell_info[i][j].right_line = j == columnCount() - 1;
+               }
 }
 
 
 void Tabular::fixCellNums()
 {
        idx_type cellno = 0;
-       for (row_type i = 0; i < rowCount(); ++i) {
-               for (col_type j = 0; j < columnCount(); ++j) {
-                       // When debugging it can be nice to set
-                       // this to true.
-                       cell_info[i][j].inset->setDrawFrame(false);
+       for (row_type i = 0; i < rowCount(); ++i)
+               for (col_type j = 0; j < columnCount(); ++j)
                        cell_info[i][j].cellno = cellno++;
-               }
-               cell_info[i].back().right_line = true;
-       }
 
        updateIndexes();
 }
@@ -637,7 +629,7 @@ void Tabular::appendRow(idx_type const cell)
        for (row_type i = 0; i < nrows - 1; ++i)
                swap(cell_info[i], old[i]);
 
-       cell_info = cell_vvector(nrows, cell_vector(ncols, CellData(buffer())));
+       cell_info = cell_vvector(nrows, cell_vector(ncols, CellData(buffer(), *this)));
 
        for (row_type i = 0; i <= row; ++i)
                swap(cell_info[i], old[i]);
@@ -680,28 +672,25 @@ void Tabular::copyRow(row_type const row)
 void Tabular::appendColumn(idx_type const cell)
 {
        col_type const column = cellColumn(cell);
-       col_type const ncols = columnCount();
        column_vector::iterator cit = column_info.begin() + column + 1;
        column_info.insert(cit, ColumnData());
+       col_type const ncols = columnCount();
        // set the column values of the column before
        column_info[column + 1] = column_info[column];
 
-       BufferParams const & bp = buffer().params();
        for (row_type i = 0; i < rowCount(); ++i) {
-               cell_info[i].insert(cell_info[i].begin() + column + 1, CellData(buffer()));
-
-               // care about multicolumns
-               if (cell_info[i][column + 1].multicolumn == CELL_BEGIN_OF_MULTICOLUMN)
-                       cell_info[i][column + 1].multicolumn = CELL_PART_OF_MULTICOLUMN;
-
-               if (column + 2 >= ncols
-                   || cell_info[i][column + 2].multicolumn != CELL_PART_OF_MULTICOLUMN)
-                       cell_info[i][column + 1].multicolumn = Tabular::CELL_NORMAL;
+               cell_info[i].insert(cell_info[i].begin() + column + 1, CellData(buffer(), *this));
+               col_type c = column + 2;
+               while (c < ncols 
+                       && cell_info[i][c].multicolumn == CELL_PART_OF_MULTICOLUMN) {
+                       cell_info[i][c].multicolumn = CELL_NORMAL;
+                       ++c;
+               }
        }
        //++column;
        for (row_type i = 0; i < rowCount(); ++i) {
                cell_info[i][column + 1].inset->clear();
-               if (bp.trackChanges)
+               if (buffer().params().trackChanges)
                        cell_info[i][column + 1].inset->setChange(Change(Change::INSERTED));
        }
        fixCellNums();
@@ -751,7 +740,7 @@ void Tabular::updateIndexes()
        for (row_type row = 0; row < rowCount(); ++row) {
                for (col_type column = 0; column < columnCount(); ++column) {
                        if (cell_info[row][column].multicolumn
-                               != Tabular::CELL_PART_OF_MULTICOLUMN)
+                               != CELL_PART_OF_MULTICOLUMN)
                                ++numberofcells;
                        BOOST_ASSERT(numberofcells != 0);
                        cell_info[row][column].cellno =
@@ -772,8 +761,8 @@ void Tabular::updateIndexes()
                do {
                        ++column;
                } while (column < columnCount() &&
-                                cell_info[row][column].multicolumn
-                                == Tabular::CELL_PART_OF_MULTICOLUMN);
+                               cell_info[row][column].multicolumn
+                                               == Tabular::CELL_PART_OF_MULTICOLUMN);
 
                if (column == columnCount()) {
                        column = 0;
@@ -809,78 +798,51 @@ Tabular::idx_type Tabular::numberOfCellsInRow(idx_type const cell) const
 }
 
 
-bool Tabular::topLine(idx_type const cell, bool const wholerow) const
+bool Tabular::topLine(idx_type const cell) const
 {
-       if (!wholerow && isMultiColumn(cell) &&
-           !(use_booktabs && cellRow(cell) == 0))
-               return cellinfo_of_cell(cell).top_line;
-       return row_info[cellRow(cell)].top_line;
+       return cellinfo_of_cell(cell).top_line;
 }
 
 
-bool Tabular::bottomLine(idx_type const cell, bool wholerow) const
+bool Tabular::bottomLine(idx_type const cell) const
 {
-       if (!wholerow && isMultiColumn(cell) &&
-           !(use_booktabs && isLastRow(cell)))
-               return cellinfo_of_cell(cell).bottom_line;
-       return row_info[cellRow(cell)].bottom_line;
+       return cellinfo_of_cell(cell).bottom_line;
 }
 
 
-bool Tabular::leftLine(idx_type cell, bool wholecolumn) const
+bool Tabular::leftLine(idx_type cell) const
 {
        if (use_booktabs)
                return false;
-       if (!wholecolumn && isMultiColumn(cell) &&
-               (isFirstCellInRow(cell) || isMultiColumn(cell-1)))
-               return cellinfo_of_cell(cell).left_line;
-       return column_info[cellColumn(cell)].left_line;
+       return cellinfo_of_cell(cell).left_line;
 }
 
 
-bool Tabular::rightLine(idx_type cell, bool wholecolumn) const
+bool Tabular::rightLine(idx_type cell) const
 {
        if (use_booktabs)
                return false;
-       if (!wholecolumn && isMultiColumn(cell) &&
-               (isLastCellInRow(cell) || isMultiColumn(cell + 1)))
-               return cellinfo_of_cell(cell).right_line;
-       return column_info[cellRightColumn(cell)].right_line;
+       return cellinfo_of_cell(cell).right_line;
 }
 
 
 bool Tabular::topAlreadyDrawn(idx_type cell) const
 {
        row_type row = cellRow(cell);
-       if (row > 0 && !getAdditionalHeight(row)) {
-               col_type column = cellColumn(cell);
-               --row;
-               while (column
-                          && cell_info[row][column].multicolumn
-                          == Tabular::CELL_PART_OF_MULTICOLUMN)
-                       --column;
-               if (cell_info[row][column].multicolumn == Tabular::CELL_NORMAL)
-                       return row_info[row].bottom_line;
-               else
-                       return cell_info[row][column].bottom_line;
-       }
-       return false;
+       if (row == 0)
+               return false;
+       idx_type i = cellIndex(row - 1, cellColumn(cell));
+       return !rowBottomLine(row - 1) && bottomLine(i);
 }
 
 
 bool Tabular::leftAlreadyDrawn(idx_type cell) const
 {
-       col_type column = cellColumn(cell);
-       if (column > 0) {
-               row_type row = cellRow(cell);
-               while (--column &&
-                          (cell_info[row][column].multicolumn ==
-                               Tabular::CELL_PART_OF_MULTICOLUMN)) { }
-               if (getAdditionalWidth(cell_info[row][column].cellno))
-                       return false;
-               return rightLine(cell_info[row][column].cellno);
-       }
-       return false;
+       col_type col = cellColumn(cell);
+       if (col == 0)
+               return false;
+       idx_type i = cellIndex(cellRow(cell), col - 1);
+       return !columnRightLine(col - 1) && rightLine(i);
 }
 
 
@@ -895,31 +857,10 @@ int Tabular::getAdditionalHeight(row_type row) const
        if (!row || row >= rowCount())
                return 0;
 
-       bool top = true;
-       bool bottom = true;
-
-       for (col_type column = 0; column < columnCount() && bottom; ++column) {
-               switch (cell_info[row - 1][column].multicolumn) {
-               case Tabular::CELL_BEGIN_OF_MULTICOLUMN:
-                       bottom = cell_info[row - 1][column].bottom_line;
-                       break;
-               case Tabular::CELL_NORMAL:
-                       bottom = row_info[row - 1].bottom_line;
-               }
-       }
-       for (col_type column = 0; column < columnCount() && top; ++column) {
-               switch (cell_info[row][column].multicolumn) {
-               case Tabular::CELL_BEGIN_OF_MULTICOLUMN:
-                       top = cell_info[row][column].top_line;
-                       break;
-               case Tabular::CELL_NORMAL:
-                       top = row_info[row].top_line;
-               }
-       }
        int const interline_space = row_info[row - 1].interline_space_default ?
                default_line_space :
                row_info[row - 1].interline_space.inPixels(width());
-       if (top && bottom)
+       if (rowTopLine(row) && rowBottomLine(row - 1))
                return interline_space + WIDTH_OF_LINE;
        return interline_space;
 }
@@ -929,13 +870,11 @@ int Tabular::getAdditionalWidth(idx_type cell) const
 {
        // internally already set in setCellWidth
        // used to get it back in text.cpp
-       col_type const col = cellRightColumn(cell);
-       row_type const row = cellRow(cell);
-       if (col < columnCount() - 1 && rightLine(cell) &&
-               leftLine(cell_info[row][col+1].cellno)) // column_info[col+1].left_line)
-       {
+       col_type c = cellColumn(cell);
+       if (c < columnCount() - 1 
+               && columnRightLine(c) && columnLeftLine(c + 1)
+               && cellinfo_of_cell(cell).multicolumn == CELL_NORMAL)
                return WIDTH_OF_LINE;
-       }
        return 0;
 }
 
@@ -1024,15 +963,13 @@ void Tabular::recalculateMulticolumnsOfColumn(col_type column)
 void Tabular::setCellWidth(idx_type cell, int new_width)
 {
        row_type const row = cellRow(cell);
-       col_type const column1 = cellColumn(cell);
+       col_type const col = cellColumn(cell);
        bool tmp = false;
        int width = 0;
        int add_width = 0;
 
-       if (rightLine(cell_info[row][column1].cellno, true) &&
-               column1 < columnCount() - 1 &&
-               leftLine(cell_info[row][column1+1].cellno, true))
-       {
+       if (col < columnCount() - 1 && columnRightLine(col) &&
+               columnLeftLine(col + 1)) {
                add_width = WIDTH_OF_LINE;
        }
 
@@ -1043,10 +980,10 @@ void Tabular::setCellWidth(idx_type cell, int new_width)
                tmp = setWidthOfMulticolCell(cell, new_width);
        } else {
                width = new_width + 2 * WIDTH_OF_LINE + add_width;
-               cell_info[row][column1].width = width;
-               tmp = calculate_width_of_column_NMC(column1);
+               cell_info[row][col].width = width;
+               tmp = calculate_width_of_column_NMC(col);
                if (tmp)
-                       recalculateMulticolumnsOfColumn(column1);
+                       recalculateMulticolumnsOfColumn(col);
        }
        if (tmp) {
                for (col_type i = 0; i < columnCount(); ++i)
@@ -1082,7 +1019,7 @@ namespace {
  * merge cell paragraphs and reset layout to standard for variable width
  * cells.
  */
-void toggleFixedWidth(Cursor & cur, InsetText * inset, bool fixedWidth)
+void toggleFixedWidth(Cursor & cur, InsetTableCell * inset, bool fixedWidth)
 {
        inset->setAutoBreakRows(fixedWidth);
        if (fixedWidth)
@@ -1097,7 +1034,7 @@ void toggleFixedWidth(Cursor & cur, InsetText * inset, bool fixedWidth)
        cur.push(*inset);
        // undo information has already been recorded
        inset->getText(0)->setLayout(cur.bv().buffer(), 0, cur.lastpit() + 1,
-                       bp.textClass().emptyLayoutName());
+                       bp.documentClass().emptyLayoutName());
        cur.pop();
 }
 
@@ -1162,40 +1099,74 @@ void Tabular::setAllLines(idx_type cell, bool line)
 }
 
 
-void Tabular::setTopLine(idx_type cell, bool line, bool wholerow)
+void Tabular::setTopLine(idx_type i, bool line)
 {
-       row_type const row = cellRow(cell);
-       if (wholerow || !isMultiColumn(cell))
-               row_info[row].top_line = line;
-       else
-               cellinfo_of_cell(cell).top_line = line;
+       cellinfo_of_cell(i).top_line = line;
 }
 
 
-void Tabular::setBottomLine(idx_type cell, bool line, bool wholerow)
+void Tabular::setBottomLine(idx_type i, bool line)
 {
-       if (wholerow || !isMultiColumn(cell))
-               row_info[cellRow(cell)].bottom_line = line;
-       else
-               cellinfo_of_cell(cell).bottom_line = line;
+       cellinfo_of_cell(i).bottom_line = line;
 }
 
 
-void Tabular::setLeftLine(idx_type cell, bool line, bool wholecolumn)
+void Tabular::setLeftLine(idx_type cell, bool line)
 {
-       if (wholecolumn || !isMultiColumn(cell))
-               column_info[cellColumn(cell)].left_line = line;
-       else
-               cellinfo_of_cell(cell).left_line = line;
+       cellinfo_of_cell(cell).left_line = line;
 }
 
 
-void Tabular::setRightLine(idx_type cell, bool line, bool wholecolumn)
+void Tabular::setRightLine(idx_type cell, bool line)
 {
-       if (wholecolumn || !isMultiColumn(cell))
-               column_info[cellRightColumn(cell)].right_line = line;
-       else
-               cellinfo_of_cell(cell).right_line = line;
+       cellinfo_of_cell(cell).right_line = line;
+}
+
+bool Tabular::rowTopLine(row_type r) const
+{
+       idx_type i0 = getFirstCellInRow(r);
+       idx_type i1 = getLastCellInRow(r);
+       bool all_rows_set = true;
+       for (idx_type j = i0; all_rows_set && j <= i1; ++j)
+               all_rows_set = cellinfo_of_cell(j).top_line;
+       return all_rows_set;
+}
+
+
+bool Tabular::rowBottomLine(row_type r) const
+{
+       idx_type i0 = getFirstCellInRow(r);
+       idx_type i1 = getLastCellInRow(r);
+       bool all_rows_set = true;
+       for (idx_type j = i0; all_rows_set && j <= i1; ++j)
+               all_rows_set = cellinfo_of_cell(j).bottom_line;
+       return all_rows_set;
+}
+
+
+bool Tabular::columnLeftLine(col_type c) const
+{
+       bool all_cols_set = true;
+       row_type nrows = rowCount();
+       for (row_type r = 0; all_cols_set && r < nrows; ++r) {
+               idx_type i = cellIndex(r, c);
+               if (columnSpan(i) == 1)
+                       all_cols_set = cellinfo_of_cell(i).left_line;
+       }
+       return all_cols_set;
+}
+
+
+bool Tabular::columnRightLine(col_type c) const
+{
+       bool all_cols_set = true;
+       row_type nrows = rowCount();
+       for (row_type r = 0; all_cols_set && r < nrows; ++r) {
+               idx_type i = cellIndex(r, c);
+               if (c == cellColumn(i) + columnSpan(i) - 1)
+                       all_cols_set = cellinfo_of_cell(i).right_line;
+       }
+       return all_cols_set;
 }
 
 
@@ -1367,7 +1338,7 @@ Tabular::col_type Tabular::cellRightColumn(idx_type cell) const
        row_type const row = cellRow(cell);
        col_type column = cellColumn(cell);
        while (column < columnCount() - 1 &&
-                  cell_info[row][column + 1].multicolumn == Tabular::CELL_PART_OF_MULTICOLUMN)
+                  cell_info[row][column + 1].multicolumn == CELL_PART_OF_MULTICOLUMN)
                ++column;
        return column;
 }
@@ -1401,17 +1372,13 @@ void Tabular::write(ostream & os) const
                os << "<column"
                   << write_attribute("alignment", column_info[j].alignment)
                   << write_attribute("valignment", column_info[j].valignment)
-                  << write_attribute("leftline", column_info[j].left_line)
-                  << write_attribute("rightline", column_info[j].right_line)
                   << write_attribute("width", column_info[j].p_width.asString())
                   << write_attribute("special", column_info[j].align_special)
                   << ">\n";
        }
        for (row_type i = 0; i < rowCount(); ++i) {
-               os << "<row"
-                  << write_attribute("topline", row_info[i].top_line)
-                  << write_attribute("bottomline", row_info[i].bottom_line);
                static const string def("default");
+               os << "<row";
                if (row_info[i].top_space_default)
                        os << write_attribute("topspace", def);
                else
@@ -1507,8 +1474,6 @@ void Tabular::read(Lexer & lex)
                }
                getTokenValue(line, "alignment", column_info[j].alignment);
                getTokenValue(line, "valignment", column_info[j].valignment);
-               getTokenValue(line, "leftline", column_info[j].left_line);
-               getTokenValue(line, "rightline", column_info[j].right_line);
                getTokenValue(line, "width", column_info[j].p_width);
                getTokenValue(line, "special", column_info[j].align_special);
        }
@@ -1520,8 +1485,6 @@ void Tabular::read(Lexer & lex)
                               << line << ')' << endl;
                        return;
                }
-               getTokenValue(line, "topline", row_info[i].top_line);
-               getTokenValue(line, "bottomline", row_info[i].bottom_line);
                getTokenValue(line, "topspace", row_info[i].top_space,
                              row_info[i].top_space_default);
                getTokenValue(line, "bottomspace", row_info[i].bottom_space,
@@ -1578,14 +1541,14 @@ void Tabular::read(Lexer & lex)
 
 bool Tabular::isMultiColumn(idx_type cell) const
 {
-       return cellinfo_of_cell(cell).multicolumn != Tabular::CELL_NORMAL;
+       return cellinfo_of_cell(cell).multicolumn != CELL_NORMAL;
 }
 
 
 bool Tabular::isMultiColumnReal(idx_type cell) const
 {
        return cellColumn(cell) != cellRightColumn(cell) &&
-                       cellinfo_of_cell(cell).multicolumn != Tabular::CELL_NORMAL;
+                       cellinfo_of_cell(cell).multicolumn != CELL_NORMAL;
 }
 
 
@@ -1600,21 +1563,18 @@ void Tabular::setMultiColumn(idx_type cell, idx_type number)
        CellData & cs = cellinfo_of_cell(cell);
        cs.multicolumn = CELL_BEGIN_OF_MULTICOLUMN;
        cs.alignment = column_info[cellColumn(cell)].alignment;
-       cs.top_line = row_info[cellRow(cell)].top_line;
-       cs.bottom_line = row_info[cellRow(cell)].bottom_line;
-       cs.left_line = column_info[cellColumn(cell)].left_line;
-       cs.right_line = column_info[cellColumn(cell+number-1)].right_line;
        for (idx_type i = 1; i < number; ++i) {
                CellData & cs1 = cellinfo_of_cell(cell + i);
                cs1.multicolumn = CELL_PART_OF_MULTICOLUMN;
                cs.inset->appendParagraphs(cs1.inset->paragraphs());
                cs1.inset->clear();
        }
+       setRightLine(cell, rightLine(cell + number - 1));
        updateIndexes();
 }
 
 
-Tabular::idx_type Tabular::cells_in_multicolumn(idx_type cell) const
+Tabular::idx_type Tabular::columnSpan(idx_type cell) const
 {
        row_type const row = cellRow(cell);
        col_type column = cellColumn(cell);
@@ -1737,26 +1697,6 @@ Tabular::idx_type Tabular::getCellBelow(idx_type cell) const
 }
 
 
-Tabular::idx_type Tabular::getLastCellAbove(idx_type cell) const
-{
-       if (cellRow(cell) == 0)
-               return cell;
-       if (!isMultiColumn(cell))
-               return getCellAbove(cell);
-       return cell_info[cellRow(cell) - 1][cellRightColumn(cell)].cellno;
-}
-
-
-Tabular::idx_type Tabular::getLastCellBelow(idx_type cell) const
-{
-       if (cellRow(cell) + 1 >= rowCount())
-               return cell;
-       if (!isMultiColumn(cell))
-               return getCellBelow(cell);
-       return cell_info[cellRow(cell) + 1][cellRightColumn(cell)].cellno;
-}
-
-
 Tabular::idx_type Tabular::cellIndex(row_type row,
                                               col_type column) const
 {
@@ -2033,18 +1973,20 @@ int Tabular::TeXCellPreamble(odocstream & os, idx_type cell) const
                os << "\\begin{sideways}\n";
                ++ret;
        }
-       if (isMultiColumn(cell)) {
-               os << "\\multicolumn{" << cells_in_multicolumn(cell) << "}{";
-               if (leftLine(cell) &&
-                       (isFirstCellInRow(cell) ||
-                        (!isMultiColumn(cell - 1) && !leftLine(cell, true) &&
-                         !rightLine(cell - 1, true))))
+       Tabular::VAlignment valign =  getVAlignment(cell, !isMultiColumn(cell));
+       LyXAlignment align = getAlignment(cell, !isMultiColumn(cell));
+       col_type c = cellColumn(cell);
+       if (isMultiColumn(cell)
+               || (leftLine(cell) && !columnLeftLine(c))
+               || (rightLine(cell) && !columnRightLine(c))) {
+               os << "\\multicolumn{" << columnSpan(cell) << "}{";
+               if (leftLine(cell))
                        os << '|';
                if (!cellinfo_of_cell(cell).align_special.empty()) {
                        os << cellinfo_of_cell(cell).align_special;
                } else {
                        if (!getPWidth(cell).zero()) {
-                               switch (getVAlignment(cell)) {
+                               switch (valign) {
                                case LYX_VALIGN_TOP:
                                        os << 'p';
                                        break;
@@ -2059,7 +2001,7 @@ int Tabular::TeXCellPreamble(odocstream & os, idx_type cell) const
                                   << from_ascii(getPWidth(cell).asLatexString())
                                   << '}';
                        } else {
-                               switch (getAlignment(cell)) {
+                               switch (align) {
                                case LYX_ALIGN_LEFT:
                                        os << 'l';
                                        break;
@@ -2074,14 +2016,11 @@ int Tabular::TeXCellPreamble(odocstream & os, idx_type cell) const
                } // end if else !cellinfo_of_cell
                if (rightLine(cell))
                        os << '|';
-               if (((cell + 1) < cellCount()) && !isFirstCellInRow(cell+1) &&
-                       leftLine(cell+1))
-                       os << '|';
                os << "}{";
                }
        if (getUsebox(cell) == BOX_PARBOX) {
                os << "\\parbox[";
-               switch (getVAlignment(cell)) {
+               switch (valign) {
                case LYX_VALIGN_TOP:
                        os << 't';
                        break;
@@ -2096,7 +2035,7 @@ int Tabular::TeXCellPreamble(odocstream & os, idx_type cell) const
                   << "}{";
        } else if (getUsebox(cell) == BOX_MINIPAGE) {
                os << "\\begin{minipage}[";
-               switch (getVAlignment(cell)) {
+               switch (valign) {
                case LYX_VALIGN_TOP:
                        os << 't';
                        break;
@@ -2126,7 +2065,10 @@ int Tabular::TeXCellPostamble(odocstream & os, idx_type cell) const
                os << "%\n\\end{minipage}";
                ret += 2;
        }
-       if (isMultiColumn(cell)) {
+       col_type c = cellColumn(cell);
+       if (isMultiColumn(cell)
+               || (leftLine(cell) && !columnLeftLine(c))
+               || (rightLine(cell) && !columnRightLine(c))) {
                os << '}';
        }
        if (getRotateCell(cell)) {
@@ -2265,7 +2207,7 @@ int Tabular::TeXRow(odocstream & os, row_type i,
                if (isPartOfMultiColumn(i, j))
                        continue;
                ret += TeXCellPreamble(os, cell);
-               shared_ptr<InsetText> inset = getCellInset(cell);
+               shared_ptr<InsetTableCell> inset = getCellInset(cell);
 
                Paragraph const & par = inset->paragraphs().front();
                bool rtl = par.isRTL(buffer().params())
@@ -2345,8 +2287,9 @@ int Tabular::latex(odocstream & os, OutputParams const & runparams) const
                os << "\\begin{longtable}{";
        else
                os << "\\begin{tabular}{";
+
        for (col_type i = 0; i < columnCount(); ++i) {
-               if (!use_booktabs && column_info[i].left_line)
+               if (!use_booktabs && columnLeftLine(i))
                        os << '|';
                if (!column_info[i].align_special.empty()) {
                        os << column_info[i].align_special;
@@ -2397,7 +2340,7 @@ int Tabular::latex(odocstream & os, OutputParams const & runparams) const
                                }
                        } // end if else !column_info[i].p_width
                } // end if else !column_info[i].align_special
-               if (!use_booktabs && column_info[i].right_line)
+               if (!use_booktabs && columnRightLine(i))
                        os << '|';
        }
        os << "}\n";
@@ -2475,7 +2418,7 @@ int Tabular::docbookRow(odocstream & os, row_type row,
 
                if (isMultiColumn(cell)) {
                        os << " namest=\"col" << j << "\" ";
-                       os << "nameend=\"col" << j + cells_in_multicolumn(cell) - 1<< '"';
+                       os << "nameend=\"col" << j + columnSpan(cell) - 1<< '"';
                }
 
                os << '>';
@@ -2749,7 +2692,7 @@ void Tabular::plaintext(odocstream & os,
                                odocstringstream sstr;
                                getCellInset(cell)->plaintext(sstr, runparams);
                                int len = int(sstr.str().length());
-                               idx_type const n = cells_in_multicolumn(cell);
+                               idx_type const n = columnSpan(cell);
                                for (col_type k = j; len > 0 && k < j + n - 1; ++k)
                                        len -= clen[k];
                                if (len > int(clen[j + n - 1]))
@@ -2781,13 +2724,13 @@ void Tabular::plaintext(odocstream & os,
 }
 
 
-shared_ptr<InsetText> Tabular::getCellInset(idx_type cell) const
+shared_ptr<InsetTableCell> Tabular::getCellInset(idx_type cell) const
 {
        return cell_info[cellRow(cell)][cellColumn(cell)].inset;
 }
 
 
-shared_ptr<InsetText> Tabular::getCellInset(row_type row,
+shared_ptr<InsetTableCell> Tabular::getCellInset(row_type row,
                                               col_type column) const
 {
        return cell_info[row][column].inset;
@@ -2795,9 +2738,13 @@ shared_ptr<InsetText> Tabular::getCellInset(row_type row,
 
 
 void Tabular::setCellInset(row_type row, col_type column,
-                             shared_ptr<InsetText> ins) const
+                             shared_ptr<InsetTableCell> ins) const
 {
-       cell_info[row][column].inset = ins;
+       CellData & cd = cell_info[row][column];
+       cd.inset = ins;
+       // reset the InsetTableCell's pointers
+       ins->setCellData(&cd);
+       ins->setTabular(this);
 }
 
 
@@ -2859,6 +2806,50 @@ Tabular::BoxType Tabular::useParbox(idx_type cell) const
 }
 
 
+/////////////////////////////////////////////////////////////////////
+//
+// InsetTableCell
+//
+/////////////////////////////////////////////////////////////////////
+
+InsetTableCell::InsetTableCell(Buffer const & buf,
+       Tabular::CellData const * cell, Tabular const * table)
+       : InsetText(buf), cell_data_(cell), table_(table)
+{}
+
+
+bool InsetTableCell::forceEmptyLayout(idx_type) const
+{
+       BOOST_ASSERT(table_);
+       BOOST_ASSERT(cell_data_);
+       return table_->getPWidth(cell_data_->cellno).zero();
+}
+
+bool InsetTableCell::allowParagraphCustomization(idx_type) const
+{
+       BOOST_ASSERT(table_);
+       BOOST_ASSERT(cell_data_);
+       return !table_->getPWidth(cell_data_->cellno).zero();
+}
+
+bool InsetTableCell::getStatus(Cursor & cur, FuncRequest const & cmd,
+       FuncStatus & status) const
+{
+       bool enabled;
+       switch (cmd.action) {
+       case LFUN_LAYOUT:
+               enabled = !forceEmptyLayout();
+               break;
+       case LFUN_LAYOUT_PARAGRAPH:
+               enabled = allowParagraphCustomization();
+               break;
+       default:
+               return InsetText::getStatus(cur, cmd, status);
+       }
+       status.enabled(enabled);
+       return true;
+}
+
 /////////////////////////////////////////////////////////////////////
 //
 // InsetTabular
@@ -2886,12 +2877,6 @@ InsetTabular::~InsetTabular()
 }
 
 
-Inset * InsetTabular::clone() const
-{
-       return new InsetTabular(*this);
-}
-
-
 bool InsetTabular::insetAllowed(InsetCode code) const
 {
        if (code == MATHMACRO_CODE)
@@ -2930,6 +2915,34 @@ void InsetTabular::read(Lexer & lex)
 }
 
 
+int InsetTabular::rowFromY(Cursor & cur, int y) const
+{
+       // top y coordinate of tabular
+       int h = yo(cur.bv()) - tabular.rowAscent(0);
+       size_t nrows = tabular.rowCount();
+       row_type r = 0;
+       for (;r < nrows && y > h; ++r) {
+               h += tabular.rowAscent(r);
+               h += tabular.rowDescent(r);
+               h += tabular.getAdditionalHeight(r);
+       }
+       return r - 1;
+}
+
+
+int InsetTabular::columnFromX(Cursor & cur, int x) const
+{
+       // left x coordinate of tabular
+       int w = xo(cur.bv()) + ADD_TO_TABULAR_WIDTH;
+       size_t ncols = tabular.columnCount();
+       col_type c = 0;
+       for (;c < ncols && x > w; ++c) {
+               w += tabular.columnWidth(c);
+       }
+       return c - 1;
+}
+
+
 void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
 {
        //lyxerr << "InsetTabular::metrics: " << mi.base.bv << " width: " <<
@@ -2951,7 +2964,7 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
                        MetricsInfo m = mi;
                        Length p_width;
                        if (tabular.cell_info[i][j].multicolumn ==
-                           Tabular::CELL_BEGIN_OF_MULTICOLUMN)
+                               Tabular::CELL_BEGIN_OF_MULTICOLUMN)
                                p_width = tabular.cellinfo_of_cell(cell).p_width;
                        else
                                p_width = tabular.column_info[j].p_width;
@@ -3175,7 +3188,7 @@ void InsetTabular::edit(Cursor & cur, bool front, EntryDirection)
 void InsetTabular::updateLabels(ParIterator const & it)
 {
        // In a longtable, tell captions what the current float is
-       Counters & cnts = buffer().params().textClass().counters();
+       Counters & cnts = buffer().params().documentClass().counters();
        string const saveflt = cnts.current_float();
        if (tabular.isLongTabular())
                cnts.current_float("table");
@@ -3201,9 +3214,36 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        switch (cmd.action) {
 
-       case LFUN_MOUSE_PRESS:
+       case LFUN_MOUSE_PRESS: {
                //lyxerr << "# InsetTabular::MousePress\n" << cur.bv().cursor() << endl;
 
+               // select row
+               if (cmd.x < xo(cur.bv()) + ADD_TO_TABULAR_WIDTH
+                       || cmd.x > xo(cur.bv()) + tabular.width()) {
+                       row_type r = rowFromY(cur, cmd.y);
+                       cur.idx() = tabular.getFirstCellInRow(r);
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.idx() = tabular.getLastCellInRow(r);
+                       cur.pos() = cur.lastpos();
+                       cur.selection() = true;
+                       bvcur = cur; 
+                       break;
+               }
+               // select column
+               int const y0 = yo(cur.bv()) - tabular.rowAscent(0);
+               if (cmd.y < y0 + ADD_TO_TABULAR_WIDTH 
+                       || cmd.y > y0 + tabular.height()) {
+                       col_type c = columnFromX(cur, cmd.x);
+                       cur.idx() = tabular.cellIndex(0, c);
+                       cur.pos() = 0;
+                       cur.resetAnchor();
+                       cur.idx() = tabular.cellIndex(tabular.rowCount() - 1, c);
+                       cur.pos() = cur.lastpos();
+                       cur.selection() = true;
+                       bvcur = cur; 
+                       break;
+               }
                // do not reset cursor/selection if we have selected
                // some cells (bug 2715).
                if (cmd.button() == mouse_button::button3
@@ -3211,23 +3251,44 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                    && tablemode(bvcur)) 
                        ;
                else
-                       // Let InsetText do it
+                       // Let InsetTableCell do it
                        cell(cur.idx())->dispatch(cur, cmd);
                break;
+       }
        case LFUN_MOUSE_MOTION:
                //lyxerr << "# InsetTabular::MouseMotion\n" << bvcur << endl;
                if (cmd.button() == mouse_button::button1) {
                        // only accept motions to places not deeper nested than the real anchor
-                       if (bvcur.anchor_.hasPart(cur)) {
-                               // only update if selection changes
-                               if (bvcur.idx() == cur.idx() &&
-                                       !(bvcur.anchor_.idx() == cur.idx() && bvcur.pos() != cur.pos()))
-                                       cur.noUpdate();
-                               setCursorFromCoordinates(cur, cmd.x, cmd.y);
+                       if (!bvcur.anchor_.hasPart(cur)) {
+                               cur.undispatched();
+                               break;
+                       }
+                       // select (additional) row
+                       if (cmd.x < xo(cur.bv()) + ADD_TO_TABULAR_WIDTH
+                               || cmd.x > xo(cur.bv()) + tabular.width()) {
+                               row_type r = rowFromY(cur, cmd.y);
+                               cur.idx() = tabular.getLastCellInRow(r);
                                bvcur.setCursor(cur);
                                bvcur.selection() = true;
-                       } else
-                               cur.undispatched();
+                               break;
+                       }
+                       // select (additional) column
+                       int const y0 = yo(cur.bv()) - tabular.rowAscent(0);
+                       if (cmd.y < y0 + ADD_TO_TABULAR_WIDTH 
+                               || cmd.y > y0 + tabular.height()) {
+                               col_type c = columnFromX(cur, cmd.x);
+                               cur.idx() = tabular.cellIndex(tabular.rowCount() - 1, c);
+                               bvcur.setCursor(cur);
+                               bvcur.selection() = true;
+                               break;
+                       }
+                       // only update if selection changes
+                       if (bvcur.idx() == cur.idx() &&
+                               !(bvcur.anchor_.idx() == cur.idx() && bvcur.pos() != cur.pos()))
+                               cur.noUpdate();
+                       setCursorFromCoordinates(cur, cmd.x, cmd.y);
+                       bvcur.setCursor(cur);
+                       bvcur.selection() = true;
                }
                break;
 
@@ -3246,7 +3307,6 @@ void InsetTabular::doDispatch(Cursor & cur, FuncRequest & cmd)
                moveNextCell(cur);
                cur.selection() = false;
                break;
-
        case LFUN_CHAR_FORWARD_SELECT:
        case LFUN_CHAR_FORWARD:
                cell(cur.idx())->dispatch(cur, cmd);
@@ -3577,6 +3637,7 @@ bool InsetTabular::getStatus(Cursor & cur, FuncRequest const & cmd,
                case Tabular::SET_TOP_SPACE:
                case Tabular::SET_BOTTOM_SPACE:
                case Tabular::SET_INTERLINE_SPACE:
+               case Tabular::SET_BORDER_LINES:
                        status.clear();
                        return true;
 
@@ -3584,28 +3645,20 @@ bool InsetTabular::getStatus(Cursor & cur, FuncRequest const & cmd,
                        status.setOnOff(tabular.isMultiColumn(cur.idx()));
                        break;
 
-               case Tabular::M_TOGGLE_LINE_TOP:
-                       flag = false;
                case Tabular::TOGGLE_LINE_TOP:
-                       status.setOnOff(tabular.topLine(cur.idx(), flag));
+                       status.setOnOff(tabular.topLine(cur.idx()));
                        break;
 
-               case Tabular::M_TOGGLE_LINE_BOTTOM:
-                       flag = false;
                case Tabular::TOGGLE_LINE_BOTTOM:
-                       status.setOnOff(tabular.bottomLine(cur.idx(), flag));
+                       status.setOnOff(tabular.bottomLine(cur.idx()));
                        break;
 
-               case Tabular::M_TOGGLE_LINE_LEFT:
-                       flag = false;
                case Tabular::TOGGLE_LINE_LEFT:
-                       status.setOnOff(tabular.leftLine(cur.idx(), flag));
+                       status.setOnOff(tabular.leftLine(cur.idx()));
                        break;
 
-               case Tabular::M_TOGGLE_LINE_RIGHT:
-                       flag = false;
                case Tabular::TOGGLE_LINE_RIGHT:
-                       status.setOnOff(tabular.rightLine(cur.idx(), flag));
+                       status.setOnOff(tabular.rightLine(cur.idx()));
                        break;
 
                case Tabular::M_ALIGN_LEFT:
@@ -3847,13 +3900,13 @@ void InsetTabular::validate(LaTeXFeatures & features) const
 }
 
 
-shared_ptr<InsetText const> InsetTabular::cell(idx_type idx) const
+shared_ptr<InsetTableCell const> InsetTabular::cell(idx_type idx) const
 {
        return tabular.getCellInset(idx);
 }
 
 
-shared_ptr<InsetText> InsetTabular::cell(idx_type idx)
+shared_ptr<InsetTableCell> InsetTabular::cell(idx_type idx)
 {
        return tabular.getCellInset(idx);
 }
@@ -4226,51 +4279,35 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                cur.idx() = tabular.cellIndex(row, column);
                break;
 
-       case Tabular::M_TOGGLE_LINE_TOP:
-               flag = false;
        case Tabular::TOGGLE_LINE_TOP: {
-               bool lineSet = !tabular.topLine(cur.idx(), flag);
+               bool lineSet = !tabular.topLine(cur.idx());
                for (row_type i = sel_row_start; i <= sel_row_end; ++i)
                        for (col_type j = sel_col_start; j <= sel_col_end; ++j)
-                               tabular.setTopLine(
-                                       tabular.cellIndex(i, j),
-                                       lineSet, flag);
+                               tabular.setTopLine(tabular.cellIndex(i, j), lineSet);
                break;
        }
 
-       case Tabular::M_TOGGLE_LINE_BOTTOM:
-               flag = false;
        case Tabular::TOGGLE_LINE_BOTTOM: {
-               bool lineSet = !tabular.bottomLine(cur.idx(), flag);
+               bool lineSet = !tabular.bottomLine(cur.idx());
                for (row_type i = sel_row_start; i <= sel_row_end; ++i)
                        for (col_type j = sel_col_start; j <= sel_col_end; ++j)
-                               tabular.setBottomLine(
-                                       tabular.cellIndex(i, j),
-                                       lineSet,
-                                       flag);
+                               tabular.setBottomLine(tabular.cellIndex(i, j), lineSet);
                break;
        }
 
-       case Tabular::M_TOGGLE_LINE_LEFT:
-               flag = false;
        case Tabular::TOGGLE_LINE_LEFT: {
-               bool lineSet = !tabular.leftLine(cur.idx(), flag);
+               bool lineSet = !tabular.leftLine(cur.idx());
                for (row_type i = sel_row_start; i <= sel_row_end; ++i)
                        for (col_type j = sel_col_start; j <= sel_col_end; ++j)
-                               tabular.setLeftLine(
-                                       tabular.cellIndex(i,j),
-                                       lineSet,
-                                       flag);
+                               tabular.setLeftLine(tabular.cellIndex(i, j), lineSet);
                break;
        }
 
-       case Tabular::M_TOGGLE_LINE_RIGHT:
-               flag = false;
        case Tabular::TOGGLE_LINE_RIGHT: {
-               bool lineSet = !tabular.rightLine(cur.idx(), flag);
+               bool lineSet = !tabular.rightLine(cur.idx());
                for (row_type i = sel_row_start; i <= sel_row_end; ++i)
                        for (col_type j = sel_col_start; j <= sel_col_end; ++j)
-                               tabular.setRightLine(tabular.cellIndex(i,j), lineSet, flag);
+                               tabular.setRightLine(tabular.cellIndex(i, j), lineSet);
                break;
        }
 
@@ -4337,6 +4374,17 @@ void InsetTabular::tabularFeatures(Cursor & cur,
                                        tabular.cellIndex(i,j), setLines);
                break;
 
+       case Tabular::SET_BORDER_LINES:
+               for (row_type i = sel_row_start; i <= sel_row_end; ++i) {
+                       tabular.setLeftLine(tabular.cellIndex(i, sel_col_start), true);
+                       tabular.setRightLine(tabular.cellIndex(i, sel_col_end), true);
+               }
+               for (col_type j = sel_col_start; j <= sel_col_end; ++j) {
+                       tabular.setTopLine(tabular.cellIndex(sel_row_start, j), true);
+                       tabular.setBottomLine(tabular.cellIndex(sel_row_end, j), true);
+               }
+               break;
+
        case Tabular::SET_LONGTABULAR:
                tabular.setLongTabular(true);
                break;
@@ -4528,10 +4576,6 @@ bool InsetTabular::copySelection(Cursor & cur)
        while (paste_tabular->rowCount() > rows)
                paste_tabular->deleteRow(rows);
 
-       paste_tabular->setTopLine(0, true, true);
-       paste_tabular->setBottomLine(paste_tabular->getFirstCellInRow(rows - 1),
-                                    true, true);
-
        for (col_type i = 0; i < cs; ++i)
                paste_tabular->deleteColumn(0);
 
@@ -4539,9 +4583,14 @@ bool InsetTabular::copySelection(Cursor & cur)
        while (paste_tabular->columnCount() > columns)
                paste_tabular->deleteColumn(columns);
 
-       paste_tabular->setLeftLine(0, true, true);
-       paste_tabular->setRightLine(paste_tabular->getLastCellInRow(0),
-                                   true, true);
+       // We clear all the InsetTableCell pointers, since they
+       // might now become invalid and there is no point in having
+       // them point to temporary things in paste_tabular.
+       for (row_type i = 0; i < paste_tabular->rowCount(); ++i)
+               for (col_type j = 0; j < paste_tabular->columnCount(); ++j) {
+                       paste_tabular->getCellInset(i,j)->setCellData(0);
+                       paste_tabular->getCellInset(i,j)->setTabular(0);
+               }
 
        odocstringstream os;
        OutputParams const runparams(0);
@@ -4582,8 +4631,10 @@ bool InsetTabular::pasteClipboard(Cursor & cur)
                                --c1;
                                continue;
                        }
-                       shared_ptr<InsetText> inset(
-                               new InsetText(*paste_tabular->getCellInset(r1, c1)));
+                       shared_ptr<InsetTableCell> inset(
+                               new InsetTableCell(*paste_tabular->getCellInset(r1, c1)));
+                       // note that setCellInset will call InsetTableCell::setCellData()
+                       // and InsetTableCell::setTabular()
                        tabular.setCellInset(r2, c2, inset);
                        // FIXME: change tracking (MG)
                        inset->setChange(Change(cur.buffer().params().trackChanges ?
@@ -4605,7 +4656,7 @@ void InsetTabular::cutSelection(Cursor & cur)
        getSelection(cur, rs, re, cs, ce);
        for (row_type i = rs; i <= re; ++i) {
                for (col_type j = cs; j <= ce; ++j) {
-                       shared_ptr<InsetText> t
+                       shared_ptr<InsetTableCell> t
                                = cell(tabular.cellIndex(i, j));
                        if (cur.buffer().params().trackChanges)
                                // FIXME: Change tracking (MG)
@@ -4688,6 +4739,12 @@ bool InsetTabular::allowParagraphCustomization(idx_type cell) const
 }
 
 
+bool InsetTabular::forceEmptyLayout(idx_type cell) const
+{
+       return !tabular.getPWidth(cell).zero();
+}
+
+
 bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
                                     bool usePaste)
 {
@@ -4697,8 +4754,8 @@ bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
        col_type cols = 1;
        row_type rows = 1;
        col_type maxCols = 1;
-       docstring::size_type const len = buf.length();
-       docstring::size_type p = 0;
+       size_t const len = buf.length();
+       size_t p = 0;
 
        while (p < len &&
               (p = buf.find_first_of(from_ascii("\t\n"), p)) != docstring::npos) {
@@ -4732,7 +4789,7 @@ bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
                row = tabular.cellRow(cell);
        }
 
-       docstring::size_type op = 0;
+       size_t op = 0;
        idx_type const cells = loctab->cellCount();
        p = 0;
        cols = ocol;
@@ -4748,9 +4805,9 @@ bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
                case '\t':
                        // we can only set this if we are not too far right
                        if (cols < columns) {
-                               shared_ptr<InsetText> inset = loctab->getCellInset(cell);
+                               shared_ptr<InsetTableCell> inset = loctab->getCellInset(cell);
                                Font const font = bv.textMetrics(&inset->text_).
-                                       getDisplayFont(0, 0);
+                                       displayFont(0, 0);
                                inset->setText(buf.substr(op, p - op), font,
                                               buffer().params().trackChanges);
                                ++cols;
@@ -4760,9 +4817,9 @@ bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
                case '\n':
                        // we can only set this if we are not too far right
                        if (cols < columns) {
-                               shared_ptr<InsetText> inset = tabular.getCellInset(cell);
+                               shared_ptr<InsetTableCell> inset = tabular.getCellInset(cell);
                                Font const font = bv.textMetrics(&inset->text_).
-                                       getDisplayFont(0, 0);
+                                       displayFont(0, 0);
                                inset->setText(buf.substr(op, p - op), font,
                                               buffer().params().trackChanges);
                        }
@@ -4777,8 +4834,8 @@ bool InsetTabular::insertPlaintextString(BufferView & bv, docstring const & buf,
        }
        // check for the last cell if there is no trailing '\n'
        if (cell < cells && op < len) {
-               shared_ptr<InsetText> inset = loctab->getCellInset(cell);
-               Font const font = bv.textMetrics(&inset->text_).getDisplayFont(0, 0);
+               shared_ptr<InsetTableCell> inset = loctab->getCellInset(cell);
+               Font const font = bv.textMetrics(&inset->text_).displayFont(0, 0);
                inset->setText(buf.substr(op, len - op), font,
                        buffer().params().trackChanges);
        }
@@ -4803,6 +4860,68 @@ bool InsetTabular::tablemode(Cursor & cur) const
 }
 
 
+bool InsetTabular::completionSupported(Cursor const & cur) const
+{
+       Cursor const & bvCur = cur.bv().cursor();
+       if (&bvCur.inset() != this)
+               return false;
+       return cur.text()->completionSupported(cur);
+}
+
+
+bool InsetTabular::inlineCompletionSupported(Cursor const & cur) const
+{
+       return completionSupported(cur);
+}
+
+
+bool InsetTabular::automaticInlineCompletion() const
+{
+       return lyxrc.completion_inline_text;
+}
+
+
+bool InsetTabular::automaticPopupCompletion() const
+{
+       return lyxrc.completion_popup_text;
+}
+
+
+bool InsetTabular::showCompletionCursor() const
+{
+       return lyxrc.completion_cursor_text;
+}
+
+
+CompletionList const * InsetTabular::createCompletionList(Cursor const & cur) const
+{
+       return completionSupported(cur) ? cur.text()->createCompletionList(cur) : 0;
+}
+
+
+docstring InsetTabular::completionPrefix(Cursor const & cur) const
+{
+       if (!completionSupported(cur))
+               return docstring();
+       return cur.text()->completionPrefix(cur);
+}
+
+
+bool InsetTabular::insertCompletion(Cursor & cur, docstring const & s, bool finished)
+{
+       if (!completionSupported(cur))
+               return false;
+
+       return cur.text()->insertCompletion(cur, s, finished);
+}
+
+
+void InsetTabular::completionPosAndDim(Cursor const & cur, int & x, int & y, 
+                                   Dimension & dim) const
+{
+       TextMetrics const & tm = cur.bv().textMetrics(cur.text());
+       tm.completionPosAndDim(cur, x, y, dim);
+}
 
 
 string const InsetTabularMailer::name_("tabular");