DocBook, InsetFloat: avoid a potential nullptr dereference when detecting the type...

[features.git] / src / insets / InsetLine.cpp

diff --git a/src/insets/InsetLine.cpp b/src/insets/InsetLine.cpp
index 2479be13a03ced33b37e110527aba238803a8ac9..70469be37a653028aa0f67696ded24e954e811a2 100644 (file)
--- a/src/insets/InsetLine.cpp
+++ b/src/insets/InsetLine.cpp
@@ -21,9 +21,8 @@
 #include "FuncRequest.h"
 #include "FuncStatus.h"
 #include "LaTeXFeatures.h"
-#include "Length.h"
 #include "MetricsInfo.h"
-#include "OutputParams.h"
+#include "output_docbook.h"
 #include "output_xhtml.h"
 #include "texstream.h"
 #include "Text.h"
@@ -34,10 +33,10 @@
 #include "support/debug.h"
 #include "support/docstream.h"
 #include "support/gettext.h"
+#include "support/Length.h"
 #include "support/lstrings.h"
 
 #include <cstdlib>
-#include <output_docbook.h>
 
 using namespace std;
 
@@ -141,16 +140,10 @@ void InsetLine::draw(PainterInfo & pi, int x, int y) const
        Dimension const dim = dimension(*pi.base.bv);
 
        // get the surrounding text color
-       Color Line_color = pi.base.font.realColor();
+       Color line_color = pi.base.font.realColor();
 
        // the offset is a vertical one
-       // the horizontal dimension must be corrected with the height because
-       // of left and right border of the painted line for big height.
-       pi.pain.line(x + height_/2 + 1,
-                    y - offset_ - height_/2,
-                    x + dim.wid - height_/2 - 2,
-                    y - offset_ - height_/2,
-                    Line_color, Painter::line_solid, height_);
+       pi.pain.fillRectangle(x, y - offset_ - height_, dim.wid, height_, line_color);
 }