]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetInclude.cpp
InsetTabular.cpp: fix #6585 also for wrapped floats - thanks Vincent
[lyx.git] / src / insets / InsetInclude.cpp
index d28ca279641428146fe9ba00327baade0e24e91c..fd92af13baf4090619060c125e5021091254b781 100644 (file)
@@ -57,7 +57,7 @@
 #include "support/lstrings.h" // contains
 #include "support/lyxalgo.h"
 
-#include <boost/bind.hpp>
+#include "support/bind.h"
 
 using namespace std;
 using namespace lyx::support;
@@ -133,17 +133,17 @@ FileName const masterFileName(Buffer const & buffer)
 void add_preview(RenderMonitoredPreview &, InsetInclude const &, Buffer const &);
 
 
-string const parentFilename(Buffer const & buffer)
+string const parentFileName(Buffer const & buffer)
 {
        return buffer.absFileName();
 }
 
 
-FileName const includedFilename(Buffer const & buffer,
+FileName const includedFileName(Buffer const & buffer,
                              InsetCommandParams const & params)
 {
        return makeAbsPath(to_utf8(params["filename"]),
-                       onlyPath(parentFilename(buffer)));
+                       onlyPath(parentFileName(buffer)));
 }
 
 
@@ -160,11 +160,11 @@ InsetLabel * createLabel(Buffer * buf, docstring const & label_str)
 
 
 InsetInclude::InsetInclude(Buffer * buf, InsetCommandParams const & p)
-       : InsetCommand(buf, p, "include"), include_label(uniqueID()),
+       : InsetCommand(buf, p), include_label(uniqueID()),
          preview_(new RenderMonitoredPreview(this)), failedtoload_(false),
          set_label_(false), label_(0), child_buffer_(0)
 {
-       preview_->fileChanged(boost::bind(&InsetInclude::fileChanged, this));
+       preview_->fileChanged(bind(&InsetInclude::fileChanged, this));
 
        if (isListings(params())) {
                InsetListingsParams listing_params(to_utf8(p["lstparams"]));
@@ -178,7 +178,7 @@ InsetInclude::InsetInclude(InsetInclude const & other)
          preview_(new RenderMonitoredPreview(this)), failedtoload_(false),
          set_label_(false), label_(0), child_buffer_(0)
 {
-       preview_->fileChanged(boost::bind(&InsetInclude::fileChanged, this));
+       preview_->fileChanged(bind(&InsetInclude::fileChanged, this));
 
        if (other.label_)
                label_ = new InsetLabel(*other.label_);
@@ -187,6 +187,8 @@ InsetInclude::InsetInclude(InsetInclude const & other)
 
 InsetInclude::~InsetInclude()
 {
+       if (isBufferLoaded())
+               buffer().invalidateBibfileCache();
        delete label_;
 }
 
@@ -235,7 +237,7 @@ void InsetInclude::doDispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_INSET_MODIFY: {
-               // It should be OK just to invalidate the cache is setParams()
+               // It should be OK just to invalidate the cache in setParams()
                // If not....
                // child_buffer_ = 0;
                InsetCommandParams p(INCLUDE_CODE);
@@ -243,7 +245,7 @@ void InsetInclude::doDispatch(Cursor & cur, FuncRequest & cmd)
                        InsetCommand::doDispatch(cur, cmd);
                        p = params();
                } else
-                       InsetCommand::string2params("include", to_utf8(cmd.argument()), p);
+                       InsetCommand::string2params(to_utf8(cmd.argument()), p);
                if (!p.getCmdName().empty()) {
                        if (isListings(p)){
                                InsetListingsParams new_params(to_utf8(p["lstparams"]));
@@ -274,8 +276,9 @@ void InsetInclude::doDispatch(Cursor & cur, FuncRequest & cmd)
                                }
                        }
                        setParams(p);
+                       cur.forceBufferUpdate();
                } else
-                       cur.noUpdate();
+                       cur.noScreenUpdate();
                break;
        }
 
@@ -337,7 +340,7 @@ void InsetInclude::setParams(InsetCommandParams const & p)
        if (type(params()) == INPUT)
                add_preview(*preview_, *this, buffer());
 
-       buffer().updateBibfilesCache();
+       buffer().invalidateBibfileCache();
 }
 
 
@@ -411,7 +414,7 @@ Buffer * InsetInclude::loadIfNeeded() const
        if (failedtoload_ || isVerbatim(params()) || isListings(params()))
                return 0;
 
-       FileName const included_file = includedFilename(buffer(), params());
+       FileName const included_file = includedFileName(buffer(), params());
        // Use cached Buffer if possible.
        if (child_buffer_ != 0) {
                if (theBufferList().isLoaded(child_buffer_)
@@ -437,7 +440,7 @@ Buffer * InsetInclude::loadIfNeeded() const
                        // Buffer creation is not possible.
                        return 0;
 
-               if (!child->loadLyXFile(included_file)) {
+               if (child->loadLyXFile(included_file) != Buffer::ReadSuccess) {
                        failedtoload_ = true;
                        //close the buffer we just opened
                        theBufferList().release(child);
@@ -463,7 +466,7 @@ int InsetInclude::latex(odocstream & os, OutputParams const & runparams) const
        if (incfile.empty())
                return 0;
 
-       FileName const included_file = includedFilename(buffer(), params());
+       FileName const included_file = includedFileName(buffer(), params());
 
        // Check we're not trying to include ourselves.
        // FIXME RECURSIVE INCLUDE
@@ -507,9 +510,16 @@ int InsetInclude::latex(odocstream & os, OutputParams const & runparams) const
                incfile = mangled;
        else if (!isValidLaTeXFileName(incfile)) {
                frontend::Alert::warning(_("Invalid filename"),
-                                        _("The following filename is likely to cause trouble "
-                                          "when running the exported file through LaTeX: ") +
-                                           from_utf8(incfile));
+                       _("The following filename will cause troubles "
+                         "when running the exported file through LaTeX: ") +
+                       from_utf8(incfile));
+       }
+       else if (!isValidDVIFileName(incfile)) {
+               frontend::Alert::warning(_("Problematic filename for DVI"),
+                       _("The following filename can cause troubles "
+                         "when running the exported file through LaTeX "
+                         "and opening the resulting DVI: ") +
+                       from_utf8(incfile), true);
        }
        LYXERR(Debug::LATEX, "incfile:" << incfile);
        LYXERR(Debug::LATEX, "exportfile:" << exportfile);
@@ -520,13 +530,13 @@ int InsetInclude::latex(odocstream & os, OutputParams const & runparams) const
                //in a comment or doing a dryrun
        } else if (isInputOrInclude(params()) &&
                 isLyXFileName(included_file.absFileName())) {
-               //if it's a LyX file and we're inputting or including,
-               //try to load it so we can write the associated latex
-               if (!loadIfNeeded())
+               // if it's a LyX file and we're inputting or including,
+               // try to load it so we can write the associated latex
+               
+               Buffer * tmp = loadIfNeeded();
+               if (!tmp)
                        return false;
 
-               Buffer * tmp = theBufferList().getBuffer(included_file);
-
                if (tmp->params().baseClass() != masterBuffer->params().baseClass()) {
                        // FIXME UNICODE
                        docstring text = bformat(_("Included file `%1$s'\n"
@@ -669,7 +679,7 @@ docstring InsetInclude::xhtml(XHTMLStream & xs, OutputParams const &rp) const
                if (listing)
                        xs << html::StartTag("pre");
                // FIXME: We don't know the encoding of the file, default to UTF-8.
-               xs << includedFilename(buffer(), params()).fileContents("UTF-8");
+               xs << includedFileName(buffer(), params()).fileContents("UTF-8");
                if (listing)
                        xs << html::EndTag("pre");
                return docstring();
@@ -678,7 +688,7 @@ docstring InsetInclude::xhtml(XHTMLStream & xs, OutputParams const &rp) const
        // We don't (yet) know how to Input or Include non-LyX files.
        // (If we wanted to get really arcane, we could run some tex2html
        // converter on the included file. But that's just masochistic.)
-       FileName const included_file = includedFilename(buffer(), params());
+       FileName const included_file = includedFileName(buffer(), params());
        if (!isLyXFileName(included_file.absFileName())) {
                frontend::Alert::warning(_("Unsupported Inclusion"),
                                         bformat(_("LyX does not know how to include non-LyX files when "
@@ -711,7 +721,7 @@ int InsetInclude::plaintext(odocstream & os, OutputParams const &) const
        if (isVerbatim(params()) || isListings(params())) {
                os << '[' << screenLabel() << '\n';
                // FIXME: We don't know the encoding of the file, default to UTF-8.
-               os << includedFilename(buffer(), params()).fileContents("UTF-8");
+               os << includedFileName(buffer(), params()).fileContents("UTF-8");
                os << "\n]";
                return PLAINTEXT_NEWLINE + 1; // one char on a separate line
        } else {
@@ -730,7 +740,7 @@ int InsetInclude::docbook(odocstream & os, OutputParams const & runparams) const
        if (incfile.empty())
                return 0;
 
-       string const included_file = includedFilename(buffer(), params()).absFileName();
+       string const included_file = includedFileName(buffer(), params()).absFileName();
 
        // Check we're not trying to include ourselves.
        // FIXME RECURSIVE INCLUDE
@@ -747,9 +757,8 @@ int InsetInclude::docbook(odocstream & os, OutputParams const & runparams) const
        string const exportfile = changeExtension(incfile, ".sgml");
        DocFileName writefile(changeExtension(included_file, ".sgml"));
 
-       if (loadIfNeeded()) {
-               Buffer * tmp = theBufferList().getBuffer(FileName(included_file));
-
+       Buffer * tmp = loadIfNeeded();
+       if (tmp) {
                string const mangled = writefile.mangledFileName();
                writefile = makeAbsPath(mangled,
                                        buffer().masterBuffer()->temppath());
@@ -787,7 +796,7 @@ void InsetInclude::validate(LaTeXFeatures & features) const
        LASSERT(&buffer() == &features.buffer(), /**/);
 
        string const included_file =
-               includedFilename(buffer(), params()).absFileName();
+               includedFileName(buffer(), params()).absFileName();
 
        if (isLyXFileName(included_file))
                writefile = changeExtension(included_file, ".sgml");
@@ -810,9 +819,9 @@ void InsetInclude::validate(LaTeXFeatures & features) const
        // Here we must do the fun stuff...
        // Load the file in the include if it needs
        // to be loaded:
-       if (loadIfNeeded()) {
-               // a file got loaded
-               Buffer * const tmp = theBufferList().getBuffer(FileName(included_file));
+       Buffer * const tmp = loadIfNeeded();
+       if (tmp) {
+               // the file is loaded
                // make sure the buffer isn't us
                // FIXME RECURSIVE INCLUDES
                // This is not sufficient, as recursive includes could be
@@ -832,32 +841,10 @@ void InsetInclude::validate(LaTeXFeatures & features) const
 void InsetInclude::fillWithBibKeys(BiblioInfo & keys,
        InsetIterator const & /*di*/) const
 {
-       if (loadIfNeeded()) {
-               string const included_file = includedFilename(buffer(), params()).absFileName();
-               Buffer * tmp = theBufferList().getBuffer(FileName(included_file));
-               BiblioInfo const & newkeys = tmp->localBibInfo();
-               keys.mergeBiblioInfo(newkeys);
-       }
-}
-
-
-void InsetInclude::updateBibfilesCache()
-{
-       Buffer const * const child = getChildBuffer();
-       if (child)
-               child->updateBibfilesCache(Buffer::UpdateChildOnly);
-}
-
-
-support::FileNameList const &
-       InsetInclude::getBibfilesCache() const
-{
-       Buffer const * const child = getChildBuffer();
-       if (child)
-               return child->getBibfilesCache(Buffer::UpdateChildOnly);
-
-       static support::FileNameList const empty;
-       return empty;
+       Buffer * child = loadIfNeeded();
+       if (!child)
+               return;
+       child->fillWithBibKeys(keys);
 }
 
 
@@ -938,7 +925,7 @@ namespace {
 
 bool preview_wanted(InsetCommandParams const & params, Buffer const & buffer)
 {
-       FileName const included_file = includedFilename(buffer, params);
+       FileName const included_file = includedFileName(buffer, params);
 
        return type(params) == INPUT && params.preview() &&
                included_file.isReadableFile();
@@ -964,7 +951,7 @@ void add_preview(RenderMonitoredPreview & renderer, InsetInclude const & inset,
        InsetCommandParams const & params = inset.params();
        if (RenderPreview::status() != LyXRC::PREVIEW_OFF &&
            preview_wanted(params, buffer)) {
-               renderer.setAbsFile(includedFilename(buffer, params));
+               renderer.setAbsFile(includedFileName(buffer, params));
                docstring const snippet = latexString(inset);
                renderer.addPreview(snippet, buffer);
        }
@@ -979,7 +966,7 @@ void InsetInclude::addPreview(DocIterator const & /*inset_pos*/,
        Buffer const & buffer = ploader.buffer();
        if (!preview_wanted(params(), buffer))
                return;
-       preview_->setAbsFile(includedFilename(buffer, params()));
+       preview_->setAbsFile(includedFileName(buffer, params()));
        docstring const snippet = latexString(*this);
        preview_->addPreview(snippet, ploader);
 }