]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetInclude.cpp
Get rid of Qt resources
[lyx.git] / src / insets / InsetInclude.cpp
index d9a99237110d8f2a03b8a612a798194edbb95554..5f1af32640a5cf19a68b676c7ac938b28a92f4a4 100644 (file)
@@ -65,8 +65,6 @@
 #include "support/mutex.h"
 #include "support/ExceptionMessage.h"
 
-#include "support/bind.h"
-
 using namespace std;
 using namespace lyx::support;
 
@@ -160,7 +158,7 @@ FileName const includedFileName(Buffer const & buffer,
 InsetLabel * createLabel(Buffer * buf, docstring const & label_str)
 {
        if (label_str.empty())
-               return 0;
+               return nullptr;
        InsetCommandParams icp(LABEL_CODE);
        icp["name"] = label_str;
        return new InsetLabel(buf, icp);
@@ -189,7 +187,8 @@ char_type replaceCommaInBraces(docstring & params)
 InsetInclude::InsetInclude(Buffer * buf, InsetCommandParams const & p)
        : InsetCommand(buf, p), include_label(uniqueID()),
          preview_(make_unique<RenderMonitoredPreview>(this)), failedtoload_(false),
-         set_label_(false), label_(0), child_buffer_(0), file_exist_(false)
+         set_label_(false), label_(nullptr), child_buffer_(nullptr), file_exist_(false),
+         recursion_error_(false)
 {
        preview_->connect([=](){ fileChanged(); });
 
@@ -204,7 +203,8 @@ InsetInclude::InsetInclude(Buffer * buf, InsetCommandParams const & p)
 InsetInclude::InsetInclude(InsetInclude const & other)
        : InsetCommand(other), include_label(other.include_label),
          preview_(make_unique<RenderMonitoredPreview>(this)), failedtoload_(false),
-         set_label_(false), label_(0), child_buffer_(0), file_exist_(other.file_exist_)
+         set_label_(false), label_(nullptr), child_buffer_(nullptr), 
+         file_exist_(other.file_exist_),recursion_error_(other.recursion_error_)
 {
        preview_->connect([=](){ fileChanged(); });
 
@@ -289,7 +289,7 @@ void InsetInclude::doDispatch(Cursor & cur, FuncRequest & cmd)
 
                                if (new_label.empty()) {
                                        delete label_;
-                                       label_ = 0;
+                                       label_ = nullptr;
                                } else {
                                        docstring old_label;
                                        if (label_)
@@ -374,10 +374,11 @@ bool InsetInclude::getStatus(Cursor & cur, FuncRequest const & cmd,
 void InsetInclude::setParams(InsetCommandParams const & p)
 {
        // invalidate the cache
-       child_buffer_ = 0;
+       child_buffer_ = nullptr;
 
        // reset in order to allow loading new file
        failedtoload_ = false;
+       recursion_error_ = false;
 
        InsetCommand::setParams(p);
        set_label_ = false;
@@ -443,17 +444,6 @@ docstring InsetInclude::screenLabel() const
 }
 
 
-Buffer * InsetInclude::getChildBuffer() const
-{
-       Buffer * childBuffer = loadIfNeeded();
-
-       // FIXME RECURSIVE INCLUDE
-       // This isn't sufficient, as the inclusion could be downstream.
-       // But it'll have to do for now.
-       return (childBuffer == &buffer()) ? 0 : childBuffer;
-}
-
-
 Buffer * InsetInclude::loadIfNeeded() const
 {
        // This is for background export and preview. We don't even want to
@@ -463,47 +453,53 @@ Buffer * InsetInclude::loadIfNeeded() const
 
        // Don't try to load it again if we failed before.
        if (failedtoload_ || isVerbatim(params()) || isListings(params()))
-               return 0;
+               return nullptr;
 
        FileName const included_file = includedFileName(buffer(), params());
        // Use cached Buffer if possible.
-       if (child_buffer_ != 0) {
+       if (child_buffer_ != nullptr) {
                if (theBufferList().isLoaded(child_buffer_)
                    // additional sanity check: make sure the Buffer really is
                    // associated with the file we want.
                    && child_buffer_ == theBufferList().getBuffer(included_file))
                        return child_buffer_;
                // Buffer vanished, so invalidate cache and try to reload.
-               child_buffer_ = 0;
+               child_buffer_ = nullptr;
        }
 
        if (!isLyXFileName(included_file.absFileName()))
-               return 0;
+               return nullptr;
 
        Buffer * child = theBufferList().getBuffer(included_file);
+       if (checkForRecursiveInclude(child))
+               return child;
+
        if (!child) {
                // the readonly flag can/will be wrong, not anymore I think.
                if (!included_file.exists()) {
                        failedtoload_ = true;
-                       return 0;
+                       return nullptr;
                }
 
                child = theBufferList().newBuffer(included_file.absFileName());
                if (!child)
                        // Buffer creation is not possible.
-                       return 0;
+                       return nullptr;
 
+               buffer().pushIncludedBuffer(child);
                // Set parent before loading, such that macros can be tracked
                child->setParent(&buffer());
 
                if (child->loadLyXFile() != Buffer::ReadSuccess) {
                        failedtoload_ = true;
-                       child->setParent(0);
+                       child->setParent(nullptr);
                        //close the buffer we just opened
                        theBufferList().release(child);
-                       return 0;
+                       buffer().popIncludedBuffer();
+                       return nullptr;
                }
 
+               buffer().popIncludedBuffer();
                if (!child->errorList("Parse").empty()) {
                        // FIXME: Do something.
                }
@@ -526,6 +522,26 @@ Buffer * InsetInclude::loadIfNeeded() const
 }
 
 
+bool InsetInclude::checkForRecursiveInclude(
+       Buffer const * cbuf, bool silent) const
+{
+       if (recursion_error_)
+               return true;
+
+       if (!buffer().isBufferIncluded(cbuf))
+               return false;
+
+       if (!silent) {
+               docstring const msg = _("The file\n%1$s\n has attempted to include itself.\n"
+                       "The document set will not work properly until this is fixed!");
+               frontend::Alert::warning(_("Recursive Include"),
+                       bformat(msg, from_utf8(cbuf->fileName().absFileName())));
+       }
+       recursion_error_ = true;
+       return true;
+}
+
+
 void InsetInclude::latex(otexstream & os, OutputParams const & runparams) const
 {
        string incfile = ltrim(to_utf8(params()["filename"]));
@@ -550,20 +566,6 @@ void InsetInclude::latex(otexstream & os, OutputParams const & runparams) const
        }
 
        FileName const included_file = includedFileName(buffer(), params());
-
-       // Check we're not trying to include ourselves.
-       // FIXME RECURSIVE INCLUDE
-       // This isn't sufficient, as the inclusion could be downstream.
-       // But it'll have to do for now.
-       if (isInputOrInclude(params()) &&
-               buffer().absFileName() == included_file.absFileName())
-       {
-               Alert::error(_("Recursive input"),
-                              bformat(_("Attempted to include file %1$s in itself! "
-                              "Ignoring inclusion."), from_utf8(incfile)));
-               return;
-       }
-
        Buffer const * const masterBuffer = buffer().masterBuffer();
 
        // if incfile is relative, make it relative to the master
@@ -765,152 +767,8 @@ void InsetInclude::latex(otexstream & os, OutputParams const & runparams) const
                // in a comment or doing a dryrun
                return;
 
-       if (isInputOrInclude(params()) &&
-                isLyXFileName(included_file.absFileName())) {
-               // if it's a LyX file and we're inputting or including,
-               // try to load it so we can write the associated latex
-
-               Buffer * tmp = loadIfNeeded();
-               if (!tmp) {
-                       if (!runparams.silent) {
-                               docstring text = bformat(_("Could not load included "
-                                       "file\n`%1$s'\n"
-                                       "Please, check whether it actually exists."),
-                                       included_file.displayName());
-                               throw ExceptionMessage(ErrorException, _("Error: "),
-                                                      text);
-                       }
-                       return;
-               }
-
-               if (!runparams.silent) {
-                       if (tmp->params().baseClass() != masterBuffer->params().baseClass()) {
-                               // FIXME UNICODE
-                               docstring text = bformat(_("Included file `%1$s'\n"
-                                       "has textclass `%2$s'\n"
-                                       "while parent file has textclass `%3$s'."),
-                                       included_file.displayName(),
-                                       from_utf8(tmp->params().documentClass().name()),
-                                       from_utf8(masterBuffer->params().documentClass().name()));
-                               Alert::warning(_("Different textclasses"), text, true);
-                       }
-
-                       string const child_tf = tmp->params().useNonTeXFonts ? "true" : "false";
-                       string const master_tf = masterBuffer->params().useNonTeXFonts ? "true" : "false";
-                       if (tmp->params().useNonTeXFonts != masterBuffer->params().useNonTeXFonts) {
-                               docstring text = bformat(_("Included file `%1$s'\n"
-                                       "has use-non-TeX-fonts set to `%2$s'\n"
-                                       "while parent file has use-non-TeX-fonts set to `%3$s'."),
-                                       included_file.displayName(),
-                                       from_utf8(child_tf),
-                                       from_utf8(master_tf));
-                               Alert::warning(_("Different use-non-TeX-fonts settings"), text, true);
-                       } 
-                       else if (tmp->params().inputenc != masterBuffer->params().inputenc) {
-                               docstring text = bformat(_("Included file `%1$s'\n"
-                                       "uses input encoding \"%2$s\" [%3$s]\n"
-                                       "while parent file uses input encoding \"%4$s\" [%5$s]."),
-                                       included_file.displayName(),
-                                       _(tmp->params().inputenc),
-                                       from_utf8(tmp->params().encoding().guiName()),
-                                       _(masterBuffer->params().inputenc),
-                                       from_utf8(masterBuffer->params().encoding().guiName()));
-                               Alert::warning(_("Different LaTeX input encodings"), text, true);
-                       }
-
-                       // Make sure modules used in child are all included in master
-                       // FIXME It might be worth loading the children's modules into the master
-                       // over in BufferParams rather than doing this check.
-                       LayoutModuleList const masterModules = masterBuffer->params().getModules();
-                       LayoutModuleList const childModules = tmp->params().getModules();
-                       LayoutModuleList::const_iterator it = childModules.begin();
-                       LayoutModuleList::const_iterator end = childModules.end();
-                       for (; it != end; ++it) {
-                               string const module = *it;
-                               LayoutModuleList::const_iterator found =
-                                       find(masterModules.begin(), masterModules.end(), module);
-                               if (found == masterModules.end()) {
-                                       docstring text = bformat(_("Included file `%1$s'\n"
-                                               "uses module `%2$s'\n"
-                                               "which is not used in parent file."),
-                                               included_file.displayName(), from_utf8(module));
-                                       Alert::warning(_("Module not found"), text, true);
-                               }
-                       }
-               }
-
-               tmp->markDepClean(masterBuffer->temppath());
-
-               // Don't assume the child's format is latex
-               string const inc_format = tmp->params().bufferFormat();
-               FileName const tmpwritefile(changeExtension(writefile.absFileName(),
-                       theFormats().extension(inc_format)));
-
-               // FIXME: handle non existing files
-               // The included file might be written in a different encoding
-               // and language.
-               Encoding const * const oldEnc = runparams.encoding;
-               Language const * const oldLang = runparams.master_language;
-               // If the master uses non-TeX fonts (XeTeX, LuaTeX),
-               // the children must be encoded in plain utf8!
-               if (masterBuffer->params().useNonTeXFonts)
-                       runparams.encoding = encodings.fromLyXName("utf8-plain");
-               else if (oldEnc)
-                       runparams.encoding = oldEnc;
-               else runparams.encoding = &tmp->params().encoding();
-               runparams.master_language = buffer().params().language;
-               runparams.par_begin = 0;
-               runparams.par_end = tmp->paragraphs().size();
-               runparams.is_child = true;
-               Buffer::ExportStatus retval =
-                       tmp->makeLaTeXFile(tmpwritefile, masterFileName(buffer()).
-                               onlyPath().absFileName(), runparams, Buffer::OnlyBody);
-               if (retval == Buffer::ExportKilled && buffer().isClone() &&
-                     buffer().isExporting()) {
-                 // We really shouldn't get here, I don't think.
-                 LYXERR0("No conversion exception?");
-                       throw ConversionException();
-               }
-               else if (retval != Buffer::ExportSuccess) {
-                       if (!runparams.silent) {
-                               docstring msg = bformat(_("Included file `%1$s' "
-                                       "was not exported correctly.\n "
-                                       "LaTeX export is probably incomplete."),
-                                       included_file.displayName());
-                               ErrorList const & el = tmp->errorList("Export");
-                               if (!el.empty())
-                                       msg = bformat(from_ascii("%1$s\n\n%2$s\n\n%3$s"),
-                                               msg, el.begin()->error, el.begin()->description);
-                               throw ExceptionMessage(ErrorException, _("Error: "), msg);
-                       }
-               }
-               runparams.encoding = oldEnc;
-               runparams.master_language = oldLang;
-               runparams.is_child = false;
-
-               // If needed, use converters to produce a latex file from the child
-               if (tmpwritefile != writefile) {
-                       ErrorList el;
-                       Converters::RetVal const conv_retval =
-                               theConverters().convert(tmp, tmpwritefile, writefile,
-                                   included_file, inc_format, tex_format, el);
-                       if (conv_retval == Converters::KILLED && buffer().isClone() &&
-                           buffer().isExporting()) {
-                               // We really shouldn't get here, I don't think.
-                               LYXERR0("No conversion exception?");
-                               throw ConversionException();
-                       } else if (conv_retval != Converters::SUCCESS && !runparams.silent) {
-                               docstring msg = bformat(_("Included file `%1$s' "
-                                               "was not exported correctly.\n "
-                                               "LaTeX export is probably incomplete."),
-                                               included_file.displayName());
-                               if (!el.empty())
-                                       msg = bformat(from_ascii("%1$s\n\n%2$s\n\n%3$s"),
-                                               msg, el.begin()->error, el.begin()->description);
-                               throw ExceptionMessage(ErrorException, _("Error: "), msg);
-                       }
-               }
-       } else {
+       if (!isInputOrInclude(params()) ||
+                !isLyXFileName(included_file.absFileName())) {
                // In this case, it's not a LyX file, so we copy the file
                // to the temp dir, so that .aux files etc. are not created
                // in the original dir. Files included by this file will be
@@ -918,7 +776,6 @@ void InsetInclude::latex(otexstream & os, OutputParams const & runparams) const
                // input@path, see ../Buffer.cpp.
                unsigned long const checksum_in  = included_file.checksum();
                unsigned long const checksum_out = writefile.checksum();
-
                if (checksum_in != checksum_out) {
                        if (!included_file.copyTo(writefile)) {
                                // FIXME UNICODE
@@ -926,9 +783,156 @@ void InsetInclude::latex(otexstream & os, OutputParams const & runparams) const
                                        to_utf8(bformat(_("Could not copy the file\n%1$s\n"
                                                                        "into the temporary directory."),
                                                         from_utf8(included_file.absFileName()))));
-                               return;
                        }
                }
+               return;
+       }
+
+               
+       // it's a LyX file and we're inputting or including, so
+       // try to load it so we can write the associated latex
+       Buffer * tmp = loadIfNeeded();
+       if (!tmp) {
+               if (!runparams.silent) {
+                       docstring text = bformat(_("Could not load included "
+                               "file\n`%1$s'\n"
+                               "Please, check whether it actually exists."),
+                               included_file.displayName());
+                       throw ExceptionMessage(ErrorException, _("Error: "),
+                                                  text);
+               }
+               return;
+       }
+
+       if (recursion_error_)
+               return;
+
+       if (!runparams.silent) {
+               if (tmp->params().baseClass() != masterBuffer->params().baseClass()) {
+                       // FIXME UNICODE
+                       docstring text = bformat(_("Included file `%1$s'\n"
+                               "has textclass `%2$s'\n"
+                               "while parent file has textclass `%3$s'."),
+                               included_file.displayName(),
+                               from_utf8(tmp->params().documentClass().name()),
+                               from_utf8(masterBuffer->params().documentClass().name()));
+                       Alert::warning(_("Different textclasses"), text, true);
+               }
+
+               string const child_tf = tmp->params().useNonTeXFonts ? "true" : "false";
+               string const master_tf = masterBuffer->params().useNonTeXFonts ? "true" : "false";
+               if (tmp->params().useNonTeXFonts != masterBuffer->params().useNonTeXFonts) {
+                       docstring text = bformat(_("Included file `%1$s'\n"
+                               "has use-non-TeX-fonts set to `%2$s'\n"
+                               "while parent file has use-non-TeX-fonts set to `%3$s'."),
+                               included_file.displayName(),
+                               from_utf8(child_tf),
+                               from_utf8(master_tf));
+                       Alert::warning(_("Different use-non-TeX-fonts settings"), text, true);
+               } 
+               else if (tmp->params().inputenc != masterBuffer->params().inputenc) {
+                       docstring text = bformat(_("Included file `%1$s'\n"
+                               "uses input encoding \"%2$s\" [%3$s]\n"
+                               "while parent file uses input encoding \"%4$s\" [%5$s]."),
+                               included_file.displayName(),
+                               _(tmp->params().inputenc),
+                               from_utf8(tmp->params().encoding().guiName()),
+                               _(masterBuffer->params().inputenc),
+                               from_utf8(masterBuffer->params().encoding().guiName()));
+                       Alert::warning(_("Different LaTeX input encodings"), text, true);
+               }
+
+               // Make sure modules used in child are all included in master
+               // FIXME It might be worth loading the children's modules into the master
+               // over in BufferParams rather than doing this check.
+               LayoutModuleList const masterModules = masterBuffer->params().getModules();
+               LayoutModuleList const childModules = tmp->params().getModules();
+               LayoutModuleList::const_iterator it = childModules.begin();
+               LayoutModuleList::const_iterator end = childModules.end();
+               for (; it != end; ++it) {
+                       string const module = *it;
+                       LayoutModuleList::const_iterator found =
+                               find(masterModules.begin(), masterModules.end(), module);
+                       if (found == masterModules.end()) {
+                               docstring text = bformat(_("Included file `%1$s'\n"
+                                       "uses module `%2$s'\n"
+                                       "which is not used in parent file."),
+                                       included_file.displayName(), from_utf8(module));
+                               Alert::warning(_("Module not found"), text, true);
+                       }
+               }
+       }
+
+       tmp->markDepClean(masterBuffer->temppath());
+
+       // Don't assume the child's format is latex
+       string const inc_format = tmp->params().bufferFormat();
+       FileName const tmpwritefile(changeExtension(writefile.absFileName(),
+               theFormats().extension(inc_format)));
+
+       // FIXME: handle non existing files
+       // The included file might be written in a different encoding
+       // and language.
+       Encoding const * const oldEnc = runparams.encoding;
+       Language const * const oldLang = runparams.master_language;
+       // If the master uses non-TeX fonts (XeTeX, LuaTeX),
+       // the children must be encoded in plain utf8!
+       if (masterBuffer->params().useNonTeXFonts)
+               runparams.encoding = encodings.fromLyXName("utf8-plain");
+       else if (oldEnc)
+               runparams.encoding = oldEnc;
+       else runparams.encoding = &tmp->params().encoding();
+       runparams.master_language = buffer().params().language;
+       runparams.par_begin = 0;
+       runparams.par_end = tmp->paragraphs().size();
+       runparams.is_child = true;
+       Buffer::ExportStatus retval =
+               tmp->makeLaTeXFile(tmpwritefile, masterFileName(buffer()).
+                       onlyPath().absFileName(), runparams, Buffer::OnlyBody);
+       if (retval == Buffer::ExportKilled && buffer().isClone() &&
+                 buffer().isExporting()) {
+         // We really shouldn't get here, I don't think.
+         LYXERR0("No conversion exception?");
+               throw ConversionException();
+       }
+       else if (retval != Buffer::ExportSuccess) {
+               if (!runparams.silent) {
+                       docstring msg = bformat(_("Included file `%1$s' "
+                               "was not exported correctly.\n "
+                               "LaTeX export is probably incomplete."),
+                               included_file.displayName());
+                       ErrorList const & el = tmp->errorList("Export");
+                       if (!el.empty())
+                               msg = bformat(from_ascii("%1$s\n\n%2$s\n\n%3$s"),
+                                               msg, el.begin()->error, el.begin()->description);
+                       throw ExceptionMessage(ErrorException, _("Error: "), msg);
+               }
+       }
+       runparams.encoding = oldEnc;
+       runparams.master_language = oldLang;
+       runparams.is_child = false;
+
+       // If needed, use converters to produce a latex file from the child
+       if (tmpwritefile != writefile) {
+               ErrorList el;
+               Converters::RetVal const conv_retval =
+                       theConverters().convert(tmp, tmpwritefile, writefile,
+                               included_file, inc_format, tex_format, el);
+               if (conv_retval == Converters::KILLED && buffer().isClone() &&
+                       buffer().isExporting()) {
+                       // We really shouldn't get here, I don't think.
+                       LYXERR0("No conversion exception?");
+                       throw ConversionException();
+               } else if (conv_retval != Converters::SUCCESS && !runparams.silent) {
+                       docstring msg = bformat(_("Included file `%1$s' "
+                                       "was not exported correctly.\n "
+                                       "LaTeX export is probably incomplete."),
+                                       included_file.displayName());
+                       if (!el.empty())
+                               msg = bformat(from_ascii("%1$s\n\n%2$s\n\n%3$s"),
+                                               msg, el.begin()->error, el.begin()->description);
+                       throw ExceptionMessage(ErrorException, _("Error: "), msg);
+               }
        }
 }
 
@@ -966,19 +970,13 @@ docstring InsetInclude::xhtml(XHTMLStream & xs, OutputParams const & rp) const
 
        // In the other cases, we will generate the HTML and include it.
 
-       // Check we're not trying to include ourselves.
-       // FIXME RECURSIVE INCLUDE
-       if (buffer().absFileName() == included_file.absFileName()) {
-               Alert::error(_("Recursive input"),
-                              bformat(_("Attempted to include file %1$s in itself! "
-                              "Ignoring inclusion."), ltrim(params()["filename"])));
-               return docstring();
-       }
-
        Buffer const * const ibuf = loadIfNeeded();
        if (!ibuf)
                return docstring();
 
+       if (recursion_error_)
+               return docstring();
+
        // are we generating only some paragraphs, or all of them?
        bool const all_pars = !rp.dryrun ||
                        (rp.par_begin == 0 &&
@@ -995,6 +993,7 @@ docstring InsetInclude::xhtml(XHTMLStream & xs, OutputParams const & rp) const
                   << from_utf8(included_file.absFileName())
                   << XHTMLStream::ESCAPE_NONE
                         << " -->";
+       
        return docstring();
 }
 
@@ -1029,6 +1028,10 @@ int InsetInclude::plaintext(odocstringstream & os,
                os << str;
                return str.size();
        }
+
+       if (recursion_error_)
+               return 0;
+
        writePlaintextFile(*ibuf, os, op);
        return 0;
 }
@@ -1043,18 +1046,6 @@ int InsetInclude::docbook(odocstream & os, OutputParams const & runparams) const
                return 0;
 
        string const included_file = includedFileName(buffer(), params()).absFileName();
-
-       // Check we're not trying to include ourselves.
-       // FIXME RECURSIVE INCLUDE
-       // This isn't sufficient, as the inclusion could be downstream.
-       // But it'll have to do for now.
-       if (buffer().absFileName() == included_file) {
-               Alert::error(_("Recursive input"),
-                              bformat(_("Attempted to include file %1$s in itself! "
-                              "Ignoring inclusion."), from_utf8(incfile)));
-               return 0;
-       }
-
        string exppath = incfile;
        if (!runparams.export_folder.empty()) {
                exppath = makeAbsPath(exppath, runparams.export_folder).realPath();
@@ -1067,6 +1058,9 @@ int InsetInclude::docbook(odocstream & os, OutputParams const & runparams) const
 
        Buffer * tmp = loadIfNeeded();
        if (tmp) {
+               if (recursion_error_)
+                       return 0;
+
                string const mangled = writefile.mangledFileName();
                writefile = makeAbsPath(mangled,
                                        buffer().masterBuffer()->temppath());
@@ -1136,40 +1130,41 @@ void InsetInclude::validate(LaTeXFeatures & features) const
        // Load the file in the include if it needs
        // to be loaded:
        Buffer * const tmp = loadIfNeeded();
-       if (tmp) {
-               // the file is loaded
-               // make sure the buffer isn't us
-               // FIXME RECURSIVE INCLUDES
-               // This is not sufficient, as recursive includes could be
-               // more than a file away. But it will do for now.
-               if (tmp && tmp != &buffer()) {
-                       // We must temporarily change features.buffer,
-                       // otherwise it would always be the master buffer,
-                       // and nested includes would not work.
-                       features.setBuffer(*tmp);
-                       // Maybe this is already a child
-                       bool const is_child =
-                               features.runparams().is_child;
-                       features.runparams().is_child = true;
-                       tmp->validate(features);
-                       features.runparams().is_child = is_child;
-                       features.setBuffer(buffer());
-               }
-       }
+       if (!tmp) 
+               return;
+
+       // the file is loaded
+       if (checkForRecursiveInclude(tmp))
+               return;
+       buffer().pushIncludedBuffer(tmp);
+
+       // We must temporarily change features.buffer,
+       // otherwise it would always be the master buffer,
+       // and nested includes would not work.
+       features.setBuffer(*tmp);
+       // Maybe this is already a child
+       bool const is_child =
+               features.runparams().is_child;
+       features.runparams().is_child = true;
+       tmp->validate(features);
+       features.runparams().is_child = is_child;
+       features.setBuffer(buffer());
+       
+       buffer().popIncludedBuffer();
 }
 
 
 void InsetInclude::collectBibKeys(InsetIterator const & /*di*/, FileNameList & checkedFiles) const
 {
-       Buffer * child = loadIfNeeded();
-       if (!child)
+       Buffer * ibuf = loadIfNeeded();
+       if (!ibuf)
                return;
-       // FIXME RECURSIVE INCLUDE
-       // This isn't sufficient, as the inclusion could be downstream.
-       // But it'll have to do for now.
-       if (child == &buffer())
+
+       if (checkForRecursiveInclude(ibuf))
                return;
-       child->collectBibKeys(checkedFiles);
+       buffer().pushIncludedBuffer(ibuf);
+       ibuf->collectBibKeys(checkedFiles);
+       buffer().popIncludedBuffer();   
 }
 
 
@@ -1189,7 +1184,7 @@ void InsetInclude::metrics(MetricsInfo & mi, Dimension & dim) const
        } else {
                if (!set_label_) {
                        set_label_ = true;
-                       button_.update(screenLabel(), true, false, !file_exist_);
+                       button_.update(screenLabel(), true, false, !file_exist_ || recursion_error_);
                }
                button_.metrics(mi, dim);
        }
@@ -1276,7 +1271,7 @@ docstring latexString(InsetInclude const & inset)
        otexstream os(ods);
        // We don't need to set runparams.encoding since this will be done
        // by latex() anyway.
-       OutputParams runparams(0);
+       OutputParams runparams(nullptr);
        runparams.flavor = OutputParams::LATEX;
        runparams.for_preview = true;
        inset.latex(os, runparams);
@@ -1327,7 +1322,7 @@ void InsetInclude::addToToc(DocIterator const & cpit, bool output_active,
                b.pushItem(cpit, screenLabel(), output_active);
                b.pop();
        } else {
-               Buffer const * const childbuffer = getChildBuffer();
+               Buffer const * const childbuffer = loadIfNeeded();
 
                TocBuilder & b = backend.builder("child");
                docstring str = childbuffer ? childbuffer->fileName().displayName()
@@ -1338,16 +1333,20 @@ void InsetInclude::addToToc(DocIterator const & cpit, bool output_active,
                if (!childbuffer)
                        return;
 
+               if (checkForRecursiveInclude(childbuffer))
+                       return;
+               buffer().pushIncludedBuffer(childbuffer);
                // Update the child's tocBackend. The outliner uses the master's, but
                // the navigation menu uses the child's.
                childbuffer->tocBackend().update(output_active, utype);
                // Include Tocs from children
                childbuffer->inset().addToToc(DocIterator(), output_active, utype,
                                              backend);
-               //Copy missing outliner names (though the user has been warned against
-               //having different document class and module selection between master
-               //and child).
-               for (pair<string, docstring> const & name
+               buffer().popIncludedBuffer();
+               // Copy missing outliner names (though the user has been warned against
+               // having different document class and module selection between master
+               // and child).
+               for (auto const & name
                             : childbuffer->params().documentClass().outlinerNames())
                        backend.addName(name.first, translateIfPossible(name.second));
        }
@@ -1379,14 +1378,16 @@ void InsetInclude::updateCommand()
 void InsetInclude::updateBuffer(ParIterator const & it, UpdateType utype, bool const deleted)
 {
        file_exist_ = includedFileExist();
-
-       button_.update(screenLabel(), true, false, !file_exist_);
-
-       Buffer const * const childbuffer = getChildBuffer();
+       Buffer const * const childbuffer = loadIfNeeded();
        if (childbuffer) {
-               childbuffer->updateBuffer(Buffer::UpdateChildOnly, utype);
+               if (!checkForRecursiveInclude(childbuffer))
+                       childbuffer->updateBuffer(Buffer::UpdateChildOnly, utype);
+               button_.update(screenLabel(), true, false, recursion_error_);
                return;
        }
+
+       button_.update(screenLabel(), true, false, !file_exist_);
+
        if (!isListings(params()))
                return;