pimpl not needed here

[lyx.git] / src / insets / InsetHyperlink.cpp

diff --git a/src/insets/InsetHyperlink.cpp b/src/insets/InsetHyperlink.cpp
index dfb9e94aef50a30ee60aa54eaff01bdd3fc28b7f..509fedfe7e3b20583040235f95e11f67c93ef4d5 100644 (file)
--- a/src/insets/InsetHyperlink.cpp
+++ b/src/insets/InsetHyperlink.cpp
@@ -20,24 +20,15 @@
 #include "OutputParams.h"
 
 #include "support/lstrings.h"
-
-#include "support/std_ostream.h"
-
-
-namespace lyx {
-
-using support::subst;
+#include "support/docstream.h"
 
 using std::string;
-using std::ostream;
 using std::find;
 using std::replace;
 
-//FIXME: these should be lists of char_type and not char
-static char const * const chars_url[2] = {"%", "#"};
+namespace lyx {
 
-static char const * const chars_name[6] = {
-       "&", "_", "$", "%", "#", "^"};
+using support::subst;
 
 
 InsetHyperlink::InsetHyperlink(InsetCommandParams const & p)
@@ -45,7 +36,7 @@ InsetHyperlink::InsetHyperlink(InsetCommandParams const & p)
 {}
 
 
-CommandInfo const * InsetHyperlink::findInfo(std::string const & /* cmdName */)
+CommandInfo const * InsetHyperlink::findInfo(string const & /* cmdName */)
 {
        static const char * const paramnames[] =
                {"name", "target", "type", ""};
@@ -77,26 +68,27 @@ docstring const InsetHyperlink::getScreenLabel(Buffer const &) const
 int InsetHyperlink::latex(Buffer const &, odocstream & os,
                    OutputParams const & runparams) const
 {
-       //FIXME: all strings in this routine should be docstrings
-       string url = to_utf8(getParam("target"));
-
-       string backslash = "\\";
-       string braces = "{}";
+       docstring url = getParam("target");
+       static docstring const backslash = from_ascii("\\");
+       static docstring const braces = from_ascii("{}");
+       static char_type const chars_url[2] = {'%', '#'};
+       static char_type const chars_name[6] = {
+               '&', '_', '$', '%', '#', '^'};
 
        // The characters in chars_url[] need to be changed to a command when
        // they are in the url field.
        if (!url.empty()) {
                // the chars_url[] characters must be handled for both, url and href
                for (int k = 0; k < 2; k++) {
-                       for (int i = 0, pos;
+                       for (size_t i = 0, pos;
                                (pos = url.find(chars_url[k], i)) != string::npos;
                                i = pos + 2) {
-                               url.replace(pos,1,backslash + chars_url[k]);
+                               url.replace(pos, 1, backslash + chars_url[k]);
                        }
                }
        } // end if (!url.empty())
 
-       string name = to_utf8(getParam("name"));
+       docstring name = getParam("name");
 
        // The characters in chars_name[] need to be changed to a command when
        // they are in the name field.
@@ -104,40 +96,37 @@ int InsetHyperlink::latex(Buffer const &, odocstream & os,
 
                // handle the "\" character, but only when the following character
                // is not also a "\", because "\\" is valid code
-               for (int i = 0, pos;
-                       (pos = name.find("\\", i)) != string::npos;
+               docstring const textbackslash = from_ascii("\\textbackslash{}");
+               for (size_t i = 0, pos;
+                       (pos = name.find('\\', i)) != string::npos;
                        i = pos + 2) {
-                       if      (name[pos+1] != '\\')
-                               name.replace(pos,1,"\\textbackslash{}");
+                       if (name[pos + 1] != '\\')
+                               name.replace(pos, 1, textbackslash);
                }
                for (int k = 0; k < 6; k++) {
-                       for (int i = 0, pos;
+                       for (size_t i = 0, pos;
                                (pos = name.find(chars_name[k], i)) != string::npos;
                                i = pos + 2) {
-                               name.replace(pos,1,backslash + chars_name[k] + braces);
+                               name.replace(pos, 1, backslash + chars_name[k] + braces);
                        }
                }
                // replace the tilde by the \sim character as suggested in the LaTeX FAQ
                // for URLs
-               for (int i = 0, pos;
-                       (pos = name.find("~", i)) != string::npos;
+               docstring const sim = from_ascii("$\\sim$");
+               for (size_t i = 0, pos;
+                       (pos = name.find('~', i)) != string::npos;
                        i = pos + 1)
-                       name.replace(pos,1,"$\\sim$");
+                       name.replace(pos, 1, sim);
 
        }  // end if (!name.empty())
        
-       //for the case there is no name given, the target is set as name
-       string urlname = url;
-       // set the hyperlink type
-       url = to_utf8(getParam("type")) + url;
-
        if (runparams.moving_arg)
                os << "\\protect";
-       //set the target for the name when no name is given
-       if (!name.empty())
-               os << "\\href{" << from_utf8(url) << "}{" << from_utf8(name) << '}';
-       else
-               os << "\\href{" << from_utf8(url) << "}{" << from_utf8(urlname) << '}';
+
+       //for the case there is no name given, the target is set as name
+       os << "\\href{" << getParam("type") << url << "}{"
+               << (name.empty()? url : name) << '}';
+
        return 0;
 }