validate encodable characters in href inset (#8357)

[lyx.git] / src / insets / InsetHyperlink.cpp

diff --git a/src/insets/InsetHyperlink.cpp b/src/insets/InsetHyperlink.cpp
index e3125c3b5291af7e612a005bd14e6d77ddc73371..37692af97a634c65244245908861036357a14206 100644 (file)
--- a/src/insets/InsetHyperlink.cpp
+++ b/src/insets/InsetHyperlink.cpp
@@ -15,6 +15,7 @@
 
 #include "Buffer.h"
 #include "DispatchResult.h"
+#include "Encoding.h"
 #include "Format.h"
 #include "FuncRequest.h"
 #include "FuncStatus.h"
@@ -28,6 +29,8 @@
 #include "support/gettext.h"
 #include "support/lstrings.h"
 
+#include "frontends/alert.h"
+
 using namespace std;
 using namespace lyx::support;
 
@@ -108,8 +111,8 @@ void InsetHyperlink::viewTarget() const
 }
 
 
-int InsetHyperlink::latex(otexstream & os,
-                         OutputParams const & runparams) const
+void InsetHyperlink::latex(otexstream & os,
+                          OutputParams const & runparams) const
 {
        docstring url = getParam("target");
        docstring name = getParam("name");
@@ -185,7 +188,17 @@ int InsetHyperlink::latex(otexstream & os,
                        (pos = name.find('~', i)) != string::npos;
                        i = pos + 1)
                        name.replace(pos, 1, sim);
-
+               pair<docstring, docstring> name_latexed =
+                       runparams.encoding->latexString(name, runparams.dryrun);
+               name = name_latexed.first;
+               if (!name_latexed.second.empty()) {
+                       // issue a warning about omitted characters
+                       // FIXME: should be passed to the error dialog
+                       frontend::Alert::warning(_("Uncodable characters"),
+                               bformat(_("The following characters that are used in the href inset are not\n"
+                                         "representable in the current encoding and therefore have been omitted:\n%1$s."),
+                                       name_latexed.second));
+               }
        }  // end if (!name.empty())
        
        if (runparams.moving_arg)
@@ -193,8 +206,6 @@ int InsetHyperlink::latex(otexstream & os,
 
        // output the ready \href command
        os << "\\href{" << getParam("type") << url << "}{" << name << '}';
-
-       return 0;
 }
 
 
@@ -227,7 +238,8 @@ int InsetHyperlink::docbook(odocstream & os, OutputParams const &) const
 
 docstring InsetHyperlink::xhtml(XHTMLStream & xs, OutputParams const &) const
 {
-       docstring const & target = getParam("target");
+       docstring const & target = 
+               html::htmlize(getParam("target"), XHTMLStream::ESCAPE_AND);
        docstring const & name   = getParam("name");
        xs << html::StartTag("a", to_utf8("href=\"" + target + "\""));
        xs << (name.empty() ? target : name);
@@ -272,9 +284,9 @@ void InsetHyperlink::validate(LaTeXFeatures & features) const
 }
 
 
-docstring InsetHyperlink::contextMenuName() const
+string InsetHyperlink::contextMenuName() const
 {
-       return from_ascii("context-hyperlink");
+       return "context-hyperlink";
 }