]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetExternal.cpp
Fix GRAPHICS_EDIT of InsetGraphics
[lyx.git] / src / insets / InsetExternal.cpp
index 3efc70a6bfd761303787475e9c65dddafe0d8fcc..79d47ca8a519aa2b3ee085b0792cc406c0799c17 100644 (file)
@@ -25,6 +25,7 @@
 #include "FuncRequest.h"
 #include "LaTeXFeatures.h"
 #include "Lexer.h"
+#include "LyX.h" // use_gui
 #include "LyXRC.h"
 #include "MetricsInfo.h"
 #include "OutputParams.h"
@@ -64,8 +65,6 @@ namespace lyx {
 
 namespace Alert = frontend::Alert;
 
-extern bool use_gui;
-
 namespace external {
 
 TempName::TempName()
@@ -182,13 +181,13 @@ void InsetExternalParams::settemplate(string const & name)
 }
 
 
-void InsetExternalParams::write(Buffer const & buffer, ostream & os) const
+void InsetExternalParams::write(Buffer const & buf, ostream & os) const
 {
        os << "External\n"
           << "\ttemplate " << templatename() << '\n';
 
        if (!filename.empty()) {
-               os << "\tfilename " << filename.outputFilename(buffer.filePath()) << '\n';
+               os << "\tfilename " << filename.outputFilename(buf.filePath()) << '\n';
                os << "\tembed " << (filename.embedded() ? filename.inzipName() : "\"\"") << '\n';
        }
        if (display != defaultDisplayType)
@@ -269,9 +268,9 @@ bool InsetExternalParams::read(Buffer const & buffer, Lexer & lex)
                { "clip",            EX_CLIP },
                { "display",         EX_DISPLAY},
                { "draft",           EX_DRAFT},
+               { "embed",           EX_EMBED},
                { "extra",           EX_EXTRA },
                { "filename",        EX_FILENAME},
-               { "embed",           EX_EMBED},
                { "height",          EX_HEIGHT },
                { "keepAspectRatio", EX_KEEPASPECTRATIO },
                { "lyxscale",        EX_LYXSCALE},
@@ -419,15 +418,26 @@ InsetExternal::InsetExternal(InsetExternal const & other)
 {}
 
 
-Inset * InsetExternal::clone() const
+InsetExternal::~InsetExternal()
 {
-       return new InsetExternal(*this);
+       InsetExternalMailer(*this).hideDialog();
 }
 
 
-InsetExternal::~InsetExternal()
+void InsetExternal::setBuffer(Buffer & buffer)
 {
-       InsetExternalMailer(*this).hideDialog();
+       if (buffer_) {
+               try {
+                       // a file may not be copied successfully when, e.g. buffer_
+                       // has already been closed.
+                       params_.filename = params_.filename.copyTo(&buffer);
+               } catch (ExceptionMessage const & message) {
+                       Alert::error(message.title_, message.details_);
+                       // failed to embed
+                       params_.filename.setEmbed(false);
+               }
+       }
+       Inset::setBuffer(buffer);
 }
 
 
@@ -442,27 +452,16 @@ void InsetExternal::doDispatch(Cursor & cur, FuncRequest & cmd)
        switch (cmd.action) {
 
        case LFUN_EXTERNAL_EDIT: {
-               Buffer const & buffer = cur.buffer();
                InsetExternalParams p;
-               InsetExternalMailer::string2params(to_utf8(cmd.argument()), buffer, p);
-               external::editExternal(p, buffer);
+               InsetExternalMailer::string2params(to_utf8(cmd.argument()), buffer(), p);
+               external::editExternal(p, buffer());
                break;
        }
 
        case LFUN_INSET_MODIFY: {
-               Buffer const & buffer = cur.buffer();
                InsetExternalParams p;
-               InsetExternalMailer::string2params(to_utf8(cmd.argument()), buffer, p);
-               if (!p.filename.empty()) {
-                       try {
-                               p.filename.enable(buffer.embedded(), &buffer);
-                       } catch (ExceptionMessage const & message) {
-                               Alert::error(message.title_, message.details_);
-                               // do not set parameter if an error happens
-                               break;
-                       }
-               }
-               setParams(p, buffer);
+               InsetExternalMailer::string2params(to_utf8(cmd.argument()), buffer(), p);
+               setParams(p);
                break;
        }
 
@@ -498,21 +497,15 @@ bool InsetExternal::getStatus(Cursor & cur, FuncRequest const & cmd,
 }
 
 
-void InsetExternal::registerEmbeddedFiles(Buffer const & buffer,
-       EmbeddedFileList & files) const
+void InsetExternal::registerEmbeddedFiles(EmbeddedFileList & files) const
 {
-       files.registerFile(params_.filename, this, buffer);
+       files.registerFile(params_.filename, this, buffer());
 }
 
 
-void InsetExternal::updateEmbeddedFile(Buffer const & buf,
-       EmbeddedFile const & file)
+void InsetExternal::updateEmbeddedFile(EmbeddedFile const & file)
 {
-       // when embedding is enabled, change of embedding status leads to actions
-       EmbeddedFile temp = file;
-       temp.enable(buf.embedded(), &buf);
-       // this will not be set if an exception is thorwn in enable()
-       params_.filename = temp;
+       params_.filename = file;
 }
 
 
@@ -603,7 +596,7 @@ graphics::Params get_grfx_params(InsetExternalParams const & eparams)
 }
 
 
-docstring const getScreenLabel(InsetExternalParams const & params,
+docstring screenLabel(InsetExternalParams const & params,
                            Buffer const & buffer)
 {
        external::Template const * const ptr =
@@ -618,21 +611,51 @@ docstring const getScreenLabel(InsetExternalParams const & params,
                                to_utf8(gui), false));
 }
 
-void add_preview_and_start_loading(RenderMonitoredPreview &,
-                                  InsetExternal const &,
-                                  Buffer const &);
-
 } // namespace anon
 
 
+static bool isPreviewWanted(InsetExternalParams const & params)
+{
+       return params.display == external::PreviewDisplay &&
+               params.filename.isReadableFile();
+}
+
+
+static docstring latexString(InsetExternal const & inset)
+{
+       odocstringstream os;
+       // We don't need to set runparams.encoding since it is not used by
+       // latex().
+       OutputParams runparams(0);
+       runparams.flavor = OutputParams::LATEX;
+       inset.latex(os, runparams);
+       return os.str();
+}
+
+
+static void add_preview_and_start_loading(RenderMonitoredPreview & renderer,
+                                  InsetExternal const & inset,
+                                  Buffer const & buffer)
+{
+       InsetExternalParams const & params = inset.params();
+
+       if (RenderPreview::status() != LyXRC::PREVIEW_OFF &&
+           isPreviewWanted(params)) {
+               renderer.setAbsFile(params.filename);
+               docstring const snippet = latexString(inset);
+               renderer.addPreview(snippet, buffer);
+               renderer.startLoading(buffer);
+       }
+}
+
+
 InsetExternalParams const & InsetExternal::params() const
 {
        return params_;
 }
 
 
-void InsetExternal::setParams(InsetExternalParams const & p,
-                             Buffer const & buffer)
+void InsetExternal::setParams(InsetExternalParams const & p)
 {
        params_ = p;
 
@@ -648,7 +671,7 @@ void InsetExternal::setParams(InsetExternalParams const & p,
                        button_ptr = renderer_->asButton();
                }
 
-               button_ptr->update(getScreenLabel(params_, buffer), true);
+               button_ptr->update(screenLabel(params_, buffer()), true);
                break;
        }
 
@@ -676,7 +699,7 @@ void InsetExternal::setParams(InsetExternalParams const & p,
 
                if (preview_ptr->monitoring())
                        preview_ptr->stopMonitoring();
-               add_preview_and_start_loading(*preview_ptr, *this, buffer);
+               add_preview_and_start_loading(*preview_ptr, *this, buffer());
 
                break;
        }
@@ -698,30 +721,29 @@ void InsetExternal::fileChanged() const
 }
 
 
-void InsetExternal::write(Buffer const & buffer, ostream & os) const
+void InsetExternal::write(ostream & os) const
 {
-       params_.write(buffer, os);
+       params_.write(buffer(), os);
 }
 
 
-void InsetExternal::read(Buffer const & buffer, Lexer & lex)
+void InsetExternal::read(Lexer & lex)
 {
        InsetExternalParams params;
-       if (params.read(buffer, lex)) {
+       if (params.read(buffer(), lex)) {
                // exception handling is not needed as long as embedded files are in place.
-               params.filename.enable(buffer.embedded(), & buffer);
-               setParams(params, buffer);
+               params.filename.enable(buffer().embedded(), &buffer(), false);
+               setParams(params);
        }
 }
 
 
-int InsetExternal::latex(Buffer const & buf, odocstream & os,
-                        OutputParams const & runparams) const
+int InsetExternal::latex(odocstream & os, OutputParams const & runparams) const
 {
        if (params_.draft) {
                // FIXME UNICODE
                os << "\\fbox{\\ttfamily{}"
-                  << from_utf8(params_.filename.outputFilename(buf.filePath()))
+                  << from_utf8(params_.filename.outputFilename(buffer().filePath()))
                   << "}\n";
                return 1;
        }
@@ -747,35 +769,35 @@ int InsetExternal::latex(Buffer const & buf, odocstream & os,
 
                if (cit != et.formats.end()) {
                        return external::writeExternal(params_, "PDFLaTeX",
-                                                      buf, os,
+                                                      buffer(), os,
                                                       *(runparams.exportdata),
                                                       external_in_tmpdir,
                                                       dryrun);
                }
        }
 
-       return external::writeExternal(params_, "LaTeX", buf, os,
+       return external::writeExternal(params_, "LaTeX", buffer(), os,
                                       *(runparams.exportdata),
                                       external_in_tmpdir,
                                       dryrun);
 }
 
 
-int InsetExternal::plaintext(Buffer const & buf, odocstream & os,
+int InsetExternal::plaintext(odocstream & os,
                             OutputParams const & runparams) const
 {
        os << '\n'; // output external material on a new line
-       external::writeExternal(params_, "Ascii", buf, os,
+       external::writeExternal(params_, "Ascii", buffer(), os,
                                *(runparams.exportdata), false,
                                runparams.dryrun || runparams.inComment);
        return PLAINTEXT_NEWLINE;
 }
 
 
-int InsetExternal::docbook(Buffer const & buf, odocstream & os,
+int InsetExternal::docbook(odocstream & os,
                           OutputParams const & runparams) const
 {
-       return external::writeExternal(params_, "DocBook", buf, os,
+       return external::writeExternal(params_, "DocBook", buffer(), os,
                                       *(runparams.exportdata), false,
                                       runparams.dryrun || runparams.inComment);
 }
@@ -833,54 +855,15 @@ void InsetExternal::validate(LaTeXFeatures & features) const
 // preview stuff
 //
 
-namespace {
-
-bool preview_wanted(InsetExternalParams const & params)
-{
-       return params.display == external::PreviewDisplay &&
-               params.filename.isReadableFile();
-}
-
-
-docstring const latex_string(InsetExternal const & inset, Buffer const & buffer)
-{
-       odocstringstream os;
-       // We don't need to set runparams.encoding since it is not used by
-       // latex().
-       OutputParams runparams(0);
-       runparams.flavor = OutputParams::LATEX;
-       inset.latex(buffer, os, runparams);
-       return os.str();
-}
-
-
-void add_preview_and_start_loading(RenderMonitoredPreview & renderer,
-                                  InsetExternal const & inset,
-                                  Buffer const & buffer)
-{
-       InsetExternalParams const & params = inset.params();
-
-       if (RenderPreview::status() != LyXRC::PREVIEW_OFF &&
-           preview_wanted(params)) {
-               renderer.setAbsFile(params.filename);
-               docstring const snippet = latex_string(inset, buffer);
-               renderer.addPreview(snippet, buffer);
-               renderer.startLoading(buffer);
-       }
-}
-
-} // namespace anon
-
-
 void InsetExternal::addPreview(graphics::PreviewLoader & ploader) const
 {
        RenderMonitoredPreview * const ptr = renderer_->asMonitoredPreview();
        if (!ptr)
                return;
 
-       if (preview_wanted(params())) {
+       if (isPreviewWanted(params())) {
                ptr->setAbsFile(params_.filename);
-               docstring const snippet = latex_string(*this, ploader.buffer());
+               docstring const snippet = latexString(*this);
                ptr->addPreview(snippet, ploader);
        }
 }