Remove unsafe method FileName::tempName()

[lyx.git] / src / insets / InsetExternal.cpp

diff --git a/src/insets/InsetExternal.cpp b/src/insets/InsetExternal.cpp
index 50c6e4be87d1013cb5c1f701ed8af1a06a420033..2e97fc07055bd504c859f044529582c2a28a603d 100644 (file)
--- a/src/insets/InsetExternal.cpp
+++ b/src/insets/InsetExternal.cpp
@@ -45,6 +45,7 @@
 #include "support/lassert.h"
 #include "support/lstrings.h"
 #include "support/lyxlib.h"
+#include "support/TempFile.h"
 
 #include <sstream>
 #include <vector>
@@ -67,33 +68,39 @@ namespace Alert = frontend::Alert;
 
 namespace external {
 
-TempName::TempName()
+TempName::TempName() : tempfile_(new support::TempFile("lyxextXXXXXX.tmp"))
 {
-       FileName const tempname = FileName::tempName("lyxext");
        // must have an extension for the converter code to work correctly.
-       tempname_ = FileName(tempname.absFileName() + ".tmp");
 }
 
 
-TempName::TempName(TempName const &)
+TempName::TempName(TempName const & that) : tempfile_(0)
 {
-       tempname_ = TempName()();
+       *this = that;
 }
 
 
 TempName::~TempName()
 {
-       tempname_.removeFile();
+       delete tempfile_;
 }
 
 
 TempName & TempName::operator=(TempName const & other)
 {
-       if (this != &other)
-               tempname_ = TempName()();
+       if (this != &other) {
+               delete tempfile_;
+               tempfile_ = new support::TempFile("lyxextXXXXXX.tmp");
+       }
        return *this;
 }
 
+
+support::FileName TempName::operator()() const
+{
+       return tempfile_->name();
+}
+
 } // namespace external