]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetCollapsable.cpp
Revert r27129. We can't get rid of these until we have something else positive to do.
[lyx.git] / src / insets / InsetCollapsable.cpp
index 6135a63545e69494301a66ba7928e58729a98007..84eb4e319b21c822e8e90adf5226743953f51774 100644 (file)
 #include "Dimension.h"
 #include "DispatchResult.h"
 #include "FloatList.h"
+#include "FuncRequest.h"
 #include "FuncStatus.h"
 #include "InsetLayout.h"
 #include "Language.h"
 #include "LaTeXFeatures.h"
 #include "Lexer.h"
-#include "FuncRequest.h"
 #include "MetricsInfo.h"
 #include "ParagraphParameters.h"
 #include "TextClass.h"
 #include "support/debug.h"
 #include "support/docstream.h"
 #include "support/gettext.h"
+#include "support/lassert.h"
 
 using namespace std;
 
-namespace lyx {
 
+namespace lyx {
 
 InsetCollapsable::CollapseStatus InsetCollapsable::status() const
 {
+       if (decoration() == InsetLayout::CONGLOMERATE)
+               return status_;
        return autoOpen_ ? Open : status_;
 }
 
@@ -52,22 +55,18 @@ InsetCollapsable::CollapseStatus InsetCollapsable::status() const
 InsetCollapsable::Geometry InsetCollapsable::geometry() const
 {
        switch (decoration()) {
-       case Deco_Classic:
-               if (status() == Open) {
-                       if (openinlined_)
-                               return LeftButton;
-                       else
-                               return TopButton;
-               } else
-                       return ButtonOnly;
+       case InsetLayout::CLASSIC:
+               if (status() == Open)
+                       return openinlined_ ? LeftButton : TopButton;
+               return ButtonOnly;
 
-       case Deco_Minimalistic:
+       case InsetLayout::MINIMALISTIC:
                return status() == Open ? NoButton : ButtonOnly ;
 
-       case Deco_Conglomerate:
+       case InsetLayout::CONGLOMERATE:
                return status() == Open ? SubLabel : Corners ;
 
-       case Deco_Default:
+       case InsetLayout::DEFAULT:
                break; // this shouldn't happen
        }
 
@@ -77,22 +76,21 @@ InsetCollapsable::Geometry InsetCollapsable::geometry() const
 }
 
 
-InsetCollapsable::InsetCollapsable(BufferParams const & bp,
-               CollapseStatus status, TextClassPtr tc)
-       : InsetText(bp), status_(status),
+InsetCollapsable::InsetCollapsable(Buffer const & buf)
+       : InsetText(buf), status_(Inset::Open),
          openinlined_(false), autoOpen_(false), mouse_hover_(false)
 {
-       setLayout(tc);
+       DocumentClass const & dc = buf.params().documentClass();
+       setLayout(&dc);
        setAutoBreakRows(true);
        setDrawFrame(true);
        setFrameColor(Color_collapsableframe);
-       paragraphs().back().layout(bp.getTextClass().emptyLayout());
+       paragraphs().back().setLayout(dc.plainLayout()); 
 }
 
 
 InsetCollapsable::InsetCollapsable(InsetCollapsable const & rhs)
        : InsetText(rhs),
-               textClass_(rhs.textClass_),
                layout_(rhs.layout_),
                labelstring_(rhs.labelstring_),
                button_dim(rhs.button_dim),
@@ -109,34 +107,34 @@ docstring InsetCollapsable::toolTip(BufferView const & bv, int x, int y) const
 {
        Dimension dim = dimensionCollapsed();
        if (geometry() == NoButton)
-               return layout_->labelstring();
-       else if (x > xo(bv) + dim.wid || y > yo(bv) + dim.des)
+               return translateIfPossible(layout_->labelstring());
+       if (x > xo(bv) + dim.wid || y > yo(bv) + dim.des || isOpen())
                return docstring();
 
-       switch (status_) {
-       case Open:
-               return _("Left-click to collapse the inset");
-       case Collapsed:
-               return _("Left-click to open the inset");
-       }
-       return docstring();
+       OutputParams rp(&buffer().params().encoding());
+       odocstringstream ods;
+       InsetText::plaintext(ods, rp);
+       docstring content_tip = ods.str();
+       // shorten it if necessary
+       if (content_tip.size() > 200)
+               content_tip = content_tip.substr(0, 200) + "...";
+       return content_tip;
 }
 
 
 void InsetCollapsable::setLayout(BufferParams const & bp)
 {
-       setLayout(bp.getTextClassPtr());
+       setLayout(bp.documentClassPtr());
 }
 
 
-void InsetCollapsable::setLayout(TextClassPtr tc)
+void InsetCollapsable::setLayout(DocumentClass const * const dc)
 {
-       textClass_ = tc;
-       if ( tc.get() != 0 ) {
-               layout_ = &tc->insetlayout(name());
-               labelstring_ = layout_->labelstring();
+       if (dc) {
+               layout_ = &(dc->insetLayout(name()));
+               labelstring_ = translateIfPossible(layout_->labelstring());
        } else {
-               layout_ = &TextClass::emptyInsetLayout();
+               layout_ = &DocumentClass::plainInsetLayout();
                labelstring_ = _("UNDEFINED");
        }
 
@@ -144,7 +142,7 @@ void InsetCollapsable::setLayout(TextClassPtr tc)
 }
 
 
-void InsetCollapsable::write(Buffer const & buf, ostream & os) const
+void InsetCollapsable::write(ostream & os) const
 {
        os << "status ";
        switch (status_) {
@@ -156,45 +154,25 @@ void InsetCollapsable::write(Buffer const & buf, ostream & os) const
                break;
        }
        os << "\n";
-       text_.write(buf, os);
+       text().write(buffer(), os);
 }
 
 
-void InsetCollapsable::read(Buffer const & buf, Lexer & lex)
+void InsetCollapsable::read(Lexer & lex)
 {
-       bool token_found = false;
-       if (lex.isOK()) {
-               lex.next();
-               string const token = lex.getString();
-               if (token == "status") {
-                       lex.next();
-                       string const tmp_token = lex.getString();
-
-                       if (tmp_token == "collapsed") {
-                               status_ = Collapsed;
-                               token_found = true;
-                       } else if (tmp_token == "open") {
-                               status_ = Open;
-                               token_found = true;
-                       } else {
-                               lyxerr << "InsetCollapsable::read: Missing status!"
-                                      << endl;
-                               // Take countermeasures
-                               lex.pushToken(token);
-                       }
-               } else {
-                       LYXERR0("InsetCollapsable::read: Missing 'status'-tag!");
-                       // take countermeasures
-                       lex.pushToken(token);
-               }
-       }
-       //this must be set before we enter InsetText::read()
-       setLayout(buf.params());
-
-       InsetText::read(buf, lex);
+       lex.setContext("InsetCollapsable::read");
+       string tmp_token;
+       status_ = Collapsed;
+       lex >> "status" >> tmp_token;
+       if (tmp_token == "open")
+               status_ = Open;
 
-       if (!token_found)
-               status_ = isOpen() ? Open : Collapsed;
+       // this must be set before we enter InsetText::read()
+       setLayout(buffer().params());
+       InsetText::read(lex);
+       // set button label again as the inset contents was not read yet at
+       // setLayout() time.
+       setButtonLabel();
 
        // Force default font, if so requested
        // This avoids paragraphs in buffer language that would have a
@@ -209,7 +187,7 @@ void InsetCollapsable::read(Buffer const & buf, Lexer & lex)
 
 Dimension InsetCollapsable::dimensionCollapsed() const
 {
-       BOOST_ASSERT(layout_);
+       LASSERT(layout_, /**/);
        Dimension dim;
        theFontMetrics(layout_->labelfont()).buttonText(
                labelstring_, dim.wid, dim.asc, dim.des);
@@ -219,7 +197,7 @@ Dimension InsetCollapsable::dimensionCollapsed() const
 
 void InsetCollapsable::metrics(MetricsInfo & mi, Dimension & dim) const
 {
-       BOOST_ASSERT(layout_);
+       LASSERT(layout_, /**/);
 
        autoOpen_ = mi.base.bv->cursor().isInside(this);
 
@@ -254,8 +232,7 @@ void InsetCollapsable::metrics(MetricsInfo & mi, Dimension & dim) const
        case LeftButton:
        case ButtonOnly:
                dim = dimensionCollapsed();
-               if (geometry() == TopButton
-                || geometry() == LeftButton) {
+               if (geometry() == TopButton || geometry() == LeftButton) {
                        Dimension textdim;
                        InsetText::metrics(mi, textdim);
                        openinlined_ = (textdim.wid + dim.wid) < mi.base.textwidth;
@@ -285,11 +262,9 @@ bool InsetCollapsable::setMouseHover(bool mouse_hover)
 
 void InsetCollapsable::draw(PainterInfo & pi, int x, int y) const
 {
-       BOOST_ASSERT(layout_);
+       LASSERT(layout_, /**/);
 
        autoOpen_ = pi.base.bv->cursor().isInside(this);
-       ColorCode const old_color = pi.background_color;
-       pi.background_color = backgroundColor();
 
        FontInfo tmpfont = pi.base.font;
        pi.base.font = layout_->font();
@@ -366,8 +341,8 @@ void InsetCollapsable::draw(PainterInfo & pi, int x, int y) const
                                xx2, y + desc,
                                layout_->labelfont().color());
                }
-               pi.pain.line(x + textdim.wid - 3, y + desc, x + textdim.wid - 3, y + desc - 4,
-                       layout_->labelfont().color());
+               pi.pain.line(x + textdim.wid - 3, y + desc, x + textdim.wid - 3, 
+                       y + desc - 4, layout_->labelfont().color());
 
                // the label below the text. Can be toggled.
                if (geometry() == SubLabel) {
@@ -399,7 +374,6 @@ void InsetCollapsable::draw(PainterInfo & pi, int x, int y) const
                }
                break;
        }
-       pi.background_color = old_color;
 
        pi.base.font = tmpfont;
 }
@@ -410,7 +384,7 @@ void InsetCollapsable::cursorPos(BufferView const & bv,
 {
        if (geometry() == ButtonOnly)
                status_ = Open;
-       BOOST_ASSERT(geometry() != ButtonOnly);
+       LASSERT(geometry() != ButtonOnly, /**/);
 
        InsetText::cursorPos(bv, sl, boundary, x, y);
        Dimension const textdim = InsetText::dimension(bv);
@@ -437,7 +411,7 @@ void InsetCollapsable::cursorPos(BufferView const & bv,
 
 Inset::EDITABLE InsetCollapsable::editable() const
 {
-       return geometry() != ButtonOnly? HIGHLY_EDITABLE : IS_EDITABLE;
+       return geometry() != ButtonOnly ? HIGHLY_EDITABLE : IS_EDITABLE;
 }
 
 
@@ -501,21 +475,23 @@ void InsetCollapsable::doDispatch(Cursor & cur, FuncRequest & cmd)
 
        switch (cmd.action) {
        case LFUN_MOUSE_PRESS:
-               if (cmd.button() == mouse_button::button1 
-                && hitButton(cmd) 
-                && geometry() != NoButton) {
-                       // reset selection if necessary (see bug 3060)
-                       if (cur.selection())
-                               cur.bv().cursor().clearSelection();
-                       else
+               if (hitButton(cmd)) {
+                       switch (cmd.button()) {
+                       case mouse_button::button1:
+                       case mouse_button::button3:
+                               // Pass the command to the enclosing InsetText,
+                               // so that the cursor gets set.
+                               cur.undispatched();
+                               break;
+                       case mouse_button::none:
+                       case mouse_button::button2:
+                       case mouse_button::button4:
+                       case mouse_button::button5:
+                               // Nothing to do.
                                cur.noUpdate();
-                       cur.dispatched();
-                       break;
-               }
-               if (geometry() == NoButton)
-                       InsetText::doDispatch(cur, cmd);
-               else if (geometry() != ButtonOnly 
-                    && !hitButton(cmd))
+                               break;
+                       }
+               } else if (geometry() != ButtonOnly)
                        InsetText::doDispatch(cur, cmd);
                else
                        cur.undispatched();
@@ -524,66 +500,43 @@ void InsetCollapsable::doDispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_MOUSE_MOTION:
        case LFUN_MOUSE_DOUBLE:
        case LFUN_MOUSE_TRIPLE:
-               if (geometry() == NoButton)
-                       InsetText::doDispatch(cur, cmd);
-               else if (geometry() != ButtonOnly
-                    && !hitButton(cmd))
+               if (hitButton(cmd)) 
+                       cur.noUpdate();
+               else if (geometry() != ButtonOnly)
                        InsetText::doDispatch(cur, cmd);
                else
                        cur.undispatched();
                break;
 
        case LFUN_MOUSE_RELEASE:
-               if (cmd.button() == mouse_button::button3) {
-                       // There is no button to right click:
-                       if (decoration() == Deco_Minimalistic ||
-                           geometry() == Corners ||
-                           geometry() == SubLabel ||
-                           geometry() == NoButton
-                          )  {
-                               if (status_ == Open)
-                                       setStatus(cur, Collapsed);
-                               else
-                                       setStatus(cur, Open);
-                               break;
-                       } else {
-                               // Open the Inset 
-                               // configuration dialog
-                               showInsetDialog(&cur.bv());
-                               break;
-                       }
-               }
-
-               if (geometry() == NoButton) {
+               if (!hitButton(cmd)) {
                        // The mouse click has to be within the inset!
-                       InsetText::doDispatch(cur, cmd);
+                       if (geometry() != ButtonOnly)
+                               InsetText::doDispatch(cur, cmd);
+                       else
+                               cur.undispatched();                     
                        break;
                }
-
-               if (cmd.button() == mouse_button::button1 && hitButton(cmd)) {
-                       // if we are selecting, we do not want to
-                       // toggle the inset.
-                       if (cur.selection())
-                               break;
-                       // Left button is clicked, the user asks to
-                       // toggle the inset visual state.
-                       cur.dispatched();
-                       cur.updateFlags(Update::Force | Update::FitCursor);
-                       if (geometry() == ButtonOnly) {
-                               setStatus(cur, Open);
-                               edit(cur, true);
-                       }
-                       else {
-                               setStatus(cur, Collapsed);
-                       }
-                       cur.bv().cursor() = cur;
+               if (cmd.button() != mouse_button::button1) {
+                       // Nothing to do.
+                       cur.noUpdate();
                        break;
                }
-
-               // The mouse click is within the opened inset.
-               if (geometry() == TopButton
-                || geometry() == LeftButton)
-                       InsetText::doDispatch(cur, cmd);
+               // if we are selecting, we do not want to
+               // toggle the inset.
+               if (cur.selection())
+                       break;
+               // Left button is clicked, the user asks to
+               // toggle the inset visual state.
+               cur.dispatched();
+               cur.updateFlags(Update::Force | Update::FitCursor);
+               if (geometry() == ButtonOnly) {
+                       setStatus(cur, Open);
+                       edit(cur, true);
+               }
+               else
+                       setStatus(cur, Collapsed);
+               cur.bv().cursor() = cur;
                break;
 
        case LFUN_INSET_TOGGLE:
@@ -660,7 +613,10 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
                FuncStatus & flag) const
 {
        switch (cmd.action) {
-       // suppress these
+       // FIXME At present, these are being enabled and disabled according to
+       // whether PASSTHRU has been set in the InsetLayout. This makes some
+       // sense, but there are other checks that should really be done. E.g.,
+       // one should not be able to inset IndexPrint inside an optional argument!!
        case LFUN_ACCENT_ACUTE:
        case LFUN_ACCENT_BREVE:
        case LFUN_ACCENT_CARON:
@@ -672,35 +628,31 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_ACCENT_HUNGARIAN_UMLAUT:
        case LFUN_ACCENT_MACRON:
        case LFUN_ACCENT_OGONEK:
-       case LFUN_ACCENT_SPECIAL_CARON:
        case LFUN_ACCENT_TIE:
        case LFUN_ACCENT_TILDE:
        case LFUN_ACCENT_UMLAUT:
        case LFUN_ACCENT_UNDERBAR:
        case LFUN_ACCENT_UNDERDOT:
        case LFUN_APPENDIX:
-       case LFUN_BIBITEM_INSERT:
        case LFUN_BOX_INSERT:
        case LFUN_BRANCH_INSERT:
-       case LFUN_NEW_LINE:
+       case LFUN_NEWLINE_INSERT:
        case LFUN_CAPTION_INSERT:
-       case LFUN_CLEARPAGE_INSERT:
-       case LFUN_CLEARDOUBLEPAGE_INSERT:
        case LFUN_DEPTH_DECREMENT:
        case LFUN_DEPTH_INCREMENT:
-       case LFUN_ENVIRONMENT_INSERT:
        case LFUN_ERT_INSERT:
        case LFUN_FILE_INSERT:
        case LFUN_FLEX_INSERT:
        case LFUN_FLOAT_INSERT:
-       case LFUN_FLOAT_LIST:
+       case LFUN_FLOAT_LIST_INSERT:
        case LFUN_FLOAT_WIDE_INSERT:
        case LFUN_FONT_BOLD:
+       case LFUN_FONT_BOLDSYMBOL:
        case LFUN_FONT_TYPEWRITER:
        case LFUN_FONT_DEFAULT:
        case LFUN_FONT_EMPH:
-       case LFUN_FONT_FREE_APPLY:
-       case LFUN_FONT_FREE_UPDATE:
+       case LFUN_TEXTSTYLE_APPLY:
+       case LFUN_TEXTSTYLE_UPDATE:
        case LFUN_FONT_NOUN:
        case LFUN_FONT_ROMAN:
        case LFUN_FONT_SANS:
@@ -710,7 +662,6 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_FONT_STATE:
        case LFUN_FONT_UNDERLINE:
        case LFUN_FOOTNOTE_INSERT:
-       case LFUN_HFILL_INSERT:
        case LFUN_HYPERLINK_INSERT:
        case LFUN_INDEX_INSERT:
        case LFUN_INDEX_PRINT:
@@ -719,9 +670,6 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_LABEL_INSERT:
        case LFUN_LINE_INSERT:
        case LFUN_NEWPAGE_INSERT:
-       case LFUN_PAGEBREAK_INSERT:
-       case LFUN_LAYOUT:
-       case LFUN_LAYOUT_PARAGRAPH:
        case LFUN_LAYOUT_TABULAR:
        case LFUN_MARGINALNOTE_INSERT:
        case LFUN_MATH_DISPLAY:
@@ -735,10 +683,6 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_NOTE_INSERT:
        case LFUN_NOTE_NEXT:
        case LFUN_OPTIONAL_INSERT:
-       case LFUN_PARAGRAPH_PARAMS:
-       case LFUN_PARAGRAPH_PARAMS_APPLY:
-       case LFUN_PARAGRAPH_SPACING:
-       case LFUN_PARAGRAPH_UPDATE:
        case LFUN_REFERENCE_NEXT:
        case LFUN_SERVER_GOTO_FILE_ROW:
        case LFUN_SERVER_NOTIFY:
@@ -748,27 +692,30 @@ bool InsetCollapsable::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_TABULAR_INSERT:
        case LFUN_TOC_INSERT:
        case LFUN_WRAP_INSERT:
-       if (layout_->isPassThru()) {
-               flag.enabled(false);
-               return true;
-       } else
+               if (layout_->isPassThru()) {
+                       flag.setEnabled(false);
+                       return true;
+               }
                return InsetText::getStatus(cur, cmd, flag);
 
        case LFUN_INSET_TOGGLE:
-               if (cmd.argument() == "open" || cmd.argument() == "close" ||
-                   cmd.argument() == "toggle")
-                       flag.enabled(true);
-               else
-                       flag.enabled(false);
+               if (cmd.argument() == "open")
+                       flag.setEnabled(status_ != Open);
+               else if (cmd.argument() == "close")
+                       flag.setEnabled(status_ == Open);
+               else if (cmd.argument() == "toggle" || cmd.argument().empty()) {
+                       flag.setEnabled(true);
+                       flag.setOnOff(status_ == Open);
+               } else
+                       flag.setEnabled(false);
                return true;
 
        case LFUN_LANGUAGE:
-               flag.enabled(!layout_->isForceLtr());
+               flag.setEnabled(!layout_->isForceLtr());
                return InsetText::getStatus(cur, cmd, flag);
 
        case LFUN_BREAK_PARAGRAPH:
-       case LFUN_BREAK_PARAGRAPH_SKIP:
-               flag.enabled(layout_->isMultiPar());
+               flag.setEnabled(layout_->isMultiPar());
                return true;
 
        default:
@@ -787,57 +734,43 @@ void InsetCollapsable::setStatus(Cursor & cur, CollapseStatus status)
 {
        status_ = status;
        setButtonLabel();
-       if (status_ == Collapsed)
+       if (status_ == Collapsed) {
                cur.leaveInset(*this);
+               mouse_hover_ = false;
+       }
 }
 
 
-docstring InsetCollapsable::floatName(string const & type, BufferParams const & bp) const
+docstring InsetCollapsable::floatName(
+               string const & type, BufferParams const & bp) const
 {
-       FloatList const & floats = bp.getTextClass().floats();
+       FloatList const & floats = bp.documentClass().floats();
        FloatList::const_iterator it = floats[type];
        // FIXME UNICODE
        return (it == floats.end()) ? from_ascii(type) : bp.B_(it->second.name());
 }
 
 
-InsetDecoration InsetCollapsable::decoration() const
+InsetLayout::InsetDecoration InsetCollapsable::decoration() const
 {
        if (!layout_)
-               return Deco_Classic;
-       InsetDecoration const dec = layout_->decoration();
+               return InsetLayout::CLASSIC;
+       InsetLayout::InsetDecoration const dec = layout_->decoration();
        switch (dec) {
-       case Deco_Classic:
-       case Deco_Minimalistic:
-       case Deco_Conglomerate:
+       case InsetLayout::CLASSIC:
+       case InsetLayout::MINIMALISTIC:
+       case InsetLayout::CONGLOMERATE:
                return dec;
-       case Deco_Default:
+       case InsetLayout::DEFAULT:
                break;
        }
        if (lyxCode() == FLEX_CODE)
-               // FIXME: Is this really necessary?
-               return Deco_Conglomerate;
-       return Deco_Classic;
+               return InsetLayout::CONGLOMERATE;
+       return InsetLayout::CLASSIC;
 }
 
 
-bool InsetCollapsable::isMacroScope(Buffer const &) const
-{
-       // layout_ == 0 leads to no latex output, so ignore 
-       // the macros outside
-       if (!layout_)
-               return true;
-
-       // see InsetCollapsable::latex(...) below. In these case
-       // an environment is opened there
-       if (!layout_->latexname().empty())
-               return true;
-
-       return false;
-}
-
-
-int InsetCollapsable::latex(Buffer const & buf, odocstream & os,
+int InsetCollapsable::latex(odocstream & os,
                          OutputParams const & runparams) const
 {
        // FIXME: What should we do layout_ is 0?
@@ -851,7 +784,7 @@ int InsetCollapsable::latex(Buffer const & buf, odocstream & os,
        // collapsable insets should not redefine this, non-standard ones may
        // call this.
        if (!layout_->latexname().empty()) {
-               if (layout_->latextype() == "command") {
+               if (layout_->latextype() == InsetLayout::COMMAND) {
                        // FIXME UNICODE
                        if (runparams.moving_arg)
                                os << "\\protect";
@@ -859,7 +792,7 @@ int InsetCollapsable::latex(Buffer const & buf, odocstream & os,
                        if (!layout_->latexparam().empty())
                                os << from_utf8(layout_->latexparam());
                        os << '{';
-               } else if (layout_->latextype() == "environment") {
+               } else if (layout_->latextype() == InsetLayout::ENVIRONMENT) {
                        os << "%\n\\begin{" << from_utf8(layout_->latexname()) << "}\n";
                        if (!layout_->latexparam().empty())
                                os << from_utf8(layout_->latexparam());
@@ -870,11 +803,11 @@ int InsetCollapsable::latex(Buffer const & buf, odocstream & os,
                rp.verbatim = true;
        if (layout_->isNeedProtect())
                rp.moving_arg = true;
-       int i = InsetText::latex(buf, os, rp);
+       int i = InsetText::latex(os, rp);
        if (!layout_->latexname().empty()) {
-               if (layout_->latextype() == "command") {
+               if (layout_->latextype() == InsetLayout::COMMAND) {
                        os << "}";
-               } else if (layout_->latextype() == "environment") {
+               } else if (layout_->latextype() == InsetLayout::ENVIRONMENT) {
                        os << "\n\\end{" << from_utf8(layout_->latexname()) << "}\n";
                        i += 4;
                }
@@ -885,11 +818,10 @@ int InsetCollapsable::latex(Buffer const & buf, odocstream & os,
 
 void InsetCollapsable::validate(LaTeXFeatures & features) const
 {
-       if (!layout_)
-               return;
-
-       // Force inclusion of preamble snippet in layout file
-       features.require(to_utf8(layout_->name()));
+       string const preamble = getLayout().preamble();
+       if (!preamble.empty())
+               features.addPreambleSnippet(preamble);
+       features.require(getLayout().requires());
        InsetText::validate(features);
 }
 
@@ -897,8 +829,24 @@ void InsetCollapsable::validate(LaTeXFeatures & features) const
 bool InsetCollapsable::undefined() const
 {
        docstring const & n = getLayout().name();
-       return n.empty() || n == TextClass::emptyInsetLayout().name();
+       return n.empty() || n == DocumentClass::plainInsetLayout().name();
 }
 
 
+docstring InsetCollapsable::contextMenu(BufferView const & bv, int x,
+       int y) const
+{
+       if (decoration() == InsetLayout::CONGLOMERATE)
+               return from_ascii("context-conglomerate");
+
+       if (geometry() == NoButton)
+               return from_ascii("context-collapsable");
+
+       Dimension dim = dimensionCollapsed();
+       if (x < xo(bv) + dim.wid && y < yo(bv) + dim.des)
+               return from_ascii("context-collapsable");
+
+       return InsetText::contextMenu(bv, x, y);
+}
+
 } // namespace lyx