Properly terminate command

[lyx.git] / src / insets / InsetCitation.cpp

diff --git a/src/insets/InsetCitation.cpp b/src/insets/InsetCitation.cpp
index ba45f691a37cbe0cef69fdab1313ca90e6e2c02a..564ea5bb9a5e75b1b72516c4a2aa22bd2a8b5916 100644 (file)
--- a/src/insets/InsetCitation.cpp
+++ b/src/insets/InsetCitation.cpp
@@ -329,15 +329,17 @@ inline docstring wrapCitation(docstring const & key,
 } // anonymous namespace
 
 
-map<docstring, docstring> InsetCitation::getQualifiedLists(docstring const p) const
+vector<pair<docstring, docstring>> InsetCitation::getQualifiedLists(docstring const p) const
 {
        vector<docstring> ps =
                getVectorFromString(p, from_ascii("\t"));
-       std::map<docstring, docstring> res;
+       QualifiedList res;
        for (docstring const & s: ps) {
-               docstring key;
-               docstring val = split(s, key, ' ');
-               res[key] = val;
+               docstring key = s;
+               docstring val;
+               if (contains(s, ' '))
+                       val = split(s, key, ' ');
+               res.push_back(make_pair(key, val));
        }
        return res;
 }
@@ -399,8 +401,8 @@ docstring InsetCitation::complexLabel(bool for_xhtml) const
                && (keys.size() > 1
                    || !getParam("pretextlist").empty()
                    || !getParam("posttextlist").empty());
-       map<docstring, docstring> pres = getQualifiedLists(getParam("pretextlist"));
-       map<docstring, docstring> posts = getQualifiedLists(getParam("posttextlist"));
+       QualifiedList pres = getQualifiedLists(getParam("pretextlist"));
+       QualifiedList posts = getQualifiedLists(getParam("posttextlist"));
 
        CiteItem ci;
        ci.textBefore = getParam("before");
@@ -443,6 +445,18 @@ docstring InsetCitation::basicLabel(bool for_xhtml) const
        return '[' + label + ']';
 }
 
+
+bool InsetCitation::forceLTR(OutputParams const & rp) const
+{
+       // We have to force LTR for numeric references
+       // [= bibliography, plain BibTeX, numeric natbib
+       // and biblatex]. Except for XeTeX/bidi. See #3005.
+       if (rp.useBidiPackage())
+               return false;
+       return (buffer().masterParams().citeEngine() == "basic"
+               || buffer().masterParams().citeEngineType() == ENGINE_TYPE_NUMERICAL);
+}
+
 docstring InsetCitation::screenLabel() const
 {
        return cache.screen_label;
@@ -458,8 +472,8 @@ void InsetCitation::updateBuffer(ParIterator const &, UpdateType)
        cache.recalculate = false;
        cache.generated_label = glabel;
        unsigned int const maxLabelChars = 45;
-       cache.screen_label = glabel.substr(0, maxLabelChars + 1);
-       support::truncateWithEllipsis(cache.screen_label, maxLabelChars);
+       cache.screen_label = glabel;
+       support::truncateWithEllipsis(cache.screen_label, maxLabelChars, true);
 }
 
 
@@ -611,12 +625,30 @@ void InsetCitation::latex(otexstream & os, OutputParams const & runparams) const
                os << '{' << escape(cleanupWhitespace(key)) << '}';
        else {
                if (qualified) {
-                       map<docstring, docstring> pres = getQualifiedLists(getParam("pretextlist"));
-                       map<docstring, docstring> posts = getQualifiedLists(getParam("posttextlist"));
-                       for (docstring const & k: keys) {
-                               docstring bef = params().prepareCommand(runparams, pres[k],
+                       QualifiedList pres = getQualifiedLists(getParam("pretextlist"));
+                       QualifiedList posts = getQualifiedLists(getParam("posttextlist"));
+                       for (docstring const & k : keys) {
+                               docstring prenote;
+                               QualifiedList::iterator it = pres.begin();
+                               for (; it != pres.end() ; ++it) {
+                                       if ((*it).first == k) {
+                                               prenote = (*it).second;
+                                               pres.erase(it);
+                                               break;
+                                       }
+                               }
+                               docstring bef = params().prepareCommand(runparams, prenote,
                                                   pinfo["pretextlist"].handling());
-                               docstring aft = params().prepareCommand(runparams, posts[k],
+                               docstring postnote;
+                               QualifiedList::iterator pit = posts.begin();
+                               for (; pit != posts.end() ; ++pit) {
+                                       if ((*pit).first == k) {
+                                               postnote = (*pit).second;
+                                               posts.erase(pit);
+                                               break;
+                                       }
+                               }
+                               docstring aft = params().prepareCommand(runparams, postnote,
                                                   pinfo["posttextlist"].handling());
                                if (!bef.empty())
                                        os << '[' << protectArgument(bef)