]> git.lyx.org Git - lyx.git/blobdiff - src/insets/InsetBibtex.cpp
Context menu item to add unknown branch (rest of #7643)
[lyx.git] / src / insets / InsetBibtex.cpp
index 09ea999b5aae223794175377b6829154a8529440..8f33a2de3c37ca2c2c1501cc7028aaedac1b0c11 100644 (file)
 
 #include "InsetBibtex.h"
 
+#include "BiblioInfo.h"
 #include "Buffer.h"
 #include "BufferParams.h"
+#include "Cursor.h"
 #include "DispatchResult.h"
-#include "EmbeddedFiles.h"
 #include "Encoding.h"
+#include "Exporter.h"
+#include "Format.h"
 #include "FuncRequest.h"
+#include "FuncStatus.h"
+#include "Language.h"
 #include "LaTeXFeatures.h"
-#include "MetricsInfo.h"
+#include "output_xhtml.h"
 #include "OutputParams.h"
+#include "PDFOptions.h"
 #include "TextClass.h"
 
 #include "frontends/alert.h"
 
+#include "support/convert.h"
 #include "support/debug.h"
 #include "support/docstream.h"
 #include "support/ExceptionMessage.h"
+#include "support/FileNameList.h"
 #include "support/filetools.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
@@ -47,28 +55,20 @@ namespace Alert = frontend::Alert;
 namespace os = support::os;
 
 
-InsetBibtex::InsetBibtex(InsetCommandParams const & p)
-       : InsetCommand(p, "bibtex"), bibfiles_()
-{}
+InsetBibtex::InsetBibtex(Buffer * buf, InsetCommandParams const & p)
+       : InsetCommand(buf, p)
+{
+       buffer().invalidateBibfileCache();
+       buffer().removeBiblioTempFiles();
+}
 
 
-void InsetBibtex::setBuffer(Buffer & buffer)
+InsetBibtex::~InsetBibtex()
 {
-       // FIXME We ought to have a buffer.
-       if (buffer_) {
-               EmbeddedFileList::iterator it = bibfiles_.begin();
-               EmbeddedFileList::iterator en = bibfiles_.end();
-               for (; it != en; ++it) {
-                       try {
-                               *it = it->copyTo(&buffer);
-                       } catch (ExceptionMessage const & message) {
-                               Alert::error(message.title_, message.details_);
-                               // failed to embed
-                               it->setEmbed(false);
-                       }
-               }
+       if (isBufferLoaded()) {
+               buffer().invalidateBibfileCache();
+               buffer().removeBiblioTempFiles();
        }
-       InsetCommand::setBuffer(buffer);
 }
 
 
@@ -78,7 +78,6 @@ ParamInfo const & InsetBibtex::findInfo(string const & /* cmdName */)
        if (param_info_.empty()) {
                param_info_.add("btprint", ParamInfo::LATEX_OPTIONAL);
                param_info_.add("bibfiles", ParamInfo::LATEX_REQUIRED);
-               param_info_.add("embed", ParamInfo::LYX_INTERNAL);
                param_info_.add("options", ParamInfo::LYX_INTERNAL);
        }
        return param_info_;
@@ -87,29 +86,33 @@ ParamInfo const & InsetBibtex::findInfo(string const & /* cmdName */)
 
 void InsetBibtex::doDispatch(Cursor & cur, FuncRequest & cmd)
 {
-       switch (cmd.action) {
+       switch (cmd.action()) {
+
+       case LFUN_INSET_EDIT:
+               editDatabases();
+               break;
 
        case LFUN_INSET_MODIFY: {
                InsetCommandParams p(BIBTEX_CODE);
                try {
-                       if (!InsetCommand::string2params("bibtex", 
-                                       to_utf8(cmd.argument()), p)) {
-                               cur.noUpdate();
+                       if (!InsetCommand::string2params(to_utf8(cmd.argument()), p)) {
+                               cur.noScreenUpdate();
                                break;
                        }
                } catch (ExceptionMessage const & message) {
                        if (message.type_ == WarningException) {
                                Alert::warning(message.title_, message.details_);
-                               cur.noUpdate();
-                       } else 
+                               cur.noScreenUpdate();
+                       } else
                                throw message;
                        break;
                }
-               //
-               createBibFiles();
-               updateParam();
-               setParam("options", p["options"]);
-               buffer().updateBibfilesCache();
+
+               cur.recordUndo();
+               setParams(p);
+               buffer().invalidateBibfileCache();
+               buffer().removeBiblioTempFiles();
+               cur.forceBufferUpdate();
                break;
        }
 
@@ -120,17 +123,113 @@ void InsetBibtex::doDispatch(Cursor & cur, FuncRequest & cmd)
 }
 
 
+bool InsetBibtex::getStatus(Cursor & cur, FuncRequest const & cmd,
+               FuncStatus & flag) const
+{
+       switch (cmd.action()) {
+       case LFUN_INSET_EDIT:
+               flag.setEnabled(true);
+               return true;
+
+       default:
+               return InsetCommand::getStatus(cur, cmd, flag);
+       }
+}
+
+
+void InsetBibtex::editDatabases() const
+{
+       vector<docstring> bibfilelist = getVectorFromString(getParam("bibfiles"));
+
+       if (bibfilelist.empty())
+               return;
+
+       int nr_databases = bibfilelist.size();
+       if (nr_databases > 1) {
+                       docstring message = bformat(_("The BibTeX inset includes %1$s databases.\n"
+                                                      "If you proceed, all of them will be opened."),
+                                                       convert<docstring>(nr_databases));
+                       int const ret = Alert::prompt(_("Open Databases?"),
+                               message, 0, 1, _("&Cancel"), _("&Proceed"));
+
+                       if (ret == 0)
+                               return;
+       }
+
+       vector<docstring>::const_iterator it = bibfilelist.begin();
+       vector<docstring>::const_iterator en = bibfilelist.end();
+       for (; it != en; ++it) {
+               FileName const bibfile = getBibTeXPath(*it, buffer());
+               formats.edit(buffer(), bibfile,
+                    formats.getFormatFromFile(bibfile));
+       }
+}
+
+
 docstring InsetBibtex::screenLabel() const
 {
        return _("BibTeX Generated Bibliography");
 }
 
 
+docstring InsetBibtex::toolTip(BufferView const & /*bv*/, int /*x*/, int /*y*/) const
+{
+       docstring item = from_ascii("* ");
+       docstring tip = _("Databases:") + "\n";
+       vector<docstring> bibfilelist = getVectorFromString(getParam("bibfiles"));
+
+       if (bibfilelist.empty()) {
+               tip += item;
+               tip += _("none");
+       } else {
+               vector<docstring>::const_iterator it = bibfilelist.begin();
+               vector<docstring>::const_iterator en = bibfilelist.end();
+               for (; it != en; ++it) {
+                       tip += item;
+                       tip += *it + "\n";
+               }
+       }
+
+       // Style-Options
+       bool toc = false;
+       docstring style = getParam("options"); // maybe empty! and with bibtotoc
+       docstring bibtotoc = from_ascii("bibtotoc");
+       if (prefixIs(style, bibtotoc)) {
+               toc = true;
+               if (contains(style, char_type(',')))
+                       style = split(style, bibtotoc, char_type(','));
+       }
+
+       tip += _("Style File:") +"\n";
+       tip += item;
+       if (!style.empty())
+               tip += style;
+       else
+               tip += _("none");
+
+       tip += "\n" + _("Lists:") + " ";
+       docstring btprint = getParam("btprint");
+               if (btprint == "btPrintAll")
+                       tip += _("all references");
+               else if (btprint == "btPrintNotCited")
+                       tip += _("all uncited references");
+               else
+                       tip += _("all cited references");
+
+       if (toc) {
+               tip += ", ";
+               tip += _("included in TOC");
+       }
+
+       return tip;
+}
+
+
 static string normalizeName(Buffer const & buffer,
        OutputParams const & runparams, string const & name, string const & ext)
 {
-       string const fname = makeAbsPath(name, buffer.filePath()).absFilename();
-       if (FileName(name).isAbsolute() || !FileName(fname + ext).isReadableFile())
+       string const fname = makeAbsPath(name, buffer.filePath()).absFileName();
+       if (FileName::isAbsolute(name) || !FileName(fname + ext).isReadableFile())
                return name;
        if (!runparams.nice)
                return fname;
@@ -141,7 +240,7 @@ static string normalizeName(Buffer const & buffer,
 }
 
 
-int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
+void InsetBibtex::latex(otexstream & os, OutputParams const & runparams) const
 {
        // the sequence of the commands:
        // 1. \bibliographystyle{style}
@@ -163,11 +262,17 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
        // use such filenames.)
        // Otherwise, store the (maybe absolute) path to the original,
        // unmangled database name.
-       EmbeddedFileList::const_iterator it = bibfiles_.begin();
-       EmbeddedFileList::const_iterator it_end = bibfiles_.end();
+       vector<docstring> bibfilelist = getVectorFromString(getParam("bibfiles"));
+       vector<docstring>::const_iterator it = bibfilelist.begin();
+       vector<docstring>::const_iterator en = bibfilelist.end();
        odocstringstream dbs;
-       for (; it != it_end; ++it) {
-               string utf8input = removeExtension(it->availableFile().absFilename());
+       bool didone = false;
+
+       // determine the export format
+       string const tex_format = flavor2format(runparams.flavor);
+
+       for (; it != en; ++it) {
+               string utf8input = to_utf8(*it);
                string database =
                        normalizeName(buffer(), runparams, utf8input, ".bib");
                FileName const try_in_file =
@@ -176,29 +281,38 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
 
                if (!runparams.inComment && !runparams.dryrun && !runparams.nice &&
                    not_from_texmf) {
-
-                       // mangledFilename() needs the extension
+                       // mangledFileName() needs the extension
                        DocFileName const in_file = DocFileName(try_in_file);
-                       database = removeExtension(in_file.mangledFilename());
+                       database = removeExtension(in_file.mangledFileName());
                        FileName const out_file = makeAbsPath(database + ".bib",
                                        buffer().masterBuffer()->temppath());
-
                        bool const success = in_file.copyTo(out_file);
                        if (!success) {
                                lyxerr << "Failed to copy '" << in_file
                                       << "' to '" << out_file << "'"
                                       << endl;
                        }
-               } else if (!runparams.inComment && runparams.nice && not_from_texmf &&
-                          !isValidLaTeXFilename(database)) {
+               } else if (!runparams.inComment && runparams.nice && not_from_texmf) {
+                       runparams.exportdata->addExternalFile(tex_format, try_in_file, database + ".bib");
+                       if (!isValidLaTeXFileName(database)) {
                                frontend::Alert::warning(_("Invalid filename"),
-                                                        _("The following filename is likely to cause trouble "
-                                                          "when running the exported file through LaTeX: ") +
-                                                           from_utf8(database));
+                                        _("The following filename will cause troubles "
+                                              "when running the exported file through LaTeX: ") +
+                                            from_utf8(database));
+                       }
+                       if (!isValidDVIFileName(database)) {
+                               frontend::Alert::warning(_("Problematic filename for DVI"),
+                                        _("The following filename can cause troubles "
+                                              "when running the exported file through LaTeX "
+                                                  "and opening the resulting DVI: ") +
+                                            from_utf8(database), true);
+                       }
                }
 
-               if (it != bibfiles_.begin())
+               if (didone)
                        dbs << ',';
+               else
+                       didone = true;
                // FIXME UNICODE
                dbs << from_utf8(latex_path(database));
        }
@@ -209,12 +323,10 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
        if (!warned_about_spaces &&
            runparams.nice && db_out.find(' ') != docstring::npos) {
                warned_about_spaces = true;
-
                Alert::warning(_("Export Warning!"),
                               _("There are spaces in the paths to your BibTeX databases.\n"
                                              "BibTeX will be unable to find them."));
        }
-
        // Style-Options
        string style = to_utf8(getParam("options")); // maybe empty! and with bibtotoc
        string bibtotoc;
@@ -224,12 +336,12 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
                        style = split(style, bibtotoc, ',');
        }
 
-       // line count
-       int nlines = 0;
+       if (style == "default")
+               style = buffer().params().biblio_style;
 
        if (!style.empty()) {
                string base = normalizeName(buffer(), runparams, style, ".bst");
-               FileName const try_in_file = 
+               FileName const try_in_file =
                        makeAbsPath(base + ".bst", buffer().filePath());
                bool const not_from_texmf = try_in_file.isReadableFile();
                // If this style does not come from texmf and we are not
@@ -240,7 +352,7 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
                    not_from_texmf) {
                        // use new style name
                        DocFileName const in_file = DocFileName(try_in_file);
-                       base = removeExtension(in_file.mangledFilename());
+                       base = removeExtension(in_file.mangledFileName());
                        FileName const out_file = makeAbsPath(base + ".bst",
                                        buffer().masterBuffer()->temppath());
                        bool const success = in_file.copyTo(out_file);
@@ -254,7 +366,6 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
                os << "\\bibliographystyle{"
                   << from_utf8(latex_path(normalizeName(buffer(), runparams, base, ".bst")))
                   << "}\n";
-               nlines += 1;
        }
 
        // Post this warning only once.
@@ -274,21 +385,16 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
                        btprint = from_ascii("btPrintCited");
                os << "\\" << btprint << "\n"
                   << "\\end{btSect}\n";
-               nlines += 3;
        }
 
        // bibtotoc-Option
        if (!bibtotoc.empty() && !buffer().params().use_bibtopic) {
-               if (buffer().params().documentClass().hasLaTeXLayout("chapter")) {
-                       if (buffer().params().sides == OneSide) {
-                               // oneside
-                               os << "\\clearpage";
-                       } else {
-                               // twoside
-                               os << "\\cleardoublepage";
-                       }
+               // set label for hyperref, see http://www.lyx.org/trac/ticket/6470
+               if (buffer().params().pdfoptions().use_hyperref)
+                               os << "\\phantomsection";
+               if (buffer().params().documentClass().hasLaTeXLayout("chapter"))
                        os << "\\addcontentsline{toc}{chapter}{\\bibname}";
-               else if (buffer().params().documentClass().hasLaTeXLayout("section"))
+               else if (buffer().params().documentClass().hasLaTeXLayout("section"))
                        os << "\\addcontentsline{toc}{section}{\\refname}";
        }
 
@@ -296,19 +402,33 @@ int InsetBibtex::latex(odocstream & os, OutputParams const & runparams) const
                docstring btprint = getParam("btprint");
                if (btprint == "btPrintAll") {
                        os << "\\nocite{*}\n";
-                       nlines += 1;
                }
                os << "\\bibliography{" << db_out << "}\n";
-               nlines += 1;
        }
-
-       return nlines;
 }
 
 
-EmbeddedFileList const & InsetBibtex::getBibFiles() const
+support::FileNameList InsetBibtex::getBibFiles() const
 {
-       return bibfiles_;
+       FileName path(buffer().filePath());
+       support::PathChanger p(path);
+
+       support::FileNameList vec;
+
+       vector<docstring> bibfilelist = getVectorFromString(getParam("bibfiles"));
+       vector<docstring>::const_iterator it = bibfilelist.begin();
+       vector<docstring>::const_iterator en = bibfilelist.end();
+       for (; it != en; ++it) {
+               FileName const file = getBibTeXPath(*it, buffer());
+
+               if (!file.empty())
+                       vec.push_back(file);
+               else
+                       LYXERR0("Couldn't find " + to_utf8(*it) + " in InsetBibtex::getBibFiles()!");
+       }
+
+       return vec;
+
 }
 
 namespace {
@@ -321,7 +441,7 @@ namespace {
        /// and further whitespace characters from the stream.
        /// @return true if a comma was found, false otherwise
        ///
-       bool removeWSAndComma(idocfstream & ifs) {
+       bool removeWSAndComma(ifdocstream & ifs) {
                char_type ch;
 
                if (!ifs)
@@ -364,8 +484,8 @@ namespace {
        ///
        /// @return true if a string of length > 0 could be read.
        ///
-       bool readTypeOrKey(docstring & val, idocfstream & ifs,
-               docstring const & delimChars, docstring const &illegalChars, 
+       bool readTypeOrKey(docstring & val, ifdocstream & ifs,
+               docstring const & delimChars, docstring const & illegalChars,
                charCase chCase) {
 
                char_type ch;
@@ -385,10 +505,10 @@ namespace {
 
                // read value
                bool legalChar = true;
-               while (ifs && !isSpace(ch) && 
+               while (ifs && !isSpace(ch) &&
                                                 delimChars.find(ch) == docstring::npos &&
                                                 (legalChar = (illegalChars.find(ch) == docstring::npos))
-                                       ) 
+                                       )
                {
                        if (chCase == makeLowerCase)
                                val += lowercase(ch);
@@ -396,7 +516,7 @@ namespace {
                                val += ch;
                        ifs.get(ch);
                }
-               
+
                if (!legalChar) {
                        ifs.putback(ch);
                        return false;
@@ -419,7 +539,7 @@ namespace {
        /// the variable strings.
        /// @return true if reading was successfull (all single parts were delimited
        /// correctly)
-       bool readValue(docstring & val, idocfstream & ifs, const VarMap & strings) {
+       bool readValue(docstring & val, ifdocstream & ifs, const VarMap & strings) {
 
                char_type ch;
 
@@ -438,13 +558,13 @@ namespace {
                                return false;
 
                        // check for field type
-                       if (isDigit(ch)) {
+                       if (isDigitASCII(ch)) {
 
                                // read integer value
                                do {
                                        val += ch;
                                        ifs.get(ch);
-                               } while (ifs && isDigit(ch));
+                               } while (ifs && isDigitASCII(ch));
 
                                if (!ifs)
                                        return false;
@@ -453,37 +573,37 @@ namespace {
                                // set end delimiter
                                char_type delim = ch == '"' ? '"': '}';
 
-                               //Skip whitespace
+                               // Skip whitespace
                                do {
                                        ifs.get(ch);
                                } while (ifs && isSpace(ch));
-                               
+
                                if (!ifs)
                                        return false;
-                               
-                               //We now have the first non-whitespace character
-                               //We'll collapse adjacent whitespace.
+
+                               // We now have the first non-whitespace character
+                               // We'll collapse adjacent whitespace.
                                bool lastWasWhiteSpace = false;
-                               
+
                                // inside this delimited text braces must match.
                                // Thus we can have a closing delimiter only
                                // when nestLevel == 0
                                int nestLevel = 0;
+
                                while (ifs && (nestLevel > 0 || ch != delim)) {
                                        if (isSpace(ch)) {
                                                lastWasWhiteSpace = true;
                                                ifs.get(ch);
                                                continue;
                                        }
-                                       //We output the space only after we stop getting 
-                                       //whitespace so as not to output any whitespace
-                                       //at the end of the value.
+                                       // We output the space only after we stop getting
+                                       // whitespace so as not to output any whitespace
+                                       // at the end of the value.
                                        if (lastWasWhiteSpace) {
                                                lastWasWhiteSpace = false;
                                                val += ' ';
                                        }
-                                       
+
                                        val += ch;
 
                                        // update nesting level
@@ -493,16 +613,19 @@ namespace {
                                                        break;
                                                case '}':
                                                        --nestLevel;
-                                                       if (nestLevel < 0) return false;
+                                                       if (nestLevel < 0)
+                                                               return false;
                                                        break;
                                        }
 
-                                       ifs.get(ch);
+                                       if (ifs)
+                                               ifs.get(ch);
                                }
 
                                if (!ifs)
                                        return false;
 
+                               // FIXME Why is this here?
                                ifs.get(ch);
 
                                if (!ifs)
@@ -549,9 +672,13 @@ namespace {
 }
 
 
-// This method returns a comma separated list of Bibtex entries
-void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
-       InsetIterator const & /*di*/) const
+void InsetBibtex::collectBibKeys(InsetIterator const & /*di*/) const
+{
+       parseBibTeXFiles();
+}
+
+
+void InsetBibtex::parseBibTeXFiles() const
 {
        // This bibtex parser is a first step to parse bibtex files
        // more precisely.
@@ -571,11 +698,14 @@ void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
        // We don't restrict keys to ASCII in LyX, since our own
        // InsetBibitem can generate non-ASCII keys, and nonstandard
        // 8bit clean bibtex forks exist.
-       EmbeddedFileList const & files = getBibFiles();
-       EmbeddedFileList::const_iterator it = files.begin();
-       EmbeddedFileList::const_iterator en = files.end();
+
+       BiblioInfo keylist;
+
+       support::FileNameList const files = getBibFiles();
+       support::FileNameList::const_iterator it = files.begin();
+       support::FileNameList::const_iterator en = files.end();
        for (; it != en; ++ it) {
-               idocfstream ifs(it->availableFile().toFilesystemEncoding().c_str(),
+               ifdocstream ifs(it->toFilesystemEncoding().c_str(),
                        ios_base::in, buffer().params().encoding().iconvName());
 
                char_type ch;
@@ -592,22 +722,29 @@ void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
 
                        docstring entryType;
 
-                       if (!readTypeOrKey(entryType, ifs, from_ascii("{("), 
-                                          docstring(), makeLowerCase) || !ifs)
+                       if (!readTypeOrKey(entryType, ifs, from_ascii("{("), docstring(), makeLowerCase)) {
+                               lyxerr << "BibTeX Parser: Error reading entry type." << std::endl;
                                continue;
+                       }
 
-                       if (entryType == from_ascii("comment")) {
+                       if (!ifs) {
+                               lyxerr << "BibTeX Parser: Unexpected end of file." << std::endl;
+                               continue;
+                       }
 
+                       if (entryType == from_ascii("comment")) {
                                ifs.ignore(numeric_limits<int>::max(), '\n');
                                continue;
                        }
 
                        ifs.get(ch);
-                       if (!ifs)
+                       if (!ifs) {
+                               lyxerr << "BibTeX Parser: Unexpected end of file." << std::endl;
                                break;
+                       }
 
                        if ((ch != '(') && (ch != '{')) {
-                               // invalid entry delimiter
+                               lyxerr << "BibTeX Parser: Invalid entry delimiter." << std::endl;
                                ifs.putback(ch);
                                continue;
                        }
@@ -620,17 +757,29 @@ void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
                                docstring name;
                                docstring value;
 
-                               if (!readTypeOrKey(name, ifs, from_ascii("="), 
-                                                  from_ascii("#{}(),"), makeLowerCase) || !ifs)
+                               if (!readTypeOrKey(name, ifs, from_ascii("="), from_ascii("#{}(),"), makeLowerCase)) {
+                                       lyxerr << "BibTeX Parser: Error reading string name." << std::endl;
                                        continue;
+                               }
+
+                               if (!ifs) {
+                                       lyxerr << "BibTeX Parser: Unexpected end of file." << std::endl;
+                                       continue;
+                               }
 
                                // next char must be an equal sign
                                ifs.get(ch);
-                               if (!ifs || ch != '=')
+                               if (!ifs || ch != '=') {
+                                       lyxerr << "BibTeX Parser: No `=' after string name: " <<
+                                                       name << "." << std::endl;
                                        continue;
+                               }
 
-                               if (!readValue(value, ifs, strings))
+                               if (!readValue(value, ifs, strings)) {
+                                       lyxerr << "BibTeX Parser: Unable to read value for string: " <<
+                                                       name << "." << std::endl;
                                        continue;
+                               }
 
                                strings[name] = value;
 
@@ -640,54 +789,69 @@ void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
                                // can they be of any use in lyx?
                                docstring value;
 
-                               if (!readValue(value, ifs, strings))
+                               if (!readValue(value, ifs, strings)) {
+                                       lyxerr << "BibTeX Parser: Unable to read preamble value." << std::endl;
                                        continue;
+                               }
 
                        } else {
 
                                // Citation entry. Try to read the key.
                                docstring key;
 
-                               if (!readTypeOrKey(key, ifs, from_ascii(","), 
-                                                  from_ascii("}"), keepCase) || !ifs)
+                               if (!readTypeOrKey(key, ifs, from_ascii(","), from_ascii("}"), keepCase)) {
+                                       lyxerr << "BibTeX Parser: Unable to read key for entry type:" << 
+                                                       entryType << "." << std::endl;
                                        continue;
+                               }
+
+                               if (!ifs) {
+                                       lyxerr << "BibTeX Parser: Unexpected end of file." << std::endl;
+                                       continue;
+                               }
 
                                /////////////////////////////////////////////
-                               // now we have a key, so we will add an entry 
+                               // now we have a key, so we will add an entry
                                // (even if it's empty, as bibtex does)
                                //
                                // we now read the field = value pairs.
                                // all items must be separated by a comma. If
                                // it is missing the scanning of this entry is
                                // stopped and the next is searched.
-                               docstring fields;
                                docstring name;
                                docstring value;
-                               docstring commaNewline;
                                docstring data;
                                BibTeXInfo keyvalmap(key, entryType);
-                               
+
                                bool readNext = removeWSAndComma(ifs);
+
                                while (ifs && readNext) {
 
                                        // read field name
-                                       if (!readTypeOrKey(name, ifs, from_ascii("="), 
+                                       if (!readTypeOrKey(name, ifs, from_ascii("="),
                                                           from_ascii("{}(),"), makeLowerCase) || !ifs)
                                                break;
 
                                        // next char must be an equal sign
+                                       // FIXME Whitespace??
                                        ifs.get(ch);
-                                       if (!ifs)
+                                       if (!ifs) {
+                                               lyxerr << "BibTeX Parser: Unexpected end of file." << std::endl;
                                                break;
+                                       }
                                        if (ch != '=') {
+                                               lyxerr << "BibTeX Parser: Missing `=' after field name: " <<
+                                                               name << ", for key: " << key << "." << std::endl;
                                                ifs.putback(ch);
                                                break;
                                        }
 
                                        // read field value
-                                       if (!readValue(value, ifs, strings))
+                                       if (!readValue(value, ifs, strings)) {
+                                               lyxerr << "BibTeX Parser: Unable to read value for field: " <<
+                                                               name << ", for key: " << key << "." << std::endl;
                                                break;
+                                       }
 
                                        keyvalmap[name] = value;
                                        data += "\n\n" + value;
@@ -699,16 +863,18 @@ void InsetBibtex::fillWithBibKeys(BiblioInfo & keylist,
                                keylist.addEntryType(entryType);
                                keyvalmap.setAllData(data);
                                keylist[key] = keyvalmap;
-                       }
+                       } //< else (citation entry)
                } //< searching '@'
        } //< for loop over files
+
+       buffer().addBiblioInfo(keylist);
 }
 
 
 FileName InsetBibtex::getBibTeXPath(docstring const & filename, Buffer const & buf)
 {
        string texfile = changeExtension(to_utf8(filename), "bib");
-       // note that, if the filename can be found directly from the path, 
+       // note that, if the filename can be found directly from the path,
        // findtexfile will just return a FileName object for that path.
        FileName file(findtexfile(texfile, "bib"));
        if (file.empty())
@@ -719,31 +885,32 @@ FileName InsetBibtex::getBibTeXPath(docstring const & filename, Buffer const & b
 
 bool InsetBibtex::addDatabase(docstring const & db)
 {
-       FileName const texPath = getBibTeXPath(db, buffer());
-       EmbeddedFileList::const_iterator efp = 
-               bibfiles_.findFile(texPath.absFilename());
-       if (efp != bibfiles_.end())
-               //already have it
+       docstring bibfiles = getParam("bibfiles");
+       if (tokenPos(bibfiles, ',', db) != -1)
                return false;
-
-       EmbeddedFile file(texPath.absFilename(), buffer().filePath());
-       bibfiles_.push_back(file);
-       updateParam();
+       if (!bibfiles.empty())
+               bibfiles += ',';
+       setParam("bibfiles", bibfiles + db);
        return true;
 }
 
 
 bool InsetBibtex::delDatabase(docstring const & db)
 {
-       FileName const texPath = getBibTeXPath(db, buffer());
-       EmbeddedFileList::iterator efp = 
-               bibfiles_.findFile(texPath.absFilename());
-       if (efp == bibfiles_.end())
-               // don't have it
-               return false;
-       
-       bibfiles_.erase(efp);
-       updateParam();
+       docstring bibfiles = getParam("bibfiles");
+       if (contains(bibfiles, db)) {
+               int const n = tokenPos(bibfiles, ',', db);
+               docstring bd = db;
+               if (n > 0) {
+                       // this is not the first database
+                       docstring tmp = ',' + bd;
+                       setParam("bibfiles", subst(bibfiles, tmp, docstring()));
+               } else if (n == 0)
+                       // this is the first (or only) database
+                       setParam("bibfiles", split(bibfiles, bd, ','));
+               else
+                       return false;
+       }
        return true;
 }
 
@@ -752,106 +919,87 @@ void InsetBibtex::validate(LaTeXFeatures & features) const
 {
        if (features.bufferParams().use_bibtopic)
                features.require("bibtopic");
+       // FIXME XHTML
+       // It'd be better to be able to get this from an InsetLayout, but at present
+       // InsetLayouts do not seem really to work for things that aren't InsetTexts.
+       if (features.runparams().flavor == OutputParams::HTML)
+               features.addCSSSnippet("div.bibtexentry { margin-left: 2em; text-indent: -2em; }\n"
+                       "span.bibtexlabel:before{ content: \"[\"; }\n"
+                       "span.bibtexlabel:after{ content: \"] \"; }");
 }
 
 
-void InsetBibtex::createBibFiles() const
+// FIXME
+// docstring InsetBibtex::entriesAsXHTML(vector<docstring> const & entries)
+// And then here just: entriesAsXHTML(buffer().masterBibInfo().citedEntries())
+docstring InsetBibtex::xhtml(XHTMLStream & xs, OutputParams const &) const
 {
-       // need to do this to keep old info while also not
-       // copying over any files that have been deleted.
-       EmbeddedFileList oldlist = bibfiles_;
-       bibfiles_.clear();
-       
-       docstring bibfile;
-       docstring embfile;
-       
-       docstring bibfiles = getParam("bibfiles");
-       docstring embfiles = getParam("embed");
-       
-       bibfiles = split(bibfiles, bibfile, ',');
-       embfiles = split(embfiles, embfile, ',');
-       
-       while (!bibfile.empty()) {
-               FileName bib = getBibTeXPath(bibfile, buffer());
-               EmbeddedFileList::iterator efp = oldlist.findFile(bib.absFilename());
-               if (efp != oldlist.end()) {
-                       // already have this one, but embedding status may have been changed
-                       bool old_status = efp->embedded();
-                       bool new_status = !embfile.empty();
-                       efp->setEmbed(new_status);
-                       try {
-                               // copy file if embedding status changed.
-                               efp->enable(buffer().embedded(), &buffer(), old_status != new_status);
-                       } catch (ExceptionMessage const & message) {
-                               Alert::error(message.title_, message.details_);
-                               // failed to change embeddeing status
-                               efp->setEmbed(old_status);
-                       }
-                       bibfiles_.push_back(*efp);
-               } else {
-                       EmbeddedFile file(bib.absFilename(), buffer().filePath());
-                       file.setEmbed(!embfile.empty());
-                       try {
-                               file.enable(buffer().embedded(), &buffer(), true);
-                       } catch (ExceptionMessage const & message) {
-                               Alert::error(message.title_, message.details_);
-                               // failed to embed
-                               file.setEmbed(false);
-                       }
-                       bibfiles_.push_back(file);
+       BiblioInfo const & bibinfo = buffer().masterBibInfo();
+       vector<docstring> const & cites = bibinfo.citedEntries();
+       CiteEngineType const engine_type = buffer().params().citeEngineType();
+       bool const numbers = (engine_type == ENGINE_TYPE_NUMERICAL);
+
+       docstring reflabel = from_ascii("References");
+       Language const * l = buffer().params().language;
+       if (l)
+               reflabel = translateIfPossible(reflabel, l->code());
+
+       xs << html::StartTag("h2", "class='bibtex'")
+               << reflabel
+               << html::EndTag("h2")
+               << html::StartTag("div", "class='bibtex'");
+
+       // Now we loop over the entries
+       vector<docstring>::const_iterator vit = cites.begin();
+       vector<docstring>::const_iterator const ven = cites.end();
+       for (; vit != ven; ++vit) {
+               BiblioInfo::const_iterator const biit = bibinfo.find(*vit);
+               if (biit == bibinfo.end())
+                       continue;
+               BibTeXInfo const & entry = biit->second;
+               xs << html::StartTag("div", "class='bibtexentry'");
+               // FIXME XHTML
+               // The same name/id problem we have elsewhere.
+               string const attr = 
+                       "id='LyXCite-" + to_utf8(html::cleanAttr(entry.key())) + "'";
+               xs << html::CompTag("a", attr);
+               docstring citekey;
+               if (numbers)
+                       citekey = entry.citeNumber();
+               else {
+                       docstring const auth = entry.getAbbreviatedAuthor();
+                       // we do it this way so as to access the xref, if necessary
+                       // note that this also gives us the modifier
+                       docstring const year = bibinfo.getYear(*vit, true);
+                       if (!auth.empty() && !year.empty())
+                               citekey = auth + ' ' + year;
                }
-               // Get next file name
-               bibfiles = split(bibfiles, bibfile, ',');
-               embfiles = split(embfiles, embfile, ',');
-       }
-}
-
-
-void InsetBibtex::updateParam()
-{
-       docstring bibfiles;
-       docstring embed;
-
-       bool first = true;
-
-       EmbeddedFileList::iterator it = bibfiles_.begin();
-       EmbeddedFileList::iterator en = bibfiles_.end();
-       for (; it != en; ++it) {
-               if (!first) {
-                       bibfiles += ',';
-                       embed += ',';
-               } else
-                       first = false;
-               bibfiles += from_utf8(it->outputFilename(buffer().filePath()));
-               if (it->embedded())
-                       embed += from_utf8(it->inzipName());
+               if (citekey.empty()) {
+                       citekey = entry.label();
+                       if (citekey.empty())
+                               citekey = entry.key();
+               }
+               xs << html::StartTag("span", "class='bibtexlabel'")
+                       << citekey
+                       << html::EndTag("span");
+               // FIXME Right now, we are calling BibInfo::getInfo on the key,
+               // which will give us all the cross-referenced info. But for every
+               // entry, so there's a lot of repitition. This should be fixed.
+               xs << html::StartTag("span", "class='bibtexinfo'")
+                  << XHTMLStream::ESCAPE_AND
+                  << bibinfo.getInfo(entry.key(), buffer(), true)
+                  << html::EndTag("span")
+                  << html::EndTag("div")
+                  << html::CR();
        }
-       setParam("bibfiles", bibfiles);
-       setParam("embed", embed);
+       xs << html::EndTag("div");
+       return docstring();
 }
 
 
-void InsetBibtex::registerEmbeddedFiles(EmbeddedFileList & files) const
+string InsetBibtex::contextMenuName() const
 {
-       if (bibfiles_.empty())
-               createBibFiles();
-
-       EmbeddedFileList::const_iterator it = bibfiles_.begin();
-       EmbeddedFileList::const_iterator en = bibfiles_.end();
-       for (; it != en; ++it)
-               files.registerFile(*it, this, buffer());
-}
-
-
-void InsetBibtex::updateEmbeddedFile(EmbeddedFile const & file)
-{
-       // look for the item and update status
-       string const filename = file.absFilename();
-       EmbeddedFileList::iterator it = bibfiles_.findFile(filename);
-       if (it == bibfiles_.end())
-               return;
-       *it = file;
-       updateParam();
+       return "context-bibtex";
 }