]> git.lyx.org Git - lyx.git/blobdiff - src/insets/ExternalSupport.C
* src/LyXAction.C: mark goto-clear-bookmark as working without buffer
[lyx.git] / src / insets / ExternalSupport.C
index 5795a2d5f66f9f480bd459b4806e38bf1f8d18ea..d84baf75069b5a48e9ec22d0d8544259387f86d4 100644 (file)
 #include "support/lyxlib.h"
 #include "support/os.h"
 #include "support/package.h"
-#include "support/path.h"
-
-namespace support = lyx::support;
 
 using std::endl;
-
 using std::string;
 using std::vector;
 
 
 namespace lyx {
+
+using support::FileName;
+
 namespace external {
 
 Template const * getTemplatePtr(InsetExternalParams const & params)
@@ -52,9 +51,8 @@ Template const * getTemplatePtr(InsetExternalParams const & params)
 
 void editExternal(InsetExternalParams const & params, Buffer const & buffer)
 {
-       string const file_with_path = params.filename.absFilename();
-       formats.edit(buffer, file_with_path,
-                    formats.getFormatFromFile(file_with_path));
+       formats.edit(buffer, params.filename,
+                    formats.getFormatFromFile(params.filename));
 }
 
 
@@ -69,9 +67,11 @@ string const subst_path(string const & input,
 {
        if (input.find(placeholder) == string::npos)
                return input;
+       // Don't use external_path here when use_latex_path is false, as the
+       // path will be compared with another one in internal style later
+       // in Converters::move.
        string const path2 = use_latex_path ?
-               support::latex_path(path, ext, dots) :
-               support::os::external_path(path);
+               support::latex_path(path, ext, dots) : path;
        return support::subst(input, placeholder, path2);
 }
 
@@ -93,7 +93,7 @@ string const doSubstitution(InsetExternalParams const & params,
                params.filename.outputFilename(parentpath);
        string const basename = support::changeExtension(
                        support::onlyFilename(filename), string());
-       string const absname = support::makeAbsPath(filename, parentpath);
+       string const absname = support::makeAbsPath(filename, parentpath).absFilename();
 
        string result = s;
        if (what != ALL_BUT_PATHS) {
@@ -157,7 +157,7 @@ string const doSubstitution(InsetExternalParams const & params,
                            support::PROTECT_EXTENSION, support::ESCAPE_DOTS);
        result = subst_path(result, "$$Extension",
                        '.' + support::getExtension(filename), use_latex_path);
-       result = subst_path(result, "$$Tempname", params.tempname(), use_latex_path);
+       result = subst_path(result, "$$Tempname", params.tempname().absFilename(), use_latex_path);
        result = subst_path(result, "$$Sysdir",
                                support::package().system_support(), use_latex_path);
 
@@ -169,12 +169,10 @@ string const doSubstitution(InsetExternalParams const & params,
                string const file = result.substr(pos + 12, end - (pos + 12));
                string contents;
 
-               string const filepath = support::isFileReadable(file) ?
-                       buffer.filePath() : m_buffer->temppath();
-               support::Path p(filepath);
-
-               if (support::isFileReadable(file))
-                       contents = support::getFileContents(file);
+               FileName const absfile(
+                       support::makeAbsPath(file, m_buffer->temppath()));
+               if (support::isFileReadable(absfile))
+                       contents = support::getFileContents(absfile);
 
                result = support::subst(result,
                                        ("$$Contents(\"" + file + "\")").c_str(),
@@ -217,14 +215,12 @@ void updateExternal(InsetExternalParams const & params,
        if (from_format.empty())
                return; // NOT_NEEDED
 
-       string abs_from_file = params.filename.absFilename();
-
        if (from_format == "*") {
-               if (abs_from_file.empty())
+               if (params.filename.empty())
                        return; // NOT_NEEDED
 
                // Try and ascertain the file format from its contents.
-               from_format = formats.getFormatFromFile(abs_from_file);
+               from_format = formats.getFormatFromFile(params.filename);
                if (from_format.empty())
                        return; // FAILURE
 
@@ -234,7 +230,7 @@ void updateExternal(InsetExternalParams const & params,
        if (to_format.empty())
                return; // NOT_NEEDED
 
-       if (!converters.isReachable(from_format, to_format)) {
+       if (!theConverters().isReachable(from_format, to_format)) {
                lyxerr[Debug::EXTERNAL]
                        << "external::updateExternal. "
                        << "Unable to convert from "
@@ -248,20 +244,20 @@ void updateExternal(InsetExternalParams const & params,
 
        // We copy the source file to the temp dir and do the conversion
        // there if necessary
-       string const temp_file =
+       FileName const temp_file(
                support::makeAbsPath(params.filename.mangledFilename(),
-                                    m_buffer->temppath());
-       if (!abs_from_file.empty()) {
-               unsigned long const from_checksum = support::sum(abs_from_file);
+                                    m_buffer->temppath()));
+       if (!params.filename.empty()) {
+               unsigned long const from_checksum = support::sum(params.filename);
                unsigned long const temp_checksum = support::sum(temp_file);
 
                if (from_checksum != temp_checksum) {
-                       Mover const & mover = movers(from_format);
-                       if (!mover.copy(abs_from_file, temp_file)) {
+                       Mover const & mover = getMover(from_format);
+                       if (!mover.copy(params.filename, temp_file)) {
                                lyxerr[Debug::EXTERNAL]
                                        << "external::updateExternal. "
                                        << "Unable to copy "
-                                       << abs_from_file << " to " << temp_file << endl;
+                                       << params.filename << " to " << temp_file << endl;
                                return; // FAILURE
                        }
                }
@@ -271,8 +267,8 @@ void updateExternal(InsetExternalParams const & params,
        string const to_file = doSubstitution(params, buffer,
                                              outputFormat.updateResult,
                                              false, true);
-       string const abs_to_file =
-               support::makeAbsPath(to_file, m_buffer->temppath());
+       FileName const abs_to_file(
+               support::makeAbsPath(to_file, m_buffer->temppath()));
 
        // Record the referenced files for the exporter.
        // The exporter will copy them to the export dir.
@@ -283,10 +279,10 @@ void updateExternal(InsetExternalParams const & params,
                vector<string>::const_iterator fit  = rit->second.begin();
                vector<string>::const_iterator fend = rit->second.end();
                for (; fit != fend; ++fit) {
-                       string const source = support::makeAbsPath(
+                       FileName const source(support::makeAbsPath(
                                        doSubstitution(params, buffer, *fit,
                                                       false, true),
-                                       m_buffer->temppath());
+                                       m_buffer->temppath()));
                        // The path of the referenced file is never the
                        // temp path, but the filename may be the mangled
                        // or the real name. Therefore we substitute the
@@ -308,14 +304,13 @@ void updateExternal(InsetExternalParams const & params,
        // Yes if to_file does not exist or if from_file is newer than to_file
        if (support::compare_timestamps(temp_file, abs_to_file) < 0)
                return; // SUCCESS
-       string const to_file_base =
-               support::changeExtension(to_file, string());
 
        // FIXME (Abdel 12/08/06): Is there a need to show these errors?
        ErrorList el;
        /* bool const success = */
-               converters.convert(&buffer, temp_file, to_file_base,
-                                  from_format, to_format, el, true);
+               theConverters().convert(&buffer, temp_file, abs_to_file,
+                                  params.filename, from_format, to_format, el,
+                                  Converters::try_default | Converters::try_cache);
        // return success
 }
 
@@ -331,7 +326,7 @@ string const substituteOptions(InsetExternalParams const & params,
 
 int writeExternal(InsetExternalParams const & params,
                  string const & format,
-                 Buffer const & buffer, lyx::odocstream & os,
+                 Buffer const & buffer, odocstream & os,
                  ExportData & exportdata,
                  bool external_in_tmpdir,
                  bool external_in_comment)
@@ -360,7 +355,7 @@ int writeExternal(InsetExternalParams const & params,
        str = substituteCommands(params, str, format);
        str = substituteOptions(params, str, format);
        // FIXME UNICODE
-       os << lyx::from_utf8(str);
+       os << from_utf8(str);
        return int(lyx::count(str.begin(), str.end(),'\n'));
 }
 
@@ -511,9 +506,10 @@ string const substituteOptions(InsetExternalParams const & params,
        }
 
        return output;
- }
+}
 
 } // namespace anon
 
 } // namespace external
+
 } // namespace lyx