]> git.lyx.org Git - lyx.git/blobdiff - src/graphics/PreviewLoader.cpp
Run codespell on tex2lyx/, client/, convert/ and graphics/
[lyx.git] / src / graphics / PreviewLoader.cpp
index 49b8b73b0ace5184766c38d89387ddcc82ee79f1..e3daaa770415d24a563f650cc3fd2819b8b3ec24 100644 (file)
@@ -124,14 +124,10 @@ void setAscentFractions(vector<double> & ascent_fractions,
 }
 
 
-class FindFirst
+std::function <bool (SnippetPair const &)> FindFirst(string const & comp)
 {
-public:
-       FindFirst(string const & comp) : comp_(comp) {}
-       bool operator()(SnippetPair const & sp) const { return sp.first == comp_; }
-private:
-       string const comp_;
-};
+       return [&comp](SnippetPair const & sp) { return sp.first == comp; };
+}
 
 
 /// Store info on a currently executing, forked process.
@@ -146,22 +142,21 @@ public:
        /// Remove any files left lying around and kill the forked process.
        void stop() const;
 
-       ///
-       pid_t pid;
        ///
        string command;
        ///
        FileName metrics_file;
        ///
        BitmapFile snippets;
+       ///
+       pid_t pid;
 };
 
 typedef map<pid_t, InProgress>  InProgressProcesses;
 
 typedef InProgressProcesses::value_type InProgressProcess;
 
-} // namespace anon
-
+} // namespace
 
 
 namespace lyx {
@@ -218,7 +213,6 @@ private:
 
        /** in_progress_ stores all forked processes so that we can proceed
         *  thereafter.
-           The map uses the conversion commands as its identifiers.
         */
        InProgressProcesses in_progress_;
 
@@ -235,12 +229,13 @@ private:
        ///
        QTimer * delay_refresh_;
        ///
+       Trackable trackable_;
+       ///
        bool finished_generating_;
 
        /// We don't own this
        static lyx::Converter const * pconverter_;
 
-       signals2::scoped_connection connection_;
 };
 
 
@@ -335,11 +330,10 @@ public:
        {
                ostringstream os;
                os << base_ << counter_++ << '.' << to_format_;
-               string const file = os.str();
-
-               return make_pair(snippet, FileName(file));
+               string const file_name = os.str();
+               return make_pair(snippet, FileName(file_name));
        }
-
+       
 private:
        string const & to_format_;
        string const & base_;
@@ -350,9 +344,8 @@ private:
 InProgress::InProgress(string const & filename_base,
                       PendingSnippets const & pending,
                       string const & to_format)
-       : pid(0),
-         metrics_file(filename_base + ".metrics"),
-         snippets(pending.size())
+       : metrics_file(filename_base + ".metrics"),
+         snippets(pending.size()), pid(0)
 {
        PendingSnippets::const_iterator pit  = pending.begin();
        PendingSnippets::const_iterator pend = pending.end();
@@ -379,7 +372,7 @@ void InProgress::stop() const
        }
 }
 
-} // namespace anon
+} // namespace
 
 
 namespace lyx {
@@ -390,8 +383,8 @@ PreviewLoader::Impl::Impl(PreviewLoader & p, Buffer const & b)
 {
        font_scaling_factor_ = int(buffer_.fontScalingFactor());
        if (theApp()) {
-               fg_color_ = strtol(theApp()->hexName(foregroundColor()).c_str(), 0, 16);
-               bg_color_ = strtol(theApp()->hexName(backgroundColor()).c_str(), 0, 16);
+               fg_color_ = convert(theApp()->hexName(foregroundColor()).c_str(), 16);
+               bg_color_ = convert(theApp()->hexName(backgroundColor()).c_str(), 16);
        } else {
                fg_color_ = 0x0;
                bg_color_ = 0xffffff;
@@ -454,8 +447,8 @@ PreviewLoader::Impl::preview(string const & latex_snippet) const
        int fg = 0x0;
        int bg = 0xffffff;
        if (theApp()) {
-               fg = strtol(theApp()->hexName(foregroundColor()).c_str(), 0, 16);
-               bg = strtol(theApp()->hexName(backgroundColor()).c_str(), 0, 16);
+               fg = convert(theApp()->hexName(foregroundColor()).c_str(), 16);
+               bg = convert(theApp()->hexName(backgroundColor()).c_str(), 16);
        }
        if (font_scaling_factor_ != fs || fg_color_ != fg || bg_color_ != bg) {
                // Schedule refresh of all previews on zoom or color changes.
@@ -467,9 +460,10 @@ PreviewLoader::Impl::preview(string const & latex_snippet) const
        }
        // Don't try to access the cache until we are done.
        if (delay_refresh_->isActive() || !finished_generating_)
-               return 0;
+               return nullptr;
+
        Cache::const_iterator it = cache_.find(latex_snippet);
-       return (it == cache_.end()) ? 0 : it->second.get();
+       return (it == cache_.end()) ? nullptr : it->second.get();
 }
 
 
@@ -492,22 +486,17 @@ void PreviewLoader::Impl::refreshPreviews()
 
 namespace {
 
-class FindSnippet {
-public:
-       FindSnippet(string const & s) : snippet_(s) {}
-       bool operator()(InProgressProcess const & process) const
-       {
+std::function<bool (InProgressProcess const &)> FindSnippet(string const & s)
+{
+       return [&s](InProgressProcess const & process) {
                BitmapFile const & snippets = process.second.snippets;
                BitmapFile::const_iterator beg  = snippets.begin();
                BitmapFile::const_iterator end = snippets.end();
-               return find_if(beg, end, FindFirst(snippet_)) != end;
-       }
-
-private:
-       string const snippet_;
-};
+               return find_if(beg, end, FindFirst(s)) != end;
+       };
+}
 
-} // namespace anon
+} // namespace
 
 PreviewLoader::Status
 PreviewLoader::Impl::status(string const & latex_snippet) const
@@ -551,25 +540,19 @@ void PreviewLoader::Impl::add(string const & latex_snippet)
 
 namespace {
 
-class EraseSnippet {
-public:
-       EraseSnippet(string const & s) : snippet_(s) {}
-       void operator()(InProgressProcess & process)
-       {
+std::function<void (InProgressProcess &)> EraseSnippet(string const & s) {
+       return [&s](InProgressProcess & process) {
                BitmapFile & snippets = process.second.snippets;
                BitmapFile::iterator it  = snippets.begin();
                BitmapFile::iterator end = snippets.end();
 
-               it = find_if(it, end, FindFirst(snippet_));
+               it = find_if(it, end, FindFirst(s));
                if (it != end)
                        snippets.erase(it, it+1);
-       }
-
-private:
-       string const & snippet_;
+       };
 };
 
-} // namespace anon
+} // namespace
 
 
 void PreviewLoader::Impl::remove(string const & latex_snippet)
@@ -691,7 +674,7 @@ void PreviewLoader::Impl::startLoading(bool wait)
        }
        dumpPreamble(os, flavor);
        // handle inputenc etc.
-       // I think, this is already hadled by dumpPreamble(): Kornel
+       // I think this is already handled by dumpPreamble(): Kornel
        // buffer_.params().writeEncodingPreamble(os, features);
        of << "\n\\begin{document}\n";
        dumpData(of, inprogress.snippets);
@@ -728,7 +711,8 @@ void PreviewLoader::Impl::startLoading(bool wait)
        if (wait) {
                ForkedCall call(buffer_.filePath(), buffer_.layoutPos());
                int ret = call.startScript(ForkedProcess::Wait, command);
-               static atomic_int fake((2^20) + 1);
+               // PID_MAX_LIMIT is 2^22 so we start one after that
+               static atomic_int fake((1 << 22) + 1);
                int pid = fake++;
                inprogress.pid = pid;
                inprogress.command = command;
@@ -739,10 +723,9 @@ void PreviewLoader::Impl::startLoading(bool wait)
 
        // Initiate the conversion from LaTeX to bitmap images files.
        ForkedCall::sigPtr convert_ptr = make_shared<ForkedCall::sig>();
-       // This is a scoped connection
-       connection_ = convert_ptr->connect([this](pid_t pid, int retval){
-                       finishedGenerating(pid, retval);
-               });
+       convert_ptr->connect(ForkedProcess::slot([this](pid_t pid, int retval){
+                               finishedGenerating(pid, retval);
+                       }).track_foreign(trackable_.p()));
 
        ForkedCall call(buffer_.filePath());
        int ret = call.startScript(command, convert_ptr);
@@ -798,7 +781,7 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
 
        list<PreviewImagePtr> newimages;
 
-       int metrics_counter = 0;
+       size_t metrics_counter = 0;
        for (; it != end; ++it, ++metrics_counter) {
                string const & snip = it->first;
                FileName const & file = it->second;