]> git.lyx.org Git - lyx.git/blobdiff - src/graphics/PreviewLoader.cpp
Avoid null pointer dereference
[lyx.git] / src / graphics / PreviewLoader.cpp
index ac14fbb6a904591e9b8a0182bef5b230eb7ae3e6..28a0e0fa5271e6eefd473e558fc51b8c038b14bc 100644 (file)
@@ -19,7 +19,6 @@
 #include "Converter.h"
 #include "Encoding.h"
 #include "Format.h"
-#include "InsetIterator.h"
 #include "LaTeXFeatures.h"
 #include "LyXRC.h"
 #include "output.h"
 
 #include "frontends/Application.h" // hexName
 
-#include "insets/Inset.h"
-
 #include "support/convert.h"
 #include "support/debug.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
 #include "support/ForkedCalls.h"
 #include "support/lstrings.h"
+#include "support/os.h"
 
 #include "support/TempFile.h"
 
@@ -124,14 +122,10 @@ void setAscentFractions(vector<double> & ascent_fractions,
 }
 
 
-class FindFirst
+std::function <bool (SnippetPair const &)> FindFirst(string const & comp)
 {
-public:
-       FindFirst(string const & comp) : comp_(comp) {}
-       bool operator()(SnippetPair const & sp) const { return sp.first == comp_; }
-private:
-       string const comp_;
-};
+       return [&comp](SnippetPair const & sp) { return sp.first == comp; };
+}
 
 
 /// Store info on a currently executing, forked process.
@@ -146,14 +140,14 @@ public:
        /// Remove any files left lying around and kill the forked process.
        void stop() const;
 
-       ///
-       pid_t pid;
        ///
        string command;
        ///
        FileName metrics_file;
        ///
        BitmapFile snippets;
+       ///
+       pid_t pid;
 };
 
 typedef map<pid_t, InProgress>  InProgressProcesses;
@@ -187,7 +181,7 @@ public:
        void refreshPreviews();
 
        /// Emit this signal when an image is ready for display.
-       signals2::signal<void(PreviewImage const &)> imageReady;
+       signal<void(PreviewImage const &)> imageReady;
 
        Buffer const & buffer() const { return buffer_; }
 
@@ -197,7 +191,7 @@ private:
        /// Called by the ForkedCall process that generated the bitmap files.
        void finishedGenerating(pid_t, int);
        ///
-       void dumpPreamble(otexstream &, OutputParams::FLAVOR) const;
+       void dumpPreamble(otexstream &, Flavor) const;
        ///
        void dumpData(odocstream &, BitmapFile const &) const;
 
@@ -217,7 +211,6 @@ private:
 
        /** in_progress_ stores all forked processes so that we can proceed
         *  thereafter.
-           The map uses the conversion commands as its identifiers.
         */
        InProgressProcesses in_progress_;
 
@@ -239,7 +232,6 @@ private:
        /// We don't own this
        static lyx::Converter const * pconverter_;
 
-       Trackable trackable_;
 };
 
 
@@ -251,16 +243,10 @@ lyx::Converter const * PreviewLoader::Impl::pconverter_;
 //
 
 PreviewLoader::PreviewLoader(Buffer const & b)
-       : pimpl_(new Impl(*this, b))
+       : pimpl_(make_shared<Impl>(*this, b))
 {}
 
 
-PreviewLoader::~PreviewLoader()
-{
-       delete pimpl_;
-}
-
-
 PreviewImage const * PreviewLoader::preview(string const & latex_snippet) const
 {
        return pimpl_->preview(latex_snippet);
@@ -297,7 +283,7 @@ void PreviewLoader::refreshPreviews()
 }
 
 
-signals2::connection PreviewLoader::connect(slot const & slot) const
+connection PreviewLoader::connect(slot const & slot) const
 {
        return pimpl_->imageReady.connect(slot);
 }
@@ -334,9 +320,8 @@ public:
        {
                ostringstream os;
                os << base_ << counter_++ << '.' << to_format_;
-               string const file = os.str();
-
-               return make_pair(snippet, FileName(file));
+               string const file_name = os.str();
+               return make_pair(snippet, FileName(file_name));
        }
 
 private:
@@ -349,9 +334,8 @@ private:
 InProgress::InProgress(string const & filename_base,
                       PendingSnippets const & pending,
                       string const & to_format)
-       : pid(0),
-         metrics_file(filename_base + ".metrics"),
-         snippets(pending.size())
+       : metrics_file(filename_base + ".metrics"),
+         snippets(pending.size()), pid(0)
 {
        PendingSnippets::const_iterator pit  = pending.begin();
        PendingSnippets::const_iterator pend = pending.end();
@@ -389,8 +373,8 @@ PreviewLoader::Impl::Impl(PreviewLoader & p, Buffer const & b)
 {
        font_scaling_factor_ = int(buffer_.fontScalingFactor());
        if (theApp()) {
-               fg_color_ = strtol(theApp()->hexName(foregroundColor()).c_str(), 0, 16);
-               bg_color_ = strtol(theApp()->hexName(backgroundColor()).c_str(), 0, 16);
+               fg_color_ = convert(theApp()->hexName(foregroundColor()), 16);
+               bg_color_ = convert(theApp()->hexName(backgroundColor()), 16);
        } else {
                fg_color_ = 0x0;
                bg_color_ = 0xffffff;
@@ -453,8 +437,8 @@ PreviewLoader::Impl::preview(string const & latex_snippet) const
        int fg = 0x0;
        int bg = 0xffffff;
        if (theApp()) {
-               fg = strtol(theApp()->hexName(foregroundColor()).c_str(), 0, 16);
-               bg = strtol(theApp()->hexName(backgroundColor()).c_str(), 0, 16);
+               fg = convert(theApp()->hexName(foregroundColor()), 16);
+               bg = convert(theApp()->hexName(backgroundColor()), 16);
        }
        if (font_scaling_factor_ != fs || fg_color_ != fg || bg_color_ != bg) {
                // Schedule refresh of all previews on zoom or color changes.
@@ -466,9 +450,10 @@ PreviewLoader::Impl::preview(string const & latex_snippet) const
        }
        // Don't try to access the cache until we are done.
        if (delay_refresh_->isActive() || !finished_generating_)
-               return 0;
+               return nullptr;
+
        Cache::const_iterator it = cache_.find(latex_snippet);
-       return (it == cache_.end()) ? 0 : it->second.get();
+       return (it == cache_.end()) ? nullptr : it->second.get();
 }
 
 
@@ -491,20 +476,15 @@ void PreviewLoader::Impl::refreshPreviews()
 
 namespace {
 
-class FindSnippet {
-public:
-       FindSnippet(string const & s) : snippet_(s) {}
-       bool operator()(InProgressProcess const & process) const
-       {
+std::function<bool (InProgressProcess const &)> FindSnippet(string const & s)
+{
+       return [&s](InProgressProcess const & process) {
                BitmapFile const & snippets = process.second.snippets;
                BitmapFile::const_iterator beg  = snippets.begin();
                BitmapFile::const_iterator end = snippets.end();
-               return find_if(beg, end, FindFirst(snippet_)) != end;
-       }
-
-private:
-       string const snippet_;
-};
+               return find_if(beg, end, FindFirst(s)) != end;
+       };
+}
 
 } // namespace
 
@@ -550,23 +530,18 @@ void PreviewLoader::Impl::add(string const & latex_snippet)
 
 namespace {
 
-class EraseSnippet {
-public:
-       EraseSnippet(string const & s) : snippet_(s) {}
-       void operator()(InProgressProcess & process)
-       {
+std::function<void (InProgressProcess &)> EraseSnippet(string const & s)
+{
+       return [&s](InProgressProcess & process) {
                BitmapFile & snippets = process.second.snippets;
                BitmapFile::iterator it  = snippets.begin();
                BitmapFile::iterator end = snippets.end();
 
-               it = find_if(it, end, FindFirst(snippet_));
+               it = find_if(it, end, FindFirst(s));
                if (it != end)
                        snippets.erase(it, it+1);
-       }
-
-private:
-       string const & snippet_;
-};
+       };
+}
 
 } // namespace
 
@@ -646,7 +621,7 @@ void PreviewLoader::Impl::startLoading(bool wait)
 
        // Set \jobname of previews to the document name (see bug 9627)
        of << "\\def\\jobname{"
-          << from_utf8(changeExtension(buffer_.latexName(true), ""))
+          << from_utf8(changeExtension(buffer_.latexName(), ""))
           << "}\n";
 
        LYXERR(Debug::LATEX, "Format = " << buffer_.params().getDefaultOutputFormat());
@@ -655,42 +630,42 @@ void PreviewLoader::Impl::startLoading(bool wait)
                        && buffer_.params().default_output_format != "default";
        // Use LATEX flavor if the document does not specify a specific
        // output format (see bug 9371).
-       OutputParams::FLAVOR flavor = docformat
+       Flavor flavor = docformat
                                        ? buffer_.params().getOutputFlavor()
-                                       : OutputParams::LATEX;
+                                       : Flavor::LaTeX;
        if (buffer_.params().encoding().package() == Encoding::japanese) {
                latexparam = " --latex=platex";
-               flavor = OutputParams::LATEX;
+               flavor = Flavor::LaTeX;
        }
        else if (buffer_.params().useNonTeXFonts) {
-               if (flavor == OutputParams::LUATEX)
+               if (flavor == Flavor::LuaTeX)
                        latexparam = " --latex=lualatex";
                else {
-                       flavor = OutputParams::XETEX;
+                       flavor = Flavor::XeTeX;
                        latexparam = " --latex=xelatex";
                }
        }
        else {
                switch (flavor) {
-                       case OutputParams::PDFLATEX:
+                       case Flavor::PdfLaTeX:
                                latexparam = " --latex=pdflatex";
                                break;
-                       case OutputParams::XETEX:
+                       case Flavor::XeTeX:
                                latexparam = " --latex=xelatex";
                                break;
-                       case OutputParams::LUATEX:
+                       case Flavor::LuaTeX:
                                latexparam = " --latex=lualatex";
                                break;
-                       case OutputParams::DVILUATEX:
+                       case Flavor::DviLuaTeX:
                                latexparam = " --latex=dvilualatex";
                                break;
                        default:
-                               flavor = OutputParams::LATEX;
+                               flavor = Flavor::LaTeX;
                }
        }
        dumpPreamble(os, flavor);
        // handle inputenc etc.
-       // I think, this is already hadled by dumpPreamble(): Kornel
+       // I think this is already handled by dumpPreamble(): Kornel
        // buffer_.params().writeEncodingPreamble(os, features);
        of << "\n\\begin{document}\n";
        dumpData(of, inprogress.snippets);
@@ -704,7 +679,7 @@ void PreviewLoader::Impl::startLoading(bool wait)
 
        // The conversion command.
        ostringstream cs;
-       cs << pconverter_->command()
+       cs << subst(pconverter_->command(), "$${python}", os::python())
           << " " << quoteName(latexfile.toFilesystemEncoding())
           << " --dpi " << font_scaling_factor_;
 
@@ -727,7 +702,8 @@ void PreviewLoader::Impl::startLoading(bool wait)
        if (wait) {
                ForkedCall call(buffer_.filePath(), buffer_.layoutPos());
                int ret = call.startScript(ForkedProcess::Wait, command);
-               static atomic_int fake((2^20) + 1);
+               // PID_MAX_LIMIT is 2^22 so we start one after that
+               static atomic_int fake((1 << 22) + 1);
                int pid = fake++;
                inprogress.pid = pid;
                inprogress.command = command;
@@ -738,9 +714,12 @@ void PreviewLoader::Impl::startLoading(bool wait)
 
        // Initiate the conversion from LaTeX to bitmap images files.
        ForkedCall::sigPtr convert_ptr = make_shared<ForkedCall::sig>();
-       convert_ptr->connect(ForkedProcess::slot([this](pid_t pid, int retval){
-                               finishedGenerating(pid, retval);
-                       }).track_foreign(trackable_.p()));
+       weak_ptr<PreviewLoader::Impl> this_ = parent_.pimpl_;
+       convert_ptr->connect([this_](pid_t pid, int retval){
+                       if (auto p = this_.lock()) {
+                               p->finishedGenerating(pid, retval);
+                       }
+               });
 
        ForkedCall call(buffer_.filePath());
        int ret = call.startScript(command, convert_ptr);
@@ -796,7 +775,7 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
 
        list<PreviewImagePtr> newimages;
 
-       int metrics_counter = 0;
+       size_t metrics_counter = 0;
        for (; it != end; ++it, ++metrics_counter) {
                string const & snip = it->first;
                FileName const & file = it->second;
@@ -828,10 +807,10 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
 }
 
 
-void PreviewLoader::Impl::dumpPreamble(otexstream & os, OutputParams::FLAVOR flavor) const
+void PreviewLoader::Impl::dumpPreamble(otexstream & os, Flavor flavor) const
 {
        // Dump the preamble only.
-       LYXERR(Debug::LATEX, "dumpPreamble, flavor == " << flavor);
+       LYXERR(Debug::LATEX, "dumpPreamble, flavor == " << static_cast<int>(flavor));
        OutputParams runparams(&buffer_.params().encoding());
        runparams.flavor = flavor;
        runparams.nice = true;
@@ -841,11 +820,11 @@ void PreviewLoader::Impl::dumpPreamble(otexstream & os, OutputParams::FLAVOR fla
        buffer_.writeLaTeXSource(os, buffer_.filePath(), runparams, Buffer::OnlyPreamble);
 
        // FIXME! This is a HACK! The proper fix is to control the 'true'
-       // passed to WriteStream below:
+       // passed to TeXMathStream below:
        // int InsetMathNest::latex(Buffer const &, odocstream & os,
        //                          OutputParams const & runparams) const
        // {
-       //      WriteStream wi(os, runparams.moving_arg, true);
+       //      TeXMathStream wi(os, runparams.moving_arg, true);
        //      par_->write(wi);
        //      return wi.line();
        // }