]> git.lyx.org Git - lyx.git/blobdiff - src/graphics/PreviewLoader.cpp
Do not compute metrics at each preview when loading file
[lyx.git] / src / graphics / PreviewLoader.cpp
index 26c9b3c977d04f192359d4259e0ca16f3add424a..004ced6d899a742c317299951cf1638622eeef51 100644 (file)
 #include "Converter.h"
 #include "Encoding.h"
 #include "Format.h"
-#include "InsetIterator.h"
-#include "LaTeXFeatures.h"
 #include "LyXRC.h"
 #include "output.h"
 #include "OutputParams.h"
 #include "TexRow.h"
+#include "texstream.h"
 
 #include "frontends/Application.h" // hexName
 
-#include "insets/Inset.h"
-
 #include "support/convert.h"
 #include "support/debug.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
 #include "support/ForkedCalls.h"
 #include "support/lstrings.h"
+#include "support/os.h"
 
-#include "support/bind.h"
+#include "support/TempFile.h"
 
-#include <sstream>
+#include <atomic>
 #include <fstream>
 #include <iomanip>
+#include <memory>
+#include <mutex>
+#include <sstream>
+
+#include <QTimer>
 
 using namespace std;
+using namespace lyx;
 using namespace lyx::support;
 
 
 
 namespace {
 
-typedef pair<string, FileName> SnippetPair;
+typedef pair<docstring, FileName> SnippetPair;
 
 // A list of all snippets to be converted to previews
-typedef list<string> PendingSnippets;
+typedef list<docstring> PendingSnippets;
 
 // Each item in the vector is a pair<snippet, image file name>.
 typedef vector<SnippetPair> BitmapFile;
 
 
-string const unique_filename(string const & bufferpath)
+FileName const unique_tex_filename(FileName const & bufferpath)
 {
-       static int theCounter = 0;
-       string const filename = lyx::convert<string>(theCounter++) + "lyxpreview";
-       return addName(bufferpath, filename);
-}
-
-
-lyx::Converter const * setConverter(string const from)
-{
-       typedef vector<string> FmtList;
-       typedef lyx::graphics::Cache GCache;
-       FmtList const & loadableFormats = GCache::get().loadableFormats();
-       FmtList::const_iterator it = loadableFormats.begin();
-       FmtList::const_iterator const end = loadableFormats.end();
-
-       for (; it != end; ++it) {
-               string const to = *it;
-               if (from == to)
-                       continue;
-
-               lyx::Converter const * ptr = lyx::theConverters().getConverter(from, to);
-               if (ptr)
-                       return ptr;
-       }
-
-       static bool first = true;
-       if (first) {
-               first = false;
-               LYXERR0("PreviewLoader::startLoading()\n"
-                       << "No converter from \"" << from << "\" format has been defined.");
-       }
-       return 0;
+       TempFile tempfile(bufferpath, "lyxpreviewXXXXXX.tex");
+       tempfile.setAutoRemove(false);
+       return tempfile.name();
 }
 
 
@@ -146,14 +122,10 @@ void setAscentFractions(vector<double> & ascent_fractions,
 }
 
 
-class FindFirst
+std::function <bool (SnippetPair const &)> FindFirst(docstring const & comp)
 {
-public:
-       FindFirst(string const & comp) : comp_(comp) {}
-       bool operator()(SnippetPair const & sp) const { return sp.first == comp_; }
-private:
-       string const comp_;
-};
+       return [&comp](SnippetPair const & sp) { return sp.first == comp; };
+}
 
 
 /// Store info on a currently executing, forked process.
@@ -168,64 +140,67 @@ public:
        /// Remove any files left lying around and kill the forked process.
        void stop() const;
 
-       ///
-       pid_t pid;
        ///
        string command;
        ///
        FileName metrics_file;
        ///
        BitmapFile snippets;
+       ///
+       pid_t pid;
 };
 
 typedef map<pid_t, InProgress>  InProgressProcesses;
 
 typedef InProgressProcesses::value_type InProgressProcess;
 
-} // namespace anon
-
+} // namespace
 
 
 namespace lyx {
 namespace graphics {
 
-class PreviewLoader::Impl : public boost::signals::trackable {
+class PreviewLoader::Impl {
 public:
        ///
        Impl(PreviewLoader & p, Buffer const & b);
        /// Stop any InProgress items still executing.
        ~Impl();
        ///
-       PreviewImage const * preview(string const & latex_snippet) const;
+       PreviewImage const * preview(docstring const & latex_snippet) const;
        ///
-       PreviewLoader::Status status(string const & latex_snippet) const;
+       PreviewLoader::Status status(docstring const & latex_snippet) const;
        ///
-       void add(string const & latex_snippet);
+       void add(docstring const & latex_snippet);
        ///
-       void remove(string const & latex_snippet);
+       void remove(docstring const & latex_snippet);
        /// \p wait whether to wait for the process to complete or, instead,
        /// to do it in the background.
        void startLoading(bool wait = false);
+       ///
+       void refreshPreviews();
 
        /// Emit this signal when an image is ready for display.
-       boost::signal<void(PreviewImage const &)> imageReady;
+       signal<void(PreviewImage const &)> imageReady;
 
        Buffer const & buffer() const { return buffer_; }
 
+       lyx::Converter const * setConverter(string const & from);
+
 private:
        /// Called by the ForkedCall process that generated the bitmap files.
        void finishedGenerating(pid_t, int);
        ///
-       void dumpPreamble(otexstream &) const;
+       void dumpPreamble(otexstream &, Flavor) const;
        ///
        void dumpData(odocstream &, BitmapFile const &) const;
 
        /** cache_ allows easy retrieval of already-generated images
         *  using the LaTeX snippet as the identifier.
         */
-       typedef shared_ptr<PreviewImage> PreviewImagePtr;
+       typedef std::shared_ptr<PreviewImage> PreviewImagePtr;
        ///
-       typedef map<string, PreviewImagePtr> Cache;
+       typedef map<docstring, PreviewImagePtr> Cache;
        ///
        Cache cache_;
 
@@ -236,7 +211,6 @@ private:
 
        /** in_progress_ stores all forked processes so that we can proceed
         *  thereafter.
-           The map uses the conversion commands as its identifiers.
         */
        InProgressProcesses in_progress_;
 
@@ -244,9 +218,20 @@ private:
        PreviewLoader & parent_;
        ///
        Buffer const & buffer_;
+       ///
+       mutable int font_scaling_factor_;
+       ///
+       mutable int fg_color_;
+       ///
+       mutable int bg_color_;
+       ///
+       QTimer * delay_refresh_;
+       ///
+       bool finished_generating_;
 
        /// We don't own this
        static lyx::Converter const * pconverter_;
+
 };
 
 
@@ -258,35 +243,29 @@ lyx::Converter const * PreviewLoader::Impl::pconverter_;
 //
 
 PreviewLoader::PreviewLoader(Buffer const & b)
-       : pimpl_(new Impl(*this, b))
+       : pimpl_(make_shared<Impl>(*this, b))
 {}
 
 
-PreviewLoader::~PreviewLoader()
-{
-       delete pimpl_;
-}
-
-
-PreviewImage const * PreviewLoader::preview(string const & latex_snippet) const
+PreviewImage const * PreviewLoader::preview(docstring const & latex_snippet) const
 {
        return pimpl_->preview(latex_snippet);
 }
 
 
-PreviewLoader::Status PreviewLoader::status(string const & latex_snippet) const
+PreviewLoader::Status PreviewLoader::status(docstring const & latex_snippet) const
 {
        return pimpl_->status(latex_snippet);
 }
 
 
-void PreviewLoader::add(string const & latex_snippet) const
+void PreviewLoader::add(docstring const & latex_snippet) const
 {
        pimpl_->add(latex_snippet);
 }
 
 
-void PreviewLoader::remove(string const & latex_snippet) const
+void PreviewLoader::remove(docstring const & latex_snippet) const
 {
        pimpl_->remove(latex_snippet);
 }
@@ -298,7 +277,13 @@ void PreviewLoader::startLoading(bool wait) const
 }
 
 
-boost::signals::connection PreviewLoader::connect(slot_type const & slot) const
+void PreviewLoader::refreshPreviews()
+{
+       pimpl_->refreshPreviews();
+}
+
+
+connection PreviewLoader::connect(slot const & slot) const
 {
        return pimpl_->imageReady.connect(slot);
 }
@@ -331,13 +316,12 @@ public:
                : to_format_(to_format), base_(filename_base), counter_(1)
        {}
 
-       SnippetPair const operator()(string const & snippet)
+       SnippetPair const operator()(docstring const & snippet)
        {
                ostringstream os;
                os << base_ << counter_++ << '.' << to_format_;
-               string const file = os.str();
-
-               return make_pair(snippet, FileName(file));
+               string const file_name = os.str();
+               return make_pair(snippet, FileName(file_name));
        }
 
 private:
@@ -350,9 +334,8 @@ private:
 InProgress::InProgress(string const & filename_base,
                       PendingSnippets const & pending,
                       string const & to_format)
-       : pid(0),
-         metrics_file(filename_base + ".metrics"),
-         snippets(pending.size())
+       : metrics_file(filename_base + ".metrics"),
+         snippets(pending.size()), pid(0)
 {
        PendingSnippets::const_iterator pit  = pending.begin();
        PendingSnippets::const_iterator pend = pending.end();
@@ -379,22 +362,66 @@ void InProgress::stop() const
        }
 }
 
-} // namespace anon
+} // namespace
 
 
 namespace lyx {
 namespace graphics {
 
 PreviewLoader::Impl::Impl(PreviewLoader & p, Buffer const & b)
-       : parent_(p), buffer_(b)
+       : parent_(p), buffer_(b), finished_generating_(true)
 {
+       font_scaling_factor_ = int(buffer_.fontScalingFactor());
+       if (theApp()) {
+               fg_color_ = convert(theApp()->hexName(foregroundColor()), 16);
+               bg_color_ = convert(theApp()->hexName(backgroundColor()), 16);
+       } else {
+               fg_color_ = 0x0;
+               bg_color_ = 0xffffff;
+       }
        if (!pconverter_)
                pconverter_ = setConverter("lyxpreview");
+
+       delay_refresh_ = new QTimer(&parent_);
+       delay_refresh_->setSingleShot(true);
+       QObject::connect(delay_refresh_, SIGNAL(timeout()),
+                        &parent_, SLOT(refreshPreviews()));
+}
+
+
+lyx::Converter const * PreviewLoader::Impl::setConverter(string const & from)
+{
+       typedef vector<string> FmtList;
+       FmtList const & loadableFormats = graphics::Cache::get().loadableFormats();
+       FmtList::const_iterator it = loadableFormats.begin();
+       FmtList::const_iterator const end = loadableFormats.end();
+
+       for (; it != end; ++it) {
+               string const to = *it;
+               if (from == to)
+                       continue;
+
+               lyx::Converter const * ptr = lyx::theConverters().getConverter(from, to);
+               if (ptr)
+                       return ptr;
+       }
+
+       // Show the error only once. This is thread-safe.
+       static nullptr_t no_conv = [&]{
+               LYXERR0("PreviewLoader::startLoading()\n"
+                       << "No converter from \"" << from
+                       << "\" format has been defined.");
+               return nullptr;
+       } ();
+
+       return no_conv;
 }
 
 
 PreviewLoader::Impl::~Impl()
 {
+       delete delay_refresh_;
+
        InProgressProcesses::iterator ipit  = in_progress_.begin();
        InProgressProcesses::iterator ipend = in_progress_.end();
 
@@ -404,34 +431,65 @@ PreviewLoader::Impl::~Impl()
 
 
 PreviewImage const *
-PreviewLoader::Impl::preview(string const & latex_snippet) const
+PreviewLoader::Impl::preview(docstring const & latex_snippet) const
 {
+       int fs = int(buffer_.fontScalingFactor());
+       int fg = 0x0;
+       int bg = 0xffffff;
+       if (theApp()) {
+               fg = convert(theApp()->hexName(foregroundColor()), 16);
+               bg = convert(theApp()->hexName(backgroundColor()), 16);
+       }
+       if (font_scaling_factor_ != fs || fg_color_ != fg || bg_color_ != bg) {
+               // Schedule refresh of all previews on zoom or color changes.
+               // The previews are regenerated only after the zoom factor
+               // has not been changed for about 1 second.
+               fg_color_ = fg;
+               bg_color_ = bg;
+               delay_refresh_->start(1000);
+       }
+       // Don't try to access the cache until we are done.
+       if (delay_refresh_->isActive() || !finished_generating_)
+               return nullptr;
+
        Cache::const_iterator it = cache_.find(latex_snippet);
-       return (it == cache_.end()) ? 0 : it->second.get();
+       return (it == cache_.end()) ? nullptr : it->second.get();
+}
+
+
+void PreviewLoader::Impl::refreshPreviews()
+{
+       font_scaling_factor_ = int(buffer_.fontScalingFactor());
+       // Reschedule refresh until the previous process completed.
+       if (!finished_generating_) {
+               delay_refresh_->start(1000);
+               return;
+       }
+       Cache::const_iterator cit = cache_.begin();
+       Cache::const_iterator cend = cache_.end();
+       while (cit != cend)
+               parent_.remove((cit++)->first);
+       finished_generating_ = false;
+       buffer_.updatePreviews();
 }
 
 
 namespace {
 
-class FindSnippet {
-public:
-       FindSnippet(string const & s) : snippet_(s) {}
-       bool operator()(InProgressProcess const & process) const
-       {
+std::function<bool (InProgressProcess const &)> FindSnippet(docstring const & s)
+{
+       return [&s](InProgressProcess const & process) {
                BitmapFile const & snippets = process.second.snippets;
                BitmapFile::const_iterator beg  = snippets.begin();
                BitmapFile::const_iterator end = snippets.end();
-               return find_if(beg, end, FindFirst(snippet_)) != end;
-       }
-
-private:
-       string const snippet_;
-};
+               return find_if(beg, end, FindFirst(s)) != end;
+       };
+}
 
-} // namespace anon
+} // namespace
 
 PreviewLoader::Status
-PreviewLoader::Impl::status(string const & latex_snippet) const
+PreviewLoader::Impl::status(docstring const & latex_snippet) const
 {
        Cache::const_iterator cit = cache_.find(latex_snippet);
        if (cit != cache_.end())
@@ -455,12 +513,12 @@ PreviewLoader::Impl::status(string const & latex_snippet) const
 }
 
 
-void PreviewLoader::Impl::add(string const & latex_snippet)
+void PreviewLoader::Impl::add(docstring const & latex_snippet)
 {
        if (!pconverter_ || status(latex_snippet) != NotFound)
                return;
 
-       string const snippet = trim(latex_snippet);
+       docstring const snippet = trim(latex_snippet);
        if (snippet.empty())
                return;
 
@@ -472,28 +530,23 @@ void PreviewLoader::Impl::add(string const & latex_snippet)
 
 namespace {
 
-class EraseSnippet {
-public:
-       EraseSnippet(string const & s) : snippet_(s) {}
-       void operator()(InProgressProcess & process)
-       {
+std::function<void (InProgressProcess &)> EraseSnippet(docstring const & s)
+{
+       return [&s](InProgressProcess & process) {
                BitmapFile & snippets = process.second.snippets;
                BitmapFile::iterator it  = snippets.begin();
                BitmapFile::iterator end = snippets.end();
 
-               it = find_if(it, end, FindFirst(snippet_));
+               it = find_if(it, end, FindFirst(s));
                if (it != end)
                        snippets.erase(it, it+1);
-       }
-
-private:
-       string const & snippet_;
-};
+       };
+}
 
-} // namespace anon
+} // namespace
 
 
-void PreviewLoader::Impl::remove(string const & latex_snippet)
+void PreviewLoader::Impl::remove(docstring const & latex_snippet)
 {
        Cache::iterator cit = cache_.find(latex_snippet);
        if (cit != cache_.end())
@@ -529,35 +582,30 @@ void PreviewLoader::Impl::startLoading(bool wait)
        LYXERR(Debug::GRAPHICS, "PreviewLoader::startLoading()");
 
        // As used by the LaTeX file and by the resulting image files
-       string const directory = buffer_.temppath();
+       FileName const directory(buffer_.temppath());
 
-       string const filename_base = unique_filename(directory);
+       FileName const latexfile = unique_tex_filename(directory);
+       string const filename_base = removeExtension(latexfile.absFileName());
 
        // Create an InProgress instance to place in the map of all
        // such processes if it starts correctly.
-       InProgress inprogress(filename_base, pending_, pconverter_->to);
+       InProgress inprogress(filename_base, pending_, pconverter_->to());
 
        // clear pending_, so we're ready to start afresh.
        pending_.clear();
 
        // Output the LaTeX file.
-       FileName const latexfile(filename_base + ".tex");
-
        // we use the encoding of the buffer
        Encoding const & enc = buffer_.params().encoding();
        ofdocstream of;
        try { of.reset(enc.iconvName()); }
-       catch (iconv_codecvt_facet_exception & e) {
+       catch (iconv_codecvt_facet_exception const & e) {
                LYXERR0("Caught iconv exception: " << e.what()
                        << "\nUnable to create LaTeX file: " << latexfile);
                return;
        }
 
-       TexRow texrow;
-       otexstream os(of, texrow);
-       OutputParams runparams(&enc);
-       LaTeXFeatures features(buffer_, buffer_.params(), runparams);
-
+       otexstream os(of);
        if (!openFileWrite(of, latexfile))
                return;
 
@@ -567,9 +615,50 @@ void PreviewLoader::Impl::startLoading(bool wait)
                return;
        }
        of << "\\batchmode\n";
-       dumpPreamble(os);
+
+       LYXERR(Debug::OUTFILE, "Format = " << buffer_.params().getDefaultOutputFormat());
+       string latexparam = "";
+       bool docformat = !buffer_.params().default_output_format.empty()
+                       && buffer_.params().default_output_format != "default";
+       // Use LATEX flavor if the document does not specify a specific
+       // output format (see bug 9371).
+       Flavor flavor = docformat
+                                       ? buffer_.params().getOutputFlavor()
+                                       : Flavor::LaTeX;
+       if (buffer_.params().encoding().package() == Encoding::japanese) {
+               latexparam = " --latex=platex";
+               flavor = Flavor::LaTeX;
+       }
+       else if (buffer_.params().useNonTeXFonts) {
+               if (flavor == Flavor::LuaTeX)
+                       latexparam = " --latex=lualatex";
+               else {
+                       flavor = Flavor::XeTeX;
+                       latexparam = " --latex=xelatex";
+               }
+       }
+       else {
+               switch (flavor) {
+                       case Flavor::PdfLaTeX:
+                               latexparam = " --latex=pdflatex";
+                               break;
+                       case Flavor::XeTeX:
+                               latexparam = " --latex=xelatex";
+                               break;
+                       case Flavor::LuaTeX:
+                               latexparam = " --latex=lualatex";
+                               break;
+                       case Flavor::DviLuaTeX:
+                               latexparam = " --latex=dvilualatex";
+                               break;
+                       default:
+                               flavor = Flavor::LaTeX;
+               }
+       }
+       dumpPreamble(os, flavor);
        // handle inputenc etc.
-       buffer_.params().writeEncodingPreamble(os, features);
+       // I think this is already handled by dumpPreamble(): Kornel
+       // buffer_.params().writeEncodingPreamble(os, features);
        of << "\n\\begin{document}\n";
        dumpData(of, inprogress.snippets);
        of << "\n\\end{document}\n";
@@ -580,43 +669,33 @@ void PreviewLoader::Impl::startLoading(bool wait)
                return;
        }
 
-       double const font_scaling_factor = 
-               buffer_.isExporting() ? 75.0 * buffer_.params().html_math_img_scale 
-                       : 0.01 * lyxrc.dpi * lyxrc.zoom * lyxrc.preview_scale_factor;
-
-       // FIXME XHTML 
-       // The colors should be customizable.
-       ColorCode const bg = buffer_.isExporting() 
-                      ? Color_white : PreviewLoader::backgroundColor();
-       ColorCode const fg = buffer_.isExporting() 
-                      ? Color_black : PreviewLoader::foregroundColor();
        // The conversion command.
        ostringstream cs;
-       cs << pconverter_->command
+       cs << subst(pconverter_->command(), "$${python}", os::python())
           << " " << quoteName(latexfile.toFilesystemEncoding())
-          << " --dpi " << int(font_scaling_factor)
-          << " --fg " << theApp()->hexName(fg)
-          << " --bg " << theApp()->hexName(bg);
-       // FIXME what about LuaTeX?
-       if (buffer_.params().useNonTeXFonts)
-               cs << " --latex=xelatex";
-       if (buffer_.params().encoding().package() == Encoding::japanese)
-               cs << " --latex=platex";
-       if (buffer_.params().bibtex_command != "default")
-               cs << " --bibtex=" << quoteName(buffer_.params().bibtex_command);
-       else if (buffer_.params().encoding().package() == Encoding::japanese)
-               cs << " --bibtex=" << quoteName(lyxrc.jbibtex_command);
-       else
-               cs << " --bibtex=" << quoteName(lyxrc.bibtex_command);
+          << " --dpi " << font_scaling_factor_;
+
+       // FIXME XHTML
+       // The colors should be customizable.
+       if (!buffer_.isExporting()) {
+               ColorCode const fg = PreviewLoader::foregroundColor();
+               ColorCode const bg = PreviewLoader::backgroundColor();
+               cs << " --fg " << theApp()->hexName(fg)
+                  << " --bg " << theApp()->hexName(bg);
+       }
+
+       cs << latexparam;
+       cs << " --bibtex=" << quoteName(buffer_.params().bibtexCommand());
        if (buffer_.params().bufferFormat() == "lilypond-book")
                cs << " --lilypond";
 
-       string const command = libScriptSearch(cs.str());
+       string const command = cs.str();
 
        if (wait) {
-               ForkedCall call(buffer_.filePath());
+               ForkedCall call(buffer_.filePath(), buffer_.layoutPos());
                int ret = call.startScript(ForkedProcess::Wait, command);
-               static int fake = (2^20) + 1;
+               // PID_MAX_LIMIT is 2^22 so we start one after that
+               static atomic_int fake((1 << 22) + 1);
                int pid = fake++;
                inprogress.pid = pid;
                inprogress.command = command;
@@ -626,9 +705,13 @@ void PreviewLoader::Impl::startLoading(bool wait)
        }
 
        // Initiate the conversion from LaTeX to bitmap images files.
-       ForkedCall::SignalTypePtr
-               convert_ptr(new ForkedCall::SignalType);
-       convert_ptr->connect(bind(&Impl::finishedGenerating, this, _1, _2));
+       ForkedCall::sigPtr convert_ptr = make_shared<ForkedCall::sig>();
+       weak_ptr<PreviewLoader::Impl> this_ = parent_.pimpl_;
+       convert_ptr->connect([this_](pid_t pid, int retval){
+                       if (auto p = this_.lock()) {
+                               p->finishedGenerating(pid, retval);
+                       }
+               });
 
        ForkedCall call(buffer_.filePath());
        int ret = call.startScript(command, convert_ptr);
@@ -646,6 +729,11 @@ void PreviewLoader::Impl::startLoading(bool wait)
 }
 
 
+double PreviewLoader::displayPixelRatio() const
+{
+       return buffer().params().display_pixel_ratio;
+}
+
 void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
 {
        // Paranoia check!
@@ -653,6 +741,7 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
        if (git == in_progress_.end()) {
                lyxerr << "PreviewLoader::finishedGenerating(): unable to find "
                        "data for PID " << pid << endl;
+               finished_generating_ = true;
                return;
        }
 
@@ -661,8 +750,11 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
        LYXERR(Debug::GRAPHICS, "PreviewLoader::finishedInProgress("
                                << retval << "): processing " << status
                                << " for " << command);
-       if (retval > 0)
+       if (retval > 0) {
+               in_progress_.erase(git);
+               finished_generating_ = true;
                return;
+       }
 
        // Read the metrics file, if it exists
        vector<double> ascent_fractions(git->second.snippets.size());
@@ -675,14 +767,15 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
 
        list<PreviewImagePtr> newimages;
 
-       int metrics_counter = 0;
+       size_t metrics_counter = 0;
        for (; it != end; ++it, ++metrics_counter) {
-               string const & snip = it->first;
+               docstring const & snip = it->first;
                FileName const & file = it->second;
                double af = ascent_fractions[metrics_counter];
 
                // Add the image to the cache only if it's actually present
-               if (file.isReadableFile()) {
+               // and not empty (an empty image is signaled by af < 0)
+               if (af >= 0 && file.isReadableFile()) {
                        PreviewImagePtr ptr(new PreviewImage(parent_, snip, file, af));
                        cache_[snip] = ptr;
 
@@ -694,6 +787,16 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
        // Remove the item from the list of still-executing processes.
        in_progress_.erase(git);
 
+#if 0
+       /* FIXME : there is no need for all these calls, which recompute
+        * all metrics for each and every preview. The single call at the
+        * end of this method is sufficient.
+
+        * It seems that this whole imageReady mechanism is actually not
+        * needed. If it is the case, the whole updateFrontend/updateInset
+        * bloat can go too.
+        */
+
        // Tell the outside world
        list<PreviewImagePtr>::const_reverse_iterator
                nit  = newimages.rbegin();
@@ -702,28 +805,32 @@ void PreviewLoader::Impl::finishedGenerating(pid_t pid, int retval)
        for (; nit != nend; ++nit) {
                imageReady(*nit->get());
        }
+#endif
+
+       finished_generating_ = true;
+       buffer_.scheduleRedrawWorkAreas();
 }
 
 
-void PreviewLoader::Impl::dumpPreamble(otexstream & os) const
+void PreviewLoader::Impl::dumpPreamble(otexstream & os, Flavor flavor) const
 {
        // Dump the preamble only.
+       LYXERR(Debug::OUTFILE, "dumpPreamble, flavor == " << static_cast<int>(flavor));
        OutputParams runparams(&buffer_.params().encoding());
-       if (buffer_.params().useNonTeXFonts)
-               runparams.flavor = OutputParams::XETEX;
-       else
-               runparams.flavor = OutputParams::LATEX;
+       runparams.flavor = flavor;
        runparams.nice = true;
        runparams.moving_arg = true;
        runparams.free_spacing = true;
+       runparams.is_child = buffer_.parent();
+       runparams.for_preview = true;
        buffer_.writeLaTeXSource(os, buffer_.filePath(), runparams, Buffer::OnlyPreamble);
 
        // FIXME! This is a HACK! The proper fix is to control the 'true'
-       // passed to WriteStream below:
+       // passed to TeXMathStream below:
        // int InsetMathNest::latex(Buffer const &, odocstream & os,
        //                          OutputParams const & runparams) const
        // {
-       //      WriteStream wi(os, runparams.moving_arg, true);
+       //      TeXMathStream wi(os, runparams.moving_arg, true);
        //      par_->write(wi);
        //      return wi.line();
        // }
@@ -755,13 +862,32 @@ void PreviewLoader::Impl::dumpData(odocstream & os,
        BitmapFile::const_iterator it  = vec.begin();
        BitmapFile::const_iterator end = vec.end();
 
+       Encoding const & enc = buffer_.params().encoding();
+
        for (; it != end; ++it) {
-               // FIXME UNICODE
-               os << "\\begin{preview}\n"
-                  << from_utf8(it->first)
-                  << "\n\\end{preview}\n\n";
+               bool uncodable_content = false;
+               // check whether the content is encodable
+               // FIXME: the preview loader should be able
+               //        to handle multiple encodings
+               //        or we should generally use utf8
+               for (char_type n : it->first) {
+                       if (!enc.encodable(n)) {
+                               LYXERR0("Uncodable character '"
+                                       << docstring(1, n)
+                                       << "' in preview snippet!");
+                               uncodable_content = true;
+                               break;
+                       }
+               }
+               os << "\\begin{preview}\n";
+               // do not show incomplete preview
+               if (!uncodable_content)
+                       os << it->first;
+               os << "\n\\end{preview}\n\n";
        }
 }
 
 } // namespace graphics
 } // namespace lyx
+
+#include "moc_PreviewLoader.cpp"