#include "GraphicsConverter.h"
+#include "Buffer.h"
#include "Converter.h"
#include "Format.h"
+#include "LyXRC.h"
+#include "frontends/alert.h"
#include "support/lassert.h"
#include "support/convert.h"
#include "support/debug.h"
#include "support/lstrings.h"
#include "support/os.h"
-#include "support/bind.h"
#include "support/TempFile.h"
#include <sstream>
namespace graphics {
-class Converter::Impl : public boost::signals::trackable {
+class Converter::Impl {
public:
///
- Impl(FileName const &, string const &, string const &, string const &);
+ Impl(FileName const & doc_fname,
+ FileName const & from_file, string const & to_file_base,
+ string const & from_format, string const & to_format);
///
void startConversion();
/** At the end of the conversion process inform the outside world
* by emitting a signal.
*/
- typedef boost::signal<void(bool)> SignalType;
+ typedef signals2::signal<void(bool)> sig;
///
- SignalType finishedConversion;
+ sig finishedConversion;
+ ///
+ FileName const doc_fname_;
///
string script_command_;
///
bool valid_process_;
///
bool finished_;
+ ///
+ Trackable tracker_;
};
}
-Converter::Converter(FileName const & from_file, string const & to_file_base,
- string const & from_format, string const & to_format)
- : pimpl_(new Impl(from_file, to_file_base, from_format, to_format))
+Converter::Converter(FileName const & doc_fname,
+ FileName const & from_file, string const & to_file_base,
+ string const & from_format, string const & to_format)
+ : pimpl_(new Impl(doc_fname, from_file, to_file_base, from_format, to_format))
{}
}
-boost::signals::connection Converter::connect(slot_type const & slot) const
+signals2::connection Converter::connect(slot_type const & slot) const
{
return pimpl_->finishedConversion.connect(slot);
}
/** Build the conversion script.
* The script is output to the stream \p script.
*/
-static void build_script(string const & from_file, string const & to_file_base,
+static void build_script(string const & doc_fname,
+ string const & from_file, string const & to_file_base,
string const & from_format, string const & to_format,
ostream & script);
-Converter::Impl::Impl(FileName const & from_file, string const & to_file_base,
+Converter::Impl::Impl(FileName const & doc_fname,
+ FileName const & from_file, string const & to_file_base,
string const & from_format, string const & to_format)
- : valid_process_(false), finished_(false)
+ : doc_fname_(doc_fname), valid_process_(false), finished_(false)
{
LYXERR(Debug::GRAPHICS, "Converter c-tor:\n"
- << "\tfrom_file: " << from_file
+ << "doc_fname: " << doc_fname
+ << "\n\tfrom_file: " << from_file
<< "\n\tto_file_base: " << to_file_base
<< "\n\tfrom_format: " << from_format
<< "\n\tto_format: " << to_format);
// The converted image is to be stored in this file (we do not
// use ChangeExtension because this is a basename which may
// nevertheless contain a '.')
- to_file_ = FileName(to_file_base + '.' + formats.extension(to_format));
+ to_file_ = FileName(to_file_base + '.' + theFormats().extension(to_format));
// The conversion commands are stored in a stringstream
ostringstream script;
- build_script(from_file.toFilesystemEncoding(),
+ build_script(doc_fname_.absFileName(), from_file.toFilesystemEncoding(),
to_file_.toFilesystemEncoding(),
from_format, to_format, script);
LYXERR(Debug::GRAPHICS, "\tConversion script:"
<< "\n--------------------------------------\n");
// Output the script to file.
- // FIXME THREAD
- static int counter = 0;
- script_file_ = FileName(onlyPath(to_file_base) + "lyxconvert" +
- convert<string>(counter++) + ".py");
+ TempFile tempfile(to_file_.onlyPath(), "lyxconvertXXXXXX.py");
+ tempfile.setAutoRemove(false);
+ script_file_ = tempfile.name();
ofstream fs(script_file_.toFilesystemEncoding().c_str());
if (!fs.good()) {
return;
}
- ForkedCall::SignalTypePtr ptr =
- ForkedCallQueue::add(script_command_);
- ptr->connect(bind(&Impl::converted, this, _1, _2));
+ ForkedCall::sigPtr ptr = ForkedCallQueue::add(script_command_);
+ ptr->connect(ForkedCall::slot([this](pid_t pid, int retval){
+ converted(pid, retval);
+ }).track_foreign(tracker_.p()));
}
static void build_conversion_command(string const & command, ostream & script)
{
// Store in the python script
- script << "\nif os.system(r'" << command << "') != 0:\n";
+ script << "\nif os.system(r'" << commandPrep(command) << "') != 0:\n";
// Test that this was successful. If not, remove
// ${outfile} and exit the python script
}
-static void build_script(string const & from_file,
+static void build_script(string const & doc_fname,
+ string const & from_file,
string const & to_file,
string const & from_format,
string const & to_format,
LYXERR(Debug::GRAPHICS, "build_script ... ");
typedef Graph::EdgePath EdgePath;
- script << "#!/usr/bin/env python\n"
- "# -*- coding: utf-8 -*-\n"
+ script << "# -*- coding: utf-8 -*-\n"
"import os, shutil, sys\n\n"
"def unlinkNoThrow(file):\n"
" ''' remove a file, do not throw if an error occurs '''\n"
theConverters().getPath(from_format, to_format);
// Create a temporary base file-name for all intermediate steps.
- // Remember to remove the temp file because we only want the name...
- // FIXME THREAD
- static int counter = 0;
- string const tmp = "gconvert" + convert<string>(counter++);
- TempFile tempfile(tmp);
+ string const from_ext = getExtension(from_file);
+ TempFile tempfile(addExtension("gconvertXXXXXX", from_ext));
tempfile.setAutoRemove(false);
- string const to_base = tempfile.name().toFilesystemEncoding();
+ string outfile = tempfile.name().toFilesystemEncoding();
+ string const to_base = from_ext.empty() ? outfile : removeExtension(outfile);
// Create a copy of the file in case the original name contains
// problematic characters like ' or ". We can work around that problem
// in python, but the converters might be shell scripts and have more
// troubles with it.
- string outfile = addExtension(to_base, getExtension(from_file));
script << "infile = "
<< quoteName(from_file, quote_python)
<< "\n"
ostringstream os;
os << os::python() << ' '
<< commandPrep("$$s/scripts/convertDefault.py") << ' ';
- if (!from_format.empty())
- os << strip_digit(from_format) << ':';
+ if (from_format.empty())
+ os << "unknown ";
+ else
+ os << strip_digit(from_format) << ' ';
// The extra " quotes around infile and outfile are needed
// because the filename may contain spaces and it is used
// as argument of os.system().
os << "' + '\"' + infile + '\"' + ' "
- << strip_digit(to_format) << ":' + '\"' + outfile + '\"' + '";
+ << strip_digit(to_format) << " ' + '\"' + outfile + '\"' + '";
string const command = os.str();
LYXERR(Debug::GRAPHICS,
// Build the conversion command
string const infile = outfile;
string const infile_base = changeExtension(infile, string());
- outfile = conv.result_file.empty()
- ? addExtension(to_base, conv.To->extension())
- : addName(subst(conv.result_dir,
+ outfile = conv.result_file().empty()
+ ? addExtension(to_base, conv.To()->extension())
+ : addName(subst(conv.result_dir(),
token_base, infile_base),
- subst(conv.result_file,
+ subst(conv.result_file(),
token_base, onlyFileName(infile_base)));
// If two formats share the same extension we may get identical names
- if (outfile == infile && conv.result_file.empty()) {
- TempFile tempfile(tmp);
- tempfile.setAutoRemove(false);
- string const new_base = tempfile.name().toFilesystemEncoding();
- outfile = addExtension(new_base, conv.To->extension());
+ if (outfile == infile && conv.result_file().empty()) {
+ TempFile tmpfile(addExtension("gconvertXXXXXX", conv.To()->extension()));
+ tmpfile.setAutoRemove(false);
+ outfile = tmpfile.name().toFilesystemEncoding();
}
+ if (!theConverters().checkAuth(conv, doc_fname))
+ return;
+
// Store these names in the python script
script << "infile = "
<< quoteName(infile, quote_python) << "\n"
// See comment about extra " quotes above (although that
// applies only for the first loop run here).
- string command = conv.command;
+ string command = conv.command();
command = subst(command, token_from, "' + '\"' + infile + '\"' + '");
command = subst(command, token_base, "' + '\"' + infile_base + '\"' + '");
command = subst(command, token_to, "' + '\"' + outfile + '\"' + '");
projects / lyx.git / blobdiff