Remove unnecessary `c_str`

[lyx.git] / src / graphics / GraphicsCache.cpp

diff --git a/src/graphics/GraphicsCache.cpp b/src/graphics/GraphicsCache.cpp
index dbf9cafa5e93d0e14ccbefce7ab646280947cbfa..bf1b3fceff8476590772c89246ec0d1625576b4f 100644 (file)
--- a/src/graphics/GraphicsCache.cpp
+++ b/src/graphics/GraphicsCache.cpp
@@ -13,7 +13,6 @@
 
 #include "GraphicsCache.h"
 #include "GraphicsCacheItem.h"
-#include "GraphicsImage.h"
 
 #include "Format.h"
 
@@ -21,7 +20,6 @@
 
 #include "support/debug.h"
 #include "support/FileName.h"
-#include "support/filetools.h"
 
 #include <map>
 
@@ -70,18 +68,10 @@ vector<string> const & Cache::loadableFormats() const
        if (!fmts.empty())
                return fmts;
 
-       // The formats recognised by LyX
-       Formats::const_iterator begin = theFormats().begin();
-       Formats::const_iterator end   = theFormats().end();
-
-       // The formats natively loadable.
-       vector<string> nformat = frontend::loadableImageFormats();
-
-       vector<string>::const_iterator it = nformat.begin();
-       for (; it != nformat.end(); ++it) {
-               for (Formats::const_iterator fit = begin; fit != end; ++fit) {
-                       if (fit->extension() == *it) {
-                               fmts.push_back(fit->name());
+       for (string const & native_extension : frontend::loadableImageFormats()) {
+               for (Format const & format : theFormats()) {
+                       if (format.extension() == native_extension) {
+                               fmts.push_back(format.name());
                                break;
                        }
                }
@@ -89,11 +79,8 @@ vector<string> const & Cache::loadableFormats() const
 
        if (lyxerr.debugging()) {
                LYXERR(Debug::GRAPHICS, "LyX recognises the following image formats:");
-
-               vector<string>::const_iterator fbegin = fmts.begin();
-               vector<string>::const_iterator fend = fmts.end();
-               for (vector<string>::const_iterator fit = fbegin; fit != fend; ++fit) {
-                       LYXERR(Debug::GRAPHICS, *fit << ',');
+               for (string const & format : fmts) {
+                       LYXERR(Debug::GRAPHICS, format << ',');
                }
        }