]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/xforms/XWorkArea.C
remove defaults stuff, let Qt handle no toolbar
[lyx.git] / src / frontends / xforms / XWorkArea.C
index b11948732f8ac73433bea783fdabc004b5d63b08..561d90b5b56456ebc0ca3714179128319e747e9b 100644 (file)
@@ -1,63 +1,34 @@
 /**
  * \file XWorkArea.C
- * Copyright 1995-2002 the LyX Team
- * Read the file COPYING
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
  *
  * \author unknown
- * \author John Levon <moz@compsoc.man.ac.uk>
+ * \author John Levon
+ *
+ * Full author contact details are available in file CREDITS
  */
 
 #include <config.h>
 
-#ifdef __GNUG__
-#pragma implementation
-#endif
 
 #include "XWorkArea.h"
 #include "debug.h"
-#include "LyXView.h"
 #include "XLyXKeySym.h"
-#include "ColorHandler.h"
-
-#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5))
-#include "lyxlookup.h"
-#endif
-
-#include "support/filetools.h" // LibFileSearch
-#include "support/lstrings.h"
-#include "support/LAssert.h"
-
-#include <cmath>
-#include <cctype>
-
-// xforms doesn't define this (but it should be in <forms.h>).
-extern "C"
-FL_APPEVENT_CB fl_set_preemptive_callback(Window, FL_APPEVENT_CB, void *);
+#include "funcrequest.h"
+#include "Timeout.h"
 
 using std::endl;
 using std::abs;
 using std::hex;
+using std::dec;
 
 namespace {
 
 inline
-void waitForX()
+void waitForX(bool discard)
 {
-       XSync(fl_get_display(), 0);
-}
-
-
-void setXtermCursor(Window win)
-{
-       static Cursor cursor;
-       static bool cursor_undefined = true;
-       if (cursor_undefined) {
-               cursor = XCreateFontCursor(fl_get_display(), XC_xterm);
-               XFlush(fl_get_display());
-               cursor_undefined = false;
-       }
-       XDefineCursor(fl_get_display(), win, cursor);
-       XFlush(fl_get_display());
+       XSync(fl_get_display(), discard);
 }
 
 
@@ -65,45 +36,26 @@ mouse_button::state x_button_state(unsigned int button)
 {
        mouse_button::state b = mouse_button::none;
        switch (button) {
-               case Button1:
-                       b = mouse_button::button1;
-                       break;
-               case Button2:
-                       b = mouse_button::button2;
-                       break;
-               case Button3:
-                       b = mouse_button::button3;
-                       break;
-               case Button4:
-                       b = mouse_button::button4;
-                       break;
-               case Button5:
-                       b = mouse_button::button5;
-                       break;
-               default: // FIXME
-                       break;
+       case FL_MBUTTON1:
+               b = mouse_button::button1;
+               break;
+       case FL_MBUTTON2:
+               b = mouse_button::button2;
+               break;
+       case FL_MBUTTON3:
+               b = mouse_button::button3;
+               break;
+       case FL_MBUTTON4:
+               b = mouse_button::button4;
+               break;
+       case FL_MBUTTON5:
+               b = mouse_button::button5;
+               break;
        }
        return b;
 }
 
 
-mouse_button::state x_motion_state(unsigned int state)
-{
-       mouse_button::state b = mouse_button::none;
-       if (state & Button1MotionMask)
-               b |= mouse_button::button1;
-       if (state & Button2MotionMask)
-               b |= mouse_button::button2;
-       if (state & Button3MotionMask)
-               b |= mouse_button::button3;
-       if (state & Button4MotionMask)
-               b |= mouse_button::button4;
-       if (state & Button5MotionMask)
-               b |= mouse_button::button5;
-       return b;
-}
-
-
 key_modifier::state x_key_state(unsigned int state)
 {
        key_modifier::state k = key_modifier::none;
@@ -117,62 +69,56 @@ key_modifier::state x_key_state(unsigned int state)
 }
 
 
-} // anon namespace
+extern "C" {
 
+void C_scroll_cb(FL_OBJECT * ob, long)
+{
+       XWorkArea * area = static_cast<XWorkArea *>(ob->u_vdata);
+       area->scroll_cb();
+}
 
-extern "C" {
-       // Just a bunch of C wrappers around static members of XWorkArea
-       static
-       void C_XWorkArea_scroll_cb(FL_OBJECT * ob, long)
-       {
-               XWorkArea * area = static_cast<XWorkArea*>(ob->u_vdata);
-               area->scroll_cb();
-       }
 
+int C_work_area_handler(FL_OBJECT * ob, int event, FL_Coord, FL_Coord,
+                       int key, void * xev)
+{
+       return XWorkArea::work_area_handler(ob, event, 0, 0, key, xev);
+}
 
-       static
-       int C_XWorkArea_work_area_handler(FL_OBJECT * ob, int event,
-                                        FL_Coord, FL_Coord,
-                                        int key, void * xev)
-       {
-               return XWorkArea::work_area_handler(ob, event,
-                                                  0, 0, key, xev);
-       }
 
-       static
-       int C_XWorkAreaEventCB(FL_FORM * form, void * xev) {
-               XWorkArea * wa = static_cast<XWorkArea*>(form->u_vdata);
-               return wa->event_cb(static_cast<XEvent*>(xev));
-       }
+int C_event_cb(FL_FORM * form, void * xev)
+{
+       XWorkArea * area = static_cast<XWorkArea *>(form->u_vdata);
+       return area->event_cb(static_cast<XEvent *>(xev));
 }
 
+} // extern "C"
+} // namespace anon
+
 
 XWorkArea::XWorkArea(int x, int y, int w, int h)
        : workareapixmap(0), painter_(*this)
 {
+       if (lyxerr.debugging(Debug::WORKAREA)) {
+               lyxerr << "\tbackground box: +"
+                      << x << '+' << y << ' '
+                      << w - 15 << 'x' << h << endl;
+       }
+
        fl_freeze_all_forms();
 
        FL_OBJECT * obj;
 
-       if (lyxerr.debugging(Debug::WORKAREA))
-               lyxerr << "\tbackground box: +"
-                      << x << '+' << y << ' '
-                      << w - 15 << 'x' << h << endl;
-       backgroundbox = obj = fl_add_box(FL_BORDER_BOX,
-                                        x, y,
-                                        w - 15,
-                                        h, "");
+       obj = fl_add_box(FL_BORDER_BOX, x, y, w - 15, h, "");
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthWestGravity, SouthEastGravity);
 
        scrollbar = obj = fl_add_scrollbar(FL_VERT_SCROLLBAR,
-                                          x + w - 15,
-                                          y, 17, h, "");
+                                          x + w - 15, y, 17, h, "");
        fl_set_object_boxtype(obj, FL_UP_BOX);
        fl_set_object_resize(obj, FL_RESIZE_ALL);
        fl_set_object_gravity(obj, NorthEastGravity, SouthEastGravity);
        obj->u_vdata = this;
-       fl_set_object_callback(obj, C_XWorkArea_scroll_cb, 0);
+       fl_set_object_callback(obj, C_scroll_cb, 0);
        fl_set_scrollbar_bounds(scrollbar, 0.0, 0.0);
        fl_set_scrollbar_value(scrollbar, 0.0);
        fl_set_scrollbar_size(scrollbar, scrollbar->h);
@@ -195,7 +141,7 @@ XWorkArea::XWorkArea(int x, int y, int w, int h)
                                      x + bw, y + bw,
                                      w - 15 - 2 * bw,
                                      h - 2 * bw, "",
-                                     C_XWorkArea_work_area_handler);
+                                     C_work_area_handler);
        obj->wantkey = FL_KEY_ALL;
        obj->u_vdata = this;
 
@@ -205,7 +151,7 @@ XWorkArea::XWorkArea(int x, int y, int w, int h)
 
        /// X selection hook - xforms gets it wrong
        fl_current_form->u_vdata = this;
-       fl_register_raw_callback(fl_current_form, FL_ALL_EVENT, C_XWorkAreaEventCB);
+       fl_register_raw_callback(fl_current_form, FL_ALL_EVENT, C_event_cb);
 
        fl_unfreeze_all_forms();
 
@@ -213,7 +159,7 @@ XWorkArea::XWorkArea(int x, int y, int w, int h)
 
        val.function = GXcopy;
        copy_gc = XCreateGC(fl_get_display(), RootWindow(fl_get_display(), 0),
-               GCFunction, &val);
+                           GCFunction, &val);
 }
 
 
@@ -225,21 +171,6 @@ XWorkArea::~XWorkArea()
 }
 
 
-namespace {
-void destroy_object(FL_OBJECT * obj)
-{
-       if (!obj)
-               return;
-
-       if (obj->visible) {
-               fl_hide_object(obj);
-       }
-       fl_delete_object(obj);
-       fl_free_object(obj);
-}
-} // namespace anon
-
-
 void XWorkArea::redraw(int width, int height)
 {
        static int cur_width = -1;
@@ -247,8 +178,8 @@ void XWorkArea::redraw(int width, int height)
 
        if (cur_width == width && cur_height == height && workareapixmap) {
                XCopyArea(fl_get_display(),
-                       getPixmap(), getWin(), copy_gc,
-                       0, 0, width, height, xpos(), ypos());
+                         getPixmap(), getWin(), copy_gc,
+                         0, 0, width, height, xpos(), ypos());
                return;
        }
 
@@ -257,7 +188,7 @@ void XWorkArea::redraw(int width, int height)
 
        if (lyxerr.debugging(Debug::WORKAREA)) {
                lyxerr << "(Re)creating pixmap ("
-                      << width << 'x' << height << ")" << endl;
+                      << width << 'x' << height << ')' << endl;
        }
 
        if (workareapixmap) {
@@ -269,7 +200,7 @@ void XWorkArea::redraw(int width, int height)
                                       width,
                                       height,
                                       fl_get_visual_depth());
+
        workAreaResize();
 }
 
@@ -287,14 +218,17 @@ void XWorkArea::setScrollbarParams(int height, int pos, int line_height)
 
        long const work_height = workHeight();
 
-       lyxerr[Debug::GUI] << "scroll: height now " << height << endl;
-       lyxerr[Debug::GUI] << "scroll: work_height " << work_height << endl;
+       if (lyxerr.debugging(Debug::GUI)) {
+               lyxerr << "scroll: height now " << height << '\n'
+                      << "scroll: work_height " << work_height << endl;
+       }
 
        /* If the text is smaller than the working area, the scrollbar
         * maximum must be the working area height. No scrolling will
         * be possible */
        if (height <= work_height) {
-               lyxerr[Debug::GUI] << "scroll: doc smaller than workarea !" << endl;
+               lyxerr[Debug::GUI] << "scroll: doc smaller than workarea !"
+                                  << endl;
                fl_set_scrollbar_bounds(scrollbar, 0.0, 0.0);
                fl_set_scrollbar_value(scrollbar, pos);
                fl_set_scrollbar_size(scrollbar, scrollbar->h);
@@ -317,22 +251,22 @@ void XWorkArea::setScrollbarParams(int height, int pos, int line_height)
 void XWorkArea::scroll_cb()
 {
        double const val = fl_get_scrollbar_value(scrollbar);
-       lyxerr[Debug::GUI] << "scroll: val: " << val << endl;
-       lyxerr[Debug::GUI] << "scroll: height: " << scrollbar->h << endl;
-       lyxerr[Debug::GUI] << "scroll: docheight: " << doc_height_ << endl;
+
+       if (lyxerr.debugging(Debug::GUI)) {
+               lyxerr << "scroll: val: " << val << '\n'
+                      << "scroll: height: " << scrollbar->h << '\n'
+                      << "scroll: docheight: " << doc_height_ << endl;
+       }
+
        scrollDocView(int(val));
-       waitForX();
+       waitForX(false);
 }
 
 
 int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
-                               FL_Coord, FL_Coord ,
-                               int key, void * xev)
+                                FL_Coord, FL_Coord,
+                                int key, void * xev)
 {
-       static int x_old = -1;
-       static int y_old = -1;
-       static long scrollbar_value_old = -1;
-
        XEvent * ev = static_cast<XEvent*>(xev);
        XWorkArea * area = static_cast<XWorkArea*>(ob->u_vdata);
 
@@ -340,8 +274,7 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
 
        switch (event) {
        case FL_DRAW:
-               if (!area->work_area ||
-                   !area->work_area->form->visible)
+               if (!area->work_area || !area->work_area->form->visible)
                        return 1;
                lyxerr[Debug::WORKAREA] << "Workarea event: DRAW" << endl;
                area->redraw(area->workWidth(), area->workHeight());
@@ -350,84 +283,116 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
                if (!ev || ev->xbutton.button == 0) break;
                // Should really have used xbutton.state
                lyxerr[Debug::WORKAREA] << "Workarea event: PUSH" << endl;
-               area->workAreaButtonPress(ev->xbutton.x - ob->x,
-                                         ev->xbutton.y - ob->y,
-                                         x_button_state(ev->xbutton.button));
+               area->dispatch(
+                       FuncRequest(LFUN_MOUSE_PRESS,
+                                   ev->xbutton.x - ob->x,
+                                   ev->xbutton.y - ob->y,
+                                   x_button_state(key)));
                break;
        case FL_RELEASE:
                if (!ev || ev->xbutton.button == 0) break;
                // Should really have used xbutton.state
                lyxerr[Debug::WORKAREA] << "Workarea event: RELEASE" << endl;
-               area->workAreaButtonRelease(ev->xbutton.x - ob->x,
-                                     ev->xbutton.y - ob->y,
-                                     x_button_state(ev->xbutton.button));
+               area->dispatch(
+                       FuncRequest(LFUN_MOUSE_RELEASE,
+                                   ev->xbutton.x - ob->x,
+                                   ev->xbutton.y - ob->y,
+                                   x_button_state(key)));
                break;
-#if FL_VERSION < 1 && FL_REVISION < 89
-       case FL_MOUSE:
-#else
        case FL_DRAG:
-#endif
-               if (!ev || ! area->scrollbar) break;
-               if (ev->xmotion.x != x_old ||
-                   ev->xmotion.y != y_old ||
-                   fl_get_scrollbar_value(area->scrollbar) != scrollbar_value_old
-                       ) {
-                       lyxerr[Debug::WORKAREA] << "Workarea event: MOUSE" << endl;
-                       area->workAreaMotionNotify(ev->xmotion.x - ob->x,
-                                            ev->xmotion.y - ob->y,
-                                            x_motion_state(ev->xbutton.state));
+       {
+               if (!ev || !area->scrollbar)
+                       break;
+
+               int const drag_x = ev->xmotion.x;
+               int const drag_y = ev->xmotion.y;
+               int const area_y = ob->y;
+               int const area_h = ob->h;
+
+               // Check if the mouse is above or below the workarea
+               if (drag_y <= area_y || drag_y >= area_y + area_h) {
+                       // The mouse button is depressed and we are outside the
+                       // workarea. That means we are simultaneously selecting
+                       // text and scrolling the view.
+                       // Use a Timeout to react to a drag events only every
+                       // 200ms. All intervening events are discarded,
+                       // allowing the user to control position easily.
+                       static int const discard_interval = 200;
+                       static Timeout timeout(discard_interval);
+
+                       if (timeout.running())
+                               break;
+                       // The timeout is not running, so process the
+                       // event, first starting the timeout to discard future
+                       // events.
+                       timeout.start();
+               }
+
+               static int x_old = -1;
+               static int y_old = -1;
+               static double scrollbar_value_old = -1.0;
+
+               double const scrollbar_value =
+                       fl_get_scrollbar_value(area->scrollbar);
+
+               if (drag_x != x_old || drag_y != y_old ||
+                   scrollbar_value != scrollbar_value_old) {
+                       x_old = drag_x;
+                       y_old = drag_y;
+                       scrollbar_value_old = scrollbar_value;
+
+                       lyxerr[Debug::WORKAREA] << "Workarea event: DRAG"
+                                               << endl;
+
+                       // It transpires that ev->xbutton.button == 0 when
+                       // the mouse is dragged, so it cannot be used to
+                       // initialise x_button_state and hence FuncRequest.
+
+                       // The 'key' that is passed into the function does
+                       // contain the necessary info, however.
+
+                       // It is for this reason that x_button_state has
+                       // been modified to work with key
+                       // rather than ev->xbutton.button.
+
+                       // Angus 15 Oct 2002.
+                       FuncRequest cmd(LFUN_MOUSE_MOTION,
+                                       ev->xbutton.x - ob->x,
+                                       ev->xbutton.y - ob->y,
+                                       x_button_state(key));
+                       area->dispatch(cmd);
                }
                break;
-#if FL_VERSION < 1 && FL_REVISION < 89
-       case FL_KEYBOARD:
-#else
+       }
+
        case FL_KEYPRESS:
-#endif
        {
-               lyxerr[Debug::WORKAREA] << "Workarea event: KEYBOARD" << endl;
+               lyxerr[Debug::WORKAREA] << "Workarea event: KEYPRESS" << endl;
 
                KeySym keysym = 0;
                char dummy[1];
                XKeyEvent * xke = reinterpret_cast<XKeyEvent *>(ev);
-#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5))
-               // XForms < 0.89.5 does not have compose support
-               // so we are using our own compose support
-               LyXLookupString(ev, dummy, 1, &keysym);
-#else
                XLookupString(xke, dummy, 1, &keysym, 0);
-//             int num_keys = XLookupString(xke, dummy, 10, &keysym, &xcs);
-//             lyxerr << "We have " << num_keys << " keys in the returned buffer" << endl;
-//             lyxerr << "Our dummy string is " << dummy << endl;
-#endif
 
                if (lyxerr.debugging(Debug::KEY)) {
-                       char const * tmp = XKeysymToString(key);
-                       char const * tmp2 = XKeysymToString(keysym);
-                       string const stm = (tmp ? tmp : "");
-                       string const stm2 = (tmp2 ? tmp2 : "");
-
-                       lyxerr[Debug::KEY] << "XWorkArea: Key is `" << stm << "' ["
-                              << key << "]" << endl;
-                       lyxerr[Debug::KEY] << "XWorkArea: Keysym is `" << stm2 << "' ["
-                              << keysym << "]" << endl;
+                       char const * const tmp  = XKeysymToString(key);
+                       char const * const tmp2 = XKeysymToString(keysym);
+                       string const stm  = (tmp ? tmp : string());
+                       string const stm2 = (tmp2 ? tmp2 : string());
+
+                       lyxerr << "XWorkArea: Key is `" << stm
+                              << "' [" << key << "]\n"
+                              << "XWorkArea: Keysym is `" << stm2
+                              << "' [" << keysym << ']' << endl;
                }
 
-#if FL_VERSION < 1 && (FL_REVISION < 89 || (FL_REVISION == 89 && FL_FIXLEVEL < 5))
-               if (keysym == NoSymbol) {
-                       lyxerr[Debug::KEY]
-                               << "Empty kdb action (probably composing)"
-                               << endl;
-                       break;
-               }
-               KeySym ret_key = keysym;
-#else
                // Note that we need this handling because of a bug
                // in XForms 0.89, if this bug is resolved in the way I hope
-               // we can just use the keysym directly with out looking
+               // we can just use the keysym directly without looking
                // at key at all. (Lgb)
                KeySym ret_key = 0;
                if (!key) {
-                       // We migth have to add more keysyms here also,
+                       // We might have to add more keysyms here also,
                        // we will do that as the issues arise. (Lgb)
                        if (keysym == XK_space) {
                                ret_key = keysym;
@@ -446,13 +411,12 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
                        //              << static_cast<unsigned char>(key)
                        //              << endl;
                        //} else {
-                               ret_key = (keysym ? keysym : key);
-                               lyxerr[Debug::KEY] << "Using keysym [B]"
-                                                  << endl;
+                       ret_key = (keysym ? keysym : key);
+                       lyxerr[Debug::KEY] << "Using keysym [B]"
+                                          << endl;
                                //}
                }
 
-#endif
                unsigned int const ret_state = xke->state;
 
                // If you have a better way to handle "wild-output" of
@@ -473,8 +437,8 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
                        //       << XEventsQueued(fl_get_display(), QueuedAlready)
                        //       << endl;
                        if (XEventsQueued(fl_get_display(), QueuedAlready) > 0)
-                               XSync(fl_get_display(), 1);
-                       // This purge make f.ex. scrolling stop immidiatly when
+                               waitForX(true);
+                       // This purge make f.ex. scrolling stop immediately when
                        // releasing the PageDown button. The question is if
                        // this purging of XEvents can cause any harm...
                        // after some testing I can see no problems, but
@@ -493,35 +457,42 @@ int XWorkArea::work_area_handler(FL_OBJECT * ob, int event,
        }
        break;
 
-#if FL_VERSION > 0 || FL_REVISION >= 89
        case FL_KEYRELEASE:
                lyxerr[Debug::WORKAREA] << "Workarea event: KEYRELEASE" << endl;
                break;
-#endif
 
        case FL_ENTER:
                lyxerr[Debug::WORKAREA] << "Workarea event: ENTER" << endl;
+               fl_set_cursor(FL_ObjWin(area->work_area), XC_xterm);
                break;
        case FL_LEAVE:
                lyxerr[Debug::WORKAREA] << "Workarea event: LEAVE" << endl;
+               // There should be no need for this. But there is.
+               fl_set_cursor(FL_ObjWin(area->work_area), FL_DEFAULT_CURSOR);
                break;
        case FL_DBLCLICK:
-               if (!ev) break;
-               lyxerr[Debug::WORKAREA] << "Workarea event: DBLCLICK" << endl;
-               area->workAreaDoubleClick(ev->xbutton.x - ob->x,
-                                         ev->xbutton.y - ob->y,
-                                         x_button_state(ev->xbutton.button));
+               if (ev) {
+                       lyxerr[Debug::WORKAREA] << "Workarea event: DBLCLICK" << endl;
+                       FuncRequest cmd(LFUN_MOUSE_DOUBLE,
+                                       ev->xbutton.x - ob->x,
+                                       ev->xbutton.y - ob->y,
+                                       x_button_state(key));
+                       area->dispatch(cmd);
+               }
                break;
        case FL_TRPLCLICK:
-               if (!ev) break;
-               lyxerr[Debug::WORKAREA] << "Workarea event: TRPLCLICK" << endl;
-               area->workAreaTripleClick(ev->xbutton.x - ob->x,
-                                         ev->xbutton.y - ob->y,
-                                         x_button_state(ev->xbutton.button));
+               if (ev) {
+                       lyxerr[Debug::WORKAREA] << "Workarea event: TRPLCLICK" << endl;
+                       FuncRequest cmd(LFUN_MOUSE_TRIPLE,
+                                       ev->xbutton.x - ob->x,
+                                       ev->xbutton.y - ob->y,
+                                       x_button_state(key));
+                       area->dispatch(cmd);
+               }
                break;
        case FL_OTHER:
-               if (!ev) break;
-               lyxerr[Debug::WORKAREA] << "Workarea event: OTHER" << endl;
+               if (ev)
+                       lyxerr[Debug::WORKAREA] << "Workarea event: OTHER" << endl;
                break;
        }
 
@@ -536,51 +507,43 @@ bool clipboard_read = false;
 
 extern "C" {
 
-       static
-       int request_clipboard_cb(FL_OBJECT * /*ob*/, long /*type*/,
-                                void const * data, long size)
-       {
-               clipboard_selection.erase();
-
-               if (size > 0)
-                       clipboard_selection.reserve(size);
-               for (int i = 0; i < size; ++i)
-                       clipboard_selection +=
-                               static_cast<char const *>(data)[i];
-               clipboard_read = true;
-               return 0;
-       }
-
+int request_clipboard_cb(FL_OBJECT * /*ob*/, long /*type*/,
+                        void const * data, long size)
+{
+       clipboard_selection.erase();
+
+       if (size > 0)
+               clipboard_selection.reserve(size);
+       for (int i = 0; i < size; ++i)
+               clipboard_selection += static_cast<char const *>(data)[i];
+       clipboard_read = true;
+       return 0;
 }
 
+} // extern "C"
 } // namespace anon
 
 
 int XWorkArea::event_cb(XEvent * xev)
 {
-       int ret = 0;
        switch (xev->type) {
-               case SelectionRequest:
-                       lyxerr[Debug::GUI] << "X requested selection." << endl;
-                       selectionRequested();
-                       break;
-               case SelectionClear:
-                       lyxerr[Debug::GUI] << "Lost selection." << endl;
-                       selectionLost();
-                       break;
+       case SelectionRequest:
+               lyxerr[Debug::GUI] << "X requested selection." << endl;
+               selectionRequested();
+               break;
+       case SelectionClear:
+               lyxerr[Debug::GUI] << "Lost selection." << endl;
+               selectionLost();
+               break;
        }
-       return ret;
+       return 0;
 }
 
 
 void XWorkArea::haveSelection(bool yes) const
 {
-       if (!yes) {
-               XSetSelectionOwner(fl_get_display(), XA_PRIMARY, None, CurrentTime);
-               return;
-       }
-
-       XSetSelectionOwner(fl_get_display(), XA_PRIMARY, FL_ObjWin(work_area), CurrentTime);
+       Window const owner = yes ? FL_ObjWin(work_area) : None;
+       XSetSelectionOwner(fl_get_display(), XA_PRIMARY, owner, CurrentTime);
 }
 
 
@@ -596,9 +559,10 @@ string const XWorkArea::getClipboard() const
        while (!clipboard_read) {
                if (fl_check_forms() == FL_EVENT) {
                        fl_XNextEvent(&ev);
-                       lyxerr << "Received unhandled X11 event" << endl;
-                       lyxerr << "Type: 0x" << hex << ev.xany.type <<
-                               " Target: 0x" << hex << ev.xany.window << endl;
+                       lyxerr << "Received unhandled X11 event\n"
+                              << "Type: 0x" << hex << ev.xany.type
+                              << " Target: 0x" << hex << ev.xany.window
+                              << dec << endl;
                }
        }
        return clipboard_selection;