]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/xforms/FormPreferences.C
Introduce LFUN_PRINT.
[lyx.git] / src / frontends / xforms / FormPreferences.C
index 6630f8c81308e08e9a51f2ec62a317961fc73be6..db10c7371eb01f89e805eadc63e3e96cfbfd279b 100644 (file)
@@ -5,65 +5,56 @@
  *
  * \author Angus Leeming
  *
- * Full author contact details are available in file CREDITS
+ * Full author contact details are available in file CREDITS.
  */
 
 #include <config.h>
 
-
-#include "ControlPrefs.h"
 #include "FormPreferences.h"
 #include "forms/form_preferences.h"
-#include "xformsBC.h"
-#include "ButtonController.h"
 
-#include "Color.h"
-#include "input_validators.h"
+#include "FormColorpicker.h"
 #include "forms_gettext.h"
+#include "input_validators.h"
+#include "xformsBC.h"
 #include "xforms_helpers.h"
-#include "helper_funcs.h" // getSecond
+
+#include "controllers/ControlPrefs.h"
+#include "controllers/frnt_lang.h"
+#include "controllers/helper_funcs.h" // getSecond
 
 #include "buffer.h"
 #include "converter.h"
 #include "format.h"
-#include "debug.h"
-#include "language.h"
-#include "frnt_lang.h"
-#include "lyxlex.h"
-#include "lyxrc.h"
 #include "LColor.h"
-#include "Lsstream.h"
-#include "funcrequest.h"
-#include "author.h"
+#include "lyxfont.h"
 
-#include "support/lyxfunctional.h"
-#include "support/lyxmanip.h"
+#include "support/lstrings.h"
+#include "support/tostr.h"
+#include "support/path_defines.h"
 #include "support/filetools.h"
-#include "support/LAssert.h"
-
-#include "graphics/GraphicsCache.h"
-#include "graphics/GraphicsTypes.h"
-
-#include <boost/bind.hpp>
 
-#include FORMS_H_LOCATION
+#include "lyx_forms.h"
 #include "combox.h"
 
-#include <utility>
 #include <iomanip>
-#include <X11/Xlib.h>
+
+using lyx::support::AddName;
+using lyx::support::ChangeExtension;
+using lyx::support::rtrim;
+using lyx::support::strToDbl;
+using lyx::support::trim;
+using lyx::support::user_lyxdir;
 
 using std::endl;
-using std::pair;
 using std::make_pair;
 using std::max;
 using std::min;
+
+using std::pair;
 using std::vector;
-using std::setw;
-using std::setfill;
+using std::string;
 
-extern string system_lyxdir;
-extern string user_lyxdir;
 
 namespace {
 
@@ -89,17 +80,6 @@ pair<string,string> parseFontName(string const & name)
 }
 
 
-string const X11hexname(RGBColor const & col)
-{
-       ostringstream ostr;
-
-       ostr << '#' << std::setbase(16) << setfill('0')
-            << setw(2) << col.r
-            << setw(2) << col.g
-            << setw(2) << col.b;
-
-       return STRCONV(ostr.str());
-}
 
 #if FL_VERSION == 0 || (FL_REVISION == 0 && FL_FIXLEVEL < 2)
 bool const scalableTabfolders = false;
@@ -223,74 +203,74 @@ void FormPreferences::build()
                folder = lang_opts_tab_->tabfolder_inner;
                fl_set_tabfolder_autofit(folder, FL_FIT);
        }
-       
+
        // Stack tabs
        // Now add them to the tabfolder
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Look & Feel"),
+                          _("Look & Feel").c_str(),
                           look_n_feel_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Lang Opts"),
+                          _("Lang Opts").c_str(),
                           lang_opts_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Conversion"),
+                          _("Conversion").c_str(),
                           converters_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Inputs"),
+                          _("Inputs").c_str(),
                           inputs_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Outputs"),
+                          _("Outputs").c_str(),
                           outputs_tab_->form);
 
        // now build the nested tabfolders
        // Starting with look and feel
        fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
-                          _("Screen Fonts"),
+                          _("Screen Fonts").c_str(),
                           screen_fonts_.dialog()->form);
        fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
-                          _("Interface"),
+                          _("Interface").c_str(),
                           interface_.dialog()->form);
        fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
-                          _("Colors"),
+                          _("Colors").c_str(),
                           colors_.dialog()->form);
        fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
-                          _("Misc"),
+                          _("Misc").c_str(),
                           lnf_misc_.dialog()->form);
        fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
-                          _("Identity"),
+                          _("Identity").c_str(),
                           identity_.dialog()->form);
 
        // then build converters
        fl_addto_tabfolder(converters_tab_->tabfolder_inner,
-                          _("Formats"),
+                          _("Formats").c_str(),
                           formats_.dialog()->form);
        fl_addto_tabfolder(converters_tab_->tabfolder_inner,
-                          _("Converters"),
+                          _("Converters").c_str(),
                           converters_.dialog()->form);
 
        // then build inputs
        // Paths should probably go in a few inner_tab called Files
        fl_addto_tabfolder(inputs_tab_->tabfolder_inner,
-                          _("Paths"),
+                          _("Paths").c_str(),
                           paths_.dialog()->form);
        fl_addto_tabfolder(inputs_tab_->tabfolder_inner,
-                          _("Misc"),
+                          _("Misc").c_str(),
                           inputs_misc_.dialog()->form);
 
        // then building outputs
        fl_addto_tabfolder(outputs_tab_->tabfolder_inner,
-                          _("Printer"),
+                          _("Printer").c_str(),
                           printer_.dialog()->form);
        fl_addto_tabfolder(outputs_tab_->tabfolder_inner,
-                          _("Misc"),
+                          _("Misc").c_str(),
                           outputs_misc_.dialog()->form);
 
        // then building usage
        fl_addto_tabfolder(lang_opts_tab_->tabfolder_inner,
-                          _("Spell checker"),
+                          _("Spell checker").c_str(),
                           spelloptions_.dialog()->form);
        fl_addto_tabfolder(lang_opts_tab_->tabfolder_inner,
-                          _("Language"),
+                          _("Language").c_str(),
                           language_.dialog()->form);
 }
 
@@ -327,7 +307,7 @@ void FormPreferences::apply()
        // The "Save" button has been pressed.
        if (controller().isClosing() && colors_.modifiedXformsPrefs) {
                string const filename =
-                       AddName(user_lyxdir, "preferences.xform");
+                       AddName(user_lyxdir(), "preferences.xform");
                colors_.modifiedXformsPrefs = !XformsColor::write(filename);
        }
 }
@@ -335,7 +315,7 @@ void FormPreferences::apply()
 
 string const FormPreferences::getFeedback(FL_OBJECT * ob)
 {
-       lyx::Assert(ob);
+       BOOST_ASSERT(ob);
 
        if (ob->form->fdui == colors_.dialog())
                return colors_.feedback(ob);
@@ -368,7 +348,7 @@ string const FormPreferences::getFeedback(FL_OBJECT * ob)
 
 ButtonPolicy::SMInput FormPreferences::input(FL_OBJECT * ob, long)
 {
-       lyx::Assert(ob);
+       BOOST_ASSERT(ob);
 
        bool valid = true;
 
@@ -481,7 +461,7 @@ void FormPreferences::Colors::apply()
        // Now do the same for the LyX LColors...
        for (vector<NamedColor>::const_iterator cit = lyxColorDB.begin();
             cit != lyxColorDB.end(); ++cit) {
-               LColor::color lc = lcolor.getFromGUIName(cit->getname());
+               LColor::color lc = lcolor.getFromLyXName(cit->lyxname);
                if (lc == LColor::inherit) continue;
 
                // Create a valid X11 name of the form "#rrggbb"
@@ -503,48 +483,16 @@ void FormPreferences::Colors::apply()
 
 void FormPreferences::Colors::build()
 {
+       picker_.reset(new FormColorpicker);
        dialog_.reset(build_preferences_colors(&parent_));
 
        fl_set_object_color(dialog_->button_color,
                            GUI_COLOR_CHOICE, GUI_COLOR_CHOICE);
 
-       fl_set_object_color(dialog_->dial_hue, GUI_COLOR_HUE_DIAL, FL_BLACK);
-       fl_set_dial_bounds(dialog_->dial_hue, 0.0, 360.0);
-       fl_set_dial_step(dialog_->dial_hue, 1.0);
-       fl_set_dial_return(dialog_->dial_hue, FL_RETURN_CHANGED);
-
-       fl_set_slider_bounds(dialog_->slider_saturation, 0.0, 1.0);
-       fl_set_slider_step(dialog_->slider_saturation, 0.01);
-       fl_set_slider_return(dialog_->slider_saturation, FL_RETURN_CHANGED);
-
-       fl_set_slider_bounds(dialog_->slider_value, 0.0, 1.0);
-       fl_set_slider_step(dialog_->slider_value, 0.01);
-       fl_set_slider_return(dialog_->slider_value, FL_RETURN_CHANGED);
-
-       fl_set_slider_bounds(dialog_->slider_red, 0.0, 255.0);
-       fl_set_slider_step(dialog_->slider_red, 1.0);
-       fl_set_slider_return(dialog_->slider_red, FL_RETURN_CHANGED);
-
-       fl_set_slider_bounds(dialog_->slider_green, 0.0, 255.0);
-       fl_set_slider_step(dialog_->slider_green, 1.0);
-       fl_set_slider_return(dialog_->slider_green, FL_RETURN_CHANGED);
-
-       fl_set_slider_bounds(dialog_->slider_blue, 0.0, 255.0);
-       fl_set_slider_step(dialog_->slider_blue, 1.0);
-       fl_set_slider_return(dialog_->slider_blue, FL_RETURN_CHANGED);
-
        // set up the feedback mechanism
        setPrehandler(dialog_->browser_lyx_objs);
        setPrehandler(dialog_->button_color);
        setPrehandler(dialog_->button_modify);
-       setPrehandler(dialog_->dial_hue);
-       setPrehandler(dialog_->slider_saturation);
-       setPrehandler(dialog_->slider_value);
-       setPrehandler(dialog_->slider_red);
-       setPrehandler(dialog_->slider_green);
-       setPrehandler(dialog_->slider_blue);
-       setPrehandler(dialog_->radio_rgb);
-       setPrehandler(dialog_->radio_hsv);
 }
 
 
@@ -557,17 +505,6 @@ FormPreferences::Colors::feedback(FL_OBJECT const * const ob) const
        if (ob == dialog_->button_modify)
                return _("Modify the LyX object's color. Note: you must then \"Apply\" the change.");
 
-       if (ob == dialog_->dial_hue ||
-           ob == dialog_->slider_saturation ||
-           ob == dialog_->slider_value ||
-           ob == dialog_->slider_red ||
-           ob == dialog_->slider_green ||
-           ob == dialog_->slider_blue)
-               return  _("Find a new color.");
-
-       if (ob == dialog_->radio_rgb || ob == dialog_->radio_hsv)
-               return _("Toggle between RGB and HSV color spaces.");
-
        return string();
 }
 
@@ -577,20 +514,6 @@ void FormPreferences::Colors::input(FL_OBJECT const * const ob)
        if (ob == dialog_->browser_lyx_objs) {
                InputBrowserLyX();
 
-       } else if (ob == dialog_->dial_hue ||
-                  ob == dialog_->slider_saturation ||
-                  ob == dialog_->slider_value) {
-               InputHSV();
-
-       } else if (ob == dialog_->slider_red ||
-                  ob == dialog_->slider_green ||
-                  ob == dialog_->slider_blue) {
-               InputRGB();
-
-       } else if (ob == dialog_->radio_rgb ||
-                  ob == dialog_->radio_hsv) {
-               SwitchColorSpace();
-
        } else if (ob == dialog_->button_modify) {
                Modify();
        }
@@ -637,106 +560,7 @@ void FormPreferences::Colors::InputBrowserLyX() const
        fl_mapcolor(GUI_COLOR_CHOICE, col.r, col.g, col.b);
        fl_redraw_object(dialog_->button_color);
 
-       // Display either RGB or HSV but not both!
-       SwitchColorSpace();
-
-       // Deactivate the modify button to begin with...
-       setEnabled(dialog_->button_modify, false);
-
-       fl_unfreeze_form(dialog_->form);
-}
-
-
-void FormPreferences::Colors::InputHSV()
-{
-       double const hue = fl_get_dial_value(dialog_->dial_hue);
-       double const sat = fl_get_slider_value(dialog_->slider_saturation);
-       double const val = fl_get_slider_value(dialog_->slider_value);
-
-       int const h = int(hue);
-       int const s = int(100.0 * sat);
-       int const v = int(100.0 * val);
-
-       string const label = tostr(h) + string(", ") + tostr(s) + string(", ") +
-               tostr(v);
-       fl_set_object_label(dialog_->text_color_values, label.c_str());
-
-       RGBColor col = HSVColor(hue, sat, val);
-
-       fl_freeze_form(dialog_->form);
-
-       fl_mapcolor(GUI_COLOR_CHOICE, col.r, col.g, col.b);
-       fl_redraw_object(dialog_->button_color);
-
-       col = HSVColor(hue, 1.0, 1.0);
-       col.r = max(col.r, 0u);
-       fl_mapcolor(GUI_COLOR_HUE_DIAL, col.r, col.g, col.b);
-       fl_redraw_object(dialog_->dial_hue);
-
-       // Ascertain whether to activate the Modify button.
-       vector<NamedColor>::size_type const selLyX =
-               fl_get_browser(dialog_->browser_lyx_objs);
-
-       fl_unfreeze_form(dialog_->form);
-       if (selLyX < 1) return;
-
-       fl_getmcolor(GUI_COLOR_CHOICE, &col.r, &col.g, &col.b);
-       bool modify = false;
-
-       // Is the choice an Xforms color...
-       if (selLyX - 1 < xformsColorDB.size()) {
-               vector<XformsColor>::size_type const i = selLyX - 1;
-               modify = (xformsColorDB[i].color() != col);
-       }
-       // or a LyX Logical color?
-       else {
-               vector<NamedColor>::size_type const i = selLyX - 1 -
-                       xformsColorDB.size();
-               modify = (lyxColorDB[i].color() != col);
-       }
-
-       setEnabled(dialog_->button_modify, modify);
-}
-
-
-void FormPreferences::Colors::InputRGB()
-{
-       int const red   = int(fl_get_slider_value(dialog_->slider_red));
-       int const green = int(fl_get_slider_value(dialog_->slider_green));
-       int const blue  = int(fl_get_slider_value(dialog_->slider_blue));
-
-       string const label = tostr(red) + string(", ") + tostr(green) +
-               string(", ") + tostr(blue);
-       fl_set_object_label(dialog_->text_color_values, label.c_str());
-
-       fl_freeze_form(dialog_->form);
-
-       RGBColor col = RGBColor(red, green, blue);
-       fl_mapcolor(GUI_COLOR_CHOICE, col.r, col.g, col.b);
-       fl_redraw_object(dialog_->button_color);
-
-       // Ascertain whether to activate the Modify button.
-       vector<NamedColor>::size_type const selLyX =
-               fl_get_browser(dialog_->browser_lyx_objs);
-
        fl_unfreeze_form(dialog_->form);
-       if (selLyX < 1) return;
-
-       bool modify = false;
-
-       // Is the choice an Xforms color...
-       if (selLyX - 1 < xformsColorDB.size()) {
-               vector<XformsColor>::size_type const i = selLyX - 1;
-               modify = (xformsColorDB[i].color() != col);
-       }
-       // or a LyX Logical color?
-       else {
-               vector<NamedColor>::size_type const i = selLyX - 1 -
-                       xformsColorDB.size();
-               modify = (lyxColorDB[i].color() != col);
-       }
-
-       setEnabled(dialog_->button_modify, modify);
 }
 
 
@@ -749,25 +573,29 @@ void FormPreferences::Colors::LoadBrowserLyX()
        xformsColorDB.clear();
        XformsColor xcol;
 
-       xcol.name = _("GUI background");
+       xcol.lyxname = "GUI background";
+       xcol.guiname = _("GUI background");
        xcol.colorID = FL_COL1;
        fl_getmcolor(FL_COL1, &xcol.r, &xcol.g, &xcol.b);
 
        xformsColorDB.push_back(xcol);
 
-       xcol.name = _("GUI text");
+       xcol.lyxname = "GUI text";
+       xcol.guiname = _("GUI text");
        xcol.colorID = FL_BLACK;
        fl_getmcolor(FL_BLACK, &xcol.r, &xcol.g, &xcol.b);
 
        xformsColorDB.push_back(xcol);
 
-       xcol.name = _("GUI selection");
+       xcol.lyxname = "GUI selection";
+       xcol.guiname = _("GUI selection");
        xcol.colorID = FL_YELLOW;
        fl_getmcolor(FL_YELLOW, &xcol.r, &xcol.g, &xcol.b);
 
        xformsColorDB.push_back(xcol);
 
-       xcol.name = _("GUI pointer");
+       xcol.lyxname = "GUI pointer";
+       xcol.guiname = _("GUI pointer");
        xcol.colorID = GUI_COLOR_CURSOR;
        fl_getmcolor(GUI_COLOR_CURSOR, &xcol.r, &xcol.g, &xcol.b);
 
@@ -816,7 +644,7 @@ void FormPreferences::Colors::LoadBrowserLyX()
                }
 
                // Finally, push the color onto the database
-               NamedColor ncol(lcolor.getGUIName(lc), col);
+               NamedColor ncol(lcolor.getLyXName(lc), lcolor.getGUIName(lc), col);
                lyxColorDB.push_back(ncol);
        }
 
@@ -826,11 +654,11 @@ void FormPreferences::Colors::LoadBrowserLyX()
        fl_clear_browser(colbr);
        for (vector<XformsColor>::const_iterator cit = xformsColorDB.begin();
             cit != xformsColorDB.end(); ++cit) {
-               fl_addto_browser(colbr, cit->getname().c_str());
+               fl_addto_browser(colbr, cit->guiname.c_str());
        }
        for (vector<NamedColor>::const_iterator cit = lyxColorDB.begin();
             cit != lyxColorDB.end(); ++cit) {
-               fl_addto_browser(colbr, cit->getname().c_str());
+               fl_addto_browser(colbr, cit->guiname.c_str());
        }
 
        // just to be safe...
@@ -849,8 +677,15 @@ void FormPreferences::Colors::Modify()
        if (selLyX < 1)
                return;
 
-       RGBColor col;
-       fl_getmcolor(GUI_COLOR_CHOICE, &col.r, &col.g, &col.b);
+       RGBColor before;
+       fl_getmcolor(GUI_COLOR_CHOICE, &before.r, &before.g, &before.b);
+
+       RGBColor col = picker_->requestColor(before);
+       if (before == col)
+               return;
+
+       fl_mapcolor(GUI_COLOR_CHOICE, col.r, col.g, col.b);
+       fl_redraw_object(dialog_->button_color);
 
        // Is the choice an Xforms color...
        if (selLyX - 1 < xformsColorDB.size()) {
@@ -867,74 +702,6 @@ void FormPreferences::Colors::Modify()
                lyxColorDB[i].g  = col.g;
                lyxColorDB[i].b  = col.b;
        }
-
-       fl_freeze_form(dialog_->form);
-       setEnabled(dialog_->button_modify, false);
-       fl_unfreeze_form(dialog_->form);
-}
-
-
-void FormPreferences::Colors::SwitchColorSpace() const
-{
-       bool const hsv = fl_get_button(dialog_->radio_hsv);
-
-       RGBColor col;
-       fl_getmcolor(GUI_COLOR_CHOICE, &col.r, &col.g, &col.b);
-
-       fl_freeze_form(dialog_->form);
-
-       if (hsv) {
-               fl_hide_object(dialog_->slider_red);
-               fl_hide_object(dialog_->slider_blue);
-               fl_hide_object(dialog_->slider_green);
-               fl_show_object(dialog_->dial_hue);
-               fl_show_object(dialog_->slider_saturation);
-               fl_show_object(dialog_->slider_value);
-
-               HSVColor hsv = HSVColor(col);
-               hsv.h = max(hsv.h, 0.0);
-
-               fl_set_dial_value(dialog_->dial_hue, hsv.h);
-               fl_set_slider_value(dialog_->slider_saturation, hsv.s);
-               fl_set_slider_value(dialog_->slider_value, hsv.v);
-
-               col = HSVColor(hsv.h, 1.0, 1.0);
-               col.r = max(col.r, 0u);
-               fl_mapcolor(GUI_COLOR_HUE_DIAL, col.r, col.g, col.b);
-               fl_redraw_object(dialog_->dial_hue);
-
-               // Adjust the label a bit, but not the actual values.
-               // Means that toggling from one space to the other has no
-               // effect on the final color.
-               int const h = int(hsv.h);
-               int const s = int(100 * hsv.s);
-               int const v = int(100 * hsv.v);
-               string const label = tostr(h) + ", " + tostr(s) +
-                       ", " + tostr(v);
-               fl_set_object_label(dialog_->text_color_values, label.c_str());
-
-       } else {
-               fl_show_object(dialog_->slider_red);
-               fl_show_object(dialog_->slider_blue);
-               fl_show_object(dialog_->slider_green);
-               fl_hide_object(dialog_->dial_hue);
-               fl_hide_object(dialog_->slider_saturation);
-               fl_hide_object(dialog_->slider_value);
-
-               fl_set_slider_value(dialog_->slider_red,   col.r);
-               fl_set_slider_value(dialog_->slider_green, col.g);
-               fl_set_slider_value(dialog_->slider_blue,  col.b);
-
-               // Adjust the label a bit. Same reasoning as above.
-               int const r = int(col.r);
-               int const g = int(col.g);
-               int const b = int(col.b);
-               string const label = tostr(r) + ", " + tostr(g) +
-                       ", " + tostr(b);
-               fl_set_object_label(dialog_->text_color_values, label.c_str());
-       }
-
-       fl_unfreeze_form(dialog_->form);
 }
 
 
@@ -977,7 +744,7 @@ string const
 FormPreferences::Converters::feedback(FL_OBJECT const * const ob) const
 {
        if (ob == dialog_->browser_all)
-               return _("All the currently defined converters known to LyX.");
+               return _("All explicitly defined converters for LyX");
 
        if (ob == dialog_->choice_from)
                return _("Convert \"from\" this format");
@@ -1839,22 +1606,22 @@ void FormPreferences::LnFmisc::apply(LyXRC & rc) const
                (fl_get_counter_value(dialog_->counter_wm_jump));
 
        // See FIXME below
-       // grfx::DisplayType old_value = rc.display_graphics;
+       // lyx::graphics::DisplayType old_value = rc.display_graphics;
        switch (fl_get_choice(dialog_->choice_display)) {
        case 4:
-               rc.display_graphics = grfx::NoDisplay;
+               rc.display_graphics = lyx::graphics::NoDisplay;
                break;
        case 3:
-               rc.display_graphics = grfx::ColorDisplay;
+               rc.display_graphics = lyx::graphics::ColorDisplay;
                break;
        case 2:
-               rc.display_graphics = grfx::GrayscaleDisplay;
+               rc.display_graphics = lyx::graphics::GrayscaleDisplay;
                break;
        case 1:
-               rc.display_graphics = grfx::MonochromeDisplay;
+               rc.display_graphics = lyx::graphics::MonochromeDisplay;
                break;
        default:
-               rc.display_graphics = grfx::ColorDisplay;
+               rc.display_graphics = lyx::graphics::ColorDisplay;
                break;
        }
 
@@ -1863,7 +1630,7 @@ void FormPreferences::LnFmisc::apply(LyXRC & rc) const
 #endif
 #if 0
        if (old_value != rc.display_graphics) {
-               grfx::GCache & gc = grfx::GCache::get();
+               lyx::graphics::GCache & gc = lyx::graphics::GCache::get();
                gc.changeDisplay();
        }
 #endif
@@ -1888,7 +1655,8 @@ void FormPreferences::LnFmisc::build()
        setPrehandler(dialog_->check_preview_latex);
        setPrehandler(dialog_->counter_wm_jump);
 
-       fl_addto_choice(dialog_->choice_display, _("Monochrome|Grayscale|Color|Do not display"));
+       fl_addto_choice(dialog_->choice_display,
+                       _("Monochrome|Grayscale|Color|Do not display").c_str());
 }
 
 
@@ -1927,16 +1695,16 @@ void FormPreferences::LnFmisc::update(LyXRC const & rc)
        fl_set_counter_value(dialog_->counter_wm_jump, rc.wheel_jump);
 
        switch (rc.display_graphics) {
-       case grfx::NoDisplay:
+       case lyx::graphics::NoDisplay:
                fl_set_choice(dialog_->choice_display, 4);
                break;
-       case grfx::ColorDisplay:
+       case lyx::graphics::ColorDisplay:
                fl_set_choice(dialog_->choice_display, 3);
                break;
-       case grfx::GrayscaleDisplay:
+       case lyx::graphics::GrayscaleDisplay:
                fl_set_choice(dialog_->choice_display, 2);
                break;
-       case grfx::MonochromeDisplay:
+       case lyx::graphics::MonochromeDisplay:
                fl_set_choice(dialog_->choice_display, 1);
                break;
        default:
@@ -1965,7 +1733,7 @@ void FormPreferences::OutputsMisc::apply(LyXRC & rc) const
 
        int const choice =
                fl_get_choice(dialog_->choice_default_papersize) - 1;
-       rc.default_papersize = static_cast<BufferParams::PAPER_SIZE>(choice);
+       rc.default_papersize = static_cast<PAPER_SIZE>(choice);
 
        rc.ascii_roff_command = fl_get_input(dialog_->input_ascii_roff);
        rc.chktex_command = fl_get_input(dialog_->input_checktex);
@@ -1987,7 +1755,8 @@ void FormPreferences::OutputsMisc::build()
        fl_set_input_return(dialog_->input_paperoption,  FL_RETURN_CHANGED);
 
        fl_addto_choice(dialog_->choice_default_papersize,
-                       _(" default | US letter | US legal | US executive | A3 | A4 | A5 | B5 "));
+                       _(" default | US letter | US legal "
+                         "| US executive | A3 | A4 | A5 | B5 ").c_str());
 
        // set up the feedback mechanism
        setPrehandler(dialog_->counter_line_len);
@@ -2056,17 +1825,10 @@ void FormPreferences::Paths::apply(LyXRC & rc)
 {
        rc.document_path = fl_get_input(dialog_->input_default_path);
        rc.template_path = fl_get_input(dialog_->input_template_path);
+       rc.tempdir_path  = fl_get_input(dialog_->input_temp_dir);
 
-       int button = fl_get_button(dialog_->check_use_temp_dir);
-       string str  = fl_get_input(dialog_->input_temp_dir);
-       if (!button)
-               str.erase();
-
-       rc.use_tempdir = button;
-       rc.tempdir_path = str;
-
-       button = fl_get_button(dialog_->check_last_files);
-       str = fl_get_input(dialog_->input_lastfiles);
+       int button = fl_get_button(dialog_->check_last_files);
+       string str = fl_get_input(dialog_->input_lastfiles);
        if (!button) str.erase();
 
        rc.check_lastfiles = button;
@@ -2111,7 +1873,6 @@ void FormPreferences::Paths::build()
        setPrehandler(dialog_->input_backup_path);
        setPrehandler(dialog_->input_serverpipe);
        setPrehandler(dialog_->input_temp_dir);
-       setPrehandler(dialog_->check_use_temp_dir);
 }
 
 
@@ -2122,8 +1883,6 @@ FormPreferences::Paths::feedback(FL_OBJECT const * const ob) const
                return LyXRC::getDescription(LyXRC::RC_DOCUMENTPATH);
        if (ob == dialog_->input_template_path)
                return LyXRC::getDescription(LyXRC::RC_TEMPLATEPATH);
-       if (ob == dialog_->check_use_temp_dir)
-               return LyXRC::getDescription(LyXRC::RC_USETEMPDIR);
        if (ob == dialog_->input_temp_dir)
                return LyXRC::getDescription(LyXRC::RC_TEMPDIRPATH);
        if (ob == dialog_->check_last_files)
@@ -2149,11 +1908,6 @@ bool FormPreferences::Paths::input(FL_OBJECT const * const ob)
        // !ob if function is called from Paths::update() to de/activate
        // objects,
        // otherwise the function is called by an xforms CB via input().
-       if (!ob || ob == dialog_->check_use_temp_dir) {
-               bool const enable = fl_get_button(dialog_->check_use_temp_dir);
-               setEnabled(dialog_->input_temp_dir, enable);
-       }
-
        if (!ob || ob == dialog_->check_last_files) {
                bool const enable = fl_get_button(dialog_->check_last_files);
                setEnabled(dialog_->input_lastfiles, enable);
@@ -2277,13 +2031,7 @@ void FormPreferences::Paths::update(LyXRC const & rc)
                      rc.make_backup);
        fl_set_input(dialog_->input_backup_path, str.c_str());
 
-       str.erase();
-       if (rc.use_tempdir)
-               str = rc.tempdir_path;
-
-       fl_set_button(dialog_->check_use_temp_dir,
-                     rc.use_tempdir);
-       fl_set_input(dialog_->input_temp_dir, str.c_str());
+       fl_set_input(dialog_->input_temp_dir, rc.tempdir_path.c_str());
 
        str.erase();
        if (rc.check_lastfiles)
@@ -2864,7 +2612,7 @@ void FormPreferences::SpellOptions::build()
        dialog_.reset(build_preferences_spelloptions(&parent_));
 
        fl_addto_choice(dialog_->choice_spell_command,
-                       _(" ispell | aspell "));
+                       _(" ispell | aspell ").c_str());
        fl_set_input_return(dialog_->input_alt_lang,      FL_RETURN_CHANGED);
        fl_set_input_return(dialog_->input_escape_chars,  FL_RETURN_CHANGED);
        fl_set_input_return(dialog_->input_personal_dict, FL_RETURN_CHANGED);