]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/xforms/FormPreferences.C
Bugfixes: checkboxes to radiobuttons (from J�rgen S) and remove a little
[lyx.git] / src / frontends / xforms / FormPreferences.C
index 084db72967ed0e9eeb1b7d5546acaa69641ab480..a63609fc4db56a9ed55637b393e6d9181b28be9d 100644 (file)
@@ -28,6 +28,7 @@
 #include "Lsstream.h"
 #include "FormPreferences.h"
 #include "form_preferences.h"
+#include "ButtonController.tmpl"
 #include "input_validators.h"
 #include "LyXView.h"
 #include "language.h"
@@ -38,7 +39,6 @@
 #include "debug.h"
 #include "support/filetools.h"
 #include "support/LAssert.h"
-#include "lyx_gui_misc.h" // idex, scex
 #include "lyxlex.h"
 #include "input_validators.h"
 #include "xforms_helpers.h"
@@ -97,19 +97,19 @@ void FormPreferences::redraw()
 
        FL_FORM * form3 = 0;
        if (form2 == converters_tab_->form)
-               form3 = fl_get_active_folder(converters_tab_->tabfolder_outer);
+               form3 = fl_get_active_folder(converters_tab_->tabfolder_inner);
 
        else if (form2 == look_n_feel_tab_->form)
-               form3 = fl_get_active_folder(look_n_feel_tab_->tabfolder_outer);
+               form3 = fl_get_active_folder(look_n_feel_tab_->tabfolder_inner);
 
        else if (form2 == inputs_tab_->form)
-               form3 = fl_get_active_folder(inputs_tab_->tabfolder_outer);
+               form3 = fl_get_active_folder(inputs_tab_->tabfolder_inner);
 
        else if (form2 == outputs_tab_->form)
-               form3 = fl_get_active_folder(outputs_tab_->tabfolder_outer);
+               form3 = fl_get_active_folder(outputs_tab_->tabfolder_inner);
 
        else if (form2 == lang_opts_tab_->form)
-               form3 = fl_get_active_folder(lang_opts_tab_->tabfolder_outer);
+               form3 = fl_get_active_folder(lang_opts_tab_->tabfolder_inner);
 
        if (form3 && form3->visible)
                fl_redraw_form(form3);
@@ -127,7 +127,7 @@ void FormPreferences::showSpellPref()
 {
        show();
        fl_set_folder(dialog_->tabfolder_prefs, lang_opts_tab_->form);
-       fl_set_folder(lang_opts_tab_->tabfolder_outer, spelloptions_.dialog()->form);
+       fl_set_folder(lang_opts_tab_->tabfolder_inner, spelloptions_.dialog()->form);
 }
 
 
@@ -149,10 +149,10 @@ void FormPreferences::hide()
 {
        // We need to hide the active tabfolder otherwise we get a
        // BadDrawable error from X window and LyX crashes without saving.
-       FL_FORM * outer_form = fl_get_active_folder(dialog_->tabfolder_prefs);
-       if (outer_form
-           && outer_form->visible) {
-               fl_hide_form(outer_form);
+       FL_FORM * inner_form = fl_get_active_folder(dialog_->tabfolder_prefs);
+       if (inner_form
+           && inner_form->visible) {
+               fl_hide_form(inner_form);
        }
        FormBaseDeprecated::hide();
 }
@@ -169,11 +169,11 @@ void FormPreferences::build()
        bc().setRestore(dialog_->button_restore);
 
        // build the tab folders
-       converters_tab_.reset(build_outer_tab());
-       look_n_feel_tab_.reset(build_outer_tab());
-       inputs_tab_.reset(build_outer_tab());
-       outputs_tab_.reset(build_outer_tab());
-       lang_opts_tab_.reset(build_outer_tab());
+       converters_tab_.reset(build_inner_tab());
+       look_n_feel_tab_.reset(build_inner_tab());
+       inputs_tab_.reset(build_inner_tab());
+       outputs_tab_.reset(build_inner_tab());
+       lang_opts_tab_.reset(build_inner_tab());
 
        // build actual tabfolder contents
        // these will become nested tabfolders
@@ -198,7 +198,7 @@ void FormPreferences::build()
                           _("Lang Opts"),
                           lang_opts_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
-                          _("Converters"),
+                          _("Conversion"),
                           converters_tab_->form);
        fl_addto_tabfolder(dialog_->tabfolder_prefs,
                           _("Inputs"),
@@ -209,49 +209,49 @@ void FormPreferences::build()
 
        // now build the nested tabfolders
        // Starting with look and feel
-       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_outer,
+       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
                           _("Screen Fonts"),
                           screen_fonts_.dialog()->form);
-       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_outer,
+       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
                           _("Interface"),
                           interface_.dialog()->form);
-       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_outer,
+       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
                           _("Colors"),
                           colors_.dialog()->form);
-       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_outer,
+       fl_addto_tabfolder(look_n_feel_tab_->tabfolder_inner,
                           _("Misc"),
                           lnf_misc_.dialog()->form);
 
        // then build converters
-       fl_addto_tabfolder(converters_tab_->tabfolder_outer,
+       fl_addto_tabfolder(converters_tab_->tabfolder_inner,
                           _("Formats"),
                           formats_.dialog()->form);
-       fl_addto_tabfolder(converters_tab_->tabfolder_outer,
+       fl_addto_tabfolder(converters_tab_->tabfolder_inner,
                           _("Converters"),
                           converters_.dialog()->form);
 
        // then build inputs
-       // Paths should probably go in a few outer_tab called Files
-       fl_addto_tabfolder(inputs_tab_->tabfolder_outer,
+       // Paths should probably go in a few inner_tab called Files
+       fl_addto_tabfolder(inputs_tab_->tabfolder_inner,
                           _("Paths"),
                           paths_.dialog()->form);
-       fl_addto_tabfolder(inputs_tab_->tabfolder_outer,
+       fl_addto_tabfolder(inputs_tab_->tabfolder_inner,
                           _("Misc"),
                           inputs_misc_.dialog()->form);
 
        // then building outputs
-       fl_addto_tabfolder(outputs_tab_->tabfolder_outer,
+       fl_addto_tabfolder(outputs_tab_->tabfolder_inner,
                           _("Printer"),
                           printer_.dialog()->form);
-       fl_addto_tabfolder(outputs_tab_->tabfolder_outer,
+       fl_addto_tabfolder(outputs_tab_->tabfolder_inner,
                           _("Misc"),
                           outputs_misc_.dialog()->form);
 
        // then building usage
-       fl_addto_tabfolder(lang_opts_tab_->tabfolder_outer,
+       fl_addto_tabfolder(lang_opts_tab_->tabfolder_inner,
                           _("Spell checker"),
                           spelloptions_.dialog()->form);
-       fl_addto_tabfolder(lang_opts_tab_->tabfolder_outer,
+       fl_addto_tabfolder(lang_opts_tab_->tabfolder_inner,
                           _("Language"),
                           language_.dialog()->form);
 }
@@ -499,7 +499,8 @@ void FormPreferences::Colors::build()
        setPreHandler(dialog_->slider_red);
        setPreHandler(dialog_->slider_green);
        setPreHandler(dialog_->slider_blue);
-       setPreHandler(dialog_->button_colorspace);
+       setPreHandler(dialog_->radio_rgb);
+       setPreHandler(dialog_->radio_hsv);
 }
 
 string const
@@ -521,7 +522,8 @@ FormPreferences::Colors::feedback(FL_OBJECT const * const ob) const
                   ob == dialog_->slider_blue) {
                str = N_("Find a new color.");
 
-       } else if (ob == dialog_->button_colorspace) {
+       } else if (ob == dialog_->radio_rgb ||
+                  ob == dialog_->radio_hsv) {
                str = N_("Toggle between RGB and HSV color spaces.");
        }
 
@@ -544,7 +546,8 @@ void FormPreferences::Colors::input(FL_OBJECT const * const ob)
                   ob == dialog_->slider_blue) {
                InputRGB();
 
-       } else if (ob == dialog_->button_colorspace) {
+       } else if (ob == dialog_->radio_rgb ||
+                  ob == dialog_->radio_hsv) {
                SwitchColorSpace();
 
        } else if (ob == dialog_->button_modify) {
@@ -847,16 +850,14 @@ void FormPreferences::Colors::Modify()
 
 void FormPreferences::Colors::SwitchColorSpace() const
 {
-       bool const pressed = fl_get_button(dialog_->button_colorspace);
+       bool const hsv = fl_get_button(dialog_->radio_hsv);
 
        RGBColor col;
        fl_getmcolor(GUI_COLOR_CHOICE, &col.r, &col.g, &col.b);
 
        fl_freeze_form(dialog_->form);
 
-       if (pressed) {
-               fl_set_object_label(dialog_->button_colorspace, _("HSV"));
-
+       if (hsv) {
                fl_hide_object(dialog_->slider_red);
                fl_hide_object(dialog_->slider_blue);
                fl_hide_object(dialog_->slider_green);
@@ -887,8 +888,6 @@ void FormPreferences::Colors::SwitchColorSpace() const
                fl_set_object_label(dialog_->text_color_values, label.c_str());
                
        } else {
-               fl_set_object_label(dialog_->button_colorspace, _("RGB"));
-
                fl_show_object(dialog_->slider_red);
                fl_show_object(dialog_->slider_blue);
                fl_show_object(dialog_->slider_green);
@@ -1470,11 +1469,11 @@ FD_form_interface const * FormPreferences::Interface::dialog()
 
 void FormPreferences::Interface::apply() const
 {
-       lyxrc.popup_font_name =
-               fl_get_input(dialog_->input_popup_font);
-       lyxrc.menu_font_name = fl_get_input(dialog_->input_menu_font);
-       lyxrc.font_norm_menu =
-               fl_get_input(dialog_->input_popup_encoding);
+       lyxrc.popup_normal_font =
+               fl_get_input(dialog_->input_popup_normal_font);
+       lyxrc.popup_bold_font = fl_get_input(dialog_->input_popup_bold_font);
+       lyxrc.popup_font_encoding =
+               fl_get_input(dialog_->input_popup_font_encoding);
        lyxrc.bind_file = fl_get_input(dialog_->input_bind_file);
        lyxrc.ui_file = fl_get_input(dialog_->input_ui_file);
        lyxrc.override_x_deadkeys =
@@ -1486,16 +1485,16 @@ void FormPreferences::Interface::build()
 {
        dialog_.reset(parent_.build_interface());
 
-       fl_set_input_return(dialog_->input_popup_font, FL_RETURN_CHANGED);
-       fl_set_input_return(dialog_->input_menu_font, FL_RETURN_CHANGED);
-       fl_set_input_return(dialog_->input_popup_encoding, FL_RETURN_CHANGED);
+       fl_set_input_return(dialog_->input_popup_normal_font, FL_RETURN_CHANGED);
+       fl_set_input_return(dialog_->input_popup_bold_font, FL_RETURN_CHANGED);
+       fl_set_input_return(dialog_->input_popup_font_encoding, FL_RETURN_CHANGED);
        fl_set_input_return(dialog_->input_bind_file, FL_RETURN_CHANGED);
        fl_set_input_return(dialog_->input_ui_file, FL_RETURN_CHANGED);
 
        // set up the feedback mechanism
-       setPreHandler(dialog_->input_popup_font);
-       setPreHandler(dialog_->input_menu_font);
-       setPreHandler(dialog_->input_popup_encoding);
+       setPreHandler(dialog_->input_popup_normal_font);
+       setPreHandler(dialog_->input_popup_bold_font);
+       setPreHandler(dialog_->input_popup_font_encoding);
        setPreHandler(dialog_->input_bind_file);
        setPreHandler(dialog_->button_bind_file_browse);
        setPreHandler(dialog_->input_ui_file);
@@ -1509,12 +1508,12 @@ FormPreferences::Interface::feedback(FL_OBJECT const * const ob) const
 {
        string str;
 
-       if (ob == dialog_->input_popup_font)
-               str = lyxrc.getDescription(LyXRC::RC_SCREEN_FONT_POPUP);
-       else if (ob == dialog_->input_menu_font)
-               str = lyxrc.getDescription(LyXRC::RC_SCREEN_FONT_MENU);
-       else if (ob == dialog_->input_popup_encoding)
-               str = lyxrc.getDescription(LyXRC::RC_SCREEN_FONT_ENCODING_MENU);
+       if (ob == dialog_->input_popup_normal_font)
+               str = lyxrc.getDescription(LyXRC::RC_POPUP_NORMAL_FONT);
+       else if (ob == dialog_->input_popup_bold_font)
+               str = lyxrc.getDescription(LyXRC::RC_POPUP_BOLD_FONT);
+       else if (ob == dialog_->input_popup_font_encoding)
+               str = lyxrc.getDescription(LyXRC::RC_POPUP_FONT_ENCODING);
        else if (ob == dialog_->input_bind_file)
                str = lyxrc.getDescription(LyXRC::RC_BINDFILE);
        else if (ob == dialog_->input_ui_file)
@@ -1530,11 +1529,11 @@ bool FormPreferences::Interface::input(FL_OBJECT const * const ob)
 {
        if (ob == dialog_->button_bind_file_browse) {
                string dir  = AddName(system_lyxdir, "bind");
-               string name = N_("Sys Bind");
+               string name = N_("Sys Bind|#S#s");
                pair<string,string> dir1(name, dir);
 
                dir = AddName(user_lyxdir, "bind");
-               name = N_("User Bind");
+               name = N_("User Bind|#U#u");
                pair<string,string> dir2(name, dir);
 
                parent_.browse(dialog_->input_bind_file,
@@ -1542,11 +1541,11 @@ bool FormPreferences::Interface::input(FL_OBJECT const * const ob)
                
        } else if (ob == dialog_->button_ui_file_browse) {
                string dir  = AddName(system_lyxdir, "ui");
-               string name = N_("Sys UI");
+               string name = N_("Sys UI|#S#s");
                pair<string,string> dir1(name, dir);
 
                dir = AddName(user_lyxdir, "ui");
-               name = N_("User UI");
+               name = N_("User UI|#U#u");
                pair<string,string> dir2(name, dir);
 
                parent_.browse(dialog_->input_ui_file,
@@ -1559,12 +1558,12 @@ bool FormPreferences::Interface::input(FL_OBJECT const * const ob)
 
 void FormPreferences::Interface::update()
 {
-       fl_set_input(dialog_->input_popup_font,
-                    lyxrc.popup_font_name.c_str());
-       fl_set_input(dialog_->input_menu_font,
-                    lyxrc.menu_font_name.c_str());
-       fl_set_input(dialog_->input_popup_encoding,
-                    lyxrc.font_norm_menu.c_str());
+       fl_set_input(dialog_->input_popup_normal_font,
+                    lyxrc.popup_normal_font.c_str());
+       fl_set_input(dialog_->input_popup_bold_font,
+                    lyxrc.popup_bold_font.c_str());
+       fl_set_input(dialog_->input_popup_font_encoding,
+                    lyxrc.popup_font_encoding.c_str());
        fl_set_input(dialog_->input_bind_file,
                     lyxrc.bind_file.c_str());
        fl_set_input(dialog_->input_ui_file,
@@ -1644,7 +1643,7 @@ void FormPreferences::Language::build()
        fl_deactivate_object(dialog_->choice_default_lang);
        combo_default_lang.reset(new Combox(FL_COMBOX_DROPLIST));
        combo_default_lang->add(obj->x, obj->y, obj->w, obj->h, 400,
-                               parent_.lang_opts_tab_->tabfolder_outer,
+                               parent_.lang_opts_tab_->tabfolder_inner,
                                parent_.dialog_->tabfolder_prefs);
        combo_default_lang->shortcut("#L",1);
        combo_default_lang->setcallback(ComboCB, &parent_);
@@ -1738,20 +1737,18 @@ bool FormPreferences::Language::input(FL_OBJECT const * const ob)
 
        if (ob == dialog_->button_kbmap1_browse) {
                string const dir  = AddName(system_lyxdir, "kbd");
-               string const name = N_("Key maps");
+               string const name = N_("Key maps|#K#k");
                pair<string, string> dir1(name, dir);
 
                parent_.browse(dialog_->input_kbmap1,
-                              N_("Keyboard map"), "*.kmap", dir1,
-                              make_pair(string(), string()));
+                              N_("Keyboard map"), "*.kmap", dir1);
        } else if (ob == dialog_->button_kbmap2_browse) {
                string const dir  = AddName(system_lyxdir, "kbd");
-               string const name = N_("Key maps");
+               string const name = N_("Key maps|#K#k");
                pair<string, string> dir1(name, dir);
 
                parent_.browse(dialog_->input_kbmap2,
-                              N_("Keyboard map"), "*.kmap", dir1,
-                              make_pair(string(), string()));
+                              N_("Keyboard map"), "*.kmap", dir1);
        }
 
        return activate;
@@ -2159,7 +2156,7 @@ bool FormPreferences::Paths::input(FL_OBJECT const * const ob)
 
        if (!ob || ob == dialog_->input_default_path) {
                string const name = fl_get_input(dialog_->input_default_path);
-               if (!RWInfo::WriteableDir(name)) {
+               if (!name.empty() && !RWInfo::WriteableDir(name)) {
                        parent_.printWarning(RWInfo::ErrorMessage());
                        return false;
                }
@@ -2167,7 +2164,7 @@ bool FormPreferences::Paths::input(FL_OBJECT const * const ob)
 
        if (!ob || ob == dialog_->input_template_path) {
                string const name = fl_get_input(dialog_->input_template_path);
-               if (!RWInfo::ReadableDir(name)) {
+               if (!name.empty() && !RWInfo::ReadableDir(name)) {
                        parent_.printWarning(RWInfo::ErrorMessage());
                        return false;
                }
@@ -2221,35 +2218,24 @@ bool FormPreferences::Paths::input(FL_OBJECT const * const ob)
 
        if (ob == dialog_->button_default_path_browse) {
                parent_.browse(dialog_->input_default_path,
-                              N_("Default path"), string(),
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("Default path"), string());
        } else if (ob == dialog_->button_template_path_browse) {
                parent_.browse(dialog_->input_template_path,
-                              N_("Template path"), string(),
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("Template path"), string());
        } else if (ob == dialog_->button_temp_dir_browse) {
                parent_.browse(dialog_->input_temp_dir,
-                              N_("Temp dir"), string(),
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("Temp dir"), string());
        } else if (ob == dialog_->button_lastfiles_browse) {
-               pair<string, string> dir(_("User"), user_lyxdir);
+               pair<string, string> dir(_("User|#U#u"), user_lyxdir);
 
                parent_.browse(dialog_->input_lastfiles,
-                              N_("Lastfiles"), string(), dir,
-                              make_pair(string(), string()));
+                              N_("Lastfiles"), string(), dir);
        } else if (ob == dialog_->button_backup_path_browse) {
                parent_.browse(dialog_->input_backup_path,
-                              N_("Backup path"), string(),
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("Backup path"), string());
        } else if (ob == dialog_->button_serverpipe_browse) {
                parent_.browse(dialog_->input_serverpipe,
-                              N_("LyX Server pipes"), string(),
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("LyX Server pipes"), string());
        }
        
        return activate;
@@ -2948,9 +2934,7 @@ bool FormPreferences::SpellOptions::input(FL_OBJECT const * const ob)
 
        if (ob == dialog_->button_personal_dict) {
                parent_.browse(dialog_->input_personal_dict,
-                              N_("Personal dictionary"), "*.ispell",
-                              make_pair(string(), string()),
-                              make_pair(string(), string()));
+                              N_("Personal dictionary"), "*.ispell");
        }
        
        return true; // All input is valid!