]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/xforms/FormCitation.C
fix crash with "save as"
[lyx.git] / src / frontends / xforms / FormCitation.C
index 22ac62b05d238701e5196a2f6e21c09d05575892..fafc6375c9140de316a3bf4c0c59e65084d4a1d9 100644 (file)
@@ -1,9 +1,12 @@
 /**
  * \file xforms/FormCitation.C
- * Copyright 2000-2001 The LyX Team.
- * See the file COPYING.
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
  *
- * \author Angus Leeming, a.leeming@ic.ac.uk
+ * \author Angus Leeming
+ * \author Rob Lahaye
+ *
+ * Full author contact details are available in file CREDITS
  */
 
 #include <config.h>
@@ -55,34 +58,12 @@ void fillChoice(FD_citation * dialog, vector<string> vec)
                return;
 
        // They will be changed. Proceed
-       string str = " ";
-       if (!vec.empty())
-               str += getStringFromVector(vec, " | ") + " ";
+       bool const noVec = vec.empty();
+       string const str = noVec ? string() : getStringFromVector(vec, "|");
 
        fl_clear_choice(dialog->choice_style);
        fl_addto_choice(dialog->choice_style, str.c_str());
-
-       setEnabled(dialog->choice_style, !vec.empty());
-       if (vec.empty())
-               return;
-
-       // The width of the choice varies with the contents.
-       // Ensure that it is centred in the frame.
-
-       int width = 0;
-       for (vector<string>::const_iterator it = vec.begin();
-            it != vec.end(); ++it) {
-               width = max(width, string_width(*it));
-       }
-
-       int const dx =
-               max(5, int(0.5 * (dialog->frame_style->w - width)));
-
-       fl_set_object_geometry(dialog->choice_style,
-                              dialog->frame_style->x + dx,
-                              dialog->choice_style->y,
-                              width,
-                              dialog->choice_style->h);
+       setEnabled(dialog->choice_style, !noVec);
 }
 
 
@@ -97,16 +78,13 @@ void updateStyle(FD_citation * dialog, string command)
                find(styles.begin(), styles.end(), cs.style);
 
        // Use this to initialise the GUI
-       if (cit == styles.end()) {
-               fl_set_choice(dialog->choice_style, 1);
-               fl_set_button(dialog->check_full_author_list, 0);
-               fl_set_button(dialog->check_force_uppercase, 0);
-       } else {
-               int const i = int(cit - styles.begin());
-               fl_set_choice(dialog->choice_style, i+1);
-               fl_set_button(dialog->check_full_author_list,  cs.full);
-               fl_set_button(dialog->check_force_uppercase, cs.forceUCase);
-       }
+       bool const noStyles = cit == styles.end();
+       int const index = 1 + ( noStyles ? 0 : int(cit - styles.begin()) );
+       fl_set_choice(dialog->choice_style, index);
+       
+       // Disable if there are no styles, otherwise use cs member settings.
+       fl_set_button(dialog->check_full_author_list, !noStyles && cs.full);
+       fl_set_button(dialog->check_force_uppercase, !noStyles && cs.forceUCase);
 }
 
 } // namespace anon
@@ -116,14 +94,14 @@ typedef FormCB<ControlCitation, FormDB<FD_citation> > base_class;
 
 
 FormCitation::FormCitation()
-       : base_class(_("Citation"), false)
+       : base_class(_("Citation"))
 {}
 
 
 void FormCitation::apply()
 {
        string command = "cite";
-       if (dialog_->choice_style->active != 0) {
+       if (isActive(dialog_->choice_style)) {
                vector<biblio::CiteStyle> const & styles =
                        ControlCitation::getCiteStyles();
 
@@ -140,7 +118,7 @@ void FormCitation::apply()
        controller().params().setCmdName(command);
        controller().params().setContents(getStringFromVector(citekeys));
 
-       string const after  = fl_get_input(dialog_->input_after);
+       string const after  = getString(dialog_->input_after);
        controller().params().setOptions(after);
 }
 
@@ -158,23 +136,13 @@ void FormCitation::build()
 {
        dialog_.reset(build_citation(this));
 
-       fl_set_input_return(dialog_->input_after,  FL_RETURN_CHANGED);
-       fl_set_input_return(dialog_->input_before, FL_RETURN_CHANGED);
-       fl_set_input_return(dialog_->input_search, FL_RETURN_END);
-
-       fl_set_button(dialog_->check_search_case, 0);
-       fl_set_button(dialog_->check_search_type, 0);
-
-       setPrehandler(dialog_->input_search);
-       setPrehandler(dialog_->input_before);
-       setPrehandler(dialog_->input_after);
-
        // Manage the ok, apply, restore and cancel/close buttons
        bc().setOK(dialog_->button_ok);
        bc().setApply(dialog_->button_apply);
        bc().setCancel(dialog_->button_close);
        bc().setRestore(dialog_->button_restore);
 
+       // disable for read-only documents
        bc().addReadOnly(dialog_->button_add);
        bc().addReadOnly(dialog_->button_del);
        bc().addReadOnly(dialog_->button_up);
@@ -185,6 +153,15 @@ void FormCitation::build()
        bc().addReadOnly(dialog_->check_full_author_list);
        bc().addReadOnly(dialog_->check_force_uppercase);
 
+       // trigger an input event for cut&paste with middle mouse button.
+       setPrehandler(dialog_->input_search);
+       setPrehandler(dialog_->input_before);
+       setPrehandler(dialog_->input_after);
+
+       fl_set_input_return(dialog_->input_after,  FL_RETURN_CHANGED);
+       fl_set_input_return(dialog_->input_before, FL_RETURN_CHANGED);
+       fl_set_input_return(dialog_->input_search, FL_RETURN_END);
+
        //set up the tooltip mechanism
        string str = _("Add the selected entry to the current citation reference.");
        tooltips().init(dialog_->button_add, str);
@@ -200,12 +177,18 @@ void FormCitation::build()
 
        str = _("The entries which will be cited. Select them with the arrow buttons from the right browser window.");
        tooltips().init(dialog_->browser_cite, str);
+       // Work-around xforms' bug; enable tooltips for browser widgets.
+       setPrehandler(dialog_->browser_cite);
 
        str = _("All entries in the database you have loaded (via \"Insert->Lists&TOC->BibTex Reference\"). Move the ones you want to cite with the arrow buttons into the left browser window.");
        tooltips().init(dialog_->browser_bib, str);
+       // Work-around xforms' bug; enable tooltips for browser widgets.
+       setPrehandler(dialog_->browser_bib);
 
        str = _("Information about the selected entry");
        tooltips().init(dialog_->browser_info, str);
+       // Work-around xforms' bug; enable tooltips for browser widgets.
+       setPrehandler(dialog_->browser_info);
 
        str = _("Here you may select how the citation label should look inside the text (Natbib).");
        tooltips().init(dialog_->choice_style, str);
@@ -235,7 +218,7 @@ void FormCitation::build()
 
 void FormCitation::findBiblio(biblio::Direction const dir)
 {
-       string const str = fl_get_input(dialog_->input_search);
+       string const str = getString(dialog_->input_search);
        biblio::InfoMap const & theMap = controller().bibkeysInfo();
        bool const caseSensitive =
                fl_get_button(dialog_->check_search_case);
@@ -292,22 +275,22 @@ ButtonPolicy::SMInput FormCitation::input(FL_OBJECT * ob, long)
                fl_clear_browser(dialog_->browser_info);
 
                string const tmp = formatted(biblio::getInfo(theMap,
-                                                            bibkeys[sel-1]),
-                                            dialog_->browser_info->w-10);
+                                                            bibkeys[sel - 1]),
+                                             dialog_->browser_info->w - 10);
                fl_add_browser_line(dialog_->browser_info, tmp.c_str());
 
                // Highlight the selected browser_bib key in browser_cite if
                // present
                vector<string>::const_iterator cit =
-                       find(citekeys.begin(), citekeys.end(), bibkeys[sel-1]);
+                       find(citekeys.begin(), citekeys.end(), bibkeys[sel - 1]);
 
                if (cit != citekeys.end()) {
                        int const n = int(cit - citekeys.begin());
-                       fl_select_browser_line(dialog_->browser_cite, n+1);
-                       fl_set_browser_topline(dialog_->browser_cite, n+1);
+                       fl_select_browser_line(dialog_->browser_cite, n + 1);
+                       fl_set_browser_topline(dialog_->browser_cite, n + 1);
                }
 
-               if (!controller().isReadonly()) {
+               if (!controller().bufferIsReadonly()) {
                        if (cit != citekeys.end()) {
                                setBibButtons(OFF);
                                setCiteButtons(ON);
@@ -322,27 +305,27 @@ ButtonPolicy::SMInput FormCitation::input(FL_OBJECT * ob, long)
                if (sel < 1 || sel > citekeys.size())
                        return ButtonPolicy::SMI_NOOP;
 
-               if (!controller().isReadonly()) {
+               if (!controller().bufferIsReadonly()) {
                        setBibButtons(OFF);
                        setCiteButtons(ON);
                }
 
                // Highlight the selected browser_cite key in browser_bib
                vector<string>::const_iterator cit =
-                       find(bibkeys.begin(), bibkeys.end(), citekeys[sel-1]);
+                       find(bibkeys.begin(), bibkeys.end(), citekeys[sel - 1]);
 
                if (cit != bibkeys.end()) {
                        int const n = int(cit - bibkeys.begin());
-                       fl_select_browser_line(dialog_->browser_bib, n+1);
-                       fl_set_browser_topline(dialog_->browser_bib, n+1);
+                       fl_select_browser_line(dialog_->browser_bib, n + 1);
+                       fl_set_browser_topline(dialog_->browser_bib, n + 1);
 
                        // Put into browser_info the additional info associated
                        // with the selected browser_cite key
                        fl_clear_browser(dialog_->browser_info);
                        string const tmp =
                                formatted(biblio::getInfo(theMap,
-                                                         citekeys[sel-1]),
-                                         dialog_->browser_info->w-10);
+                                                         citekeys[sel - 1]),
+                                         dialog_->browser_info->w - 10);
                        fl_add_browser_line(dialog_->browser_info, tmp.c_str());
                }
 
@@ -353,8 +336,8 @@ ButtonPolicy::SMInput FormCitation::input(FL_OBJECT * ob, long)
 
                // Add the selected browser_bib key to browser_cite
                fl_addto_browser(dialog_->browser_cite,
-                                bibkeys[sel-1].c_str());
-               citekeys.push_back(bibkeys[sel-1]);
+                                 bibkeys[sel - 1].c_str());
+               citekeys.push_back(bibkeys[sel - 1]);
 
                int const n = int(citekeys.size());
                fl_select_browser_line(dialog_->browser_cite, n);
@@ -370,7 +353,7 @@ ButtonPolicy::SMInput FormCitation::input(FL_OBJECT * ob, long)
 
                // Remove the selected key from browser_cite
                fl_delete_browser_line(dialog_->browser_cite, sel) ;
-               citekeys.erase(citekeys.begin() + sel-1);
+               citekeys.erase(citekeys.begin() + sel - 1);
 
                setBibButtons(ON);
                setCiteButtons(OFF);
@@ -382,25 +365,25 @@ ButtonPolicy::SMInput FormCitation::input(FL_OBJECT * ob, long)
                        return ButtonPolicy::SMI_NOOP;
 
                // Move the selected key up one line
-               vector<string>::iterator it = citekeys.begin() + sel-1;
+               vector<string>::iterator it = citekeys.begin() + sel - 1;
                string const tmp = *it;
 
                fl_delete_browser_line(dialog_->browser_cite, sel);
                citekeys.erase(it);
 
-               fl_insert_browser_line(dialog_->browser_cite, sel-1, tmp.c_str());
-               fl_select_browser_line(dialog_->browser_cite, sel-1);
-               citekeys.insert(it-1, tmp);
+               fl_insert_browser_line(dialog_->browser_cite, sel - 1, tmp.c_str());
+               fl_select_browser_line(dialog_->browser_cite, sel - 1);
+               citekeys.insert(it - 1, tmp);
                setCiteButtons(ON);
                activate = ButtonPolicy::SMI_VALID;
 
        } else if (ob == dialog_->button_down) {
                unsigned int const sel = fl_get_browser(dialog_->browser_cite);
-               if (sel < 1 || sel > citekeys.size()-1)
+               if (sel < 1 || sel > citekeys.size() - 1)
                        return ButtonPolicy::SMI_NOOP;
 
                // Move the selected key down one line
-               vector<string>::iterator it = citekeys.begin() + sel-1;
+               vector<string>::iterator it = citekeys.begin() + sel - 1;
                string const tmp = *it;
 
                fl_delete_browser_line(dialog_->browser_cite, sel);
@@ -487,8 +470,11 @@ void FormCitation::updateBrowser(FL_OBJECT * browser,
        // changed by loading the contents of the vec...
        vector<string> browser_keys = getVector(browser);
 
-       if (browser_keys == keys)
+       if (browser_keys == keys) {
+               fl_deselect_browser(browser);
+               fl_set_browser_topline(browser, 1);
                return;
+       }
 
        // They will be changed. Proceed.
        fl_clear_browser(browser);