Bugfixes: checkboxes to radiobuttons (from J�rgen S) and remove a little

[lyx.git] / src / frontends / xforms / FormBibtex.C

diff --git a/src/frontends/xforms/FormBibtex.C b/src/frontends/xforms/FormBibtex.C
index 7d1842aa6af50e50bb0cf98db8f38d1bb1e280cd..591a33068b89bca91a40eb80eaeb8dc4c678b60d 100644 (file)
--- a/src/frontends/xforms/FormBibtex.C
+++ b/src/frontends/xforms/FormBibtex.C
@@ -19,6 +19,7 @@
 #include "form_bibtex.h"
 #include "gettext.h"
 #include "debug.h"
+#include "helper_funcs.h"
 #include "support/lstrings.h"
 #include "support/filetools.h"
 
@@ -52,17 +53,16 @@ void FormBibtex::build()
 ButtonPolicy::SMInput FormBibtex::input(FL_OBJECT * ob, long)
 {
        if (ob == dialog_->database_browse) {
-               string const in_name  = fl_get_input(dialog_->database);
+               // When browsing, take the first file only 
+               string const in_name = fl_get_input(dialog_->database);
                string out_name = 
-                       controller().Browse(in_name,
+                       controller().Browse("",
                                            "Select Database",
                                            "*.bib| BibTeX Databases (*.bib)");
                if (!out_name.empty()) {
-                       if (suffixIs(out_name,".bib")) {
-                               // to prevent names like xxxbib.bib
-                               // (because latex needs it without suffix)
-                               out_name = ChangeExtension(out_name,"");
-                       }
+                       // add the database to any existing ones
+                       if (!in_name.empty())
+                               out_name = in_name + ", " + out_name;
 
                        fl_freeze_form(form()); 
                        fl_set_input(dialog_->database, out_name.c_str());
@@ -77,13 +77,6 @@ ButtonPolicy::SMInput FormBibtex::input(FL_OBJECT * ob, long)
                                            "Select BibTeX-Style",
                                            "*.bst| BibTeX Styles (*.bst)");
                if (!out_name.empty()) {
-                       out_name = OnlyFilename(out_name);
-                       if (suffixIs(out_name,".bst")) {
-                               // to prevent names like xxxbst.bst
-                               // (because bibtex needs it without the suffix)
-                               out_name = ChangeExtension(out_name,"");
-                       }
-
                        fl_freeze_form(form()); 
                        fl_set_input(dialog_->style, out_name.c_str());
                        fl_unfreeze_form(form()); 
@@ -120,23 +113,62 @@ void FormBibtex::update()
        }
 }
 
+namespace {
+
+// Remove all duplicate entries in c.
+// Taken stright out of Stroustrup
+template<class C> void eliminate_duplicates(C & c)
+{
+       std::sort(c.begin(), c.end()); // sort
+       typename C::iterator p = std::unique(c.begin(), c.end()); // compact
+       c.erase(p, c.end()); // shrink
+}
+
+string const unique_and_no_extensions(string const & str_in)
+{
+       std::vector<string> dbase = getVectorFromString(str_in);
+       for (std::vector<string>::iterator it = dbase.begin();
+            it != dbase.end(); ++it) {
+               *it = ChangeExtension(*it, "");
+       }
+       eliminate_duplicates(dbase);
+       return subst(getStringFromVector(dbase),",",", ");
+}
+ 
+} // namespace anon
+
 
 void FormBibtex::apply()
 {
-       controller().params().setContents(fl_get_input(dialog_->database));
-       string const bibstyle = fl_get_input(dialog_->style); // may be empty!
+       string const db = fl_get_input(dialog_->database);
+       if (db.empty()) {
+               // no database -> no bibtex-command and no options!
+               controller().params().setContents("");
+               controller().params().setOptions("");
+               return;
+       }
+       
+       controller().params().setContents(unique_and_no_extensions(db));
+
+       // empty is valid!
+       string bibstyle = fl_get_input(dialog_->style);
+       if (!bibstyle.empty()) {
+               // save the BibTeX style without any ".bst" extension
+               bibstyle = ChangeExtension(OnlyFilename(bibstyle), "");
+       }
 
-       if ((fl_get_button(dialog_->radio_bibtotoc) > 0) &&
-           (!bibstyle.empty())) {
+       bool const bibtotoc = fl_get_button(dialog_->radio_bibtotoc);
+       
+       if (bibtotoc && (!bibstyle.empty())) {
                // both bibtotoc and style
                controller().params().setOptions("bibtotoc,"+bibstyle);
-       } else {
-               if (fl_get_button(dialog_->radio_bibtotoc) > 0) {
-                       // bibtotoc and no style
-                       controller().params().setOptions("bibtotoc");
-               } else {
-                       // only style
-                       controller().params().setOptions(bibstyle);
-               }
+
+       } else if (bibtotoc) {
+               // bibtotoc and no style
+               controller().params().setOptions("bibtotoc");
+
+       } else if (!bibstyle.empty()){
+               // only style
+               controller().params().setOptions(bibstyle);
        }
 }