Tiny clean-ups.

[lyx.git] / src / frontends / xforms / ColorHandler.C

diff --git a/src/frontends/xforms/ColorHandler.C b/src/frontends/xforms/ColorHandler.C
index 65f45e7c286e0fe56ecc68054d29daeb88617dae..ac4da0db5043977d62b2419636bd9f6653de9298 100644 (file)
--- a/src/frontends/xforms/ColorHandler.C
+++ b/src/frontends/xforms/ColorHandler.C
@@ -5,30 +5,35 @@
  *
  * \author unknown
  *
- * Full author contact details are available in file CREDITS
+ * Full author contact details are available in file CREDITS.
  */
 
 #include <config.h>
 
-
 #include "ColorHandler.h"
-#include "LColor.h"
-#include "gettext.h"
+
 #include "debug.h"
+#include "gettext.h"
+#include "LColor.h"
 
-#include <boost/scoped_array.hpp>
-#include "support/tostr.h"
 #include "support/lstrings.h"
+#include "support/tostr.h"
+
+#include "lyx_forms.h"
+
+#include <boost/scoped_array.hpp>
 
 #include <cmath>
 
+using lyx::support::bformat;
+
 #ifndef CXX_GLOBAL_CSTD
 using std::pow;
 #endif
 
 using std::endl;
+using std::string;
 
-#include "lyx_forms.h"
 
 namespace {
 
@@ -42,6 +47,7 @@ namespace {
 
 
 LyXColorHandler::LyXColorHandler()
+               : colorGCcache(LColor::ignore + 1)
 {
        display = fl_get_display();
        drawable = XCreatePixmap(display,
@@ -50,7 +56,7 @@ LyXColorHandler::LyXColorHandler()
 
        colormap = fl_state[fl_get_vclass()].colormap;
        // Clear the GC cache
-       for (int i = 0; i <= LColor::ignore; ++i) {
+       for (string::size_type i = 0; i < colorGCcache.size(); ++i) {
                colorGCcache[i] = 0;
        }
 }
@@ -59,7 +65,7 @@ LyXColorHandler::LyXColorHandler()
 LyXColorHandler::~LyXColorHandler()
 {
        // Release all the registered GCs
-       for (int i = 0; i <= LColor::ignore; ++i) {
+       for (unsigned i = 0; i < colorGCcache.size(); ++i) {
                if (colorGCcache[i] != 0) {
                        XFreeGC(display, colorGCcache[i]);
                }
@@ -72,7 +78,7 @@ LyXColorHandler::~LyXColorHandler()
 }
 
 
-unsigned long LyXColorHandler::colorPixel(LColor::color c)
+unsigned long LyXColorHandler::colorPixel(LColor_color c)
 {
        XGCValues val;
        XGetGCValues(display, getGCForeground(c), GCForeground, &val);
@@ -80,40 +86,28 @@ unsigned long LyXColorHandler::colorPixel(LColor::color c)
 }
 
 
-// Gets GC according to color
-// Uses caching
-GC LyXColorHandler::getGCForeground(LColor::color c)
+GC LyXColorHandler::getGCForeground(string const & s)
 {
-       if (colorGCcache[c] != 0)
-               return colorGCcache[c];
-
        XColor xcol;
        XColor ccol;
-       string const s = lcolor.getX11Name(c);
        XGCValues val;
-
        // Look up the RGB values for the color, and an approximate
        // color that we can hope to get on this display.
        if (XLookupColor(display, colormap, s.c_str(), &xcol, &ccol) == 0) {
                lyxerr << bformat(
-                       _("LyX: Unknown X11 color %1$s for %2$s\n"
+                       _("LyX: Unknown X11 color %1$s\n"
                          "     Using black instead, sorry!"),
-                       s, lcolor.getGUIName(c)) << endl;
+                       s) << endl;
                unsigned long bla = BlackPixel(display,
                                               DefaultScreen(display));
                val.foreground = bla;
        // Try the exact RGB values first, then the approximate.
        } else if (XAllocColor(display, colormap, &xcol) != 0) {
                if (lyxerr.debugging(Debug::GUI)) {
-                       lyxerr << bformat(_("LyX: X11 color %1$s allocated for %2$s"),
-                               s, lcolor.getGUIName(c)) << endl;
+                       lyxerr << bformat(_("LyX: X11 color %1$s allocated"),
+                               s) << endl;
                }
                val.foreground = xcol.pixel;
-       } else if (XAllocColor(display, colormap, &ccol)) {
-               lyxerr << bformat(
-                       _("LyX: Using approximated X11 color %1$s allocated for %2$s"),
-                       s, lcolor.getGUIName(c)) << endl;
-               val.foreground = xcol.pixel;
        } else {
                // Here we are traversing the current colormap to find
                // the color closest to the one we want.
@@ -153,26 +147,49 @@ GC LyXColorHandler::getGCForeground(LColor::color c)
                }
 
                lyxerr << bformat(
-                       _("LyX: Couldn't allocate '%1$s' for %2$s with (r,g,b)=%3$s.\n"),
-                       s, lcolor.getGUIName(c), tostr(xcol));
+                       _("LyX: Couldn't allocate '%1$s' with (r,g,b)=%3$s.\n"),
+                       s, tostr(xcol));
 
                lyxerr << bformat(
                                _("     Using closest allocated color with (r,g,b)=%1$s instead.\n"
-                         "Pixel [%2$s] is used."), 
+                         "Pixel [%2$s] is used."),
                        tostr(cmap[closest_pixel]), tostr(closest_pixel)) << endl;
 
                val.foreground = cmap[closest_pixel].pixel;
        }
-
        val.function = GXcopy;
-       return colorGCcache[c] = XCreateGC(display, drawable,
+       return XCreateGC(display, drawable,
                                           GCForeground | GCFunction, &val);
 }
 
+// Gets GC according to color
+// Uses caching
+GC LyXColorHandler::getGCForeground(LColor_color c)
+{
+       if (static_cast<unsigned>(c) >= colorGCcache.size()) {
+               colorGCcache.resize(c + 1, 0);
+       }
+
+       if (colorGCcache[c] != 0) {
+               return colorGCcache[c];
+       }
+       XColor xcol;
+       XColor ccol;
+       string const s = lcolor.getX11Name(c);
+       // Look up the RGB values for the color, and an approximate
+       // color that we can hope to get on this display.
+       if (XLookupColor(display, colormap, s.c_str(), &xcol, &ccol) == 0) {
+               lyxerr << bformat(
+                       _("LyX: Unknown X11 color %1$s for %2$s\n"),
+                       s, lcolor.getGUIName(c)) << endl;
+       }
+       return colorGCcache[c] = getGCForeground(s);
+}
+
 
 // Gets GC for line
 GC LyXColorHandler::getGCLinepars(Painter::line_style ls,
-                                 Painter::line_width lw, LColor::color c)
+                                 Painter::line_width lw, LColor_color c)
 {
        //if (lyxerr.debugging()) {
        //      lyxerr << "Painter drawable: " << drawable() << endl;
@@ -218,7 +235,7 @@ GC LyXColorHandler::getGCLinepars(Painter::line_style ls,
 
 
 // update GC cache after color redefinition
-void LyXColorHandler::updateColor (LColor::color c)
+void LyXColorHandler::updateColor (LColor_color c)
 {
        // color GC cache
        GC gc = colorGCcache[c];