#include <QHeaderView>
#include <QMenu>
-#include <QTimer>
#include <vector>
-#define DELAY_UPDATE_VIEW
-
using namespace std;
namespace lyx {
namespace frontend {
TocWidget::TocWidget(GuiView & gui_view, QWidget * parent)
- : QWidget(parent), depth_(0), persistent_(false), gui_view_(gui_view), update_delay_(0)
-
+ : QWidget(parent), depth_(0), persistent_(false), gui_view_(gui_view),
+ timer_(new QTimer(this))
{
setupUi(this);
moveDownTB->setIcon(QIcon(getPixmap("images/", "outline-down", "svgz,png")));
updateTB->setIcon(QIcon(getPixmap("images/", "reload", "svgz,png")));
+ QSize icon_size = gui_view.iconSize();
+ moveOutTB->setIconSize(icon_size);
+ moveInTB->setIconSize(icon_size);
+ moveUpTB->setIconSize(icon_size);
+ moveDownTB->setIconSize(icon_size);
+ updateTB->setIconSize(icon_size);
+
// avoid flickering
tocTV->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
connect(filterLE, SIGNAL(textEdited(QString)),
this, SLOT(filterContents()));
+ // setting the update timer
+ timer_->setSingleShot(true);
+ connect(timer_, SIGNAL(timeout()), this, SLOT(finishUpdateView()));
+
init(QString());
}
case LFUN_OUTLINE_IN:
case LFUN_OUTLINE_OUT:
case LFUN_SECTION_SELECT:
- status.setEnabled(item.dit() != 0);
+ status.setEnabled((bool)item.dit());
return true;
case LFUN_LABEL_COPY_AS_REFERENCE: {
if (button & Qt::LeftButton) {
goTo(index);
gui_view_.setFocus();
+ gui_view_.activateWindow();
}
}
void TocWidget::on_sortCB_stateChanged(int state)
{
gui_view_.tocModels().sort(current_type_, state == Qt::Checked);
- updateViewForce();
+ updateViewNow();
}
if (index == -1)
return;
current_type_ = typeCO->itemData(index).toString();
- updateViewForce();
+ updateViewNow();
if (typeCO->hasFocus())
gui_view_.setFocus();
}
void TocWidget::updateView()
{
-// Enable if you dont want the delaying business, cf #7138.
-#ifndef DELAY_UPDATE_VIEW
- updateViewForce();
- return;
-#endif
- // already scheduled?
- if (update_delay_ == -1)
- return;
- QTimer::singleShot(update_delay_, this, SLOT(updateViewForce()));
- // Subtler optimization for having the delay more UI invisible.
- // We trigger update immediately for sparse editation actions,
- // i.e. there was no editation/cursor movement in last 2 sec.
- // At worst there will be +1 redraw after 2s in a such "calm" mode.
- if (update_delay_ != 0)
- updateViewForce();
- update_delay_ = -1;
-}
-
-void TocWidget::updateViewForce()
-{
- update_delay_ = 2000;
if (!gui_view_.documentBufferView()) {
tocTV->setModel(0);
depthSL->setMaximum(0);
setEnabled(true);
bool const is_sortable = isSortable();
sortCB->setEnabled(is_sortable);
- bool focus_ = tocTV->hasFocus();
+ bool focus = tocTV->hasFocus();
tocTV->setEnabled(false);
tocTV->setUpdatesEnabled(false);
&& gui_view_.tocModels().isSorted(current_type_));
sortCB->blockSignals(false);
- bool const can_navigate_ = canNavigate();
- persistentCB->setEnabled(can_navigate_);
+ persistentCB->setEnabled(canNavigate());
bool controls_enabled = toc_model && toc_model->rowCount() > 0
&& !gui_view_.documentBufferView()->buffer().isReadonly();
depthSL->setMaximum(gui_view_.tocModels().depth(current_type_));
depthSL->setValue(depth_);
- if (!persistent_ && can_navigate_)
- setTreeDepth(depth_);
- if (can_navigate_) {
+ tocTV->setEnabled(true);
+ tocTV->setUpdatesEnabled(true);
+ if (focus)
+ tocTV->setFocus();
+
+ // Expensive operations are on a timer. We finish the update immediately
+ // for sparse edition actions, i.e. there was no edition/cursor movement
+ // recently, then every 300ms.
+ if (!timer_->isActive()) {
+ finishUpdateView();
+ timer_->start(300);
+ }
+}
+
+
+void TocWidget::updateViewNow()
+{
+ timer_->stop();
+ updateView();
+}
+
+
+void TocWidget::finishUpdateView()
+{
+ // Profiling shows that this is the expensive stuff in the context of typing
+ // text and moving with arrows (still five times less than updateToolbars in
+ // my tests with a medium-sized document, however this grows linearly in the
+ // size of the document). For bigger operations, this is negligible, and
+ // outweighted by TocModels::reset() anyway.
+ if (canNavigate()) {
+ if (!persistent_)
+ setTreeDepth(depth_);
persistentCB->setChecked(persistent_);
select(gui_view_.tocModels().currentIndex(current_type_));
}
filterContents();
- tocTV->setEnabled(true);
- tocTV->setUpdatesEnabled(true);
- if (focus_)
- tocTV->setFocus();
}
typeCO->blockSignals(true);
typeCO->setCurrentIndex(new_index);
typeCO->blockSignals(false);
-
- // no delay when the whole outliner is reseted.
- update_delay_ = 0;
+ updateViewNow();
}
} // namespace frontend