]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/Menus.cpp
Fix the tab ordering of GuiDocument components.
[lyx.git] / src / frontends / qt4 / Menus.cpp
index 26f90b1078e4cb5c7ac4f2b9e3ed746fe25e2bb2..8689b32f05b834e1fd6c6be55807743daa0c2092 100644 (file)
@@ -333,7 +333,7 @@ public:
        void expandLastfiles();
        void expandDocuments();
        void expandBookmarks();
-       void expandFormats(MenuItem::Kind kind, Buffer const * buf);
+       void expandFormats(MenuItem::Kind const kind, Buffer const * buf);
        void expandFloatListInsert(Buffer const * buf);
        void expandFloatInsert(Buffer const * buf);
        void expandFlexInsert(Buffer const * buf, InsetLayout::InsetLyXType type);
@@ -764,9 +764,11 @@ void MenuDefinition::expandSpellingSuggestions(BufferView const * bv)
 {
        if (!bv)
                return;
+       Cursor const & cur = bv->cursor();
+       if (!cur.inTexted())
+               return;
        WordLangTuple wl;
        docstring_list suggestions;
-       Cursor const & cur = bv->cursor();
        Paragraph const & par = cur.paragraph();
        pos_type from = cur.pos();
        pos_type to = from;
@@ -786,8 +788,8 @@ void MenuDefinition::expandSpellingSuggestions(BufferView const * bv)
                                        LYXERR(Debug::GUI, suggestion);
                                        MenuItem w(MenuItem::Command, toqstr(suggestion),
                                                FuncRequest(LFUN_WORD_REPLACE, 
-                                                       replace2string(suggestion,selection,
-                                                               true, true, false, false)));
+                                                       replace2string(suggestion, selection,
+                                                               true, true, false, true, false)));
                                        if (i < m)
                                                add(w);
                                        else
@@ -990,14 +992,14 @@ void MenuDefinition::expandBookmarks()
 }
 
 
-void MenuDefinition::expandFormats(MenuItem::Kind kind, Buffer const * buf)
+void MenuDefinition::expandFormats(MenuItem::Kind const kind, Buffer const * buf)
 {
        if (!buf && kind != MenuItem::ImportFormats)
                return;
 
        typedef vector<Format const *> Formats;
        Formats formats;
-       FuncCode action;
+       FuncCode action = LFUN_NOACTION;
 
        switch (kind) {
        case MenuItem::ImportFormats:
@@ -1005,17 +1007,22 @@ void MenuDefinition::expandFormats(MenuItem::Kind kind, Buffer const * buf)
                action = LFUN_BUFFER_IMPORT;
                break;
        case MenuItem::ViewFormats:
-               formats = buf->exportableFormats(true);
+               formats = buf->params().exportableFormats(true);
                action = LFUN_BUFFER_VIEW;
                break;
        case MenuItem::UpdateFormats:
-               formats = buf->exportableFormats(true);
+               formats = buf->params().exportableFormats(true);
                action = LFUN_BUFFER_UPDATE;
                break;
-       default:
-               formats = buf->exportableFormats(false);
+       case MenuItem::ExportFormats:
+               formats = buf->params().exportableFormats(false);
                action = LFUN_BUFFER_EXPORT;
+               break;
+       default:
+               LASSERT(false, /* */);
+               return;
        }
+       
        sort(formats.begin(), formats.end(), &compareFormat);
 
        bool const view_update = (kind == MenuItem::ViewFormats
@@ -1023,8 +1030,8 @@ void MenuDefinition::expandFormats(MenuItem::Kind kind, Buffer const * buf)
 
        QString smenue;
        if (view_update)
-               smenue = (kind == MenuItem::ViewFormats ?
-                       qt_("View (Other Formats)|F")
+               smenue = (kind == MenuItem::ViewFormats
+                       qt_("View (Other Formats)|F")
                        : qt_("Update (Other Formats)|p"));
        MenuItem item(MenuItem::Submenu, smenue);
        item.setSubmenu(MenuDefinition(smenue));
@@ -1036,59 +1043,55 @@ void MenuDefinition::expandFormats(MenuItem::Kind kind, Buffer const * buf)
                        continue;
 
                docstring lab = from_utf8((*fit)->prettyname());
-               docstring scut = from_utf8((*fit)->shortcut());
+               docstring const scut = from_utf8((*fit)->shortcut());
                docstring const tmplab = lab;
  
                if (!scut.empty())
                        lab += char_type('|') + scut;
-               docstring lab_i18n = translateIfPossible(lab);
+               docstring const lab_i18n = translateIfPossible(lab);
+               docstring const shortcut = split(lab_i18n, lab, '|');
+
                bool const untranslated = (lab == lab_i18n);
-               QString const shortcut = toqstr(split(lab_i18n, lab, '|'));
-               QString label = toqstr(lab);
-               if (untranslated)
-                       // this might happen if the shortcut
-                       // has been redefined
-                       label = toqstr(translateIfPossible(tmplab));
+               docstring label = untranslated ? translateIfPossible(tmplab) : lab;
 
                switch (kind) {
                case MenuItem::ImportFormats:
-                       label += "...";
+                       label += from_ascii("...");
                        break;
                case MenuItem::ViewFormats:
                case MenuItem::UpdateFormats:
-                       if ((*fit)->name() == buf->getDefaultOutputFormat()) {
-                               docstring lbl = (kind == MenuItem::ViewFormats ?
-                                       bformat(_("View [%1$s]|V"), qstring_to_ucs4(label))
-                                       : bformat(_("Update [%1$s]|U"), qstring_to_ucs4(label)));
-                               MenuItem w(MenuItem::Command, toqstr(lbl),
-                                          FuncRequest(action));
-                               add(w);
+                       if ((*fit)->name() == buf->params().getDefaultOutputFormat()) {
+                               docstring lbl = (kind == MenuItem::ViewFormats
+                                       ? bformat(_("View [%1$s]|V"), label)
+                                       : bformat(_("Update [%1$s]|U"), label));
+                               add(MenuItem(MenuItem::Command, toqstr(lbl), FuncRequest(action)));
                                continue;
                        }
+               // fall through
                case MenuItem::ExportFormats:
                        if (!(*fit)->inExportMenu())
                                continue;
                        break;
                default:
-                       LASSERT(false, /**/);
-                       break;
+                       LASSERT(false, /* */);
+                       continue;
                }
-               if (!shortcut.isEmpty())
+               if (!shortcut.empty())
                        label += '|' + shortcut;
 
                if (view_update) {
                        if (buf)
-                               item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command, label,
-                                       FuncRequest(action, (*fit)->name())));
+                               item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command, 
+                                       toqstr(label), FuncRequest(action, (*fit)->name())));
                        else
-                               item.submenu().add(MenuItem(MenuItem::Command, label,
+                               item.submenu().add(MenuItem(MenuItem::Command, toqstr(label),
                                        FuncRequest(action, (*fit)->name())));
                } else {
                        if (buf)
-                               addWithStatusCheck(MenuItem(MenuItem::Command, label,
+                               addWithStatusCheck(MenuItem(MenuItem::Command, toqstr(label),
                                        FuncRequest(action, (*fit)->name())));
                        else
-                               add(MenuItem(MenuItem::Command, label,
+                               add(MenuItem(MenuItem::Command, toqstr(label),
                                        FuncRequest(action, (*fit)->name())));
                }
        }
@@ -1628,6 +1631,17 @@ void Menu::updateView()
 }
 
 
+void Menu::clear()
+{
+       QList<QAction *> items = actions();
+       for (int i = 0; i != items.size(); ++i) {
+               // QAction::menu() returns 0 if there's no submenu.
+               delete items.at(i)->menu();
+       }
+       QMenu::clear();
+}
+
+
 /////////////////////////////////////////////////////////////////////
 // Menus::Impl definition and implementation
 /////////////////////////////////////////////////////////////////////
@@ -1732,9 +1746,10 @@ void Menus::Impl::macxMenuBarInit(GuiView * view, QMenuBar * qmb)
                {LFUN_LYX_QUIT, "", "Quit LyX", QAction::QuitRole}
        };
        const size_t num_entries = sizeof(entries) / sizeof(entries[0]);
+       const bool first_call = mac_special_menu_.size() == 0;
 
        // the special menu for Menus. Fill it up only once.
-       if (mac_special_menu_.size() == 0) {
+       if (first_call) {
                for (size_t i = 0 ; i < num_entries ; ++i) {
                        FuncRequest const func(entries[i].action,
                                from_utf8(entries[i].arg));
@@ -1742,17 +1757,26 @@ void Menus::Impl::macxMenuBarInit(GuiView * view, QMenuBar * qmb)
                                entries[i].label, func));
                }
        }
-       
+
        // add the entries to a QMenu that will eventually be empty
        // and therefore invisible.
        QMenu * qMenu = qmb->addMenu("special");
        MenuDefinition::const_iterator cit = mac_special_menu_.begin();
        MenuDefinition::const_iterator end = mac_special_menu_.end();
        for (size_t i = 0 ; cit != end ; ++cit, ++i) {
+#if defined(QT_MAC_USE_COCOA) && (QT_MAC_USE_COCOA > 0)
+               if (first_call || entries[i].role != QAction::ApplicationSpecificRole) {
+                       Action * action = new Action(view, QIcon(), cit->label(),
+                                cit->func(), QString(), qMenu);
+                       action->setMenuRole(entries[i].role);
+                       qMenu->addAction(action);
+               }
+#else
                Action * action = new Action(view, QIcon(), cit->label(),
                        cit->func(), QString(), qMenu);
                action->setMenuRole(entries[i].role);
                qMenu->addAction(action);
+#endif
        }
 }