]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiWorkArea.cpp
fix memory leaks
[lyx.git] / src / frontends / qt4 / GuiWorkArea.cpp
index 9c99508c6d03a54d36a932b2703b7a795dc6aeb2..2c53eb524ff99b995b1e6a4b8e0073ae0ffb8367 100644 (file)
 
 #include "GuiWorkArea.h"
 
-#include "GuiApplication.h"
-#include "GuiPainter.h"
-#include "GuiKeySymbol.h"
-#include "qt_helpers.h"
-
-#include "frontends/LyXView.h"
-
 #include "Buffer.h"
+#include "BufferParams.h"
 #include "BufferView.h"
-#include "Color.h"
+#include "CoordCache.h"
 #include "Cursor.h"
-#include "debug.h"
+#include "Font.h"
 #include "FuncRequest.h"
+#include "GuiApplication.h"
+#include "GuiKeySymbol.h"
+#include "GuiPainter.h"
+#include "GuiView.h"
+#include "KeySymbol.h"
+#include "Language.h"
 #include "LyXFunc.h"
 #include "LyXRC.h"
+#include "MetricsInfo.h"
+#include "qt_helpers.h"
 #include "version.h"
 
 #include "graphics/GraphicsImage.h"
 #include "graphics/GraphicsLoader.h"
 
+#include "support/debug.h"
+#include "support/gettext.h"
+#include "support/FileName.h"
+#include "support/ForkedCalls.h"
+
+#include "frontends/Application.h"
+#include "frontends/FontMetrics.h"
+#include "frontends/WorkAreaManager.h"
+
 #include <QInputContext>
 #include <QLayout>
 #include <QMainWindow>
@@ -43,7 +54,6 @@
 #include <QTabBar>
 #include <QTimer>
 
-#include <boost/current_function.hpp>
 #include <boost/bind.hpp>
 
 #ifdef Q_WS_X11
@@ -61,12 +71,15 @@ int const CursorWidth = 1;
 #undef NoModifier 
 
 using std::endl;
+using std::min;
+using std::max;
 using std::string;
 
 namespace lyx {
 
 using support::FileName;
 
+
 /// return the LyX mouse button state from Qt's
 static mouse_button::state q_button_state(Qt::MouseButton button)
 {
@@ -135,7 +148,7 @@ public:
 
        void update(int x, int y, int h, CursorShape shape)
        {
-               color_ = guiApp->colorCache().get(Color::cursor);
+               color_ = guiApp->colorCache().get(Color_cursor);
                shape_ = shape;
                switch (shape) {
                case L_SHAPE:
@@ -175,19 +188,31 @@ SyntheticMouseEvent::SyntheticMouseEvent()
 {}
 
 
-GuiWorkArea::GuiWorkArea(Buffer & buf, LyXView & lv)
-       : WorkArea(buf, lv), need_resize_(false), schedule_redraw_(false),
-         preedit_lines_(1)
+
+GuiWorkArea::GuiWorkArea(Buffer & buffer, GuiView & lv)
+       : buffer_view_(new BufferView(buffer)), lyx_view_(&lv),
+         cursor_visible_(false),
+    need_resize_(false), schedule_redraw_(false),
+               preedit_lines_(1)
 {
+       buffer.workAreaManager().add(this);
+       // Setup the signals
+       cursor_timeout_.setInterval(400);
+       connect(&cursor_timeout_, SIGNAL(timeout()),
+               this, SLOT(toggleCursor()));
+
+       cursor_timeout_.start();
+
        screen_ = QPixmap(viewport()->width(), viewport()->height());
        cursor_ = new frontend::CursorWidget();
        cursor_->hide();
 
-       setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);
+       setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
        setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
        setAcceptDrops(true);
        setMouseTracking(true);
        setMinimumSize(100, 70);
+       updateWindowTitle();
 
        viewport()->setAutoFillBackground(false);
        // We don't need double-buffering nor SystemBackground on
@@ -200,7 +225,7 @@ GuiWorkArea::GuiWorkArea(Buffer & buf, LyXView & lv)
 
        synthetic_mouse_event_.timeout.timeout.connect(
                boost::bind(&GuiWorkArea::generateSyntheticMouseEvent,
-                           this));
+                                       this));
 
        // Initialize the vertical Scroll Bar
        QObject::connect(verticalScrollBar(), SIGNAL(actionTriggered(int)),
@@ -212,12 +237,8 @@ GuiWorkArea::GuiWorkArea(Buffer & buf, LyXView & lv)
        // PageStep only depends on the viewport height.
        verticalScrollBar()->setPageStep(viewport()->height());
 
-       LYXERR(Debug::GUI) << BOOST_CURRENT_FUNCTION
-               << "\n Area width\t" << width()
-               << "\n Area height\t" << height()
-               << "\n viewport width\t" << viewport()->width()
-               << "\n viewport height\t" << viewport()->height()
-               << endl;
+       LYXERR(Debug::GUI, "viewport width: " << viewport()->width()
+               << "  viewport height: " << viewport()->height());
 
        // Enables input methods for asian languages.
        // Must be set when creating custom text editing widgets.
@@ -225,21 +246,235 @@ GuiWorkArea::GuiWorkArea(Buffer & buf, LyXView & lv)
 }
 
 
-void GuiWorkArea::setScrollbarParams(int h, int scroll_pos, int scroll_line_step)
+
+GuiWorkArea::~GuiWorkArea()
+{
+       buffer_view_->buffer().workAreaManager().remove(this);
+       delete buffer_view_;
+       delete cursor_;
+}
+
+
+void GuiWorkArea::close()
+{
+       lyx_view_->removeWorkArea(this);
+}
+
+
+BufferView & GuiWorkArea::bufferView()
+{
+       return *buffer_view_;
+}
+
+
+BufferView const & GuiWorkArea::bufferView() const
+{
+       return *buffer_view_;
+}
+
+
+void GuiWorkArea::stopBlinkingCursor()
+{
+       cursor_timeout_.stop();
+       hideCursor();
+}
+
+
+void GuiWorkArea::startBlinkingCursor()
+{
+       showCursor();
+       cursor_timeout_.start();
+}
+
+
+void GuiWorkArea::redraw()
+{
+       if (!isVisible())
+               // No need to redraw in this case.
+               return;
+
+       // No need to do anything if this is the current view. The BufferView
+       // metrics are already up to date.
+       if (lyx_view_ != guiApp->currentView()) {
+               // FIXME: it would be nice to optimize for the off-screen case.
+               buffer_view_->updateMetrics();
+               buffer_view_->cursor().fixIfBroken();
+       }
+
+       updateScrollbar();
+
+       // update cursor position, because otherwise it has to wait until
+       // the blinking interval is over
+       if (cursor_visible_) {
+               hideCursor();
+               showCursor();
+       }
+       
+       LYXERR(Debug::WORKAREA, "WorkArea::redraw screen");
+       updateScreen();
+       update(0, 0, viewport()->width(), viewport()->height());
+
+       lyx_view_->updateStatusBar();
+
+       if (lyxerr.debugging(Debug::WORKAREA))
+               buffer_view_->coordCache().dump();
+}
+
+
+void GuiWorkArea::processKeySym(KeySymbol const & key, KeyModifier mod)
 {
-       if (verticalScrollBarPolicy() != Qt::ScrollBarAlwaysOn)
-               setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOn);
+       // In order to avoid bad surprise in the middle of an operation,
+       // we better stop the blinking cursor.
+       stopBlinkingCursor();
+
+       theLyXFunc().setLyXView(lyx_view_);
+       theLyXFunc().processKeySym(key, mod);
+}
+
+
+void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
+{
+       // Handle drag&drop
+       if (cmd0.action == LFUN_FILE_OPEN) {
+               lyx_view_->dispatch(cmd0);
+               return;
+       }
+
+       theLyXFunc().setLyXView(lyx_view_);
+
+       FuncRequest cmd;
+
+       if (cmd0.action == LFUN_MOUSE_PRESS) {
+               if (mod == ShiftModifier)
+                       cmd = FuncRequest(cmd0, "region-select");
+               else if (mod == ControlModifier)
+                       cmd = FuncRequest(cmd0, "paragraph-select");
+               else
+                       cmd = cmd0;
+       }
+       else
+               cmd = cmd0;
+
+       // In order to avoid bad surprise in the middle of an operation, we better stop
+       // the blinking cursor.
+       if (!(cmd.action == LFUN_MOUSE_MOTION
+               && cmd.button() == mouse_button::none))
+               stopBlinkingCursor();
+
+       buffer_view_->mouseEventDispatch(cmd);
 
+       // Skip these when selecting
+       if (cmd.action != LFUN_MOUSE_MOTION) {
+               lyx_view_->updateLayoutList();
+               lyx_view_->updateToolbars();
+       }
+
+       // GUI tweaks except with mouse motion with no button pressed.
+       if (!(cmd.action == LFUN_MOUSE_MOTION
+               && cmd.button() == mouse_button::none)) {
+               // Slight hack: this is only called currently when we
+               // clicked somewhere, so we force through the display
+               // of the new status here.
+               lyx_view_->clearMessage();
+
+               // Show the cursor immediately after any operation.
+               startBlinkingCursor();
+       }
+}
+
+
+void GuiWorkArea::resizeBufferView()
+{
+       // WARNING: Please don't put any code that will trigger a repaint here!
+       // We are already inside a paint event.
+       lyx_view_->setBusy(true);
+       buffer_view_->resize(viewport()->width(), viewport()->height());
+       lyx_view_->updateLayoutList();
+       lyx_view_->setBusy(false);
+       need_resize_ = false;
+}
+
+
+void GuiWorkArea::showCursor()
+{
+       if (cursor_visible_)
+               return;
+
+       CursorShape shape = BAR_SHAPE;
+
+       Font const & realfont = buffer_view_->cursor().real_current_font;
+       BufferParams const & bp = buffer_view_->buffer().params();
+       bool const samelang = realfont.language() == bp.language;
+       bool const isrtl = realfont.isVisibleRightToLeft();
+
+       if (!samelang || isrtl != bp.language->rightToLeft()) {
+               shape = L_SHAPE;
+               if (isrtl)
+                       shape = REVERSED_L_SHAPE;
+       }
+
+       // The ERT language hack needs fixing up
+       if (realfont.language() == latex_language)
+               shape = BAR_SHAPE;
+
+       Font const font = buffer_view_->cursor().getFont();
+       FontMetrics const & fm = theFontMetrics(font);
+       int const asc = fm.maxAscent();
+       int const des = fm.maxDescent();
+       int h = asc + des;
+       int x = 0;
+       int y = 0;
+       buffer_view_->cursor().getPos(x, y);
+       y -= asc;
+
+       // if it doesn't touch the screen, don't try to show it
+       if (y + h < 0 || y >= viewport()->height())
+               return;
+
+       cursor_visible_ = true;
+       showCursor(x, y, h, shape);
+}
+
+
+void GuiWorkArea::hideCursor()
+{
+       if (!cursor_visible_)
+               return;
+
+       cursor_visible_ = false;
+       removeCursor();
+}
+
+
+void GuiWorkArea::toggleCursor()
+{
+       if (cursor_visible_)
+               hideCursor();
+       else
+               showCursor();
+
+       // Use this opportunity to deal with any child processes that
+       // have finished but are waiting to communicate this fact
+       // to the rest of LyX.
+       support::ForkedCallsController::handleCompletedProcesses();
+}
+
+
+void GuiWorkArea::updateScrollbar()
+{
        verticalScrollBar()->setTracking(false);
 
+       buffer_view_->updateScrollbar();
+       ScrollbarParameters const & scroll_ = buffer_view_->scrollbarParameters();
+
        // do what cursor movement does (some grey)
-       h += height() / 4;
-       int scroll_max_ = std::max(0, h - height());
+       int const h = scroll_.height + viewport()->height() / 4;
+       int scroll_max_ = std::max(0, h - viewport()->height());
 
        verticalScrollBar()->setRange(0, scroll_max_);
-       verticalScrollBar()->setSliderPosition(scroll_pos);
-       verticalScrollBar()->setSingleStep(scroll_line_step);
-       verticalScrollBar()->setValue(scroll_pos);
+       verticalScrollBar()->setSliderPosition(scroll_.position);
+       verticalScrollBar()->setSingleStep(scroll_.lineScrollHeight);
+       verticalScrollBar()->setValue(scroll_.position);
 
        verticalScrollBar()->setTracking(true);
 }
@@ -257,7 +492,7 @@ void GuiWorkArea::adjustViewWithScrollBar(int action)
 
        if (lyxrc.cursor_follows_scrollbar) {
                buffer_view_->setCursorFromScrollbar();
-               lyx_view_->updateLayoutChoice();
+               lyx_view_->updateLayoutList();
        }
        // Show the cursor immediately after any operation.
        startBlinkingCursor();
@@ -412,20 +647,15 @@ void GuiWorkArea::keyPressEvent(QKeyEvent * ev)
 #ifdef Q_WS_X11
        if (XEventsQueued(QX11Info::display(), 0) > 1 && ev->isAutoRepeat() 
                        && (Qt::Key_PageDown || Qt::Key_PageUp)) {
-               LYXERR(Debug::KEY)      
-                       << BOOST_CURRENT_FUNCTION << endl
-                       << "system is busy: scroll key event ignored" << endl;
+               LYXERR(Debug::KEY, "system is busy: scroll key event ignored");
                ev->ignore();
                return;
        }
 #endif
 
-       LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
-               << " count=" << ev->count()
-               << " text=" << fromqstr(ev->text())
-               << " isAutoRepeat=" << ev->isAutoRepeat()
-               << " key=" << ev->key()
-               << endl;
+       LYXERR(Debug::KEY, " count: " << ev->count()
+               << " text: " << fromqstr(ev->text())
+               << " isAutoRepeat: " << ev->isAutoRepeat() << " key: " << ev->key());
 
        KeySymbol sym;
        setKeySymbol(&sym, ev);
@@ -441,7 +671,7 @@ void GuiWorkArea::doubleClickTimeout()
 
 void GuiWorkArea::mouseDoubleClickEvent(QMouseEvent * ev)
 {
-       dc_event_ = double_click(ev);
+       dc_event_ = DoubleClick(ev);
        QTimer::singleShot(QApplication::doubleClickInterval(), this,
                           SLOT(doubleClickTimeout()));
        FuncRequest cmd(LFUN_MOUSE_DOUBLE,
@@ -467,21 +697,16 @@ void GuiWorkArea::update(int x, int y, int w, int h)
 void GuiWorkArea::paintEvent(QPaintEvent * ev)
 {
        QRect const rc = ev->rect();
-       /*
-       LYXERR(Debug::PAINTING) << "paintEvent begin: x: " << rc.x()
-               << " y: " << rc.y()
-               << " w: " << rc.width()
-               << " h: " << rc.height() << endl;
-       */
+       // LYXERR(Debug::PAINTING, "paintEvent begin: x: " << rc.x()
+       //      << " y: " << rc.y() << " w: " << rc.width() << " h: " << rc.height());
 
        if (need_resize_) {
                verticalScrollBar()->setPageStep(viewport()->height());
                screen_ = QPixmap(viewport()->width(), viewport()->height());
                resizeBufferView();
                updateScreen();
-               WorkArea::hideCursor();
-               WorkArea::showCursor();
-               need_resize_ = false;
+               hideCursor();
+               showCursor();
        }
 
        QPainter pain(viewport());
@@ -490,17 +715,9 @@ void GuiWorkArea::paintEvent(QPaintEvent * ev)
 }
 
 
-void GuiWorkArea::expose(int x, int y, int w, int h)
-{
-       updateScreen();
-       update(x, y, w, h);
-}
-
-
 void GuiWorkArea::updateScreen()
 {
        GuiPainter pain(&screen_);
-       verticalScrollBar()->show();
        buffer_view_->draw(pain);
 }
 
@@ -508,7 +725,7 @@ void GuiWorkArea::updateScreen()
 void GuiWorkArea::showCursor(int x, int y, int h, CursorShape shape)
 {
        if (schedule_redraw_) {
-               buffer_view_->updateMetrics(false);
+               buffer_view_->updateMetrics();
                updateScreen();
                viewport()->update(QRect(0, 0, viewport()->width(), viewport()->height()));
                schedule_redraw_ = false;
@@ -540,15 +757,13 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
 
        if (!commit_string.isEmpty()) {
 
-               LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
-                       << " preeditString =" << fromqstr(e->preeditString())
-                       << " commitString  =" << fromqstr(e->commitString())
-                       << endl;
+               LYXERR(Debug::KEY, "preeditString: " << fromqstr(e->preeditString())
+                       << " commitString: " << fromqstr(e->commitString()));
 
                int key = 0;
 
                // FIXME Iwami 04/01/07: we should take care also of UTF16 surrogates here.
-               for (int i = 0; i < commit_string.size(); ++i) {
+               for (int i = 0; i != commit_string.size(); ++i) {
                        QKeyEvent ev(QEvent::KeyPress, key, Qt::NoModifier, commit_string[i]);
                        keyPressEvent(&ev);
                }
@@ -569,16 +784,16 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
        }
 
        GuiPainter pain(&screen_);
-       buffer_view_->updateMetrics(false);
+       buffer_view_->updateMetrics();
        buffer_view_->draw(pain);
-       Font font = buffer_view_->cursor().getFont();
+       FontInfo font = buffer_view_->cursor().getFont().fontInfo();
        FontMetrics const & fm = theFontMetrics(font);
        int height = fm.maxHeight();
        int cur_x = cursor_->rect().left();
        int cur_y = cursor_->rect().bottom();
 
        // redraw area of preedit string.
-       update(0, cur_y - height, GuiWorkArea::width(),
+       update(0, cur_y - height, viewport()->width(),
                (height + 1) * preedit_lines_);
 
        if (preedit_string.empty()) {
@@ -596,7 +811,7 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
        // cursor_pos : cursor position in preedit string.
        size_t cursor_pos = 0;
        bool cursor_is_visible = false;
-       for (int i = 0; i < att.size(); ++i) {
+       for (int i = 0; i != att.size(); ++i) {
                if (att.at(i).type == QInputMethodEvent::Cursor) {
                        cursor_pos = att.at(i).start;
                        cursor_is_visible = att.at(i).length != 0;
@@ -613,7 +828,7 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
        // rLength : selected string length in IM.
        size_t rLength = 0;
        if (cursor_pos < preedit_length) {
-               for (int i = 0; i < att.size(); ++i) {
+               for (int i = 0; i != att.size(); ++i) {
                        if (att.at(i).type == QInputMethodEvent::TextFormat) {
                                if (att.at(i).start <= int(cursor_pos)
                                        && int(cursor_pos) < att.at(i).start + att.at(i).length) {
@@ -641,7 +856,7 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
                ps = Painter::preedit_default;
 
                // if we reached the right extremity of the screen, go to next line.
-               if (cur_x + fm.width(typed_char) > GuiWorkArea::width() - right_margin) {
+               if (cur_x + fm.width(typed_char) > viewport()->width() - right_margin) {
                        cur_x = right_margin;
                        cur_y += height + 1;
                        ++preedit_lines_;
@@ -665,7 +880,7 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
        }
 
        // update the preedit string screen area.
-       update(0, cur_y - preedit_lines_*height, GuiWorkArea::width(),
+       update(0, cur_y - preedit_lines_*height, viewport()->width(),
                (height + 1) * preedit_lines_);
 
        // Don't forget to accept the event!
@@ -691,18 +906,58 @@ QVariant GuiWorkArea::inputMethodQuery(Qt::InputMethodQuery query) const
 }
 
 
+void GuiWorkArea::updateWindowTitle()
+{
+       docstring maximize_title;
+       docstring minimize_title;
+
+       Buffer & buf = buffer_view_->buffer();
+       FileName const fileName = buf.fileName();
+       if (!fileName.empty()) {
+               maximize_title = fileName.displayName(30);
+               minimize_title = from_utf8(fileName.onlyFileName());
+               if (!buf.isClean()) {
+                       maximize_title += _(" (changed)");
+                       minimize_title += char_type('*');
+               }
+               if (buf.isReadonly())
+                       maximize_title += _(" (read only)");
+       }
+
+       QString title = windowTitle();
+       QString new_title = toqstr(maximize_title);
+       if (title == new_title)
+               return;
+
+       QWidget::setWindowTitle(new_title);
+       QWidget::setWindowIconText(toqstr(minimize_title));
+       titleChanged(this);
+}
+
+
+void GuiWorkArea::setReadOnly(bool)
+{
+       updateWindowTitle();
+       if (this == lyx_view_->currentWorkArea())
+               lyx_view_->updateBufferDependent(false);
+}
+
+
 ////////////////////////////////////////////////////////////////////
 //
 // TabWorkArea 
 //
 ////////////////////////////////////////////////////////////////////
 
-TabWorkArea::TabWorkArea(QWidget * parent): QTabWidget(parent)
+TabWorkArea::TabWorkArea(QWidget * parent) : QTabWidget(parent)
 {
        QPalette pal = palette();
-       pal.setColor(QPalette::Active, QPalette::Button, pal.color(QPalette::Active, QPalette::Window));
-       pal.setColor(QPalette::Disabled, QPalette::Button, pal.color(QPalette::Disabled, QPalette::Window));
-       pal.setColor(QPalette::Inactive, QPalette::Button, pal.color(QPalette::Inactive, QPalette::Window));
+       pal.setColor(QPalette::Active, QPalette::Button,
+               pal.color(QPalette::Active, QPalette::Window));
+       pal.setColor(QPalette::Disabled, QPalette::Button,
+               pal.color(QPalette::Disabled, QPalette::Window));
+       pal.setColor(QPalette::Inactive, QPalette::Button,
+               pal.color(QPalette::Inactive, QPalette::Window));
 
        QToolButton * closeTabButton = new QToolButton(this);
     closeTabButton->setPalette(pal);
@@ -719,14 +974,13 @@ TabWorkArea::TabWorkArea(QWidget * parent): QTabWidget(parent)
                this, SLOT(closeCurrentTab()));
 
        setCornerWidget(closeTabButton);
-#if QT_VERSION >= 0x040200
        setUsesScrollButtons(true);
-#endif
 }
 
 
 void TabWorkArea::showBar(bool show)
 {
+       tabBar()->setEnabled(show);
        tabBar()->setVisible(show);
 }
 
@@ -784,6 +1038,22 @@ bool TabWorkArea::setCurrentWorkArea(GuiWorkArea * work_area)
 }
 
 
+GuiWorkArea * TabWorkArea::addWorkArea(Buffer & buffer, GuiView & view)
+{
+       GuiWorkArea * wa = new GuiWorkArea(buffer, view);
+       wa->setUpdatesEnabled(false);
+       // Hide tabbar if there's no tab (avoid a resize and a flashing tabbar
+       // when hiding it again below).
+       showBar(count() > 0);
+       addTab(wa, wa->windowTitle());
+       QObject::connect(wa, SIGNAL(titleChanged(GuiWorkArea *)),
+               this, SLOT(updateTabText(GuiWorkArea *)));
+       // Hide tabbar if there's only one tab.
+       showBar(count() > 1);
+       return wa;
+}
+
+
 bool TabWorkArea::removeWorkArea(GuiWorkArea * work_area)
 {
        BOOST_ASSERT(work_area);
@@ -810,16 +1080,16 @@ void TabWorkArea::on_currentTabChanged(int i)
        GuiWorkArea * wa = dynamic_cast<GuiWorkArea *>(widget(i));
        BOOST_ASSERT(wa);
        BufferView & bv = wa->bufferView();
-       bv.updateMetrics(false);
        bv.cursor().fixIfBroken();
+       bv.updateMetrics();
        wa->setUpdatesEnabled(true);
        wa->redraw();
        wa->setFocus();
        ///
        currentWorkAreaChanged(wa);
 
-       LYXERR(Debug::GUI) << "currentTabChanged " << i
-               << "File" << bv.buffer().absFileName() << endl;
+       LYXERR(Debug::GUI, "currentTabChanged " << i
+               << "File" << bv.buffer().absFileName());
 }
 
 
@@ -828,6 +1098,15 @@ void TabWorkArea::closeCurrentTab()
        lyx::dispatch(FuncRequest(LFUN_BUFFER_CLOSE));
 }
 
+
+void TabWorkArea::updateTabText(GuiWorkArea * wa)
+{
+       int const i = indexOf(wa);
+       if (i < 0)
+               return;
+       setTabText(i, wa->windowTitle());
+}
+
 } // namespace frontend
 } // namespace lyx