]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiWorkArea.cpp
Fix the tab ordering of GuiDocument components.
[lyx.git] / src / frontends / qt4 / GuiWorkArea.cpp
index 9c4d306a65b78a1d7aa63c364cb850e6bfafe7ed..026c7699db10dbf98d0ece4c1d1c698a71bc4f2d 100644 (file)
@@ -37,6 +37,7 @@
 #include "LyXVC.h"
 #include "qt_helpers.h"
 #include "Text.h"
+#include "TextMetrics.h"
 #include "version.h"
 
 #include "graphics/GraphicsImage.h"
@@ -46,6 +47,7 @@
 #include "support/debug.h"
 #include "support/gettext.h"
 #include "support/FileName.h"
+#include "support/lassert.h"
 
 #include "frontends/Application.h"
 #include "frontends/FontMetrics.h"
 #include <QToolTip>
 #include <QMenuBar>
 
-#include <boost/bind.hpp>
+#include "support/bind.h"
 
 #include <cmath>
 
-#ifdef Q_WS_X11
-#include <QX11Info>
-extern "C" int XEventsQueued(Display *display, int mode);
-#endif
-
-#ifdef Q_WS_WIN
-int const CursorWidth = 2;
-#else
-int const CursorWidth = 1;
-#endif
 int const TabIndicatorWidth = 3;
 
 #undef KeyPress
@@ -132,7 +124,9 @@ namespace frontend {
 
 class CursorWidget {
 public:
-       CursorWidget() {}
+       CursorWidget() {
+               recomputeWidth();
+       }
 
        void draw(QPainter & painter)
        {
@@ -144,8 +138,8 @@ public:
                int r = rect_.right() - x_;
                int bot = rect_.bottom();
 
-               // draw vertica linel
-               painter.fillRect(x_, y, CursorWidth, rect_.height(), color_);
+               // draw vertical line
+               painter.fillRect(x_, y, cursor_width_, rect_.height(), color_);
 
                // draw RTL/LTR indication
                painter.setPen(color_);
@@ -153,7 +147,7 @@ public:
                        if (rtl_)
                                painter.drawLine(x_, bot, x_ - l, bot);
                        else
-                               painter.drawLine(x_, bot, x_ + CursorWidth + r, bot);
+                               painter.drawLine(x_, bot, x_ + cursor_width_ + r, bot);
                }
 
                // draw completion triangle
@@ -164,8 +158,8 @@ public:
                                painter.drawLine(x_ - 1, m - d, x_ - 1 - d, m);
                                painter.drawLine(x_ - 1, m + d, x_ - 1 - d, m);
                        } else {
-                               painter.drawLine(x_ + CursorWidth, m - d, x_ + CursorWidth + d, m);
-                               painter.drawLine(x_ + CursorWidth, m + d, x_ + CursorWidth + d, m);
+                               painter.drawLine(x_ + cursor_width_, m - d, x_ + cursor_width_ + d, m);
+                               painter.drawLine(x_ + cursor_width_, m + d, x_ + cursor_width_ + d, m);
                        }
                }
        }
@@ -200,11 +194,17 @@ public:
                }
 
                // compute overall rectangle
-               rect_ = QRect(x - l, y, CursorWidth + r + l, h);
+               rect_ = QRect(x - l, y, cursor_width_ + r + l, h);
        }
 
        void show(bool set_show = true) { show_ = set_show; }
        void hide() { show_ = false; }
+       int cursorWidth() const { return cursor_width_; }
+       void recomputeWidth() {
+               cursor_width_ = lyxrc.cursor_width
+                       ? lyxrc.cursor_width 
+                       : 1 + int((lyxrc.zoom + 50) / 200.0);
+       }
 
        QRect const & rect() { return rect_; }
 
@@ -223,14 +223,15 @@ private:
        QRect rect_;
        /// x position (were the vertical line is drawn)
        int x_;
+       
+       int cursor_width_;
 };
 
 
 // This is a 'heartbeat' generating synthetic mouse move events when the
 // cursor is at the top or bottom edge of the viewport. One scroll per 0.2 s
 SyntheticMouseEvent::SyntheticMouseEvent()
-       : timeout(200), restart_timeout(true),
-         x_old(-1), y_old(-1), min_scrollbar_old(-1), max_scrollbar_old(-1)
+       : timeout(200), restart_timeout(true)
 {}
 
 
@@ -238,8 +239,7 @@ GuiWorkArea::GuiWorkArea(QWidget *)
        : buffer_view_(0), lyx_view_(0),
        cursor_visible_(false),
        need_resize_(false), schedule_redraw_(false),
-       preedit_lines_(1), completer_(new GuiCompleter(this, this)),
-       context_target_pos_()
+       preedit_lines_(1), completer_(new GuiCompleter(this, this))
 {
 }
 
@@ -248,8 +248,7 @@ GuiWorkArea::GuiWorkArea(Buffer & buffer, GuiView & gv)
        : buffer_view_(0), read_only_(buffer.isReadonly()), lyx_view_(0),
        cursor_visible_(false),
        need_resize_(false), schedule_redraw_(false),
-       preedit_lines_(1), completer_(new GuiCompleter(this, this)),
-       context_target_pos_()
+       preedit_lines_(1), completer_(new GuiCompleter(this, this))
 {
        setGuiView(gv);
        setBuffer(buffer);
@@ -293,10 +292,10 @@ void GuiWorkArea::init()
 
        setFocusPolicy(Qt::StrongFocus);
 
-       viewport()->setCursor(Qt::IBeamCursor);
+       setCursorShape(Qt::IBeamCursor);
 
        synthetic_mouse_event_.timeout.timeout.connect(
-               boost::bind(&GuiWorkArea::generateSyntheticMouseEvent,
+               bind(&GuiWorkArea::generateSyntheticMouseEvent,
                                        this));
 
        // Initialize the vertical Scroll Bar
@@ -325,6 +324,25 @@ GuiWorkArea::~GuiWorkArea()
 }
 
 
+Qt::CursorShape GuiWorkArea::cursorShape() const
+{
+       return viewport()->cursor().shape();
+}
+
+
+void GuiWorkArea::setCursorShape(Qt::CursorShape shape)
+{
+       viewport()->setCursor(shape);
+}
+
+
+void GuiWorkArea::updateCursorShape()
+{
+       setCursorShape(buffer_view_->clickableInset() 
+               ? Qt::PointingHandCursor : Qt::IBeamCursor);
+}
+
+
 void GuiWorkArea::setGuiView(GuiView & gv)
 {
        lyx_view_ = &gv;
@@ -396,6 +414,10 @@ void GuiWorkArea::stopBlinkingCursor()
 
 void GuiWorkArea::startBlinkingCursor()
 {
+       // do not show the cursor if the view is busy
+       if (view().busy())
+               return;
+
        Point p;
        int h = 0;
        buffer_view_->cursorPosAndHeight(p, h);
@@ -425,6 +447,7 @@ void GuiWorkArea::redraw(bool update_metrics)
        if (update_metrics || lyx_view_ != guiApp->currentView()
                || lyx_view_->currentWorkArea() != this) {
                // FIXME: it would be nice to optimize for the off-screen case.
+               buffer_view_->cursor().fixIfBroken();
                buffer_view_->updateMetrics();
                buffer_view_->cursor().fixIfBroken();
        }
@@ -449,6 +472,8 @@ void GuiWorkArea::redraw(bool update_metrics)
                buffer_view_->coordCache().dump();
 
        setReadOnly(buffer_view_->buffer().isReadonly());
+
+       updateCursorShape();
 }
 
 
@@ -472,7 +497,7 @@ void GuiWorkArea::processKeySym(KeySymbol const & key, KeyModifier mod)
 void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
 {
        // Handle drag&drop
-       if (cmd0.action == LFUN_FILE_OPEN) {
+       if (cmd0.action() == LFUN_FILE_OPEN) {
                DispatchResult dr;
                lyx_view_->dispatch(cmd0, dr);
                return;
@@ -480,7 +505,7 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
 
        FuncRequest cmd;
 
-       if (cmd0.action == LFUN_MOUSE_PRESS) {
+       if (cmd0.action() == LFUN_MOUSE_PRESS) {
                if (mod == ShiftModifier)
                        cmd = FuncRequest(cmd0, "region-select");
                else if (mod == ControlModifier)
@@ -492,7 +517,7 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
                cmd = cmd0;
 
        bool const notJustMovingTheMouse =
-               cmd.action != LFUN_MOUSE_MOTION || cmd.button() != mouse_button::none;
+               cmd.action() != LFUN_MOUSE_MOTION || cmd.button() != mouse_button::none;
 
        // In order to avoid bad surprise in the middle of an operation, we better stop
        // the blinking cursor.
@@ -502,7 +527,7 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
        buffer_view_->mouseEventDispatch(cmd);
 
        // Skip these when selecting
-       if (cmd.action != LFUN_MOUSE_MOTION) {
+       if (cmd.action() != LFUN_MOUSE_MOTION) {
                completer_->updateVisibility(false, false);
                lyx_view_->updateDialogs();
                lyx_view_->updateStatusBar();
@@ -518,6 +543,8 @@ void GuiWorkArea::dispatch(FuncRequest const & cmd0, KeyModifier mod)
                // Show the cursor immediately after any operation
                startBlinkingCursor();
        }
+
+       updateCursorShape();
 }
 
 
@@ -579,6 +606,7 @@ void GuiWorkArea::showCursor()
                && !completer_->popupVisible()
                && !completer_->inlineVisible();
        cursor_visible_ = true;
+       cursor_->recomputeWidth();
        showCursor(p.x_, p.y_, h, l_shape, isrtl, completable);
 }
 
@@ -619,7 +647,7 @@ void GuiWorkArea::updateScrollbar()
 void GuiWorkArea::scrollTo(int value)
 {
        stopBlinkingCursor();
-       buffer_view_->scrollDocView(value);
+       buffer_view_->scrollDocView(value, true);
 
        if (lyxrc.cursor_follows_scrollbar) {
                buffer_view_->setCursorFromScrollbar();
@@ -655,11 +683,14 @@ bool GuiWorkArea::event(QEvent * e)
                // which are otherwise reserved to focus switching between controls
                // within a dialog.
                QKeyEvent * ke = static_cast<QKeyEvent*>(e);
-               if ((ke->key() != Qt::Key_Tab && ke->key() != Qt::Key_Backtab)
-                       || ke->modifiers() & Qt::ControlModifier)
-                       return QAbstractScrollArea::event(e);
-               keyPressEvent(ke);
-               return true;
+               if ((ke->key() == Qt::Key_Tab && ke->modifiers() == Qt::NoModifier)
+                       || (ke->key() == Qt::Key_Backtab && (
+                               ke->modifiers() == Qt::ShiftModifier
+                               || ke->modifiers() == Qt::NoModifier))) {
+                       keyPressEvent(ke);
+                       return true;
+               }
+               return QAbstractScrollArea::event(e);
        }
 
        default:
@@ -671,31 +702,36 @@ bool GuiWorkArea::event(QEvent * e)
 
 void GuiWorkArea::contextMenuEvent(QContextMenuEvent * e)
 {
-       QPoint pos;
+       docstring name;
        if (e->reason() == QContextMenuEvent::Mouse)
-               // the position is set on mouse press
-               pos = context_target_pos_;
-       else
-               pos = e->pos();
-       Cursor const & cur = buffer_view_->cursor();
-       if (e->reason() == QContextMenuEvent::Keyboard && cur.inTexted()) {
-               // Do not access the context menu of math right in front of before
-               // the cursor. This does not work when the cursor is in text.
-               Inset * inset = cur.paragraph().getInset(cur.pos());
-               if (inset && inset->asInsetMath())
-                       --pos.rx();
-               else if (cur.pos() > 0) {
-                       Inset * inset = cur.paragraph().getInset(cur.pos() - 1);
-                       if (inset)
-                               ++pos.rx();
+               // the menu name is set on mouse press
+               name = context_menu_name_;
+       else {
+               QPoint pos = e->pos();
+               Cursor const & cur = buffer_view_->cursor();
+               if (e->reason() == QContextMenuEvent::Keyboard && cur.inTexted()) {
+                       // Do not access the context menu of math right in front of before
+                       // the cursor. This does not work when the cursor is in text.
+                       Inset * inset = cur.paragraph().getInset(cur.pos());
+                       if (inset && inset->asInsetMath())
+                               --pos.rx();
+                       else if (cur.pos() > 0) {
+                               Inset * inset = cur.paragraph().getInset(cur.pos() - 1);
+                               if (inset)
+                                       ++pos.rx();
+                       }
                }
+               name = buffer_view_->contextMenu(pos.x(), pos.y());
        }
-       docstring name = buffer_view_->contextMenu(pos.x(), pos.y());
+       
        if (name.empty()) {
                QAbstractScrollArea::contextMenuEvent(e);
                return;
        }
-       QMenu * menu = guiApp->menus().menu(toqstr(name), *lyx_view_);
+       // always show mnemonics when the keyboard is used to show the context menu
+       // FIXME: This should be fixed in Qt itself
+       bool const keyboard = (e->reason() == QContextMenuEvent::Keyboard);
+       QMenu * menu = guiApp->menus().menu(toqstr(name), *lyx_view_, keyboard);
        if (!menu) {
                QAbstractScrollArea::contextMenuEvent(e);
                return;
@@ -737,14 +773,20 @@ void GuiWorkArea::mousePressEvent(QMouseEvent * e)
                return;
        }
 
-       if (e->button() == Qt::RightButton)
-               context_target_pos_ = e->pos();
-
        inputContext()->reset();
 
        FuncRequest const cmd(LFUN_MOUSE_PRESS, e->x(), e->y(),
                q_button_state(e->button()));
        dispatch(cmd, q_key_state(e->modifiers()));
+
+       // Save the context menu on mouse press, because also the mouse
+       // cursor is set on mouse press. Afterwards, we can either release
+       // the mousebutton somewhere else, or the cursor might have moved
+       // due to the DEPM. We need to do this after the mouse has been
+       // set in dispatch(), because the selection state might change.
+       if (e->button() == Qt::RightButton)
+               context_menu_name_ = buffer_view_->contextMenu(e->x(), e->y());
+
        e->accept();
 }
 
@@ -771,18 +813,19 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e)
        e->accept();
 
        // If we're above or below the work area...
-       if (e->y() <= 20 || e->y() >= viewport()->height() - 20) {
+       if ((e->y() <= 20 || e->y() >= viewport()->height() - 20)
+                       && e->buttons() == mouse_button::button1) {
                // Make sure only a synthetic event can cause a page scroll,
                // so they come at a steady rate:
                if (e->y() <= 20)
                        // _Force_ a scroll up:
-                       cmd.y = -40;
+                       cmd.set_y(e->y() - 21);
                else
-                       cmd.y = viewport()->height();
+                       cmd.set_y(e->y() + 21);
                // Store the event, to be handled when the timeout expires.
                synthetic_mouse_event_.cmd = cmd;
 
-               if (synthetic_mouse_event_.timeout.running())
+               if (synthetic_mouse_event_.timeout.running()) {
                        // Discard the event. Note that it _may_ be handled
                        // when the timeout expires if
                        // synthetic_mouse_event_.cmd has not been overwritten.
@@ -791,7 +834,8 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e)
                        // occurred after the one used to start the timeout
                        // in the first place.
                        return;
-
+               }
+               
                synthetic_mouse_event_.restart_timeout = true;
                synthetic_mouse_event_.timeout.start();
                // Fall through to handle this event...
@@ -807,24 +851,6 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e)
                synthetic_mouse_event_.restart_timeout = false;
                return;
        }
-
-       // Has anything changed on-screen since the last QMouseEvent
-       // was received?
-       if (e->x() == synthetic_mouse_event_.x_old
-               && e->y() == synthetic_mouse_event_.y_old
-               && synthetic_mouse_event_.min_scrollbar_old == verticalScrollBar()->minimum()
-               && synthetic_mouse_event_.max_scrollbar_old == verticalScrollBar()->maximum()) {
-               // Nothing changed on-screen since the last QMouseEvent.
-               return;
-       }
-
-       // Yes something has changed. Store the params used to check this.
-       synthetic_mouse_event_.x_old = e->x();
-       synthetic_mouse_event_.y_old = e->y();
-       synthetic_mouse_event_.min_scrollbar_old = verticalScrollBar()->minimum();
-       synthetic_mouse_event_.max_scrollbar_old = verticalScrollBar()->maximum();
-
-       // ... and dispatch the event to the LyX core.
        dispatch(cmd);
 }
 
@@ -833,9 +859,26 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev)
 {
        // Wheel rotation by one notch results in a delta() of 120 (see
        // documentation of QWheelEvent)
-       int const delta = ev->delta() / 120;
-       if (ev->modifiers() & Qt::ControlModifier) {
-               docstring arg = convert<docstring>(5 * delta);
+       double const delta = ev->delta() / 120.0;
+       bool zoom = false;
+       switch (lyxrc.scroll_wheel_zoom) {
+       case LyXRC::SCROLL_WHEEL_ZOOM_CTRL:
+               zoom = ev->modifiers() & Qt::ControlModifier;
+               zoom &= !(ev->modifiers() & (Qt::ShiftModifier | Qt::AltModifier));
+               break;
+       case LyXRC::SCROLL_WHEEL_ZOOM_SHIFT:
+               zoom = ev->modifiers() & Qt::ShiftModifier;
+               zoom &= !(ev->modifiers() & (Qt::ControlModifier | Qt::AltModifier));
+               break;
+       case LyXRC::SCROLL_WHEEL_ZOOM_ALT:
+               zoom = ev->modifiers() & Qt::AltModifier;
+               zoom &= !(ev->modifiers() & (Qt::ShiftModifier | Qt::ControlModifier));
+               break;
+       case LyXRC::SCROLL_WHEEL_ZOOM_OFF:
+               break;
+       }
+       if (zoom) {
+               docstring arg = convert<docstring>(int(5 * delta));
                lyx::dispatch(FuncRequest(LFUN_BUFFER_ZOOM_IN, arg));
                return;
        }
@@ -847,11 +890,8 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev)
        int scroll_value = lines > page_step
                ? page_step : lines * verticalScrollBar()->singleStep();
 
-       // Take into account the rotation.
-       scroll_value *= delta;
-
-       // Take into account user preference.
-       scroll_value = int(scroll_value * lyxrc.mouse_wheel_speed);
+       // Take into account the rotation and the user preferences.
+       scroll_value = int(scroll_value * delta * lyxrc.mouse_wheel_speed);
        LYXERR(Debug::SCROLLING, "wheelScrollLines = " << lines
                        << " delta = " << delta << " scroll_value = " << scroll_value
                        << " page_step = " << page_step);
@@ -864,23 +904,85 @@ void GuiWorkArea::wheelEvent(QWheelEvent * ev)
 
 void GuiWorkArea::generateSyntheticMouseEvent()
 {
+       int const e_y = synthetic_mouse_event_.cmd.y();
+       int const wh = buffer_view_->workHeight();
+       bool const up = e_y < 0;
+       bool const down = e_y > wh;
+
        // Set things off to generate the _next_ 'pseudo' event.
-       if (synthetic_mouse_event_.restart_timeout)
+       int step = 50;
+       if (synthetic_mouse_event_.restart_timeout) {
+               // This is some magic formulae to determine the speed
+               // of scrolling related to the position of the mouse.
+               int time = 200;
+               if (up || down) {
+                       int dist = up ? -e_y : e_y - wh;
+                       time = max(min(200, 250000 / (dist * dist)), 1) ;
+                       
+                       if (time < 40) {
+                               step = 80000 / (time * time);
+                               time = 40;
+                       }
+               }
+               synthetic_mouse_event_.timeout.setTimeout(time);
                synthetic_mouse_event_.timeout.start();
+       }
 
-       // Has anything changed on-screen since the last timeout signal
-       // was received?
-       int const min_scrollbar = verticalScrollBar()->minimum();
-       int const max_scrollbar = verticalScrollBar()->maximum();
-       if (min_scrollbar == synthetic_mouse_event_.min_scrollbar_old
-               && max_scrollbar == synthetic_mouse_event_.max_scrollbar_old) {
+       // Can we scroll further ?
+       int const value = verticalScrollBar()->value();
+       if (value == verticalScrollBar()->maximum()
+                 || value == verticalScrollBar()->minimum()) {
+               synthetic_mouse_event_.timeout.stop();
                return;
        }
-       // Yes it has. Store the params used to check this.
-       synthetic_mouse_event_.min_scrollbar_old = min_scrollbar;
-       synthetic_mouse_event_.max_scrollbar_old = max_scrollbar;
-       // ... and dispatch the event to the LyX core.
-       dispatch(synthetic_mouse_event_.cmd);
+
+       // Scroll
+       if (step <= 2 * wh) {
+               buffer_view_->scroll(up ? -step : step);
+               buffer_view_->updateMetrics();
+       } else {
+               buffer_view_->scrollDocView(value + up ? -step : step, false);
+       }
+
+       // In which paragraph do we have to set the cursor ?
+       Cursor & cur = buffer_view_->cursor();
+       // FIXME: we don't know howto handle math.
+       Text * text = cur.text();
+       if (!text)
+               return;
+       TextMetrics const & tm = buffer_view_->textMetrics(text);
+
+       pair<pit_type, const ParagraphMetrics *> p = up ? tm.first() : tm.last();
+       ParagraphMetrics const & pm = *p.second;
+       pit_type const pit = p.first;
+
+       if (pm.rows().empty())
+               return;
+
+       // Find the row at which we set the cursor.
+       RowList::const_iterator rit = pm.rows().begin();
+       RowList::const_iterator rlast = pm.rows().end();
+       int yy = pm.position() - pm.ascent();
+       for (--rlast; rit != rlast; ++rit) {
+               int h = rit->height();
+               if ((up && yy + h > 0)
+                         || (!up && yy + h > wh - defaultRowHeight()))
+                       break;
+               yy += h;
+       }
+       
+       // Find the position of the cursor
+       bool bound;
+       int x = synthetic_mouse_event_.cmd.x();
+       pos_type const pos = rit->pos() + tm.getColumnNearX(pit, *rit, x, bound);
+
+       // Set the cursor
+       cur.pit() = pit;
+       cur.pos() = pos;
+       cur.boundary(bound);
+
+       buffer_view_->buffer().changed(false);
+       return;
 }
 
 
@@ -911,18 +1013,38 @@ void GuiWorkArea::keyPressEvent(QKeyEvent * ev)
 
        // do nothing if there are other events
        // (the auto repeated events come too fast)
-       // \todo FIXME: remove hard coded Qt keys, process the key binding
+       // it looks like this is only needed on X11
 #ifdef Q_WS_X11
-       if (XEventsQueued(QX11Info::display(), 0) > 1 && ev->isAutoRepeat()
-                       && (Qt::Key_PageDown || Qt::Key_PageUp)) {
-               LYXERR(Debug::KEY, "system is busy: scroll key event ignored");
-               ev->ignore();
-               return;
+       if (qApp->hasPendingEvents() && ev->isAutoRepeat()) {
+               switch (ev->key()) {
+               case Qt::Key_PageDown:
+               case Qt::Key_PageUp:
+               case Qt::Key_Left:
+               case Qt::Key_Right:
+               case Qt::Key_Up:
+               case Qt::Key_Down:
+                       LYXERR(Debug::KEY, "system is busy: scroll key event ignored");
+                       ev->ignore();
+                       return;
+               }
        }
 #endif
 
+       KeyModifier m = q_key_state(ev->modifiers());
+
+       std::string str;
+       if (m & ShiftModifier)
+               str += "Shift-";
+       if (m & ControlModifier)
+               str += "Control-";
+       if (m & AltModifier)
+               str += "Alt-";
+       if (m & MetaModifier)
+               str += "Meta-";
+       
        LYXERR(Debug::KEY, " count: " << ev->count() << " text: " << ev->text()
-               << " isAutoRepeat: " << ev->isAutoRepeat() << " key: " << ev->key());
+               << " isAutoRepeat: " << ev->isAutoRepeat() << " key: " << ev->key()
+               << " keyState: " << str);
 
        KeySymbol sym;
        setKeySymbol(&sym, ev);
@@ -964,7 +1086,7 @@ void GuiWorkArea::resizeEvent(QResizeEvent * ev)
 
 void GuiWorkArea::update(int x, int y, int w, int h)
 {
-       viewport()->repaint(x, y, w, h);
+       viewport()->update(x, y, w, h);
 }
 
 
@@ -1194,11 +1316,11 @@ void GuiWorkArea::updateWindowTitle()
        docstring maximize_title;
        docstring minimize_title;
 
-       Buffer & buf = buffer_view_->buffer();
-       FileName const fileName = buf.fileName();
-       if (!fileName.empty()) {
-               maximize_title = fileName.displayName(30);
-               minimize_title = from_utf8(fileName.onlyFileName());
+       Buffer const & buf = buffer_view_->buffer();
+       FileName const file_name = buf.fileName();
+       if (!file_name.empty()) {
+               maximize_title = file_name.displayName(130);
+               minimize_title = from_utf8(file_name.onlyFileName());
                if (buf.lyxvc().inUse()) {
                        if (buf.lyxvc().locking())
                                maximize_title +=  _(" (version control, locking)");
@@ -1213,14 +1335,12 @@ void GuiWorkArea::updateWindowTitle()
                        maximize_title += _(" (read only)");
        }
 
-       QString title = windowTitle();
-       QString new_title = toqstr(maximize_title);
-       if (title == new_title)
-               return;
-
-       QWidget::setWindowTitle(new_title);
-       QWidget::setWindowIconText(toqstr(minimize_title));
-       titleChanged(this);
+       QString const new_title = toqstr(maximize_title);
+       if (new_title != windowTitle()) {
+               QWidget::setWindowTitle(new_title);
+               QWidget::setWindowIconText(toqstr(minimize_title));
+               titleChanged(this);
+       }
 }
 
 
@@ -1251,7 +1371,7 @@ bool GuiWorkArea::isFullScreen()
 EmbeddedWorkArea::EmbeddedWorkArea(QWidget * w): GuiWorkArea(w)
 {
        buffer_ = theBufferList().newBuffer(
-               support::FileName::tempName().absFilename() + "_embedded.internal");
+               support::FileName::tempName().absFileName() + "_embedded.internal");
        buffer_->setUnnamed(true);
        buffer_->setFullyLoaded(true);
        setBuffer(*buffer_);
@@ -1262,7 +1382,7 @@ EmbeddedWorkArea::EmbeddedWorkArea(QWidget * w): GuiWorkArea(w)
 EmbeddedWorkArea::~EmbeddedWorkArea()
 {
        // No need to destroy buffer and bufferview here, because it is done
-       // in theBuffeerList() destruction loop at application exit
+       // in theBufferList() destruction loop at application exit
 }
 
 
@@ -1391,10 +1511,24 @@ TabWorkArea::TabWorkArea(QWidget * parent)
 }
 
 
+void TabWorkArea::mouseDoubleClickEvent(QMouseEvent * event)
+{
+       if (event->button() != Qt::LeftButton)
+               return;
+
+       // return early if double click on existing tabs
+       for (int i = 0; i < count(); ++i)
+               if (tabBar()->tabRect(i).contains(event->pos()))
+                       return;
+
+       dispatch(FuncRequest(LFUN_BUFFER_NEW));
+}
+
+
 void TabWorkArea::setFullScreen(bool full_screen)
 {
        for (int i = 0; i != count(); ++i) {
-               if (GuiWorkArea * wa = dynamic_cast<GuiWorkArea *>(widget(i)))
+               if (GuiWorkArea * wa = workArea(i))
                        wa->setFullScreen(full_screen);
        }
 
@@ -1425,12 +1559,18 @@ GuiWorkArea * TabWorkArea::currentWorkArea()
 }
 
 
+GuiWorkArea * TabWorkArea::workArea(int index)
+{
+       return dynamic_cast<GuiWorkArea *>(widget(index));
+}
+
+
 GuiWorkArea * TabWorkArea::workArea(Buffer & buffer)
 {
        // FIXME: this method doesn't work if we have more than work area
        // showing the same buffer.
        for (int i = 0; i != count(); ++i) {
-               GuiWorkArea * wa = dynamic_cast<GuiWorkArea *>(widget(i));
+               GuiWorkArea * wa = workArea(i);
                LASSERT(wa, return 0);
                if (&wa->bufferView().buffer() == &buffer)
                        return wa;
@@ -1442,7 +1582,7 @@ GuiWorkArea * TabWorkArea::workArea(Buffer & buffer)
 void TabWorkArea::closeAll()
 {
        while (count()) {
-               GuiWorkArea * wa = dynamic_cast<GuiWorkArea *>(widget(0));
+               GuiWorkArea * wa = workArea(0);
                LASSERT(wa, /**/);
                removeTab(0);
                delete wa;
@@ -1525,7 +1665,7 @@ void TabWorkArea::on_currentTabChanged(int i)
        // returns e.g. on application destruction
        if (i == -1)
                return;
-       GuiWorkArea * wa = dynamic_cast<GuiWorkArea *>(widget(i));
+       GuiWorkArea * wa = workArea(i);
        LASSERT(wa, return);
        wa->setUpdatesEnabled(true);
        wa->redraw(true);
@@ -1544,7 +1684,7 @@ void TabWorkArea::closeCurrentBuffer()
        if (clicked_tab_ == -1)
                wa = currentWorkArea();
        else {
-               wa = dynamic_cast<GuiWorkArea *>(widget(clicked_tab_));
+               wa = workArea(clicked_tab_);
                LASSERT(wa, /**/);
        }
        wa->view().closeWorkArea(wa);
@@ -1557,7 +1697,7 @@ void TabWorkArea::hideCurrentTab()
        if (clicked_tab_ == -1)
                wa = currentWorkArea();
        else {
-               wa = dynamic_cast<GuiWorkArea *>(widget(clicked_tab_));
+               wa = workArea(clicked_tab_);
                LASSERT(wa, /**/);
        }
        wa->view().hideWorkArea(wa);
@@ -1571,7 +1711,7 @@ void TabWorkArea::closeTab(int index)
        if (index == -1)
                wa = currentWorkArea();
        else {
-               wa = dynamic_cast<GuiWorkArea *>(widget(index));
+               wa = workArea(index);
                LASSERT(wa, /**/);
        }
        wa->view().closeWorkArea(wa);
@@ -1682,7 +1822,7 @@ void TabWorkArea::updateTabTexts()
        // collect full names first: path into postfix, empty prefix and
        // filename without extension
        for (size_t i = 0; i < n; ++i) {
-               GuiWorkArea * i_wa = dynamic_cast<GuiWorkArea *>(widget(i));
+               GuiWorkArea * i_wa = workArea(i);
                FileName const fn = i_wa->bufferView().buffer().fileName();
                paths.push_back(DisplayPath(i, fn));
        }
@@ -1766,12 +1906,13 @@ void TabWorkArea::updateTabTexts()
 
        // set new tab titles
        for (It it = paths.begin(); it != paths.end(); ++it) {
-               GuiWorkArea * i_wa = dynamic_cast<GuiWorkArea *>(widget(it->tab()));
-               Buffer & buf = i_wa->bufferView().buffer();
+               int const tab_index = it->tab();
+               Buffer const & buf = workArea(tab_index)->bufferView().buffer();
+               QString tab_text = it->displayString();
                if (!buf.fileName().empty() && !buf.isClean())
-                       setTabText(it->tab(), it->displayString() + "*");
-               else
-                       setTabText(it->tab(), it->displayString());
+                       tab_text += "*";
+               setTabText(tab_index, tab_text);
+               setTabToolTip(tab_index, it->abs());
        }
 }